Re: [Qemu-devel] spidev with omap3 running on qemu

2012-11-01 Thread Peter Crosthwaite
On Sat, Oct 27, 2012 at 7:24 PM, johan marx pasj...@hotmail.com wrote: Hi Peter, Thanks for the quick reply. I'm building with qemu-linaro Hi Johan, Sorry about the delay. Ive had a quick browse of this tree. The OMAP spi work there is ahead of whats in mainline, but is still divergent from

Re: [Qemu-devel] ISA BIOS mapping for system flash emulation

2012-11-01 Thread Jan Kiszka
On 2012-11-01 03:55, Jordan Justen wrote: On Tue, Oct 30, 2012 at 11:14 PM, Jan Kiszka jan.kis...@web.de wrote: Hi Jordan, I was starring at pc_isa_bios_init and wondering why you are creating a copy of the system flash for the low ISA range instead of using an alias here as well, just like

[Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device

2012-11-01 Thread Lei Li
netdev_del assume that remove host network device. However, when try to remove a non-host network device by netdev_del, it will cause a segfault. The reson is that qmp_netdev_del is not checking for a NULL return for qemu_find_opts_err in case find_list did not find the netdev group to delete.

Re: [Qemu-devel] [RfC PATCH 3/5] usb/ehci: seperate out PCIisms

2012-11-01 Thread Gerd Hoffmann
Hi, -static int usb_ehci_initfn(PCIDevice *dev) +static void usb_ehci_initfn(EHCIState *s, DeviceState *dev) { -EHCIState *s = DO_UPCAST(EHCIState, dev, dev); +static int usb_ehci_pci_initfn(PCIDevice *dev) +{ +EHCIPCIState *i = DO_UPCAST(EHCIPCIState, pcidev, dev); Same as

Re: [Qemu-devel] On block interface types in general, IF_AHCI in particular

2012-11-01 Thread Gerd Hoffmann
Hi, The main drawback of if=ahci is, as pointed out by Markus, that you would have to provide both controllers on-board. I think a real ICH9 has the compatibility IDE controller on a separate PCI address from the SATA controller, so creating both of them is not really out of question. I

Re: [Qemu-devel] [RFC PATCH v3 00/19] ACPI memory hotplug

2012-11-01 Thread Vasilis Liaskovitis
On Wed, Oct 31, 2012 at 01:16:56PM +0200, Avi Kivity wrote: On 10/31/2012 12:58 PM, Stefan Hajnoczi wrote: On Fri, Sep 21, 2012 at 1:17 PM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is supported

[Qemu-devel] [PATCH V5 00/10] replace QEMUOptionParameter with QemuOpts parser

2012-11-01 Thread Dong Xu Wang
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 3 was changed according Paolo's comments. Patch 4-5: because qemu_opts_create can not fail while id is null, so create function

[Qemu-devel] [PATCH V5 06/10] create new function: qemu_opt_set_number

2012-11-01 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v4-v5: 1) Use g_strdup_printf. qemu-option.c | 22 ++ qemu-option.h |1 + 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 1303188..94557cf 100644 ---

[Qemu-devel] [PATCH V5 02/10] qemu-option: qemu_opts_validate(): fix duplicated code

2012-11-01 Thread Dong Xu Wang
Use opts_accepts_any() and find_desc_by_name(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-option.c b/qemu-option.c

[Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer

2012-11-01 Thread Dong Xu Wang
This patch will use QemuOpts related functions in block layer, add a member bdrv_create_options to BlockDriver struct, it will return a QemuOptsList pointer, which includes the image format's create options. And create options's primary consumer is block creating related functions, so modify them

[Qemu-devel] [PATCH V5 08/10] Create four opts list related functions

2012-11-01 Thread Dong Xu Wang
This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 90 + qemu-option.h

[Qemu-devel] [PATCH V5 10/10] remove QEMUOptionParameter related functions and struct

2012-11-01 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 285 - qemu-option.h | 32 --- 2 files changed, 0 insertions(+), 317 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 5dfbf35..560e44a 100644 ---

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-11-01 Thread Amit Shah
On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote: On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira wrote: I didn't take enough time to uderstand the code, so unfortunately I fear there is not much I could do to solve the problem, apart from trying your

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Gerd Hoffmann
On 10/31/12 13:53, Alon Levy wrote: I cannot find a reason we asserted that injecting interrupts happen only when the vm is running. This is right now the cause of spice crashing due to the new interface_client_set_capabilities being called when the vm is stopped, this happens if a user stops

[Qemu-devel] [PATCH V15 0/6] add-cow file format

2012-11-01 Thread Dong Xu Wang
It will introduce a new file format: add-cow. The add-cow file format makes it possible to perform copy-on-write on top of a raw disk image. When we know that no backing file clusters remain visible (e.g. we have streamed the entire image and copied all data from the backing file), then it is

[Qemu-devel] [PATCH V15 2/6] make path_has_protocol non static

2012-11-01 Thread Dong Xu Wang
We will use path_has_protocol outside block.c, so just make it public. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com --- block.c |2 +- block.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH V15 1/6] docs: document for add-cow file format

2012-11-01 Thread Dong Xu Wang
Document for add-cow format, the usage and spec of add-cow are introduced. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v14-v15: 1) Fix some typo and make sentences more readable. docs/specs/add-cow.txt | 154 1 files changed, 154

[Qemu-devel] [PATCH V15 6/6] qemu-iotests: add add-cow iotests support.

2012-11-01 Thread Dong Xu Wang
This patch will use qemu-iotests to test add-cow file format. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- tests/qemu-iotests/017 |2 +- tests/qemu-iotests/020 |2 +- tests/qemu-iotests/common|6 ++ tests/qemu-iotests/common.rc | 15 ++-

[Qemu-devel] [PATCH V15 4/6] rename qcow2-cache.c to block-cache.c

2012-11-01 Thread Dong Xu Wang
We will re-use qcow2-cache as block layer common cache code, so change its name and made some changes, define a struct named BlockTableType, pass BlockTableType and table size parameters to block cache initialization function. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH] hw/qxl: vaildate surface-data

2012-11-01 Thread Gerd Hoffmann
On 10/25/12 14:27, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com Looks sane at a quick glance. But: how far we wanna take this? Add checks to qxl for each and every assert() guests can trigger in spice-server? So we end up sanity-checking everything twice long-term? I think

[Qemu-devel] [PATCH V5 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-11-01 Thread Dong Xu Wang
It will set opt-str in qemu_opt_set_bool, without opt-str, there will be some potential bugs. These are uses of opt-str, and what happens when it isn't set: * qemu_opt_get(): returns NULL, which means not set. Bug can bite when value isn't the default value. * qemu_opt_parse(): passes NULL

[Qemu-devel] [RFC PATCH v3 0/3] use reset handlers to reload images

2012-11-01 Thread Olivia Yin
The current model of loader copy rom blobs and kept in memory until a reset occurs and waste host memory. This serial of patches uses private reset handlers to load from hard disk on reset, which could make loader framework more dynamic and reduce the memory consumption of QEMU process. Olivia

[Qemu-devel] [RFC PATCH v3 3/3] update rom_reset

2012-11-01 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index 0581c71..17908cf 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -738,11 +738,8 @@ static void rom_reset(void

[Qemu-devel] [RFC PATCH v3 1/3] define image_file_reset

2012-11-01 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index ba01ca6..a4c095e 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -56,6 +56,13 @@

[Qemu-devel] [PATCH V5 01/10] qemu-option: opt_set(): split it up into more functions

2012-11-01 Thread Dong Xu Wang
The new functions are opts_accepts_any() and find_desc_by_name(), which are also going to be used by qemu_opts_validate() (see next commit). This also makes opt_set() slightly more readable. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Dong Xu Wang

[Qemu-devel] [PATCH] net: fix bug in net_init_socket

2012-11-01 Thread Lei Li
Fix the problem that can not delete the udp socket. It's caused by passing udp model to net_socket_udp_init, but we do not have udp model in our model list. Pass the right model socket to init function. https://bugs.launchpad.net/qemu/+bug/1073585?comments=all Signed-off-by: Lei Li

Re: [Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device

2012-11-01 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 8:48 AM, Lei Li li...@linux.vnet.ibm.com wrote: netdev_del assume that remove host network device. However, when try to remove a non-host network device by netdev_del, it will cause a segfault. I recently sent a similar fix which forbids deleting non-netdev net clients

Re: [Qemu-devel] [PATCH] hw/qxl: vaildate surface-data

2012-11-01 Thread Alon Levy
On 10/25/12 14:27, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com Looks sane at a quick glance. But: how far we wanna take this? Add checks to qxl for each and every assert() guests can trigger in spice-server? So we end up sanity-checking everything twice long-term? I

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2012-11-01 Thread Stefan Hajnoczi
GTESTER check-qtest-i386 command timed out: 1200 seconds without output, attempting to kill The buildslave had a load average of 10 and was having trouble making progress. I have killed off qemu processes and hopefully things will work normally again. I also tested that make check terminates

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Alon Levy
On 10/31/12 13:53, Alon Levy wrote: I cannot find a reason we asserted that injecting interrupts happen only when the vm is running. This is right now the cause of spice crashing due to the new interface_client_set_capabilities being called when the vm is stopped, this happens if a

[Qemu-devel] [PATCH V15 5/6] add-cow file format core code.

2012-11-01 Thread Dong Xu Wang
add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block/Makefile.objs |1 + block/add-cow.c | 687 +++ block/add-cow.h |

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-01 Thread Stefan Hajnoczi
On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote: On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote: On Wed, Oct 31, 2012 at 10:57:24AM +0200, Michael S. Tsirkin wrote: On Wed, Oct 31, 2012 at 09:07:27AM +0100, Stefan Hajnoczi wrote: On Tue, Oct 30, 2012

[Qemu-devel] [PATCH V5 07/10] add def_print_str and use it in qemu_opts_print.

2012-11-01 Thread Dong Xu Wang
qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print will be used while using qemu-img create, it will produce the same output as previous code. The behavior of this function has changed: 1. Print every possible option, whether a value has been set or not. 2.

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Gerd Hoffmann
Hi, IMO spice-server must not call interface_client_set_capabilities when the vm is not running. After all we notify spice-server about the vm stop/start events for a reason ... OK, I agree that should be fixed, we can queue this until the vm starts running in spice-server. But having

[Qemu-devel] [PATCH V15 3/6] qed_read_string to bdrv_read_string

2012-11-01 Thread Dong Xu Wang
Make qed_read_string function to a common interface, so move it to block.c. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block.c | 27 +++ block.h |2 ++ block/qed.c | 34 -- 3 files changed, 33 insertions(+),

[Qemu-devel] [PATCH V5 05/10] use qemu_opts_create_nofail

2012-11-01 Thread Dong Xu Wang
We will use qemu_opts_create_nofail function, it can make code more readable. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- blockdev.c |2 +- hw/watchdog.c |2 +- qemu-config.c |4 ++-- qemu-img.c |2 +- qemu-sockets.c | 16 vl.c

Re: [Qemu-devel] [PATCH] net: fix bug in net_init_socket

2012-11-01 Thread Stefan Hajnoczi
On Thu, Nov 01, 2012 at 05:39:55PM +0800, Lei Li wrote: Fix the problem that can not delete the udp socket. It's caused by passing udp model to net_socket_udp_init, but we do not have udp model in our model list. Pass the right model socket to init function.

Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()

2012-11-01 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 02:34:12PM +0200, Stefan Hajnoczi wrote: The netdev_del command crashes when given a -net device, because it calls qemu_opts_del(NULL). Check that this is a -netdev before attempting to delete it and the QemuOpts. Note the subtle change from

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Gerd Hoffmann
On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! + */ +if (state != leftover) { +g_free(combined); +} This calls for

Re: [Qemu-devel] [PATCH 02/16] target-ppc: Rework storage of VPA registration state

2012-11-01 Thread Alexander Graf
On 30.10.2012, at 04:24, David Gibson wrote: With PAPR guests, hypercalls allow registration of the Virtual Processor Area (VPA), SLB shadow and dispatch trace log (DTL), each of which allow for certain communication between the guest and hypervisor. Currently, we store the addresses of the

Re: [Qemu-devel] [PATCH 4/8] usb-redir: Add support for input pipelining

2012-11-01 Thread Gerd Hoffmann
On 10/31/12 13:47, Hans de Goede wrote: +if (p-combined) { +iov_to_buf(p-combined-iov.iov, p-combined-iov.niov, + 0, buf, size); +} else { +usb_packet_copy(p, buf, size); +} Should we make usb_packet_copy friends aware

[Qemu-devel] [PATCH V5 04/10] introduce qemu_opts_create_nofail function

2012-11-01 Thread Dong Xu Wang
While id is NULL, qemu_opts_create can not fail, so ignore errors is fine. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- v4-v5: 1) Rewrite qemu_opts_create_nofail. qemu-option.c |9 + qemu-option.h |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [RFC PATCH v3 2/3] use reset handlers to reload kernel and initrd

2012-11-01 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 57 +++-- 1 files changed, 43 insertions(+), 14 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index a4c095e..0581c71 100644 --- a/hw/loader.c +++ b/hw/loader.c @@

Re: [Qemu-devel] [PATCH 05/16] pseries: Use #define for XICS base irq number

2012-11-01 Thread Alexander Graf
On 30.10.2012, at 04:25, David Gibson wrote: From: Ben Herrenschmidt b...@kernel.crashing.org Currently the lowest real irq number for the XICS irq controller (as opposed to numbers reserved for IPIs and other special purposes) is hard coded as 16 in two places - in xics_system_init() and

Re: [Qemu-devel] [PATCH 07/16] pseries: Move XICS initialization before cpu initialization

2012-11-01 Thread Alexander Graf
On 30.10.2012, at 04:25, David Gibson wrote: From: Ben Herrenschmidt b...@kernel.crashing.org Currently, the pseries machine initializes the cpus, then the XICS interrupt controller. However, to support the upcoming in-kernel XICS implementation we will need to initialize the irq

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Alon Levy
Hi, IMO spice-server must not call interface_client_set_capabilities when the vm is not running. After all we notify spice-server about the vm stop/start events for a reason ... OK, I agree that should be fixed, we can queue this until the vm starts running in spice-server. But

Re: [Qemu-devel] [0/16] pseries and PPC pending patches

2012-11-01 Thread Alexander Graf
On 30.10.2012, at 04:24, David Gibson wrote: Alex, Having updated for your latest merge upstream, here's my current pending set of pseries related patches. Note that 1/16 is an important bugfix reverting a broken patch of yours: old_portio is not gone, alas, so we still need the

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Gerd Hoffmann
Hi, This prevents a known abort on set_client_capabilities, that should be fixed in upstream, but it should also be checked against in qxl. Checks every other location that qxl_send_events is eventually possibly called Why check in all callers instead of qxl_send_events

[Qemu-devel] [PATCH 4/4] e1000: pre-initialize RAH/RAL registers

2012-11-01 Thread Stefan Hajnoczi
From: Gabriel L. Somlo gso...@gmail.com Some guest operating systems' drivers (Mac OS X in particular) fail to properly initialize the Receive Address registers (probably expecting them to be pre-initialized by an earlier component, such as a specific proprietary BIOS). This patch pre-initializes

[Qemu-devel] [PATCH 2/4] net: use socket model name for UDP sockets

2012-11-01 Thread Stefan Hajnoczi
From: Lei Li li...@linux.vnet.ibm.com Fix the problem that can not delete the udp socket. It's caused by passing udp model to net_socket_udp_init, but we do not have udp model in our model list. Pass the right model socket to init function.

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-01 Thread Michael S. Tsirkin
On Thu, Nov 01, 2012 at 10:53:52AM +0100, Stefan Hajnoczi wrote: On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote: On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote: On Wed, Oct 31, 2012 at 10:57:24AM +0200, Michael S. Tsirkin wrote: On Wed, Oct 31, 2012

Re: [Qemu-devel] [PATCH] tests: allow qemu-iotests to be run against nbd backend

2012-11-01 Thread Nicholas Thomas
On Wed, 2012-10-31 at 17:44 +0100, Kevin Wolf wrote: Am 31.10.2012 15:33, schrieb Paolo Bonzini: Il 31/10/2012 15:01, n...@bytemark.co.uk ha scritto: From: Nick Thomas n...@bytemark.co.uk To do this, we start a qemu-nbd process at _make_test_img and kill it in _cleanup_test_img.

[Qemu-devel] [PATCH 3/4] net: Reject non-netdevs in qmp_netdev_del()

2012-11-01 Thread Stefan Hajnoczi
The netdev_del command crashes when given a -net device, because it calls qemu_opts_del(NULL). Check that this is a -netdev before attempting to delete it and the QemuOpts. Note the subtle change from qemu_find_opts_err(netdev, errp) to qemu_find_opts_err(netdev, NULL). Since netdev is a built

[Qemu-devel] [PULL 1.3 0/4] Net patches

2012-11-01 Thread Stefan Hajnoczi
The following changes since commit 286d52ebfc0d0d53c2a878e454292fea14bad41b: target-mips: don't flush extra TLB on permissions upgrade (2012-10-31 22:20:49 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-11-01 Thread Michael S. Tsirkin
On Mon, Oct 15, 2012 at 09:46:06PM -, Edivaldo de Araujo Pereira wrote: Hi Stefan, Thank you, very much for taking the time to help me, and excuse me for not seeing your answer early... I've run the procedure you pointed me out, and the result is:

[Qemu-devel] [PATCH 1/4] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-11-01 Thread Stefan Hajnoczi
From: Dmitry Fleytman dmi...@daynix.com Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb chris.w...@elastichosts.com Reported-by: Richard Davies richard.dav...@elastichosts.com Signed-off-by: Dmitry Fleytman

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Alon Levy
Hi, This prevents a known abort on set_client_capabilities, that should be fixed in upstream, but it should also be checked against in qxl. Checks every other location that qxl_send_events is eventually possibly called Why check in all callers instead of

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-11-01 Thread Michael S. Tsirkin
On Thu, Nov 01, 2012 at 02:49:18PM +0530, Amit Shah wrote: On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote: On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira wrote: I didn't take enough time to uderstand the code, so unfortunately I fear there is not much I

[Qemu-devel] [PATCH 3/5] target-ppc: Extend FPU state for newer POWER CPUs

2012-11-01 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au This patch adds some extra FPU state to CPUPPCState. Specifically, fpscr is extended to a target_ulong bits, since some recent (64 bit) CPUs now have more status bits than fit inside 32 bits. Also, we add the 32 VSR registers present on CPUs with

[Qemu-devel] [PULL 0/5] ppc patch queue 2012-11-01

2012-11-01 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 286d52ebfc0d0d53c2a878e454292fea14bad41b: Aurelien Jarno (1): target-mips: don't flush extra TLB on permissions upgrade are available in the git repository at:

[Qemu-devel] [PATCH 5/5] pseries: Cleanup duplications of ics_valid_irq() code

2012-11-01 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au A couple of places in xics.c open-coded the same logic as is already implemented in ics_valid_irq(). This patch fixes the code duplication. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PATCH] qxl: make sure we don't have a stale ds_mirror hanging around

2012-11-01 Thread Gerd Hoffmann
ui/spice-display.c uses ds_mirror to figure which screen areas did actually change. This is active when the qxl card is in vga mode or a non-qxl gfx card is used. A display resize invalidates ds_mirror, and it is handled by simply simply freeing ds_mirror. The next screen update it will be

[Qemu-devel] [PATCH 1/5] Revert PPC: pseries: Remove hack for PIO window

2012-11-01 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au This reverts commit a178274efabcbbc5d44805b51def874e47051325. Contrary to that commit's message, the users of old_portio are not all gone. In particular VGA still uses it via portio_list_add(). Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH v2] e1000: pre-initialize RAH/RAL registers

2012-11-01 Thread Stefan Hajnoczi
On Wed, Oct 31, 2012 at 02:15:39PM -0400, Gabriel L. Somlo wrote: Some guest operating systems' drivers (Mac OS X in particular) fail to properly initialize the Receive Address registers (probably expecting them to be pre-initialized by an earlier component, such as a specific proprietary

[Qemu-devel] [PATCH 4/5] pseries: Clean up inconsistent variable name in xics.c

2012-11-01 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Throughout xics.c 'nr' is used to refer to a global interrupt number, and 'server' is used to refer to an interrupt server number (i.e. CPU number). Except in icp_set_mfrr(), where 'nr' is used as a server number. Fix this confusing inconsistency.

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Gerd Hoffmann
On 11/01/12 12:48, Alon Levy wrote: +if (!qemu_spice_display_is_running(d-ssd)) { +fprintf(stderr, %s: guest stopped, ignoring\n, __func__); +trace_qxl_send_events_vm_stopped(d-id, events); +return; +} Almost perfect. We should add a note here that this

[Qemu-devel] [PATCH 2/5] target-ppc: Rework storage of VPA registration state

2012-11-01 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au We change the storage of the VPA information to explicitly use fixed size integer types which will make life easier for syncing this data with KVM, which we will need in future. Signed-off-by: David Gibson da...@gibson.dropbear.id.au [agraf: fix

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Alon Levy
On 11/01/12 12:48, Alon Levy wrote: +if (!qemu_spice_display_is_running(d-ssd)) { +fprintf(stderr, %s: guest stopped, ignoring\n, __func__); +trace_qxl_send_events_vm_stopped(d-id, events); +return; +} Almost perfect. We should add a note here that

Re: [Qemu-devel] [RFC] hw/qxl: inject interrupts in any state

2012-11-01 Thread Gerd Hoffmann
On 11/01/12 13:44, Alon Levy wrote: On 11/01/12 12:48, Alon Levy wrote: +if (!qemu_spice_display_is_running(d-ssd)) { +fprintf(stderr, %s: guest stopped, ignoring\n, __func__); +trace_qxl_send_events_vm_stopped(d-id, events); +return; +} Almost perfect. We

Re: [Qemu-devel] [PATCH 20/27] target-i386: do not call x86_cpu_realize() on cpu_x86_init()

2012-11-01 Thread Igor Mammedov
On Wed, 31 Oct 2012 17:43:48 +0100 Andreas Färber afaer...@suse.de wrote: Am 31.10.2012 17:32, schrieb Igor Mammedov: On Wed, 24 Oct 2012 15:49:54 -0200 Eduardo Habkost ehabk...@redhat.com wrote: The PC code will need to run additional steps when initializing the CPU object, before

[Qemu-devel] [PATCH] hw/qxl: qxl_send_events: nop if stopped

2012-11-01 Thread Alon Levy
Added a trace point for easy logging. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972 Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 8 +++- trace-events | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 7b88a1e..c33dd03

[Qemu-devel] [PATCH 04/29] rtc: qidl_declare RTCState

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/mc146818rtc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 98839f2..8983d26 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -25,6 +25,7 @@

[Qemu-devel] [PATCH 22/22] pixman: drop obsolete fields from DisplaySurface

2012-11-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |9 - console.h | 23 +-- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/console.c b/console.c index d28b75e..048b48e 100644 --- a/console.c +++ b/console.c @@ -1297,14 +1297,10 @@

[Qemu-devel] [PATCH 05/22] console: untangle gfx txt updates

2012-11-01 Thread Gerd Hoffmann
Stop abusing displaysurface fields for text mode displays. (bpp = 0, width = cols, height = lines). Add flags to displaystate indicating whenever text mode display (curses) or gfx mode displays (sdl, vnc, ...) are present. Add separate displaychangelistener callbacks for text / gfx mode resize

[Qemu-devel] [PATCH 14/22] console: make qemu_alloc_display static

2012-11-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 48 console.h |2 -- 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/console.c b/console.c index 5e1c5f5..48d88e4 100644 --- a/console.c +++ b/console.c @@

[Qemu-devel] [PATCH 01/29] qemu-timer: add QEMUTimer visitor

2012-11-01 Thread Michael Roth
We'll use this for serializing rtc and elsewhere Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile |3 ++- qemu-timer.c | 29 + qemu-timer.h |4 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile

[Qemu-devel] [PATCH 10/29] vga: qidl_declare VGACommonState

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/vga_int.h | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/vga_int.h b/hw/vga_int.h index 22f1706..074e5d5 100644 --- a/hw/vga_int.h +++ b/hw/vga_int.h @@ -25,6 +25,7 @@ #include

Re: [Qemu-devel] [PATCH] hw/qxl: qxl_send_events: nop if stopped

2012-11-01 Thread Alon Levy
On 11/01/12 13:56, Alon Levy wrote: Added a trace point for easy logging. Patch added to spice patch queue. thanks, Gerd PS: There are two pending patches from you (see http://www.kraxel.org/cgit/qemu/log/?h=rebase/spice-next), is that correct or did I miss something?

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! + */ +if (state != leftover) { +

Re: [Qemu-devel] [PATCH 4/8] usb-redir: Add support for input pipelining

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 11:10 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +if (p-combined) { +iov_to_buf(p-combined-iov.iov, p-combined-iov.niov, + 0, buf, size); +} else { +usb_packet_copy(p, buf, size); +}

[Qemu-devel] [PATCH 14/29] cirrus: add qom property for isa-cirrus-vga

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/cirrus_vga.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 220525a..4f00758 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2903,6 +2903,23 @@ static void

Re: [Qemu-devel] [PATCH 1/2] When the XHCI host controller is switched to the running mode, set the ccs bit for each port, to which a device is already attached.

2012-11-01 Thread Gerd Hoffmann
Hi, [ sorry for the delay, was busy with other stuff ] I'm not sure about that. According to the spec, when the hc is set to running mode (p.70) At this point, the host controller is up and running and the Root Hub ports (5.4.8) will begin reporting device connects I understand report

[Qemu-devel] [PATCH 29/29] hpet: add qom property for hpet state

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/hpet.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/hpet.c b/hw/hpet.c index 3beb61e..e1b8881 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -34,6 +34,8 @@ #include i8254.h #include qidl.h

Re: [Qemu-devel] [PATCH] ui/spice: support websockets ports

2012-11-01 Thread Gerd Hoffmann
On 10/19/12 13:52, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- Spice package is not yet available, I assumed it will be the next version, 0.12.1, for the added API spice_server_set_ws_ports. Patches are on spice-devel and git is at http://cgit.freedesktop.org/~alon/spice

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 02:14 PM, Hans de Goede wrote: Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! +

Re: [Qemu-devel] [PATCH] ui/spice: support websockets ports

2012-11-01 Thread Alon Levy
On 10/19/12 13:52, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- Spice package is not yet available, I assumed it will be the next version, 0.12.1, for the added API spice_server_set_ws_ports. Patches are on spice-devel and git is at

[Qemu-devel] [PATCH 18/22] pixman: switch screendump function.

2012-11-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga.c | 39 +++ 1 files changed, 11 insertions(+), 28 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 1188463..023134e 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2393,13 +2393,12 @@ void

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-01 Thread Gerd Hoffmann
On 10/19/12 12:35, Vasilis Liaskovitis wrote: Hi, On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: This patchs adds a frame buffer driver for (virtual/emulated) vga cards implementing the bochs dispi interface. Supported hardware are the bochs vga card with vbe extension and

[Qemu-devel] [PATCH 08/22] console: remove dpy_gfx_fill

2012-11-01 Thread Gerd Hoffmann
Unused code. 'nuff said. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 13 - ui/sdl.c |7 --- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/console.h b/console.h index 7e0ac76..6492e67 100644 --- a/console.h +++ b/console.h @@ -161,8

[Qemu-devel] [PATCH 01/22] console: QLIST-ify display change listeners.

2012-11-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index 6099d8d..4239eb3 100644

[Qemu-devel] [PATCH 03/22] console: move set_mouse + cursor_define callbacks

2012-11-01 Thread Gerd Hoffmann
When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |2 +- console.h | 39 +++ hw/jazz_led.c

[Qemu-devel] [PATCH 27/29] ide: add qom property for piix3/piix4-ide state

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/ide/pci.c |9 +++-- hw/ide/pci.h |3 +++ hw/ide/piix.c | 39 +++ 3 files changed, 49 insertions(+), 2 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index bcdd70e..6629b3a

Re: [Qemu-devel] [PATCH v2 3/7] memory: iommu support

2012-11-01 Thread Avi Kivity
On 10/31/2012 08:59 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-10-31 at 12:32 +0200, Avi Kivity wrote: This has nothing to do with device endianness; we're translating from a byte buffer (address_space_rw()) to a uint64_t (MemoryRegionOps::read/write()) so we need to take host endianess

Re: [Qemu-devel] [PATCH v2 3/7] memory: iommu support

2012-11-01 Thread Avi Kivity
On 11/01/2012 03:44 PM, Avi Kivity wrote: However we do have a problem with non-1/2/4/8 byte writes. Right now any mismatched access ends up as an 8 byte write, we need an extra accessor for arbitrary writes, or rather better use of the .impl members of MemoryRegionOps. Sorry, it's

[Qemu-devel] [PULL 00/22] console cleanups pixman rendering

2012-11-01 Thread Gerd Hoffmann
Hi, Sitting on these too long already. Series has been on the list a while back, only splitted into two parts (separate console cleanups series carrying patches 1-8). Patch 11 was updated according to Paolos suggestion, otherwise the patches are unmodified. please pull, Gerd The following

[Qemu-devel] [PATCH 02/22] console: add unregister_displaychangelistener

2012-11-01 Thread Gerd Hoffmann
Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whether we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the gui timer works correctly with

[Qemu-devel] [PATCH 19/22] pixman/vnc: use pixman images in vnc.

2012-11-01 Thread Gerd Hoffmann
The vnc code uses *three* DisplaySurfaces: First is the surface of the actual QemuConsole, usually the guest screen, but could also be a text console (monitor/serial reachable via Ctrl-Alt-nr keys). This is left as-is. Second is the current server's view of the screen content. The vnc code

[Qemu-devel] [PATCH 15/29] i440fx: qidl_declare PCII440FXState

2012-11-01 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/piix_pci.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 9af5847..a4c32aa 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -30,6 +30,7 @@ #include sysbus.h

Re: [Qemu-devel] [PATCH] hw/qxl: qxl_send_events: nop if stopped

2012-11-01 Thread Gerd Hoffmann
On 11/01/12 13:56, Alon Levy wrote: Added a trace point for easy logging. Patch added to spice patch queue. thanks, Gerd PS: There are two pending patches from you (see http://www.kraxel.org/cgit/qemu/log/?h=rebase/spice-next), is that correct or did I miss something?

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! + */ +if (state != leftover) { +

  1   2   3   >