[Qemu-devel] buildbot failure in qemu on xen_unstable

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder xen_unstable while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_unstable/builds/173 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The

[Qemu-devel] [Bug 1073585] Re: Deleting UDP socket in monitor mode

2012-11-02 Thread Lei Li
Hi, I reproduced this problem and have already submit a patch to fix it: http://patchwork.ozlabs.org/patch/196116/ ** Changed in: qemu Status: New = Fix Committed ** Changed in: qemu Assignee: (unassigned) = Lei Li (matrixs-zero) -- You received this bug notification because

[Qemu-devel] buildbot failure in qemu on xen41

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder xen41 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen41/builds/172 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

Re: [Qemu-devel] buildbot failure in qemu on xen41

2012-11-02 Thread Stefan Hajnoczi
Anthony, your buildslave is missing a package: ERROR: pixman not present. Your options: (1) Prefered: Install the pixman devel package (any recent distro should have packages as Xorg needs pixman too). (2) Fetch the pixman submodule, using: git submodule update --init pixman On

[Qemu-devel] [PATCH] Fix spelling (prefered - preferred)

2012-11-02 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- configure |2 +- net/tap-win32.c |7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 79701ea..860859b 100755 --- a/configure +++ b/configure @@ -2115,7 +2115,7 @@ if test $pixman =

Re: [Qemu-devel] [PATCH v3] correct error message qemu-img reported

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 6:11 AM, liguang lig.f...@cn.fujitsu.com wrote: diff --git a/qemu-img.c b/qemu-img.c index b41e670..d4ea800 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -337,10 +337,15 @@ static int img_create(int argc, char **argv) /* Get image size, if specified */ if

Re: [Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-02 Thread Stefan Hajnoczi
Corey, any ideas here? LINK qemu-ga Undefined symbols: _monitor_get_fd, referenced from: _socket_connect in qemu-sockets.o _socket_listen in qemu-sockets.o _monitor_fdset_dup_fd_find, referenced from: _qemu_close in osdep.o _sem_timedwait, referenced from:

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki k.suz...@aist.go.jp wrote: Can live migration of QEMU include previous snapshot images? I want to roll back to a previous snapshot image on another machine after live migration. I was thinking Block Migration bring the snapshot images of QCOW2,

Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx txt updates

2012-11-02 Thread Jan Kiszka
On 2012-11-01 14:04, Gerd Hoffmann wrote: Stop abusing displaysurface fields for text mode displays. (bpp = 0, width = cols, height = lines). Add flags to displaystate indicating whenever text mode display (curses) or gfx mode displays (sdl, vnc, ...) are present. Add separate

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Jan Kiszka
On 2012-10-31 16:30, Paolo Bonzini wrote: Otherwise, chardevs will not be able to create a bottom half as soon as that will require an AioContext. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 12 ++-- 1 file modificato, 6 inserzioni(+), 6 rimozioni(-) diff --git

[Qemu-devel] [PATCH] Fix comments (adress - address, layed - laid, wierd - weird)

2012-11-02 Thread Stefan Weil
Remove also a duplicated 'the'. Signed-off-by: Stefan Weil s...@weilnetz.de --- slirp/ip_icmp.c |2 +- tcg/tcg.h |4 ++-- uri.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index d571fd0..9f1cb08 100644 ---

Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs

2012-11-02 Thread Gerd Hoffmann
Hi, +static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr, + uint32_t *buf, size_t len) +{ +int i; + +for (i = 0; i (len / sizeof(uint32_t)); i++) { +buf[i] = cpu_to_le32(buf[i]); +} +

[Qemu-devel] [PATCH] s390x: Spelling fixes (endianess - endianness, occured - occurred)

2012-11-02 Thread Stefan Weil
Replace also write into by write to. Signed-off-by: Stefan Weil s...@weilnetz.de --- I think write to is better, but I am not sure about this, so please wait until a native speaker has reviewed that patch. Regards Stefan Weil hw/s390x/sclp.h|4 ++-- hw/s390x/sclpconsole.c |4

Re: [Qemu-devel] [PATCH] net: avoid segfault in case netdev_del non-host network device

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 3:10 AM, Lei Li li...@linux.vnet.ibm.com wrote: On 11/01/2012 05:42 PM, Stefan Hajnoczi wrote: On Thu, Nov 1, 2012 at 8:48 AM, Lei Li li...@linux.vnet.ibm.com wrote: netdev_del assume that remove host network device. However, when try to remove a non-host network

[Qemu-devel] [PATCH] xenfb: fix build breakage caused by console cleanup series

2012-11-02 Thread Gerd Hoffmann
Console cleanup series renamed dpy_resize and dpy_update all over the tree, but hw/xenfb.c was forgotten. Update it too so it builds again. Reported-by: Jan Kiszka jan.kis...@web.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/xenfb.c |4 ++-- 1 files changed, 2 insertions(+), 2

[Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-11-02 Thread Gerd Hoffmann
-- Forwarded message -- From: build...@spunk.home.kraxel.org Date: 2012/10/30 Subject: buildbot failure in qemu on fedora-default To: kraxel...@gmail.com The Buildbot has detected a failed build on builder fedora-default while building qemu. Full details are available at:

Re: [Qemu-devel] [patch v5 5/8] memory: introduce local lock for address space

2012-11-02 Thread Jan Kiszka
On 2012-11-02 01:52, liu ping fan wrote: On Fri, Nov 2, 2012 at 2:44 AM, Jan Kiszka jan.kis...@web.de wrote: On 2012-11-01 16:45, Avi Kivity wrote: On 10/29/2012 11:46 AM, liu ping fan wrote: On Mon, Oct 29, 2012 at 5:32 PM, Avi Kivity a...@redhat.com wrote: On 10/29/2012 01:48 AM, Liu Ping

[Qemu-devel] buildbot failure in qemu on xen40

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder xen40 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen40/builds/174 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Stefan, From: Stefan Hajnoczi stefa...@gmail.com Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 2 Nov 2012 08:19:15 +0100 On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki k.suz...@aist.go.jp wrote: Can live migration of QEMU include previous snapshot

Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs

2012-11-02 Thread David Gibson
On Fri, Nov 02, 2012 at 08:31:23AM +0100, Gerd Hoffmann wrote: Hi, +static inline void xhci_dma_write_u32s(XHCIState *xhci, dma_addr_t addr, + uint32_t *buf, size_t len) +{ +int i; + +for (i = 0; i (len / sizeof(uint32_t)); i++) { +

Re: [Qemu-devel] [PATCH] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Kevin Wolf
Am 01.11.2012 12:30, schrieb Nicholas Thomas: On Wed, 2012-10-31 at 17:44 +0100, Kevin Wolf wrote: Am 31.10.2012 15:33, schrieb Paolo Bonzini: Il 31/10/2012 15:01, n...@bytemark.co.uk ha scritto: From: Nick Thomas n...@bytemark.co.uk To do this, we start a qemu-nbd process at _make_test_img

[Qemu-devel] [PATCH 1/7] hw/qxl: guest bug on primary create with stride %4 != 0

2012-11-02 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Due to usage of pixman for rendering on all spice surfaces we have pixman's requirement that the stride be word aligned. A guest not honoring that can crash spice and qemu with it due to failure to create a surface (in spice-server). Avoid this early on in primary

[Qemu-devel] [PATCH 5/7] spice: switch to pixman

2012-11-02 Thread Gerd Hoffmann
Switch over spice-display.c to use the pixman library instead of the home-grown pflib bits. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h |5 + qemu-pixman.c | 13 + qemu-pixman.h |2 ++ ui/spice-display.c | 51

[Qemu-devel] [PATCH 4/7] qxl: call dpy_gfx_resize when entering vga mode

2012-11-02 Thread Gerd Hoffmann
When entering vga mode the display size likely changes, notify all displaychangelisteners about this. Probably went unnoticed for a while as one if the first things the guest does after leaving qxl native mode and entering qxl vga mode is to set the vga video mode. But there is still a small

[Qemu-devel] [PATCH 7/7] spice: fix initialization order

2012-11-02 Thread Gerd Hoffmann
Register displaychangelistener last, after spice is fully initialized, otherwise we may hit NULL pointer dereferences when qemu starts calling our callbacks. Commit e250d949feb1334828f27f0d145c35f29c4b7639 triggers this bug. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 08:26, Jan Kiszka ha scritto: Can we move os_daemonize before that, or what are its dependencies? I have an increasingly bad feeling about this code shuffling. Moving os_daemonize too early ruins error messages. I would just pull qemu_mutex_lock_iothread later, even just before

Re: [Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 08:45, Gerd Hoffmann ha scritto: CCfsdev/virtfs-proxy-helper.o fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’: fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result]

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Amit Shah
On (Thu) 01 Nov 2012 [18:07:21], Michael S. Tsirkin wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we really only care about a single packet worth of buffers. To fix, add parameters

[Qemu-devel] compile failure on macos: only weak aliases are supported on darwin

2012-11-02 Thread Peter Maydell
Building on MacOS with clang has broken: qmp.c:474:1: error: only weak aliases are supported on darwin QEMU_WEAK_ALIAS(arch_query_cpu_definitions, default_arch_query_cpu_definitions); ^ ./compiler.h:54:54: note: expanded from macro 'QEMU_WEAK_ALIAS' typeof(oldname) newname

[Qemu-devel] [PULL 0/7] spice patch queue

2012-11-02 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue. It carries some qxl bugfixes, switches spice-display over to pixman, drops the obsolete pflib bits and fixes some fallout from the console cleanup patch series. please pull, Gerd The following changes since commit

[Qemu-devel] [PATCH 6/7] pflib: unused, remove it.

2012-11-02 Thread Gerd Hoffmann
Replaced by pixman library. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile.objs |1 - pflib.c | 215 - pflib.h | 20 - 3 files changed, 0 insertions(+), 236 deletions(-) delete mode 100644 pflib.c

[Qemu-devel] [PATCH 3/7] qxl: fix cursor reset

2012-11-02 Thread Gerd Hoffmann
When resetting the qxl cursor notify the qemu displaystate too. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index f19451b..063970d 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -293,6

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin m...@redhat.com wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we really only care about a single packet worth of buffers. To fix, add

[Qemu-devel] [PATCH 2/7] hw/qxl: qxl_send_events: nop if stopped

2012-11-02 Thread Gerd Hoffmann
From: Alon Levy al...@redhat.com Added a trace point for easy logging. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972 Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |8 +++- trace-events |1 + 2 files changed, 8

[Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread nick
From: Nick Thomas n...@bytemark.co.uk To do this, we start a qemu-nbd process at _make_test_img and kill it in _cleanup_test_img. $TEST_IMG is changed to point at the TCP server. We also remove the checks for existence of binaries from common.config - they're duplicated in common, and we can make

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 9:24 AM, Kuniyasu Suzaki k.suz...@aist.go.jp wrote: Hello Stefan, From: Stefan Hajnoczi stefa...@gmail.com Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 2 Nov 2012 08:19:15 +0100 On Fri, Nov 2, 2012 at 4:15 AM, Kuniyasu Suzaki

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Jan Kiszka
On 2012-11-02 10:55, Paolo Bonzini wrote: Il 02/11/2012 08:26, Jan Kiszka ha scritto: Can we move os_daemonize before that, or what are its dependencies? I have an increasingly bad feeling about this code shuffling. Moving os_daemonize too early ruins error messages. I would just pull

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-02 Thread Stefan Hajnoczi
On Thu, Nov 1, 2012 at 12:31 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 01, 2012 at 10:53:52AM +0100, Stefan Hajnoczi wrote: On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote: On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote: On Wed, Oct 31,

Re: [Qemu-devel] [RFC] net: Peer with existing NIC in netdev_add

2012-11-02 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 2:49 PM, Stefan Hajnoczi stefa...@redhat.com wrote: Laine: Please try this out and see if it works for your use case. Waiting for your feedback before I prepare a final patch that can go into QEMU. There's no time pressure from my side to get this feature in so take as

Re: [Qemu-devel] compile failure on macos: only weak aliases are supported on darwin

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 10:54, Peter Maydell ha scritto: Building on MacOS with clang has broken: qmp.c:474:1: error: only weak aliases are supported on darwin QEMU_WEAK_ALIAS(arch_query_cpu_definitions, default_arch_query_cpu_definitions); ^ ./compiler.h:54:54: note: expanded from macro

Re: [Qemu-devel] [patch v5 7/8] memory: introduce tls context to record nested dma

2012-11-02 Thread Jan Kiszka
On 2012-10-29 00:48, Liu Ping Fan wrote: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- cpus.c|3 ++ exec.c| 58 + qemu-thread.h |8 +++ vl.c |1 + 4 files changed, 70

Re: [Qemu-devel] compile failure on macos: only weak aliases are supported on darwin

2012-11-02 Thread Peter Maydell
On 2 November 2012 11:39, Paolo Bonzini pbonz...@redhat.com wrote: Il 02/11/2012 10:54, Peter Maydell ha scritto: Looks like commit 67d223be is the culprit (and QEMU_WEAK_ALIAS isn't actually generated weak aliases?) It's a bad error message. It should be only weakref aliases are supported

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-02 Thread Juan Quintela
David Gibson d...@au1.ibm.com wrote: On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: On 10/31/2012 05:43 AM, David Gibson wrote: The code for migrating (or savevm-ing) memory pages starts off by creating a dirty bitmap and filling it with 1s. Except, actually, because bit

Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 11:32, Jan Kiszka ha scritto: On 2012-11-02 10:55, Paolo Bonzini wrote: Il 02/11/2012 08:26, Jan Kiszka ha scritto: Can we move os_daemonize before that, or what are its dependencies? I have an increasingly bad feeling about this code shuffling. Moving os_daemonize too early

Re: [Qemu-devel] [PATCH v7 1/3] hw: introduce standard SD host controller

2012-11-02 Thread Igor Mitsyanko
On 11/02/2012 06:21 AM, Peter Crosthwaite wrote: On Fri, Nov 2, 2012 at 3:21 AM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Hi, Peter, I did some testing and noticed significant performance reduction compared to previous version without transfer_timer. For read operation: Testcase (count

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Vasilis Liaskovitis
On Thu, Nov 01, 2012 at 02:30:35PM +0100, Gerd Hoffmann wrote: On 10/19/12 12:35, Vasilis Liaskovitis wrote: Hi, On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote: This patchs adds a frame buffer driver for (virtual/emulated) vga cards implementing the bochs dispi

[Qemu-devel] qemu.org DNS is down, use 140.211.15.109

2012-11-02 Thread Stefan Hajnoczi
The DNS for qemu.org is down. Please use the IP address 140.211.15.109 directly in the meantime or add it to your /etc/hosts so you can continue to use the domain name: echo '140.211.15.109 qemu.org wiki.qemu.org git.qemu.org' /etc/hosts Stefan

[Qemu-devel] [PATCH trace] Avoid all systemtap reserved words

2012-11-02 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Over time various systemtap reserved words have been blacklisted in the trace backend generator. The list is not complete though, so there is continued risk of problems in the future. Preempt such problems by specifying the full list of systemtap

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Orit Wasserman
On 11/02/2012 05:10 AM, David Gibson wrote: Asking for some advice on the list. I have prorotype savevm and migration support ready for the pseries machine. They seem to work under simple circumstances (idle guest). To test them more extensively I've been attempting to perform live

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: @@ -197,12 +198,14 @@ testlist options IMGPROTO=rbd xpand=false ;; - -sheepdog) IMGPROTO=sheepdog xpand=false ;; - +-nbd) +IMGPROTO=nbd +

[Qemu-devel] [PATCH v3] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Nicholas Thomas
From: n...@bytemark.co.uk To: qemu-devel@nongnu.org Cc: pbonz...@redhat.com, kw...@redhat.com, Nick Thomas n...@bytemark.co.uk Subject: [PATCH v3] tests: allow qemu-iotests to be run against nbd backend Date: Fri, 2 Nov 2012 10:28:06 + From: Nick Thomas n...@bytemark.co.uk To do this, we

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Nicholas Thomas
On Fri, 2012-11-02 at 13:41 +0100, Paolo Bonzini wrote: Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: @@ -197,12 +198,14 @@ testlist options IMGPROTO=rbd xpand=false ;; - -sheepdog) IMGPROTO=sheepdog xpand=false ;; -

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 04:10, David Gibson ha scritto: Asking for some advice on the list. I have prorotype savevm and migration support ready for the pseries machine. They seem to work under simple circumstances (idle guest). To test them more extensively I've been attempting to perform live

Re: [Qemu-devel] Testing migration under stress

2012-11-02 Thread Juan Quintela
David Gibson da...@gibson.dropbear.id.au wrote: Asking for some advice on the list. I have prorotype savevm and migration support ready for the pseries machine. They seem to work under simple circumstances (idle guest). To test them more extensively I've been attempting to perform live

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Eric Blake
On 11/02/2012 04:30 AM, Stefan Hajnoczi wrote: II. If you want to use internal snapshots in a single qcow2 file, you will need to modify QEMU code more: 1. Implement BlockDriverState snapshot slave support so a qcow2 snapshot can be read-only accessed as a BlockDriverState while the master

[Qemu-devel] [PATCH 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin

[Qemu-devel] [PATCH 4/5] vl: unify calls to init_timer_alarm

2012-11-02 Thread Paolo Bonzini
init_timer_alarm was being called twice. This is not needed. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 5 - vl.c| 5 - 2 file modificati, 4 inserzioni(+), 6 rimozioni(-) diff --git a/main-loop.c b/main-loop.c index e43c7c8..234a313 100644 ---

[Qemu-devel] [PATCH 1/5] compiler: support Darwin weak references

2012-11-02 Thread Paolo Bonzini
Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- compiler.h | 9 -

[Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-thread-posix.c | 74 + qemu-thread-posix.h | 6 + 2 file modificati, 80 inserzioni(+) diff --git

[Qemu-devel] [PATCH 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

[Qemu-devel] [PATCH 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 15 ++- 1 file modificato, 14 inserzioni(+). 1 rimozione(-) diff --git a/qemu-timer.c b/qemu-timer.c

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Gerd Hoffmann
Only with bochsfb or with vesafb (+ fbdev xorg driver) too? vt-switching with vesafb/X11 works fine on a grml 64-bit image. However, xorg uses vesa driver in this case, not fbdev (fbdev / fbdevhw xorg modules are initially loaded but then unloaded). X11 uses 1280x768 and vesafb uses

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 13:41, schrieb Paolo Bonzini: Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: @@ -197,12 +198,14 @@ testlist options IMGPROTO=rbd xpand=false ;; - -sheepdog) IMGPROTO=sheepdog xpand=false ;; - +-nbd) +

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: By adding error propagation to bdrv_img_create() we improve error reporting in qmp_transaction() and simplify qemu-img.c:img_create() a bit. Please, check individual patches for details. Kevin, is this in your

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 14:25, schrieb Luiz Capitulino: On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: By adding error propagation to bdrv_img_create() we improve error reporting in qmp_transaction() and simplify qemu-img.c:img_create() a bit. Please, check

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 02 Nov 2012 14:40:03 +0100 Kevin Wolf kw...@redhat.com wrote: Am 02.11.2012 14:25, schrieb Luiz Capitulino: On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino lcapitul...@redhat.com wrote: By adding error propagation to bdrv_img_create() we improve error reporting in

Re: [Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-02 Thread Corey Bryant
On 11/02/2012 03:17 AM, Stefan Hajnoczi wrote: Corey, any ideas here? My guess for the majority of these is that monitor.o is not being linked with osdep.o for MacOSX. Is this a nightly build that would have been successful earlier in the week? Also do you know if (and perhaps how) I

Re: [Qemu-devel] [PATCH 1/5] compiler: support Darwin weak references

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini pbonz...@redhat.com wrote: Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. clang doesn't

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2:

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini pbonz...@redhat.com wrote: +#if defined(__OpenBSD__) || defined(__APPLE__) || defined(__NetBSD__) +struct timespec ts; +clock_gettime(CLOCK_REALTIME, ts); qemu-thread-posix.c:198:5: warning: implicit declaration of function 'clock_gettime' is

[Qemu-devel] First 9 + 1/2 years of QEMU dev history animated

2012-11-02 Thread Daniel P. Berrange
While I was generating an animation of libvirt dev history[1] using gource, I also took the time to generate one showing the first 9+1/2 years of QEMU's dev history. https://www.youtube.com/watch?v=IujBYP7cw8E I see QEMU has its 10th birthday coming up early next year on Feb 18, 2013, assuming

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt.

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 12:29:37 AM Eduardo Otubo wrote: On Thu, Nov 01, 2012 at 05:43:03PM -0400, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using

Re: [Qemu-devel] RBD trim / unmap support?

2012-11-02 Thread Stefan Priebe - Profihost AG
Hello qemu list, i cc you as i'm not sure where the problem is. When i use scsi-hd with discard_granularity the discard works fine on target size but the client print these - immediatly after sending discard / trim commands with mkfs.btrfs. [ 75.076895] sd 2:0:0:4: [sdc] [ 75.078353]

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new

[Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin

[Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references

2012-11-02 Thread Paolo Bonzini
Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: add unused attribute

[Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: extract compute_abs_deadline and use it qemu-thread-posix.c | 92 +++-- qemu-thread-posix.h | 6

[Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-timer.c | 14 ++ 1 file modificato, 14 inserzioni(+) diff --git a/qemu-timer.c b/qemu-timer.c index

Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx txt updates

2012-11-02 Thread Peter Maydell
On 2 November 2012 08:20, Jan Kiszka jan.kis...@web.de wrote: On 2012-11-01 14:04, Gerd Hoffmann wrote: Stop abusing displaysurface fields for text mode displays. (bpp = 0, width = cols, height = lines). Add flags to displaystate indicating whenever text mode display (curses) or gfx mode

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Michael S. Tsirkin
On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin m...@redhat.com wrote: Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced a regression in virtio-net performance because it looks into the ring aggressively while we

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23,

Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int - size_t

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: Using appropriate types for variables is a good thing :). All users simply do sizeof(MyType) and the value is passed to a memory allocator, it should be size_t. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-aio.h | 2 +- 1

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: AIO control blocks are frequently acquired and released because each aio request involves at least one AIOCB. Therefore, we pool them to avoid heap allocation overhead. The problem with the freelist approach in AIOPool is thread-safety. If

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:46 AM, Paul Moore wrote: On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM,

Re: [Qemu-devel] [PATCH v2 3/3] aio: rename AIOPool to AIOCBInfo

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: Now that AIOPool no longer keeps a freelist, it isn't really a pool anymore. Rename it to AIOCBInfo and make it const since it no longer needs to be modified. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 22

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
Il 30/10/2012 19:21, Jan Kiszka ha scritto: Aren't we still dependent on the order of processing? If the APIC is restored after the device, won't we get the same problem? Strictly speaking yes, but CPUs and APICs are always the first devices to be saved. Hmm, thinking about this

[Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Peter Maydell
Commit a93a4a2 changed the names of some fields in DisplayChangeListener and broke compilation of the cocoa UI. Update to the new names. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m

[Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Gerd Hoffmann
On 11/02/12 15:54, Peter Maydell wrote: Commit a93a4a2 changed the names of some fields in DisplayChangeListener and broke compilation of the cocoa UI. Update to the new names. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Jan Kiszka
On 2012-11-02 15:53, Paolo Bonzini wrote: Il 30/10/2012 19:21, Jan Kiszka ha scritto: Aren't we still dependent on the order of processing? If the APIC is restored after the device, won't we get the same problem? Strictly speaking yes, but CPUs and APICs are always the first devices to be

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug

Re: [Qemu-devel] [PATCH v2 35/39] raw: merge posix-aio-compat.c into block/raw-posix.c

2012-11-02 Thread Peter Maydell
On 31 October 2012 16:30, Paolo Bonzini pbonz...@redhat.com wrote: Making the qemu_paiocb specific to raw devices will let us access members of the BDRVRawState arbitrarily. Signed-off-by: Paolo Bonzini pbonz...@redhat.com clang now warns about an unused function: CCblock/raw-posix.o

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Eric, From: Eric Blake ebl...@redhat.com Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 02 Nov 2012 07:12:21 -0600 On 11/02/2012 04:30 AM, Stefan Hajnoczi wrote: II. If you want to use internal snapshots in a single qcow2 file, you will need to

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Andreas Färber
Am 02.11.2012 15:54, schrieb Peter Maydell: Commit a93a4a2 changed the names of some fields in DisplayChangeListener and broke compilation of the cocoa UI. Update to the new names. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Andreas Färber andreas.faer...@web.de

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Gerd Hoffmann
Hi, I think deferring IRQ events to the point when the complete vmstate is loaded is the cleaner and more robust approach. Agree. Just schedule a bh in post_load. See also a229c0535bd336efaec786dd6e352a54e0a8187d cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Peter Maydell
On 2 November 2012 15:43, Paolo Bonzini pbonz...@redhat.com wrote: Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken,

[Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm

2012-11-02 Thread Paolo Bonzini
init_timer_alarm was being called twice. This is not needed. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 5 - vl.c| 5 - 2 file modificati, 4 inserzioni(+), 6 rimozioni(-) diff --git a/main-loop.c b/main-loop.c index e43c7c8..234a313 100644 ---

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
Hi, I think deferring IRQ events to the point when the complete vmstate is loaded is the cleaner and more robust approach. Agree. Just schedule a bh in post_load. See also a229c0535bd336efaec786dd6e352a54e0a8187d No, it cannot a bh. Right now incoming migration is blocking, but

[Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl

2012-11-02 Thread Paolo Bonzini
clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: unused function paio_ioctl [-Wunused-function] static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd, ^ 1 warning generated. because the only use of

  1   2   >