[Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes

2013-04-26 Thread David Gibson
vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the helper for PCI devices, which means it was broken by Paolo Bonzini's recent addition of iommu support to the memory API. This fixes it. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/scsi/vmw_pvscsi.c |2

[Qemu-devel] [PATCH 2/4] vfio: Associate VFIO groups with (guest) IOMMU address spaces

2013-04-26 Thread David Gibson
The only model so far supported for VFIO passthrough devices is the model usually used on x86, where all of the guest's RAM is mapped into the (host) IOMMU and there is no IOMMU visible in the guest. Later, however we want to also support guest visible IOMMUs. In order to do that the vfio

[Qemu-devel] [PATCH 4/4] vfio: Only use memory listeners when appropriate

2013-04-26 Thread David Gibson
Currently, vfio registers a MemoryListener for every vfio container we create, to keep the container's mappings in sync with main system memory. That's only correct though, if the context the container is attached to represents a dma address space which actually matches main system memory -

[Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-26 Thread David Gibson
At the moment, vfio maintains a global list of containers that are assumed to be more or less interchangeable, since they are all set up with a MemoryListener to have all of system memory mapped. However, that only makes sense if all the containers are used on devices which really do expect a dma

[Qemu-devel] [0/4] RFC: Preparations for VFIO and guest IOMMUs (v2)

2013-04-26 Thread David Gibson
This patch series represents a second attempt at better integration of the vfio code with qemu's handling of guest IOMMUs. It is based on Paolo Bonzini's tree at git://github.com/bonzini/qemu.git (iommu branch). ddThis series should open the way for using VFIO with a guest system containing an

[Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-26 Thread Bharat Bhushan
ePAPR defines the initial values of cpu registers. This patch initialize the GPRs as per ePAPR specification. This resolves the issue of guest reboot/reset (guest hang on reboot). Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com Signed-off-by: Stuart Yoder stuart.yo...@freescale.com

Re: [Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-26 Thread Alexander Graf
On 26.04.2013, at 08:17, Bharat Bhushan wrote: ePAPR defines the initial values of cpu registers. This patch initialize the GPRs as per ePAPR specification. This resolves the issue of guest reboot/reset (guest hang on reboot). Why does it hang only on reboot, not on initial bootup?

Re: [Qemu-devel] [PATCH 3/4] s390-ccw.img: Fix compile warning in s390 ccw virtio code

2013-04-26 Thread Alexander Graf
On 23.04.2013, at 13:45, Christian Borntraeger wrote: On 23/04/13 13:31, Alexander Graf wrote: On 04/23/2013 01:23 PM, Christian Borntraeger wrote: Lets fix this gcc warning: virtio.c: In function ‘vring_send_buf’: virtio.c:125:35: error: operation on ‘vr-next_idx’ may be undefined

Re: [Qemu-devel] ppc64-linux-user broken since PPC: Unify dcbzl code path ?

2013-04-26 Thread Alexander Graf
On 22.04.2013, at 08:37, Riku Voipio wrote: Hi, While testing my linux-user smoke-testing setup, I noticed that with current qemu head: ./ppc64-linux-user/qemu-ppc64 ../../qemu-smoke/ppc64/busybox ls busybox: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *)

Re: [Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-26 Thread Alexander Graf
On 26.04.2013, at 08:51, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, April 26, 2013 11:51 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wood Scott-B07421; Bhushan Bharat-R65777; Yoder

[Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970

2013-04-26 Thread Alexander Graf
The default with linux-user for dcbz on 970 is to emulate 32 byte clears. However, redoing the dcbzl support we added a check to not honor the bit in HID5 that sets this. Remove the #ifdef check on linux user, so that we get 32 byte clears again. Reported-by: Riku Voipio riku.voi...@iki.fi

Re: [Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-26 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, April 26, 2013 11:51 AM To: Bhushan Bharat-R65777 Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wood Scott-B07421; Bhushan Bharat-R65777; Yoder Stuart-B08248 Subject: Re: [PATCH] ppc: initialize GPRs as

Re: [Qemu-devel] [PATCH 04/15] target-i386: introduce apic-id property

2013-04-26 Thread Igor Mammedov
On Thu, 25 Apr 2013 17:36:45 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Apr 25, 2013 at 04:05:26PM +0200, Igor Mammedov wrote: [...] +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque, + const char *name, Error **errp)

Re: [Qemu-devel] [PATCH v2 05/10] target-ppc: emulate prtyw and prtyd instructions

2013-04-26 Thread Alexander Graf
On 20.04.2013, at 20:56, Aurelien Jarno wrote: Needed for Power ISA version 2.05 compliance. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-ppc/translate.c | 38 ++ 1 file changed, 38

Re: [Qemu-devel] [PATCH v2 00/10] target-ppc: emulate Power ISA 2.05 instructions

2013-04-26 Thread Alexander Graf
On 20.04.2013, at 20:56, Aurelien Jarno wrote: qemu-system-ppc64 -M pseries clamis to emulate a POWER7 CPU, corresponding to an ISA 2.06 compliant CPU, while QEMU emulates something like an ISA 2.04 CPU. Given that glibc and GCC start to use some instructions like cmpb and fcpsgn, this

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-26 Thread Paolo Bonzini
Il 25/04/2013 14:26, Luiz Capitulino ha scritto: That's a good point, although I wonder if a command could have a new capability that's not mapped to a new argument. IOW, I'd expect most/all new capabilities to always be mapped to new arguments. A new enum value would also be a new capability,

Re: [Qemu-devel] [PATCH] rbd: Fix use after free in rbd_open()

2013-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2013 at 03:59:27PM +0200, Kevin Wolf wrote: Commit 56d1b4d2 frees the QemuOpts for the driver-specific options immediately, even though it still needs the filename string that is contained there. This doesn't work. Move the deletion of the QemuOpts to the end of the function

Re: [Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes

2013-04-26 Thread Paolo Bonzini
Il 26/04/2013 08:02, David Gibson ha scritto: vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the helper for PCI devices, which means it was broken by Paolo Bonzini's recent addition of iommu support to the memory API. This fixes it. Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-26 Thread Paolo Bonzini
Il 26/04/2013 08:02, David Gibson ha scritto: At the moment, vfio maintains a global list of containers that are assumed to be more or less interchangeable, since they are all set up with a MemoryListener to have all of system memory mapped. However, that only makes sense if all the

Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3

2013-04-26 Thread Paolo Bonzini
Il 24/04/2013 20:49, Andreas Färber ha scritto: Am 24.04.2013 13:30, schrieb Paolo Bonzini: Il 24/04/2013 12:37, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com I had exactly the same patch in my 1.6 queue. :) Reviewed-by: Paolo Bonzini pbonz...@redhat.com The commit

Re: [Qemu-devel] [PULL 0/9] SCSI updates for 2013-04-13

2013-04-26 Thread Paolo Bonzini
Il 24/04/2013 18:56, Stefan Weil ha scritto: Am 24.04.2013 10:19, schrieb Paolo Bonzini: Il 24/04/2013 06:56, Stefan Weil ha scritto: Hi Paolo, the latest QEMU build is broken when CONFIG_VHOST_SCSI is undefined. --verbose, please. :) Sorry, I thought it was obvious. The error occurs in a

[Qemu-devel] [PATCH 1/3] virtio-pci: properly validate address before accessing config

2013-04-26 Thread Jason Wang
There are several several issues in the current checking: - The check was based on the minus of unsigned values which can overflow - It was done after .{set|get}_config() which can lead crash when config_len is zero since vdev-config is NULL Fix this by: - Validate the address in

[Qemu-devel] [PATCH 2/3] virtio-ccw: check config length before accessing it

2013-04-26 Thread Jason Wang
virtio-rng-ccw has zero config length, so we need validate the config length before trying to access it. Otherwise we may crash since vdev-config is NULL. Cc: Cornelia Huck cornelia.h...@de.ibm.com Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Signed-off-by: Jason Wang

Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext

2013-04-26 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 25/04/2013 08:36, David Gibson ha scritto: On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: Il 24/04/2013 17:12, Alex Williamson ha scritto: At the moment, vfio maintains a global list of containers that are assumed to be more or

[Qemu-devel] [PATCH 3/3] s390-virtio-bus: sync config only when config_len is not zero

2013-04-26 Thread Jason Wang
virtio-rng-s390 has zero config length, so no need to sync its config otherwise qemu will crash since vdev-config is NULL. Cc: Alexander Graf ag...@suse.de Cc: Richard Henderson r...@twiddle.net Signed-off-by: Jason Wang jasow...@redhat.com --- hw/s390x/s390-virtio-bus.c |4 1 files

Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext

2013-04-26 Thread Alexey Kardashevskiy
On 04/26/2013 06:44 PM, Paolo Bonzini wrote: Il 25/04/2013 08:36, David Gibson ha scritto: On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: Il 24/04/2013 17:12, Alex Williamson ha scritto: At the moment, vfio maintains a global list of containers that are assumed to be more or

Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext

2013-04-26 Thread Paolo Bonzini
Il 26/04/2013 10:46, Alexey Kardashevskiy ha scritto: On 04/26/2013 06:44 PM, Paolo Bonzini wrote: Il 25/04/2013 08:36, David Gibson ha scritto: On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: Il 24/04/2013 17:12, Alex Williamson ha scritto: At the moment, vfio maintains a

Re: [Qemu-devel] [PATCH 04/15] target-i386: introduce apic-id property

2013-04-26 Thread Eduardo Habkost
On Fri, Apr 26, 2013 at 09:32:59AM +0200, Igor Mammedov wrote: On Thu, 25 Apr 2013 17:36:45 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Apr 25, 2013 at 04:05:26PM +0200, Igor Mammedov wrote: [...] +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque,

Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext

2013-04-26 Thread Alexey Kardashevskiy
On 04/26/2013 06:52 PM, Paolo Bonzini wrote: Il 26/04/2013 10:46, Alexey Kardashevskiy ha scritto: On 04/26/2013 06:44 PM, Paolo Bonzini wrote: Il 25/04/2013 08:36, David Gibson ha scritto: On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo Bonzini wrote: Il 24/04/2013 17:12, Alex Williamson ha

Re: [Qemu-devel] [PATCH v2 0/4] sheepdog: support online snapshot from qemu-img

2013-04-26 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 01:19:50AM +0900, MORITA Kazutaka wrote: v2: - rename reload_vdi_obj to reload_inode and use it from sd_snapshot_goto (Yuan) - use g_free instead of free (Stefan) - fix typo in the comment (Stefan) - add coroutine_fn marker to resend_aioreq Currently, we can

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: fix loadvm operation

2013-04-26 Thread Liu Yuan
On 04/25/2013 09:06 PM, MORITA Kazutaka wrote: At Thu, 25 Apr 2013 20:49:39 +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com Currently the 'loadvm' opertaion works as following: 1. switch to the snapshot 2. mark current working VDI as a snapshot 3. rely on sd_create_branch to

Re: [Qemu-devel] [PATCH 4/5] vfio: Move container list to DMAContext

2013-04-26 Thread Paolo Bonzini
Il 26/04/2013 10:56, Alexey Kardashevskiy ha scritto: On 04/26/2013 06:52 PM, Paolo Bonzini wrote: Il 26/04/2013 10:46, Alexey Kardashevskiy ha scritto: On 04/26/2013 06:44 PM, Paolo Bonzini wrote: Il 25/04/2013 08:36, David Gibson ha scritto: On Wed, Apr 24, 2013 at 06:33:33PM +0200, Paolo

Re: [Qemu-devel] [RFC PATCH v5 01/14] util: introduce gsource event abstraction

2013-04-26 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 10:47:22AM +0800, Liu Ping Fan wrote: +GPollFD *events_source_add_gfd(EventsGSource *src, int fd) +{ +GPollFD *retfd; + +retfd = g_slice_alloc(sizeof(GPollFD)); +retfd-events = 0; +retfd-fd = fd; +src-pollfds_list =

[Qemu-devel] [PATCH v3 0/2] i2c: Add AT24Cxx EEPROM model

2013-04-26 Thread Jan Kiszka
Changes in v3: - rebased over current master - addressed review comments by Andreas Färber and Peter Crosthwaite - better QOM compliance - table-driven device parametrization I also briefly looked into a libqos-based test case, but the omap wrapper just gives me

[Qemu-devel] [PATCH v3 2/2] Add AT24Cxx I2C EEPROM device model

2013-04-26 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by the size property (required for sizes 512, the blockdev sector size) or is derived from the size of the backing block

[Qemu-devel] [PATCH v3 1/2] i2c: Introduce device address mask

2013-04-26 Thread Jan Kiszka
Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the transmitted address before matching it against the stored

Re: [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource

2013-04-26 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 10:47:25AM +0800, Liu Ping Fan wrote: +static gboolean vde_handler(gpointer data) +{ +EventGSource *nsrc = (EventGSource *)data; + +if (nsrc-gfd.revents G_IO_IN) { The VDE file descriptor is a socket. Please use the full G_IO_IN | G_IO_HUP | G_IO_ERR set

Re: [Qemu-devel] [PATCH v4 3/7] hw/acpi: extract standard table headers as a standalone structure

2013-04-26 Thread Laszlo Ersek
On 04/25/13 20:47, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: +typedef struct acpi_table_std_header { +char sig[4]; /* ACPI signature (4 ASCII characters) */ +uint32_t length; /* Length of table, in bytes, including header */ +uint8_t

[Qemu-devel] [PATCH 0/7] qapi and snapshot code clean up in block layer

2013-04-26 Thread Wenchao Xia
These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better bdrv_snapshot_find(). 3 better info dumping

[Qemu-devel] [PATCH 1/7] block: drop bs_snapshots global variable

2013-04-26 Thread Wenchao Xia
From: Stefan Hajnoczi stefa...@redhat.com The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became clear that hotplug could result in a dangling pointer. While

[Qemu-devel] [PATCH 2/7] block: move bdrv_snapshot_find() to block/snapshot.c

2013-04-26 Thread Wenchao Xia
This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- block/Makefile.objs

[Qemu-devel] [PATCH 3/7] block: move snapshot code in block.c to block/snapshot.c

2013-04-26 Thread Wenchao Xia
All snapshot related code, except bdrv_snapshot_dump(), is moved to block/snapshot.c. bdrv_snapshot_dump() will be moved to another file later. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block.c |

[Qemu-devel] [PATCH 4/7] block: distinguish id and name in bdrv_find_snapshot()

2013-04-26 Thread Wenchao Xia
To make it clear about id and name in searching, the API is changed a bit to distinguish them, and caller can choose to search by id or name. If not found, *errp will be set to tip why. Note that the caller logic is changed a bit: 1) In del_existing_snapshots() called by do_savevm(), it travers

[Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code to block/qapi.c

2013-04-26 Thread Wenchao Xia
This patch is a pure code move patch, except following modification: 1 get_human_readable_size() is changed to static function. 2 dump_human_image_info() is renamed to bdrv_image_info_dump(). 3 in qmp_query_block() and qmp_query_blockstats, use bdrv_next(bs) instead of direct traverse of global

[Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-26 Thread Wenchao Xia
This patch introduce a new print function, which will output message to monitor when it present. With it, bdrv_snapshot_dump() need no more buffer and can avoid string truncation, bdrv_image_info_dump() can also be used by hmp code later, besides qemu-img code. Signed-off-by: Wenchao Xia

[Qemu-devel] [PATCH 5/7] block: move collect_snapshots() and collect_image_info() to block/qapi.c

2013-04-26 Thread Wenchao Xia
This patch adds block/qapi.c and moves the functions there. To avoid conflict and tip better, macro in header file is BLOCK_QAPI_H instead of QAPI_H. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH 04/15] target-i386: introduce apic-id property

2013-04-26 Thread Igor Mammedov
On Fri, 26 Apr 2013 05:53:55 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Apr 26, 2013 at 09:32:59AM +0200, Igor Mammedov wrote: On Thu, 25 Apr 2013 17:36:45 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Apr 25, 2013 at 04:05:26PM +0200, Igor Mammedov wrote:

Re: [Qemu-devel] [PATCH v2 05/10] target-ppc: emulate prtyw and prtyd instructions

2013-04-26 Thread Aurelien Jarno
On Fri, Apr 26, 2013 at 09:50:31AM +0200, Alexander Graf wrote: On 20.04.2013, at 20:56, Aurelien Jarno wrote: Needed for Power ISA version 2.05 compliance. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

Re: [Qemu-devel] [PATCH v4 4/7] hw/acpi: export default ACPI headers using the type just introduced

2013-04-26 Thread Laszlo Ersek
On 04/25/13 20:49, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: This enables reuse when preparing per-table fw_cfg blobs later. Signed-off-by: Laszlo Ersek ler...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/acpi.h |2 ++

Re: [Qemu-devel] [PATCH v2 05/10] target-ppc: emulate prtyw and prtyd instructions

2013-04-26 Thread Alexander Graf
On 26.04.2013, at 11:38, Aurelien Jarno wrote: On Fri, Apr 26, 2013 at 09:50:31AM +0200, Alexander Graf wrote: On 20.04.2013, at 20:56, Aurelien Jarno wrote: Needed for Power ISA version 2.05 compliance. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH] linux-user: fix compile error due to stray colon at end of #ifdef line

2013-04-26 Thread Stefan Hajnoczi
On Sun, Apr 21, 2013 at 01:30:03PM +0100, Peter Maydell wrote: Remove a stray colon from the end of a #ifdef line. Some versions of gcc complain about this: linux-user/syscall.c: In function ‘do_syscall’: linux-user/syscall.c:7606:28: error: extra tokens at end of #ifdef directive

Re: [Qemu-devel] [PATCH v2 05/10] target-ppc: emulate prtyw and prtyd instructions

2013-04-26 Thread Aurelien Jarno
On Fri, Apr 26, 2013 at 11:53:49AM +0200, Alexander Graf wrote: On 26.04.2013, at 11:38, Aurelien Jarno wrote: On Fri, Apr 26, 2013 at 09:50:31AM +0200, Alexander Graf wrote: On 20.04.2013, at 20:56, Aurelien Jarno wrote: Needed for Power ISA version 2.05 compliance.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] s390x: use CONFIG_INT128 to detect __uint128_t

2013-04-26 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 06:15:12PM +0100, Gabriel Kerneis wrote: Target s390x uses ad-hoc macro magic to guess if the compiler supports the GCC extension __uint128_t. This patch uses the the dedicated macro CONFIG_INT128 defined by configure instead. This fixes compilation with the CIL

Re: [Qemu-devel] [PATCH v6 00/20] tcg-arm improvments

2013-04-26 Thread Peter Maydell
On 23 April 2013 21:46, Richard Henderson r...@twiddle.net wrote: Changes v5-v6, feedback from Aurelien: * Drop tcg_out_goto changes. * Add Z constraint for deposit. * Small comment cleanups. * Rebase vs master. I gave this a quick spin on an A15 and an A8 -- seems to work (though I

Re: [Qemu-devel] [PATCH v2] qapi: add struct strList and visit_type_strList()

2013-04-26 Thread Amos Kong
Hi Michael, On Wed, Apr 24, 2013 at 11:46:25AM -0500, mdroth wrote: On Thu, Apr 25, 2013 at 12:08:05AM +0800, Amos Kong wrote: Currently we can only use ['String'] to add string to a list, it contains some additional JSON structure. multicast: [ { str:

Re: [Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970

2013-04-26 Thread Riku Voipio
On Fri, Apr 26, 2013 at 09:20:51AM +0200, Alexander Graf wrote: The default with linux-user for dcbz on 970 is to emulate 32 byte clears. However, redoing the dcbzl support we added a check to not honor the bit in HID5 that sets this. Remove the #ifdef check on linux user, so that we get 32

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-26 Thread Eric Blake
On 04/25/2013 11:06 PM, Jason Wang wrote: if (addr (vdev-config_len - sizeof(val))) ^ quiz: spot a bug above if config_len is 0:) Then we need to fix these bugs and allocate a CVE. virtio-rng has shipped. This code is also dumb. Ok, but since the discussion is in public

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-26 Thread Jason Wang
On 04/26/2013 06:32 PM, Eric Blake wrote: On 04/25/2013 11:06 PM, Jason Wang wrote: if (addr (vdev-config_len - sizeof(val))) ^ quiz: spot a bug above if config_len is 0:) Then we need to fix these bugs and allocate a CVE. virtio-rng has shipped. This code is also dumb.

[Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-04-26 Thread Jason Wang
Commit 32993698 (vhost: disable on tap link down) tries to disable the vhost also when the peer's link is down. But the check was not done properly, the vhost were only started when: 1) peer's link is not down 2) virtio-net has already been started. Since == have a higher precedence than , place

Re: [Qemu-devel] [PATCH v2] virtio-net: unbreak the minix guest

2013-04-26 Thread Aurelien Jarno
On Thu, Apr 25, 2013 at 03:24:23PM +0800, Jason Wang wrote: Multiqueue patchset conditionally add control vq only when guest negotiate the feature. Though the spec is not clear on this but it breaks the minix guest since it will identify the ctrl vq even if it does not support it. Though this

Re: [Qemu-devel] [PATCH] qemu-doc: Option -ignore-environment removed.

2013-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2013 at 06:41:16PM +0200, Thomas Schwinge wrote: Has been removed in commit fc9c54124d134dbd76338a92a91804dab2df8166. Signed-off-by: Thomas Schwinge tho...@codesourcery.com --- qemu-doc.texi |3 --- 1 file changed, 3 deletions(-) Thanks, applied to the trivial patches

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Track change in FreeBSD SYSCTL(9) types

2013-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2013 at 01:59:41PM -0400, Ed Maste wrote: CCing qemu-devel@nongnu.org. Originally from Garrett Cooper in FreeBSD PR ports/18 http://www.freebsd.org/cgi/query-pr.cgi?pr=18 Signed-off-by: Ed Maste ema...@freebsd.org --- bsd-user/syscall.c | 4 1 file changed,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix compilation without CONFIG_VHOST_SCSI

2013-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2013 at 01:38:28PM -0400, Ed Maste wrote: CCing qemu-devel@nongnu.org. Signed-off-by: Ed Maste ema...@freebsd.org --- hw/s390x/s390-virtio-bus.c | 2 ++ hw/s390x/virtio-ccw.c | 2 ++ hw/s390x/virtio-ccw.h | 2 ++ 3 files changed, 6 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-26 Thread Laszlo Ersek
On 04/25/13 21:03, Anthony Liguori wrote: Laszlo Ersek ler...@redhat.com writes: This patch reuses some code from SeaBIOS, which was originally under LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This relicensing has been acked by all contributors that had contributed

Re: [Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes

2013-04-26 Thread David Gibson
On Fri, Apr 26, 2013 at 10:19:55AM +0200, Paolo Bonzini wrote: Il 26/04/2013 08:02, David Gibson ha scritto: vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the helper for PCI devices, which means it was broken by Paolo Bonzini's recent addition of iommu support to the

[Qemu-devel] [PATCH 1/2] gtk: fix cursor unref

2013-04-26 Thread Gerd Hoffmann
Use correct unref function, cursors are not gobjects (at least in gtk2). Fixes crash, reproducer: qemu -vga qxl -display gtk. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index

[Qemu-devel] [PATCH 2/2] console: nicer initial screen

2013-04-26 Thread Gerd Hoffmann
Now that we have a function to create a fancy DisplaySurface with a message for the user, to handle non-existing graphics hardware, we can make it more generic and use it for other things too. This patch adds a text line to the in initial DisplaySurface, notifying the user that the display isn't

[Qemu-devel] [PATCH 0/2] console tweaks

2013-04-26 Thread Gerd Hoffmann
Hi, Two little console tweaks. One gtk bugfix, and one small usability improvement. please review, Gerd The following changes since commit e3351000cd682200835763caca87adf708ed1c65: Makefile: Use QEMU_FLAGS for DTC compilation (2013-04-26 02:48:10 +0200) are available in the git

[Qemu-devel] [PULL 0/5] Trivial patches for 20 to 26 April 2013

2013-04-26 Thread Stefan Hajnoczi
The following changes since commit e3351000cd682200835763caca87adf708ed1c65: Makefile: Use QEMU_FLAGS for DTC compilation (2013-04-26 02:48:10 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

Re: [Qemu-devel] [RFC PATCH v5 05/14] net: port socket to GSource

2013-04-26 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 10:47:26AM +0800, Liu Ping Fan wrote: @@ -141,6 +134,59 @@ static ssize_t net_socket_receive_dgram(NetClientState *nc, const uint8_t *buf, return ret; } +static gushort socket_connecting_readable(void *opaque) +{ +return G_IO_IN; +} + +static gushort

Re: [Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-26 Thread David Gibson
On Fri, Apr 26, 2013 at 10:23:40AM +0200, Paolo Bonzini wrote: Il 26/04/2013 08:02, David Gibson ha scritto: At the moment, vfio maintains a global list of containers that are assumed to be more or less interchangeable, since they are all set up with a MemoryListener to have all of system

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-26 Thread Laszlo Ersek
On 04/26/13 12:32, Eric Blake wrote: On 04/25/2013 11:06 PM, Jason Wang wrote: if (addr (vdev-config_len - sizeof(val))) ^ quiz: spot a bug above if config_len is 0:) Then we need to fix these bugs and allocate a CVE. virtio-rng has shipped. This code is also dumb. Ok,

Re: [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it

2013-04-26 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 25 Apr 2013 20:18:35 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to bdrv_dev_change_media_cb() outside the media

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: fix loadvm operation

2013-04-26 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 05:04:06PM +0800, Liu Yuan wrote: On 04/25/2013 09:06 PM, MORITA Kazutaka wrote: At Thu, 25 Apr 2013 20:49:39 +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com Currently the 'loadvm' opertaion works as following: 1. switch to the snapshot 2. mark

Re: [Qemu-devel] [PATCH v4] sheepdog: fix loadvm operation

2013-04-26 Thread Stefan Hajnoczi
On Thu, Apr 25, 2013 at 08:49:39PM +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com Currently the 'loadvm' opertaion works as following: 1. switch to the snapshot 2. mark current working VDI as a snapshot 3. rely on sd_create_branch to create a new working VDI based on the

[Qemu-devel] [PULL 00/11] Block patches

2013-04-26 Thread Stefan Hajnoczi
The following changes since commit e3351000cd682200835763caca87adf708ed1c65: Makefile: Use QEMU_FLAGS for DTC compilation (2013-04-26 02:48:10 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to

[Qemu-devel] [PATCH 01/11] block/ssh: Require libssh2 = 1.2.8.

2013-04-26 Thread Stefan Hajnoczi
From: Richard W.M. Jones rjo...@redhat.com libssh2 = 1.2.8 is required to enable this block device (because that version introduced the libssh2_session_handshake call). Change the test to use pkg-config exclusively. If the user requests --enable-libssh2 and the minimum version is not available,

[Qemu-devel] [PATCH 02/11] savevm: Implement block_writev_buffer()

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Instead of breaking up RAM state into many small chunks, pass the iovec to the block layer for better performance. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/migration/qemu-file.h | 2 +- savevm.c

[Qemu-devel] [PATCH 01/11] block: Introduce bdrv_writev_vmstate

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 25 - block/qcow2.c | 12 +--- block/sheepdog.c | 13 ++---

[Qemu-devel] [PATCH 03/11] block: Introduce bdrv_pwritev() for qcow2_save_vmstate

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Directly pass the QEMUIOVector on instead of linearising it. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 80 +-- block/qcow2.c

[Qemu-devel] [PATCH 07/11] ide: refuse WIN_READ_NATIVE_MAX on empty device

2013-04-26 Thread Stefan Hajnoczi
What is the highest addressable sector on an empty CD-ROM? Nothing is addressable so produce an error. This patch prevents a divide-by-zero in ide_set_sector() since s-sectors and s-heads would be 0. Not to mention that a sector=-1 argument would be nonsense. Note that WIN_READ_NATIVE_MAX can

[Qemu-devel] [PATCH 03/11] sheepdog: use BDRV_SECTOR_SIZE

2013-04-26 Thread Stefan Hajnoczi
From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/sheepdog.c | 11 +-- 1

[Qemu-devel] [PATCH 02/11] sheepdog: add discard/trim support for sheepdog

2013-04-26 Thread Stefan Hajnoczi
From: Liu Yuan tailai...@taobao.com The 'TRIM' command from VM that is to release underlying data storage for better thin-provision is already supported by the Sheepdog. This patch adds the TRIM support at QEMU part. For older Sheepdog that doesn't support it, we return 0(success) to upper

[Qemu-devel] [PATCH 05/11] qemu-iotests: Add test for -drive options

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/051 | 148 + tests/qemu-iotests/051.out | 162 +

[Qemu-devel] [PATCH 04/11] qemu-iotests: A few more bdrv_pread/pwrite tests

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/002 | 13 + tests/qemu-iotests/002.out | 26 ++ 2 files changed, 39 insertions(+) diff --git

[Qemu-devel] [PATCH 08/11] block: Add support for Secure Shell (ssh) block device.

2013-04-26 Thread Stefan Hajnoczi
From: Richard W.M. Jones rjo...@redhat.com qemu-system-x86_64 -drive file=ssh://hostname/some/image QEMU will ssh into 'hostname' and open '/some/image' which is made available as a standard block device. You can specify a username (ssh://user@host/...) and/or a port number

[Qemu-devel] [PATCH 07/11] sheepdog: cleanup find_vdi_name

2013-04-26 Thread Stefan Hajnoczi
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This makes 'filename' and 'tag' constant variables, and renames 'for_snapshot' to 'lock' to clear how it works. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PATCH 06/11] rbd: Fix use after free in rbd_open()

2013-04-26 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Commit a9ccedc3 frees the QemuOpts for the driver-specific options immediately, even though it still needs the filename string that is contained there. This doesn't work. Move the deletion of the QemuOpts to the end of the function where its content isn't needed

[Qemu-devel] [PATCH 11/11] sheepdog: fix loadvm operation

2013-04-26 Thread Stefan Hajnoczi
From: Liu Yuan tailai...@taobao.com Currently the 'loadvm' opertaion works as following: 1. switch to the snapshot 2. mark current working VDI as a snapshot 3. rely on sd_create_branch to create a new working VDI based on the snapshot This works not the same as other format as QCOW2. For e.g,

[Qemu-devel] [PATCH 09/11] sheepdog: add helper function to reload inode

2013-04-26 Thread Stefan Hajnoczi
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This adds a helper function to update the current inode state with the specified vdi object. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/sheepdog.c | 67

Re: [Qemu-devel] [PATCH v2] microblaze: Add internal base vectors reg

2013-04-26 Thread Andreas Färber
Hi, Am 24.04.2013 13:31, schrieb edgar.igles...@gmail.com: From: Edgar E. Iglesias edgar.igles...@gmail.com Configurable at CPU synthesis/instantiation. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- Peter Crosthwaite commented off-list that it would be a good idea to

[Qemu-devel] [PATCH 09/11] block: ssh: Use libssh2_sftp_fsync (if supported by libssh2) to flush to disk.

2013-04-26 Thread Stefan Hajnoczi
From: Richard W.M. Jones rjo...@redhat.com libssh2_sftp_fsync is an extension to libssh2 to support fsync(2) over sftp, which is itself an extension of OpenSSH. If both libssh2 and the ssh daemon support it, this will allow bdrv_flush_to_disk to commit changes through to disk on the remote

Re: [Qemu-devel] [PATCH v21 5/8] pvpanic: pass configurable ioport to seabios

2013-04-26 Thread Markus Armbruster
Hu Tao hu...@cn.fujitsu.com writes: This lets seabios patch the corresponding SSDT entry. Also add fw_cfg object to /machine/fw_cfg so we can reference it elsewhere. Signed-off-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: fix loadvm operation

2013-04-26 Thread Liu Yuan
On 04/26/2013 07:39 PM, Stefan Hajnoczi wrote: Please send patches as top-level email threads instead of replies so that they get noticed. Okay, will do for future patches. Thanks for reminding. Yuan

Re: [Qemu-devel] [PATCH v21 3/8] introduce a new qom device to deal with panicked event

2013-04-26 Thread Markus Armbruster
Hu Tao hu...@cn.fujitsu.com writes: pvpanic device is used to send guest panic event from guest to qemu. When guest panic happens, pvpanic device driver will write a event number to IO port 0x505(which is the IO port occupied by pvpanic device, by default). On receiving the event, pvpanic

[Qemu-devel] [PATCH 10/11] sheepdog: resend write requests when SD_RES_READONLY is received

2013-04-26 Thread Stefan Hajnoczi
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp When a snapshot is taken from out side of qemu (e.g. qemu-img snapshot), write requests to the current vdi return SD_RES_READONLY. In this case, the sheepdog block driver needs to update the current inode to the latest one and resend the write

Re: [Qemu-devel] [PATCH v21 4/8] fw_cfg: add required header files

2013-04-26 Thread Markus Armbruster
Hu Tao hu...@cn.fujitsu.com writes: If fw_cfg.h is included alone, gcc gives error messages like these: error: unknown type name ‘uint32_t’ error: unknown type name ‘size_t’ error: unknown type name ‘hwaddr’ ... Signed-off-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Markus

Re: [Qemu-devel] [PATCH v21 8/8] Wire up disabled wait a panicked event on s390

2013-04-26 Thread Markus Armbruster
Hu Tao hu...@cn.fujitsu.com writes: From: Christian Borntraeger borntrae...@de.ibm.com On s390 the disabled wait state indicates a state of attention. For example Linux uses that state after a panic. Lets put the system into panicked state. An alternative implementation would be to state

[Qemu-devel] [PATCH 11/11] rbd: add an asynchronous flush

2013-04-26 Thread Stefan Hajnoczi
From: Josh Durgin josh.dur...@inktank.com The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block until it is complete. This results in unresponsiveness and extra latency for the guest. Fix this by using an asynchronous

Re: [Qemu-devel] [PATCH v21 1/8] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-04-26 Thread Markus Armbruster
Hu Tao hu...@cn.fujitsu.com writes: The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Markus Armbruster arm...@redhat.com

  1   2   3   4   >