[Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

2013-09-12 Thread Frank
It is allocated by g_new0() in inet_parse(), so needs to be freed in qemu_rdma_data_init(). From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001 From: Frank Yang frank.yang...@gmail.com Date: Thu, 12 Sep 2013 21:37:56 +0800 Subject: [PATCH] rdma: memory leak InetSocketAddress

Re: [Qemu-devel] [RFC] O_EXCL or not open block device

2013-09-12 Thread Stefan Hajnoczi
On Thu, Sep 12, 2013 at 01:27:32PM +0200, Jack Wang wrote: Hi all, We're using qemu export md-raid to guest OS, and we saw deadlock on MD(which is already fixed by Neil), please see thread below: http://marc.info/?l=linux-raidm=137894040228125w=2 As Neil suggested it would be good for

Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Richard Henderson
On 09/12/2013 01:30 AM, Claudio Fontana wrote: +case INDEX_op_mov_i64: +case INDEX_op_mov_i32: +case INDEX_op_movi_i64: +case INDEX_op_movi_i32: +/* Always implemented with tcg_out_mov/i, never with tcg_out_op. */ default: -tcg_abort(); /* opcode not

Re: [Qemu-devel] [PATCH v7 5/8] module: implement module loading function

2013-09-12 Thread Daniel P. Berrange
On Thu, Sep 12, 2013 at 03:04:56PM +0800, Fam Zheng wrote: Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading function: void

Re: [Qemu-devel] [RFC] O_EXCL or not open block device

2013-09-12 Thread Kevin Wolf
Am 12.09.2013 um 15:58 hat Stefan Hajnoczi geschrieben: On Thu, Sep 12, 2013 at 01:27:32PM +0200, Jack Wang wrote: Hi all, We're using qemu export md-raid to guest OS, and we saw deadlock on MD(which is already fixed by Neil), please see thread below:

Re: [Qemu-devel] [PATCH] block: Assert validity of BdrvActionOps

2013-09-12 Thread Kevin Wolf
Am 12.09.2013 um 14:57 hat Max Reitz geschrieben: In qmp_transaction, assert that the BdrvActionOps to be used is actually valid. This assertion failing is very improbable, however, it might happen, if a new TransactionActionKind is introduced out of order and the actions[] array is not

Re: [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with make install

2013-09-12 Thread Daniel P. Berrange
On Thu, Sep 12, 2013 at 03:04:57PM +0800, Fam Zheng wrote: Install all the subdirs for modules under configure option moddir. Signed-off-by: Fam Zheng f...@redhat.com --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index ef76967..00c2a52 100644

Re: [Qemu-devel] [PATCH] block: Assert validity of BdrvActionOps

2013-09-12 Thread Eric Blake
On 09/12/2013 06:57 AM, Max Reitz wrote: In qmp_transaction, assert that the BdrvActionOps to be used is actually valid. This assertion failing is very improbable, however, it might happen, if a new TransactionActionKind is introduced out of order and the actions[] array is not updated.

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 qemu32 CPU models

2013-09-12 Thread Eduardo Habkost
On Wed, Sep 11, 2013 at 11:53:46PM +0200, Andreas Färber wrote: Am 11.09.2013 10:37, schrieb Igor Mammedov: On Wed, 11 Sep 2013 10:25:58 +0200 Andreas Färber afaer...@suse.de wrote: Am 11.09.2013 10:22, schrieb Igor Mammedov: On Tue, 10 Sep 2013 17:48:59 -0300 Eduardo Habkost

Re: [Qemu-devel] [PATCH v3 0/4] timers thread-safe stuff

2013-09-12 Thread Stefan Hajnoczi
On Thu, Sep 12, 2013 at 01:19:47PM +0200, Paolo Bonzini wrote: Il 27/08/2013 05:20, Liu Ping Fan ha scritto: Saw the Alex's patches has been merged, rebase mine onto his. v3: 1. rename seqlock_read_check as seqlock_read_retry 2. Document timerlist were protected by BQL, and discard

Re: [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block

2013-09-12 Thread Paolo Bonzini
Il 12/09/2013 14:08, Kevin Wolf ha scritto: Am 12.09.2013 um 11:31 hat Paolo Bonzini geschrieben: Il 12/09/2013 11:15, Wenchao Xia ha scritto: This series will remove the usage of symbols of mon-protocol-event in qemu-img, qemu-nbd and qemu-io, in short remove the connetion for block layer.

[Qemu-devel] [Bug 1224444] Re: virtio-serial loses writes when used over virtio-mmio

2013-09-12 Thread Richard Jones
Recall this bug only happens intermittently. This is an strace -f of qemu when it happens to work. Notes: - fd = 6 is the Unix domain socket - there are an expected number of recvmsg writes, all with the correct sizes - this time qemu adds the socket to ppoll ** Attachment added: working

[Qemu-devel] [Bug 1224444] Re: virtio-serial loses writes when used over virtio-mmio

2013-09-12 Thread Richard Jones
strace -f of qemu when it fails. Notes: - fd = 6 is the Unix domain socket connected to virtio-serial - only one 4 byte write occurs to this socket (expected guest - host communication) - the socket isn't read at all (even though the library on the other side has written) - the socket is

Re: [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-09-12 Thread Peter Maydell
On 12 September 2013 15:14, Andreas Färber andreas.faer...@web.de wrote: I don't think I have any other Cocoa patches queued - or did I miss a more acceptable version of the command-key workaround? http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg02300.html is the latest on that

Re: [Qemu-devel] [PATCH 15/16] qdev-monitor: Clean up qdev_device_add() variable naming

2013-09-12 Thread Andreas Färber
Am 30.08.2013 19:19, schrieb Andreas Färber: Am 26.08.2013 09:52, schrieb Wenchao Xia: 于 2013-8-24 8:00, Andreas Färber 写道: Avoid confusion between object and object class. between object class and device class? No the issue is that by convention we usually use Object *obj;

Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Claudio Fontana
On 12.09.2013 16:02, Richard Henderson wrote: On 09/12/2013 01:30 AM, Claudio Fontana wrote: +case INDEX_op_mov_i64: +case INDEX_op_mov_i32: +case INDEX_op_movi_i64: +case INDEX_op_movi_i32: +/* Always implemented with tcg_out_mov/i, never with tcg_out_op. */

Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-12 Thread Peter Maydell
On 12 September 2013 15:31, Claudio Fontana claudio.font...@huawei.com wrote: On 12.09.2013 16:02, Richard Henderson wrote: On 09/12/2013 01:30 AM, Claudio Fontana wrote: Ok Sadly, Ok is neither Reviewed-by or Signed-off-by There is nothing sad about it. When it's reviewed, you will know.

Re: [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-09-12 Thread Andreas Färber
Am 12.09.2013 03:23, schrieb Fam Zheng: On Wed, 09/11 17:49, Peter Maydell wrote: Delete an unnecessary dependency for cocoa.o; we already have a general rule that tells Make that we can build a .o file from a .m source using an ObjC compiler, so this specific rule is unnecessary. Further, it

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-09-12 Thread Igor Mammedov
On Wed, 21 Aug 2013 17:04:28 +0800 Hu Tao hu...@cn.fujitsu.com wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 91 -- include/hw/acpi/ich9.h | 11 ++ 2 files changed, 100 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH v5 0/8] Add metadata overlap checks

2013-09-12 Thread Eric Blake
On 09/02/2013 01:25 AM, Max Reitz wrote: If a qcow2 image file becomes corrupted, any write may inadvertently overwrite important metadata structures such as the L1 table. This series adds functionality for detecting, preventing and (to some extent) repairing such collisions. v5: - fixed

Re: [Qemu-devel] [uq/master][PATCH 0/3] Fix initialization bugs in kvmvapic

2013-09-12 Thread Paolo Bonzini
Il 03/09/2013 18:08, Jan Kiszka ha scritto: Addresses the issue Daniel reported in http://thread.gmane.org/gmane.comp.emulators.qemu/231577 CC: qemu-sta...@nongnu.org Jan Kiszka (3): kvmvapic: Catch invalid ROM size kvmvapic: Enter inactive state on hardware reset kvmvapic:

[Qemu-devel] [Bug 1224414] [NEW] dtc/.git file included in release tarball

2013-09-12 Thread Olof Johansson
Public bug reported: The release tarballs include the dtc/.git submodule file, causing when working git in some circumstances (e.g. doing git clean -fxd in a parent git repository): $ mkdir foo cd foo $ git init $ echo yo bar $ curl http://wiki.qemu-project.org/download/qemu-1.6.0.tar.bz2 $ tar

Re: [Qemu-devel] [PATCH] linux-headers: update to 3.11

2013-09-12 Thread Paolo Bonzini
Il 03/09/2013 10:27, Alexey Kardashevskiy ha scritto: Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- I need this update as VFIO on PPC64/pseries got in upstream kernel and this is required by VFIO-SPAPR bits in QEMU. Others may find this update useful too :) ---

Re: [Qemu-devel] [PATCH v6] kvm irqfd: support direct msimessage to irq translation

2013-09-12 Thread Paolo Bonzini
Il 03/09/2013 10:08, Alexey Kardashevskiy ha scritto: On PPC64 systems MSI Messages are translated to system IRQ in a PCI host bridge. This is already supported for emulated MSI/MSIX but not for irqfd where the current QEMU allocates IRQ numbers from irqchip and maps MSIMessages to IRQ in the

[Qemu-devel] [RFC] O_EXCL or not open block device

2013-09-12 Thread Jack Wang
Hi all, We're using qemu export md-raid to guest OS, and we saw deadlock on MD(which is already fixed by Neil), please see thread below: http://marc.info/?l=linux-raidm=137894040228125w=2 As Neil suggested it would be good for userspace applications to call open() with O_EXCL flag, to avoid

Re: [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d

2013-09-12 Thread Paolo Bonzini
Il 09/09/2013 14:07, Stefan Hajnoczi ha scritto: On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote: KVM request types are normally defined using hex constants but QEMU traces print decimal values instead, which is not very convenient. This changes the request type format

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-09-12 Thread Christoffer Dall
On Thu, Sep 12, 2013 at 11:17:50AM +0100, Peter Maydell wrote: This patch series adds a 'virt' platform which uses the kernel's mach-virt (fully device-tree driven) support to create a simple minimalist platform intended for use for KVM VM guests. looks good to me. fwiw Reviewed-by:

Re: [Qemu-devel] [RFC] O_EXCL or not open block device

2013-09-12 Thread Jack Wang
On 09/12/2013 04:27 PM, Kevin Wolf wrote: Am 12.09.2013 um 15:58 hat Stefan Hajnoczi geschrieben: On Thu, Sep 12, 2013 at 01:27:32PM +0200, Jack Wang wrote: Hi all, We're using qemu export md-raid to guest OS, and we saw deadlock on MD(which is already fixed by Neil), please see thread

Re: [Qemu-devel] [PULL] s390: cleanups and fixes

2013-09-12 Thread Anthony Liguori
On Thu, Sep 12, 2013 at 10:21 AM, Christian Borntraeger borntrae...@de.ibm.com wrote: On 03/09/13 21:08, Christian Borntraeger wrote: Anthony, The following changes since commit 4ff78e0dbcd5c795962567fdc1b31e9e03c55b07: Merge remote-tracking branch 'luiz/queue/qmp' into staging

Re: [Qemu-devel] [PATCH] *-user: Improve documentation for lock_user function

2013-09-12 Thread Eric Blake
On 09/12/2013 11:57 AM, Stefan Weil wrote: Add a missing function and replace and by any. BSD und Linux use the same documentation here, so fix both. s/und/and/ -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description:

[Qemu-devel] [PATCH] *-user: Fix typo in comment (ulocking - unlocking)

2013-09-12 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/qemu.h |2 +- linux-user/qemu.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 1998af6..ddc74ed 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -381,7 +381,7 @@

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-09-12 Thread Peter Maydell
Ping^4! thanks -- PMM On 2 September 2013 09:24, Peter Maydell peter.mayd...@linaro.org wrote: Ping^3! thanks -- PMM On 20 August 2013 13:59, Peter Maydell peter.mayd...@linaro.org wrote: Ping^2! This has been reviewed and I've checked that the patch still applies to master. thanks --

Re: [Qemu-devel] [PULL] s390: cleanups and fixes

2013-09-12 Thread Christian Borntraeger
On 03/09/13 21:08, Christian Borntraeger wrote: Anthony, The following changes since commit 4ff78e0dbcd5c795962567fdc1b31e9e03c55b07: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-08-30 12:26:04 -0500) are available in the git repository at:

[Qemu-devel] [PATCH] ivshmem: allow the sharing of hugepages

2013-09-12 Thread Damien Millescamps
According to shm_open specifications: A shared memory object should be identified by a name of the form /somename; that is, a null-terminated string of up to NAME_MAX (i.e., 255) characters consisting of an initial slash, followed by one or more characters, none of which are slashes. This

[Qemu-devel] [PATCH] translate-all: Fix formatting of dump output

2013-09-12 Thread Stefan Weil
The page dump writes a table with 3 abi_ulong values in each row. These values take 8 or 16 characters (depending on sizeof abi_ulong). Fix the table headings to be aligned with the table columns. old: startend size prot 00012000-00012021e000 0021e000 rwx

[Qemu-devel] ping Re: [PATCH] target-i386: fix disassembly with PAE=1, PG=0

2013-09-12 Thread Paolo Bonzini
Il 30/08/2013 11:58, Paolo Bonzini ha scritto: CR4.PAE=1 will not enable paging if CR0.PG=0, but the if chain in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG before everything else. Fixes -d in_asm for a code section at the beginning of OVMF. Cc: Richard Henderson

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-12 Thread Scott Wood
On Thu, 2013-09-12 at 04:18 -0500, Bhushan Bharat-R65777 wrote: -Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Wednesday, September 11, 2013 10:45 PM To: Yoder Stuart-B08248 Cc: Wood Scott-B07421; Sethi Varun-B16395; Bhushan Bharat-R65777;

Re: [Qemu-devel] [PATCH] *-user: Improve documentation for lock_user function

2013-09-12 Thread Peter Maydell
On 12 September 2013 18:57, Stefan Weil s...@weilnetz.de wrote: Add a missing function and replace and by any. BSD und Linux use the same documentation here, so fix both. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

[Qemu-devel] [PATCH] MAINTAINERS: Add missing entry to filelist for TCI target

2013-09-12 Thread Stefan Weil
tci.c is also a maintained part of the TCI implementation. Signed-off-by: Stefan Weil s...@weilnetz.de --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d128ed0..4d634f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -842,6 +842,7 @@ TCI target

[Qemu-devel] [PULL 1/2] target-i386: fix disassembly with PAE=1, PG=0

2013-09-12 Thread Richard Henderson
From: Paolo Bonzini pbonz...@redhat.com CR4.PAE=1 will not enable paging if CR0.PG=0, but the if chain in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG before everything else. Fixes -d in_asm for a code section at the beginning of OVMF. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 2/2] target-i386: Only provide CMOV and friends if feature bit set

2013-09-12 Thread Richard Henderson
From: Peter Maydell peter.mayd...@linaro.org The instructions CMOVcc, FCMOVcc and F[U]COMI[P] should only be present if the CMOV feature bit is set. Add missing feature bit checks so we correctly fault if emulating a 486 or 586. This fixes bug LP:1201446. Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 0/2] Outstanding target-i386 patches

2013-09-12 Thread Richard Henderson
These two have been hanging out, reviewed, for a month or more with no one picking them up. I wondered if a pull req might help. ;-) r~ The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551: Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into

Re: [Qemu-devel] [PATCH 1/2] ich9: update sci on gpe write

2013-09-12 Thread Igor Mammedov
On Wed, 21 Aug 2013 17:04:27 +0800 Hu Tao hu...@cn.fujitsu.com wrote: OSPM may disable the sci by clearing GPEx_BLK EN bit, in the case we have to set sci level to 0 or guest will receive sci interrupts endlessly. Could you make a more verbose comment, referring to relevant ACPI spec chapter

Re: [Qemu-devel] [PATCH v5 0/8] Add metadata overlap checks

2013-09-12 Thread Max Reitz
On 2013-09-12 16:57, Eric Blake wrote: On 09/02/2013 01:25 AM, Max Reitz wrote: If a qcow2 image file becomes corrupted, any write may inadvertently overwrite important metadata structures such as the L1 table. This series adds functionality for detecting, preventing and (to some extent)

[Qemu-devel] [PATCH] *-user: Improve documentation for lock_user function

2013-09-12 Thread Stefan Weil
Add a missing function and replace and by any. BSD und Linux use the same documentation here, so fix both. Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/qemu.h |4 ++-- linux-user/qemu.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bsd-user/qemu.h

[Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
Debian busybox-static for alpha has a load address of 0x00012000 which is mapped to 0x2000 for 32 bit hosts. qemu-alpha uses the TCG opcodes qemu_ld32, qemu_ld64, qemu_st32 and qemu_st64 which all raise the assertion (taddr == host_addr). Remove all assertions of this type

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Richard Henderson
On 09/12/2013 11:17 AM, Stefan Weil wrote: @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(tb_ptr)); #else host_addr = (tcg_target_ulong)taddr; -assert(taddr ==

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add missing entry to filelist for TCI target

2013-09-12 Thread Richard Henderson
On 09/12/2013 11:24 AM, Stefan Weil wrote: tci.c is also a maintained part of the TCI implementation. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Richard Henderson r...@twiddle.net r~

Re: [Qemu-devel] [PATCH] *-user: Fix typo in comment (ulocking - unlocking)

2013-09-12 Thread Peter Maydell
On 12 September 2013 18:57, Stefan Weil s...@weilnetz.de wrote: Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

[Qemu-devel] [PULLv2 3/6] s390/ipl: Fix waiting for virtio processing

2013-09-12 Thread Christian Borntraeger
From: Cornelia Huck cornelia.h...@de.ibm.com The guest side must not manipulate the index for the used buffers. Instead, remember the state of the used buffer locally and wait until it has moved. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Alexander Graf ag...@suse.de

Re: [Qemu-devel] [PATCH 3/3] misc: Use new rotate functions

2013-09-12 Thread Richard Henderson
On 09/12/2013 12:13 PM, Stefan Weil wrote: Signed-off-by: Stefan Weil s...@weilnetz.de --- target-arm/iwmmxt_helper.c |2 +- tcg/optimize.c | 12 tci.c |8 3 files changed, 9 insertions(+), 13 deletions(-) Reviewed by:

[Qemu-devel] [PULLv2 2/6] s390/dump: zero out padding bytes in notes sections

2013-09-12 Thread Christian Borntraeger
The prstatus of an s390x dump contains several padding areas. Zero out these bytes to make reading the notes section easier with a hexdump. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- target-s390x/arch_dump.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULLv2 5/6] s390/cpu: Make setcc() function available to other files

2013-09-12 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com Moved the setcc() function to cpu.h so that it can be used by other files, too. It now also does not modify the kvm state anymore since this gets updated during kvm_arch_put_registers() anyway. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com

[Qemu-devel] [PULLv2 1/6] s390/kvm: Add check for priviledged SCLP handler

2013-09-12 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The SCLP instruction is priviledged, so we should make sure that we generate an exception when it is called from the problem state. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com ---

[Qemu-devel] [PULLv2 4/6] s390/ipl: Update the s390-ccw.img rom

2013-09-12 Thread Christian Borntraeger
Rebuild of the virtio-ccw rom containing these patches: 1. s390/ipl: Fix waiting for virtio processing Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- pc-bios/s390-ccw.img | Bin 9432 - 9336 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img

Re: [Qemu-devel] [Qemu-trivial] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it

2013-09-12 Thread Michael Tokarev
05.09.2013 14:54, Michal Privoznik wrote: Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Thanks, applied to the trivial-patches queue (combined with the

[Qemu-devel] [PATCH] Python-lang gdb script to extract x86_64 guest vmcore from qemu coredump

2013-09-12 Thread Laszlo Ersek
When qemu dies unexpectedly, for example in response to an explicit abort() call, or (more importantly) when an external signal is delivered to it that results in a coredump, sometimes it is useful to extract the guest vmcore from the qemu process' memory image. The guest vmcore might help

[Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Stefan Weil
This fixes TCI on ARM hosts (tested with Debian's busybox-static running in linux-user emulation). Signed-off-by: Stefan Weil s...@weilnetz.de --- configure| 63 ++ tcg/tci/tcg-target.h |6 - 2 files changed, 68 insertions(+),

Re: [Qemu-devel] MSI-X doesn't work when running Windows as guest

2013-09-12 Thread Eduardo Habkost
On Thu, Sep 12, 2013 at 11:42:17AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 12, 2013 at 11:23:46AM +0300, Gal Hammer wrote: Hi, I've notice that the virtio-serial Windows' driver doesn't use MSI-X vectors when running using upstream qemu or qemu-kvm-1.2.2-13.fc18.x86_64. The same

[Qemu-devel] [PATCH 3/3] misc: Use new rotate functions

2013-09-12 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- target-arm/iwmmxt_helper.c |2 +- tcg/optimize.c | 12 tci.c |8 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/target-arm/iwmmxt_helper.c b/target-arm/iwmmxt_helper.c

[Qemu-devel] [PULLv2 6/6] s390/ioinst: Moved the CC setting to the IO instruction handlers

2013-09-12 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The IO instruction handlers now take care of setting the CC value on their own, so that the confusing return code magic in kvm_handle_css_inst() is not needed anymore. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 2/3] bitops: Add rotate functions (rol8, ror8, ...)

2013-09-12 Thread Richard Henderson
On 09/12/2013 12:13 PM, Stefan Weil wrote: These functions were copies from include/linux/bitopts.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- include/qemu/bitops.h | 82 + 1 file changed, 82 insertions(+) Reviewed-by: Richard

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
Am 12.09.2013 20:39, schrieb Richard Henderson: On 09/12/2013 11:17 AM, Stefan Weil wrote: @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(tb_ptr)); #else host_addr =

[Qemu-devel] [PATCH 2/3] bitops: Add rotate functions (rol8, ror8, ...)

2013-09-12 Thread Stefan Weil
These functions were copies from include/linux/bitopts.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- include/qemu/bitops.h | 82 + 1 file changed, 82 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index

[Qemu-devel] [PATCH 0/3] Add and use bit rotate functions

2013-09-12 Thread Stefan Weil
The first patch was already sent to qemu-devel and is only included here because patch 3 is based on it. Only patch 1 is needed for qemu-stable. It looks like shift values of 0 or 32/64 work as expected because the compiler knows the pattern used to implement the rotate operation, so the code

Re: [Qemu-devel] [PATCH 0/3] Add and use bit rotate functions

2013-09-12 Thread Richard Henderson
On 09/12/2013 12:13 PM, Stefan Weil wrote: The first patch was already sent to qemu-devel and is only included here because patch 3 is based on it. Only patch 1 is needed for qemu-stable. It looks like shift values of 0 or 32/64 work as expected because the compiler knows the pattern used to

[Qemu-devel] [PATCH 1/3] tci: Add implementation of rotl_i64, rotr_i64

2013-09-12 Thread Stefan Weil
It is used by qemu-ppc64 when running Debian's busybox-static. Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Richard Henderson r...@twiddle.net --- tcg/tci/tcg-target.c |1 - tci.c| 10 +- 2 files changed, 9

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
Am 12.09.2013 22:07, schrieb Richard Henderson: On 09/12/2013 11:57 AM, Stefan Weil wrote: Thanks for your hint. Yes, as you can see from tcg/tci/README,the test matrix of TCI did not include big endian hosts up to now. Testing on an emulated big endian Malta system is terribly slow, and I

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Richard Henderson
On 09/12/2013 11:57 AM, Stefan Weil wrote: Thanks for your hint. Yes, as you can see from tcg/tci/README,the test matrix of TCI did not include big endian hosts up to now. Testing on an emulated big endian Malta system is terribly slow, and I have no access to real big endian hardware

Re: [Qemu-devel] [PATCH] *-user: Improve documentation for lock_user function

2013-09-12 Thread Stefan Weil
Am 12.09.2013 20:26, schrieb Eric Blake: On 09/12/2013 11:57 AM, Stefan Weil wrote: Add a missing function and replace and by any. BSD und Linux use the same documentation here, so fix both. s/und/and/ Indeed, thanks. Well, I am German, so I may write und. :-) Perhaps this can be fixed when

[Qemu-devel] [PULLv2 0/6] s390: cleanups and fixes

2013-09-12 Thread Christian Borntraeger
Anthony, The following changes since commit 4ff78e0dbcd5c795962567fdc1b31e9e03c55b07: Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-08-30 12:26:04 -0500) are available in the git repository at: git://github.com/borntraeger/qemu.git tags/s390-20130902 for you to fetch

Re: [Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Stefan Weil
Am 12.09.2013 22:29, schrieb Richard Henderson: On 09/12/2013 12:45 PM, Stefan Weil wrote: +cat $TMPC EOF +#include stdbool.h +#include stdio.h +#include stdint.h +#include inttypes.h +static bool call_align_args(uint32_t arg1, uint64_t arg2) { + if (arg2 == 0x0003004ULL || arg2

Re: [Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Peter Maydell
On 12 September 2013 20:45, Stefan Weil s...@weilnetz.de wrote: +else + + # Cross compilation, so we cannot launch a program. Require configure argument. + error_exit Unknown function argument alignment \ + The TCG interpreter must know the alignment of function arguments. \

Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-12 Thread Stefan Weil
Am 12.09.2013 22:28, schrieb Stefan Weil: TCI passes your smoke-test on i686, x86_64 and maybe also on ARM hosts (ARM is still running, up to now it got the first line of the test done). ARM finished the test successfully now, too.

Re: [Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Richard Henderson
On 09/12/2013 12:45 PM, Stefan Weil wrote: +cat $TMPC EOF +#include stdbool.h +#include stdio.h +#include stdint.h +#include inttypes.h +static bool call_align_args(uint32_t arg1, uint64_t arg2) { + if (arg2 == 0x0003004ULL || arg2 == 0x00040003ULL) { +return true;

[Qemu-devel] [RFC PATCH] vfio-pci: Make use of new KVM-VFIO device

2013-09-12 Thread Alex Williamson
Add and remove groups from the KVM virtual VFIO device as we make use of them. This allows KVM to optimize for performance and correctness based on properties of the group. Signed-off-by: Alex Williamson alex.william...@redhat.com --- This patch is enabled by: [RFC PATCH 0/3] kvm/vfio: Manage

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-12 Thread Alexander Graf
On 12.09.2013, at 13:10, Scott Wood wrote: On Thu, 2013-09-12 at 04:18 -0500, Bhushan Bharat-R65777 wrote: -Original Message- From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Wednesday, September 11, 2013 10:45 PM To: Yoder Stuart-B08248 Cc: Wood Scott-B07421;

Re: [Qemu-devel] [PATCH] tci: Detect function argument alignment

2013-09-12 Thread Richard Henderson
On 09/12/2013 01:40 PM, Stefan Weil wrote: Am 12.09.2013 22:29, schrieb Richard Henderson: On 09/12/2013 12:45 PM, Stefan Weil wrote: +cat $TMPC EOF +#include stdbool.h +#include stdio.h +#include stdint.h +#include inttypes.h +static bool call_align_args(uint32_t arg1, uint64_t arg2) {

Re: [Qemu-devel] MSI-X doesn't work when running Windows as guest

2013-09-12 Thread Michael S. Tsirkin
On Thu, Sep 12, 2013 at 04:45:01PM -0300, Eduardo Habkost wrote: On Thu, Sep 12, 2013 at 11:42:17AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 12, 2013 at 11:23:46AM +0300, Gal Hammer wrote: Hi, I've notice that the virtio-serial Windows' driver doesn't use MSI-X vectors when

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-12 Thread Scott Wood
On Thu, 2013-09-12 at 16:48 -0500, Alexander Graf wrote: On 12.09.2013, at 16:45, Scott Wood wrote: On Thu, 2013-09-12 at 16:23 -0500, Alexander Graf wrote: On 12.09.2013, at 13:10, Scott Wood wrote: On Thu, 2013-09-12 at 04:18 -0500, Bhushan Bharat-R65777 wrote: and device disabling

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-12 Thread Scott Wood
On Thu, 2013-09-12 at 16:23 -0500, Alexander Graf wrote: On 12.09.2013, at 13:10, Scott Wood wrote: On Thu, 2013-09-12 at 04:18 -0500, Bhushan Bharat-R65777 wrote: and device disabling is not a standard like PCI. Do you think that we might need to do some device specific handling.

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-12 Thread Alexander Graf
On 12.09.2013, at 16:45, Scott Wood wrote: On Thu, 2013-09-12 at 16:23 -0500, Alexander Graf wrote: On 12.09.2013, at 13:10, Scott Wood wrote: On Thu, 2013-09-12 at 04:18 -0500, Bhushan Bharat-R65777 wrote: and device disabling is not a standard like PCI. Do you think that we might need

Re: [Qemu-devel] [RFC] O_EXCL or not open block device

2013-09-12 Thread NeilBrown
On Thu, 12 Sep 2013 16:27:50 +0200 Kevin Wolf kw...@redhat.com wrote: Am 12.09.2013 um 15:58 hat Stefan Hajnoczi geschrieben: On Thu, Sep 12, 2013 at 01:27:32PM +0200, Jack Wang wrote: Hi all, We're using qemu export md-raid to guest OS, and we saw deadlock on MD(which is already

Re: [Qemu-devel] Buildbot Failures

2013-09-12 Thread Brad Smith
On 29/08/13 5:57 AM, Charlie Shepherd wrote: Hi all, This is an attempt to do some triaging of the 18 current buildbot failures[1]. default_openbsd_current (offline): http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/509/steps/compile/logs/stdio AS

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-09-12 Thread Brad Smith
On 20/01/13 1:12 PM, David Woodhouse wrote: The PCI Firmware Specification apparently requires that the PCI Data Structure be DWORD-aligned. The implementation in OVMF also requires this, so vgabios ROMs don't work there. With this fixed, I can now initialise the VGA ROM from EFI, and EFI can

Re: [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with make install

2013-09-12 Thread Fam Zheng
On Thu, 09/12 15:06, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 03:04:57PM +0800, Fam Zheng wrote: Install all the subdirs for modules under configure option moddir. Signed-off-by: Fam Zheng f...@redhat.com --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [Qemu-devel] [PATCH v7 5/8] module: implement module loading function

2013-09-12 Thread Fam Zheng
On Thu, 09/12 15:08, Daniel P. Berrange wrote: On Thu, Sep 12, 2013 at 03:04:56PM +0800, Fam Zheng wrote: Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, }

Re: [Qemu-devel] MSI-X doesn't work when running Windows as guest

2013-09-12 Thread Eduardo Habkost
On Fri, Sep 13, 2013 at 12:03:40AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 12, 2013 at 04:45:01PM -0300, Eduardo Habkost wrote: On Thu, Sep 12, 2013 at 11:42:17AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 12, 2013 at 11:23:46AM +0300, Gal Hammer wrote: Hi, I've notice

[Qemu-devel] [RFC v2 0/2] use sizes.h macros for power-of-two sizes

2013-09-12 Thread Antony Pavlov
Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta:

[Qemu-devel] [RFC v2 1/2] include/qemu: introduce sizes.h

2013-09-12 Thread Antony Pavlov
The header file sizes.h is used in linux kernel, barebox bootloader and u-boot bootloader. It provides the short and easy-to-read names for power-of-two numbers. The numbers like this are othen used for memory range sizes. Signed-off-by: Antony Pavlov antonynpav...@gmail.com Reviewed-by: Aurelien

[Qemu-devel] [RFC v2 2/2] hw/mips: use sizes.h macros

2013-09-12 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com Reviewed-by: Aurelien Jarno aurel...@aurel32.net --- hw/mips/mips_malta.c | 25 + include/hw/mips/bios.h | 3 ++- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/mips/mips_malta.c

[Qemu-devel] [Bug 1019179] Re: vCPU hot-add makes the guest abort

2013-09-12 Thread chao zhou
qemu-kvm.git has merged to qemu.git, upstream qemu doesn't have cpu_set command. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1019179 Title: vCPU hot-add makes the guest abort Status in QEMU:

[Qemu-devel] [Bug 1019179] Re: vCPU hot-add makes the guest abort

2013-09-12 Thread chao zhou
** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1019179 Title: vCPU hot-add makes the guest abort Status in QEMU: Invalid Bug description:

Re: [Qemu-devel] [PATCH 4/4] arm: vgic device control api support

2013-09-12 Thread Christoffer Dall
On Fri, Sep 06, 2013 at 02:34:40PM +0100, Peter Maydell wrote: On 23 August 2013 20:41, Christoffer Dall christoffer.d...@linaro.org wrote: Support creating the ARM vgic device through the device control API and setting the base address for the distributor and cpu interfaces in KVM VMs

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-12 Thread David Gibson
On Mon, Sep 09, 2013 at 08:06:53AM +0200, Alexander Graf wrote: Am 09.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 09/09/2013 03:50 PM, Alexander Graf wrote: Am 09.09.2013 um 04:40 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 09/06/2013 01:11 AM,

Re: [Qemu-devel] [RFC v2 1/2] include/qemu: introduce sizes.h

2013-09-12 Thread Stefan Weil
Am 13.09.2013 06:33, schrieb Antony Pavlov: The header file sizes.h is used in linux kernel, barebox bootloader and u-boot bootloader. It provides the short and easy-to-read names for power-of-two numbers. The numbers like this are othen used for memory range sizes. Signed-off-by: Antony

[Qemu-devel] Wiki vandalism

2013-09-12 Thread Michal Privoznik
So I've just got another trivial patch ACKed. Yay! So I wanted to check it out in the next-trivial branch. Therefore I went on the qemu-trivial wiki and found two things: 1) Plenty of wiki vandalism (tracked down to user Jennypear [2]), e.g. appending ads in URL form to several pages [2] 2) The

<    1   2