Re: [Qemu-devel] [PATCH for-1.7] atomic.h: Fix build with clang

2013-11-10 Thread Paolo Bonzini
Il 09/11/2013 19:09, Peter Maydell ha scritto: Ping! This is needed as a build-fix for MacOSX and didn't make it into 1.7-rc0. Paolo, can I get you to review this? I thought I already had done that, anyway: diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 0aa8913..492bce1

[Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Phi Debian
Hi All, I implemented guest-dump-memory for arm32, and bumped in something strange, the PT_LOADs generated from dump.c are not target page aligned. There are some advantage to get PT_LOAD aligned. This mail is to ask advise about patch I could submit later if wanted. Would it be desirable to

Re: [Qemu-devel] [PATCH 2/2] exec: make address spaces 64-bit wide

2013-11-10 Thread Michael S. Tsirkin
On Thu, Nov 07, 2013 at 05:14:37PM +0100, Paolo Bonzini wrote: As an alternative to commit 818f86b (exec: limit system memory size, 2013-11-04) let's just make all address spaces 64-bit wide. This eliminates problems with phys_page_find ignoring bits above TARGET_PHYS_ADDR_SPACE_BITS and

Re: [Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-10 Thread Michael S. Tsirkin
On Fri, Nov 08, 2013 at 06:33:12PM +0100, Igor Mammedov wrote: On Fri, 8 Nov 2013 12:22:12 +0200 Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: Hi, On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote: On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-10 Thread Michael S. Tsirkin
On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- 8 -- Subject: [PATCH] e1000/rtl8139: update HMP NIC when every bit is written We

[Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches

2013-11-10 Thread Marcel Apfelbaum
The master-abort patch introduced a background memory region covering all 64 bit pci address space, the visible parts being the unused pci-holes addresses. The patch revealed the following issues: 1. Some memory regions have INT64_MAX size, but the size was supposed to be UINT64_MAX (meaning

[Qemu-devel] [PATCH for-1.7 1/2] Revert hw/pci: partially handle pci master abort

2013-11-10 Thread Marcel Apfelbaum
This reverts commit a53ae8e934cd54686875b5bcfc2f434244ee55d6. The master-abort patch introduced a background memory region covering all 64 bit pci address space, the visible parts being the unused pci-holes addresses. The patch revealed the following issues: 1. Some memory regions have

[Qemu-devel] [PATCH for-1.7 2/2] Revert exec: limit system memory size

2013-11-10 Thread Marcel Apfelbaum
From: Michael S. Tsirkin m...@redhat.com This reverts commit 818f86b88394b7b2b59d313e51043fe15a8004db. This was a work-around for bugs elsewhere in the system, exposed by commit a53ae8e934cd54686875b5bcfc2f434244ee55d6: hw/pci: partially handle pci master abort since that's reverted now, the

Re: [Qemu-devel] [PATCH for-1.7 0/2] revert master abort related patches

2013-11-10 Thread Michael S. Tsirkin
On Sun, Nov 10, 2013 at 02:15:23PM +0200, Marcel Apfelbaum wrote: The master-abort patch introduced a background memory region covering all 64 bit pci address space, the visible parts being the unused pci-holes addresses. The patch revealed the following issues: 1. Some memory regions have

[Qemu-devel] [PATCH 2/2] trace: Remove trace.h from hw/usb/hcd-ehci.h (less dependencies)

2013-11-10 Thread Stefan Weil
This reduces the dependencies on trace.h. Only one source file which needs hcd-ehci.h also needs trace.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch reduces the number of .o files which depend on trace.h in a default QEMU build from 382 to 379. That's not a big reduction, but

[Qemu-devel] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)

2013-11-10 Thread Stefan Weil
This reduces the dependencies on trace.h. Only two source files which need console.h also need trace.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- Without this patch, 449 .o files depend on trace.h and must be rebuild whenever the file trace-events is changed. The patch reduces this number

[Qemu-devel] [PATCH] console: Remove unused debug code

2013-11-10 Thread Stefan Weil
The local function console_print_text_attributes is no longer used since commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f. Signed-off-by: Stefan Weil s...@weilnetz.de --- ui/console.c | 33 - 1 file changed, 33 deletions(-) diff --git a/ui/console.c

[Qemu-devel] [PATCH] console: Replace conditional debug messages by trace methods

2013-11-10 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch needs my previous patch which added trace.h, see http://patchwork.ozlabs.org/patch/290045/. trace-events |2 ++ ui/console.c | 11 +++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/trace-events

[Qemu-devel] [PATCH] gtk: Replace conditional debug messages by trace methods

2013-11-10 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- trace-events |5 + ui/gtk.c | 19 +-- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/trace-events b/trace-events index 8695e9e..360f684 100644 --- a/trace-events +++ b/trace-events @@ -1020,6 +1020,11

[Qemu-devel] Buildbot failures (XEN)

2013-11-10 Thread Stefan Weil
Hi Stefan, hi Alex, could you please have a look at these buildbots (maybe others, too): xen_i386_debian_6_0 xen_x86_64_debian_6_0 Both fail during the configuration: ERROR: unknown option --disable-debug-info Either the git repository should be updated (it is obviously more than a year old),

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-11-10 Thread debfreak
I have the same problem. I tried it with qemu 1.4 and the last 1.6.0-dfsg-2 on a debian testing system. Win 7 says always This device cannot start. (Code 10). I tried a lot of usb sticks but always the same... I hope there will be sometime a solution for this :( I wait over a year in the hope

[Qemu-devel] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW

2013-11-10 Thread Stefan Weil
While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny (gcc-mingw32 4.4.2-3) shows these errors: In file included from qga/vss-win32.c:17: qga/vss-win32/requester.h:31: error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init« qga/vss-win32/requester.h:32:

[Qemu-devel] Buildbot failures (MinGW)

2013-11-10 Thread Stefan Weil
Hello Gerd, could you please install bison and flex on the buildbot machine for default_mingw? That would fix some errors in the dtc build: BISON dtc-parser.tab.c make[1]: bison: Command not found LEX dtc-lexer.lex.c make[1]: flex: Command not found See

[Qemu-devel] [PATCH] ui/sdl2 : initial port to SDL 2.0

2013-11-10 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Laszlo Ersek
On 11/10/13 10:10, Phi Debian wrote: Hi All, I implemented guest-dump-memory for arm32, and bumped in something strange, the PT_LOADs generated from dump.c are not target page aligned. There are some advantage to get PT_LOAD aligned. This mail is to ask advise about patch I could submit

Re: [Qemu-devel] [PATCH V5 6/6] qemu-iotests: add test for qcow2 snapshot

2013-11-10 Thread Wenchao Xia
于 2013/11/9 4:50, Jeff Cody 写道: On Tue, Nov 05, 2013 at 08:01:29AM +0800, Wenchao Xia wrote: This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors.

Re: [Qemu-devel] [PATCH V4 5/5] qemu-iotests: add test for snapshot in qemu-img convert

2013-11-10 Thread Wenchao Xia
于 2013/11/9 1:18, Jeff Cody 写道: On Fri, Oct 11, 2013 at 10:33:31AM +0800, Wenchao Xia wrote: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 19 ++- tests/qemu-iotests/058.out | 12 2 files changed, 30 insertions(+), 1

[Qemu-devel] i386: pc: align gpa-hpa on 1GB boundary (v5)

2013-11-10 Thread Marcelo Tosatti
v2: condition enablement of new mapping to new machine types (Paolo) v3: fix changelog v4: rebase v5: ensure alignment of piecetwo on 2MB GPA (Igor) do not register zero-sized piece-one(Igor) - Align guest physical address and host physical address beyond guest 4GB on a 1GB boundary.

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-10 Thread Phi Debian
Hi All, Sorry Laszlo for flooding your mailbox, I missed the 'reply to all' so I redo the post here. And I added some more comment at the end to answer your questions. Phi == CU82$ /usr/bin/readelf -a vmcore ELF Header: Magic: 7f 45 4c

[Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-10 Thread Amos Kong
mac_table was always cleaned up first in handling VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover mac_table content in error state, it's not correct. This patch makes all the changes in temporal variables, only update the real mac_table if everything is ok. We won't change mac_table

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic icc_bus

2013-11-10 Thread 赵小强
于 11/05/2013 04:51 PM, 赵小强 写道: 于 2013年11月05日 16:25, Chen Fan 写道: On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote: changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent

Re: [Qemu-devel] [PATCH] ui/sdl2 : initial port to SDL 2.0

2013-11-10 Thread Anthony Liguori
On Sun, Nov 10, 2013 at 3:15 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to

Re: [Qemu-devel] [PATCH] qdev-properties-system.c: Allow vlan or netdev for -device, not both

2013-11-10 Thread Jason Wang
On 11/08/2013 10:13 AM, Vlad Yasevich wrote: It is currently possible to specify things like: -device e1000,netdev=foo,vlan=1 With this usage, whichever argument was specified last (vlan or netdev) overwrites what was previousely set and results in a non-working configuration. Even

[Qemu-devel] [PATCH V5 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-11-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 102 tests/qemu-iotests/058.out | 32 ++ tests/qemu-iotests/check |1 + tests/qemu-iotests/group |1 + 4 files changed, 136 insertions(+),

[Qemu-devel] [PATCH V5 0/5] export internal snapshot by qemu-nbd

2013-11-10 Thread Wenchao Xia
This series allow user to read internal snapshot's contents without qemu-img convert. V2: Address Stefan's comments: 02: add 'fall through' comments in the case statement. 03: add doc about the difference of internal snapshot and backing chain snapshot, which is used in previous

[Qemu-devel] [PATCH V5 2/5] qemu-nbd: support internal snapshot export

2013-11-10 Thread Wenchao Xia
Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/snapshot.c | 18 + include/block/snapshot.h |8 +++

[Qemu-devel] [PATCH V5 1/5] snapshot: distinguish id and name in load_tmp

2013-11-10 Thread Wenchao Xia
Since later this function will be used so improve it. The only caller of it now is qemu-img, and it is not impacted by introduce function bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() twice to keep old search logic. bdrv_snapshot_load_tmp_by_id_or_name() return int to

[Qemu-devel] [PATCH V5 5/5] qemu-iotests: add test for snapshot in qemu-img convert

2013-11-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/058 | 19 ++- tests/qemu-iotests/058.out | 12 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/058 b/tests/qemu-iotests/058 index 2d50d97..9e28132

[Qemu-devel] [PATCH V5 4/5] qemu-img: add -l for snapshot in convert

2013-11-10 Thread Wenchao Xia
Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- qemu-img-cmds.hx |2 +- qemu-img.c | 45 - qemu-img.texi| 12 3 files changed, 45

[Qemu-devel] [PATCH v3 2/6] target-ppc: make use of new -cpu suboptions handling

2013-11-10 Thread Alexey Kardashevskiy
This enables -cpu subobtions parser. No option is supported yet. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/ppc/spapr.c | 4 +++- target-ppc/translate_init.c | 5 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

[Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-10 Thread Alexey Kardashevskiy
This adds a macro to calculate the highest bit set. If used on constant values, no code will be generated. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- include/qemu/bitops.h | 12 1 file changed, 12 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h

[Qemu-devel] [PATCH v3 0/6] spapr: add compat machine option

2013-11-10 Thread Alexey Kardashevskiy
The further I go, more questions I get. Here are 6 patches. The first three is what I would like to have in QEMU to support compat option for a CPU. The option now accepts power6/power7 as after all we will limit number of threads per core (not in this series though) and since 2.05 does not

[Qemu-devel] [PATCH v3 1/6] cpu: add suboptions support

2013-11-10 Thread Alexey Kardashevskiy
This adds suboptions support for -cpu. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- include/qom/cpu.h | 29 + include/sysemu/sysemu.h | 1 + qom/cpu.c | 27 +++ vl.c

[Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-10 Thread Alexey Kardashevskiy
This converts +foo/-foo to foo=on/foo=off respectively when QEMU parser is used for the command line options. -cpu parsers in x86 and other architectures should be unaffected by this change. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- util/qemu-option.c | 6 ++ 1 file changed, 6

[Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new vsx property

2013-11-10 Thread Alexey Kardashevskiy
This patch is to demonstrate a static property handling in PowerPC. Running QEMU with -cpu host,-vsx disables VSX bit in PowerPCCPU::env::flags. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/translate_init.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Qemu-devel] [PATCH v3 3/6] target-ppc: add compat CPU option

2013-11-10 Thread Alexey Kardashevskiy
To be able to boot a guest on the hardware which is newer than the guest actually supports, PowerISA defines a logical PVR per every PowerISA specification version from 2.04. This adds the compat option which takes values 205 or 206 and forces QEMU to boot the guest with a logical PVR

Re: [Qemu-devel] [PATCH for-1.7] qdev-properties-system.c: Allow vlan or netdev for -device, not both

2013-11-10 Thread Paolo Bonzini
Il 11/11/2013 06:18, Jason Wang ha scritto: On 11/08/2013 10:13 AM, Vlad Yasevich wrote: It is currently possible to specify things like: -device e1000,netdev=foo,vlan=1 With this usage, whichever argument was specified last (vlan or netdev) overwrites what was previousely set and

[Qemu-devel] [PATCH V6 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-11-10 Thread Wenchao Xia
The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6

[Qemu-devel] [PATCH V6 1/6] snapshot: add parameter *errp in snapshot create

2013-11-10 Thread Wenchao Xia
The return value is only used for error report before this patch, so change the function protype to return void. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c| 30 +- block/qcow2.h

[Qemu-devel] [PATCH V6 6/6] qemu-iotests: add test for qcow2 snapshot

2013-11-10 Thread Wenchao Xia
This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/070 | 216

[Qemu-devel] [PATCH V6 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots

2013-11-10 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 6a1d9de..70e329e 100644 ---