[Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Chunyan Liu
Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad performance is to turn off COW attributes on VM files (since

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

2013-11-14 Thread Marcel Apfelbaum
On Wed, 2013-11-13 at 21:43 +0200, Michael S. Tsirkin wrote: On Wed, Nov 13, 2013 at 06:11:25PM +0200, Marcel Apfelbaum wrote: Machines before 1.6 used ACPI supplied by SeaBios, for 1.7+ machines the tables are build by qemu. This patch checks that both machines have the same ACPI tables.

Re: [Qemu-devel] [PATCH] target-arm: add support for v8 AES instructions

2013-11-14 Thread Ard Biesheuvel
Ping? Regards, Ard. On 6 November 2013 15:21, Ard Biesheuvel ard.biesheu...@linaro.org wrote: This adds support for the AESE/AESD/AESMC/AESIMC instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org ---

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-14 Thread Paolo Bonzini
Il 14/11/2013 00:09, Peter Maydell ha scritto: +#ifndef __OPTIMIZE__ +/* This function is only called inside conditionals which we + * rely on the compiler to optimize out when CONFIG_KVM is not + * defined. + */ +uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, +

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-14 Thread Paolo Bonzini
Il 14/11/2013 06:51, Alexey Kardashevskiy ha scritto: The wrappers are not usable where you have constant expressions as in your case. So your original patch is good IMO, except for the __ at the beginning of __BITNR. There are 2 macros, one (BITNR) uses the other (__BITNR). What would

Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level compression

2013-11-14 Thread Avi Kivity
Michael S. Tsirkin mst at redhat.com writes: At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have huge memory regions but inefficient if we are only using a tiny portion of the address space. After we

[Qemu-devel] [PATCH v4 0/4] Use blkdebug to make test deterministic

2013-11-14 Thread Fam Zheng
This adds remove_break command to block, which removes a break point defined with break. It is used in iotests.py to pause and resume drive in block job cases to make the test deterministic. v4: [01] Added. [03] Add common method pair pause_drive and resume_drive. [04] Also fix 040, 055.

[Qemu-devel] [PATCH v4 1/4] qemu-iotests: Drop local version of cancel_and_wait from 040

2013-11-14 Thread Fam Zheng
iotests.py already has one. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/040 | 15 --- 1 file changed, 15 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index a2e18c5..0e85136 100755 --- a/tests/qemu-iotests/040 +++

[Qemu-devel] [PATCH v4 3/4] qemu-iotest: Add pause_drive and resume_drive methods

2013-11-14 Thread Fam Zheng
They wrap blkdebug break and remove_break. Add optional argument resume to cancel_and_wait(). Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/iotests.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py

[Qemu-devel] [PATCH v4 4/4] qemu-iotests: Make test case 030, 040 and 055 deterministic

2013-11-14 Thread Fam Zheng
Pause the drive and start the block job, so we won't miss the block job. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/030 | 16 +++- tests/qemu-iotests/040 | 4 +++- tests/qemu-iotests/055 | 15 +++ 3 files changed, 25 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH v4 2/4] blkdebug: add remove_break command

2013-11-14 Thread Fam Zheng
This adds remove_break command which is the reverse of blkdebug command break: it removes all breakpoints with given tag and resumes all the requests. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 13 + block/blkdebug.c | 26

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-14 Thread Stefan Hajnoczi
On Wed, Nov 13, 2013 at 11:17:12AM -0500, Jeff Cody wrote: On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: +VHDX +M: Jeff Cody jc...@redhat.com +S: Supported +F: block/vhdx.* This should be block/vhdx* instead, to pick up vhdx-endian.c and vhdx-log.c as well. Oops,

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexey Kardashevskiy
On 11/14/2013 05:01 PM, Benjamin Herrenschmidt wrote: On Thu, 2013-11-14 at 16:01 +1100, Alexey Kardashevskiy wrote: So the question is - is there any proper (i. e. qemu-upstreamable) way to detect a VGA device presence and create additional devices (OHCI, keyboard, mouse) as -vga does it now?

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bennée
cy...@suse.com writes: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad performance is to turn off COW

Re: [Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

2013-11-14 Thread Paul Durrant
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 13 November 2013 18:06 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory On Wed, 13 Nov

Re: [Qemu-devel] [PATCH] pc: add 1.8 machine type

2013-11-14 Thread Paolo Bonzini
Il 13/11/2013 20:35, Michael S. Tsirkin ha scritto: +static void pc_compat_1_7(QEMUMachineInitArgs *args) +{ +} + static void pc_compat_1_6(QEMUMachineInitArgs *args) { has_pci_info = false; This should call pc_compat_1_7(args), for both piix and q35.

Re: [Qemu-devel] [PATCH] pc: add 1.8 machine type

2013-11-14 Thread Paolo Bonzini
Il 13/11/2013 20:35, Michael S. Tsirkin ha scritto: +static QEMUMachine pc_q35_machine_v1_8 = { +PC_Q35_1_8_MACHINE_OPTIONS, +.name = pc-q35-1.8, +.alias = q35, +.init = pc_q35_init, +}; + #define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS Also, you probably want

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 10:44 hat Alex Bennée geschrieben: cy...@suse.com writes: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system.

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 10:21:02AM +0200, Marcel Apfelbaum wrote: On Wed, 2013-11-13 at 21:43 +0200, Michael S. Tsirkin wrote: On Wed, Nov 13, 2013 at 06:11:25PM +0200, Marcel Apfelbaum wrote: Machines before 1.6 used ACPI supplied by SeaBios, for 1.7+ machines the tables are build by

[Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-11-14 Thread Michael S. Tsirkin
Several changes that affect compatibility between 1.8 and 1.7 are already planned, so we need pc compat structures in place. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v1: make 1.6 call 1.7 as suggested by Paolo hw/i386/pc_piix.c | 30 +-

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-11-14 Thread Paolo Bonzini
Il 14/11/2013 11:37, Michael S. Tsirkin ha scritto: Several changes that affect compatibility between 1.8 and 1.7 are already planned, so we need pc compat structures in place. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v1: make 1.6 call 1.7 as suggested by

[Qemu-devel] [PATCH 0/5] qemu-io: readline command completion

2013-11-14 Thread Stefan Hajnoczi
This series decouples readline.c from the QEMU monitor and then reuses it in qemu-io. This adds history and command completion to the qemu-io interactive prompt. Stefan Hajnoczi (5): readline: decouple readline from the monitor readline: move readline to a generic location osdep: add

[Qemu-devel] [PATCH 2/5] readline: move readline to a generic location

2013-11-14 Thread Stefan Hajnoczi
Now that the monitor and readline are decoupled, readline.h no longer belongs in include/monitor/. Put the header into include/qemu/. Move the source file into util/ so it can be linked as part of libqemuutil.a. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- Makefile.objs

[Qemu-devel] [PATCH 1/5] readline: decouple readline from the monitor

2013-11-14 Thread Stefan Hajnoczi
Make the readline.c functionality reusable. Instead of calling monitor_printf() and monitor_flush() directly, invoke function pointers provided by the user. This way readline.c does not know about Monitor and other users will be able to make use of readline.c. Note that there is already an

[Qemu-devel] [PATCH 5/5] qemu-io: add command completion

2013-11-14 Thread Stefan Hajnoczi
Autocomplete qemu-io commands at the interactive prompt. Note this only completes command names and not their options. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/qemu-io.h | 3 +++ qemu-io-cmds.c| 15 +++ qemu-io.c | 8 +++- 3 files changed, 25

[Qemu-devel] [PATCH 3/5] osdep: add qemu_set_tty_echo()

2013-11-14 Thread Stefan Hajnoczi
Using stdin with readline.c requires disabling echo and line buffering. Add a portable wrapper to set the terminal attributes under Linux and Windows. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/qemu/osdep.h | 2 ++ util/oslib-posix.c | 18 ++

[Qemu-devel] [PATCH 4/5] qemu-io: use readline.c

2013-11-14 Thread Stefan Hajnoczi
Use readline.c for command-line history. There was support for GNU Readline and BSD Editline but it was never compiled in. Since QEMU has its own readline.c, just use that when qemu-io runs with stdin attached to a terminal. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-io.c |

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-14 Thread Peter Maydell
On 14 November 2013 05:40, Stefan Weil s...@weilnetz.de wrote: If you happen to write a v3 patch, g_assert_not_reached would be even better than abort. It's impossible to tell why QEMU terminated after an assert without a debugger, whereas g_assert_not_reached clearly shows the location.

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-14 Thread Paolo Bonzini
Il 14/11/2013 12:06, Peter Maydell ha scritto: On 14 November 2013 05:40, Stefan Weil s...@weilnetz.de wrote: If you happen to write a v3 patch, g_assert_not_reached would be even better than abort. It's impossible to tell why QEMU terminated after an assert without a debugger, whereas

[Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT

2013-11-14 Thread Michael S. Tsirkin
IASL stores it's revision in each table header it generates. That's not nice since guests will see a change each time they move between hypervisors. We generally fill our own info for tables, but we (and seabios) forgot to do this for the built-in DSDT. Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH] ACPI DSDT: Make control method `IQCR` serialized

2013-11-14 Thread Michael S. Tsirkin
Forward-port the following commit from seabios: commit 995bbeef78b338370f426bf8d0399038c3fa259c Author: Paul Menzel paulepan...@users.sourceforge.net Date: Thu Oct 3 11:30:52 2013 +0200 The ASL Optimizing Compiler version 20130823-32 [Sep 11 2013] issues the following warning.

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-14 Thread Kevin Wolf
Am 13.11.2013 um 20:37 hat Max Reitz geschrieben: If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing normally.

Re: [Qemu-devel] [PATCH] qapi: Add (Since 1.8) to BlockInfo.dirty-bitmaps

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 03:33 hat Fam Zheng geschrieben: Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 931d710..3f2b5ef 100644 --- a/qapi-schema.json +++

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 02:43 hat Fam Zheng geschrieben: On 2013年11月13日 22:02, Kevin Wolf wrote: Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben: This change is manually copypasted into thunderbird. It has a super long line to kill `git send-email`, and is wrapped by email composer. So you need to

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexander Graf
Am 14.11.2013 um 04:37 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 11/14/2013 05:01 PM, Benjamin Herrenschmidt wrote: On Thu, 2013-11-14 at 16:01 +1100, Alexey Kardashevskiy wrote: So the question is - is there any proper (i. e. qemu-upstreamable) way to detect a VGA device presence and

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Eric Blake
[adding libvirt] On 11/13/2013 10:01 PM, Alexey Kardashevskiy wrote: Hi everyone. Here is a problem with the SPAPR machine and a libvirt's habit to use -nodefaults. When we run QEMU with -vga std, a VGA device is created from the machine_init callback and if VGA is added, then we

Re: [Qemu-devel] [PATCH] block: Fail if requested driver is not available

2013-11-14 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 02:54:59PM +0100, Kevin Wolf wrote: If an explicit driver option is present, but doesn't specify a valid driver, then bdrv_open() should fail instead of probing the format. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 5 +

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add entries to these tables. Signed-off-by: Corey Minyard

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:32 AM, Michael S. Tsirkin wrote: On Tue, Nov 12, 2013 at 11:08:07AM -0600, Corey Minyard wrote: On 11/12/2013 10:43 AM, Eric Blake wrote: On 11/12/2013 09:33 AM, Corey Minyard wrote: Allow a socket that connects to reconnect on a periodic basis if it fails to connect at

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-14 Thread Stefan Hajnoczi
On Tue, Nov 12, 2013 at 01:10:24PM +0200, Avi Kivity wrote: Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since it doesn't have the required capabilities. Fix by adding them. Up until now, downstreams had to make the bridge helper executable setuid, add the

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add

Re: [Qemu-devel] [PATCH 2/2] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-11-14 Thread Igor Mammedov
On Thu, 14 Nov 2013 09:40:12 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 13, 2013 at 01:04:10PM +0100, Igor Mammedov wrote: On Wed, 13 Nov 2013 00:10:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Nov 12, 2013 at 07:26:02PM +0100, Paolo Bonzini wrote: Il

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: Postpone the addition of the ACPI and SMBIOS tables until after

Re: [Qemu-devel] [PATCH] ACPI DSDT: Make control method `IQCR` serialized

2013-11-14 Thread Marcel Apfelbaum
On Thu, 2013-11-14 at 14:16 +0200, Michael S. Tsirkin wrote: Forward-port the following commit from seabios: commit 995bbeef78b338370f426bf8d0399038c3fa259c Author: Paul Menzel paulepan...@users.sourceforge.net Date: Thu Oct 3 11:30:52 2013 +0200 The ASL Optimizing Compiler version

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-14 Thread Stefan Hajnoczi
On Wed, Nov 13, 2013 at 08:37:58PM +0100, Max Reitz wrote: If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:46 AM, Michael S. Tsirkin wrote: BTW you included this: Cc: qemu-devel@nongnu.org, Andreas Färber afaer...@suse.de, Bret Ketchum bcketc...@gmail.com, Corey Minyard cminy...@mvista.com the last address: cminy...@mvista.com is bouncing. That's actually not the

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:40:31AM -0600, Corey Minyard wrote: On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote:

Re: [Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT

2013-11-14 Thread Marcel Apfelbaum
On Thu, 2013-11-14 at 14:01 +0200, Michael S. Tsirkin wrote: IASL stores it's revision in each table header it generates. That's not nice since guests will see a change each time they move between hypervisors. We generally fill our own info for tables, but we (and seabios) forgot to do this

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-14 Thread Michael S. Tsirkin
On Wed, Nov 13, 2013 at 02:51:39PM -0600, Corey Minyard wrote: On 11/13/2013 02:55 AM, Gerd Hoffmann wrote: Hi, Allow a socket that connects to reconnect on a periodic basis if it fails to connect at startup or if the connection drops while in use. +chr-backend = i; +

[Qemu-devel] [PATCH] smc91c111: Fix receive starvation

2013-11-14 Thread Sebastian Huber
In case the smc91c111 interface signals that it cannot receive more packets the packets are queued and further reception will be disabled. In case the interface is again ready to receive packets notify the upper layer. Signed-off-by: Sebastian Huber sebastian.hu...@embedded-brains.de ---

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-14 Thread Eric Blake
On 11/14/2013 06:41 AM, Stefan Hajnoczi wrote: On Wed, Nov 13, 2013 at 08:37:58PM +0100, Max Reitz wrote: If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-14 Thread Paolo Bonzini
Il 14/11/2013 14:41, Stefan Hajnoczi ha scritto: Thanks for raising this, it's a bug that we don't verify that the image has a backing file. I'd rather return an error that the user attempted to do something pointless. It was a mistake on their part and it helps to bring this to their

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bligh
--On 14 November 2013 10:17:26 +0100 Kevin Wolf kw...@redhat.com wrote: +#ifdef __linux__ +/* set NOCOW flag to solve performance issue on fs like btrfs */ +int attr; +attr = FS_NOCOW_FL; +ioctl(fd, FS_IOC_SETFLAGS, attr); +#endif ioctl() returning an error

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-14 Thread Andre Przywara
Peter, the config option is called: CONFIG_STRICT_DEVMEM And /dev/mem behaves differently between doing read() and doing mmap(). As Peter already hinted, the memory layout is different on native Midway (which has DRAM starting at 0) and mach-virt/vexpress (which start at 128MB / 2GB

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bligh
--On 14 November 2013 14:23:29 + Alex Bligh a...@alex.org.uk wrote: Also, given FS_NOCOW_FL was only introduced in 2.6.39, should this not be guarded by #ifdef FS_NOCOW_FL (or better tested in configure in case it becomes something other than a #define in which case this test could

[Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-14 Thread Stefan Hajnoczi
SMTP does not preserve newlines. This is normally not a problem if the email body uses DOS or UNIX newlines consistently. In 051.out we mix UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n). This patch filters the QEMU monitor output so the golden master file uses UNIX

Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 08:54:11AM +, Avi Kivity wrote: Michael S. Tsirkin mst at redhat.com writes: At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have huge memory regions but inefficient if we

Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper

2013-11-14 Thread Avi Kivity
On 11/14/2013 03:29 PM, Stefan Hajnoczi wrote: On Tue, Nov 12, 2013 at 01:10:24PM +0200, Avi Kivity wrote: Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since it doesn't have the required capabilities. Fix by adding them. Up until now, downstreams had to make the

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-14 Thread Peter Maydell
I agree we should probably make KVM inject a data abort here. That doesn't change the fact that a userspace program that looks in /dev/mem without being 100% sure what hardware it is running on is really dangerous and needs to be fixed. -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH] ACPI DSDT: Make control method `IQCR` serialized

2013-11-14 Thread Laszlo Ersek
On 11/14/13 13:16, Michael S. Tsirkin wrote: Forward-port the following commit from seabios: commit 995bbeef78b338370f426bf8d0399038c3fa259c Author: Paul Menzel paulepan...@users.sourceforge.net Date: Thu Oct 3 11:30:52 2013 +0200 The ASL Optimizing Compiler version 20130823-32 [Sep

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)

2013-11-14 Thread Stefan Hajnoczi
On Tue, Aug 27, 2013 at 3:12 PM, Stefan Weil s...@weilnetz.de wrote: When a Python script is run, Python normally writes bytecode into a .pyc file. QEMU's build process uses several Python scripts which are called from configure or make. The generated .pyc files take disk space without being

Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression

2013-11-14 Thread Avi Kivity
On 11/14/2013 04:40 PM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 08:54:11AM +, Avi Kivity wrote: Michael S. Tsirkin mst at redhat.com writes: At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have

Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-14 Thread Eric Blake
On 11/14/2013 07:34 AM, Stefan Hajnoczi wrote: SMTP does not preserve newlines. This is normally not a problem if the email body uses DOS or UNIX newlines consistently. In 051.out we mix UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n). This patch filters the QEMU

[Qemu-devel] [PATCH for-1.7] tests: add missing -display none to qtests

2013-11-14 Thread Stefan Hajnoczi
Commit 7ceeedd016facf8d58e14a0d1417fa7225d71072 (blockdev-test: add test case for drive_add duplicate IDs) and commit 43cd209803d6cffb1e1a028c9ff2fd0ff4fce954 (qdev-monitor-test: add device_add leak test cases) added qtest tests without specifying -display none. As a result, make check now tries

Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 04:56:43PM +0200, Avi Kivity wrote: On 11/14/2013 04:40 PM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 08:54:11AM +, Avi Kivity wrote: Michael S. Tsirkin mst at redhat.com writes: At the moment, memory radix tree is already variable width, but it can only

Re: [Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level?compression

2013-11-14 Thread Avi Kivity
On 11/14/2013 05:37 PM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 04:56:43PM +0200, Avi Kivity wrote: On 11/14/2013 04:40 PM, Michael S. Tsirkin wrote: On Thu, Nov 14, 2013 at 08:54:11AM +, Avi Kivity wrote: Michael S. Tsirkin mst at redhat.com writes: At the moment, memory

Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new vsx property

2013-11-14 Thread Andreas Färber
Am 14.11.2013 06:20, schrieb Alexey Kardashevskiy: On 11/12/2013 12:31 AM, Andreas Färber wrote: 2) Please move the array out of the function to just before the containing function. Again, this is just to show. But. Why do you want those properties to be outside of the function? Less

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)

2013-11-14 Thread Stefan Weil
Am 14.11.2013 15:45, schrieb Stefan Hajnoczi: On Tue, Aug 27, 2013 at 3:12 PM, Stefan Weil s...@weilnetz.de wrote: When a Python script is run, Python normally writes bytecode into a .pyc file. QEMU's build process uses several Python scripts which are called from configure or make. The

[Qemu-devel] migration speed setting.

2013-11-14 Thread Yaodong Yang
Hi everyone,I know that inside the qemu monitor, we can set the max migration speed through " set_migration_speed 32 ". This '32' means 32MB.My confusion is about the meaning of this 32MB. I checked the code and find that this '32MB' is the buffer size insde QemuFile, which include all the data

[Qemu-devel] [PATCH (1.7?)] configure: Use -B switch only for Python versions which support it

2013-11-14 Thread Stefan Weil
Commit 1d984a67a95d88f3e708b077dab8adeb47c38c93 added the -B switch unconditionally. This breaks Python versions before 2.6 which don't support that switch. Now configure adds -B only if it is accepted by the Python interpreter. This modification introduces a small incompatiblity because -B

Re: [Qemu-devel] [PATCH (1.7?)] configure: Use -B switch only for Python versions which support it

2013-11-14 Thread Stefan Weil
Am 14.11.2013 19:07, schrieb Stefan Weil: Commit 1d984a67a95d88f3e708b077dab8adeb47c38c93 added the -B switch unconditionally. This breaks Python versions before 2.6 which don't support that switch. Now configure adds -B only if it is accepted by the Python interpreter. This modification

Re: [Qemu-devel] [PATCH (1.7?)] configure: Use -B switch only for Python versions which support it

2013-11-14 Thread Peter Maydell
On 14 November 2013 18:07, Stefan Weil s...@weilnetz.de wrote: Commit 1d984a67a95d88f3e708b077dab8adeb47c38c93 added the -B switch unconditionally. This breaks Python versions before 2.6 which don't support that switch. Now configure adds -B only if it is accepted by the Python interpreter.

Re: [Qemu-devel] [PATCH v5 0/8] Add metadata overlap checks

2013-11-14 Thread Max Reitz
On 05.11.2013 09:51, Stefan Hajnoczi wrote: On Sat, Oct 26, 2013 at 03:03:09PM +0200, Max Reitz wrote: Am 20.09.2013 12:32, schrieb Stefan Hajnoczi: On Thu, Sep 19, 2013 at 05:07:56PM +0200, Max Reitz wrote: As far as I understand, the I/O speed (the duration of an I/O operation) should be

[Qemu-devel] [RFC] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM

2013-11-14 Thread Peter Maydell
There are a number of places where it would be convenient for ARM code to have working definitions of KVM constants even in code which is compiled with CONFIG_KVM not set. In this situation we can't simply include the kernel KVM headers (which might conflict with host header definitions or not

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Benjamin Herrenschmidt
On Thu, 2013-11-14 at 08:04 -0500, Alexander Graf wrote: 2) -nodefaults This mode is meant to pass full control to a management stack which wants to implement its own cleverness. The less QEMU tries to be smart, the more consistent we are in our interface. This mode really is meant as to

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Peter Maydell
On 14 November 2013 20:28, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 08:04 -0500, Alexander Graf wrote: 2) -nodefaults This mode is meant to pass full control to a management stack which wants to implement its own cleverness. The less QEMU tries to be

Re: [Qemu-devel] [PATCH 12/14] VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-11-14 Thread Tom Musta
On 11/13/2013 5:14 PM, Richard Henderson wrote: On 11/14/2013 06:49 AM, Tom Musta wrote: I have also done quite a bit of random and targeted random testing using Power hardware to produce expected results. The targeted random tests followed your suggestion above: generate AxB + C where

Re: [Qemu-devel] [BUG] GTK terminal is broken

2013-11-14 Thread Stefan Weil
Am 29.07.2013 18:04, schrieb Stefan Weil: Hello, maybe most developers will already have noticed that the terminal output in QEMU's GTK user interface is broken. As far as I know, it never worked, but as there are working alternatives, I did not care much and forgot to report the issues.

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexander Graf
On 14.11.2013, at 15:28, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 08:04 -0500, Alexander Graf wrote: 2) -nodefaults This mode is meant to pass full control to a management stack which wants to implement its own cleverness. The less QEMU tries to be

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Benjamin Herrenschmidt
On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB controller like we would have to. Our pseries platform just doesn't have a legacy PC/AT keyboard controller. Sure, but that implies that

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexander Graf
Am 14.11.2013 um 17:32 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB controller like we would have to. Our pseries platform just

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Anthony Liguori
On Thu, Nov 14, 2013 at 2:41 PM, Alexander Graf ag...@suse.de wrote: Am 14.11.2013 um 17:32 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Anthony Liguori
On Thu, Nov 14, 2013 at 2:32 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB controller like we would have to. Our pseries platform just

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Peter Maydell
On 14 November 2013 22:32, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB controller like we would have to. Our pseries platform just

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Benjamin Herrenschmidt
On Thu, 2013-11-14 at 23:03 +, Peter Maydell wrote: On 14 November 2013 22:32, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB

[Qemu-devel] [PATCH 2/2 v4] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-11-14 Thread Igor Mammedov
'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI BARs mapping could safely start in high memory. Allowing BIOS to start mapping 64-bit PCI BARs at address where it wouldn't conflict with other mappings QEMU might place before it. That permits QEMU to reserve extra address space

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexey Kardashevskiy
On 11/15/2013 10:03 AM, Peter Maydell wrote: On 14 November 2013 22:32, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct thing to do in this case. X86 also doesn't create a USB controller like we

Re: [Qemu-devel] [RFC PATCH 4/4] qcow2: Add full image preallocation option

2013-11-14 Thread Hu Tao
On Wed, Nov 13, 2013 at 07:03:03AM +0100, Peter Lieven wrote: What is your use case for this seris? QCOW2 creation or converting anything to QCOW2? For the later case you could use qemu-img convert -S 0 ... starting in 1.8. The former. Seems qemu-img convert -S 0 do the same thing but at

Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n

2013-11-14 Thread Luiz Capitulino
On Thu, 14 Nov 2013 15:34:06 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: SMTP does not preserve newlines. This is normally not a problem if the email body uses DOS or UNIX newlines consistently. In 051.out we mix UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n).

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Chunyan Liu
2013/11/14 Kevin Wolf kw...@redhat.com Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-14 Thread Alexander Graf
Am 14.11.2013 um 20:25 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 11/15/2013 10:03 AM, Peter Maydell wrote: On 14 November 2013 22:32, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-11-14 at 17:23 -0500, Alexander Graf wrote: Yes. But I think it's the correct

[Qemu-devel] [PATCHv2] qemu-img: set nocow flag to new file

2013-11-14 Thread Chunyan Liu
Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad performance is to turn off COW attributes on VM files (since

[Qemu-devel] [RFC PATCH] smp: autodetect numbers of threads per core

2013-11-14 Thread Alexey Kardashevskiy
At the moment only a whole CPU core can be assigned to a KVM. Since POWER7/8 support several threads per core, we want all threads of a core to go to the same KVM so every time we run QEMU with -enable-kvm on POWER, we have to add -smp X,threads=(4|8) (4 for POWER7 and 8 for POWER8). This patch

[Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id

2013-11-14 Thread Alexey Kardashevskiy
Normally CPUState::cpu_index is used to pick the right CPU for various operations. However default consecutive numbering does not always work for POWERPC. For example, on POWER7 (which supports 4 threads per core), -smp 8,threads=4 should create CPUs with indexes 0,1,2,3,4,5,6,7 and -smp

[Qemu-devel] [PATCH] spapr: add ibm,(get|set)-system-parameter

2013-11-14 Thread Alexey Kardashevskiy
This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is platform-processor-diagnostics-run-mode which is always disabled and does not support changing. This is expected to make ppc64_cpu --run-mode=1 happy.

Re: [Qemu-devel] [BUG] GTK terminal is broken

2013-11-14 Thread Stefan Weil
Am 14.11.2013 22:32, schrieb Stefan Weil: Am 29.07.2013 18:04, schrieb Stefan Weil: Hello, maybe most developers will already have noticed that the terminal output in QEMU's GTK user interface is broken. As far as I know, it never worked, but as there are working alternatives, I did not care

[Qemu-devel] [PATCH V8 2/4] block: Add check infinite loop in bdrv_img_create()

2013-11-14 Thread Xu Wang
Backing file loop should be checked before qemu-img create command execution. If loop is found, qemu-img create should be stopped and an error printed. Signed-off-by: Xu Wang gesa...@linux.vnet.ibm.com --- block.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH V8 0/4] Refine and export backing file loop check

2013-11-14 Thread Xu Wang
If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to

[Qemu-devel] [PATCH V8 3/4] block: Add backing file loop check in change_backing_file()

2013-11-14 Thread Xu Wang
Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error printed. Signed-off-by: Xu Wang gesa...@linux.vnet.ibm.com --- block.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block.c b/block.c index

  1   2   >