Re: [Qemu-devel] [RFC qom-cpu v4 00/10] i386: add cpu hot remove support

2013-12-19 Thread Chen Fan
On Thu, 2013-11-28 at 15:41 +0100, Igor Mammedov wrote: On Wed, 9 Oct 2013 17:43:08 +0800 Chen Fan chen.fan.f...@cn.fujitsu.com wrote: Via implementing ACPI standard methods _EJ0 in bios, after Guest OS hot remove one vCPU, it is able to send a signal to QEMU, then QEMU could notify

Re: [Qemu-devel] [PATCH -V7 3/3] target-ppc: Fix page table lookup with kvm enabled

2013-12-19 Thread Paul Mackerras
On Thu, Dec 19, 2013 at 12:25:57PM +0530, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: This breaks if you run a 64-bit guest on a 32-bit host trying to access memory beyond 4GB. In that case htab_base is hwaddr (64bit) while uint8_t is only 32bit wide. Wow!! didn't know

Re: [Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-12-19 Thread Peter Maydell
On 19 December 2013 05:49, Christoffer Dall christoffer.d...@linaro.org wrote: On Thu, Nov 28, 2013 at 05:43:54PM +, Peter Maydell wrote: The other possibility is that it's a correct implementation of 11MPCore GIC semantics -- the documentation of the 11MPCore definitely says that level

Re: [Qemu-devel] sniffing traffic between virtual machines

2013-12-19 Thread Stefan Hajnoczi
On Wed, Dec 18, 2013 at 01:53:56PM +0200, Alexander Binun wrote: We are trying to monitor the traffic (network packets etc) between VMs in KVM. We succeeded to get the address of the system call table (see http://syprog.blogspot.co.il/2011/10/hijack-linux-system-calls-part-iii.html) and

Re: [Qemu-devel] [PATCH 11/21] target-arm: Update generic cpreg code for AArch64

2013-12-19 Thread Peter Maydell
On 19 December 2013 06:01, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Dec 18, 2013 at 1:12 AM, Peter Maydell peter.mayd...@linaro.org wrote: +*key = ENCODE_AA64_CP_REG(r2-cp, r-crn, crm, + r-opc0, opc1, opc2);

Re: [Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-12-19 Thread Stefan Hajnoczi
On Wed, Dec 18, 2013 at 06:05:39PM +0100, Markus Armbruster wrote: Andreas Färber afaer...@suse.de writes: I had a brief look at this series. Dropping redundant fields certainly sounds good and after the lengthy QOM'ifications of IDE devices we seem to no longer break any devices, but

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Marcel Apfelbaum
On Wed, 2013-12-18 at 19:20 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 06:49:24PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 18:33 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 06:27:12PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 17:22 +0200,

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Marcel Apfelbaum
On Thu, 2013-12-19 at 11:37 +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 19:20 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 06:49:24PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 18:33 +0200, Michael S. Tsirkin wrote: On Wed, Dec 18, 2013 at 06:27:12PM +0200,

Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: Performance is important in this function, and we want to optimize even further. Signed-off-by: Juan Quintela quint...@redhat.com --- kvm-all.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index

Re: [Qemu-devel] [PATCH 33/38] kvm: refactor start address calculation

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- kvm-all.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 308dfba..cb62ba4 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -382,7 +382,8 @@

Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2013-12-19 Thread Peter Maydell
On 17 December 2013 15:26, Juan Quintela quint...@redhat.com wrote: @@ -399,8 +401,9 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, page_number = (i * HOST_LONG_BITS + j) * hpratio; addr1 = page_number * TARGET_PAGE_SIZE;

Re: [Qemu-devel] [PATCH 34/38] memory: move bitmap synchronization to its own function

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We want to have all the functions that handle directly the dirty bitmap near. We will change it later. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/ram_addr.h | 31 +++ kvm-all.c | 27

Re: [Qemu-devel] [PATCH 35/38] memory: syncronize kvm bitmap using bitmaps operations

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: If bitmaps are aligned properly, use bitmap operations. If they are not, just use old bit at a time code. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/ram_addr.h | 54 - 1 file

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 11:49:21AM +0200, Marcel Apfelbaum wrote: Basically something like the below (warning: completely untested, sorry). I tested and it works fine for both windows and linux guests! Actually it doesn't work :( I was testing a working hack, not the master branch. I

Re: [Qemu-devel] [PATCH 36/38] ram: split function that synchronizes a range

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: This function is the only bit where we care about speed. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch_init.c

Re: [Qemu-devel] [PATCH 37/38] migration: synchronize memory bitmap 64bits at a time

2013-12-19 Thread Orit Wasserman
On 12/17/2013 05:26 PM, Juan Quintela wrote: We use the old code if the bitmaps are not aligned Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/arch_init.c

Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails

2013-12-19 Thread Eduardo Otubo
On 12/18/2013 02:48 PM, Corey Bryant wrote: This fixes a bug where we weren't exiting if seccomp_init() failed. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index

Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach

2013-12-19 Thread Alexey Kardashevskiy
On 12/16/2013 08:23 AM, Andreas Färber wrote: Am 04.12.2013 06:51, schrieb Peter Crosthwaite: On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini pbonz...@redhat.com wrote: From: Hervé Poussineau hpous...@reactos.org We should not modify the type hash table while it is being iterated on. Assert

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-19 Thread Peter Maydell
On 19 December 2013 07:27, Fedorov Sergey s.fedo...@samsung.com wrote: Yes, this banking scheme makes state changing events quite heavy. But maintaining the active copies allows to keep translation table walking code untouched. I think there is a trade-off between state changing and

Re: [Qemu-devel] [SeaBIOS] seabios release planning

2013-12-19 Thread Gerd Hoffmann
Hi, So that would look like a SeaBIOS feature freeze on Dec 6th and target release date of Dec 20th. Works for me. /me got sick, so with the xmas/newyear holidays being just around the corner that implies I'll be offline for the rest of the year. Kevin will most likely tag v1.7.4

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-19 Thread Peter Crosthwaite
On Thu, Dec 19, 2013 at 9:38 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 07:27, Fedorov Sergey s.fedo...@samsung.com wrote: Yes, this banking scheme makes state changing events quite heavy. But maintaining the active copies allows to keep translation table walking code

Re: [Qemu-devel] [PATCH] vmdk: Check VMFS extent line field number

2013-12-19 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 01:24:36PM +0800, Fam Zheng wrote: VMFS extent line in description file should be with 4 fields: RW size VMFS file-name.vmdk Check the number explicitly and report error if offset is appended as FLAT, which should be invalid format. Reported-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH for-1.7 1/3] sun4m: Add FCode ROM for TCX framebuffer

2013-12-19 Thread Artyom Tarasenko
Hi Mark, this patch breaks booting with OBP: Probing /iommu@0,1000/sbus@0,10001000 at 5,0 espdma esp sd st SUNW,bpp ledma le Probing /iommu@0,1000/sbus@0,10001000 at 4,0 SUNW,CS4231 power-management Probing /iommu@0,1000/sbus@0,10001000 at 1,0 Nothing there Probing

Re: [Qemu-devel] [PATCH v2 22/22] petalogix-ml605: Make the LMB visible only to the CPU

2013-12-19 Thread Peter Crosthwaite
On Thu, Dec 19, 2013 at 5:10 PM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Thu, Dec 19, 2013 at 04:37:22PM +1000, Peter Crosthwaite wrote: On Thu, Dec 19, 2013 at 3:51 PM, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E.

Re: [Qemu-devel] [PATCH] vmdk: Allow vmdk_create to work with protocol

2013-12-19 Thread Stefan Hajnoczi
On Tue, Dec 17, 2013 at 08:00:00PM +0800, Fam Zheng wrote: @@ -1511,48 +1521,55 @@ static int vmdk_create_extent(const char *filename, int64_t filesize, header.check_bytes[3] = 0xa; /* write all the data */ -ret = qemu_write_full(fd, magic, sizeof(magic)); -if (ret !=

Re: [Qemu-devel] [PATCH v5 0/2] target-ppc: CPU device tree id

2013-12-19 Thread Alexey Kardashevskiy
On 12/10/2013 07:16 PM, Alexey Kardashevskiy wrote: On 12/03/2013 02:30 PM, Alexey Kardashevskiy wrote: Hi! This is some cleanup. Please, comment. Thanks! Ping, anyone? Ping? Changes: v5: * cleanup * removed cpustate::kvm_cpu_id * split into 2 patches - new PPC API and the

Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2013-12-19 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 17 December 2013 15:26, Juan Quintela quint...@redhat.com wrote: @@ -399,8 +401,9 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, page_number = (i * HOST_LONG_BITS + j) * hpratio;

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-19 Thread Fedorov Sergey
On 12/19/2013 04:44 PM, Peter Crosthwaite wrote: On Thu, Dec 19, 2013 at 9:38 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 07:27, Fedorov Sergey s.fedo...@samsung.com wrote: Yes, this banking scheme makes state changing events quite heavy. But maintaining the active

Re: [Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-12-19 Thread Peter Crosthwaite
On Thu, Dec 19, 2013 at 7:03 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 05:49, Christoffer Dall christoffer.d...@linaro.org wrote: On Thu, Nov 28, 2013 at 05:43:54PM +, Peter Maydell wrote: The other possibility is that it's a correct implementation of 11MPCore

Re: [Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-12-19 Thread Peter Maydell
On 19 December 2013 13:49, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Thu, Dec 19, 2013 at 7:03 PM, Peter Maydell peter.mayd...@linaro.org wrote: My initial thought would be either to have if statements at the relevant points (which is how we've handled 11mpcore differences so

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-19 Thread Peter Crosthwaite
On Thu, Dec 19, 2013 at 11:39 PM, Fedorov Sergey s.fedo...@samsung.com wrote: On 12/19/2013 04:44 PM, Peter Crosthwaite wrote: On Thu, Dec 19, 2013 at 9:38 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 07:27, Fedorov Sergey s.fedo...@samsung.com wrote: Yes, this

Re: [Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-19 Thread Peter Maydell
On 19 December 2013 14:01, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Thu, Dec 19, 2013 at 11:39 PM, Fedorov Sergey s.fedo...@samsung.com wrote: Banked system control registers have two copies, one Secure and one Non-secure. Ok fair enough. I will wager though that sooner or

Re: [Qemu-devel] [PATCH 03/11] acpi: factor out common cpu hotplug code for PIIX4/Q35

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 13, 2013 at 05:22:08PM +0100, Igor Mammedov wrote: .. so it could be used for adding CPU hotplug to Q35 machine Signed-off-by: Igor Mammedov imamm...@redhat.com Sounds good but please call this file cpu_hotplug.c/.h or cpu-hotplug.c/h and make all prefixes acpi_cpu_hotplug and

Re: [Qemu-devel] [PATCH 01/11] acpi: piix4: remove not needed GPE0 mask

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 13, 2013 at 05:22:06PM +0100, Igor Mammedov wrote: Hardcoded GPE0 mask isn't really needed. Since GPE0_STS initialized with all bits cleared and only QEMU itself can set bits there (i.e. guest can only clear bits in it). So guest can't triger SCI by setting _STS _EN bits and there

Re: [Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI rised by GPE

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 13, 2013 at 05:22:10PM +0100, Igor Mammedov wrote: it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov imamm...@redhat.com Applied, thanks. --- hw/acpi/ich9.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH 02/11] acpi: factor out common pm_update_sci() into acpi core

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 13, 2013 at 05:22:07PM +0100, Igor Mammedov wrote: ... and rename it into acpi_update_sci() since it changes SCI on only on PM registers status. Signed-off-by: Igor Mammedov imamm...@redhat.com Applied, thanks. --- --- hw/acpi/core.c | 18 ++

Re: [Qemu-devel] [PATCH 06/11] acpi/ich9: add CPU hotplug handling to Q35 machine

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 13, 2013 at 05:22:11PM +0100, Igor Mammedov wrote: .. including readonly 'cpu-hotplug-io-base' property Signed-off-by: Igor Mammedov imamm...@redhat.com Is this documented in the Q35 spec? Could not find it there. If this is our PV code like PIIX, then we need to document this

Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic

2013-12-19 Thread Paolo Bonzini
Il 18/12/2013 19:03, Andreas Färber ha scritto: @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, Error **errp) { IOAPICCommonState *s = IOAPIC_COMMON(dev); IOAPICCommonClass *info; -static int ioapic_no; if (ioapic_no = MAX_IOAPICS) {

Re: [Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-12-19 Thread Peter Crosthwaite
On Thu, Dec 19, 2013 at 11:59 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 13:49, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Thu, Dec 19, 2013 at 7:03 PM, Peter Maydell peter.mayd...@linaro.org wrote: My initial thought would be either to have if

Re: [Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-12-19 Thread Peter Maydell
On 19 December 2013 14:26, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Thu, Dec 19, 2013 at 11:59 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 December 2013 13:49, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Thu, Dec 19, 2013 at 7:03 PM, Peter Maydell

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-19 Thread Paolo Bonzini
Il 18/12/2013 18:21, Peter Lieven ha scritto: Not completely I think, but please correct me if I am wrong. If cache=writeback is set we issue just a write. In libnfs or libiscsi case that guarantees that the request has been successfully executed on the target / server. This is enough to be

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Michael S. Tsirkin
On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing up a calculator to figure out how much is 1G is not friendly, neither is firing it up to figure out what did management do with QMP. It should be a text based

[Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant

2013-12-19 Thread armbru
From: Markus Armbruster arm...@redhat.com Once upon a time, the error message was: qemu: -device nonexistant: Device nonexistant not found. Try -device '?' for a list. But progress marches on, and conversion to QError (commit 0204276) changed it into: Invalid parameter 'driver'

Re: [Qemu-devel] [PATCH 03/11] acpi: factor out common cpu hotplug code for PIIX4/Q35

2013-12-19 Thread Igor Mammedov
On Thu, 19 Dec 2013 16:14:03 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 13, 2013 at 05:22:08PM +0100, Igor Mammedov wrote: .. so it could be used for adding CPU hotplug to Q35 machine Signed-off-by: Igor Mammedov imamm...@redhat.com Sounds good but please call this

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing up a calculator to figure out how much is 1G is not friendly, neither is firing it up to figure out what did management do

Re: [Qemu-devel] [PATCH 06/11] acpi/ich9: add CPU hotplug handling to Q35 machine

2013-12-19 Thread Igor Mammedov
On Thu, 19 Dec 2013 16:18:59 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 13, 2013 at 05:22:11PM +0100, Igor Mammedov wrote: .. including readonly 'cpu-hotplug-io-base' property Signed-off-by: Igor Mammedov imamm...@redhat.com Is this documented in the Q35 spec? Could

[Qemu-devel] [PATCH] qemu-iotests: drop duplicate virtio-blk initialization failure

2013-12-19 Thread Stefan Hajnoczi
Commit 75884afd5c6c42e523b08565e289dbe319e17ad9 (virtio-blk: Convert to QOM realize) dropped a duplicate error_report() call. Now we no longer get the following error message twice: QEMU_PROG: -drive if=virtio: Device initialization failed. Update qemu-iotests 051. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 04:14:56PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing up a calculator to figure out how much is 1G is not

Re: [Qemu-devel] [PATCH 06/11] acpi/ich9: add CPU hotplug handling to Q35 machine

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 04:17:08PM +0100, Igor Mammedov wrote: On Thu, 19 Dec 2013 16:18:59 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 13, 2013 at 05:22:11PM +0100, Igor Mammedov wrote: .. including readonly 'cpu-hotplug-io-base' property Signed-off-by: Igor

Re: [Qemu-devel] [PULL 30/30] virtio: Convert exit to unrealize

2013-12-19 Thread Paolo Bonzini
Il 19/12/2013 16:25, Stefan Hajnoczi ha scritto: On Mon, Dec 9, 2013 at 9:48 PM, Paolo Bonzini pbonz...@redhat.com wrote: From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/virtio-blk.c

Re: [Qemu-devel] [PULL 30/30] virtio: Convert exit to unrealize

2013-12-19 Thread Stefan Hajnoczi
On Mon, Dec 9, 2013 at 9:48 PM, Paolo Bonzini pbonz...@redhat.com wrote: From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/virtio-blk.c | 10 ++ hw/char/virtio-serial-bus.c

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Paolo Bonzini
Il 19/12/2013 15:40, Michael S. Tsirkin ha scritto: On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing up a calculator to figure out how much is 1G is not friendly, neither is firing it up to figure out what did

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/18] target-ppc: Add Flag for Power ISA V2.06

2013-12-19 Thread Tom Musta
On 12/18/2013 4:37 PM, Alexander Graf wrote: Am 18.12.2013 um 23:11 schrieb Scott Wood scottw...@freescale.com: On Wed, 2013-12-18 at 23:09 +0100, Alexander Graf wrote: On 18.12.2013, at 23:02, Scott Wood scottw...@freescale.com wrote: On Mon, 2013-12-09 at 09:46 -0600, Tom Musta wrote:

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 04:31:41PM +0100, Paolo Bonzini wrote: Il 19/12/2013 15:40, Michael S. Tsirkin ha scritto: On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing up a calculator to figure out how much is 1G is

Re: [Qemu-devel] [PATCH -V7 3/3] target-ppc: Fix page table lookup with kvm enabled

2013-12-19 Thread Alexander Graf
On 19.12.2013, at 07:55, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Alexander Graf ag...@suse.de writes: On 07.11.2013, at 15:31, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store

Re: [Qemu-devel] [PATCH] qdev-monitor-test: simplify using g_assert_cmpstr()

2013-12-19 Thread Stefan Hajnoczi
On Wed, Dec 18, 2013 at 07:31:48PM +0100, Andreas Färber wrote: Am 18.12.2013 17:34, schrieb Stefan Hajnoczi: Use g_assert_cmpstr() instead of combining g_assert() and strcmp(3). I vaguely remember that some such handy function was introduced only after the minimum GLib version we require.

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 03:39:58PM +, bharat.bhus...@freescale.com wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 19, 2013 3:55 AM To: Alexander Graf Cc: Bhushan Bharat-R65777; Wood Scott-B07421; QEMU Developers;

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-12-19 Thread Paolo Bonzini
Il 19/12/2013 16:40, Michael S. Tsirkin ha scritto: On Thu, Dec 19, 2013 at 04:31:41PM +0100, Paolo Bonzini wrote: Il 19/12/2013 15:40, Michael S. Tsirkin ha scritto: On Mon, Nov 25, 2013 at 09:43:48AM -0700, Eric Blake wrote: On 11/25/2013 09:32 AM, Paolo Bonzini wrote: Yes please. Firing

Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant

2013-12-19 Thread Eric Blake
On 12/19/2013 07:30 AM, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com We've since abandoned our quest for rich error objects, fortunately before it turned all error messages into mush. Time to undo the damage to this one. Make it: qemu: -device nonexistant:

Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails

2013-12-19 Thread Paul Moore
On Wednesday, December 18, 2013 11:48:11 AM Corey Bryant wrote: This fixes a bug where we weren't exiting if seccomp_init() failed. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) Acked-by: Paul Moore pmo...@redhat.com diff

Re: [Qemu-devel] [PATCH 03/27] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-12-19 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:24AM +0100, Igor Mammedov wrote: 'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI BARs mapping could safely start in high memory. Allowing BIOS to start mapping 64-bit PCI BARs at address where it wouldn't conflict with other mappings QEMU might

[Qemu-devel] [PATCH V4] kvm: Add a new machine property kvm-type

2013-12-19 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Targets like ppc64 support different typed of KVM, one which use hypervisor mode and the other which doesn't. Add a new machine property kvm-type that helps in selecting the respective ones We also add a new QEMUMachine callback get_vm_type

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Kevin O'Connor
On Wed, Dec 18, 2013 at 06:55:24PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 11:34 -0500, Paolo Bonzini wrote: Or put an array of (bdf, offset, size, value) tuples somewhere in low memory, fill it at startup, and reproduce it blindly at S3 resume time. This is similar to

Re: [Qemu-devel] [PATCH 1/2] ppc-e500: some pci related cleanup

2013-12-19 Thread Alexander Graf
On 19.12.2013, at 16:38, bharat.bhus...@freescale.com wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Thursday, December 19, 2013 3:18 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; QEMU Developers; qemu-ppc; Bhushan Bharat-R65777 Subject: Re:

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-19 Thread Alexander Graf
On 19.12.2013, at 16:39, bharat.bhus...@freescale.com wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 19, 2013 3:55 AM To: Alexander Graf Cc: Bhushan Bharat-R65777; Wood Scott-B07421; QEMU Developers; qemu-ppc; Bhushan

Re: [Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling'

2013-12-19 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 16.12.2013 17:51, schrieb Eric Blake: On 07/15/2013 04:25 PM, Igor Mammedov wrote: features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not neccessary to handle each of them

Re: [Qemu-devel] [PATCH v4 00/10] Clean up and fix no_user

2013-12-19 Thread Andreas Färber
Am 16.12.2013 09:21, schrieb Marcel Apfelbaum: On Sun, 2013-12-15 at 21:37 +0100, Andreas Färber wrote: Am 28.11.2013 17:26, schrieb arm...@redhat.com: Markus Armbruster (10): qdev: Replace no_user by cannot_instantiate_with_device_add_yet sysbus: Set

Re: [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair

2013-12-19 Thread Richard Henderson
On 12/17/2013 07:12 AM, Peter Maydell wrote: +TCGMemOp memop = MO_TE + size; Watch the double space (multiple occurrences). +if (is_vector) { +if (opc == 3) { +unallocated_encoding(s); +return; +} In the integer LDP description I see if

Re: [Qemu-devel] [PATCH 1/2] ppc-e500: some pci related cleanup

2013-12-19 Thread bharat.bhus...@freescale.com
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Thursday, December 19, 2013 3:18 AM To: Bhushan Bharat-R65777 Cc: Wood Scott-B07421; QEMU Developers; qemu-ppc; Bhushan Bharat-R65777 Subject: Re: [PATCH 1/2] ppc-e500: some pci related cleanup On 28.11.2013,

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-19 Thread bharat.bhus...@freescale.com
-Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 19, 2013 9:20 PM To: Bhushan Bharat-R65777 Cc: Alexander Graf; Wood Scott-B07421; QEMU Developers; qemu-ppc Subject: Re: [PATCH 2/2] ppc-e500: implement PCI INTx routing On Thu, Dec 19,

[Qemu-devel] [Bug 1262650] [NEW] Latest git version fails to compile in block/iscsi.o

2013-12-19 Thread Nigel Horne
Public bug reported: Git version f46e720a82ccdf1a521cf459448f3f96ed895d43 (and possibly b91f93243bbe36dc436a64a662a9bbfb2362534a) fail to build under Linux using gcc 4.8.1: block/iscsi.c: In function ‘iscsi_co_readv’: block/iscsi.c:363:40: error: too many arguments to function

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-19 Thread bharat.bhus...@freescale.com
-Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 19, 2013 3:55 AM To: Alexander Graf Cc: Bhushan Bharat-R65777; Wood Scott-B07421; QEMU Developers; qemu-ppc; Bhushan Bharat-R65777 Subject: Re: [PATCH 2/2] ppc-e500: implement PCI INTx

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/18] target-ppc: Add Flag for Power ISA V2.06

2013-12-19 Thread Scott Wood
On Thu, 2013-12-19 at 09:35 -0600, Tom Musta wrote: It turns out that all of the instructions added in this series are *not* implemented in e500mc. So the patch, as is, is correct for e500mc as well as P7/P8. That may be true for e500mc (for some reason it didn't look that way when I checked

Re: [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair

2013-12-19 Thread Peter Maydell
On 19 December 2013 16:58, Richard Henderson r...@twiddle.net wrote: On 12/17/2013 07:12 AM, Peter Maydell wrote: +TCGMemOp memop = MO_TE + size; Watch the double space (multiple occurrences). +if (is_vector) { +if (opc == 3) { +unallocated_encoding(s); +

Re: [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm

2013-12-19 Thread Richard Henderson
On 12/17/2013 07:12 AM, Peter Maydell wrote: +if (size == 3 opc == 2) { +/* PRFM - prefetch */ +return; +} +if (opc == 3 size 1) { +unallocated_encoding(s); +return; +} +is_store = (opc == 0); +

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Marcel Apfelbaum
On Thu, 2013-12-19 at 11:06 -0500, Kevin O'Connor wrote: On Wed, Dec 18, 2013 at 06:55:24PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 11:34 -0500, Paolo Bonzini wrote: Or put an array of (bdf, offset, size, value) tuples somewhere in low memory, fill it at startup, and

Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.

2013-12-19 Thread Kevin O'Connor
On Thu, Dec 19, 2013 at 08:03:15PM +0200, Marcel Apfelbaum wrote: On Thu, 2013-12-19 at 11:06 -0500, Kevin O'Connor wrote: On Wed, Dec 18, 2013 at 06:55:24PM +0200, Marcel Apfelbaum wrote: On Wed, 2013-12-18 at 11:34 -0500, Paolo Bonzini wrote: Or put an array of (bdf, offset, size,

Re: [Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 06, 2013 at 05:54:27PM +0100, Paolo Bonzini wrote: Post-order is the only sensible direction for the reset signals. For example, suppose pre-order is used and the parent has some data structures that cache children state (for example a list of active requests). When the reset

Re: [Qemu-devel] [PATCH 2/2] ppc-e500: implement PCI INTx routing

2013-12-19 Thread Michael S. Tsirkin
On Thu, Dec 19, 2013 at 05:28:17PM +0100, Alexander Graf wrote: On 19.12.2013, at 16:39, bharat.bhus...@freescale.com wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, December 19, 2013 3:55 AM To: Alexander Graf Cc: Bhushan

[Qemu-devel] [PATCH 6/7] ui: Add dpy_cursor_enable()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com This is an optimization to allow the UI to show/hide the current cursor without setting it to a new bitmap. In-guest screen sharing applications which show/hide the cursor when capturing the screen every frame (GoToMeeting, WebEx, etc.) cause high

[Qemu-devel] [PATCH 7/7] ui: Add an opaque pointer to the DisplayChangeListener

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com The pointer is a place for the UI to hang a structure off of. In the multi-head case, the UI can use this pointer to distinguish which QemuConsole a dpy_* call was made for. Signed-off-by: John V. Baboval john.babo...@citrix.com ---

[Qemu-devel] [PATCH 0/7] Multi-head support infrastructure

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com This is mostly just RFC at this point, since I'm not quite ready to submit the associated multi-head video adapter, drivers and UI that consume this stuff. (I still have to remove some Xen/XenClient specific stuff from it). These are the

[Qemu-devel] [PATCH 4/7] console: Add graphic_hw_notify()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com Hook to notify a display adapter of interesting UI changes such as monitor hotplug, orientation changes, etc... Signed-off-by: John V. Baboval john.babo...@citrix.com --- include/ui/console.h |9 + ui/console.c |7 +++ 2

[Qemu-devel] [PATCH 5/7] ui: Add dpy_reset()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com To be called by graphics adapter to have the ui re-initialize monitor state. Signed-off-by: John V. Baboval john.babo...@citrix.com --- include/ui/console.h |3 +++ ui/console.c |8 2 files changed, 11 insertions(+) diff

[Qemu-devel] [PATCH 1/7] console: Add graphic_hw_store_edid()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com Add a hook in GraphicHwOps to pass monitor EDID for a QemuConsole from the ui to the hw. Signed-off-by: John V. Baboval john.babo...@citrix.com --- include/ui/console.h |2 ++ ui/console.c | 10 ++ 2 files changed, 12

[Qemu-devel] [PATCH 2/7] console: Add graphic_hw_set_orientation()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com Add a hook in GraphicHwOps for the ui to inform the hw of display orientation changes Signed-off-by: John V. Baboval john.babo...@citrix.com --- include/ui/console.h |2 ++ ui/console.c | 10 ++ 2 files changed, 12

[Qemu-devel] [PATCH 3/7] console: Add graphic_hw_add_display()

2013-12-19 Thread John Baboval
From: John V. Baboval john.babo...@citrix.com Hook for adding another QemuConsole to the active display adapter. Signed-off-by: John V. Baboval john.babo...@citrix.com --- include/ui/console.h |2 ++ ui/console.c |8 2 files changed, 10 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-12-19 Thread Michael S. Tsirkin
On Fri, Dec 06, 2013 at 05:54:23PM +0100, Paolo Bonzini wrote: PCI is handling resetting of its devices before the bus is reset, but this is only necessary because qdev is broken and usually does pre-order reset. Post-order is a much better definition. Drop the unnecessary flexibility that

Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns

2013-12-19 Thread Richard Henderson
On 12/17/2013 07:12 AM, Peter Maydell wrote: +tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2); +if (is_sub) { +tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); +} else { +tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp); +} Perhaps worth noticing

Re: [Qemu-devel] [PATCH for-1.7 1/3] sun4m: Add FCode ROM for TCX framebuffer

2013-12-19 Thread Mark Cave-Ayland
On 19/12/13 12:59, Artyom Tarasenko wrote: Hi Mark, this patch breaks booting with OBP: Probing /iommu@0,1000/sbus@0,10001000 at 5,0 espdma esp sd st SUNW,bpp ledma le Probing /iommu@0,1000/sbus@0,10001000 at 4,0 SUNW,CS4231 power-management Probing /iommu@0,1000/sbus@0,10001000

[Qemu-devel] [PATCH v6 13/22] block: Allow recursive files

2013-12-19 Thread Max Reitz
It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Allowing nested file formats results in e.g. qcow2 BlockDriverStates never being directly passed to bdrv_open_common() from bdrv_file_open(), but instead being handed

Re: [Qemu-devel] [PATCH V9 1/4] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-12-19 Thread Jeff Cody
On Tue, Nov 26, 2013 at 01:38:30AM -0500, Xu Wang wrote: If there is a loop in the backing file chain, it could cause problems such as no response or a segfault during system boot. Hence detecting a backing file loop is necessary. This patch extracts the loop check from

[Qemu-devel] [PATCH v6 07/22] blkdebug: Use command-line in read_config()

2013-12-19 Thread Max Reitz
Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v6 08/22] block: Allow reference for bdrv_file_open()

2013-12-19 Thread Max Reitz
Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- block.c | 25 ++--- block/blkdebug.c | 2

[Qemu-devel] [PATCH v6 05/22] qemu-option: Add qemu_config_parse_qdict()

2013-12-19 Thread Max Reitz
This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {section.opt1: 42, section.opt2: 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also multiple sections of the

[Qemu-devel] [PATCH v6 06/22] blkdebug: Always call read_config()

2013-12-19 Thread Max Reitz
Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff

[Qemu-devel] [PATCH v6 14/22] blockdev: Move file to legacy_opts

2013-12-19 Thread Max Reitz
Specifying the image filename through the file option is a legacy option and should not be supported by blockdev-add (in that case, giving a string for file references an existing block device). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- blockdev.c |

[Qemu-devel] [PATCH v6 15/22] blkdebug: Allow command-line file configuration

2013-12-19 Thread Max Reitz
Introduce the image option as an alternative to specifying the image through the filename. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index c73a6cf..3a46ecd

[Qemu-devel] [PATCH v6 00/22] blkdebug/blkverify: Allow QMP configuration

2013-12-19 Thread Max Reitz
Currently, the configuration of blkdebug and blkverify is done through the filename alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts with the protocol prefix, follows up with the name of

[Qemu-devel] [PATCH v6 02/22] blkdebug: Don't require sophisticated filename

2013-12-19 Thread Max Reitz
If the filename is not prefixed by blkdebug: in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a problem at all; we just

  1   2   3   >