[Qemu-devel] [Bug 1242963] Re: QEMU loadvm causes guest OS freeze

2014-04-09 Thread NanothylL
Hi guys, This bug has reported in a very long time. I have tested v1.7.0, v1.7.1 and even v2.0.0rc1, v2.0.0rc2. The bug is still there. This is very easy to reproduce. I dunno why it is not fixed until today. I think living-snapshot is a very important feature for Qemu. Somebody can take a

[Qemu-devel] [PATCH] qmp: synchronize state of the cpu before memory reading

2014-04-09 Thread Andrey Karpov
calling memsave' through the qmp makes a zero filled dump. the hmp still works properly because hmp_memsave calls cpu_synchronize_state before calling qmp_memsave. --- Andrey Karpov (1): synchronize state of the cpu before memory reading cpus.c |1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH] synchronize state of the cpu before memory reading

2014-04-09 Thread Andrey Karpov
--- cpus.c |1 + 1 file changed, 1 insertion(+) diff --git a/cpus.c b/cpus.c index 1104d61..4c53747 100644 --- a/cpus.c +++ b/cpus.c @@ -1417,6 +1417,7 @@ void qmp_memsave(int64_t addr, int64_t size, const char *filename, return; } +cpu_synchronize_state(cpu);

[Qemu-devel] [PATCH v8 3/4] raw-posix: Add full image preallocation option

2014-04-09 Thread Hu Tao
This patch adds a new option preallocation for raw format, and implements full preallocation. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/raw-posix.c | 61 --- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v8 2/4] raw, qcow2: don't convert file size to sector size

2014-04-09 Thread Hu Tao
and avoid converting it back later. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 8 block/raw-posix.c | 4 ++-- block/raw-win32.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3377007..b2ff9c3 100644

[Qemu-devel] [PATCH v8 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-04-09 Thread Hu Tao
This patch prepares for the subsequent patches. Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 14 ++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c

[Qemu-devel] [PATCH v4 2/6] register: Add Register API

2014-04-09 Thread Peter Crosthwaite
This API provides some encapsulation of registers and factors our some common functionality to common code. Bits of device state (usually MMIO registers), often have all sorts of access restrictions and semantics associated with them. This API allow you to define what those restrictions are on a

[Qemu-devel] [PATCH v4 3/6] register: Add Memory API glue

2014-04-09 Thread Peter Crosthwaite
Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- changed from v2: Added fast path

[Qemu-devel] [PATCH v4 0/6] Data Driven device registers + Zynq DEVCFG

2014-04-09 Thread Peter Crosthwaite
Hi All. This is a new scheme i've come up with handling device registers in a data driven way. My motivation for this is to factor out a lot of the access checking that seems to be replicated in every device. See P2 commit message for further discussion. P1 is a trivial addition to bitops.h P2 is

[Qemu-devel] [PATCH v4 4/6] register: Add support for decoding information

2014-04-09 Thread Peter Crosthwaite
Allow defining of optional address decoding information in register definitions. This is useful for clients that want to associate registers with specific addresses. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- include/hw/register.h | 21 + 1 file

Re: [Qemu-devel] [V3 PATCH 1/2] target-ppc: Fix target_disas

2014-04-09 Thread Peter Maydell
On 8 April 2014 20:26, Tom Musta tommu...@gmail.com wrote: Inspect only bit 16 for the Little Endian test. Correct comment preceding the target_disas() function. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH v8 0/4] qemu-img: add preallocation=full

2014-04-09 Thread Hu Tao
The purpose of this series is to use posix_fallocate() when creating img file to ensure there are disk space for it which is way fast than acturally writing to disk. But this only works in file system level. For cases like thin provisioning, an option full preallocation is added to write zeros to

Re: [Qemu-devel] [V3 PATCH 2/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-09 Thread Peter Maydell
On 8 April 2014 20:26, Tom Musta tommu...@gmail.com wrote: The monitor support for disassembling instructions does not honor the MSR[LE] bit for PowerPC processors. This change enhances the monitor_disas() routine by supporting a flag bit for Little Endian mode. Bit 16 is used since that bit

[Qemu-devel] [PATCH v4 1/6] bitops: Add ONES macro

2014-04-09 Thread Peter Crosthwaite
Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- include/qemu/bitops.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 340b1e7..b9fd60f 100644 ---

Re: [Qemu-devel] [PATCH for-2.0] configure: add option to disable -fstack-protector flags

2014-04-09 Thread Peter Maydell
On 8 April 2014 21:47, Noonan, Steven snoo...@amazon.com wrote: On Tue, Apr 08, 2014 at 09:37:27PM +0100, Peter Maydell wrote: This is bad because we have that framework argument as part of our linker flags. Effectively this means that clang won't warn about the argument at link time but will

[Qemu-devel] [PATCH v8 4/4] qcow2: Add full image preallocation option

2014-04-09 Thread Hu Tao
This adds a preallocation=full mode to qcow2 image creation, which creates a non-sparse image file. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 79 -- tests/qemu-iotests/082.out | 54 +++ 2

[Qemu-devel] [PATCH v4 6/6] xilinx_zynq: added devcfg to machine model

2014-04-09 Thread Peter Crosthwaite
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Changed since v3: Author reset. Changed since v1: Added manual parenting of devcfg node (evil but needed for early access to canonical path by devcfgs realize fn). hw/arm/xilinx_zynq.c | 8 1 file changed, 8 insertions(+)

Re: [Qemu-devel] [PULL for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-09 Thread Igor Mammedov
On Tue, 8 Apr 2014 15:24:18 +0300 Michael S. Tsirkin m...@redhat.com wrote: ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container Device. Signed-off-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [Bug 1242963] Re: QEMU loadvm causes guest OS freeze

2014-04-09 Thread NanothylL
I found something, hope this could be useful. (qemu) info cpus * CPU #0: pc=0x8054b7f1 thread_id=20447 (qemu) savevm x (qemu) loadvm x (qemu) info cpus * CPU #0: pc=0x806f69ba (halted) thread_id=20447 -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-09 Thread Alexander Graf
Am 09.04.2014 um 02:41 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 04/09/2014 12:59 AM, Alexander Graf wrote: On 04/08/2014 02:19 PM, Michael Mueller wrote: On Tue, 08 Apr 2014 21:47:39 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/08/2014 08:32 PM, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v1 1/1] vl.c: Allow sysbus devices to be attached via commandline

2014-04-09 Thread Markus Armbruster
Alistair Francis alistair.fran...@xilinx.com writes: On Wed, Apr 9, 2014 at 11:28 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Mar 26, 2014 at 10:47 AM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch introduces a new command line argument that allows

[Qemu-devel] [PATCH v4 5/6] xilinx_devcfg: Zynq devcfg device model

2014-04-09 Thread Peter Crosthwaite
Minimal device model for devcfg module of Zynq. DMA capabilities and interrupt generation supported. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Changed since v3: Stylistic updates. Changed over to new decoding scheme. Use .rsvd in definitions as appropriate. Author reset

Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for commit

2014-04-09 Thread Kevin Wolf
Am 08.04.2014 um 18:53 hat Eric Blake geschrieben: On 04/08/2014 09:34 AM, Kevin Wolf wrote: Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v1 1/1] zynq_slcr: Change the comma to a underscore

2014-04-09 Thread Markus Armbruster
Alistair Francis alistair.fran...@xilinx.com writes: On Wed, Apr 9, 2014 at 11:14 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Mar 26, 2014 at 1:05 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch changes the comma in the xilinx,zynq_slcr to an

Re: [Qemu-devel] [PATCH] HMP: support specifying dump format for dump-guest-memory

2014-04-09 Thread Markus Armbruster
Qiao Nuohan qiaonuo...@cn.fujitsu.com writes: Dumping guest memory is available to specify the dump format now. This patch adds options '-z|-l|-s' to HMP command dump-guest-memory to specify dumping in kdump-compression format, with zlib/lzo/snappy compression. And without these options ELF

Re: [Qemu-devel] [PATCH v1 1/1] zynq_slcr: Change the comma to a underscore

2014-04-09 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Alistair Francis alistair.fran...@xilinx.com writes: On Wed, Apr 9, 2014 at 11:14 AM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Mar 26, 2014 at 1:05 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch changes

Re: [Qemu-devel] [PATCH for-2.0] configure: add option to disable -fstack-protector flags

2014-04-09 Thread Peter Maydell
On 9 April 2014 10:29, Noonan, Steven snoo...@amazon.com wrote: So in your case all you probably need is to drop the -framework arguments from CFLAGS and plop them into LIBS, and you're probably good to go. This is where they are already. The problem is that putting -framework on the linker

[Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-09 Thread Markus Armbruster
We have a number of device model names containing '.'. They're unusable with -global. That's because -global A.B.C=foo gets parsed as driver = A property = B.C value = foo. Wrong when the device model name is really A.B and the property is C, e.g. -global cfi.pflash01.name.

[Qemu-devel] [PATCH] bochs: Fix memory leak in bochs_open() error path

2014-04-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/bochs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 826ec12..50b84a9 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -150,11 +150,13 @@ static int bochs_open(BlockDriverState

Re: [Qemu-devel] [PATCH] bochs: Fix memory leak in bochs_open() error path

2014-04-09 Thread Laszlo Ersek
On 04/09/14 11:20, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- block/bochs.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 826ec12..50b84a9 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -150,11

Re: [Qemu-devel] [PATCH 2/2] pci-assign: Fix memory out of bound when MSI-X table not fit in a single page

2014-04-09 Thread Gonglei (Arei)
Hi, QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in assigned_dev_register_msix_mmio(), meanwhile the set the one page memmory to zero, so the rest memory will be random value (maybe etnry.data is not 0). In the assigned_dev_update_msix_mmio() maybe occur the issue of

[Qemu-devel] [PATCH for-2.0] configure: use do_cc when checking for -fstack-protector support

2014-04-09 Thread Peter Maydell
MacOSX clang silently swallows unrecognized -f options when doing a link with '-framework' also on the command line, so to detect support for the various -fstack-protector options we must do a plain .c to .o compile, not a complete compile-and-link. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH] bochs: Fix catalog size check

2014-04-09 Thread Kevin Wolf
The old check was off by a factor of 512 and didn't consider cases where we don't get an exact division. This could lead to an out-of-bounds array access in seek_to_sector(). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/bochs.c | 14 +++--- tests/qemu-iotests/078

[Qemu-devel] [PATCH v4 2/5] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-09 Thread Cornelia Huck
Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- include/sysemu/kvm.h |4 kvm-all.c| 19 ++- 2 files changed, 22

[Qemu-devel] [PATCH v4 5/5] s390x/virtio-ccw: Wire up irq routing and irqfds.

2014-04-09 Thread Cornelia Huck
Make use of the new s390 adapter irq routing support to enable real in-kernel irqfds for virtio-ccw with adapter interrupts. Note that s390 doesn't provide the common KVM_CAP_IRQCHIP capability, but rather needs KVM_CAP_S390_IRQCHIP to be enabled. This is to ensure backward compatibility.

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-09 Thread 陈梁
* (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repeatedly call fill_buffer until it gets all the data it requires, or until there is an

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-09 Thread Peter Crosthwaite
On Wed, Apr 9, 2014 at 7:56 PM, Markus Armbruster arm...@redhat.com wrote: We have a number of device model names containing '.'. They're unusable with -global. That's because -global A.B.C=foo gets parsed as driver = A property = B.C value = foo. Wrong when the device model

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-09 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: * (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repeatedly call fill_buffer until it

[Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Cornelia Huck
Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/intc/s390_flic.c | 59 +

[Qemu-devel] [PATCH v4 4/5] s390x/virtio-ccw: reference-counted indicators

2014-04-09 Thread Cornelia Huck
Make code using the same indicators point to a single allocated structure that is freed when the last user goes away. This will be used by the irqfd code to unmap addresses after the last user is gone. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-09 Thread 陈梁
* (chenliang0...@icloud.com) wrote: * (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make qemu_peek_buffer repeatedly call fill_buffer until it gets

[Qemu-devel] [PATCH v4 0/5] qemu: irqfds for s390x

2014-04-09 Thread Cornelia Huck
Here's my current qemu s390x irqfd patchset. Unless there are objections, I'll send a pull request once 2.0 has been released. Changes from v3: - rebased against current master - first patch is now a proper kernel header update - in patch 5, make indicators-map a uint64_t instead of void *; this

[Qemu-devel] [PATCH v4 1/5] linux-headers: update

2014-04-09 Thread Cornelia Huck
Base is 7cbb39d4d4d530dff12f2ff06ed6c85c504ba91a. Gets several new interfaces: Per-vm capability enablement, adapter interrupt sources, irq routing on s390. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- linux-headers/asm-s390/kvm.h | 24

[Qemu-devel] PL022 VMSD versions bump

2014-04-09 Thread Peter Crosthwaite
Hi Peter, Im looking to do some cleanup around pl022 and I would like to use it as my lead example of code using the new generic FIFO (as I think I have test cases handy for it). But the VMSD description for this device is a bit ugly as it is: VMSTATE_INT32(tx_fifo_head, PL022State),

Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-09 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: Cleaning up the implementation of REV and REV16 at the same time. Reviewed-by: Claudio Fontana claudio.font...@huawei.com Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/aarch64/tcg-target.c | 22 ++ 1 file

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-09 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: * (chenliang0...@icloud.com) wrote: * (chenliang0...@icloud.com) wrote: ?? 2014??4??810:29??Dr. David Alan Gilbert (git) dgilb...@redhat.com ?? From: Dr. David Alan Gilbert dgilb...@redhat.com Make

Re: [Qemu-devel] [libvirt] [PATCH 1/1] Enable QEMU_CAPS_PCI_MULTIBUS capability for QEMU2.0 forward.

2014-04-09 Thread Eric Blake
[adding qemu] On 04/08/2014 11:36 PM, Li Zhang wrote: On 2014年04月09日 11:20, Eric Blake wrote: On 04/08/2014 08:03 PM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com For QEMU2.0 forward version, it supports PCI multiBUS. Currently, libvirt still disables it which causes an error

Re: [Qemu-devel] [PATCH] bochs: Fix catalog size check

2014-04-09 Thread Laszlo Ersek
On 04/09/14 13:14, Kevin Wolf wrote: The old check was off by a factor of 512 and didn't consider cases where we don't get an exact division. This could lead to an out-of-bounds array access in seek_to_sector(). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/bochs.c |

Re: [Qemu-devel] PL022 VMSD versions bump

2014-04-09 Thread Peter Maydell
On 9 April 2014 13:42, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi Peter, Im looking to do some cleanup around pl022 and I would like to use it as my lead example of code using the new generic FIFO (as I think I have test cases handy for it). But the VMSD description for this

Re: [Qemu-devel] [PATCH 2/2] pci-assign: Fix memory out of bound when MSI-X table not fit in a single page

2014-04-09 Thread Michael S. Tsirkin
On Wed, Apr 09, 2014 at 10:56:57AM +, Gonglei (Arei) wrote: Hi, QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in assigned_dev_register_msix_mmio(), meanwhile the set the one page memmory to zero, so the rest memory will be random value (maybe etnry.data is not 0). In

Re: [Qemu-devel] [PATCH v4 2/5] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-09 Thread Alexander Graf
On 09.04.14 13:34, Cornelia Huck wrote: Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com I think it makes sense to convert all ENABLE_CAP callers of the code

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Alexander Graf
On 09.04.14 13:34, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/intc/s390_flic.c | 59

Re: [Qemu-devel] [PATCH 2/2] pci-assign: Fix memory out of bound when MSI-X table not fit in a single page

2014-04-09 Thread Laszlo Ersek
On 04/03/14 07:18, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in assigned_dev_register_msix_mmio(), meanwhile the set the one page memmory to zero, so the rest memory will be random value (maybe etnry.data is

Re: [Qemu-devel] [PATCH 1/2] pci-assign: Fix a bug when map MSI-X table memory failed

2014-04-09 Thread Michael S. Tsirkin
On Thu, Apr 03, 2014 at 01:18:23PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com when map MSI-X table memory failed, the dev-msix_table not be set to NULL, the assigned_dev_unregister_msix_mmio() will case a segfault when munmap the failed dev-msix_table.

Re: [Qemu-devel] [PATCH v4 2/5] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-09 Thread Cornelia Huck
On Wed, 09 Apr 2014 15:58:55 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 13:34, Cornelia Huck wrote: Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Cornelia Huck
On Wed, 09 Apr 2014 16:05:00 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 13:34, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by:

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Alexander Graf
On 09.04.14 16:24, Cornelia Huck wrote: On Wed, 09 Apr 2014 16:05:00 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 13:34, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth

[Qemu-devel] [PULL for-2.0 1/1] tests/acpi: update expected DSDT files

2014-04-09 Thread Michael S. Tsirkin
commit f2ccc311df55ec026a8f8ea9df998f26314f22b2 dsdt: tweak ACPI ID for hotplug resource device changes the DSDT, update test expected files to match Signed-off-by: Michael S. Tsirkin m...@redhat.com Reported-by: Igor Mammedov imamm...@redhat.com --- tests/acpi-test-data/pc/DSDT | Bin 4485

[Qemu-devel] [PULL for-2.0 0/1] acpi test: DSDT update

2014-04-09 Thread Michael S. Tsirkin
The following changes since commit efcc87d9aedb590b8506cd1a7c8abe557c760f9e: Update version for v2.0.0-rc2 release (2014-04-08 18:52:06 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [RFC v2 1/6] hw/arm/virt: add a xgmac device

2014-04-09 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org This is a hack and only serves as an example of what needs to be done to make the next RFC - add vfio-platform support - work for development purposes on a Calxeda Midway system. We don't want mach-virt to always create this ethernet device - DO NOT

[Qemu-devel] [RFC v2 3/6] vfio: add vfio-platform support

2014-04-09 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org Functions for which PCI and platform device support share are moved into common.c. The common vfio_{get,put}_group() get an additional argument, a pointer to a vfio_reset_handler(), for which to pass on to qemu_register_reset, but only if it exists (the

[Qemu-devel] [RFC v2 5/6] virt: Assign a VFIO platform device to a virt VM in QEMU command line

2014-04-09 Thread Eric Auger
This patch aims at allowing the end-user to specify the device he wants to directly assign to his virt VM in the QEMU command line. The QEMU platform device becomes generic. Current choice is to reuse the -device option. For example when assigning Calxeda Midway xgmac device this option is used:

[Qemu-devel] [RFC v2 4/6] vfio: Add initial IRQ support in QEMU platform device

2014-04-09 Thread Eric Auger
This work is inspired of PCI INTx. The code was prepared to support multiple IRQs but this was not tested at that stage. Similarly to what is done on PCI, the device register space is RAM unmapped on IRQ hit in order to trap the end of interrupt (EOI). On mmap timer hit, if the EOI was trapped,

[Qemu-devel] [RFC v2 2/6] vfio: move hw/misc/vfio.c to hw/vfio/pci.c

2014-04-09 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org This is done in preparation for the addition of VFIO platform device support. Signed-off-by: Kim Phillips kim.phill...@linaro.org --- LICENSE| 2 +- MAINTAINERS| 2 +- hw/Makefile.objs | 1 +

[Qemu-devel] [RFC v2 6/6] vfio: add exit function and IRQ disable functions

2014-04-09 Thread Eric Auger
this patch brings misc improvements: - improve comments - remove interrupt field in VFIODevice - add IRQ disable routines used by new exitfn function Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/vfio/platform.c | 167 - 1 file

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Cornelia Huck
On Wed, 09 Apr 2014 16:30:33 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 16:24, Cornelia Huck wrote: On Wed, 09 Apr 2014 16:05:00 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 13:34, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw

[Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-09 Thread Markus Armbruster
I stumbled over this while trying to purge error_is_set() from the code. Here's how we commonly use the Error API: Error *err = NULL; foo(arg, err) if (err) { goto out; } bar(arg, err) if (err) { goto out; } This ensures that err is null on entry,

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Alexander Graf
Am 09.04.2014 um 17:35 schrieb Cornelia Huck cornelia.h...@de.ibm.com: On Wed, 09 Apr 2014 16:30:33 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 16:24, Cornelia Huck wrote: On Wed, 09 Apr 2014 16:05:00 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 13:34, Cornelia

[Qemu-devel] [RFC v2 0/6] KVM platform device passthrough

2014-04-09 Thread Eric Auger
This is an RFC about QEMU VFIO platform device implementation. This work aims at enabling KVM platform device passthrough, where a guest OS is directly assigned a platform device: meaning it can access the register space without trapping, and receive IRQ from the device. Also the system MMU

Re: [Qemu-devel] [PATCH v4 3/5] s390x: Add I/O adapter registration.

2014-04-09 Thread Cornelia Huck
On Wed, 9 Apr 2014 17:53:40 +0200 Alexander Graf ag...@suse.de wrote: Am 09.04.2014 um 17:35 schrieb Cornelia Huck cornelia.h...@de.ibm.com: On Wed, 09 Apr 2014 16:30:33 +0200 Alexander Graf ag...@suse.de wrote: On 09.04.14 16:24, Cornelia Huck wrote: On Wed, 09 Apr 2014

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-09 Thread Eric Blake
On 04/09/2014 09:48 AM, Markus Armbruster wrote: I stumbled over this while trying to purge error_is_set() from the code. But: is it a good idea to have both patterns in the code? Should we perhaps use the common pattern for visiting, too? Like this: visit_type_str(v, foo, foo,

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-09 Thread Anthony Liguori
On Wed, Apr 9, 2014 at 8:48 AM, Markus Armbruster arm...@redhat.com wrote: I stumbled over this while trying to purge error_is_set() from the code. Here's how we commonly use the Error API: Error *err = NULL; foo(arg, err) if (err) { goto out; } bar(arg,

[Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command

2014-04-09 Thread Baojun Wang
Signed-off-by: Baojun Wang wan...@gmail.com --- cpus.c | 29 + hmp-commands.hx | 13 + hmp.c| 11 +++ hmp.h| 1 + qapi-schema.json | 18 ++ qmp-commands.hx | 27 +++ 6

Re: [Qemu-devel] [PATCH V4 1/1] qmp: add pmemload command

2014-04-09 Thread Eric Blake
On 04/09/2014 10:54 AM, Baojun Wang wrote: Signed-off-by: Baojun Wang wan...@gmail.com You lost this part of your commit message, which gives more details about the 'why' (the subject line covers the 'what', but it is often the 'why' that is most needed when reviewing a commit later). Your

Re: [Qemu-devel] [PATCH v8 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-04-09 Thread Eric Blake
On 04/09/2014 01:12 AM, Hu Tao wrote: This patch prepares for the subsequent patches. Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 14 ++ 2 files changed, 18 insertions(+), 4

[Qemu-devel] [PATCH] Re: snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

2014-04-09 Thread Jun Li
Thanks Eric's analysis and review firstly. As not so clear to the application context, so the first patch can not cover symlink scenarios. In this patch, will check the backing_filename is a symlink or not firstly, then return the full(absolute) path via realpath. If this patch has something not

Re: [Qemu-devel] [PATCH v3 21/26] tcg-aarch64: Introduce tcg_out_insn_3507

2014-04-09 Thread Richard Henderson
On 04/09/2014 05:54 AM, Claudio Fontana wrote: During testing I found this patch causes a regression for big endian targets (sparc). Can you take a look? I think it might be related to the extended form of the REV instruction needing an additional 0x400. See below. You're right. It's

Re: [Qemu-devel] Error propagation in generated visitors and command marshallers

2014-04-09 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: I stumbled over this while trying to purge error_is_set() from the code. Here's how we commonly use the Error API: Error *err = NULL; foo(arg, err) if (err) { goto out; } bar(arg, err) if (err) {

[Qemu-devel] qemu projects

2014-04-09 Thread Pradeep Kiruvale
Hi All, I am new to qemu-kvm.But have good knowledge about virtulization and cloud computing.I would like to do some projects in qemu-kvm.Please let me know how can I start. Please suggest me some small projects which I can take up and finish in 2-3 weeks. Regards, Pradeep

[Qemu-devel] TCG x86-64 'bt' insn

2014-04-09 Thread Clemens Kolbitsch
Hi guys, I have to revive a rather old thread [1,2]. A quick summary of the issue: TCG emulates the BT (bit-test) instruction using a SAR to re-compute eflags. While SAR affects all flags, BT only affects the C-flag and leaves the Z-flag unaffected/unchanged [3]. According to the x86 manual,

[Qemu-devel] [PATCH V3 4/5] machine: replace QEMUMachine by MachineClass in accelerator configuration

2014-04-09 Thread Marcel Apfelbaum
This minimizes QEMUMachine usage, as part of machine QOM-ification. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- include/hw/xen/xen.h| 2 +- include/qemu/typedefs.h | 1 + include/sysemu/kvm.h| 2 +- include/sysemu/qtest.h | 2 +- kvm-all.c | 6 +++---

[Qemu-devel] [PATCH V3 0/5] remove QEMUMachine indirection from MachineClass

2014-04-09 Thread Marcel Apfelbaum
Cc: Andreas Färber afaer...@suse.de V2 - V3: - Addressed Andreas's comments: - Dropped QEMUMachineInitArgs's 'next' obsoleted field in a separate patch - Revision the separation into patches: - Started using MachineClass for .machine early (3/5). - Merged hw/ppc

[Qemu-devel] [PATCH V3 1/5] hw/boards.h: remove obsoleted field from QEMUMachine

2014-04-09 Thread Marcel Apfelbaum
This field shouldn't be used any more since we adopted the QOM way of iterating over the types. The commit that obsoleted it is: commit 261747f176f6f2d88f8268aaebfdd1a1afe887e2 vl: Use MachineClass instead of global QEMUMachine list The machine registration flow is refactored to use the

[Qemu-devel] [PATCH V3 3/5] vl.c: Replace QEMUMachine with MachineClass in QEMUMachineInitArgs

2014-04-09 Thread Marcel Apfelbaum
QEMUMachine's fields are already in MachineClass. We can safely make the switch because we copy them in machine_class_init. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- include/hw/boards.h | 5 +++-- vl.c| 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH V3 2/5] vl.c: copy QEMUMachine's fields to MachineClass

2014-04-09 Thread Marcel Apfelbaum
In order to eliminate the QEMUMachine indirection, add its fields directly to MachineClass. Do not remove yet qemu_machine field because it is still in use by sparpr. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- include/hw/boards.h | 23 +++ vl.c|

[Qemu-devel] [PATCH V3 5/5] machine: remove QEMUMachine indirection from MachineClass

2014-04-09 Thread Marcel Apfelbaum
No need to go through qemu_machine field. Use MachineClass fields directly. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- device-hotplug.c| 2 +- hw/ppc/spapr.c | 26 -- include/hw/boards.h | 1 - qmp.c | 4 +-- vl.c| 79

[Qemu-devel] [PATCH V5 1/1] qmp: add pmemload command

2014-04-09 Thread Baojun Wang
I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target debug which gdb cannot do directly. Many thanks to Eric Blake for review the patch and

Re: [Qemu-devel] TCG x86-64 'bt' insn

2014-04-09 Thread Clemens Kolbitsch
Hi, quick follow-up. *As always* you find a problem right after asking for help :). The updated patch does not cause BSOD on Windows guests, but neither does it fix the actual problem (of the program seg-faulting) I would really appreciate any feedback on the proposed patch below - the

Re: [Qemu-devel] [PATCH v17 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-04-09 Thread Jeff Cody
On Tue, Apr 08, 2014 at 05:07:38PM +0800, Fam Zheng wrote: On Tue, 04/08 10:15, Markus Armbruster wrote: Jeff Cody jc...@redhat.com writes: On Mon, Mar 10, 2014 at 03:26:04PM +0800, Fam Zheng wrote: Dropping intermediate could be useful both for commit and stream, and BDS refcnt

Re: [Qemu-devel] [PATCH v17 06/14] block: Add backing_blocker in BlockDriverState

2014-04-09 Thread Jeff Cody
On Mon, Mar 10, 2014 at 03:26:02PM +0800, Fam Zheng wrote: This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState-backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at

[Qemu-devel] [Bug 1303926] Re: qemu-system-x86_64 crashed with SIGABRT

2014-04-09 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 2.0.0~rc1+dfsg-0ubuntu3 --- qemu (2.0.0~rc1+dfsg-0ubuntu3) trusty; urgency=medium * d/p/ubuntu/kvm_physical_sync_dirty_bitmap-ignore-ENOENT-from-kv.patch don't abort() just because the kernel has no dirty bitmap. (LP: #1303926) --

Re: [Qemu-devel] [PATCH v2] PPC: Clean up DECR implementation

2014-04-09 Thread Tom Musta
On 4/8/2014 2:58 PM, Alexander Graf wrote: On 04/08/2014 09:56 PM, Tom Musta wrote: On 4/6/2014 3:55 PM, Alexander Graf wrote: snip @@ -806,6 +838,10 @@ clk_setup_cb cpu_ppc_tb_init (CPUPPCState *env, uint32_t freq) tb_env = g_malloc0(sizeof(ppc_tb_t)); env-tb_env = tb_env;

[Qemu-devel] [PATCH 1/2] target-ppc: Fix target_disas

2014-04-09 Thread Tom Musta
Inspect only bit 16 for the Little Endian test. Correct comment preceding the target_disas() function. Correct grammar in comment for flags processing. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- V4: Correct grammar definitions of the

[Qemu-devel] [PATCH 2/2] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode

2014-04-09 Thread Tom Musta
The monitor support for disassembling instructions does not honor the MSR[LE] bit for PowerPC processors. This change enhances the monitor_disas() routine by supporting a flag bit for Little Endian mode. Bit 16 is used since that bit was used in the analagous guest disassembly routine

[Qemu-devel] [PATCH 0/2] QEMU Monitor Instruction Disassembly Incorrect for PPC LE

2014-04-09 Thread Tom Musta
Fix disassembly in the QEMU monitor for Little Endian codes. Also fix the comment and tighten up a flag check in the closely related disassembler code for tracing. V2: Fixed target_disas comment and bit decoding. V3: Make monitor_disas flag documentation refer to target_disas documentation. V4:

[Qemu-devel] Turning off default storage devices?

2014-04-09 Thread Andy Lutomirski
Currently, -M q35 boots linux quite a bit slower than the default machine type. This seems to be because it takes a few hundred ms to determine that there's nothing attached to the AHCI controller. In virtio setups, there will probably never be anything attached to the AHCI controller. Would it

Re: [Qemu-devel] [PATCH v2] PPC: Clean up DECR implementation

2014-04-09 Thread Alexander Graf
Am 09.04.2014 um 21:33 schrieb Tom Musta tommu...@gmail.com: On 4/8/2014 2:58 PM, Alexander Graf wrote: On 04/08/2014 09:56 PM, Tom Musta wrote: On 4/6/2014 3:55 PM, Alexander Graf wrote: snip @@ -806,6 +838,10 @@ clk_setup_cb cpu_ppc_tb_init (CPUPPCState *env, uint32_t freq)

Re: [Qemu-devel] [PATCH target-arm v1 1/1] net: cadence_gem: Make phy respond to broadcast

2014-04-09 Thread Beniamino Galvani
On Thu, Apr 03, 2014 at 11:55:19PM -0700, Peter Crosthwaite wrote: Phys must respond to address 0 by specification. Implement. Signed-off-by: Nathan Rossi nathan.ro...@xilinx.com Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/net/cadence_gem.c | 4 ++-- 1 file

[Qemu-devel] [PATCH] target-i386: Preserve the Z bit for bt/bts/btr/btc

2014-04-09 Thread Richard Henderson
Older Intel manuals (pre-2010) describe Z as undefined, but AMD and newer Intel manuals describe Z as unchanged. Signed-off-by: Richard Henderson r...@twiddle.net --- target-i386/translate.c | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) ---

Re: [Qemu-devel] [PATCH microblaze v1 1/1] net: xilinx_axienet.c: Add phy soft reset bit clearing

2014-04-09 Thread Beniamino Galvani
On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote: From: Nathan Rossi nathan.ro...@xilinx.com Clear the BMCR Reset when writing to registers. Signed-off-by: Nathan Rossi nathan.ro...@xilinx.com [ PC: * Trivial style fixes to commit message ] Signed-off-by: Peter

  1   2   >