[Qemu-devel] [PATCH v2] trace: Replace fprintf with error_report and print location

2014-06-02 Thread Alexey Kardashevskiy
This replaces fprintf(stderr) with error_report. This moves local variables to the beginning of the function to comply with QEMU's coding style. Suggested-by: Lluís Vilanova vilan...@ac.upc.edu Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v2: * polished commit log ---

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
Hi, This approach doesn't work, although the problem is different. Input is now recognized, but unwanted key repeats creep in. For example, I typed exit and got exiitt. I tested this several times while typing as accurately and quickly as I could. My theory is that the key releases

Re: [Qemu-devel] [RFC PATCH] kvm: Enable -cpu option to hide KVM

2014-06-02 Thread Paolo Bonzini
Il 01/06/2014 23:11, Alex Williamson ha scritto: It's really a nit, but I think kvm=no is preferrable (more consistent with how hyper-v leaves are enabled). Happy to oblige, but I'm not sure what I'm looking for. We enably hyper-v leaves if hyperv_enabled(), which seems to boil down to the

[Qemu-devel] [PATCH v2] thread-pool: fix deadlock when callbacks depends on each other

2014-06-02 Thread Marcin Gibuła
When two coroutines submit I/O and first coroutine depends on second to complete (by calling bdrv_drain_all), deadlock may occur. This is because both requests may have completed before thread pool notifier got called. Then, when notifier gets executed and first coroutine calls aio_pool() to

Re: [Qemu-devel] [PATCH v2 1/2] spapr: Create SPAPRMachine struct

2014-06-02 Thread Aneesh Kumar K.V
Eduardo Habkost ehabk...@redhat.com writes: Signed-off-by: Eduardo Habkost ehabk...@redhat.com Tested-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/ppc/spapr.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

Re: [Qemu-devel] [PATCH v2 2/2] spapr: Add kvm-type property

2014-06-02 Thread Aneesh Kumar K.V
Eduardo Habkost ehabk...@redhat.com writes: The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option from being used. Add the missing property to the sPAPR machine class, so it can be used. Signed-off-by: Eduardo Habkost ehabk...@redhat.com

Re: [Qemu-devel] [PATCH 1/6] usb: add usb_bus_release function

2014-06-02 Thread Gerd Hoffmann
Hi, +void usb_bus_release(USBBus *bus) +{ +assert(next_usb_bus 0); + +next_usb_bus--; +QTAILQ_REMOVE(busses, bus, next); +} That breaks when not hotplugging in last-in-first-out order. I'd suggest to simply leave next_usb_bus alone on unplug. It is only used for bus

[Qemu-devel] [PATCH qom v1 0/4] QOMify IRQs

2014-06-02 Thread Peter Crosthwaite
Hi Andreas and all, I have done some cleanup of your WIP IRQ QOMification and have it in a hopefully ready state. Its now link safe and the allocation/freeing process is not as complex as before. For fuller context of the motivation behind this series, please see:

[Qemu-devel] [PATCH qom v1 1/4] sdhci: Fix misuse of qemu_free_irqs()

2014-06-02 Thread Peter Crosthwaite
From: Andreas Färber afaer...@suse.de It does a g_free() on the pointer. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH qom v1 2/4] hw: Fix qemu_allocate_irqs() leaks

2014-06-02 Thread Peter Crosthwaite
From: Andreas Färber afaer...@suse.de Replace qemu_allocate_irqs(foo, bar, 1)[0] with qemu_allocate_irq(foo, bar, 0). This avoids leaking the dereferenced qemu_irq *. Cc: Kirill Batuzov batuz...@ispras.ru Cc: Markus Armbruster arm...@redhat.com Cc: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH qom v1 3/4] irq: Allocate IRQs individually

2014-06-02 Thread Peter Crosthwaite
Allocate each IRQ individually on array allocations. This prepares for QOMification of IRQs, where pointers to individual IRQs may be taken and handed around for usage as QOM Links. The g_renew scheme used here is too fragile and would break all existing links should an IRQ list be extended. We

Re: [Qemu-devel] [PATCH 2/6] usb-ohci: add exit function

2014-06-02 Thread Gerd Hoffmann
Hi, +static void usb_ohci_exit(PCIDevice *dev) +{ +OHCIPCIState *ohci = PCI_OHCI(dev); +OHCIState *s = ohci-state; + +memory_region_destroy(s-mem); + +if (!ohci-masterbus) { +usb_bus_release(s-bus); +} +} This is incomplete. At minimum you have to care

[Qemu-devel] [PATCH qom v1 4/4] irq: Slim conversion of qemu_irq to QOM

2014-06-02 Thread Peter Crosthwaite
From: Andreas Färber afaer...@suse.de As a prequel to any big Pin refactoring plans, do an in-place conversion of qemu_irq to an Object, so that we can reference it in link properties. Signed-off-by: Andreas Färber afaer...@suse.de [ PC Changes: * Removed array-alloctor ref counting logic

[Qemu-devel] [RFC v3 00/10] KVM platform device passthrough

2014-06-02 Thread Eric Auger
This RFC series aims at enabling KVM platform device passthrough. It implements a VFIO platform device and offers the capability to instantiate this VFIO device in mach-virt. The VFIO platform device uses an host VFIO platform driver which must be bound to the assigned device prior to the QEMU

[Qemu-devel] [RFC v3 01/10] hw/arm/virt: add a xgmac device

2014-06-02 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org This is a hack and only serves as an example of what needs to be done to make the next RFC - add vfio-platform support - work for development purposes on a Calxeda Midway system. We don't want mach-virt to always create this ethernet device - DO NOT

[Qemu-devel] [RFC v3 07/10] Add EXEC_FLAG to VFIO DMA mappings

2014-06-02 Thread Eric Auger
From: Alvise Rigo a.r...@virtualopensystems.com The flag is mandatory for the ARM SMMU so we always add it if the MMIO handles it. Signed-off-by: Alvise Rigo a.r...@virtualopensystems.com --- hw/vfio/common.c | 9 + hw/vfio/vfio-common.h | 1 + linux-headers/linux/vfio.h

[Qemu-devel] [RFC v3 02/10] vfio: move hw/misc/vfio.c to hw/vfio/pci.c

2014-06-02 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org This is done in preparation for the addition of VFIO platform device support. Signed-off-by: Kim Phillips kim.phill...@linaro.org --- LICENSE| 2 +- MAINTAINERS| 2 +- hw/Makefile.objs | 1 +

[Qemu-devel] [RFC v3 04/10] vfio: simplifed DPRINTF calls using device name

2014-06-02 Thread Eric Auger
This patch gets benefit from the new VFIODevice name field. Occurences of DPRINTF(%s(%04x:%02x:%02x.%x) ..., __func__, vdev-host.domain, vdev-host.bus, vdev-host.slot, vdev-host.function, ...) are replaced by DPRINTF(%s(%s ..., __func__, vdev-vdev.name, ...). name is built using

[Qemu-devel] [RFC v3 06/10] virt: Assign a VFIO platform device with -device option

2014-06-02 Thread Eric Auger
This patch aims at allowing the end-user to specify the device he wants to directly assign to his mach-virt guest in the QEMU command line. The QEMU platform device becomes generic. Current choice is to reuse the -device option. For example when assigning Calxeda Midway xgmac device this option

[Qemu-devel] [RFC v3 08/10] Add AMBA devices support to VFIO

2014-06-02 Thread Eric Auger
From: Alvise Rigo a.r...@virtualopensystems.com The impossibility to add more then one compatibility property to the device tree node was not permitting to bind AMBA devices. Now we can add an arbitrary number of compatibility property values divided by the character ;. If the compatibility

[Qemu-devel] [RFC v3 10/10] vfio: Add irqfd support in platform device

2014-06-02 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. It brings significant performance improvement over traditional IRQ handling introduced in : vfio: Add initial IRQ support in platform device. This new IRQ handling method depends on kernel KVM irqfd/GSI routing capability. The IRQ

[Qemu-devel] [RFC v3 05/10] vfio: Add initial IRQ support in platform device

2014-06-02 Thread Eric Auger
This patch brings a first support for device IRQ assignment to a KVM guest. Code is inspired of PCI INTx code. General principle of IRQ handling: when a physical IRQ occurs, VFIO driver signals an eventfd that was registered by the QEMU VFIO platform device. The eventfd handler

[Qemu-devel] [RFC v3 09/10] Always use eventfd as notifying mechanism

2014-06-02 Thread Eric Auger
From: Alvise Rigo a.r...@virtualopensystems.com When eventfd is not configured the method event_notifier_init fallbacks to the pipe/pipe2 system call, causing an error in VFIO_DEVICE_SET_IRQS since we pass to the kernel a file descriptor which is not created by eventfd. Signed-off-by: Alvise

Re: [Qemu-devel] [PATCH 6/6] usb: tag usb host controller as hotpluggable

2014-06-02 Thread Gerd Hoffmann
On Fr, 2014-05-30 at 20:22 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com usb host controller should be able to support hotplug/unplug, as the same as the other pci devices, which not enable multifunction capability. BTW, the qemu have not the capability to

Re: [Qemu-devel] [PATCH qom v1 3/4] irq: Allocate IRQs individually

2014-06-02 Thread Alberto Garcia
On Mon, Jun 02, 2014 at 12:41:10AM -0700, Peter Crosthwaite wrote: Cc: agar...@igalia.com Cc: m...@redhat.com Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/char/serial-pci.c | 2 +- hw/core/irq.c| 20 +++- hw/core/qdev.c | 2 +-

Re: [Qemu-devel] [PATCH v2 0/2] Restore kvm-type option support on -machine pseries

2014-06-02 Thread Alexander Graf
On 30.05.14 23:24, Eduardo Habkost wrote: Second try, now changing only the pseries machine code at hw/ppc/spapr.c. Thanks for testing Aneesh. Which queue should this go through? Alex

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Jack Biggs
Hi Richard, thanks for your help. Which instruction, then, I should add my gen_helper to in order for it to be called at the end of each basic block, as I've previously stated? Is there a way I can generically have this change apply to every target? Jack On 05/30/2014 06:25 PM, Richard

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/06/02 at 09:07 +0200] Hi: Sounds plausible. Then adding a delay after queuing the release events should fix it. Can you try the attached patch (as incremental fix on top of the other three patches)? It still isn't working correctly. I've just played with

Re: [Qemu-devel] [PATCH 11/21] target-mips: Status.UX/SX/KX enable 32-bit address wrapping

2014-06-02 Thread Leon Alrae
On 30/05/14 23:41, Aurelien Jarno wrote: In R6 the special behaviour for data references is also specified for Kernel and Supervisor mode. Therefore MIPS_HFLAG_UX is replaced by generic MIPS_HFLAG_X indicating whether 64-bit mode is enabled in current operating mode. I haven't found any

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-06-02 Thread Marcel Apfelbaum
On Sun, 2014-06-01 at 11:31 +0300, Marcel Apfelbaum wrote: On Fri, 2014-05-30 at 17:41 -0300, Eduardo Habkost wrote: The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option from being used. Add the missing property. Very interesting how did

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Dave Mielke
Hi: A follow-up to my last message. I'm glad I left those js repeating while I wrote it. After sending it, I returned to that session and discovered that they'd finally stopped. This caused me to do some more experimentation. I held j down for quite a short period of time, and, sure enough,

Re: [Qemu-devel] [patch 0/2] add QMP command to reset rtc interrupt backlog

2014-06-02 Thread Michal Privoznik
On 30.05.2014 16:05, Marcelo Tosatti wrote: It is necessary to reset RTC interrupt backlog if guest time is synchronized via a different mechanism, such as QGA's guest-set-time command. Failing to do so causes both corrections to be applied (summed), resulting in an incorrect guest time.

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
On Mo, 2014-06-02 at 05:00 -0400, Dave Mielke wrote: Hi: A follow-up to my last message. I'm glad I left those js repeating while I wrote it. After sending it, I returned to that session and discovered that they'd finally stopped. This caused me to do some more experimentation. I held j

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
Hi, Something else I noticed was that typing a control character would result in a doubling of that character. For example, control u resulted in UU. Does that also happen with the sendkey ctrl-u monitor command? cheers, Gerd

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Alex Bennée
Jack Biggs writes: Hi Richard, thanks for your help. Which instruction, then, I should add my gen_helper to in order for it to be called at the end of each basic block, as I've previously stated? Is there a way I can generically have this change apply to every target? Jack On

Re: [Qemu-devel] [PATCH v1 01/16] target-arm: A64: Break out aarch64_save/restore_sp

2014-06-02 Thread Alex Bennée
Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@xilinx.com Break out code to save/restore AArch64 SP into functions. Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/internals.h | 29 - target-arm/kvm64.c | 13

Re: [Qemu-devel] [PATCH 01/21] target-mips: introduce MIPS64R6 ISA and a new generic CPU

2014-06-02 Thread Leon Alrae
On 30/05/14 17:43, Aurelien Jarno wrote: +/* A generic CPU providing MIPS64 Release 6 features. + FIXME: Eventually this should be replaced by a real CPU model. */ +.name = MIPS64R6-generic, +.CP0_PRid = 0x0001, +.CP0_Config0 = MIPS_CONFIG0 |

Re: [Qemu-devel] [PATCH v3 5/8] virtio-blk: use aliases instead of duplicate qdev properties

2014-06-02 Thread Peter Crosthwaite
On Fri, May 30, 2014 at 9:17 PM, Stefan Hajnoczi stefa...@redhat.com wrote: virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the qdev properties of their VirtIOBlock child. This approach does not work well with string or pointer properties since we must be careful about

Re: [Qemu-devel] [PATCH v1 02/16] target-arm: A64: Respect SPSEL in ERET SP restore

2014-06-02 Thread Alex Bennée
Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index

Re: [Qemu-devel] [PATCH v1 03/16] target-arm: A64: Respect SPSEL when taking exceptions

2014-06-02 Thread Alex Bennée
Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/helper-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c

Re: [Qemu-devel] [PATCH 02/21] target-mips: signal RI Exception on instructions removed in R6

2014-06-02 Thread Maciej W. Rozycki
On Fri, 30 May 2014, Aurelien Jarno wrote: Just a comment, not related to QEMU: while it looks at a first glance to build a binary that runs on both pre-R6 and R6 by not using the removed instructions, I do wonder how the transition would be done for unaligned load/stores. On pre-R6,

Re: [Qemu-devel] [RFC PATCH] kvm: Enable -cpu option to hide KVM

2014-06-02 Thread Michael Tokarev
01.06.2014 20:25, Alex Williamson цкщеу: The latest Nvidia driver (337.88) specifically checks for KVM as the hypervisor and reports Code 43 for the driver in a Windows guest when found. Removing or changing the KVM signature is sufficient to allow the driver to load. Hmm.. Why does it do

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/06/02 at 11:29 +0200] Hi: When using my patch, I'm specifying -k delay=20 (so 20ms). Highest repeat rate ps/2 allows is 30Hz. Which is 33 ms delay per key event. We have two delays in there (one after pressing all keys, one after releasing all keys). So

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Jack Biggs
When you say arbitrary code what do you mean? Are you wanting to put backend specific code there or a common post-amble of tcg ops? Can you give a bit more detail about your use case? I'm trying to add a clock-synchronization library so that I can have two (or more) instances of QEMU run in a

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/06/02 at 11:31 +0200] Hi: Does that also happen with the sendkey ctrl-u monitor command? Yes, it does. This test was with the newest (10ms) delay patch. -- Dave Mielke | 2213 Fox Crescent | The Bible is the very Word of God. Phone:

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Peter Maydell
On 2 June 2014 11:15, Jack Biggs john.bi...@epfl.ch wrote: When you say arbitrary code what do you mean? Are you wanting to put backend specific code there or a common post-amble of tcg ops? Can you give a bit more detail about your use case? I'm trying to add a clock-synchronization library

Re: [Qemu-devel] [PATCH 6/6] usb: tag usb host controller as hotpluggable

2014-06-02 Thread Michael S. Tsirkin
On Mon, Jun 02, 2014 at 09:58:18AM +0200, Gerd Hoffmann wrote: On Fr, 2014-05-30 at 20:22 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com usb host controller should be able to support hotplug/unplug, as the same as the other pci devices, which not enable

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Jack Biggs
Hi Peter, This is not a problem for now, the main reason we wanted to have this at the end is to potentially trace load / stores in the future. How would you recommend integrating this into icount? Just wanting to make sure I don't run into anything unexpected. Regards, Jack On

Re: [Qemu-devel] Question about gen_jmp_tb

2014-06-02 Thread Peter Maydell
On 2 June 2014 11:53, Jack Biggs john.bi...@epfl.ch wrote: This is not a problem for now, the main reason we wanted to have this at the end is to potentially trace load / stores in the future. How would you recommend integrating this into icount? Just wanting to make sure I don't run into

[Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Gerd Hoffmann
Make configure detect gtk x11 and win32 backends. Make gtk backend specific code properly #ifdefed on the new CONFIG_GTK_{X11,WIN32} config options. Our gtk ui code should build fine on any platform now. This also fixes the linker failute due to the new XkbGetKeyboard call added by commit

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 12:58:33PM +0200, Gerd Hoffmann wrote: diff --git a/configure b/configure index 0e516f9..b02f822 100755 --- a/configure +++ b/configure @@ -1986,6 +1986,8 @@ fi if test $gtk != no; then gtkpackage=gtk+-$gtkabi +gtkx11package=gtk+-x11-$gtkabi +

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 12:10:44PM +0100, Daniel P. Berrange wrote: On Mon, Jun 02, 2014 at 12:58:33PM +0200, Gerd Hoffmann wrote: diff --git a/configure b/configure index 0e516f9..b02f822 100755 --- a/configure +++ b/configure @@ -1986,6 +1986,8 @@ fi if test $gtk != no; then

Re: [Qemu-devel] [PATCH 0/3] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
On Mo, 2014-06-02 at 06:40 -0400, Dave Mielke wrote: [quoted lines by Gerd Hoffmann on 2014/06/02 at 11:29 +0200] Hi: When using my patch, I'm specifying -k delay=20 (so 20ms). Highest repeat rate ps/2 allows is 30Hz. Which is 33 ms delay per key event. We have two delays in there

[Qemu-devel] [PATCH v2 0/4] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
Hi, Little series of four input patches. First patch adds support for submitting keyboard delays, which will make the input layer setup a timer, buffer the following keyboard events, send them to the guest once the delay is over. This should be used anywhere where we send synthetic key events

[Qemu-devel] [PATCH 4/4] input/vnc: use kbd delays in press_key

2014-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 2d7def9..5521abb 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1552,7 +1552,9 @@ static void press_key(VncState *vs, int keysym) { int keycode =

[Qemu-devel] [PATCH 3/4] input/curses: add kbd delay between keydown and keyup events

2014-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/curses.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/curses.c b/ui/curses.c index de85f76..c96b861 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -277,31 +277,41 @@ static void curses_refresh(DisplayChangeListener *dcl)

[Qemu-devel] [PATCH 2/4] input: use kbd delays for send_key monitor command

2014-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 45 ++--- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 2a53860..018a1fa 100644 --- a/ui/input-legacy.c +++

[Qemu-devel] [PATCH 1/4] input: add support for kbd delays

2014-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 1 + ui/input.c | 106 +++-- 2 files changed, 104 insertions(+), 3 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h index aa99b0c..5d5ac00 100644 ---

Re: [Qemu-devel] [PATCH 1/3] rng-random: NULL check not needed before g_free()

2014-06-02 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: g_free() is NULL-safe. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: Anthony Liguori aligu...@amazon.com Cc: Luiz Capitulino lcapitul...@redhat.com --- backends/rng-random.c | 5 + 1 file changed, 1 insertion(+), 4

[Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Gerd Hoffmann
Make configure detect gtk x11 backend and link libX11 then. Make gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* backends at runtime). Our gtk ui code should build and run fine on any platform now. This also fixes the linker failute due to the new XkbGetKeyboard call added

Re: [Qemu-devel] [PATCH 3/3] hw/machine: Free old values of string properties

2014-06-02 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Fri, 2014-05-30 at 17:02 -0300, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: Marcel Apfelbaum marce...@redhat.com Cc: Andreas Färber afaer...@suse.de --- hw/core/machine.c | 8 1 file changed, 8

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 01:50:25PM +0200, Gerd Hoffmann wrote: Make configure detect gtk x11 backend and link libX11 then. Make gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* backends at runtime). Our gtk ui code should build and run fine on any platform now. This

Re: [Qemu-devel] [PATCH] qemu-img: Report error even with --oformat=json

2014-06-02 Thread Kevin Wolf
Am 31.05.2014 um 21:33 hat Max Reitz geschrieben: img_check() should report that the format of the given image does not support checks even if JSON output is desired. JSON data is output to stdout, as opposed to error messages, which are (in the case of qemu-img) printed to stderr. Therefore,

Re: [Qemu-devel] [Qemu-trivial] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-06-02 Thread Michael Tokarev
01.06.2014 02:39, Peter Maydell wrote: On 26 May 2014 08:20, Michael Tokarev m...@tls.msk.ru wrote: From: Le Tan tamlokv...@gmail.com Replace fprintf(stderr,...) with error_report() in files bsd-user/*. The trailing \ns of the @fmt argument have been removed because @fmt of error_report()

[Qemu-devel] [PATCH] console: fix -vga none -sdl crash

2014-06-02 Thread Gerd Hoffmann
Call get_alloc_displaystate() for proper initialization instead of allocating with g_new(). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/console.c b/ui/console.c index 3bc18cf..2467ce4 100644 ---

Re: [Qemu-devel] [PATCH 3/3] hw/machine: Free old values of string properties

2014-06-02 Thread Marcel Apfelbaum
On Mon, 2014-06-02 at 13:51 +0200, Markus Armbruster wrote: Marcel Apfelbaum marce...@redhat.com writes: On Fri, 2014-05-30 at 17:02 -0300, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: Marcel Apfelbaum marce...@redhat.com Cc: Andreas Färber

[Qemu-devel] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak

2014-06-02 Thread Chen Gang
Call g_free() after cache_fini() in migration_end(), but do not call g_free() after call cache_fini() in xbzrle_cache_resize() which will cause memory leak. cache_init() and cache_fini() are pair, so need let cache_fini() call g_free(cache) to match cache_init(), then fix current issue too.

Re: [Qemu-devel] [PATCH memory v3 6/9] memory: MemoryRegion: QOMify

2014-06-02 Thread Peter Maydell
On 2 June 2014 05:17, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: QOMify memory regions as an Object. The former init() and destroy() routines become instance_init() and instance_finalize() resp. memory_region_init() is re-implemented to be: object_initialize() + set fields

Re: [Qemu-devel] [PATCH] readline: Clear screen on form feed.

2014-06-02 Thread Stefan Hajnoczi
On Sun, Jun 01, 2014 at 12:53:35PM +0100, Hani Benhabiles wrote: Signed-off-by: Hani Benhabiles h...@linux.com --- util/readline.c | 9 + 1 file changed, 9 insertions(+) Please only CC me on patches for areas of the code that I maintain or you feel I am an expert in. That includes

Re: [Qemu-devel] [V4 PATCH (resend) 3/6] target-ppc: Add a new user mode target for little-endian PPC64.

2014-06-02 Thread Tom Musta
On 5/29/2014 9:12 AM, Tom Musta wrote: From: Doug Kwan dougk...@google.com Signed-off-by: Doug Kwan dougk...@google.com Signed-off-by: Tom Musta tommu...@gmail.com --- V3: Addressing comment from Peter Maydell. Adding libdecnumber enable. configure |6 ++ 1 files changed, 6

Re: [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote: @@ -151,10 +141,21 @@ typedef struct E1000State_st { uint32_t compat_flags; } E1000State; -#define TYPE_E1000 e1000 +typedef struct E1000DeviceClass { The QOM type is called TYPE_E1000_BASE (e1000-base), please name

Re: [Qemu-devel] [PATCH v3 3/3] e1000: remove broken support for 82573L

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:16PM -0400, Gabriel L. Somlo wrote: Currently, e1000 support is based on the manual for the 8254xx model series. 82573x models are documented in a separate manual (see

Re: [Qemu-devel] [PATCH v3 2/3] tests: e1000: test additional device IDs

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:15PM -0400, Gabriel L. Somlo wrote: Update e1000-test.c to check all currently supported devices. Suggested-by: Andreas Färber afaer...@suse.de Signed-off-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Michael S. Tsirkin m...@redhat.com --- tests/e1000-test.c |

Re: [Qemu-devel] [Qemu-ppc] [V4 PATCH (resend) 3/6] target-ppc: Add a new user mode target for little-endian PPC64.

2014-06-02 Thread Alexander Graf
On 02.06.14 14:23, Tom Musta wrote: On 5/29/2014 9:12 AM, Tom Musta wrote: From: Doug Kwan dougk...@google.com Signed-off-by: Doug Kwan dougk...@google.com Signed-off-by: Tom Musta tommu...@gmail.com --- V3: Addressing comment from Peter Maydell. Adding libdecnumber enable. configure |

Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote: Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. New in v3: - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with: -

Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients.

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote: Signed-off-by: Hani Benhabiles h...@linux.com --- include/block/nbd.h | 6 ++ nbd.c | 12 +++- 2 files changed, 13 insertions(+), 5 deletions(-) No explanation or link to specification for this new

Re: [Qemu-devel] [Qemu-trivial] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-06-02 Thread Peter Maydell
On 2 June 2014 13:08, Michael Tokarev m...@tls.msk.ru wrote: I applied it and actually tried to compile-check it, on kFreeBSD. Compile went successfully, and I was satisfied, until I figured that my kFreeBSD test script only builds qemu-system. So I went back and enabled this, and actually

[Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected

2014-06-02 Thread Chen Gang
'encoded_buf' and 'current_buf' are lock protected during using in save_xbzrle_page() in ram_save_page(), and during freeing in migration_end(). So recommend to let them lock protected during starting, just like we have done to 'cache'. Signed-off-by: Chen Gang gang.chen.5...@gmail.com ---

Re: [Qemu-devel] [PATCH 0/3] Migrate with destination version

2014-06-02 Thread Markus Armbruster
Dr. David Alan Gilbert dgilb...@redhat.com writes: * Paolo Bonzini (pbonz...@redhat.com) wrote: [...] Version numbers open a huge compatibility can of worms (what is a version number?) No, a version number here is very well defined; it's the output of query-version' (or 'info version' for

[Qemu-devel] Xen hypervisor inside KVM guest with x2apic CPU feature fails to boot

2014-06-02 Thread Daniel P. Berrange
I'm running kernel-3.14.4-200.fc20.x86_64 qemu-1.6.2-5.fc20.x86_64 xen-4.4.0-4.fc21 In process of trying to get a Xen hypervisor running inside a KVM guest I found that there's a problem with x2apic. NB I do *not* use nested-VMX here, just trying to get plain Xen paravirt working before

Re: [Qemu-devel] [PATCH 3/3] hw/machine: Free old values of string properties

2014-06-02 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Mon, 2014-06-02 at 13:51 +0200, Markus Armbruster wrote: Marcel Apfelbaum marce...@redhat.com writes: On Fri, 2014-05-30 at 17:02 -0300, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: Marcel Apfelbaum

Re: [Qemu-devel] [PATCH 2/3] rng-egd: Free old chr_name value before setting new one

2014-06-02 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: Anthony Liguori aligu...@amazon.com Cc: Amos Kong ak...@redhat.com --- backends/rng-egd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/rng-egd.c b/backends/rng-egd.c

Re: [Qemu-devel] [PATCH v2 0/4] input: add support for kbd delays

2014-06-02 Thread Dave Mielke
[quoted lines by Gerd Hoffmann on 2014/06/02 at 13:28 +0200] Hi: Little series of four input patches. Yes, it all seems to work correctly, now, with these four patches applied. Perhaps there should be a common constant that all the delay calls use. Maybe even a variable which defaults to 10

[Qemu-devel] [Bug 922076] Re: doesn't clear screen on boot

2014-06-02 Thread Askar Safin
** Description changed: - When I start Linux in Qemu via qemu -kernel /vmlinuz ..., opens Qemu - window, it shows message Starting Seabios (version 0.5.1-2010...), and - then Linux writes messages like Loading, please wait... on top of + When I start Linux in Qemu via qemu -kernel /vmlinuz ...,

Re: [Qemu-devel] [Xen-devel] Xen hypervisor inside KVM guest with x2apic CPU feature fails to boot

2014-06-02 Thread Andrew Cooper
On 02/06/14 13:45, Daniel P. Berrange wrote: I'm running kernel-3.14.4-200.fc20.x86_64 qemu-1.6.2-5.fc20.x86_64 xen-4.4.0-4.fc21 In process of trying to get a Xen hypervisor running inside a KVM guest I found that there's a problem with x2apic. NB I do *not* use nested-VMX here, just

Re: [Qemu-devel] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-06-02 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 26 May 2014 08:20, Michael Tokarev m...@tls.msk.ru wrote: From: Le Tan tamlokv...@gmail.com Replace fprintf(stderr,...) with error_report() in files bsd-user/*. The trailing \ns of the @fmt argument have been removed because @fmt of

Re: [Qemu-devel] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-06-02 Thread Michael Tokarev
02.06.2014 17:09, Markus Armbruster wrote: Peter Maydell peter.mayd...@linaro.org writes: [] because none of these bsd-user files include a header which gives a prototype for error_report. Also, these are just straightforward reporting of command line errors, and I think that, like the

[Qemu-devel] [PATCH v4 01/33] pc: create custom generic PC machine type

2014-06-02 Thread Igor Mammedov
it will be used for PC specific options/variables Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com --- hw/i386/pc.c | 57 ++ hw/i386/pc_piix.c| 36

[Qemu-devel] [PATCH v4 02/33] pc: ACPI BIOS: use enum for defining memory affinity flags

2014-06-02 Thread Igor Mammedov
replace magic numbers with enum describing Flags field of memory affinity in SRAT table. MemoryAffinityFlags enum will define flags decribed by: ACPI spec 5.0, 5.2.16.2 Memory Affinity Structure, Table 5-69 Flags - Memory Affinity Structure Signed-off-by: Igor Mammedov imamm...@redhat.com

[Qemu-devel] [PATCH v4 03/33] object_add: allow completion handler to get canonical path

2014-06-02 Thread Igor Mammedov
Add object to /objects before calling user_creatable_complete() handler, so that object might be able to call object_get_canonical_path() in its completion handler. Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com --- qmp.c | 11

[Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-02 Thread Igor Mammedov
NOTE to commiter: * update precompiled ACPI hex files for iasl-less hosts and ACPI tables test to match new ACPI tables. What's new since v10: * rename DimmDevice to PCDIMMDevice * allow anonymous DIMMs * fix error handling in hostmemory_backend_set_size() * fix ACPI read callback for

[Qemu-devel] [PATCH v4 04/33] vl.c: daemonize before guest memory allocation

2014-06-02 Thread Igor Mammedov
memory allocated for guest before QEMU is daemonized and then mapped later in guest's address space after it is daemonized, leads to EPT violation and QEMU aborts. To avoid this and similar issues switch to daemonized mode early before applying/processing other options. Signed-off-by: Igor

[Qemu-devel] [PATCH v4 11/33] pc-dimm: do not allow to set already used memdev

2014-06-02 Thread Igor Mammedov
using the same memdev backend more than once will cause assersion at MemoryRegion mapping time becase it's already mapped. Prevent it by checking that associated MemoryRegion is not mapped. Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com

[Qemu-devel] [PATCH v4 27/33] pc: migrate piix4 ich9 MemHotplugState

2014-06-02 Thread Igor Mammedov
Adds an optional subsection that allows to migrate current state of acpi_memory_hotplug of ACPI PM device. Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com --- v2: * use subsection, requested by pbonzini --- hw/acpi/ich9.c

[Qemu-devel] [PATCH v4 21/33] trace: add acpi memory hotplug IO region events

2014-06-02 Thread Igor Mammedov
Add events for tracing accesses to memory hotplug IO ports. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/memory_hotplug.c | 13 + trace-events | 13 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/acpi/memory_hotplug.c

[Qemu-devel] [PATCH v4 13/33] pc: exit QEMU if number of slots more than supported 256

2014-06-02 Thread Igor Mammedov
... which is imposed by current naming scheme of ACPI memory devices. Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com --- v2: * use define for amount of supported slots, requested by Eduardo Habkost --- hw/i386/pc.c |6

[Qemu-devel] [PATCH v4 19/33] acpi: rename cpu_hotplug_defs.h to pc-hotplug.h

2014-06-02 Thread Igor Mammedov
to make it more generic, so it could be used for memory hotplug as well. Signed-off-by: Igor Mammedov imamm...@redhat.com Acked-by: Peter Crosthwaite peter.crostwa...@xilinx.com --- v2: - s/acpi_defs.h/pc-hotplug.h/, requested by mst --- hw/i386/acpi-dsdt.dsl |2 +-

[Qemu-devel] [PATCH v4 06/33] vl.c: extend -m option to support options for memory hotplug

2014-06-02 Thread Igor Mammedov
Add following parameters: slots - total number of hotplug memory slots maxmem - maximum possible memory slots and maxmem should go in pair and maxmem should be greater than mem for memory hotplug to be enabled. Signed-off-by: Igor Mammedov imamm...@redhat.com --- v4: - store maxmem slots

[Qemu-devel] [PATCH v4 30/33] pc: ACPI BIOS: implement memory hotplug interface

2014-06-02 Thread Igor Mammedov
- provides static SSDT object for memory hotplug that can handle upto 256 hotplugable memory slots - SSDT template for memory devices and runtime generator of them in SSDT table. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v4 24/33] acpi:piix4: add memory hotplug handling

2014-06-02 Thread Igor Mammedov
Add memory hotplug initialization/handling to PIIX4_PM device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/piix4.c | 15 ++- include/hw/acpi/memory_hotplug.h |1 + include/hw/i386/pc.h

  1   2   3   4   >