On Tue, 2014-09-30 at 21:38 +0800, Gonglei wrote:
Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability
of
pcie devices
On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
In QEMU, ARI Forwarding
John Snow js...@redhat.com writes:
On 09/30/2014 03:38 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Instead of duplicating the logic for the if_ide
(bus,unit) mappings, rely on the blockdev layer
for managing those mappings for us, and use the
drive_get_by_index call
Benoît Canet benoit.ca...@irqsave.net writes:
The Tuesday 30 Sep 2014 à 22:08:12 (+0300), Boris Sukholitko wrote :
On Tue, Sep 30, 2014 at 12:46 AM, Benoît Canet
benoit.ca...@irqsave.net wrote:
The Friday 26 Sep 2014 à 18:19:55 (+0300), Boris Sukholitko wrote :
This patchset is a small
On Fri, Sep 26, 2014 at 09:28:41AM +, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
v2:
merged in Paolo's suggestion to reduce indentation in patch
---
hw/core/qdev.c | 61
--
1 file changed, 34
Did this get stuck?
Gal Hammer gham...@redhat.com writes:
Hi,
A two parts patch to add a QEmu support for Microsoft's Virtual Machine
Generation ID device.
The first one add a new ACPI directive which allow to use a 16-bytes
buffer in an ACPI table. This buffer is for storing the VM's
On Fri, Sep 26, 2014 at 01:59:40PM -0600, Alex Williamson wrote:
On Fri, 2014-09-26 at 08:45 +0200, Frank Blaschka wrote:
On Wed, Sep 24, 2014 at 10:05:57AM -0600, Alex Williamson wrote:
On Wed, 2014-09-24 at 10:47 +0200, Frank Blaschka wrote:
On Mon, Sep 22, 2014 at 02:47:31PM -0600,
Hi,
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
arei.gong...@huawei.com writes:
From: Gonglei arei.gong...@huawei.com
It will cause that create vm failed When manager
tool is killed forcibly (kill -9 libvirtd_pid),
the file not was
On Wed, 1 Oct 2014, Slutz, Donald Christopher wrote:
On 09/30/14 06:35, Stefano Stabellini wrote:
On Mon, 29 Sep 2014, Don Slutz wrote:
On 09/29/14 06:25, Stefano Stabellini wrote:
On Mon, 29 Sep 2014, Stefano Stabellini wrote:
On Fri, 26 Sep 2014, Don Slutz wrote:
This adds
Thanks a lot for reviewing this patch.
Since the code is not trivial I will give my arguments for writing it
this way.
+/* block recursively a BDS
+ *
+ * If base != NULL the caller must make sure that there is no multiple
child
+ * BDS in the subtree pointed to by bs
In the case
On Wed, 1 Oct 2014 14:27:19 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Fri, Sep 26, 2014 at 09:28:41AM +, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
v2:
merged in Paolo's suggestion to reduce indentation in patch
---
hw/core/qdev.c
Gonglei arei.gong...@hotmail.com writes:
Hi,
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
arei.gong...@huawei.com writes:
From: Gonglei arei.gong...@huawei.com
It will cause that create vm failed When manager
tool is killed forcibly
On Wed, Oct 01, 2014 at 11:57:37AM +0200, Igor Mammedov wrote:
On Wed, 1 Oct 2014 14:27:19 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Fri, Sep 26, 2014 at 09:28:41AM +, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
---
v2:
merged in
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
Gonglei arei.gong...@hotmail.com writes:
Hi,
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
arei.gong...@huawei.com writes:
From: Gonglei
On 10/01/14 05:20, Stefano Stabellini wrote:
On Wed, 1 Oct 2014, Slutz, Donald Christopher wrote:
On 09/30/14 06:35, Stefano Stabellini wrote:
On Mon, 29 Sep 2014, Don Slutz wrote:
On 09/29/14 06:25, Stefano Stabellini wrote:
On Mon, 29 Sep 2014, Stefano Stabellini wrote:
On Fri, 26 Sep
Markus Armbruster arm...@redhat.com writes:
IDs have long spread beyond QemuOpts: not everything with an ID
necessarily goes through QemuOpts. Commit 9aebf3b is about such a
case: block layer names are meant to be well-formed IDs, but some of
them don't go through QemuOpts, and thus weren't
I haven't heard anything about these patches. Is there anything I need
to do to get them included?
Thanks,
-corey
On 09/25/2014 03:07 PM, miny...@acm.org wrote:
From: Corey Minyard cminy...@mvista.com
Adds a reconnect option to socket backends that gives a reconnect
timeout. This only
Gonglei arei.gong...@hotmail.com writes:
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
Gonglei arei.gong...@hotmail.com writes:
Hi,
Subject: Re: [Qemu-devel] [PATCH 2/4] os-posix: report error message when
lock file failed
On Wed, 1 Oct 2014 16:22:23 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Wed, Oct 01, 2014 at 11:57:37AM +0200, Igor Mammedov wrote:
On Wed, 1 Oct 2014 14:27:19 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Fri, Sep 26, 2014 at 09:28:41AM +, Igor Mammedov
Am 01.10.2014 um 14:43 schrieb Igor Mammedov:
On Wed, 1 Oct 2014 16:22:23 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Wed, Oct 01, 2014 at 11:57:37AM +0200, Igor Mammedov wrote:
On Wed, 1 Oct 2014 14:27:19 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Fri, Sep 26,
Yeah, that would be cleaner, I'll fix it in the next version.
On 30 September 2014 17:50, Edgar E. Iglesias edgar.igles...@gmail.com
wrote:
On Tue, Sep 30, 2014 at 04:49:14PM -0500, Greg Bellows wrote:
From: Fabian Aggeler aggel...@ethz.ch
arm_is_secure() function allows to determine CPU
Yes. Done for next version.
On 30 September 2014 17:56, Edgar E. Iglesias edgar.igles...@gmail.com
wrote:
On Tue, Sep 30, 2014 at 04:49:16PM -0500, Greg Bellows wrote:
Renamed the arm_current_pl CPU function to more accurately represent
that it
returns the ARMv8 EL rather than ARMv7 PL.
Thanks Edgar.
I'm okay with array notation (I think we agreed to that) as long as we are
okay with the extra padding which should be minor.
I will update the few fields that can and should be arrays.
Greg
On 30 September 2014 18:18, Edgar E. Iglesias edgar.igles...@gmail.com
wrote:
On Tue,
On Wed, 01 Oct 2014 14:46:03 +0200
Andreas Färber afaer...@suse.de wrote:
Am 01.10.2014 um 14:43 schrieb Igor Mammedov:
On Wed, 1 Oct 2014 16:22:23 +0530
Bharata B Rao bhar...@linux.vnet.ibm.com wrote:
On Wed, Oct 01, 2014 at 11:57:37AM +0200, Igor Mammedov wrote:
On Wed, 1 Oct 2014
Hi,
Applied to linux-user tree, I'll send a pull req after a bit of
testing.
Riku
On Tue, Sep 30, 2014 at 05:58:43PM +0400, Mikhail Ilin wrote:
ping
http://patchwork.ozlabs.org/patch/386918/
On 22.09.2014 13:04, Mikhail Ilin wrote:
ping
http://patchwork.ozlabs.org/patch/386918/
On
Hi,
I'm looking into creating a virtualised test bed for an 802.15.4 network.
Currently I have QEMU running and emulating our HW which bridges the Ethernet
from the guest to the host. What I would like to do is something similar with
the 802.15.4 network interface. The host doesn't have a
Hi Gerd,
i have another issue. This time with the hid keyboard rework (commit
1ff5eedd). Before this commit, a press of, for example the windows key,
resulted in two calls of the hs-event() callback. Eg. there were two
events queued and two callbacks. But after your commit, two events are
On Wed, 2014-10-01 at 07:26 +0200, Knut Omang wrote:
On Tue, 2014-09-30 at 21:38 +0800, Gonglei wrote:
Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari
capability of
pcie devices
On Tue, Sep 30, 2014 at 06:11:25PM +0800, arei.gong...@huawei.com wrote:
From:
When running a virtual machine, you eventually want to shut it down and see it
properly end the QEMU process. The magic that makes this work is the power off
code path that a guest OS uses to indicate that it wants to power off the host
machine.
This logic was missing from our e500 virt machine.
On e500 systems most SoCs implement a common GPIO controller that Linux
calls the mpc8xxx gpio controller. This patch adds an emulation model
for this device.
Signed-off-by: Alexander Graf ag...@suse.de
---
hw/gpio/Makefile.objs | 1 +
hw/gpio/mpc8xxx.c | 217
With the e500 virt machine, we don't have to adhere to the exact hardware
layout of an mpc8544ds board. So there we can just add a qoriq compatible
GPIO controller into the system that we can add a power off hook to.
Signed-off-by: Alexander Graf ag...@suse.de
---
hw/ppc/e500.c | 32
Hi,
My input device model (milkymist-softusb.c) polls (hid_keyboard_poll())
exactly once per event callback. Actually, i don't see any other way to
do it because the hid_keyboard_poll() always succeeds even if there is
no event in the queue.
You can use hid_has_events() to figure
Now that we have a working GPIO controller on the virt machine, we can use
one pin to notify QEMU that the guests wants to power off the system.
Signed-off-by: Alexander Graf ag...@suse.de
---
hw/ppc/e500.c | 24
1 file changed, 24 insertions(+)
diff --git
Am 2014-10-01 16:17, schrieb Gerd Hoffmann:
Hi,
My input device model (milkymist-softusb.c) polls
(hid_keyboard_poll())
exactly once per event callback. Actually, i don't see any other way
to
do it because the hid_keyboard_poll() always succeeds even if there is
no event in the queue.
You
On 01.10.14 00:08, Michael Roth wrote:
Quoting Alexander Graf (2014-08-26 06:36:57)
On 19.08.14 02:21, Michael Roth wrote:
From: Mike Day ncm...@ncultra.org
Signed-off-by: Mike Day ncm...@ncultra.org
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
hw/ppc/spapr_pci.c | 119
I have fixed-up some of the bank definitions and names so they more
accurately match the ARMv8 mappings. In next version.
On 30 September 2014 16:49, Greg Bellows greg.bell...@linaro.org wrote:
From: Fabian Aggeler aggel...@ethz.ch
When EL3 is running in Aarch32 (or ARMv7 with Security
Yes, good catch. Fixed in next version.
On 30 September 2014 20:23, Sergey Fedorov serge.f...@gmail.com wrote:
On 30.09.2014 14:49, Greg Bellows wrote:
From: Fabian Aggeler aggel...@ethz.ch
Make arm_current_pl() return PL3 for secure PL1 and monitor mode.
Increase MMU modes since
On Wed, 2014-10-01 at 10:20 +0100, Stefano Stabellini wrote:
I wonder if we could send both ioreqs at once from Xen and back from
QEMU. Or maybe append the registers to IOREQ_TYPE_VMWARE_PORT, changing
the size of ioreq_t only for this ioreq type.
Random idea: Why new add a
On 14.09.14 21:38, Peter Maydell wrote:
The MemoryRegionOps struct pci4xx_cfgaddr_ops and the read and
write functions it references are all unused; remove them.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Thanks, applied to ppc-next.
Alex
On 26.09.14 11:07, Bharata B Rao wrote:
g_free() in target-ppc/translate_init.c:ppc_cpu_unrealizefn() can fail
due to invalid pointer being passed to it. Fix this along with a cleanup.
I have never seen ppc_cpu_unrealizefn() getting called for sPAPR guests,
but I ran into this issue when I
-Original Message-
From: qemu-devel-bounces+paul.durrant=citrix@nongnu.org
[mailto:qemu-devel-bounces+paul.durrant=citrix@nongnu.org] On
Behalf Of Stefano Stabellini
Sent: 01 October 2014 10:20
To: Slutz, Donald Christopher
Cc: xen-de...@lists.xensource.com; Stefano
On Wed, Oct 01, 2014 at 09:29:44AM +, Benoît Canet wrote:
Thanks a lot for reviewing this patch.
Since the code is not trivial I will give my arguments for writing it
this way.
Thanks, that is very helpful.
+/* block recursively a BDS
+ *
+ * If base != NULL the caller
On 30.09.2014 21:25, Markus Armbruster wrote:
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single abstraction BlockDriverState both for tree
nodes
On 30.09.2014 21:25, Markus Armbruster wrote:
Convenience function blk_new_with_bs() creates a BlockBackend with its
BlockDriverState. Callers have to unref both. The commit after next
will relieve them of the need to unref the BlockDriverState.
Complication: due to the silly way drive_del
Hi All,
I noticed that it's quite difficult to get target-mips changes
reviewed/accepted. There is already a queue of relatively big features
and bug fixes which are stuck for months. Does anyone have an idea how
to improve this situation? Wouldn't it help to have a target-mips
co-maintainer
The main purpose of this is mirror.c and commit.c would form BDS loops on
completion.
These callers could break the look manually but the code would fail
if a loop is not breaked and the blocker function are called on it.
So the blocker code have to handle recursion loops.
I think
On 10/01/2014 02:35 AM, Bastian Koppelmann wrote:
Add instructions of ABS, ABSB opcode format.
Add microcode generator functions for ld/st of two 32bit reg as one 64bit
value.
Add microcode generator functions for ldmst and swap.
Add helper ldlcx, lducx, stlcx and stucx.
Signed-off-by:
On 10/01/2014 02:35 AM, Bastian Koppelmann wrote:
+case OPC2_32_BIT_AND_NOR_T:
+#if defined TCG_TARGET_HAS_nor_i32
+gen_bit_2op(cpu_gpr_d[r3], cpu_gpr_d[r1], cpu_gpr_d[r2],
+pos1, pos2, tcg_gen_nor_tl, tcg_gen_and_tl);
+#else
These are *always* defined. You
On 30.09.2014 21:25, Markus Armbruster wrote:
Make the BlockBackend own the DriveInfo. Change blockdev_init() to
return the BlockBackend instead of the DriveInfo.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 2 --
block/block-backend.c | 38
On 10/01/2014 02:35 AM, Bastian Koppelmann wrote:
+case OPC2_32_BO_ST_A_PREINC:
+tcg_gen_addi_tl(cpu_gpr_a[r2], cpu_gpr_a[r2], off10);
+tcg_gen_qemu_st_tl(cpu_gpr_a[r1], cpu_gpr_a[r2], ctx-mem_idx,
+ MO_LESL);
+break;
The writeback to
On Wed, Oct 1, 2014 at 7:44 AM, Ian Campbell ian.campb...@citrix.com wrote:
On Wed, 2014-10-01 at 10:20 +0100, Stefano Stabellini wrote:
I wonder if we could send both ioreqs at once from Xen and back from
QEMU. Or maybe append the registers to IOREQ_TYPE_VMWARE_PORT, changing
the size of
On Wed, Oct 01, 2014 at 12:17:50AM +0200, Paolo Bonzini wrote:
Il 30/09/2014 20:26, Eduardo Habkost ha scritto:
Other test code will use the function.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
tests/Makefile | 1 +
tests/coroutine-stub.c | 13 +
On 30.09.2014 21:25, Markus Armbruster wrote:
device_name[] can become non-empty only in bdrv_new_root() and
bdrv_move_feature_fields(). The latter is used only to undo damage
done by bdrv_swap(). The former is called only by blk_new_with_bs().
Therefore, when a BlockDriverState's
On 30.09.2014 21:25, Markus Armbruster wrote:
BlockBackend's name space is separate only to keep the initial patches
simple. Time to merge the two.
Retain bdrv_find() and bdrv_get_device_name() for now, to keep this
series manageable.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
On Wed, Oct 01, 2014 at 12:20:18AM +0200, Paolo Bonzini wrote:
Il 30/09/2014 20:26, Eduardo Habkost ha scritto:
Reasoning for each object file included in the test binary:
* qom/cpu.o - for TYPE_CPU. Dependencies:
* qom/qom-qobject.o
* qom/qdev.o - for TYPE_DEVICE. Dependencies:
On 1 October 2014 16:35, Leon Alrae leon.al...@imgtec.com wrote:
I noticed that it's quite difficult to get target-mips changes
reviewed/accepted. There is already a queue of relatively big features
and bug fixes which are stuck for months. Does anyone have an idea how
to improve this
* Peter Lieven (p...@kamp.de) wrote:
regular bitmap_new simply aborts if the memory allocation fails.
bitmap_try_new returns NULL on failure and allows for proper
error handling.
Signed-off-by: Peter Lieven p...@kamp.de
---
include/qemu/bitmap.h | 13 +++--
1 file changed, 11
Hi Leon,
Am 01.10.2014 um 17:35 schrieb Leon Alrae:
I noticed that it's quite difficult to get target-mips changes
reviewed/accepted. There is already a queue of relatively big features
and bug fixes which are stuck for months. Does anyone have an idea how
to improve this situation? Wouldn't
Hi Martin,
On 10/01/2014 09:50 AM, Martin Townsend wrote:
Hi,
I'm looking into creating a virtualised test bed for an 802.15.4 network.
Currently I have QEMU running and emulating our HW which bridges the
Ethernet from the guest to the host. What I would like to do is something
similar
Commit 1f9296b avoids other kinds of overflow by limiting the
polling interval to UINT_MAX. The computations to protect are done in
64 bits. This is indeed safe when unsigned is 32 bits, as it commonly
is. It isn't when unsigned is 64 bits. Purely theoretical; I'm not
aware of such a system.
On 10/01/2014 10:43 AM, Markus Armbruster wrote:
Commit 1f9296b avoids other kinds of overflow by limiting the
polling interval to UINT_MAX. The computations to protect are done in
64 bits. This is indeed safe when unsigned is 32 bits, as it commonly
is. It isn't when unsigned is 64 bits.
On 30.09.2014 21:25, Markus Armbruster wrote:
I'll use BlockDriverAIOCB with block backends shortly, and the name is
going to fit badly there. It's a block layer thing anyway, not just a
block driver thing.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block-migration.c |
On 30.09.2014 21:25, Markus Armbruster wrote:
I'll use it with block backends shortly, and the name is going to fit
badly there. It's a block layer thing anyway, not just a block driver
thing.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 30
Almost all the infrastructure is in place to make blockjobs safe for use with
dataplane:
* Op blockers all us to exclude commands that could conflict with a blockjob
or dataplane.
* AioContext acquire/release allows threads to temporarily access a
BlockDriverState that is running in
Make sure that query-block-jobs acquires the BlockDriverState
AioContext so that the blockjob isn't running in another thread while we
access its state.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
blockdev.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
Block jobs will run in the BlockDriverState's AioContext, which may not
always be the QEMU main loop.
There are some block layer APIs that are either not thread-safe or risk
lock ordering problems. This includes bdrv_unref(), bdrv_close(), and
anything that calls bdrv_drain_all().
The
block-job-set-speed, block-job-cancel, block-job-pause,
block-job-resume, and block-job-complete must acquire the
BlockDriverState AioContext so that it is safe to access bs.
At the moment bs-job is always NULL when dataplane is active because op
blockers prevent blockjobs from starting. Once
The stream block job must run in the BlockDriverState AioContext so that
it works with dataplane.
The basics of acquiring the AioContext are easy in blockdev.c.
The tricky part is the completion code which drops part of the backing
file chain. This must be done in the main loop where
When an emulated storage controller is unrealized it will call
blockdev_mark_auto_del(). This will cancel any running block job (and
that eventually releases its reference to the BDS so it can be freed).
Since the block job may be executing in another AioContext we must
acquire/release to ensure
Now that op blockers are in use, we can ensure that no other sources are
generating I/O on a BlockDriverState. Therefore it is possible to drain
requests for a single BDS.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c | 36 +---
Now that blockjobs use AioContext they are safe for use with dataplane.
Unblock them!
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
blockjob.c | 1 +
hw/block/dataplane/virtio-blk.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/blockjob.c b/blockjob.c
The mirror block job must run in the BlockDriverState AioContext so that
it works with dataplane.
Acquire the AioContext in blockdev.c so starting the block job is safe.
Note that to_replace is treated separately from other BlockDriverStates
in that it does not need to be in the same AioContext.
The backup block job must run in the BlockDriverState AioContext so that
it works with dataplane.
The basics of acquiring the AioContext are easy in blockdev.c.
The completion code in block/backup.c must call bdrv_unref() from the
main loop. Use block_job_defer_to_main_loop() to achieve that.
The commit block job must run in the BlockDriverState AioContext so that
it works with dataplane.
Acquire the AioContext in blockdev.c so starting the block job is safe.
One detail here is that the bdrv_drain_all() must be moved inside the
aio_context_acquire() region so requests cannot sneak in
On 30.09.2014 21:25, Markus Armbruster wrote:
Device models should access their block backends only through the
block-backend.h API. Convert them, and drop direct includes of
inappropriate headers.
Just four uses of BlockDriverState are left:
* The Xen paravirtual block device backend
On 30.09.2014 21:25, Markus Armbruster wrote:
blockdev_init() always creates a DriveInfo, but only drive_new() fills
it in. qmp_blockdev_add() leaves it blank. This results in a drive
with type = IF_IDE, bus = 0, unit = 0. Screwed up in commit ee13ed1c.
Board initialization code looking for
On 30.09.2014 21:25, Markus Armbruster wrote:
Doesn't make a difference just yet, but it's the right thing to do.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Reviewed-by: Kevin Wolf kw...@redhat.com
---
block/block-backend.c | 2 ++
On Wed, 2014-10-01 at 11:11 +0200, Frank Blaschka wrote:
On Fri, Sep 26, 2014 at 01:59:40PM -0600, Alex Williamson wrote:
On Fri, 2014-09-26 at 08:45 +0200, Frank Blaschka wrote:
On Wed, Sep 24, 2014 at 10:05:57AM -0600, Alex Williamson wrote:
On Wed, 2014-09-24 at 10:47 +0200, Frank
Quoting Kenth Andersson (2014-09-29 13:22:54)
Implementation of guest-network-get-interfaces for windows
Signed-off-by: Kenth Andersson ke...@eastmark.net
Thanks! I've been testing the functionality and it seems work nicely. Some
review comments below though:
---
configure|
The person who created qemu-file.c (me, on commit
093c455a8c6d8f715eabd8c8d346f08f17d686ec) didn't add a copyright/license
header to the file, even though the whole code was copied from savevm.c
(which had a copyright/license header).
To correct this, copy the copyright information and license
Quoting zhanghailiang (2014-09-18 22:09:10)
If readdir_r fails, error_setg_errno will reference the freed
pointer *dirpath*.
Moreover, readdir_r may cause a buffer overflow, using readdir instead.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Thanks, applied to qga tree:
* Eduardo Habkost (ehabk...@redhat.com) wrote:
The person who created qemu-file.c (me, on commit
093c455a8c6d8f715eabd8c8d346f08f17d686ec) didn't add a copyright/license
header to the file, even though the whole code was copied from savevm.c
(which had a copyright/license header).
To
Il 01/10/2014 14:38, Corey Minyard ha scritto:
I haven't heard anything about these patches. Is there anything I need
to do to get them included?
Nothing, I just missed them in the huge traffic of qemu-devel. Will
look at them tomorrow.
Thanks for pinging them.
Paolo
Il 01/10/2014 18:28, Eduardo Habkost ha scritto:
tests/x86-stub.c perhaps can be moved to target-i386/test-stubs.c?
I was trying to keep all test code inside tests/. But perhaps all the
target-specific test code (including test-x86-cpu.c) could be moved to
target directories, and we could
The Q35 board initialization does not currently bother to look
for any drives added by the various syntactical sugar shorthands
to be added to the AHCI HBA. These include -hda through -hdd,
-cdrom, and -drive if=ide shorthands.
An obstacle to having implemented this sooner is debate over
whether
Instead of duplicating the logic for the if_ide
(bus,unit) mappings, rely on the blockdev layer
for managing those mappings for us, and use the
drive_get_by_index call instead.
This allows ide_drive_get to work for AHCI HBAs
as well, and can be used in the Q35 initialization.
Lastly, change the
This patch implements the backend for the Q35 board
for us to be able to pick up and use drives defined
by the -cdrom, -hda, or -drive if=ide shorthand options.
Signed-off-by: John Snow js...@redhat.com
---
hw/i386/pc_q35.c | 4
hw/ide/ahci.c| 15 +++
hw/ide/ahci.h| 2
This patch adds the 'units_per_default_bus' property which
allows individual boards to declare their desired
index = (bus,unit) mapping for their default HBA, so that
boards such as Q35 can specify that its default if_ide HBA,
AHCI, only accepts one unit per bus.
This property only overrides the
The if_max_devs table as in the past been an immutable
default that controls the mapping of index = (bus,unit)
for all boards and all HBAs for each interface type.
Since adding this mapping information to the HBA device
itself is currently unwieldly from the perspective of
retrieving this
If the Q35 board types are to begin recognizing
and decoding syntactic sugar for drive/device
declarations, then workarounds found within
the qtests suite need to be adjusted to prevent
any test failures after the fix.
bios-tables-test improperly uses this cli:
-drive file=etc,id=hd -device
When users use command line options like -hda, -cdrom,
or even -drive if=ide, it is up to the board initialization
routines to pick up these drives and create backing
devices for them.
Some boards, like Q35, have not been doing this.
However, there is no warning explaining why certain
drive
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
block-job-set-speed, block-job-cancel, block-job-pause,
block-job-resume, and block-job-complete must acquire the
BlockDriverState AioContext so that it is safe to access bs.
At the moment bs-job is always NULL when dataplane is active because op
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
Make sure that query-block-jobs acquires the BlockDriverState
AioContext so that the blockjob isn't running in another thread while we
access its state.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
blockdev.c | 9 +++--
1 file
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
When an emulated storage controller is unrealized it will call
blockdev_mark_auto_del(). This will cancel any running block job (and
that eventually releases its reference to the BDS so it can be freed).
Since the block job may be executing in
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
This function is correct but we should document the constraint that
everything must be thread-safe.
Emitting QMP events and scheduling BHs are both thread-safe so nothing
needs to be done here.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
Block jobs will run in the BlockDriverState's AioContext, which may not
always be the QEMU main loop.
There are some block layer APIs that are either not thread-safe or risk
lock ordering problems. This includes bdrv_unref(), bdrv_close(), and
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
Now that op blockers are in use, we can ensure that no other sources are
generating I/O on a BlockDriverState. Therefore it is possible to drain
requests for a single BDS.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c
On 01.10.2014 19:01, Stefan Hajnoczi wrote:
The backup block job must run in the BlockDriverState AioContext so that
it works with dataplane.
The basics of acquiring the AioContext are easy in blockdev.c.
The completion code in block/backup.c must call bdrv_unref() from the
main loop. Use
On 09/25/2014 02:07 PM, miny...@acm.org wrote:
From: Corey Minyard cminy...@mvista.com
Adds a reconnect option to socket backends that gives a reconnect
timeout. This only applies to client sockets. If the other end
of a socket closes the connection, qemu will attempt to reconnect
after
Hi,
On Fri, Sep 05, 2014 at 03:26:09PM +0200, Wouter Verhelst wrote:
Tunneling the entire protocol inside an SSL connection doesn't fix that;
if an attacker is able to hijack your TCP connections and change flags,
then this attacker is also able to hijack your TCP connection and
redirect it
Use the existing function which checks if writev_buffer() or
put_buffer() are set, instead of duplicating it.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
qemu-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-file.c b/qemu-file.c
index 6c8a6c9..482bda6
1 - 100 of 112 matches
Mail list logo
