Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-04-10 Thread Chen Gang
On 4/11/15 05:51, Peter Maydell wrote: On 10 April 2015 at 21:41, Chen Gang xili_gchen_5...@hotmail.com wrote: On 4/10/15 05:31, Peter Maydell wrote: On 27 March 2015 at 10:49, Chen Gang xili_gchen_5...@hotmail.com wrote: +typedef struct target_sigaltstack { +abi_ulong ss_sp; +

[Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-10 Thread Andreas Färber
Hi, 001 seems to hang for -qcow (or is not reasonably quick: 5 min). 033 is failing for -vhdx. (Note that `make check-block` only tests -qcow2, so didn't uncover either of them.) Given a failing test, am I seeing correctly that there is no command line option to skip this one failing test? -x

Re: [Qemu-devel] virtio-net regression [was: syslinux vs. OVMF]

2015-04-10 Thread Laszlo Ersek
On 04/10/15 16:36, Laszlo Ersek wrote: Anyway I think we can rule out any qemu regression at this point. It's a bug in some other component that the different memory map (due to the larger, 0x2 allocation) exposes. It was an iPXE issue:

Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

2015-04-10 Thread Chen Gang
Firstly, thank you very much for your patient work for all related patches. And I shall try to send patch v10 within this month, and let linux-user run Hello world completely (finish emulate a demo executable binary successfully). The related reply is below: On 4/10/15 05:21, Peter Maydell

[Qemu-devel] [PATCH v4] target-i386: Register QOM properties for feature flags

2015-04-10 Thread Eduardo Habkost
This uses the feature name arrays to register QOM properties for feature flags. This simply adds properties that can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Changes v1 - v2: * Use cpuid-

[Qemu-devel] [PATCH v6 38/36] qapi: Check for member name conflicts with a base class

2015-04-10 Thread Eric Blake
Our type inheritance for both 'struct' and for flat 'union' merges key/value pairs from the base class with those from the type in question. Although the C code currently boxes things so that there is a distinction between which member is referred to, the QMP wire format does not allow passing a

[Qemu-devel] [PATCH v6 37/36] qapi: Support (subset of) \u escapes in strings

2015-04-10 Thread Eric Blake
The handling of \ inside QAPI strings was less than ideal, and really only worked JSON's \/, \\, \, and our extension of \' (an obvious extension, when you realize we use '' instead of for strings). For other things, like '\n', it resulted in a literal 'n' instead of a newline. Of course, at

Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-04-10 Thread Chen Gang
On 4/10/15 05:31, Peter Maydell wrote: On 27 March 2015 at 10:49, Chen Gang xili_gchen_5...@hotmail.com wrote: [...] +static inline void cpu_clone_regs(CPUTLGState *env, target_ulong newsp) +{ +if (newsp) { +env-regs[TILEGX_R_SP] = newsp; +} +env-regs[TILEGX_R_RE] = 0;

Re: [Qemu-devel] [PATCH 03/12 v9] linux-user: Support tilegx architecture in syscall

2015-04-10 Thread Chen Gang
On 4/10/15 05:38, Peter Maydell wrote: On 27 March 2015 at 10:50, Chen Gang xili_gchen_5...@hotmail.com wrote: [...] +#elif defined(TARGET_TILEGX) + +/* Copy from Linux kernel uapi/asm-generic/stat.h */ +struct target_stat { +abi_ulong st_dev; /* Device. */ +

Re: [Qemu-devel] [PATCH 04/12 v9] linux-user: Support tilegx architecture in linux-user

2015-04-10 Thread Chen Gang
On 4/10/15 05:44, Peter Maydell wrote: On 27 March 2015 at 10:52, Chen Gang xili_gchen_5...@hotmail.com wrote: [...] + +#define ELF_CLASS ELFCLASS64 +#define ELF_DATAELFDATA2LSB +#define ELF_ARCHEM_TILEGX + +static inline void init_thread(struct target_pt_regs *regs, +

Re: [Qemu-devel] [PATCH 05/12 v9] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-04-10 Thread Chen Gang
On 4/10/15 05:46, Peter Maydell wrote: On 27 March 2015 at 10:53, Chen Gang xili_gchen_5...@hotmail.com wrote: For tilegx, several syscall macros are not supported, so switch them to avoid building break. Signed-off-by: Chen Gang gang.chen.5...@gmail.com +#ifdef TARGET_NR_getpgrp

[Qemu-devel] [PATCH] qapi: Drop dead genlist parameter

2015-04-10 Thread Eric Blake
Defaulting a parameter to True, then having all callers omit or pass an explicit True for that parameter, is pointless. Looks like it has been dead since introduction in commit 06d64c6. Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-visit.py | 36

Re: [Qemu-devel] [PATCH 06/12 v9] target-tilegx: Add cpu basic features for linux-user

2015-04-10 Thread Chen Gang
On 4/10/15 05:55, Peter Maydell wrote: On 27 March 2015 at 10:54, Chen Gang xili_gchen_5...@hotmail.com wrote: It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- target-tilegx/cpu-qom.h | 73

Re: [Qemu-devel] [PATCH] qapi: Drop dead genlist parameter

2015-04-10 Thread Eric Blake
On 04/10/2015 02:59 PM, Eric Blake wrote: Defaulting a parameter to True, then having all callers omit or pass an explicit True for that parameter, is pointless. Looks like it has been dead since introduction in commit 06d64c6. Signed-off-by: Eric Blake ebl...@redhat.com ---

Re: [Qemu-devel] [PATCH 08/12 v9] target-tilegx: Add opcode basic implementation for tilegx

2015-04-10 Thread Chen Gang
On 4/10/15 06:03, Peter Maydell wrote: On 27 March 2015 at 10:56, Chen Gang xili_gchen_5...@hotmail.com wrote: It is from Tilera Corporation, and copied from Linux kernel arch/tile/ include/uapi/arch/opcode_tilegx.h. Signed-off-by: Chen Gang gang.chen.5...@gmail.com It's good to have this

[Qemu-devel] [PATCH v2] qapi: Drop dead genlist parameter

2015-04-10 Thread Eric Blake
Defaulting a parameter to True, then having all callers omit or pass an explicit True for that parameter, is pointless. Looks like it has been dead since introduction in commit 06d64c6, more than 4 years ago. Signed-off-by: Eric Blake ebl...@redhat.com --- v2: tweak commit message, don't depend

Re: [Qemu-devel] [PATCH 09/12 v9] target-tilegx: Finish processing bundle and preparing decoding pipes

2015-04-10 Thread Chen Gang
On 4/10/15 06:08, Peter Maydell wrote: On 27 March 2015 at 10:57, Chen Gang xili_gchen_5...@hotmail.com wrote: Finish processing tilegx bundle, and reach to related pipes. +qemu_log_mask(LOG_UNIMP, + UNIMP y0, opcode %d, bundle [ FMT64X ]\n, +

Re: [Qemu-devel] [PATCH 10/12 v9] target-tilegx: Add TILE-Gx building files

2015-04-10 Thread Chen Gang
On 4/10/15 06:10, Peter Maydell wrote: On 27 March 2015 at 11:00, Chen Gang xili_gchen_5...@hotmail.com wrote: [...] ;; + tilegx) +TARGET_ARCH=tilegx + ;; TARGET_ARCH already defaults to the target name, so you don't need to set it again unless it's different. You can just have

Re: [Qemu-devel] [PATCH 12/12 v9] target-tilegx: Generate tcg instructions to execute to 1st system call

2015-04-10 Thread Chen Gang
On 4/10/15 06:19, Peter Maydell wrote: On 27 March 2015 at 11:07, Chen Gang xili_gchen_5...@hotmail.com wrote: [...] +static void gen_fnop(void) +{ +qemu_log_mask(CPU_LOG_TB_IN_ASM, (f)nop\n); I really don't much like mixing a fake disassembler in with the translator. If you want a

Re: [Qemu-devel] make test fails on Mac OS X

2015-04-10 Thread Peter Maydell
On 10 April 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: The 'make test' command fails to build on Mac OS X. This is because of a missing header file. Here is the error: include/glib-compat.h:19:18: fatal error: glib.h: No such file or directory #include glib.h make test

Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

2015-04-10 Thread Peter Maydell
On 10 April 2015 at 21:01, Chen Gang xili_gchen_5...@hotmail.com wrote: Firstly, thank you very much for your patient work for all related patches. And I shall try to send patch v10 within this month, and let linux-user run Hello world completely (finish emulate a demo executable binary

Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-04-10 Thread Peter Maydell
On 10 April 2015 at 21:41, Chen Gang xili_gchen_5...@hotmail.com wrote: On 4/10/15 05:31, Peter Maydell wrote: On 27 March 2015 at 10:49, Chen Gang xili_gchen_5...@hotmail.com wrote: +typedef struct target_sigaltstack { +abi_ulong ss_sp; +abi_ulong ss_size; +abi_long ss_flags;

Re: [Qemu-devel] [PATCH 12/12 v9] target-tilegx: Generate tcg instructions to execute to 1st system call

2015-04-10 Thread Peter Maydell
On 10 April 2015 at 22:28, Chen Gang xili_gchen_5...@hotmail.com wrote: On 4/10/15 06:19, Peter Maydell wrote: On 27 March 2015 at 11:07, Chen Gang xili_gchen_5...@hotmail.com wrote: +/* + * The related functional description for bfextu in isa document: + * + * uint64_t mask = 0; + * mask =

Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-04-10 Thread Andreas Färber
Am 10.04.2015 um 23:51 schrieb Peter Maydell: On 10 April 2015 at 21:41, Chen Gang xili_gchen_5...@hotmail.com wrote: On 4/10/15 05:31, Peter Maydell wrote: On 27 March 2015 at 10:49, Chen Gang xili_gchen_5...@hotmail.com wrote: +typedef struct target_sigaltstack { +abi_ulong ss_sp; +

Re: [Qemu-devel] [PATCH RFC 03/19] qapi: Rename _generate_enum_string() to camel_to_upper()

2015-04-10 Thread Eric Blake
On 04/02/2015 11:28 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/qapi.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-04-10 Thread Peter Maydell
On 10 April 2015 at 22:59, Andreas Färber afaer...@suse.de wrote: I know linux-user is a mess. But that does not sound appealing. If this is from a generic header, can't we put that in a shared header too and #include it from aarch64 and tilegx without duplicating it? I certainly wouldn't

Re: [Qemu-devel] seccomp breakage on arm

2015-04-10 Thread Paul Moore
On Friday, April 10, 2015 05:40:40 PM Andreas Färber wrote: My main concern - that you apparently misunderstood - was whether this is a QEMU or a libseccomp issue. If it's on libseccomp's side then it's less urgent for QEMU and any new configure checks are just candy IMO. My opinion is that

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-04-10 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: Caution, rough edges. qapi/introspect.json defines the introspection schema. It should do for uses other than QMP. That is, QGA should also be able to reuse it for introspection. FIXME it's almost entirely devoid of comments. Yeah, but

Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

2015-04-10 Thread Chen Gang
On 4/11/15 05:38, Peter Maydell wrote: On 10 April 2015 at 21:01, Chen Gang xili_gchen_5...@hotmail.com wrote: Firstly, thank you very much for your patient work for all related patches. And I shall try to send patch v10 within this month, and let linux-user run Hello world completely

Re: [Qemu-devel] [PATCH 3/7] ipxe: add local patches

2015-04-10 Thread Andreas Färber
Am 10.04.2015 um 16:17 schrieb Gerd Hoffmann: There are two ipxe patches needed to make efi pxe boots work. They didn't made it upstream yet, and I don't want to wait any longer with updating qemu. So add them here, with some logic to apply them before building ipxe. /me still hopes I can

Re: [Qemu-devel] [PATCH 12/12 v9] target-tilegx: Generate tcg instructions to execute to 1st system call

2015-04-10 Thread Chen Gang
On 4/11/15 05:56, Peter Maydell wrote: On 10 April 2015 at 22:28, Chen Gang xili_gchen_5...@hotmail.com wrote: On 4/10/15 06:19, Peter Maydell wrote: On 27 March 2015 at 11:07, Chen Gang xili_gchen_5...@hotmail.com wrote: +/* + * The related functional description for bfextu in isa document: