Re: [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT

2015-06-29 Thread Richard Henderson
On 06/21/2015 05:51 PM, Aurelien Jarno wrote: A break is missing in the EXECUTE instruction, when executing the TRANSLATE AND TEST instruction. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Aurelien Jarno aurel...@aurel32.net Cc: Alexander Graf ag...@suse.de Cc: Richard

Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

2015-06-29 Thread Richard Henderson
On 06/25/2015 08:16 PM, Aurelien Jarno wrote: for (shift = 4; (shift 64) bin; shift += 4) { -int current_number = bin % 10; - -dec |= (current_number) shift; +dec |= (bin % 10) shift; bin /= 10; } You've changed from 32-bit division to 64-bit

Re: [Qemu-devel] [PATCH 4/5] net/dump: Add dump option for netdev devices

2015-06-29 Thread Thomas Huth
On Fri, 26 Jun 2015 10:44:59 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jun 24, 2015 at 05:56:20PM +0200, Thomas Huth wrote: diff --git a/net/net.c b/net/net.c index cc36c7b..8871b77 100644 --- a/net/net.c +++ b/net/net.c @@ -568,6 +568,12 @@ ssize_t

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-06-29 Thread Michael S. Tsirkin
On Mon, Jun 29, 2015 at 05:24:53PM +0800, Hong Bo Li wrote: This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost -device vfio-pci,host=:00:00.0,id=vpci1 -device

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC

2015-06-29 Thread Peter Maydell
On 29 June 2015 at 10:54, Michael S. Tsirkin m...@redhat.com wrote: Looks like hw/i386/ does not work, hw/i386/* seems to work better. This is kind of vague... The documentation at the top of MAINTAINERS says the difference is that hw/i386/ means all files in and below hw/i386/, whereas

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC

2015-06-29 Thread Laszlo Ersek
On 06/29/15 12:42, Peter Maydell wrote: On 29 June 2015 at 11:23, Laszlo Ersek ler...@redhat.com wrote: On 06/29/15 12:00, Peter Maydell wrote: On 29 June 2015 at 10:54, Michael S. Tsirkin m...@redhat.com wrote: Looks like hw/i386/ does not work, hw/i386/* seems to work better. This is kind

Re: [Qemu-devel] [PATCH v4 0/6] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-29 Thread Igor Mammedov
On Mon, 29 Jun 2015 13:50:21 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Hi, Here is the v4 of the patchset that refactors pc_dimm_plug and adds an API to lookup NUMA node by address. - Refactoring pc_dimm_plug() helps other architectures like PowerPC to make use of common

[Qemu-devel] [PATCH] block: remove redundant check before g_slist_find()

2015-06-29 Thread Alberto Garcia
An empty GSList is represented by a NULL pointer, therefore it's a perfectly valid argument for g_slist_find() and there's no need to make any additional check. Signed-off-by: Alberto Garcia be...@igalia.com --- block/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [SeaBIOS] [PATCH 05/18] virtio: add version 1.0 structs and #defines

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 10:53:27AM +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 59 src/hw/virtio-ring.h | 5 + 2 files changed, 64 insertions(+) diff --git

Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device

2015-06-29 Thread Gerd Hoffmann
On Mo, 2015-06-29 at 08:48 -0400, Kevin O'Connor wrote: On Mon, Jun 29, 2015 at 10:53:25AM +0200, Gerd Hoffmann wrote: For virtio 1.0 support we will need more state than just the (legacy mode) ioaddr for each virtio-pci device. Prepare for that by adding a new struct for it. For now it

Re: [Qemu-devel] [Qemu-block] [PATCH 01/16] ide: add limit to .prepare_buf()

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 02:16:57PM -0400, John Snow wrote: On 06/26/2015 10:32 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:00PM -0400, John Snow wrote: diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4afd0cf..a295baa 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -55,8 +55,11

Re: [Qemu-devel] [SeaBIOS] [PATCH 07/18] virtio: add version 1.0 read/write macros

2015-06-29 Thread Gerd Hoffmann
On Mo, 2015-06-29 at 09:02 -0400, Kevin O'Connor wrote: On Mon, Jun 29, 2015 at 10:53:29AM +0200, Gerd Hoffmann wrote: Add macros to read/write registers of virtio-1.0 regions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 76

Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:05PM -0400, John Snow wrote: Handle NCQ failures for cases where we want to halt the VM on IO

Re: [Qemu-devel] [SeaBIOS] [PATCH 07/18] virtio: add version 1.0 read/write macros

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 03:46:54PM +0200, Gerd Hoffmann wrote: On Mo, 2015-06-29 at 09:02 -0400, Kevin O'Connor wrote: On Mon, Jun 29, 2015 at 10:53:29AM +0200, Gerd Hoffmann wrote: Add macros to read/write registers of virtio-1.0 regions. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [SeaBIOS] [PATCH 05/18] virtio: add version 1.0 structs and #defines

2015-06-29 Thread Gerd Hoffmann
Hi, +typedef struct virtio_pci_common_cfg { +/* About the whole device. */ +u32 device_feature_select; /* read-write */ If I understand these structs correctly, they don't reside in memory, but instead represent an interface layout and are used with offsetof() and sizeof().

Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 10:53:25AM +0200, Gerd Hoffmann wrote: For virtio 1.0 support we will need more state than just the (legacy mode) ioaddr for each virtio-pci device. Prepare for that by adding a new struct for it. For now it carries the ioaddr only. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread Bharata B Rao
On Mon, Jun 29, 2015 at 02:08:20PM +0200, Igor Mammedov wrote: On Mon, 29 Jun 2015 13:50:25 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Start storing the (start_addr, end_addr) of the pc-dimm memory in corresponding numa_info[node] so that this information can be used to lookup

Re: [Qemu-devel] [PATCH] block: remove redundant check before g_slist_find()

2015-06-29 Thread Alexander Yarygin
Alberto Garcia be...@igalia.com writes: An empty GSList is represented by a NULL pointer, therefore it's a perfectly valid argument for g_slist_find() and there's no need to make any additional check. Signed-off-by: Alberto Garcia be...@igalia.com --- block/io.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 10:53:32AM +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 12 src/hw/virtio-pci.h | 6 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/hw/virtio-pci.c

Re: [Qemu-devel] [SeaBIOS] [PATCH 07/18] virtio: add version 1.0 read/write macros

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 10:53:29AM +0200, Gerd Hoffmann wrote: Add macros to read/write registers of virtio-1.0 regions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 76 + 1 file changed, 76 insertions(+)

Re: [Qemu-devel] [PULL 0/1] tricore-patches

2015-06-29 Thread Peter Maydell
repository at: https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore-20150629 for you to fetch changes up to 5f37fd8e2980818ab71bc4b4e21129e29acd73f7: target-tricore: fix depositing bits from PCXI into ICR (2015-06-29 14:02:58 +0200

Re: [Qemu-devel] [PATCH v4 0/6] Refactoring pc_dimm_plug and NUMA node lookup API

2015-06-29 Thread Bharata B Rao
On Mon, Jun 29, 2015 at 02:32:09PM +0200, Igor Mammedov wrote: On Mon, 29 Jun 2015 13:50:21 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Hi, Here is the v4 of the patchset that refactors pc_dimm_plug and adds an API to lookup NUMA node by address. - Refactoring

Re: [Qemu-devel] [SeaBIOS] [PATCH 05/18] virtio: add version 1.0 structs and #defines

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 03:35:59PM +0200, Gerd Hoffmann wrote: Hi, +typedef struct virtio_pci_common_cfg { +/* About the whole device. */ +u32 device_feature_select; /* read-write */ If I understand these structs correctly, they don't reside in memory, but instead

Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:05PM -0400, John Snow wrote: Handle NCQ failures for cases where we want to halt the VM on IO

Re: [Qemu-devel] [PATCH v18 1/6] kvm: rename kvm_irqchip_[add, remove]_irqfd_notifier with gsi suffix

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: Anticipating for the introduction of new add/remove functions taking a qemu_irq parameter, let's rename existing ones with a gsi suffix. Signed-off-by: Eric Auger eric.au...@linaro.org Tested-by: Vikram Sethi

Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-06-29 Thread Michael S. Tsirkin
On Mon, Jun 29, 2015 at 11:33:42AM +0200, Markus Armbruster wrote: Eduardo Habkost ehabk...@redhat.com writes: On Fri, Jun 26, 2015 at 02:50:04PM -0400, John Snow wrote: On 06/26/2015 08:25 AM, Laszlo Ersek wrote: On 06/26/15 11:31, Markus Armbruster wrote: Laszlo Ersek

[Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC

2015-06-29 Thread Michael S. Tsirkin
Looks like hw/i386/ does not work, hw/i386/* seems to work better. Reported-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3d48a6b..39a01ab

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Laurent Vivier
On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson wrote: The info irq and info pic HMP commands are available on some, but not all targets,

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC

2015-06-29 Thread Laszlo Ersek
On 06/29/15 12:00, Peter Maydell wrote: On 29 June 2015 at 10:54, Michael S. Tsirkin m...@redhat.com wrote: Looks like hw/i386/ does not work, hw/i386/* seems to work better. This is kind of vague... The documentation at the top of MAINTAINERS says the difference is that hw/i386/ means all

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Laurent Vivier
On 29/06/2015 12:06, Andreas Färber wrote: Am 29.06.2015 um 11:55 schrieb Laurent Vivier: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson wrote:

Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out

2015-06-29 Thread Andreas Färber
Am 29.06.2015 um 07:36 schrieb David Gibson: Currently, the code to handle the legacy ISA bus is always included in qemu. However there are lots of platforms that don't include ISA legacy devies, and quite a few that have never used ISA legacy devices at all. This patch allows the ISA bus

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Andreas Färber
Am 29.06.2015 um 12:36 schrieb Andreas Färber: Am 29.06.2015 um 12:22 schrieb Laurent Vivier: On 29/06/2015 12:06, Andreas Färber wrote: Am 29.06.2015 um 11:55 schrieb Laurent Vivier: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015

[Qemu-devel] [PATCH] target-xtensa: add 64-bit floating point registers

2015-06-29 Thread Max Filippov
Xtensa ISA got specification for 64-bit floating point registers and opcodes, see ISA, 4.3.11 Floating point coprocessor option. Add 64-bit FP registers. Although 64-bit floating point is currently not supported by xtensa translator, these registers need to be reported to gdb with proper size,

[Qemu-devel] [PULL 0/1] tricore-patches

2015-06-29 Thread Bastian Koppelmann
-tricore-20150629 for you to fetch changes up to 5f37fd8e2980818ab71bc4b4e21129e29acd73f7: target-tricore: fix depositing bits from PCXI into ICR (2015-06-29 14:02:58 +0200) TriCore bugfixes

[Qemu-devel] [PULL 1/1] target-tricore: fix depositing bits from PCXI into ICR

2015-06-29 Thread Bastian Koppelmann
From: Paolo Bonzini pbonz...@redhat.com Spotted by Coverity, because (env-PCXI MASK_PCXI_PCPN) 24 is always zero. The immediately preceding assignment is also wrong though. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Andreas Färber
Am 29.06.2015 um 11:55 schrieb Laurent Vivier: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson wrote: diff --git a/monitor.c b/monitor.c index

Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 05:06:01PM +0800, Jason Wang wrote: On 06/25/2015 05:18 PM, Stefan Hajnoczi wrote: e1000_can_receive() checks the link up status register bit. If the bit is clear, packets will be queued and the peer may disable receive to avoid wasting CPU reading packets that

Re: [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT

2015-06-29 Thread Alexander Graf
On 06/29/15 11:15, Richard Henderson wrote: On 06/21/2015 05:51 PM, Aurelien Jarno wrote: A break is missing in the EXECUTE instruction, when executing the TRANSLATE AND TEST instruction. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Aurelien Jarno aurel...@aurel32.net Cc:

Re: [Qemu-devel] [PATCH v18 4/6] sysbus: add irq_routing_notifier

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: Add a new connect_irq_notifier notifier in the SysBusDeviceClass. This notifier, if populated, is called after sysbus_connect_irq. This mechanism is used to setup VFIO signaling once VFIO platform devices get attached to their

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Andreas Färber
Am 29.06.2015 um 12:22 schrieb Laurent Vivier: On 29/06/2015 12:06, Andreas Färber wrote: Am 29.06.2015 um 11:55 schrieb Laurent Vivier: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com

Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option

2015-06-29 Thread Peter Maydell
On 29 June 2015 at 06:36, David Gibson da...@gibson.dropbear.id.au wrote: At present, the core device model code for 8250-like serial ports (serial.c) and the code for serial ports attached to ISA-style legacy IO (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. There are lots

Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC

2015-06-29 Thread Peter Maydell
On 29 June 2015 at 11:23, Laszlo Ersek ler...@redhat.com wrote: On 06/29/15 12:00, Peter Maydell wrote: On 29 June 2015 at 10:54, Michael S. Tsirkin m...@redhat.com wrote: Looks like hw/i386/ does not work, hw/i386/* seems to work better. This is kind of vague... The documentation at the top

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread Igor Mammedov
On Mon, 29 Jun 2015 13:50:25 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Start storing the (start_addr, end_addr) of the pc-dimm memory in corresponding numa_info[node] so that this information can be used to lookup node by address. Signed-off-by: Bharata B Rao

Re: [Qemu-devel] [PATCH v18 3/6] intc: arm_gic_kvm: set the qemu_irq/gsi mapping

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: The arm_gic_kvm now calls kvm_irqchip_set_qemuirq_gsi to build the hash table storing qemu_irq/gsi mappings. From that point on irqfd can be setup directly from the qemu_irq using kvm_irqchip_add_irqfd_notifier. Signed-off-by:

Re: [Qemu-devel] [PATCH v18 5/6] kvm: some fixes to kvm_resamplefds_allowed

2015-06-29 Thread Eric Auger
On 06/29/2015 11:47 AM, Peter Maydell wrote: On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and associated kvm_resamplefds_allowed boolean. This patch adds non-KVM version for kvm_resamplefds_enabled and also declares

Re: [Qemu-devel] [PATCH for-2.4] e1000: flush packets when link comes up

2015-06-29 Thread Fam Zheng
On Mon, 06/29 11:39, Stefan Hajnoczi wrote: On Fri, Jun 26, 2015 at 05:06:01PM +0800, Jason Wang wrote: On 06/25/2015 05:18 PM, Stefan Hajnoczi wrote: e1000_can_receive() checks the link up status register bit. If the bit is clear, packets will be queued and the peer may disable

[Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug

2015-06-29 Thread Andrew Bennett
From: Andrew Bennett andrew.benn...@imgtec.com For the MIPS N64 ABI when QEMU reads the break/trap instruction so that it can inspect the break/trap code it reads 8 rather than 4 bytes which means it finds the code field from the instruction after the break/trap instruction. This then causes

Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-06-29 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Fri, Jun 26, 2015 at 02:50:04PM -0400, John Snow wrote: On 06/26/2015 08:25 AM, Laszlo Ersek wrote: On 06/26/15 11:31, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: With the pc-q35-2.4 machine type, if the user creates an

Re: [Qemu-devel] [PATCH v18 5/6] kvm: some fixes to kvm_resamplefds_allowed

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and associated kvm_resamplefds_allowed boolean. This patch adds non-KVM version for kvm_resamplefds_enabled and also declares kvm_resamplefds_allowed in kvm-stub as it is

Re: [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction

2015-06-29 Thread Alexander Graf
On 06/18/15 18:04, Richard Henderson wrote: On 06/16/2015 04:57 PM, Aurelien Jarno wrote: The MOVE LONG instruction should pad the destination operand with the byte from bit positions 32-39 of the source length (r2 + 1), not with the same byte in the source address. Cc: Alexander

[Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-06-29 Thread Hong Bo Li
This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost -device vfio-pci,host=:00:00.0,id=vpci1 -device zpci,fid=2,uid=5,pci_id=vpci1,id=zpci1 The first line will create

Re: [Qemu-devel] [PATCH v3 1/5] cpu: Provide vcpu throttling interface

2015-06-29 Thread Dr. David Alan Gilbert
* Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: On 06/26/2015 02:07 PM, Dr. David Alan Gilbert wrote: * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: Provide a method to throttle guest cpu execution. CPUState is augmented with timeout controls and throttle start/stop functions. To

[Qemu-devel] [PATCH v2 0/1] s390 pci infrastructure modelling

2015-06-29 Thread Hong Bo Li
This patch extends the current s390 pci implementation to provide more flexibility in configuration of s390 specific device handling. For each vfio pci device, I create a zpci device to store s390 specific informations. And attach all of these special zpci devices to the s390 facility bus. A zpci

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Laurent Vivier
On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson wrote: The info irq and info pic HMP commands are available on some, but not all targets, and what they do isn't terribly consistent.

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Thomas Huth
On Mon, 29 Jun 2015 11:55:08 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30, Thomas Huth wrote: On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson

Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option

2015-06-29 Thread Andreas Färber
Am 29.06.2015 um 07:36 schrieb David Gibson: At present, the core device model code for 8250-like serial ports (serial.c) and the code for serial ports attached to ISA-style legacy IO (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. There are lots and lots of embedded

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Alexander Graf
On 06/29/15 12:43, Andreas Färber wrote: Am 29.06.2015 um 12:36 schrieb Andreas Färber: Am 29.06.2015 um 12:22 schrieb Laurent Vivier: On 29/06/2015 12:06, Andreas Färber wrote: Am 29.06.2015 um 11:55 schrieb Laurent Vivier: On 29/06/2015 11:51, Laurent Vivier wrote: On 29/06/2015 11:30,

Re: [Qemu-devel] [PATCH v4 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-29 Thread Igor Mammedov
On Mon, 29 Jun 2015 13:50:23 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: pc_dimm_plug() has code that will be needed for memory plug handlers in other archs too. Extract code from pc_dimm_plug() into a generic routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also

Re: [Qemu-devel] QEMU to generate host binary

2015-06-29 Thread Stefan Hajnoczi
On Sun, Jun 28, 2015 at 07:29:39PM -0400, Ayaz Akram wrote: Let's say qemu is running in System Emulation Mode, when it runs guest's binary, it can log the translated code for host. Is it possible to merge that translated code and other sections of guest's binary to make a binary which can

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

2015-06-29 Thread Vlad Yasevich
On 06/29/2015 01:46 AM, Santosh R wrote: All, I am testing VxLAN performance in VM. For this I am using below command to bring up the VM. # qemu-system-x86_64 -m 4096 -smp 4 -boot c -device virtio-net-pci,netdev=tap0,mac=00:11:22:33:44:55 -netdev tap,id=tap0,script=no,vhost=on -drive

Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures

2015-06-29 Thread John Snow
On 06/29/2015 11:42 AM, John Snow wrote: On 06/29/2015 10:24 AM, Stefan Hajnoczi wrote: On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:05PM -0400,

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-29 Thread Paul Moore
On Monday, June 29, 2015 09:50:17 AM Andrew Jones wrote: On Fri, Jun 26, 2015 at 04:26:22PM -0400, Paul Moore wrote: Perhaps a stupid question, but you did verify that it is cacheflush that is causing the problem? The seccomp filter code will emit a message to syslog or the audit log,

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] ahci: fix sdb fis semantics

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 01:36:23PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 12:11 PM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:15PM -0400, John Snow wrote: @@ -682,19 +680,22 @@ static void ahci_write_fis_sdb(AHCIState *s, int

Re: [Qemu-devel] [PATCH 00/10] block: incremental backup transactions using BlockJobTxn

2015-06-29 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 01:12:02PM +0100, Stefan Hajnoczi wrote: This series is based on my block branch (https://github.com/stefanha/qemu/commits/block). It uses patches from John Snow's [PATCH v6 00/10] block: incremental backup transactions series but implements the feature with a new

[Qemu-devel] [PULL 1/3] m68k: is_mem is useless

2015-06-29 Thread Laurent Vivier
Remove is_mem as it is never tested anymore since: commit bfa50bc2638d877cf2900712b7503be22e8811cb Author: aliguori aliguori@c046a42c-6fe2-441c-8c8c-71466251a162 Date: Tue Nov 18 20:26:41 2008 + Remove premature memop TB terminations (Jan Kiszka) Signed-off-by: Laurent

Re: [Qemu-devel] [SeaBIOS] [PATCH 00/18] virtio: add version 1.0 support

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 10:53:22AM +0200, Gerd Hoffmann wrote: Hi, This patch series adds virtio 1.0 support to the virtio blk and scsi drivers in seabios. With this series applied seabios happily boots in virtio 1.0 mode from both transitional and modern devices. Thanks. The series

Re: [Qemu-devel] [PATCH v3 1/5] cpu: Provide vcpu throttling interface

2015-06-29 Thread Jason J. Herne
On 06/26/2015 03:02 PM, Jason J. Herne wrote: On 06/26/2015 02:07 PM, Dr. David Alan Gilbert wrote: * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: Provide a method to throttle guest cpu execution. CPUState is augmented with timeout controls and throttle start/stop functions. To throttle

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Li Chengyuan
From kvm_pc_setup_irq_routing() function, we can see that 15 routes from PIC and 23 routes from IOAPIC are added into irq route table, but only 23 irq(gsi) are reserved. This leads to irq route table has been full but there are still tens of free gsi. So the retry part of kvm_irqchip_get_virq()

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-29 Thread John Snow
On 06/29/2015 10:51 AM, Stefan Hajnoczi wrote: On Fri, Jun 26, 2015 at 01:31:12PM -0400, John Snow wrote: On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice *ad, uint16_t

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Ryan Harper
Thank you for taking the time to report this bug and helping to make Ubuntu better. Please execute the following command, as it will automatically gather debugging information, in a terminal: apport-collect 1465935 When reporting bugs in the future please use apport by using 'ubuntu- bug' and

[Qemu-devel] [PULL 3/3] m68k: remove useless parameter op_size from gen_lea_indexed()

2015-06-29 Thread Laurent Vivier
Signed-off-by: Laurent Vivier laur...@vivier.eu Reviewed-by: Thomas Huth h...@tuxfamily.org --- target-m68k/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index 1f9b7fe..a57d241 100644 ---

[Qemu-devel] [PULL 0/3] m68k queue

2015-06-29 Thread Laurent Vivier
The following changes since commit 2b464e13f0d30e6c0b8f69ec908fceab30aea986: Merge remote-tracking branch 'remotes/bkoppelmann/tags/pull-tricore-20150629' into staging (2015-06-29 13:26:43 +0100) are available in the git repository at: g...@github.com:vivier/qemu-m68k.git tags/pull-m68k

[Qemu-devel] [PULL 2/3] m68k: remove useless file m68k-qreg.h

2015-06-29 Thread Laurent Vivier
Unused since: commit e1f3808e03f73e7a7fa966afbed2455dd052202e Author: pbrook pbrook@c046a42c-6fe2-441c-8c8c-71466251a162 Date: Sat May 24 22:29:16 2008 + Convert m68k target to TCG. Signed-off-by: Laurent Vivier laur...@vivier.eu Reviewed-by: Thomas Huth

Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr

2015-06-29 Thread Gerd Hoffmann
Hi, +u8 vp_get_isr(struct vp_device *vp) +{ +u8 isr; + +if (vp-use_modern) { +vp_modern_read(vp-isr, virtio_pci_isr, isr, isr); +} else { +isr = inb(vp-ioaddr + VIRTIO_PCI_ISR); +} +return isr; +} How about renaming use_modern to

Re: [Qemu-devel] [Qemu-block] [PATCH 12/16] ahci: ncq migration

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 12:46:07PM -0400, John Snow wrote: On 06/26/2015 11:48 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:11PM -0400, John Snow wrote: @@ -1555,6 +1573,35 @@ static int ahci_state_post_load(void *opaque, int version_id) return -1; } +for (j = 0; j

Re: [Qemu-devel] [PATCH 14/16] ahci: Do not map cmd_fis to generate response

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 01:31:12PM -0400, John Snow wrote: On 06/26/2015 11:59 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:13PM -0400, John Snow wrote: @@ -744,8 +722,8 @@ static void ahci_write_fis_pio(AHCIDevice *ad, uint16_t len) pio_fis[9] = s-hob_lcyl; pio_fis[10] =

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread Igor Mammedov
On Mon, 29 Jun 2015 19:11:30 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Mon, Jun 29, 2015 at 02:08:20PM +0200, Igor Mammedov wrote: On Mon, 29 Jun 2015 13:50:25 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Start storing the (start_addr, end_addr) of the pc-dimm

Re: [Qemu-devel] [PATCH V2] block/iscsi: restore compatiblity with libiscsi 1.9.0

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 12:18:01PM +0200, Peter Lieven wrote: RHEL7 and others are stuck with libiscsi 1.9.0 since there unfortunately was an ABI breakage after that release. Signed-off-by: Peter Lieven p...@kamp.de --- v1-v2: - do not use reserved macro names [Paolo] - change text

Re: [Qemu-devel] [SeaBIOS] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr

2015-06-29 Thread Kevin O'Connor
On Mon, Jun 29, 2015 at 04:33:54PM +0200, Gerd Hoffmann wrote: Hi, +u8 vp_get_isr(struct vp_device *vp) +{ +u8 isr; + +if (vp-use_modern) { +vp_modern_read(vp-isr, virtio_pci_isr, isr, isr); +} else { +isr = inb(vp-ioaddr + VIRTIO_PCI_ISR);

Re: [Qemu-devel] [PATCH] tcg/s390: fix branch target change during code retranslation

2015-06-29 Thread Richard Henderson
On 06/16/2015 06:11 AM, Aurelien Jarno wrote: Make sure to not modify the branch target. This ensure that the branch target is not corrupted during partial retranslation. Cc: Alexander Grafag...@suse.de Cc: Richard Hendersonr...@twiddle.net Signed-off-by: Aurelien Jarnoaurel...@aurel32.net ---

Re: [Qemu-devel] vmxnet3, vnet_hdr, and minimum length padding

2015-06-29 Thread Stefan Hajnoczi
On Tue, Jun 23, 2015 at 11:49:25AM -0400, Brian Kress wrote: When running ESXi under qemu there is an issue with the ESXi guest discarding packets that are too short. The guest discards any packets under the normal minimum length for an ethernet packet (60). This results in odd behaviour

Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures

2015-06-29 Thread John Snow
On 06/29/2015 10:24 AM, Stefan Hajnoczi wrote: On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote: On Mon, Jun 22, 2015 at 08:21:05PM -0400, John Snow wrote: Handle NCQ failures for

Re: [Qemu-devel] [Qemu-block] [PATCH] block/curl: Don't lose original error when a connection fails.

2015-06-29 Thread Stefan Hajnoczi
On Thu, Jun 25, 2015 at 08:39:56PM +0100, Richard W.M. Jones wrote: Currently if qemu is connected to a curl source (eg. web server), and the web server fails / times out / dies, you always see a bogus EIO Input/output error. For example, choose a large file located on any local webserver

Re: [Qemu-devel] [PATCH V2] block/nfs: add support for setting debug level

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 01:06:09PM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a cmdline parameter. Example qemu -nfs debug=99 -cdrom nfs://... Signed-off-by: Peter Lieven p...@kamp.de --- v1-v2: reworked

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: limit maximum readahead size to 1MB

2015-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2015 at 01:14:01PM +0200, Peter Lieven wrote: a malicious caller could otherwise specify a very large value via the URI and force libnfs to allocate a large amount of memory for the readahead buffer. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de ---

Re: [Qemu-devel] QEMU to generate host binary

2015-06-29 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 8:13 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, Jun 28, 2015 at 07:29:39PM -0400, Ayaz Akram wrote: Let's say qemu is running in System Emulation Mode, when it runs guest's System emulation makes the problem even harder, as a system mode binary (usually an OS

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

2015-06-29 Thread Santosh R
On Mon, Jun 29, 2015 at 9:04 PM, Vlad Yasevich vyase...@redhat.com wrote: On 06/29/2015 01:46 AM, Santosh R wrote: All, I am testing VxLAN performance in VM. For this I am using below command to bring up the VM. # qemu-system-x86_64 -m 4096 -smp 4 -boot c -device

Re: [Qemu-devel] [PATCH v6 2/6] spapr: Add LMB DR connectors

2015-06-29 Thread Thomas Huth
On Mon, 29 Jun 2015 14:14:28 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Enable memory hotplug for pseries 2.4 and add LMB DR connectors. Maybe write out the word LMB DR the first time you use it? With memory hotplug, enforce RAM size, NUMA node memory size and maxmem to be a

Re: [Qemu-devel] [PULL 0/3] m68k queue

2015-06-29 Thread Peter Maydell
On 29 June 2015 at 16:44, Laurent Vivier laur...@vivier.eu wrote: The following changes since commit 2b464e13f0d30e6c0b8f69ec908fceab30aea986: Merge remote-tracking branch 'remotes/bkoppelmann/tags/pull-tricore-20150629' into staging (2015-06-29 13:26:43 +0100) are available in the git

Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Peter Maydell
On 29 June 2015 at 17:54, Programmingkid programmingk...@gmail.com wrote: @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = { .bdrv_ioctl = hdev_ioctl, .bdrv_aio_ioctl = hdev_aio_ioctl, #endif + +#ifdef __APPLE__ +.bdrv_is_inserted =

[Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
Fix a problem with QEMU not being able to use real cd's on Mac OS X hosts. Implements a function called cd_is_inserted(). Signed-off-by: John Arbuckle programmingk...@gmail.com --- block/raw-posix.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] reset strategy?

2015-06-29 Thread Peter Crosthwaite
On Mon, Jun 29, 2015 at 12:26 AM, Liviu Ionescu i...@livius.net wrote: On 29 Jun 2015, at 02:15, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: cpu_reset(CPU(cm_state-cpu)); This should be managed by the bootloader. you mean via 'boot.c: arm_load_kernel()'? I'm not using it,

Re: [Qemu-devel] reset strategy?

2015-06-29 Thread Liviu Ionescu
On 29 Jun 2015, at 20:37, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Are are these two devices really not connected to any bus? in my emulation, these devices are created with object_new() and not connected to the sysbus or to any other bus. how do they work? just fine

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-29 Thread Andrew Jones
On Mon, Jun 29, 2015 at 10:53:14AM -0400, Paul Moore wrote: On Monday, June 29, 2015 09:50:17 AM Andrew Jones wrote: On Fri, Jun 26, 2015 at 04:26:22PM -0400, Paul Moore wrote: Perhaps a stupid question, but you did verify that it is cacheflush that is causing the problem? The seccomp

[Qemu-devel] QEMU + KVM PSCI and VCPU creation / destruction

2015-06-29 Thread Claudio Fontana
Hello, while heavily testing PSCI on QEMU+KVM during OSv enablement, I encountered, among others, the following issue: I am running a test in which I boot an OS at EL1 under KVM, then boot a secondary VCPU, then immediately call PSCI for a SYSTEM_RESET (reboot). This loops over infinitely,

Re: [Qemu-devel] [PULL 00/17] virtio, pci fixes, enhancements

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 14:45, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 0c8ff723bd29e5c8b2ca989f857ae5c37ec49c4e: m68k: fix usp processing on interrupt entry and exception exit (2015-06-22 14:43:25 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH 4/4] Disable info irq and info pic for target-ppc

2015-06-29 Thread Thomas Huth
On Mon, 29 Jun 2015 09:52:56 +0200 Laurent Vivier lviv...@redhat.com wrote: On 29/06/2015 07:36, David Gibson wrote: The info irq and info pic HMP commands are available on some, but not all targets, and what they do isn't terribly consistent. For SPARC and LM32 they do something

Re: [Qemu-devel] [PATCH v18 2/6] kvm-all.c: add qemu_irq/gsi hash table and utility routines

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: VFIO platform device needs to setup irqfd but it does not know the gsi corresponding to the device qemu_irq. This patch proposes to store a hash table in kvm_state using the qemu_irq as key and the gsi as a value.

Re: [Qemu-devel] [PATCH v18 6/6] hw/vfio/platform: add irqfd support

2015-06-29 Thread Peter Maydell
On 26 June 2015 at 18:29, Eric Auger eric.au...@linaro.org wrote: This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual

Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-06-29 Thread Michael S. Tsirkin
On Fri, Jun 26, 2015 at 02:25:42PM +0200, Laszlo Ersek wrote: On 06/26/15 11:31, Markus Armbruster wrote: Laszlo Ersek ler...@redhat.com writes: With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive

  1   2   3   >