Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

Eric Blake writes: > On 09/03/2015 08:30 AM, Markus Armbruster wrote: >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. > > [review in this sub-thread; for comments on 'int' munging

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

On Thu, Sep 03, 2015 at 12:18:18AM +0800, Yang Hongyang wrote: > > > On 09/02/2015 09:02 PM, Stefan Hajnoczi wrote: > >On Wed, Sep 02, 2015 at 09:49:18AM +0800, Yang Hongyang wrote: > >>On 09/01/2015 10:43 PM, Stefan Hajnoczi wrote: > >>>On Tue, Sep 01, 2015 at 05:06:18PM +0800, Yang Hongyang

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On 4 September 2015 at 12:24, Richard Purdie wrote: > So just based on that, yes, seems that the rx_fifo looks to be > overrunning. I can add the asserts but I think it would just confirm > this. Yes, the point of adding assertions is to confirm a hypothesis.

[Qemu-devel] [PATCH v2 2/2] block: add a 'blockdev-snapshot' QMP command

One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap

[Qemu-devel] [PATCH v2 1/2] block: rename BlockdevSnapshot to BlockdevSnapshotSync

We will introduce the 'blockdev-snapshot' command that will require its own struct for the parameters, so we need to rename this one in order to avoid name clashes. Signed-off-by: Alberto Garcia --- blockdev.c | 2 +- qapi-schema.json | 2 +- qapi/block-core.json

Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

On Fri, 14 Aug 2015 22:52:00 +0800 Xiao Guangrong wrote: > NVDIMM reserves all the free range above 4G to do: > - Persistent Memory (PMEM) mapping > - implement NVDIMM ACPI device _DSM method > > Signed-off-by: Xiao Guangrong >

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

On 09/03/2015 08:29 AM, Markus Armbruster wrote: > The QAPI code generators work with a syntax tree (nested dictionaries) > plus a few symbol tables (also dictionaries) on the side. > > + > +class QAPISchemaArrayType(QAPISchemaType): > +def __init__(self, name, info, element_type): > +

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

Hello! > Can you test this reasonably soon, please? Otherwise > I'll have to drop it from target-arm again. Tested, confirm, the problem persists with Linux v4.1.4, LPAE disabled: --- cut --- PCI host bridge /pcie@1000 ranges: IO 0x3eff..0x3eff -> 0x MEM

[Qemu-devel] Segfault using qemu-system-arm in smc91c111

We're seeing repeated segfaults in qemu-system-arm when we heavily use the network. I have a coredump backtrace: Reading symbols from /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm-lsb/build/build/tmp/sysroots/x86_64-linux/usr/bin/qemu-system-arm...done. [New LWP 4536] [New LWP 4534]

Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

04 сент. 2015 г. 12:57 пользователь "Hitoshi Mitake" < mitake.hito...@gmail.com> написал: > > On Fri, Sep 4, 2015 at 5:51 PM, Hitoshi Mitake wrote: > > On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov wrote: > >> 2015-09-01 6:03 GMT+03:00 Hitoshi

Re: [Qemu-devel] [PATCH v2 2/2] target-mips: Use tcg_gen_extrh_i64_i32

On 02/09/2015 23:50, Richard Henderson wrote: > We can tidy gen_load_fpr32h, as well as introduce a helper > to cleanup the MACC instructions. > > Signed-off-by: Richard Henderson > --- > target-mips/translate.c | 48 ++-- > 1 file

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

"Daniel P. Berrange" writes: > On Fri, Sep 04, 2015 at 09:12:09AM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Thu, Sep 03, 2015 at 04:29:53PM +0200, Markus Armbruster wrote: >> > Python has a nice tool called pep8 which

[Qemu-devel] [PATCH v2 0/2] Add 'blockdev-snapshot' command

Previous attempt to extend blockdev-snapshot-sync: https://lists.gnu.org/archive/html/qemu-block/2015-08/msg00236.html As discussed in the previous thread, this adds a new command called 'blockdev-snapshot', that simply takes references to two existing block devices. I decided to share most of

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

dovgaluk writes: > Hi! > Alex Bennée писал 2015-09-04 10:49: >> * What to do about icount? >> >> What is the impact of multi-thread on icount? Do we need to disable it >> for MTTCG or can it be correct per-cpu? Can it be updated lock-step? > Why can't we have separate icount for each CPU? >

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

Michael Roth writes: > Quoting Markus Armbruster (2015-09-03 09:30:21) >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. >> >> The introspection schema does not reflect all

Re: [Qemu-devel] [RFC 26/38] cpu: protect tb_jmp_cache with seqlock

On 04/09/2015 10:50, Paolo Bonzini wrote: > Having now reviewed the patch, I think we can do better. > > The idea is: > > - only the CPU thread can set cpu->tb_jmp_cache[] > > - other threads can, under seqlock protection, _clear_ cpu->tb_jmp_cache[] > > - the seqlock can be protected by

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On Fri, 2015-09-04 at 12:31 +0100, Peter Maydell wrote: > On 4 September 2015 at 12:24, Richard Purdie > wrote: > > So just based on that, yes, seems that the rx_fifo looks to be > > overrunning. I can add the asserts but I think it would just confirm > > this.

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

> On 4 Sep 2015, at 11:41, Edgar E. Iglesias wrote: > > On Fri, Sep 04, 2015 at 11:25:33AM +0200, Paolo Bonzini wrote: >> >> >> On 04/09/2015 09:49, Alex Bennée wrote: >>> * Signal free qemu_cpu_kick (Paolo) >>> >>> I don't know much about this patch set but I

Re: [Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

On Fri, Sep 04, 2015 at 01:24:11PM +0100, Peter Maydell wrote: > This is a brief writeup of what we discussed at the QEMU Summit 2015 > at KVM Forum last month. > * Continous integration > * Another perennial issue :-) > * Buildbot is broken and unmaintained: will probably go down soon > * The

[Qemu-devel] [PATCH 3/4] virtio-ccw: feature bits > 31 handling

We currently switch off the VERSION_1 feature bit if the guest has not negotiated at least revision 1. As no feature bits beyond 31 are valid however unless VERSION_1 has been negotiated, make sure that legacy guests never see a feature bit beyond 31. Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH V4 6/8] Introduce xilinx dpdma.

On 04/09/2015 01:34, Alistair Francis wrote: On Thu, Sep 3, 2015 at 12:28 AM, Frederic Konrad wrote: On 02/09/2015 23:39, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

On 04/09/2015 09:49, Alex Bennée wrote: > * Signal free qemu_cpu_kick (Paolo) > > I don't know much about this patch set but I assume this avoids the need > to catch signals and longjmp about just to wake up? It was part of Fred's patches, so I've extracted it to its own series. Removing 150

Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

On Fri, Sep 4, 2015 at 5:51 PM, Hitoshi Mitake wrote: > On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov wrote: >> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake : >>> This patch refines discard support of the sheepdog driver.

[Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

This is a brief writeup of what we discussed at the QEMU Summit 2015 at KVM Forum last month. * Participants Markus Armbruster Paolo Bonzini Luiz Capitulino Andreas Färber Alexander Graf Eduardo Habkost Stefan Hajnoczi Richard Henderson Gerd Hoffmann Edgar E. Iglesias Bastian Koppelmann Peter

Re: [Qemu-devel] [PATCH v15 01/33] linux-user: tilegx: Firstly add architecture related features

On 9/3/15 22:53, Eric Blake wrote: > On 09/02/2015 07:30 PM, Richard Henderson wrote: >> From: Chen Gang > > s/Firstly add/Add/ in the subject line > Thank you for your careful notification. :-) I guess, it will be modified by RTH, before the patches v15 (or v16)

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On 4 September 2015 at 11:25, Richard Purdie wrote: > We're seeing repeated segfaults in qemu-system-arm when we heavily use > the network. I have a coredump backtrace: > (gdb) print s->tx_fifo_done > $1 = {99614720, 99614720, 99614720, 99614720} > (gdb) print

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

On Fri, Sep 04, 2015 at 11:25:33AM +0200, Paolo Bonzini wrote: > > > On 04/09/2015 09:49, Alex Bennée wrote: > > * Signal free qemu_cpu_kick (Paolo) > > > > I don't know much about this patch set but I assume this avoids the need > > to catch signals and longjmp about just to wake up? > > It

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On Wed, Sep 02, 2015 at 11:25:26AM +0200, Alexander Spyridakis wrote: > Properly clean any generated object and binary files after a 'make clean', > this fixes an issue when trying to reconfigure between arm and arm64. Are you also running configure (with the opposite arch selected) after 'make

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On Fri, 2015-09-04 at 11:45 +0100, Peter Maydell wrote: > On 4 September 2015 at 11:25, Richard Purdie > wrote: > > We're seeing repeated segfaults in qemu-system-arm when we heavily use > > the network. I have a coredump backtrace: > > > (gdb) print

[Qemu-devel] [PATCH 0/2] arm/virt: Add full-sized CPU affinity handling

This small patchset is actually a small extraction from vGICv3 support, as it was suggested in https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00921.html. Initially i wanted to just make a check, but ended up full implementation which is not more difficult. Since we don't make any

[Qemu-devel] [PATCH 1/2] target-arm: Refactor CPU affinity handling

Introduces reusable definitions for CPU affinity masks/shifts and gets rid of hardcoded magic numbers. Signed-off-by: Pavel Fedin --- target-arm/cpu-qom.h | 12 target-arm/cpu.c | 2 +- target-arm/kvm32.c | 3 +-- target-arm/kvm64.c | 3 +-- 4 files

[Qemu-devel] [PATCH 2/2] arm/virt: Add full-sized CPU affinity handling

At least with KVM, currently there's no reason why qemu would not be capable of handling Aff3 != 0. This commit fixes up FDT creation in such a case. Signed-off-by: Pavel Fedin --- hw/arm/virt.c | 32 ++-- 1 file changed, 30 insertions(+), 2

Re: [Qemu-devel] [PATCH 07/17] target-openrisc: Keep SR_CY and SR_OV in a separate variables

On 09/03/2015 02:17 AM, Richard Henderson wrote: - -uint32_t HELPER(mul32)(CPUOpenRISCState *env, - uint32_t ra, uint32_t rb) -{ -uint64_t result; -uint32_t high, cy; - -OpenRISCCPU *cpu = openrisc_env_get_cpu(env); - -result = (uint64_t)ra * rb; -/*

Re: [Qemu-devel] [PATCH RFC v4 32/32] qapi-introspect: Hide type names

On 09/03/2015 08:30 AM, Markus Armbruster wrote: > To eliminate the temptation for clients to look up types by name > (which are not ABI), replace all type names by meaningless strings. > > Reduces output of query-schema by 13 out of 85KiB. > > As a debugging aid, provide option -u to suppress

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On Fri, Sep 04, 2015 at 03:48:35PM +0200, Alexander Spyridakis wrote: > On 4 September 2015 at 12:48, Andrew Jones wrote: > > Are you also running configure (with the opposite arch selected) after > > 'make clean'? If not, then that could be the source of your problems. > >

Re: [Qemu-devel] [PATCH 0/2] arm/virt: Add full-sized CPU affinity handling

On 4 September 2015 at 12:39, Pavel Fedin wrote: > This small patchset is actually a small extraction from vGICv3 support, > as it was suggested in > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00921.html. > Initially i wanted to just make a check, but ended up

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

Hello! > I think we need to leave enough space for all of GICC/GICV/GICH > (that's 2 pages for GICC, 2 for GICV, 1 for GICH). They're optional > in a GICv3, but we may want them for emulation later on and if we > haven't left ourselves enough space we'll be a bit stuck. Do we really need this?

[Qemu-devel] [PULL 23/33] qapi-commands: Inline gen_marshal_output_call()

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 3965ca8..6de5229 100644 ---

[Qemu-devel] [PULL 01/33] qapi: Clarify docs on including the same file multiple times

It's idempotent. While there, update examples to current code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/qapi-code-gen.txt

Re: [Qemu-devel] checkpatch.pl Perl 5.22 deprecation

On 09/04/2015 06:50 AM, Bastian Koppelmann wrote: > Hi, > > Perl 5.22 has deprecated unescaped { inside a regexp, which leads to > very annoying warnings. Since we use checkpatch from the Linux kernel, I > found a corresponding patch [1] that fixes it. Do we just get the new > checkpatch from the

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On Fri, Sep 04, 2015 at 03:53:46PM +0200, Alexander Spyridakis wrote: > On 4 September 2015 at 12:48, Andrew Jones wrote: > > The lines this > > patch adds are already there. See the arm_clean target in > > config/config-arm-common.mak. > > I see your point now. Maybe then

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

Hello! > Yes, I think that implementation of Hyp mode is very likely in > the future -- Xilinx want it, for instance. Ok. Will add it. > A register at offset 0x1 means 2 64K pages, doesn't it? > Can you give a more exact reference to the bit of the manual > you mean? I have mistaken 4K

[Qemu-devel] [PULL 09/33] qapi-visit: Fix generated code when schema has forward refs

The visit_type_implicit_FOO() are generated on demand, right before their first use. Used by visit_type_STRUCT_fields() when STRUCT has base FOO, and by visit_type_UNION() when flat UNION has member a FOO. If the schema defines FOO after its first use as struct base or flat union member,

[Qemu-devel] [PULL 15/33] qapi: Document shortcoming with union 'data' branch

From: Eric Blake Add a FIXME to remind us to fully audit whether removing the 'void *data' branch of each qapi union type can be done safely. Signed-off-by: Eric Blake Message-Id: <1438297637-26789-1-git-send-email-ebl...@redhat.com> Signed-off-by: Markus

[Qemu-devel] [PULL 20/33] qapi: Fix to reject union command and event arguments

A command's or event's 'data' must be a struct type, given either as a dictionary, or as struct type name. Commit dd883c6 tightened the checking there, but not enough: we still accept 'union'. Fix to reject it. We may want to support union types there, but we'll have to extend qapi-commands.py

Re: [Qemu-devel] [PATCH v2 1/2] target-mips: Use movcond in movci and movcf*

On 09/03/2015 10:01 AM, Leon Alrae wrote: On 02/09/2015 23:50, Richard Henderson wrote: @@ -8821,102 +8840,126 @@ static void gen_cp1 (DisasContext *ctx, uint32_t opc, int rt, int fs) tcg_temp_free(t0); } -static void gen_movci (DisasContext *ctx, int rd, int rs, int cc, int tf)

Re: [Qemu-devel] [PATCH v15 0/8] i.MX: Add i.MX25 support through the PDK evaluation board

On 31 August 2015 at 23:08, Jean-Christophe Dubois wrote: > This series of patches is generated against Peter Maydell GIT tree: > https://git.linaro.org/people/peter.maydell/qemu-arm.git > branch target-arm-post-2.4 > > This series of patches add the support for the i.MX25

[Qemu-devel] PING: [PATCH v2] Do not use slow [*] expansion for GPIO creation

Hello! Long time has passed, i do not see any movements. Was it forgotten? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: qemu-devel-bounces+p.fedin=samsung@nongnu.org [mailto:qemu-devel- >

Re: [Qemu-devel] PING: [PATCH v2 0/2] cpu_arm: Implement irqchip property for ARM CPU

Hello! > It's not clear to me that the TCG version of GICv3 > emulation should need to have such a link. How can it be done otherwise? Should GIC code somehow register own system register handlers instead? > The original > emulation patchset was definitely not handling the > GIC-to-CPU

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

> On 4 Sep 2015, at 14:38, Lluís Vilanova wrote: > > dovgaluk writes: > >> Hi! >> Alex Bennée писал 2015-09-04 10:49: >>> * What to do about icount? >>> >>> What is the impact of multi-thread on icount? Do we need to disable it >>> for MTTCG or can it be correct per-cpu?

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most. >>> >>> That

Re: [Qemu-devel] [PATCH 06/17] target-openrisc: Put SR[OVE] in TB flags

On 09/03/2015 02:17 AM, Richard Henderson wrote: { /* Sync the tb dependent flag between translate and runtime. */ -if (dc->tb_flags != dc->synced_flags) { -tcg_gen_movi_tl(env_flags, dc->tb_flags); +if ((dc->tb_flags ^ dc->synced_flags) & D_FLAG) { +

Re: [Qemu-devel] [PATCH v2] linux-user: add name_to_handle_at/open_by_handle_at

On 1 September 2015 at 21:27, Laurent Vivier wrote: > This patch allows to run example given by open_by_handle_at(2): > > The following shell session demonstrates the use of these two programs: > >$ echo 'Can you please think about it?' > cecilia.txt >

[Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups

The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2015-09-03 16:17:28 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-09-04

[Qemu-devel] [PULL 16/33] qapi: Document flaws in checking of names

We don't actually enforce our "other than downstream extensions [...], all names should begin with a letter" rule. Add a FIXME. We should reject names that differ only in '_' vs. '.' vs. '-', because they're liable to clash in generated C. Add a FIXME. Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 08/33] qapi: Generate a nicer struct for flat unions

The struct generated for a flat union is weird: the members of its base are at the end, except for the union tag, which is at the beginning. Example: qapi-schema-test.json has { 'struct': 'UserDefUnionBase', 'data': { 'string': 'str', 'enum1': 'EnumOne' } } { 'union':

[Qemu-devel] [PULL 17/33] tests/qapi-schema: Restore test case for flat union base bug

Test case added in commit 2fc0043, and messed up in commit 5223070. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 5 +++-- tests/qapi-schema/qapi-schema-test.out | 8 2 files changed, 7

[Qemu-devel] [PULL 1/2] qmp-shell: add documentation

From: John Snow I should probably document the changes that were made. Signed-off-by: John Snow Message-Id: <1435775149-17285-1-git-send-email-js...@redhat.com> Reviewed-By: Kashyap Chamarthy Reviewed-by: Luiz Capitulino

[Qemu-devel] checkpatch.pl Perl 5.22 deprecation

Hi, Perl 5.22 has deprecated unescaped { inside a regexp, which leads to very annoying warnings. Since we use checkpatch from the Linux kernel, I found a corresponding patch [1] that fixes it. Do we just get the new checkpatch from the kernel, or do we integrate the patch ourself? [1]

[Qemu-devel] [PULL 06/33] qapi: Drop unused and useless parameters and variables

gen_sync_call()'s parameter indent is useless: gen_sync_call() uses it only as optional argument for push_indent() and pop_indent(), their default is four, and gen_sync_call()'s only caller passes four. Drop the parameter. gen_visitor_input_containers_decl()'s parameter obj is always

[Qemu-devel] [PULL 04/33] qapi-event: Clean up how name of enum QAPIEvent is made

Use c_name() instead of ad hoc code. Doesn't upcase the -p prefix, which is an improvement in my book. Unbreaks prefix containing '.', but other funny characters remain broken. To be fixed next. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake

[Qemu-devel] [PULL 07/33] qapi: Fix generated code when flat union has member 'kind'

A flat union's tag member gets renamed to 'kind' in the generated code. Breaks when another member named 'kind' exists. Example, adapted from qapi-schema-test.json: { 'struct': 'UserDefUnionBase', 'data': { 'kind': 'str', 'enum1': 'EnumOne' } } We generate: struct

[Qemu-devel] [PULL 05/33] qapi: Reject -p arguments that break qapi-event.py

qapi-event.py breaks when you ask for a funny prefix like '@'. Protect it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index

[Qemu-devel] [PULL 02/33] qapi: Clean up cgen() and mcgen()

Commit 05dfb26 added eatspace stripping to mcgen(). Move it to cgen(), just in case somebody gets tempted to use cgen() directly instead of via mcgen(). cgen() indents blank lines. No such lines get generated right now, but fix it anyway. We use triple-quoted strings for program text, like

[Qemu-devel] [PULL 11/33] qapi-visit: Fix two name arguments passed to visitors

The generated code passes mangled schema names to visit_type_enum() and union's visit_start_struct(). Fix it to pass the names unadulterated, like we do everywhere else. Only qapi-schema-test.json actually has names where this makes a difference: enum __org.qemu_x-Enum, flat union

[Qemu-devel] [PULL 25/33] qapi-commands: Drop useless initialization

In generated command handlers, the assignment to retval dominates its only use. Therefore, its initialization is useless. Drop it. Suggested-by: Eric Blake Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake ---

[Qemu-devel] [PULL 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index b4d4a01..ff16df2 100644 ---

[Qemu-devel] [PULL 28/33] tests/qapi-schema: Cover two more syntax errors

Syntax error coverage should now be complete. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/Makefile | 1 + tests/qapi-schema/leading-comma-list.err| 1 + tests/qapi-schema/leading-comma-list.exit | 1

Re: [Qemu-devel] checkpatch.pl Perl 5.22 deprecation

On 09/04/2015 04:23 PM, Eric Blake wrote: On 09/04/2015 06:50 AM, Bastian Koppelmann wrote: Hi, Perl 5.22 has deprecated unescaped { inside a regexp, which leads to very annoying warnings. Since we use checkpatch from the Linux kernel, I found a corresponding patch [1] that fixes it. Do we

[Qemu-devel] [PULL 26/33] qapi: Generated code cleanup

Clean up white-space, brace placement, and superfluous #ifdef QAPI_TYPES_BUILTIN_CLEANUP_DEF. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 12 - scripts/qapi-commands.py | 1 + scripts/qapi-event.py|

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On 4 September 2015 at 16:05, Andrew Jones wrote: > This doesn't reproduce for me. I did the following, and it worked > fine. > > make distclean > ./configure --arch=arm --cross-prefix=arm-linux-gnu- > make > ./configure --arch=arm64 --cross-prefix=aarch64-linux-gnu- > make

Re: [Qemu-devel] [PATCH 07/10] s390: Rename s390-ccw-virtio-2.4 class name to use MACHINE_TYPE_NAME

On Fri, Sep 04, 2015 at 10:52:22AM +0200, Christian Borntraeger wrote: > Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: > > Machine class names should use the "-machine" suffix to allow > > class-name-based machine class lookup to work. Rename the > > s390-ccw-virtio-2.4 machine class using the

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

On 3 September 2015 at 06:27, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, >

Re: [Qemu-devel] [PATCH RFC v4 00/32] qapi: QMP introspection

Hi Markus On Thu, Sep 3, 2015 at 4:29 PM, Markus Armbruster wrote: > Series is based on "[PATCH 00/26] qapi: Another round of fixes and > cleanups" (which actually has 33 patches now). It also needs my > "[PATCH for-2.4 0/2] qom: Fix misuse of Error API" to pass tests. > >

Re: [Qemu-devel] [PATCH 02/17] target-openrisc: Streamline arithmetic and OVE

On 09/03/2015 04:44 PM, Richard Henderson wrote: That's patch 7/17. ;-) Woops , I just realized ;-) R0 is not an *architectural* zero. It's a software convention. The spec is fairly clear on this point. I agree that there ought to be some special-casing of the software convention,

Re: [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

On 31 August 2015 at 22:28, Alistair Francis wrote: > On Mon, Aug 31, 2015 at 1:54 PM, John Snow wrote: >> For some reason, this patch never made it to the qemu-devel archives for >> either v5 or v6. I only received a direct copy to my inbox, but

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

On 09/04/2015 03:55 AM, Markus Armbruster wrote: >>> + >>> +query-schema returns a JSON array of SchemaInfo objects. These >>> +objects together describe the wire ABI, as defined in the QAPI schema. >> >> Maybe an additional sentence here, perhaps along the lines of: >> >> Note that the wire

Re: [Qemu-devel] [PATCH] Added specific ARM_FEATURE for Thumb-exception enable bit

On 03/09/15 17:58, Peter Crosthwaite wrote: Hi Mike, On Thu, Sep 3, 2015 at 2:27 AM, GitNoviceMikeH wrote: From: GitNoviceMikeH Most ARM cores switch unconditionally to ARM mode when an exception occurs; a few (Cortex) variants

[Qemu-devel] [PATCH] target-mips: Fix RDHWR on CP0.Count

For RDHWR on the CP0.Count register, env->CP0_Count was being returned. This value is a delta against the QEMU_CLOCK_VIRTUAL clock, not the correct current value of CP0.Count. Use cpu_mips_get_count() instead. Signed-off-by: Alex Smith Cc: Aurelien Jarno

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

Hi! Alex Bennée писал 2015-09-04 10:49: * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? Why can't we have separate icount for each CPU? Then virtual timer will be assigned

[Qemu-devel] [PULL 0/2] Monitor patches

The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2015-09-03 16:17:28 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PATCH v2 2/2] block: add a 'blockdev-snapshot' QMP command

On 09/04/2015 06:37 AM, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_excp_unmasked() function

On 2 September 2015 at 16:53, Sergey Sorokin wrote: > There is an error in arm_excp_unmasked() function: > bitwise operator & is used with integer and bool operands > causing an incorrect zeroed result. > The patch fixes it. > > Signed-off-by: Sergey Sorokin

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On 4 September 2015 at 12:48, Andrew Jones wrote: > The lines this > patch adds are already there. See the arm_clean target in > config/config-arm-common.mak. I see your point now. Maybe then "arm_clean" should be changed in "arch_clean" in config-arm-common.mak? Regards.

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On 4 September 2015 at 15:05, Andrew Jones wrote: > But anyway I would suggest you do your 'make clean' or even a > 'make distclean' *before* running configure the second time. > Otherwise you'll leave old object files around from the previously > configured arch. I.e. you

[Qemu-devel] [PULL 30/33] qapi: Fix errors for non-string, non-dictionary members

Fixes the errors demonstrated by the previous commit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 10 ++ tests/qapi-schema/args-invalid.err | 2 +-

[Qemu-devel] [PULL 14/33] qapi: Document that input visitor semantics are prone to leaks

From: Eric Blake Most functions that can return a pointer or set an Error ** value are decent enough to guarantee a NULL return when reporting an error. Not so with our generated qapi visitor functions. If the caller is not careful to clean up partially-allocated objects on

Re: [Qemu-devel] [PATCH v2 1/2] block: rename BlockdevSnapshot to BlockdevSnapshotSync

On 09/04/2015 06:37 AM, Alberto Garcia wrote: > We will introduce the 'blockdev-snapshot' command that will require > its own struct for the parameters, so we need to rename this one in > order to avoid name clashes. > > Signed-off-by: Alberto Garcia > --- > blockdev.c

[Qemu-devel] [PULL 24/33] qapi-commands: Don't feed output of mcgen() to mcgen() again

Multiple passes through mcgen() is prone to produce unwanted blank lines, which we then combat by sprinkling .rstrip() on top. Just don't do it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 52

[Qemu-devel] [PULL 22/33] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err'

gen_err_check() hard-codes 'local_err' instead of substituting the argument. Currently harmless, since all callers pass either None or 'local_err'. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 13 +++-- 1

Re: [Qemu-devel] [PATCH 06/17] target-openrisc: Put SR[OVE] in TB flags

On 09/04/2015 06:05 AM, Bastian Koppelmann wrote: On 09/03/2015 02:17 AM, Richard Henderson wrote: { /* Sync the tb dependent flag between translate and runtime. */ -if (dc->tb_flags != dc->synced_flags) { -tcg_gen_movi_tl(env_flags, dc->tb_flags); +if ((dc->tb_flags

[Qemu-devel] [PATCH] checkpatch: Perl 5.22 deprecation fixes

Perl 5.22 has deprecated unescaped { inside a regexp, resulting in warnings: Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\#\s*define.*do\s{ <-- HERE / at scripts/checkpatch.pl line 3523. Unescaped left brace in regex is deprecated, passed through

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

On 4 September 2015 at 15:18, Pavel Fedin wrote: > Hello! > >> I think we need to leave enough space for all of GICC/GICV/GICH >> (that's 2 pages for GICC, 2 for GICV, 1 for GICH). They're optional >> in a GICv3, but we may want them for emulation later on and if we >>

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

On 4 September 2015 at 12:48, Andrew Jones wrote: > Are you also running configure (with the opposite arch selected) after > 'make clean'? If not, then that could be the source of your problems. > Anyway, please describe the issues you're seeing because I don't see > what this

Re: [Qemu-devel] [PATCH v2] target-arm: Break the TB after ISB to execute self-modified code correctly

On 2 September 2015 at 11:03, Sergey Sorokin wrote: > If any store instruction writes the code inside the same TB > after this store insn, the execution of the TB must be stopped > to execute new code correctly. > As described in ARMv8 manual D3.4.6 a self-modified code need

Re: [Qemu-devel] [PATCH 09/17] target-openrisc: Implement ff1 and fl1 for 64-bit

On 09/03/2015 02:17 AM, Richard Henderson wrote: True, this is unused so far, but commented out is worse than actually implemented properly. Signed-off-by: Richard Henderson --- target-openrisc/int_helper.c | 23 --- 1 file changed, 12 insertions(+),

Re: [Qemu-devel] [PATCH RFC v4 31/32] qapi-introspect: Map all integer types to 'int'

On 09/03/2015 08:30 AM, Markus Armbruster wrote: > How many bits we use internally is an implementation detail. It could > be pressed into external interface service as very approximate range > information, but that's probably a bad idea. If we need range > information, we better do it properly.

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

Lluís Vilanova писал 2015-09-04 16:00: Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most.

Re: [Qemu-devel] PING: [PATCH v2 0/2] cpu_arm: Implement irqchip property for ARM CPU

On 4 September 2015 at 07:49, Pavel Fedin wrote: > Hi! This message is mainly for Peter. I say you reviewed my major sets, but > looks like missed this > one. If it is OK, we could apply it, and i could successfully bring back the > missing part in > vGICv3-enabled

[Qemu-devel] [PULL 13/33] tests/qapi-schema: Document events with base don't work

When event FOO's 'data' is a struct with a base, we consider only the struct's direct members, and ignore its base. The generated qapi_event_send_foo() doesn't take arguments for base members. No such events currently exist in the QMP schema. Signed-off-by: Markus Armbruster

  1   2   3   4   >