Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On Sun, 2015-09-06 at 17:48 -0700, Peter Crosthwaite wrote: > On Sun, Sep 6, 2015 at 4:26 PM, Richard Purdie > wrote: > > On Sun, 2015-09-06 at 11:37 -0700, Peter Crosthwaite wrote: > > I tested an assert in _recieve() which confirms it can be called when > >

[Qemu-devel] [PATCH v5 13/14] qmp-commands.hx: Update the supported 'transaction' operations

From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup

[Qemu-devel] [PATCH v5 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v17 07/21] cpu: replay instructions sequence

This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is

[Qemu-devel] [PATCH v17 15/21] bottom halves: introduce bh call function

This patch introduces aio_bh_call function. It is used to execute bottom halves as callbacks without adding them to the queue. Signed-off-by: Pavel Dovgalyuk --- async.c |7 ++- include/block/aio.h |5 + 2 files changed, 11 insertions(+), 1

[Qemu-devel] [PATCH v17 12/21] replay: shutdown event

This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.h |2 ++ replay/replay.c | 14 ++ replay/replay.h |5 + vl.c

[Qemu-devel] [PATCH v17 13/21] icount: improve counting for record/replay

icount_warp_rt function is called by qemu_clock_warp and as callback of icount_warp timer. This patch adds call to qemu_clock_warp into main_loop_wait function, because icount warp may be missed in record/replay mode, when CPU is sleeping. This patch also disables of calling this function by

[Qemu-devel] [FIX PATCH] spapr_drc: Return correct state for logical DR in entity_sense()

When drmgr is run in the guest to add a device for which device_add hasn't been issued in QEMU, configure-connector call fails. When configure-connector call fails, the guest would release (*) the previously acquired DRC by setting back the DRC isolation state to ISOLATED and allocation state to

Re: [Qemu-devel] virtio-1 related entry in 2.4 Changelog, please

On Thu, Sep 03, 2015 at 06:47:55PM +0100, Peter Maydell wrote: > Our changelog for QEMU 2.4 (http://wiki.qemu.org/ChangeLog/2.4) > currently has a line in it saying >" * FIXME: virtio 1" > > Could somebody familiar with the level of our virtio-1 support > in 2.4 please fix this, before

[Qemu-devel] [PATCH v5 12/14] iotests: 124 - transactional failure test

From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP

[Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions

From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

Sai Pavan Boddu writes: > Conditionaly compilation hides few type mismatch warnings, fix it to > compile unconditioinal. > > Signed-off-by: Sai Pavan Boddu > Suggested-by: Eric Blake No objection to this patch, but have you

[Qemu-devel] [PATCH v17 00/21] Deterministic replay core

This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. Core set of patches does not include support for reverse debugging

[Qemu-devel] [PATCH v17 01/21] i386: partial revert of interrupt poll fix

Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c

[Qemu-devel] [PATCH v17 08/21] i386: interrupt poll processing

This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v17 06/21] cpu-exec: allow temporary disabling icount

This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH RFC 1/7] qom: allow properties to be registered against classes

On Fri, Sep 04, 2015 at 11:38:06PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Aug 26, 2015 at 2:03 PM, Daniel P. Berrange > wrote: > > +ObjectProperty * > > +object_class_property_add(ObjectClass *klass, > > + const char *name, > > +

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

Yang Hongyang writes: > Hi Stefan, > > On 09/04/2015 06:32 PM, Stefan Hajnoczi wrote: > [...] >> >> net/queue.c has logic to send/queue/flush packets but a >> qemu_deliver_packet() call is hardcoded. >> >> Maybe you can extend qemu_new_net_queue() like this: >> >> /*

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

CCing the net maintainers on this thread seems like it would be a good idea... On 7 September 2015 at 08:47, Richard Purdie wrote: > On Sun, 2015-09-06 at 17:48 -0700, Peter Crosthwaite wrote: >> This doesn't sound right. There are other network controllers

Re: [Qemu-devel] [PATCH for-2.4] Update language files for QEMU 2.4.0

Michael Tokarev writes: > Applied to -trivial-patches, unfortunately not for 2.4 but at least for 2.5 :) Should we add "Cc: qemu-sta...@nongnu.org" to the commit message?

Re: [Qemu-devel] [PATCH v4 09/14] block: add block job transactions

On Mon, 08/03 20:06, Max Reitz wrote: > > s/who/which/ OK. > > >+ */ > >+return; > >+} > >+txn->aborting = true; > >+/* We are the first failed job. Cancel other jobs. */ > >+QLIST_FOREACH(other_job, >jobs, txn_list) { > >+ctx =

[Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

Conditionaly compilation hides few type mismatch warnings, fix it to compile unconditioinal. Signed-off-by: Sai Pavan Boddu Suggested-by: Eric Blake --- hw/sd/sdhci.c | 36 ++-- 1 file changed, 18 insertions(+), 18

[Qemu-devel] [PATCH v5 03/14] block: rename BlkTransactionState and BdrvActionOps

From: John Snow These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the

[Qemu-devel] [PATCH v5 05/14] blockjob: Introduce reference count

So that block_job_complete_sync can be simplified. Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- blockjob.c | 22 ++ include/block/blockjob.h | 18 +++--- 3 files changed, 30 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function

This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/backup.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/block/backup.c

[Qemu-devel] [PATCH v5 00/14] block: incremental backup transactions using BlockJobTxn

v5: Address comments from Max Reitz: 2.4 -> 2.5 in qapi docs. Don't leak txn object. English syntax fixes. Really leave the "cancelled" status of failed job. Remove a superfluous added line. v4: Address comments from John and Stefan, including: Rename function:

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Monday, September 07, 2015 1:05 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org; crosthwaitepe...@gmail.com; > ebl...@redhat.com; peter.mayd...@linaro.org; Sai Pavan Boddu; Edgar > Iglesias; Alistair

[Qemu-devel] [PATCH v17 04/21] replay: introduce mutex to protect the replay log

This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v17 05/21] replay: introduce icount event

This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v17 18/21] replay: initialization and deinitialization

This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- exec.c |2 + replay/replay-internal.h |

[Qemu-devel] [PATCH v17 10/21] replay: asynchronous events infrastructure

This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [PATCH v17 17/21] typedef: add typedef for QemuOpts

This patch moves typedefs for QemuOpts and related types to qemu/typedefs.h file. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- include/qemu/option.h |5 + include/qemu/typedefs.h |3 +++ 2 files changed, 4

Re: [Qemu-devel] [PATCH V3 2/2] sdhci: Change debug prints to compile unconditionally

Sai Pavan Boddu writes: >> -Original Message- >> From: Markus Armbruster [mailto:arm...@redhat.com] >> Sent: Monday, September 07, 2015 1:05 PM >> To: Sai Pavan Boddu >> Cc: qemu-devel@nongnu.org; crosthwaitepe...@gmail.com; >> ebl...@redhat.com;

Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix

On 09/06/2015 10:25 PM, Andreas Färber wrote: Am 02.09.2015 um 21:58 schrieb Eduardo Habkost: Ping? Andreas, should this go through your QOM tree? Long-term I would prefer a separate machine maintainer (Marcel?) Hi Andreas, I can be the machine maintainer, sure. I should start maintaining

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

On 04/09/15 18:21, Stefan Hajnoczi wrote: > From: P J P > > While processing transmit descriptors, it could lead to an infinite > loop if 'bytes' was to become zero; Add a check to avoid it. > > [The guest can force 'bytes' to 0 by setting the hdr_len and mss >

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

On Mon, Sep 07, 2015 at 03:37:20PM +0800, Yang Hongyang wrote: > Hi Stefan, > > On 09/04/2015 06:32 PM, Stefan Hajnoczi wrote: > [...] > > > >net/queue.c has logic to send/queue/flush packets but a > >qemu_deliver_packet() call is hardcoded. > > > >Maybe you can extend qemu_new_net_queue() like

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

On 09/07/2015 05:06 PM, Markus Armbruster wrote: Yang Hongyang writes: Hi Stefan, On 09/04/2015 06:32 PM, Stefan Hajnoczi wrote: [...] net/queue.c has logic to send/queue/flush packets but a qemu_deliver_packet() call is hardcoded. Maybe you can extend

Re: [Qemu-devel] [PATCH] add macro file for coccinelle

On 7 September 2015 at 08:51, Paolo Bonzini wrote: > Coccinelle chokes on some idioms from compiler.h and queue.h. > Extract those in a macro file, to be used with "--macro-file > scripts/cocci-macro-file.h". Can we put the "how to use this" instructions in the file itself

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/11] aio: Introduce handler type to fix nested aio_poll for dataplane

On Fri, 08/28 12:53, Stefan Hajnoczi wrote: > On Wed, Jul 29, 2015 at 12:42:03PM +0800, Fam Zheng wrote: > > v2: Switch to disable/enable model. [Paolo] > > > > Most existing nested aio_poll()'s in block layer are inconsiderate of > > dispatching potential new r/w requests from ioeventfds and nbd

Re: [Qemu-devel] [PATCH v4 11/14] block/backup: support block job transactions

On Mon, 08/03 20:26, Max Reitz wrote: > On 30.07.2015 08:39, Fam Zheng wrote: > >From: Stefan Hajnoczi > > > >Join the transaction when the 'transactional-cancel' QMP argument is > >true. > > > >This ensures that the sync bitmap is not thrown away if another block > >job in

Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

Eric Blake writes: > On 09/05/2015 07:25 AM, Eric Blake wrote: >>> >>> Oh, and tests/qapi-schema/test-qapi.py is annoying - even when it exits >>> non-zero, it does NOT cause a failure in 'make check-qapi-schema'. >> >> Rather, it does not leave an obvious stack trace or

Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects.

Eric Blake writes: > We have a few fields that exist mainly to hold information from > __init__() until check() (matching the fact that parsing is > two-pass; the first to find type names, the second to associate > types together while honoring forward references), or which

Re: [Qemu-devel] [PATCH RFC v4 05/32] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

Eric Blake writes: > On 09/03/2015 08:29 AM, Markus Armbruster wrote: >> The old code prints the result of parsing (list of expression >> dictionaries), and partial results of semantic analysis (list of enum >> dictionaries, list of struct dictionaries). >> >> The new code

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On Sun, 2015-09-06 at 17:48 -0700, Peter Crosthwaite wrote: > On Sun, Sep 6, 2015 at 4:26 PM, Richard Purdie > wrote: > > On Sun, 2015-09-06 at 11:37 -0700, Peter Crosthwaite wrote: > > It seems can_receive isn't enough, we'd need to put some checks into > >

[Qemu-devel] [PATCH v5 02/14] iotests: add transactional incremental backup test

From: John Snow Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan

[Qemu-devel] [PATCH v17 09/21] replay: interrupts and exceptions

This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v17 16/21] replay: ptimer

This patch adds deterministic replay for hardware periodic countdown timers. ptimer uses bottom halves layer to execute such an asynchronous callback. We put this callback into the replay queue instead of bottom halves one. When checkpoint is met by main loop thread, the replay queue is processed

[Qemu-devel] [PATCH v17 21/21] replay: recording of the user input

This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 33 +

Re: [Qemu-devel] virtio-1 related entry in 2.4 Changelog, please

On 7 September 2015 at 08:30, Michael S. Tsirkin wrote: > I seem to have lost the wiki login/password. Looking at the userlist I suspect you didn't have an account. Let me know what username you'd like and I'll create one for you. thanks -- PMM

Re: [Qemu-devel] typofixes

Michael Tokarev writes: > 11.08.2015 00:42, Veres Lajos wrote: >> On Sun, 9 Aug 2015, Veres Lajos wrote: >> >>> Hi, >>> >>> Please find attached a couple of typo fixes, mostly in comments/docs. >>> I hope it meets the trivial criteria... > > Now that's a bunch of typos ;) > >

[Qemu-devel] [PATCH V3 1/2] sdhci: use PRIx64 for uint64_t type

Fix compile time warnings, because of type mismatch for unsigned long long type. Signed-off-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite --- Changes for V3: Same as V2. Changes for V2: Fix commit message. Correct line lenght.

[Qemu-devel] [PATCH v5 08/14] blockjob: Simplify block_job_finish_sync

With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng --- blockjob.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/blockjob.c b/blockjob.c index 293b62a..36c18e0 100644 --- a/blockjob.c +++

[Qemu-devel] [PATCH v5 01/14] qapi: Add transaction support to block-dirty-bitmap operations

From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were

[Qemu-devel] [PATCH v5 06/14] blockjob: Add .commit and .abort block job actions

Signed-off-by: Fam Zheng --- include/block/blockjob.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 3e7ad21..a7b497c 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@ -50,6

[Qemu-devel] [PATCH v5 07/14] blockjob: Add "completed" and "ret" in BlockJob

They are set when block_job_completed is called. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) diff --git a/blockjob.c b/blockjob.c index

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

On Sun, 2015-09-06 at 17:48 -0700, Peter Crosthwaite wrote: > This doesn't sound right. There are other network controllers that > rely of can_receive catching all cases properly. Is this a regression? > Looking at logs, I see some refactoring of QEMU net framework around > June timeframe, if you

Re: [Qemu-devel] [PATCH v2 2/2] block: add a 'blockdev-snapshot' QMP command

On Fri 04 Sep 2015 04:42:17 PM CEST, Eric Blake wrote: >> @@ -1183,6 +1183,18 @@ void qmp_blockdev_snapshot_sync(bool has_device, >> const char *device, >> , errp); >> } >> >> +void qmp_blockdev_snapshot(const char *device, const char *snapshot, > >

[Qemu-devel] [PATCH v17 19/21] replay: replay blockers for devices

Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk --- hw/bt/hci.c |7 +++

[Qemu-devel] [PATCH v17 20/21] replay: command line options

This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for specifying the filename for replay log. Signed-off-by:

Re: [Qemu-devel] [PATCH] configure: Require Python 2.6

On Fri, Sep 04, 2015 at 09:53:03PM +0200, Markus Armbruster wrote: > RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back > to 10.6. > > Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrange Regards, Daniel -- |:

Re: [Qemu-devel] [PULL 00/27] target-arm queue

On 4 September 2015 at 16:05, Peter Maydell wrote: > Another target-arm queue flush. I expect there'll be another > lot next week... > > > The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v4 01/14] qapi: Add transaction support to block-dirty-bitmap operations

On Mon, 08/03 18:49, Max Reitz wrote: > *2.5, and keep my R-b. Sure! Thanks. Fam

Re: [Qemu-devel] [PATCH v2 00/49] audio: -audiodev option, multiple options

"Kővágó Zoltán" writes: > 2015-09-03 17:07 keltezéssel, Eric Blake írta: >> On 09/03/2015 04:15 AM, Gerd Hoffmann wrote: >>> On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote: This patch series adds support to multiple audio backends. Afterwards I add

[Qemu-devel] [PATCH] add macro file for coccinelle

Coccinelle chokes on some idioms from compiler.h and queue.h. Extract those in a macro file, to be used with "--macro-file scripts/cocci-macro-file.h". Signed-off-by: Paolo Bonzini --- scripts/cocci-macro-file.h | 110 + 1 file

[Qemu-devel] [PATCH v17 11/21] replay: recording and replaying clock ticks

Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log and transfered to the module, which wants to read

Re: [Qemu-devel] [PATCH] configure: Require Python 2.6

On Fri, Sep 04, 2015 at 11:44:17PM +0100, Peter Maydell wrote: > On 4 September 2015 at 20:53, Markus Armbruster wrote: > > RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back > > to 10.6. > > > > Signed-off-by: Markus Armbruster > >

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

On 09/07/2015 05:11 PM, Stefan Hajnoczi wrote: On Mon, Sep 07, 2015 at 03:37:20PM +0800, Yang Hongyang wrote: Hi Stefan, On 09/04/2015 06:32 PM, Stefan Hajnoczi wrote: [...] net/queue.c has logic to send/queue/flush packets but a qemu_deliver_packet() call is hardcoded. Maybe you can extend

Re: [Qemu-devel] [PATCH v4 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

On Mon, 08/03 20:13, Max Reitz wrote: > On 30.07.2015 08:39, Fam Zheng wrote: > >From: Stefan Hajnoczi > > > >Provide a BlockJobTxn to actions executed in a qmp 'transaction' > >command. This allows actions to make their block jobs either complete > >as a group or

Re: [Qemu-devel] [PATCH v4 14/14] tests: add BlockJobTxn unit test

On Mon, 08/03 20:45, Max Reitz wrote: > >+static void test_single_job(int expected) > >+{ > >+BlockJob *job; > >+BlockJobTxn *txn; > >+int result = -EINPROGRESS; > >+ > >+txn = block_job_txn_new(); > >+job = test_block_job_start(1, true, expected, ); > > I think I'd like it

[Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the implementation which is

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

On 09/02/2015 07:06 PM, Cornelia Huck wrote: > On Wed, 2 Sep 2015 11:25:21 +0800 > Jason Wang wrote: > >> We don't migrate the followings fields for virtio-pci: >> >> uint32_t dfselect; >> uint32_t gfselect; >> uint32_t guest_features[2]; >> struct { >> uint16_t num;

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

Hi Stefan, On 09/04/2015 06:32 PM, Stefan Hajnoczi wrote: [...] net/queue.c has logic to send/queue/flush packets but a qemu_deliver_packet() call is hardcoded. Maybe you can extend qemu_new_net_queue() like this: /* Returns: * >0 - success *0 - queue packet for future redelivery

[Qemu-devel] [PATCH v5 14/14] tests: add BlockJobTxn unit test

From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

On Mon, 7 Sep 2015 15:39:59 +0800 Jason Wang wrote: > On 09/02/2015 07:06 PM, Cornelia Huck wrote: > > On Wed, 2 Sep 2015 11:25:21 +0800 > > Jason Wang wrote: > >> +static int get_extra_state(QEMUFile *f, void *pv, size_t size) > >> +{ > >> +

[Qemu-devel] [PATCH v17 14/21] replay: checkpoints

This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- cpus.c |5 + qemu-timer.c | 40

[Qemu-devel] [PATCH v17 03/21] replay: internal functions for replay log

This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 155

[Qemu-devel] [PATCH v17 02/21] replay: global variables and function stubs

This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Pavel Dovgalyuk ---

Re: [Qemu-devel] [PATCH v2] configure: factor out adding disas configure

On 7 September 2015 at 06:12, Peter Crosthwaite wrote: > Ping! ...you need to find somebody who thinks this should go via their tree. Paolo? thanks -- PMM

Re: [Qemu-devel] [Qemu-ppc] [PATCH 19/19] ppc: Rename ELF_MACHINE to be PPC specific

On 07.09.15 07:04, Peter Crosthwaite wrote: > On Tue, Aug 18, 2015 at 6:04 PM, Laurent Vivier wrote: >> I'm wondering if the existing behavior is good: >> >> what I have understood is we define ppc32 guests in ppc64 target to be >> able to run 32bit guest with 64bit qemu,

[Qemu-devel] [PULL 00/27] target-arm queue

' into staging (2015-09-04 17:37:50 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20150907 for you to fetch changes up to 8d45c54d4fd3612bd616afcc5c278394f312927b: arm/virt: Add full-sized CPU affinity handling (2015-09-07 10:39:31

[Qemu-devel] [PATCH 0/4] ipxe update

Hi, Here finaklly comes the ipxe update which makes things fly on efi. Submodule update, two small build tweaks, binary update. please review, Gerd Gerd Hoffmann (4): ipxe: update from 35c53797 to 4e03af8 ipxe: don't override GITVERSION ipxe: use upstream configuration ipxe: update

[Qemu-devel] [PATCH 2/4] ipxe: don't override GITVERSION

We had build problems due to the git version checking in the ipxe build system in the past. Don't remember the details, but the problem seems to be gone now, so lets remove the workaround. Signed-off-by: Gerd Hoffmann [ most likely ipxe commit

[Qemu-devel] [PATCH 3/4] ipxe: use upstream configuration

Upstream supports named configurations now and ships with settings for qemu. Use them, drop our config header copying. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 11 --- roms/config.ipxe.general.h | 4 2 files changed, 4 insertions(+), 11

[Qemu-devel] [PATCH RFC v5 12/32] qapi-commands: Convert to QAPISchemaVisitor

Output unchanged apart from reordering and white-space. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 159 +++ scripts/qapi.py | 2 +- 2 files changed, 91

[Qemu-devel] [PATCH RFC v5 11/32] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

Fixes flat unions to visit the base's base members (the previous commit merely added them to the struct). Same test case. Patch's effect on visit_type_UserDefFlatUnion(): static void visit_type_UserDefFlatUnion_fields(Visitor *m, UserDefFlatUnion **obj, Error **errp) { Error

[Qemu-devel] [PATCH RFC v5 23/32] qapi: De-duplicate parameter list generation

Generated qapi-event.[ch] lose line breaks. No change otherwise. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 11 ++- scripts/qapi-event.py| 18 +++--- scripts/qapi.py | 16

[Qemu-devel] [PATCH RFC v5 13/32] qapi: De-duplicate enum code generation

Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but that's no excuse. Move the helpers from qapi-types.py to qapi.py, and replace the duplicates in qapi-event.py. The generated event enumeration type's lookup table becomes const-correct (see commit 2e4450f), and uses explicit

[Qemu-devel] [PATCH RFC v5 22/32] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO()

These functions marshal both input and output. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt| 4 +- docs/writing-qmp-commands.txt | 8 +- monitor.c | 2 +- qmp-commands.hx

[Qemu-devel] [PATCH RFC v5 16/32] qapi: Generate comments to simplify splitting for review

The effect of the previous few patches on generated files is hard to review, because stuff gets generated in different order, which renders diffs of the generated files useless. To get reviewable diffs, we need to split the generated files into suitable parts: put every top-level declaration in a

[Qemu-devel] [PATCH 2/2] pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines

it will prevent guests on old machines from seeing inconsistent memory mapping in firmware/ACPI views. Signed-off-by: Igor Mammedov --- PS: this patch probably clashes with Eduardo's pc_compat refactoring, so I've split it from main fix, if applied via Eduardo's it

[Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end

reserved-memory-end tells firmware address from which it could start treating memory as PCI address space and map PCI BARs after it to avoid collisions with RAM. Currently it is incorrectly pointing to address where hotplugged memory range starts which could redirect hotplugged RAM accesses to PCI

[Qemu-devel] [PATCH 0/2] pc: fix 64-bit PCI window clashing with memory hotplug region

Igor Mammedov (2): pc: memhotplug: fix incorrectly set reserved-memory-end pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines hw/i386/pc.c | 8 +++- hw/i386/pc_piix.c| 2 ++ hw/i386/pc_q35.c | 2 ++ include/hw/i386/pc.h | 1 + 4 files

[Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union

Changes the NumaOptions to flat union from a simple one. This is required by my later OptsVisitor patch to preserve backward compatibility. Strictly speaking this would break QMP compatibility (as specified in docs/qapi-code-gen.txt), but since no QMP command use this structure, it's not an

[Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor

They are required for flat unions (you still have to allocate the structs). Signed-off-by: Kővágó, Zoltán --- qapi/opts-visitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7ae33b3..aa68814 100644

[Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option

As discussed here[1], I'm splitting the qapi related patches from my previous -audiodev patch series. These are patches 2--7 and 9 from my previous patches. (Patch 1 was merged into -trivial in the meanwhile.) Please review. [1]:

Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

On 28/08/2015 01:55, Michael Roth wrote: > Now we can build qemu-ga MSI package with: > ./configure ... > make qemu-ga.exe > make msi > > or simply: > ./configure ... > make msi Shouldn't the latter have always worked? I think that if someone does "make qemu-ga.exe" they should

[Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union

Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netdev/g' \ -e

[Qemu-devel] [PATCH RFC v5 14/32] qapi-event: Eliminate global variable event_enum_value

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-event.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py index aed45d6..537da17 100644 --- a/scripts/qapi-event.py

Re: [Qemu-devel] [PATCH RFC 1/7] qom: allow properties to be registered against classes

On 04/09/2015 08:56, Markus Armbruster wrote: >> > >> > Personally I'd prefer to see us focus on just solving the simple >> > cases first, so we don't end up stuck arguing over the hard >> > cases and holding up potential quick wins ! > That's a sensible approach when the solutions to the simple

[Qemu-devel] [PATCH 0/4] updates to coding style and checkpatch

The first two patches are a resend of a previous proposal sent to qemu-devel. The last two are new. Paolo Paolo Bonzini (4): CODING_STYLE: update mixed declaration rules CODING_STYLE, checkpatch: update line length rules checkpatch: adapt some tests to QEMU checkpatch: remove tests that

  1   2   3   4   >