[Qemu-devel] [PULL v1 09/21] moxie: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The bootloader can just pass EM_MOXIE directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Anthony Green Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v1 09/15] core: Convert tcg_enabled() uses to any/all variants

2015-09-11 Thread Peter Crosthwaite
Convert core code usages of tcg_enabled() which don't have a specific CPU associated with, to either tcg_any_enabled() or tcg_all_enabled(). This is to prepare support for multiple tcg engines, where queries must query a specific CPU or use global any/all logic. Signed-off-by: Peter Crosthwaite

Re: [Qemu-devel] Aspirant for AMD IOMMU emulation project for Outreachy

2015-09-11 Thread Jan Kiszka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2015-09-11 08:50, Jan Kiszka wrote: > Hi Rita, > > [CC'ing Andrew due to overlap with split irqchip topic] > > On 2015-09-09 19:41, Rita Sinha wrote: >> Hi Jan, >> >>> >>> Most likely than not you'll work on the Intel IOMMU and I would >>>

Re: [Qemu-devel] [PATCH RFC v5 00/32] qapi: QMP introspection

2015-09-11 Thread Markus Armbruster
I think I'm almost ready for non-RFC v6, just one more problem: my tests caught a bug related to QOM and the 'any' type. Working on it. See my cry for QOM help "Re: Confused by QOM: /machine/unattached/device[5]/dr-connector[255]/fdt".

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-11 Thread Markus Armbruster
Programmingkid writes: > On Sep 10, 2015, at 1:15 PM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> On Sep 10, 2015, at 3:21 AM, Markus Armbruster wrote: >>> Programmingkid writes: >

[Qemu-devel] [PATCH v1 00/15] Multi-Arch Phase 1

2015-09-11 Thread Peter Crosthwaite
This is the first set of patches needed to enable Multi-arch system emulation. For full context refer to RFCv3: [PATCH v3 00/35] Multi Architecture System Emulation https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03929.html This is the first patch-pack intended for merge. Original

[Qemu-devel] [PULL v1 14/21] xtensa: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The bootloaders can just pass EM_XTENSA directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Max Filippov Reviewed-by: Richard Henderson

[Qemu-devel] [PULL v1 02/21] linux-user: elfload: Provide default for elf_check_arch

2015-09-11 Thread Peter Crosthwaite
For many arch's this macro is defined as the predicatable behaviour of checking the argument for eqaulity against ELF_ARCH. Provide a default define as such, so only archs with special handling (usually allowing multiple EM values) need to provide a def. Arches that do any of: 1: provide this

Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-11 Thread Markus Armbruster
Michael Roth writes: > Quoting Markus Armbruster (2015-09-07 05:16:41) >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. >> >> The introspection schema does not reflect all

Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC 0/4] Mac OS 9 compatibility improvements

2015-09-11 Thread Stewart Smith
Mark Cave-Ayland writes: > I can confirm here that in combination with an updated OpenBIOS then the > patchset gets qemu-system-ppc -M mac99 to the OS 9 loading screen, which > is great progress! > > When booting OS 9 with this patchset I do see the following output

[Qemu-devel] [PATCH v1 14/15] cpu-common: Define tb_page_addr_t for everyone

2015-09-11 Thread Peter Crosthwaite
In system mode emulation (at least) this definition has no architecture specific dependencies. Move it to common code such that common code can use it (primarily for defining function prototypes). Signed-off-by: Peter Crosthwaite --- So this is the same as in RFCv2

[Qemu-devel] [PULL v1 10/21] unicore: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. This removes another architecture specific definition from the global namespace. Cc: Guan Xuetao

Re: [Qemu-devel] [RFC PATCH v1 00/25] error: Automatic error concatenation and prefixing

2015-09-11 Thread Markus Armbruster
Quick initial high-level feedback, since I'm afraid real review will take a while (series is long, and I'm still swamped). Peter Crosthwaite writes: > Hi Markus and all, > > This patch series adds support for automatically concatenating multiple > errors to the one

[Qemu-devel] [PULL v1 13/21] tricore: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The bootloader can just pass EM_TRICORE directly, as that is architecture specific code. This removes another architecture specific definition from the global namespace. Cc: Bastian Koppelmann Acked-By:

[Qemu-devel] [PULL v1 12/21] or32: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The bootloader can just pass EM_OPENRISC directly, as that is architecture specific code. This

[Qemu-devel] [PULL v1 00/21] Multi-arch queue

2015-09-11 Thread Peter Crosthwaite
Flush of multi-arch pre-requisite work. multi-arch queue: * add EM_MOXIE * Cleanup ELF_MACHINE and remove from cpu.h The following changes since commit 9d34158a5af734e8de0b42b0a7228200c426a8d0: Merge

[Qemu-devel] [PULL v1 18/21] mips: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The bootloaders can just pass EM_MIPS directly, as that is architecture specific code. This

[Qemu-devel] [PULL v1 15/21] sh4: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. This removes another architecture specific definition from the global namespace. Cc: Aurelien

[Qemu-devel] [PATCH] docs: update the usage example of "dtrace" backend in tracing.txt

2015-09-11 Thread Lin Ma
The usage example of dtrace is quite ancient, We have tracetool.py with different parameters instead of the original tracetool shell script for a long time, So update the old information. Signed-off-by: Lin Ma --- docs/tracing.txt | 10 +- 1 file changed, 5 insertions(+),

[Qemu-devel] [PATCH v1 10/15] exec-all: Move cpu_can_do_io() to qom/cpu.h

2015-09-11 Thread Peter Crosthwaite
This function has no architecture specific dependencies and should be callable from core code. Move it to qom/cpu.h. Reviewed-by: Richard Henderson Signed-off-by: Peter Crosthwaite --- include/qom/cpu.h | 21 + 1 file changed,

[Qemu-devel] [PULL v1 19/21] alpha: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite ELF_MACHINE is unused by target alpha. Cc: Richard Henderson Reviewed-by: Richard Henderson Acked-By: Riku Voipio Signed-off-by: Peter Crosthwaite ---

Re: [Qemu-devel] [PATCH v17 00/21] Deterministic replay core

2015-09-11 Thread Pavel Dovgaluk
Paolo, Are these patches good enough? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Monday, September 07, 2015 11:40 AM > To: qemu-devel@nongnu.org > Cc: edgar.igles...@xilinx.com; peter.mayd...@linaro.org; >

Re: [Qemu-devel] [PATCH v17 00/21] Deterministic replay core

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 07:52, Pavel Dovgaluk wrote: > Paolo, > > Are these patches good enough? Haven't reviewed them as I already have a 50 patch queue. I will look at them next week. I can already tell you that I'd like some comments in front of clock warp calls, but that can be added as a follow

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-11 Thread Michael Tokarev
09.09.2015 19:28, John Snow wrote: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command execution table to remove CD_OK permissions > from commands that are not and have never been ATAPI commands. FWIW, this issue has been assigned CVE-2015-6855

[Qemu-devel] [PULL v1 07/21] m68k: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The machine model bootloaders can just pass EM_68K directly, as that is architecture specific code.

[Qemu-devel] [PATCH] iscsi: Add chap and "initiator-name" etc as per drive options

2015-09-11 Thread Fam Zheng
Previously we use "-iscsi id=target-iqn,user=foo,password=bar,..." to specify iscsi connection parameters, unfortunately it doesn't work with qemu-img. This patch adds per drive options to iscsi driver so that at least qemu-img can use the "json:{...}" filename magic. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v1 12/15] cputlb: Change tlb_set_dirty() arg to cpu

2015-09-11 Thread Peter Crosthwaite
Change tlb_set_dirty() to accept a CPU instead of an env pointer. This allows for removal of another CPUArchState usage from prototypes that need to be QOMified. Signed-off-by: Peter Crosthwaite --- cputlb.c | 3 ++- exec.c| 3 +--

[Qemu-devel] [PULL v1 21/21] ppc: Rename ELF_MACHINE to be PPC specific

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Rename ELF_MACHINE to be PPC specific. This is used as-is by the various PPC bootloaders and is locally defined to ELF_MACHINE in linux user in PPC specific ifdeffery. This removes another architecture specific definition from the global

[Qemu-devel] [PULL v1 08/21] cris: Remove ELF_MACHINE from cpu.h

2015-09-11 Thread Peter Crosthwaite
From: Peter Crosthwaite The only generic code relying on this is linux-user, but linux users' default behaviour of defaulting ELF_MACHINE to ELF_ARCH will handle this. The bootloader can just pass EM_CRIS directly, as that is architecture specific code. This removes

Re: [Qemu-devel] Aspirant for AMD IOMMU emulation project for Outreachy

2015-09-11 Thread Jan Kiszka
Hi Rita, [CC'ing Andrew due to overlap with split irqchip topic] On 2015-09-09 19:41, Rita Sinha wrote: > Hi Jan, > >> >> Most likely than not you'll work on the Intel IOMMU and I would >> suggest, if you wish to get your feet dirty, just start right away >> with the Intel IOMMU (In which case

Re: [Qemu-devel] [PATCH PULL 02/11] tests: remove repetition in unit test object deps

2015-09-11 Thread Eric Blake
On 09/11/2015 06:10 AM, Daniel P. Berrange wrote: > Most of the unit tests have identical sets of object deps. > For example all block unit tests need to depend on > > $(block-obj-y) libqemuutil.a libqemustub.a > > Currently each unit test repeats this list of test deps. > This list of deps

Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent

2015-09-11 Thread Marc-André Lureau
Hi On Wed, Sep 9, 2015 at 11:53 PM, Michael Roth wrote: > Quoting marcandre.lur...@redhat.com (2015-08-27 05:52:07) >> From: Marc-André Lureau >> >> Add some local guest agent tests (as it is better than nothing). >> >> They can be run

Re: [Qemu-devel] [PATCH v5 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > From: Stefan Hajnoczi > > Provide a BlockJobTxn to actions executed in a qmp 'transaction' > command. This allows actions to make their block jobs either complete > as a group or fail/cancel together. > > The next patch adds the

Re: [Qemu-devel] [PATCH RFC 1/7] qom: allow properties to be registered against classes

2015-09-11 Thread Daniel P. Berrange
On Wed, Sep 02, 2015 at 06:18:28PM +0200, Andreas Färber wrote: > Am 26.08.2015 um 14:03 schrieb Daniel P. Berrange: > > When there are many instances of a given class, registering > > properties against the instance is wasteful of resources. The > > majority of objects have a statically defined

Re: [Qemu-devel] [PATCH v14 2/5] intc/gic: Extract some reusable vGIC code

2015-09-11 Thread Peter Maydell
On 9 September 2015 at 08:49, Pavel Fedin wrote: > Some functions previously used only by vGICv2 are useful also for vGICv3 > implementation. Untie them from GICState and make accessible from within > other modules: > - kvm_arm_gic_set_irq() > - kvm_gic_supports_attr() -

Re: [Qemu-devel] [PATCH v3 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-11 Thread Max Reitz
On 10.09.2015 15:39, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing options

Re: [Qemu-devel] [PATCH v4 0/3] i.MX: Add GPIO devices to i.MX SOC

2015-09-11 Thread Peter Maydell
On 9 September 2015 at 21:08, Jean-Christophe Dubois wrote: > Add GPIO devices to i.MX31 and i.MX25 SOC > > Jean-Christophe Dubois (3): > i.MX: Add GPIO device > i.MX: Add GPIO devices to i.MX31 SOC > i.MX: Add GPIO devices to i.MX25 SOC > Applied to

Re: [Qemu-devel] [PATCH PULL 00/11] Extract TLS handling code from VNC server

2015-09-11 Thread Eric Blake
On 09/11/2015 07:09 AM, Daniel P. Berrange wrote: >> Apologies for not (re-)reviewing sooner, but I have comments on (at >> least) patch 1, so I'm not sure this series should be merged just yet. > > Ok, please make sure you re-review this series, and not the earlier > v6 posting, as a few things

Re: [Qemu-devel] [PATCH] qcow2: Make qcow2_alloc_bytes() more explicit

2015-09-11 Thread Kevin Wolf
Am 11.09.2015 um 18:47 hat Max Reitz geschrieben: > In case of -EAGAIN returned by update_refcount(), we should discard the > cluster offset we were trying to allocate and request a new one, because > in theory that old offset might now be taken by a refcount block. > > In practice, this was not

Re: [Qemu-devel] [PATCH v5 07/14] blockjob: Add "completed" and "ret" in BlockJob

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > They are set when block_job_completed is called. > > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > blockjob.c | 3 +++ > include/block/blockjob.h | 9 + > 2 files changed, 12

Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Remove unnecessary brackets around error messages

2015-09-11 Thread Alistair Francis
On Fri, Sep 11, 2015 at 8:36 AM, Peter Maydell wrote: > On 9 September 2015 at 01:32, Alistair Francis > wrote: >> The errp and err variable have unnecessary brackets around them, >> so remove the brackets. >> >> Signed-off-by: Alistair

[Qemu-devel] [PULL 2/4] softmmu: add helper function to pass through retaddr

2015-09-11 Thread Richard Henderson
From: Pavel Dovgalyuk This patch introduces several helpers to pass return address which points to the TB. Correct return address allows correct restoring of the guest PC and icount. These functions should be used when helpers embedded into TB invoke memory operations.

Re: [Qemu-devel] [PATCH v3 1/4] block: rename BlockdevSnapshot to BlockdevSnapshotSync

2015-09-11 Thread Max Reitz
On 10.09.2015 15:39, Alberto Garcia wrote: > We will introduce the 'blockdev-snapshot' command that will require > its own struct for the parameters, so we need to rename this one in > order to avoid name clashes. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v3 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-11 Thread Eric Blake
On 09/10/2015 07:39 AM, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing

Re: [Qemu-devel] [PATCH v5 05/14] blockjob: Introduce reference count

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > So that block_job_complete_sync can be simplified. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 2 +- > blockjob.c | 22 ++ > include/block/blockjob.h | 18 +++--- > 3

Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [RFC PATCH v1 05/25] error: Add error prefix API

2015-09-11 Thread Eric Blake
On 09/10/2015 11:33 PM, Peter Crosthwaite wrote: > Add an API to prefix an already set error with a caller-centric > message. > > If multiple errors are set, all are prefixed individually. > Might be nice to rebase your series to add this first, prior to multi-error support. (That is, while

[Qemu-devel] [PULL 3/4] softmmu: remove now unused functions

2015-09-11 Thread Richard Henderson
From: Pavel Dovgalyuk Now that the cpu_ld/st_* function directly call helper_ret_ld/st, we can drop the old helper_ld/st functions. Reviewed-by: Aurelien Jarno Signed-off-by: Pavel Dovgalyuk Message-Id:

Re: [Qemu-devel] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat

2015-09-11 Thread Max Reitz
On 11.09.2015 19:28, Kevin Wolf wrote: > Am 11.09.2015 um 19:21 hat Max Reitz geschrieben: >> On 10.09.2015 15:39, Alberto Garcia wrote: >>> If set to true, the image will be opened with the BDRV_O_NO_BACKING >>> flag. This is useful for creating snapshots using images opened with >>>

Re: [Qemu-devel] [PATCH v3 4/4] block: add tests for the 'blockdev-snapshot' command

2015-09-11 Thread Eric Blake
On 09/10/2015 07:39 AM, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/085 | 97 > +++--- > tests/qemu-iotests/085.out | 34 +++- > 2 files changed, 123 insertions(+), 8 deletions(-) >

[Qemu-devel] [PULL 0/4] Queued tcg related patches

2015-09-11 Thread Richard Henderson
-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2015-09-11' into staging (2015-09-11 12:07:29 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20150911 for you to fetch changes up to 1c3c8af1fb40a481c07749e0448644d9b7700415: cpu-exec

Re: [Qemu-devel] [PATCH v2 0/4] scripts/qemu-gdb: Split into modules

2015-09-11 Thread Peter Maydell
On 2 September 2015 at 15:05, Stefan Hajnoczi wrote: > On Fri, Aug 14, 2015 at 06:46:28PM +0100, Peter Maydell wrote: >> This patch series splits scripts/qemu-gdb into separate >> files for each command, to make it easier to add new >> commands in future without them all

Re: [Qemu-devel] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat

2015-09-11 Thread Eric Blake
On 09/10/2015 07:39 AM, Alberto Garcia wrote: > If set to true, the image will be opened with the BDRV_O_NO_BACKING > flag. This is useful for creating snapshots using images opened with > blockdev-add, since they are not supposed to have a backing image > before the operation. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. > > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/backup.c | 26 -- > 1 file changed, 16 insertions(+), 10

Re: [Qemu-devel] [RFC PATCH] spapr: Reduce creation of LMB DR connectors from O(n^3) to O(n^2)

2015-09-11 Thread Bharata B Rao
On Thu, Sep 10, 2015 at 04:28:25PM +1000, David Gibson wrote: > The dynamic reconfiguration (hotplug) code for the pseries machine type > uses a "DR connector" QOM object for each resource it will be possible > to hotplug. Each of these is added to its owner using >

Re: [Qemu-devel] [PATCH v4 29/38] blockdev: Add blockdev-insert-medium

2015-09-11 Thread Max Reitz
On 11.09.2015 09:30, Wen Congyang wrote: > On 09/11/2015 03:09 AM, Max Reitz wrote: >> On 10.09.2015 03:12, Wen Congyang wrote: >>> On 09/09/2015 08:59 PM, Max Reitz wrote: On 09.09.2015 12:01, Wen Congyang wrote: > On 09/09/2015 05:20 AM, Max Reitz wrote: >> On 08.09.2015 11:13, Wen

Re: [Qemu-devel] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat

2015-09-11 Thread Max Reitz
On 10.09.2015 15:39, Alberto Garcia wrote: > If set to true, the image will be opened with the BDRV_O_NO_BACKING > flag. This is useful for creating snapshots using images opened with > blockdev-add, since they are not supposed to have a backing image > before the operation. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 2/4] block: Add 'ignore-backing' field to BlockdevOptionsGenericCOWFormat

2015-09-11 Thread Kevin Wolf
Am 11.09.2015 um 19:21 hat Max Reitz geschrieben: > On 10.09.2015 15:39, Alberto Garcia wrote: > > If set to true, the image will be opened with the BDRV_O_NO_BACKING > > flag. This is useful for creating snapshots using images opened with > > blockdev-add, since they are not supposed to have a

Re: [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages

2015-09-11 Thread Michael Tokarev
08.09.2015 23:29, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > docs/specs/vhost-user.txt | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v1 00/15] Multi-Arch Phase 1

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 07:39, Peter Crosthwaite wrote: > This is the first set of patches needed to enable Multi-arch system > emulation. For full context refer to RFCv3: > > [PATCH v3 00/35] Multi Architecture System Emulation > https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03929.html > >

Re: [Qemu-devel] [PATCH 2/6] hw/virtio/virtio-balloon: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
12.05.2015 05:25, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/virtio/virtio-balloon.c | 5 - > 1 file changed, 5 deletions(-) > >

Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-11 Thread Daniel P. Berrange
On Fri, Sep 11, 2015 at 09:02:15AM +0200, Markus Armbruster wrote: > Michael Roth writes: > > > Quoting Markus Armbruster (2015-09-07 05:16:41) > >> A new test-qmp-input-visitor test case feeds its result for both > >> tests/qapi-schema/qapi-schema-test.json and

Re: [Qemu-devel] [PATCH v1 10/15] exec-all: Move cpu_can_do_io() to qom/cpu.h

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 07:39, Peter Crosthwaite wrote: > This function has no architecture specific dependencies and should be > callable from core code. It also does not exist anymore. :-P Paolo

Re: [Qemu-devel] [PATCH] imx_serial: Generate interrupt on tx empty if enabled

2015-09-11 Thread Michael Tokarev
Can we please have some r-b or ACK for this? :) 20.08.2015 18:52, Guenter Roeck wrote: > Generate an interrupt if the tx buffer is empty and the tx empty interrupt > is enabled. This fixes a problem seen when running a Linux image since > Linux commit 55c3cb1358e ("serial: imx: remove unneeded

Re: [Qemu-devel] [PATCH v1 14/15] cpu-common: Define tb_page_addr_t for everyone

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 07:39, Peter Crosthwaite wrote: > So this is the same as in RFCv2 and the comment there was that it will not > work for linux-user mode WRT to qom/cpu.h fn prototypes needed this def. > But the solution there is instead to conditionalise the def of those hooks on > NEED_CPU_H. Then

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Alberto Garcia
On Fri 11 Sep 2015 11:14:33 AM CEST, Fam Zheng wrote: >> > Another advantage for bdrv_aio_poll() is, in main loop we will not >> > need a separate AioContext in changes like: >> > >> > http://patchwork.ozlabs.org/patch/514968/ >> > >> > Because nested aio_poll will

Re: [Qemu-devel] typofixes

2015-09-11 Thread Michael Tokarev
08.09.2015 11:26, Peter Maydell wrote: > On 7 September 2015 at 22:45, Veres Lajos wrote: >> Hi, >> >> Please find attached a couple of typo fixes, mostly in comments/docs. >> (Please cc me directly, I am not on the list.) > > That patch includes at least one change to

Re: [Qemu-devel] [PATCH v4 29/38] blockdev: Add blockdev-insert-medium

2015-09-11 Thread Wen Congyang
On 09/11/2015 03:09 AM, Max Reitz wrote: > On 10.09.2015 03:12, Wen Congyang wrote: >> On 09/09/2015 08:59 PM, Max Reitz wrote: >>> On 09.09.2015 12:01, Wen Congyang wrote: On 09/09/2015 05:20 AM, Max Reitz wrote: > On 08.09.2015 11:13, Wen Congyang wrote: >> On 07/21/2015 01:45 AM,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-11 Thread Thomas Huth
On 11/09/15 02:45, David Gibson wrote: > On Thu, Sep 10, 2015 at 02:03:39PM +0200, Thomas Huth wrote: >> On 10/09/15 12:40, David Gibson wrote: >>> On Thu, Sep 10, 2015 at 09:33:21AM +0200, Thomas Huth wrote: On 09/09/15 23:10, Thomas Huth wrote: > On 08/09/15 07:15, David Gibson wrote:

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-11 Thread Cornelia Huck
On Fri, 11 Sep 2015 16:01:56 +0800 Jason Wang wrote: > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > features 64bit wide"). Device's guest_features was actually set after > vdc->load(). This breaks the assumption that device specific load() >

Re: [Qemu-devel] [PATCH] virtio-vga: enable for i386

2015-09-11 Thread Michael Tokarev
11.09.2015 12:13, Gerd Hoffmann пишет: > On Fr, 2015-09-11 at 10:30 +0300, Michael Tokarev wrote: >> 13.07.2015 14:58, Gerd Hoffmann wrote: >>> Cc: Paolo Bonzini >>> Cc: qemu-triv...@nongnu.org >>> Signed-off-by: Gerd Hoffmann >> >> Gerd, -trivial received

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Daniel P. Berrange
On Fri, Sep 11, 2015 at 11:36:10AM +0200, Alberto Garcia wrote: > On Fri 11 Sep 2015 11:14:33 AM CEST, Fam Zheng wrote: > > >> > Another advantage for bdrv_aio_poll() is, in main loop we will not > >> > need a separate AioContext in changes like: > >> > > >> >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-11 Thread Alexander Graf
On 11.09.15 02:46, David Gibson wrote: > On Thu, Sep 10, 2015 at 02:13:26PM +0200, Alexander Graf wrote: >> >> >>> Am 10.09.2015 um 14:03 schrieb Thomas Huth : >>> On 10/09/15 12:40, David Gibson wrote: > On Thu, Sep 10, 2015 at 09:33:21AM +0200, Thomas Huth wrote:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Fam Zheng
On Fri, 09/11 11:36, Alberto Garcia wrote: > On Fri 11 Sep 2015 11:14:33 AM CEST, Fam Zheng wrote: > > >> > Another advantage for bdrv_aio_poll() is, in main loop we will not > >> > need a separate AioContext in changes like: > >> > > >> >

Re: [Qemu-devel] [PATCH] virtio-vga: enable for i386

2015-09-11 Thread Michael Tokarev
13.07.2015 14:58, Gerd Hoffmann wrote: > Cc: Paolo Bonzini > Cc: qemu-triv...@nongnu.org > Signed-off-by: Gerd Hoffmann Gerd, -trivial received 3 patches like this enabling various virtio bits for various architectures. I never got any reviewed-by or ACK

Re: [Qemu-devel] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks

2015-09-11 Thread Michael Tokarev
03.08.2015 12:14, Alex Bennée wrote: > Hi, > > This is mostly just a re-base to keep current with master. I've added > a couple of outstanding s-o-b and r-b tags. There are also two new > patches in this series which seemed to be worth keeping together: > > - a simple patch to dump invocation

Re: [Qemu-devel] [PATCH 5/6] hw/arm/spitz: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
Aplied (finally!) to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 01/23] userfaultfd: linux/Documentation/vm/userfaultfd.txt

2015-09-11 Thread Michael Kerrisk (man-pages)
On 05/14/2015 07:30 PM, Andrea Arcangeli wrote: > Add documentation. Hi Andrea, I do not recall... Did you write a man page also for this new system call? Thanks, Michael > Signed-off-by: Andrea Arcangeli > --- > Documentation/vm/userfaultfd.txt | 140 >

[Qemu-devel] [PATCH v3] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-11 Thread Thomas Huth
The PAPR interface defines a hypercall to pass high-quality hardware generated random numbers to guests. Recent kernels can already provide this hypercall to the guest if the right hardware random number generator is available. But in case the user wants to use another source like EGD, or QEMU is

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 11:44, Fam Zheng wrote: > > > > That would be a step back. Using GSource is useful because it lets > > > > you integrate libraries such as GTK+. > > > > > > Can we move GTK to a separate GSource thread? > > > > I think that GTK should always run in the main thread, or at least

Re: [Qemu-devel] [PATCH] Makefile: suppress command echoing in silent mode (make -s)

2015-09-11 Thread Michael Tokarev
02.09.2015 12:14, Jerome Forissier wrote: > Signed-off-by: Jerome Forissier Please Cc qemu-devel on patches. > rules.mak | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/rules.mak b/rules.mak > index 4551b9e..a44ba29 100644 >

Re: [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

2015-09-11 Thread Michael Tokarev
04.09.2015 22:41, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The legacy<> type is no longer used since 7ce7ffe02. Applied to -trivial, with the typo fix suggested by Eric. Thanks, /mjt

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Add Mount image file menu item

2015-09-11 Thread Markus Armbruster
Only reviewing around qmp_device_add() and such, ignoring the GUI part. Programmingkid writes: > Add "Mount Image File..." and a "Eject Image File" menu items to > cocoa interface. This patch makes sharing files between the > host and the guest user-friendly. > > The

[Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-11 Thread Jason Wang
After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make features 64bit wide"). Device's guest_features was actually set after vdc->load(). This breaks the assumption that device specific load() function can check guest_features. For virtio-net, self announcement and guest offloads

Re: [Qemu-devel] [PATCH 4/6] hw/gpio/zaurus: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
Applied (finally!) to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 3/6] hw/virtio/virtio-pci: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
Applied (finally!) to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Paolo Bonzini
On 09/09/2015 05:22, Fam Zheng wrote: > Another advantage for bdrv_aio_poll() is, in main loop we will not need > a separate AioContext in changes like: > > http://patchwork.ozlabs.org/patch/514968/ > > Because nested aio_poll will automatically be limited to only process block > layer events.

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

2015-09-11 Thread Gerd Hoffmann
> void early_gtk_display_init(int opengl) > { > +/* The QEMU code relies on the assumption that it's always run in > + * the C locale. Therefore it is not prepared to deal with > + * operations that produce different results depending on the > + * locale, such as printf's

Re: [Qemu-devel] [PATCH] virtio-vga: enable for i386

2015-09-11 Thread Gerd Hoffmann
On Fr, 2015-09-11 at 10:30 +0300, Michael Tokarev wrote: > 13.07.2015 14:58, Gerd Hoffmann wrote: > > Cc: Paolo Bonzini > > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Gerd Hoffmann > > Gerd, -trivial received 3 patches like this enabling various

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 11:36, Alberto Garcia wrote: > > > > Because nested aio_poll will automatically be limited to only > > > > process block layer events. My idea is to eventually let main loop > > > > use aio_poll > > > > > > That would be a step back. Using GSource is useful because it lets > > >

Re: [Qemu-devel] [PATCH] virtio-vga: enable for i386

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 11:23, Michael Tokarev wrote: > Ok, applied this one to -trivial (with a commit comment :) > > The other 2 are actually 2 incarnations of the same patch, > http://patchwork.ozlabs.org/patch/494250/ > > Since the replies hasn't been seen at qemu-trivial@ I haven't > found the

Re: [Qemu-devel] [PATCH] typofixes - v4 - https://github.com/vlajos/misspell_fixer

2015-09-11 Thread Michael Tokarev
09.09.2015 00:45, Veres Lajos wrote: > Signed-off-by: Veres Lajos Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
Applied (finally!) to -trivial, without already fixed -net and -scsi bits. Thanks! /mjt

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-09-11 Thread Michael Tokarev
12.05.2015 05:25, shannon.z...@linaro.org wrote: > From: Shannon Zhao [] > -DEFINE_PROP_END_OF_LIST() > +DEFINE_PROP_END_OF_LIST(), [] I don't see a reason doing this. Thanks, /mjt

Re: [Qemu-devel] [ipxe-devel] EFI_PXE_BASE_CODE_PROTOCOL

2015-09-11 Thread Gerd Hoffmann
> > https://ftp.fau.de/centos/7.1.1503/os/x86_64/EFI/BOOT/ > > That grubx64.efi binary makes no attempt to even look for an > EFI_PXE_BASE_CODE_PROTOCOL. Here's the complete log of calls that it makes: With grubx86.efi loaded via tftp I assume? > OpenProtocol ( >

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Fam Zheng
On Fri, 09/11 10:15, Paolo Bonzini wrote: > > > On 09/09/2015 05:22, Fam Zheng wrote: > > Another advantage for bdrv_aio_poll() is, in main loop we will not need > > a separate AioContext in changes like: > > > > http://patchwork.ozlabs.org/patch/514968/ > > > > Because nested aio_poll will

Re: [Qemu-devel] [PULL v1 00/21] Multi-arch queue

2015-09-11 Thread Peter Maydell
On 11 September 2015 at 06:44, Peter Crosthwaite wrote: > Flush of multi-arch pre-requisite work. > > > multi-arch queue: > * add EM_MOXIE > * Cleanup ELF_MACHINE and remove from cpu.h >

Re: [Qemu-devel] [PATCH] qom/object.h: remove some child/parent doc

2015-09-11 Thread Michael Tokarev
07.09.2015 18:46, Andreas Färber wrote: > Am 04.09.2015 um 23:01 schrieb marcandre.lur...@redhat.com: >> From: Marc-André Lureau >> >> It looks like this documentation is obsolete: a child object may lookup >> its parent stored in the Object struct. >> >>

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-11 Thread Eduardo Habkost
Ping? So, what's the reason we are still keeping those old machines in the code? On Tue, Aug 18, 2015 at 04:11:42PM -0700, Eduardo Habkost wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > an ich9-ahci

Re: [Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is

  1   2   3   4   >