Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

2015-09-18 Thread Shmulik Ladkani
Hi, On Thu, 3 Sep 2015 17:45:34 +0100 Stefan Hajnoczi wrote: > Thanks, applied to my net tree: > https://github.com/stefanha/qemu/commits/net For some reason, the patch isn't present on Stefan's last pull requests. Can you please verify this gets merged? Thanks, Shmulik

Re: [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-18 Thread Alexey Kardashevskiy
On 09/17/2015 11:09 PM, David Gibson wrote: Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the

[Qemu-devel] [PATCH RFC 3/4] sPAPR: Support multiple IOMMU groups in PHB for EEH operations

2015-09-18 Thread Gavin Shan
Currently, EEH works based on the assumption that every VFIO PHB has only one attached IOMMU group, which won't be true any more. It means every PHB would have multiple attached IOMMU groups. In order to apply the request EEH operation to the specified IOMMU group (PE), the changes to host kernel

[Qemu-devel] [PATCH RFC 2/4] VFIO: Introduce vfio_get_group_id()

2015-09-18 Thread Gavin Shan
This introduces vfio_get_group_id() to retrieve the group ID from the specified PCI device. The function will be used by subsequent patches to support applying EEH operation on the specified IOMMU group. Signed-off-by: Gavin Shan --- hw/vfio/pci.c | 12

[Qemu-devel] [PATCH RFC 1/4] linux-headers: Sync vfio.h

2015-09-18 Thread Gavin Shan
This synchronizes the Linux header vfio.h because of the changes introduced by below Linux commits: 900facd ("drivers/vfio: Support IOMMU group for EEH operations") 108f78d ("drivers/vfio: Support EEH API revision") Signed-off-by: Gavin Shan ---

[Qemu-devel] [PATCH RFC 4/4] sPAPR: Remove EEH callbacks in sPAPRPHBClass

2015-09-18 Thread Gavin Shan
Currently, the EEH operations implemented in the callbacks in sPAPRPHBClass, which will be dropped soon. This makes those functions corresponding to the EEH callbacks in sPAPRPHBClass public so that they can be called directly. Signed-off-by: Gavin Shan ---

[Qemu-devel] [PATCH RFC 0/4] sPAPR: Support multiple PEs in one PHB

2015-09-18 Thread Gavin Shan
This patchset bases on David Gibson's git tree: git://github.com/dgibson/qemu.git (branch: vfio). And it requires host kernel changes which is being reviewed this moment. https://patchwork.ozlabs.org/patch/519135/ https://patchwork.ozlabs.org/patch/519136/ Currently, EEH works with the

Re: [Qemu-devel] [RFC PATCH 03/10] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-09-18 Thread Alexey Kardashevskiy
On 09/17/2015 11:09 PM, David Gibson wrote: The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit

[Qemu-devel] [PATCH] ui/cocoa.m: Make boot image loading code compatible with GCC 4.9

2015-09-18 Thread Programmingkid
When QEMU is launched on Mac OS X without any arguments, an open file dialog appears. The user is then expected to select a file to boot QEMU with. This code was not compatible with GCC 4.9 (user-built, not Apple supplied). This patch greatly simplifes the open file dialog feature and makes it

Re: [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices

2015-09-18 Thread Eduardo Habkost
On Fri, Sep 18, 2015 at 08:42:54PM +0200, Thomas Huth wrote: > On 18/09/15 14:00, Markus Armbruster wrote: > > Several devices don't survive object_unref(object_new(T)): they crash > > or hang during cleanup, or they leave dangling pointers behind. > > > > This breaks at least

[Qemu-devel] [PATCH v2 3/4] target-i386: Move TCG initialization to realize time

2015-09-18 Thread Eduardo Habkost
QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Move TCG initialization to realize time so it won't be called when just doing object_new() on a X86CPU subclass.

[Qemu-devel] [PATCH] target-tilegx: Implement v1multu instruction

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to v1add implementation. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 13 + target-tilegx/translate.c | 4 3 files changed, 18 insertions(+)

[Qemu-devel] [PATCH] target-tilegx: Implement v*shl, v*shru, and v*shrs instructions

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to the v1shl, v1shru, and v1shrs implementations. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 6 + target-tilegx/simd_helper.c | 62 +

[Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-18 Thread gang . chen . 5i5j
From: Chen Gang Only according to helper_v1shrs. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 8 + target-tilegx/simd_helper.c | 77 + target-tilegx/translate.c | 26

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Programmingkid
On Sep 18, 2015, at 2:33 PM, Alexander Graf wrote: > > >> Am 18.09.2015 um 15:55 schrieb Programmingkid : >> >> >>> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote: >>> >>> >>> Am 17.09.2015 um 14:42 schrieb Programmingkid :

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-18 Thread Eduardo Habkost
On Wed, Sep 16, 2015 at 10:57:57AM +0200, Paolo Bonzini wrote: [...] > Otherwise looks good, I'll write a kvm-unit-tests patch for this. I am planning to apply the series as soon as we get kvm-unit-tests results. If you think this is ready to get included as-is, even before we have it tested by

[Qemu-devel] [Bug 1006655] Re: Can't convert to vmdk with the streamOptimized subformat

2015-09-18 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.3+dfsg-5ubuntu6 --- qemu (1:2.3+dfsg-5ubuntu6) wily; urgency=medium * Make qemu-system-common and qemu-utils depend on qemu-block-extra to fix errors with missing block backends. (LP: #1495895) * Cherry pick fixes for vmdk

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 11:47:52PM +0100, Peter Maydell wrote: > On 18 September 2015 at 19:25, Kevin O'Connor wrote: > > +Additionaly, if the DMA interface is available then a read to the DMA > > +Address will return 0x51454d5520434647 ("QEMU CFG" in big-endian > > +format).

[Qemu-devel] [Bug 1497479] [NEW] memory corruption with migrate/savevm in TCG mode

2015-09-18 Thread Pavel Boldin
Public bug reported: [ISSUE] QEMU releases 2.3.1 and lower are forgetting to flush TLBs before enabling the global dirty pages log and entering the final stage of saving the VM. [DESCRIPTION] The situation is the following: 1. TLB misses is the only way for page dirtying in the TCG mode. 2. If

[Qemu-devel] [Bug 1497479] Re: memory corruption with migrate/savevm in TCG mode

2015-09-18 Thread Pavel Boldin
** Description changed: [ISSUE] QEMU releases 2.3.1 and lower are forgetting to flush TLBs before enabling the global dirty pages log and entering the final stage of saving the VM. [DESCRIPTION] The situation is the following: 1. TLB misses is the only way for page dirtying

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == _mem_unassigned' failed

2015-09-18 Thread Gonglei
On 2015/9/16 0:49, Paolo Bonzini wrote: > > > Sorry, I haven't looked at it yet. I'll have to study the code. In the > meanwhile, perhaps you can print "section" and "existing" please from gdb? > > Paolo > Hi, Paolo We reproduced the issue today, and get below information by gdb (we

Re: [Qemu-devel] [PATCH 1/2] sPAPR: Revert don't enable EEH on emulated PCI devices

2015-09-18 Thread David Gibson
On Fri, Sep 18, 2015 at 05:30:43PM +1000, Gavin Shan wrote: > This reverts commit 7cb18007 ("sPAPR: Don't enable EEH on emulated > PCI devices") as rtas_ibm_set_eeh_option() isn't the right place > to check if there has the corresponding PCI device for the input > address, which can be PE address,

Re: [Qemu-devel] [PATCH 2/2] sPAPR: Enable EEH on VFIO PCI device only

2015-09-18 Thread David Gibson
On Fri, Sep 18, 2015 at 05:30:44PM +1000, Gavin Shan wrote: > This checks if the PCI device retrieved from the PCI device address > is VFIO PCI device when enabling EEH functionality. If it's not > VFIO PCI device, the EEH functonality isn't enabled. > > Signed-off-by: Gavin Shan

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-18 Thread Wen Congyang
On 09/18/2015 02:56 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/18/2015 04:11 AM, Eric Blake wrote: >>> On 09/17/2015 08:34 AM, Eric Blake wrote: >>> > > I apply Markus's v8 patch and this series, make check will fail: > TEST:

[Qemu-devel] [PATCH v3 2/5] fw_cfg DMA interface documentation

2015-09-18 Thread Marc Marí
Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- docs/specs/fw_cfg.txt | 65 +++ 1 file changed, 61 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 2 +- hw/nvram/fw_cfg.c | 228

Re: [Qemu-devel] internal snapshots with sheepdog

2015-09-18 Thread Kevin Wolf
Am 11.09.2015 um 17:49 hat Vasiliy Tolstov geschrieben: > Hi! qcow2 have abilit to store vm state inside qcow2 file in space > that not allocated to guest, but if i want to store vm state inside > sheepdog storage with raw image what is the preferred place to store > memory data? > I simply can

Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

2015-09-18 Thread Dmitry Fleytman
ACK. > On Sep 18, 2015, at 08:55 AM, Shmulik Ladkani > wrote: > > Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO > command. > > Currently, due to lack of support, a bogus value (-1) is returned. > > Support this command,

[Qemu-devel] [PATCH v4 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-09-18 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 6 ++--- block/quorum.c| 72 +--

[Qemu-devel] [PATCH v4 3/4] qmp: add monitor command to add/remove a child

2015-09-18 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c | 48 ++ qapi/block-core.json | 34

[Qemu-devel] [PATCH 2/2] sPAPR: Enable EEH on VFIO PCI device only

2015-09-18 Thread Gavin Shan
This checks if the PCI device retrieved from the PCI device address is VFIO PCI device when enabling EEH functionality. If it's not VFIO PCI device, the EEH functonality isn't enabled. Signed-off-by: Gavin Shan --- hw/ppc/spapr_pci_vfio.c | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 3/3] virtio-net: correctly drop truncated packets

2015-09-18 Thread Jason Wang
When packet is truncated during receiving, we drop the packets but neither discard the descriptor nor add and signal used descriptor. This will lead several issues: - sg mappings are leaked - rx will be stalled if a lots of packets were truncated In order to be consistent with vhost, fix by

[Qemu-devel] QEMU fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Implementation of the FW CFG DMA interface. When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 16a1b6e and SeaBIOS commit e4d2b8c QEMU startup time: .080 BIOS startup time: .060 Kernel setup time: .586 Total time: .726 QEMU

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-18 Thread Yang Hongyang
On 09/18/2015 04:11 AM, Eric Blake wrote: On 09/17/2015 08:34 AM, Eric Blake wrote: I apply Markus's v8 patch and this series, make check will fail: TEST: tests/virtio-net-test... (pid=23648) /x86_64/virtio/net/pci/basic: qemu-system-x86_64:

[Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86

2015-09-18 Thread Marc Marí
Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/i386/pc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside GIT tree

2015-09-18 Thread Daniel P. Berrange
Steve Ellcey / Leon Alrae reported that QEMU fails to build when the VPATH directory is outside of the GIT tree, and the system emulators & tools build is disabled. eg cd .. mkdir build cd build ../qemu/configure --disable-system --disable-tools make (...) make[1]: *** No

[Qemu-devel] [PATCH 1/2] sPAPR: Revert don't enable EEH on emulated PCI devices

2015-09-18 Thread Gavin Shan
This reverts commit 7cb18007 ("sPAPR: Don't enable EEH on emulated PCI devices") as rtas_ibm_set_eeh_option() isn't the right place to check if there has the corresponding PCI device for the input address, which can be PE address, not PCI device address. Signed-off-by: Gavin Shan

Re: [Qemu-devel] MIPS qemu build failure

2015-09-18 Thread Daniel P. Berrange
On Fri, Sep 18, 2015 at 09:53:31AM +0100, Leon Alrae wrote: > On 18/09/2015 09:24, Daniel P. Berrange wrote: > > On Thu, Sep 17, 2015 at 07:38:53PM +0100, Peter Maydell wrote: > >> On 17 September 2015 at 19:21, Steve Ellcey wrote: > >>> > >>> Following up to my own email.

Re: [Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-18 Thread Greg Kurz
On Thu, 17 Sep 2015 10:49:41 +0200 Thomas Huth wrote: > The PAPR interface defines a hypercall to pass high-quality > hardware generated random numbers to guests. Recent kernels can > already provide this hypercall to the guest if the right hardware > random number generator is

Re: [Qemu-devel] [PATCH v8 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-18 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> Fixes flat unions to get the base's base members. Test case is from >> commit 2fc0043, in qapi-schema-test.json: >> >> { 'union': 'UserDefFlatUnion', >> 'base': 'UserDefUnionBase', >>

Re: [Qemu-devel] internal snapshots with sheepdog

2015-09-18 Thread Vasiliy Tolstov
2015-09-18 12:02 GMT+03:00 Kevin Wolf : > Doesn't sheepdog already support storing snapshots in the same image? > I thought it would just work; at least, there's some code there for it. Yes, qemu and sheepdog have ability to create internal snapshot, i miss that, but when i'm

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-18 Thread Markus Armbruster
Eric Blake writes: > On 09/17/2015 10:32 AM, Paolo Bonzini wrote: > > Can we revert this one, please? Checkpatch now warns about constructs > like > typedef struct MyDevice { > DeviceState parent; > > int reg0, reg1, reg2; > }

Re: [Qemu-devel] internal snapshots with sheepdog

2015-09-18 Thread Kevin Wolf
Am 18.09.2015 um 11:03 hat Vasiliy Tolstov geschrieben: > 2015-09-18 12:02 GMT+03:00 Kevin Wolf : > > Doesn't sheepdog already support storing snapshots in the same image? > > I thought it would just work; at least, there's some code there for it. > > Yes, qemu and sheepdog have

[Qemu-devel] [Bug 1497204] [NEW] qemu-system-s390x: no SMP support without KVM

2015-09-18 Thread Marcin Kościelnicki
Public bug reported: It seems SMP support is not implemented for s390x target, at least when not running under KVM. There is also no error message when starting qemu, it just fails when the kernel tries to bring up the CPUs: $ qemu-system-s390x -nographic -smp 8 -kernel s390x/kernel.debian [

Re: [Qemu-devel] MIPS qemu build failure

2015-09-18 Thread Daniel P. Berrange
On Thu, Sep 17, 2015 at 07:38:53PM +0100, Peter Maydell wrote: > On 17 September 2015 at 19:21, Steve Ellcey wrote: > > > > Following up to my own email. Apparently the reason I get this error is > > that I am building with "--disable-tools --disable-system". I don't need >

[Qemu-devel] [v4][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-09-18 Thread Tiejun Chen
While working with qemu, IGD is a specific device in the case of pass through so we need to identify that to handle more later. Here we define a table to record all IGD types currently we can support. Also we need to introduce two helper functions to get vendor and device ids to lookup that table.

[Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-09-18 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn't suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending

[Qemu-devel] [v4][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-09-18 Thread Tiejun Chen
Ian, As we discussed previously, http://patchwork.ozlabs.org/patch/457055/ now it's time to push this into on xen/tools side since all qemu stuffs have been merged. https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02094.html v4: Ian, Actually we had v3.5 online previously, which was

[Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí --- hw/arm/virt.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Marc Marí
Implement host-side of the FW CFG DMA interface both for x86 and ARM. Based on Gerd Hoffman's initial implementation. Gabriel L. Somlo (1): fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí (4): fw_cfg DMA interface documentation Implement fw_cfg DMA interface Enable

[Qemu-devel] [PATCH v3 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-09-18 Thread Marc Marí
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo

[Qemu-devel] [PATCH v4 0/4] qapi: child add/delete support

2015-09-18 Thread Wen Congyang
If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. It is based on the following patch: http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg04579.html ChangLog: v4: 1.

[Qemu-devel] [PATCH v4 1/4] Add new block driver interface to add/delete a BDS's child

2015-09-18 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 50

[Qemu-devel] [PATCH v4 4/4] hmp: add monitor command to add/remove a child

2015-09-18 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino --- hmp-commands.hx | 28 hmp.c | 20

Re: [Qemu-devel] [PATCH 2/4] target-i386: Convert kvm_default_*features to property/value pairs

2015-09-18 Thread Eduardo Habkost
On Mon, Sep 14, 2015 at 10:32:14AM +0200, Paolo Bonzini wrote: > On 11/09/2015 21:25, Eduardo Habkost wrote: > > Convert the kvm_default_features and kvm_default_unset_features arrays > > into a simple list of property/value pairs that will be applied to > > X86CPU objects when using KVM. > > > >

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 22:16:46 +0200 Laszlo Ersek wrote: > On 09/18/15 10:58, Marc Marí wrote: > > Enable the fw_cfg DMA interface for the ARM virt machine. > > > > Based on Gerd Hoffman's initial implementation. > > > > Signed-off-by: Marc Marí > > --- > >

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Peter Crosthwaite
On Fri, Sep 18, 2015 at 10:23 AM, Richard Purdie wrote: > On Fri, 2015-09-18 at 09:46 -0700, Peter Crosthwaite wrote: >> >> My biggest fear is testing of the changes for the affected boards. >> >> Peter, do you much coverage of these boards in your regressions?

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v5 22/38] block: Prepare for NULL BDS

2015-09-18 Thread Eric Blake
On 09/18/2015 09:22 AM, Max Reitz wrote: > blk_bs() will not necessarily return a non-NULL value any more (unless > blk_is_available() is true or it can be assumed to otherwise, e.g. > because it is called immediately after a successful blk_new_with_bs() or > blk_new_open()). > > Signed-off-by:

[Qemu-devel] [PATCH v2 2/4] target-i386: Move TCG initialization check to tcg_x86_init()

2015-09-18 Thread Eduardo Habkost
Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 +--- target-i386/translate.c | 6 ++ 2

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: > Implement host-side of the FW CFG DMA interface both for x86 and ARM. > > Based on Gerd Hoffman's initial implementation. Thanks for working on this Marc! Any chance you could add the patch below to the series (or merge it into your

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Alexander Graf
> Am 18.09.2015 um 15:55 schrieb Programmingkid : > > >> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote: >> >> >> >>> Am 17.09.2015 um 14:42 schrieb Programmingkid : >>> >>> Is there a way to make USB work with Mac OS X on

Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common

2015-09-18 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > From: Peter Crosthwaite > > Move the size and mask globals for the "real" host page size to > translate-common. This is to allow system-level code to use > REAL_HOST_PAGE_ALIGN and friends in builds which hide

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Marc Marí
On Fri, 18 Sep 2015 14:25:09 -0400 "Kevin O'Connor" wrote: > On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: > > Implement host-side of the FW CFG DMA interface both for x86 and > > ARM. > > > > Based on Gerd Hoffman's initial implementation. > > Thanks for

Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common

2015-09-18 Thread Peter Crosthwaite
On Fri, Sep 18, 2015 at 11:52 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> From: Peter Crosthwaite >> >> Move the size and mask globals for the "real" host page size to >> translate-common. This is to allow

Re: [Qemu-devel] [PATCH 2/8] target-i386: Make check_hw_breakpoints static

2015-09-18 Thread Eduardo Habkost
On Tue, Sep 15, 2015 at 11:45:07AM -0700, Richard Henderson wrote: > The function is now only used from within a single file. > > Signed-off-by: Richard Henderson Reviewed-by: Eduardo Habkost Applied to x86 tree. Thanks! -- Eduardo

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 10:58, Marc Marí wrote: > Enable the fw_cfg DMA interface for the ARM virt machine. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí > --- > hw/arm/virt.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface

2015-09-18 Thread Kevin O'Connor
On Fri, Sep 18, 2015 at 10:58:47AM +0200, Marc Marí wrote: > Based on the specifications on docs/specs/fw_cfg.txt > > This interface is an addon. The old interface can still be used as usual. > > Based on Gerd Hoffman's initial implementation. > > Signed-off-by: Marc Marí >

[Qemu-devel] [PATCH v2 1/4] target-i386: Rename optimize_flags_init()

2015-09-18 Thread Eduardo Habkost
Rename the function so that the reason for its existence is clearer: it does x86-specific initialization of TCG structures. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- target-i386/cpu.h | 2 +- target-i386/translate.c | 2 +- 3 files changed, 3

[Qemu-devel] [PATCH v2 0/4] target-i386: Remove side-effects from X86CPU::instance_init

2015-09-18 Thread Eduardo Habkost
To allow new code to ask the CPU classes for CPU model information and allow QOM properties to be queried by qmp_device_list_properties(), we need to be able to safely instantiate a X86CPU object without any side-effects. This series moves some code from x86_cpu_initfn() to x86_cpu_realizefn(),

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*add and v*sub instructions

2015-09-18 Thread Richard Henderson
On 09/18/2015 05:03 PM, gang.chen.5...@gmail.com wrote: +uint64_t helper_v1add(uint64_t a, uint64_t b) +{ +uint64_t r = 0; +int i; + +for (i = 0; i < 64; i += 8) { +int64_t ae = (int8_t)(a >> i); +int64_t be = (int8_t)(b >> i); +r |= ((ae + be) & 0xff) << i; +

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v1multu instruction

2015-09-18 Thread Richard Henderson
On 09/18/2015 05:14 PM, gang.chen.5...@gmail.com wrote: From: Chen Gang Only according to v1add implementation. Signed-off-by: Chen Gang --- target-tilegx/helper.h | 1 + target-tilegx/simd_helper.c | 13 +

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-18 Thread Mike Ladouceur
I tried from Ubuntu in Virtualbox and this is the error I now get and it appears to be similar to the error from Cygwin. Configure seems to run fine. Make fails. I'm officially lost. ./configure --cross-prefix=x86_64-w64-mingw32 (...) CCqga/commands-win32.o qga/commands-win32.c: In function

Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-18 Thread Richard Henderson
On 09/18/2015 03:44 PM, Peter Maydell wrote: Well, if we're going to add a margin we need to add the worst-case margin. I guess the worst case is that deltas of the insn_data words between each insn are useless, and we need full 64-bit values to represent them -- 9 bytes for the sleb128.

Re: [Qemu-devel] [PATCH] target-tilegx: Implement v*shl, v*shru, and v*shrs instructions

2015-09-18 Thread Richard Henderson
On 09/18/2015 04:41 PM, gang.chen.5...@gmail.com wrote: +uint64_t helper_v4shl(uint64_t a, uint64_t b) +{ +uint64_t m; + +b &= 63; 31. All of the v4 functions have the same error. r~

Re: [Qemu-devel] RFC: virtio-peer shared memory based peer communication device

2015-09-18 Thread Paolo Bonzini
On 18/09/2015 18:29, Claudio Fontana wrote: > > this is a first RFC for virtio-peer 0.1, which is still very much a work in > progress: > > https://github.com/hw-claudio/virtio-peer/wiki > > It is also available as PDF there, but the text is reproduced here for > commenting: > > Peer

Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 17:18, Richard Henderson wrote: > On 09/18/2015 06:08 AM, Peter Maydell wrote: >> You're still not allowing for your worst-case datatable size when we >> calculate tcg_ctx.code_gen_buffer_max_size. > > Hum. What factor do you suggest? > > The maximum

Re: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM

2015-09-18 Thread Laszlo Ersek
On 09/18/15 22:24, Marc Marí wrote: > On Fri, 18 Sep 2015 22:16:46 +0200 > Laszlo Ersek wrote: > >> On 09/18/15 10:58, Marc Marí wrote: >>> Enable the fw_cfg DMA interface for the ARM virt machine. >>> >>> Based on Gerd Hoffman's initial implementation. >>> >>> Signed-off-by:

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-18 Thread chandrasekar kannan
http://wiki.qemu.org/Features/vhost-user-ovs-dpdk I'm running to problems attempting to try this out. qemu errors out with qemu-system-x86_64: -object memory-backend-file,id=mem,size=1024M,mem-path=/dev/hugepages,share=on: unable to map backing store for hugepages: Cannot allocate memory

[Qemu-devel] [PATCH] ui/cocoa.m: prevent stuck key situation

2015-09-18 Thread Programmingkid
When the user puts QEMU in the background while holding down a key, QEMU will not receive the keyup event when the user lets go of the key. When the user goes back to QEMU, QEMU will think the key is still down causing stuck key symptoms. This patch fixes this problem by releasing all keys when

Re: [Qemu-devel] [RFC PATCH v1 0/8] QOM prop overloading + ARM MPCore CPUs

2015-09-18 Thread Richard Purdie
On Fri, 2015-09-18 at 11:14 -0700, Peter Crosthwaite wrote: > On Fri, Sep 18, 2015 at 10:23 AM, Richard Purdie > wrote: > > On Fri, 2015-09-18 at 09:46 -0700, Peter Crosthwaite wrote: > >> >> My biggest fear is testing of the changes for the affected boards. >

Re: [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface

2015-09-18 Thread Peter Maydell
On 18 September 2015 at 19:25, Kevin O'Connor wrote: > On Fri, Sep 18, 2015 at 10:58:44AM +0200, Marc Marí wrote: >> Implement host-side of the FW CFG DMA interface both for x86 and ARM. >> >> Based on Gerd Hoffman's initial implementation. > > Thanks for working on this Marc!

[Qemu-devel] PATCH] ui/cocoa.m: verify with user before quitting QEMU

2015-09-18 Thread Programmingkid
This patch prevents the user from accidentally quitting QEMU by pushing Command-Q or by pushing the close button on the main window. When the user does one of these two things, a dialog box appears verifying with the user if he wants to quit QEMU. Signed-off-by: John Arbuckle

Re: [Qemu-devel] How to make USB work with Mac OS X

2015-09-18 Thread Alexander Graf
> Am 18.09.2015 um 20:38 schrieb Programmingkid : > > >> On Sep 18, 2015, at 2:33 PM, Alexander Graf wrote: >> >> >> >>> Am 18.09.2015 um 15:55 schrieb Programmingkid : >>> >>> On Sep 18, 2015, at 2:14 AM, Alexander Graf wrote:

[Qemu-devel] [PATCH] spapr: generate DT node names

2015-09-18 Thread Laurent Vivier
When DT node names for PCI devices are generated by SLOF, they are generated according to the type of the device (for instance, ethernet for virtio-net-pci device). Node name for hotplugged devices is generated by QEMU. This patch adds the mechanic to QEMU to create the node name according to the

Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86

2015-09-18 Thread Gerd Hoffmann
Hi, > -fw_cfg = fw_cfg_init_io(BIOS_CFG_IOPORT); > +fw_cfg = fw_cfg_init_io_dma(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 4, as); > +as = g_malloc(sizeof(*as)); > +address_space_init(as, ram_below_4g, "pc.as"); > +fw_cfg = bochs_bios_init(as); I think we can use

[Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix

2015-09-18 Thread marcandre . lureau
From: Marc-André Lureau Not only it makes sense, but it gets rid of checkpatch warning: WARNING: consider using qemu_strtosz in preference to strtosz Also remove the tabs to please checkpatch. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 3/4] checkpatch: recommend strtok_r

2015-09-18 Thread marcandre . lureau
From: Marc-André Lureau If anything, it should recommend strtok_r! (strtok_r() is reentrant-safe and thread-safe) Signed-off-by: Paolo Bonzini [Better matching and error message - Marc-André] Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 2/4] tests: add some qemu_strtosz() tests

2015-09-18 Thread marcandre . lureau
From: Marc-André Lureau While reading the function I decided to write some tests. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- tests/test-cutils.c | 91

Re: [Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test

2015-09-18 Thread Max Reitz
On 15.09.2015 08:11, Fam Zheng wrote: > From: Stefan Hajnoczi > > The BlockJobTxn unit test verifies that both single jobs and pairs of > jobs behave as a transaction group. Either all jobs complete > successfully or the group is cancelled. > > Signed-off-by: Stefan

Re: [Qemu-devel] Someone kill the in-tree build, please (was: MIPS qemu build failure)

2015-09-18 Thread Daniel P. Berrange
On Fri, Sep 18, 2015 at 02:06:39PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, Sep 18, 2015 at 09:53:31AM +0100, Leon Alrae wrote: > >> On 18/09/2015 09:24, Daniel P. Berrange wrote: > >> > On Thu, Sep 17, 2015 at 07:38:53PM +0100, Peter

Re: [Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor

2015-09-18 Thread Eric Blake
On 09/17/2015 02:30 PM, Eric Blake wrote: > On 09/07/2015 06:08 AM, Kővágó, Zoltán wrote: >> They are required for flat unions (you still have to allocate the >> structs). >> >> Signed-off-by: Kővágó, Zoltán >> --- >> qapi/opts-visitor.c | 15 +++ >> 1 file

Re: [Qemu-devel] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-18 Thread Max Reitz
On 14.09.2015 18:01, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing options

Re: [Qemu-devel] [PATCH v6 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-18 Thread Max Reitz
On 15.09.2015 08:11, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. > > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/backup.c | 27 +-- > 1 file changed, 17 insertions(+), 10

Re: [Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap()

2015-09-18 Thread Alberto Garcia
On Thu 17 Sep 2015 03:48:04 PM CEST, Kevin Wolf wrote: > bdrv_swap() has always been an ugly hack that we would rather have > avoided. When it was introduced, we simply didn't have the > infrastructure to update pointers instead of transplanting the > contents of BDS object,

[Qemu-devel] [PATCH v2 4/4] Replace strotok() by strtok_r()

2015-09-18 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- block/archipelago.c | 10 +- block/sheepdog.c| 5 +++-- qom/cpu.c | 12 ++-- target-i386/cpu.c | 6 +++--- target-sparc/cpu.c | 10

Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

2015-09-18 Thread Max Reitz
On 11.09.2015 20:52, Max Reitz wrote: > On 07.09.2015 09:34, Fam Zheng wrote: >> Sometimes block jobs must execute as a transaction group. Finishing >> jobs wait until all other jobs are ready to complete successfully. >> Failure or cancellation of one job cancels the other jobs in the group. >>

Re: [Qemu-devel] [PATCH v6 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-18 Thread Max Reitz
On 15.09.2015 08:11, Fam Zheng wrote: > From: Stefan Hajnoczi > > Provide a BlockJobTxn to actions executed in a qmp 'transaction' > command. This allows actions to make their block jobs either complete > as a group or fail/cancel together. > > The next patch adds the

Re: [Qemu-devel] [PATCH v6 11/14] block/backup: support block job transactions

2015-09-18 Thread Max Reitz
On 15.09.2015 08:11, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is

[Qemu-devel] [PULL 02/10] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt

2015-09-18 Thread Leon Alrae
From: Petar Jovanovic Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither they require any particular mode for its FPU. This patch removes the checks that may break a program that uses these instructions. Signed-off-by: Petar Jovanovic

  1   2   3   4   >