Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add real CDROM menu item

> Add a menu item to the Machine menu called "Use Real CDROM". It gives the > user the ability to use a real CDROM with QEMU by simply selecting a menu > item. > NSASCIIStringEncoding]; > +qmp_change_blockdev(device, "/dev/cdrom", "raw", ); > +handleAnyDeviceErrors(err); Not all systems

[Qemu-devel] [PATCH] tilegx: Generate ill related instructions according to Linux kernel

From: Chen Gang At present, tilegx qemu will abort for "setup_frame: not implemented", when meet raise instruction. Signed-off-by: Chen Gang --- linux-user/main.c | 14 target-tilegx/cpu.h | 3 ++

Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

> I've suggested this in the past but to my knowledge no has done any work in > this direction, including myself. Despite the lack of progress, I still > think this is a very worthwhile idea. Which is exactly why I think a configuration file would be the best option instead of

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

> On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple backup volfile servers to the > > > > gluster > > > > block backend of QEMU with tcp|rdma transport types and their

[Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

This should help clarify the purpose of the function that returns the host system's CPU cycle count. Signed-off-by: Christopher Covington --- bsd-user/main.c | 2 +- cpus.c| 6 +++--- hw/intc/xics.c| 2 +- hw/ppc/ppc.c

Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case

On 09/25/2015 06:39 AM, Andreas Färber wrote: > In addition to -42 also parse the maximum int64. > > Signed-off-by: Andreas Färber > --- > tests/test-string-input-visitor.c | 8 > 1 file changed, 8 insertions(+) Shouldn't we also add tests of one-beyond-range, to

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

Yang Hongyang writes: > On 09/24/2015 05:12 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> This filter is to buffer/release packets, this feature can be used >>> when using MicroCheckpointing, or other Remus like VM FT solutions, you

Re: [Qemu-devel] [PATCH 07/36] qapi: add some headings in docs

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add some missing double-#, the doc parser can't easily distinguish doc > comments from comments to be ignored otherwise. > > Also add some more section headings. > >

Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind

On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn't suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we can

Re: [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn a few more markups used for API documentation. > > Signed-off-by: Marc-André Lureau > --- > scripts/texi2pod.pl | 44

[Qemu-devel] [PULL 5/7] Backup: don't do copy-on-read in before_write_notifier

From: Wen Congyang We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we cannot do copy-on-read. The steps to reproduce it: 1. -drive copy-on-read=on,... // qemu option 2. drive_backup -f disk0 /path_to_backup.img // monitor command

[Qemu-devel] [PULL 6/7] sheepdog: use per AIOCB dirty indexes for non overlapping requests

From: Hitoshi Mitake In the commit 96b14ff85acf, requests for overlapping areas are serialized. However, it cannot handle a case of non overlapping requests. In such a case, min_dirty_data_idx and max_dirty_data_idx can be overwritten by the requests and invalid

[Qemu-devel] [PULL 0/7] Block patches

The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 01:32:11 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

Re: [Qemu-devel] [PATCH 08/36] qapi: add qapi2texi script

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > As the name suggests, the qapi2texi script converts JSON QAPI > description into a standalone texi file suitable for different target > formats. > > It parses the following kind

[Qemu-devel] [PATCH 1/2] memhp: extend address auto assignment to support gaps

setting gap to non 0 value will make sparse DIMM address auto allocation, leaving gaps between a new DIMM address and preceeding existing DIMM. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 2 +- hw/mem/pc-dimm.c | 13 +++-- hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

On Fri 25 Sep 2015 04:22:26 PM CEST, Eric Blake wrote: >> Disabling I/O limits from a BDS also drains all pending throttled >> requests, so it should be done at the beginning of bdrv_close() with >> the rest of the bdrv_drain() calls before the BlockDriver is closed. > > Can this be abused? If I

Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection

Andreas Färber writes: > Am 25.09.2015 um 12:17 schrieb Thomas Huth: >> On 24/09/15 20:57, Markus Armbruster wrote: >>> The test doesn't check that the output makes any sense, only that QEMU >>> survives. Useful since we've had an astounding number of crash bugs >>> around

Re: [Qemu-devel] [PATCH 02/36] qapi: add missing @

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qapi/block.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Adding qemu-trivial; this can be

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas Färber wrote: > Add a test for parsing and setting a uint64 property. > > Signed-off-by: Andreas Färber > --- > MAINTAINERS | 1 + > tests/Makefile | 3 ++ > tests/check-qom-props.c | 120 >

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

Thomas Huth writes: > On 25/09/15 10:03, Yang Hongyang wrote: >> >> >> On 09/24/2015 05:12 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: >> [...] diff --git a/vl.c b/vl.c index ec589e2..3cf89d5 100644 --- a/vl.c +++ b/vl.c

Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Clean-up qmp-commands.hx from examples. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 1128 +++- >

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

On 09/25/2015 09:29 AM, Marc-André Lureau wrote: > > > - Original Message - >> On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> Moving the remaining bits of documentation to the schema files. >>> >>>

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

Yang Hongyang writes: > This patchset addressed Markus comment on netfilter patch > series, most of them are comment fixes. > > It is based on jason's net tree: > https://github.com/jasowang/qemu/tree/net > > Signed-off-by: Yang Hongyang I think we

Re: [Qemu-devel] [PATCH 21/36] misc: spelling

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > --- > monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Trivial, can be applied now without waiting for pending qapi patches. Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Move the examples in the json file with the rest of the documentation to > avoid duplication. > > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PULL 2/7] block/nfs: cache allocated filesize for read-only files

From: Peter Lieven If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

- Original Message - > On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Moving the remaining bits of documentation to the schema files. > > > > Signed-off-by: Marc-André Lureau > >

[Qemu-devel] [PULL 7/7] sheepdog: refine discard support

From: Hitoshi Mitake This patch refines discard support of the sheepdog driver. The existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which was introduced before fine grained reference counting on newer sheepdog. It doesn't care about relations of

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On 25 September 2015 at 09:12, Programmingkid wrote: > > On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: >> (Also, isn't a simple test on gArgc going to cause us to put up >> the dialog box even if qemu was started from the command line with >> no arguments?) > > I

Re: [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict

On 09/25/2015 08:00 AM, Markus Armbruster wrote: > Make the variables holding the event QDict instead of QObject. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 0/2] sheepdog driver update

On Tue, Sep 01, 2015 at 12:03:08PM +0900, Hitoshi Mitake wrote: > This patchset has two patches. The first one is a defensive purpose > for rare cases. It is an improvement of the previous commit > 96b14ff85acf. The second one is refining discard operation caused by > fstrim command, etc. Current

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

Jason Wang writes: > On 09/24/2015 07:52 PM, Markus Armbruster wrote: >> Yang Hongyang writes: >> >>> On 09/24/2015 04:41 PM, Markus Armbruster wrote: Yang Hongyang writes: [...] > diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes

On 09/25/2015 02:08 AM, Yang Hongyang wrote: > This patchset addressed Markus comment on netfilter patch > series, most of them are comment fixes. > > It is based on jason's net tree: > https://github.com/jasowang/qemu/tree/net If that tree is not yet merged mainline, wouldn't it be better to

[Qemu-devel] [PULL 1/9] i6300esb: remove muldiv64()

Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

[Qemu-devel] [PULL 6/9] arm: clarify the use of muldiv64()

muldiv64() is used to convert microseconds into CPU ticks. But it is not clear and not commented. This patch uses macro to clearly identify what is used: time, CPU frequency and ticks. For an elapsed time and a given frequency, we compute how many ticks we have. Signed-off-by: Laurent Vivier

[Qemu-devel] [PULL 1/7] block/nfs: fix calculation of allocated file size

From: Peter Lieven st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Max Reitz Reviewed-by: Jeff Cody

Re: [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since some commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 19/36] qmp: implement qmp_query_commands without qmp_cmds

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > So we can get rid of the static qmp_cmds table. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 25 ++--- > 1 file

Re: [Qemu-devel] [PATCH 16/36] qmp: register qapi commands (no middle mode)

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The marshal functions are no longer exported, they are registered in the > dispatch table instead. The following patches will make use of > qmp_dispatch(). This patch temporarily

Re: [Qemu-devel] [PATCH 20/36] qmp: remove old qmp-commands table

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The table is no longer used. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 7 - > qmp-commands-old.h | 554 >

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: > On 23 September 2015 at 16:06, Programmingkid > wrote: >> Removes the open dialog code that runs when no arguments >> are supplied with QEMU. Not everyone needs a hard drive >> or cdrom to boot their target. A user

[Qemu-devel] [PATCH 0/2] ps: memhp: enforce gaps between DIMMs

it's a simplier way suggested by Michael S. Tsirkin to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html where virtio can't handle buffer that crosses border between 2 DIMM's (i.e. 2 MemoryRegions). idea is to leave gaps between DIMMs,

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

On 09/25/2015 07:41 AM, Alberto Garcia wrote: > Disabling I/O limits from a BDS also drains all pending throttled > requests, so it should be done at the beginning of bdrv_close() with > the rest of the bdrv_drain() calls before the BlockDriver is closed. Can this be abused? If I have a guest

Re: [Qemu-devel] [PATCH 01/36] qapi: add comment block before ChardevDummy

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is mainly to please the doc generation that requires comment block > before the declaration. > > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PULL 5/9] openrisc: remove muldiv64()

Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by

Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This was initially done to add qmp_capabilities documentation to the > schema. Then I figured it would also help to get rid of the "middle > mode" monitor dispatch code. > >

Re: [Qemu-devel] [PATCH 06/36] qapi: move documentation bits in schema files

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Moving the remaining bits of documentation to the schema files. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 48

Re: [Qemu-devel] [PATCHv2 0/7] VFIO extensions to allow VFIO devices on spapr-pci-host-bridge

On 25/09/2015 13:35, David Gibson wrote: > Hi Alex, > > Here are the parts of my recent series to allow VFIO devices on the > spapr-pci-host-bridge device which affect the core VFIO code. They've > been revised according to the comments from yourself and others. > > There's also one patch for

[Qemu-devel] [PULL 3/7] sheepdog: add reopen support

From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

Hi - Original Message - > On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > I have grown a qapi branch during the past 2 months that was > > post-poned for review until the introspection and other

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > I have grown a qapi branch during the past 2 months that was > post-poned for review until the introspection and other fixes got > merged or ready. > > It could be splitted roughly in 3 parts,

Re: [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test

On 09/25/2015 06:39 AM, Andreas Färber wrote: > Test parsing of decimal and hexadecimal uint64 numbers with most > significient bit set. s/significient/significant/ > > Signed-off-by: Andreas Färber > --- > tests/test-string-input-visitor.c | 23 +++ > 1

Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature

On 09/25/2015 06:39 AM, Andreas Färber wrote: > Instead of using int64_t for qemu_strtoll() and uiint64_t for s/uiint64/uint64/ > qemu_strtoull(), use long long and unsigned long long as their name > implies. > > The only affected callers are our test cases. > > This prepares for following

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

Programmingkid writes: > On Sep 24, 2015, at 2:57 AM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> On Sep 23, 2015, at 4:35 PM, Peter Maydell wrote: >>> On 17 September 2015 at 21:17, Programmingkid

Re: [Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Learn to generate info/html/pdf/man documentation for QEMU and agent QMP > APIs. > > This allows to provide missing agent documentation, and should help "allows to" is not

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

On 09/24/2015 02:34 AM, Markus Armbruster wrote: > John Snow writes: > > [...] >> Oh, I see: you're saying ... >> >> each action fetches the property, and if it's true, fail (for 2.5, at >> least) with e.g. a message saying "This property is not [yet?] supported >> for this

Re: [Qemu-devel] [PATCH 30/36] tests: change /0.15/* tests to /qmp/*

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Presumably 0.15 was the version it was first introduced, but > qmp keeps evolving. There is no point in having that version > has test prefix, qmp makes more sense. s/has/be

Re: [Qemu-devel] [RFC 0/6] Throttle event VSERPORT_CHANGE separately by "id"

Hi On Fri, Sep 25, 2015 at 4:00 PM, Markus Armbruster wrote: > VSERPORT_CHANGE is emitted when the guest opens or closes a > virtio-serial port. The event's member "id" identifies the port. > > When several events arrive quickly, throttling drops all but the last > of them.

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

Thomas Huth writes: > On 24/09/15 20:57, Markus Armbruster wrote: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> >> This breaks at least device-list-properties, because >>

Re: [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing

On 09/25/2015 06:39 AM, Andreas Färber wrote: > All integers would get parsed by strtoll(), not handling the case of > UINT64 properties with the most significient bit set. > > Implement a .type_uint64 visitor callback, reusing the existing > parse_str() code through a new argument, using

Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

On 09/25/2015 06:39 AM, Andreas Färber wrote: > Add a test for parsing and setting a uint64 property. > > Signed-off-by: Andreas Färber > --- > MAINTAINERS | 1 + > tests/Makefile | 3 ++ > tests/check-qom-props.c | 120 >

[Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting

Signed-off-by: Markus Armbruster --- docs/qmp/qmp-events.txt | 12 docs/qmp/qmp-spec.txt | 5 + 2 files changed, 17 insertions(+) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index d92cc48..d2f1ce4 100644 --- a/docs/qmp/qmp-events.txt +++

Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

Jason Wang writes: > On 09/25/2015 03:18 PM, Yang Hongyang wrote: >> >> >> On 09/24/2015 05:12 PM, Markus Armbruster wrote: >>> Yang Hongyang writes: [...] +static ssize_t filter_buffer_receive_iov(NetFilterState *nf, +

[Qemu-devel] [PULL 4/7] block: Introduce a new API bdrv_co_no_copy_on_readv()

From: Wen Congyang In some cases, we need to disable copy-on-read, and just read the data. Signed-off-by: Wen Congyang Message-id: 1441682913-14320-2-git-send-email-we...@cn.fujitsu.com Signed-off-by: Jeff Cody --- block/io.c

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On 23 September 2015 at 16:06, Programmingkid wrote: > Removes the open dialog code that runs when no arguments > are supplied with QEMU. Not everyone needs a hard drive > or cdrom to boot their target. A user might only need to > use their target's bios to do work.

Re: [Qemu-devel] [PATCH 18/36] qapi: remove "middle" mode

On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Now that the register function is always generated, we can > remove the so-called "middle" mode to the generator script. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

On 25.09.2015 17:42, Christopher Covington wrote: > This should help clarify the purpose of the function that returns > the host system's CPU cycle count. +1 Best regards, Sergey

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

On Sep 23, 2015, at 4:35 PM, Peter Maydell wrote: > On 17 September 2015 at 21:17, Programmingkid > wrote: >> Add "Mount Image File..." and a "Eject Image File" menu items to >> cocoa interface. This patch makes sharing files between the >> host and the guest

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

On 24/09/2015 06:33, David Gibson wrote: > When we have guest visible IOMMUs, we allow notifiers to be registered > which will be informed of all changes to IOMMU mappings. This is used by > vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. > > However, unlike with a

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 25/09/2015 07:24, David Gibson wrote: >> When memory_listener_register() replays mappings, it does so on >> an rcu copy of the flatview for each AddressSpace. Here we >> don't seem to have anything protecting against concurrency... do >> we

Re: [Qemu-devel] [PATCH] target-arm: fix CPU breakpoint handling

On 18.09.2015 17:07, Sergey Fedorov wrote: > On 18.09.2015 16:50, Peter Maydell wrote: >> On 14 September 2015 at 11:51, Sergey Fedorov wrote: >> @@ -904,7 +913,16 @@ void arm_debug_excp_handler(CPUState *cs) >> arm_debug_target_el(env)); >> }

[Qemu-devel] [PATCHv2 2/7] vfio: Generalize vfio_listener_region_add failure path

If a DMA mapping operation fails in vfio_listener_region_add() it checks to see if we've already completed initial setup of the container. If so it reports an error so the setup code can fail gracefully, otherwise throws a hw_error(). There are other potential failure cases in

[Qemu-devel] [PATCHv2 1/7] vfio: Remove unneeded union from VFIOContainer

Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used on all IOMMU types,

[Qemu-devel] [PATCHv2 0/7] VFIO extensions to allow VFIO devices on spapr-pci-host-bridge

Hi Alex, Here are the parts of my recent series to allow VFIO devices on the spapr-pci-host-bridge device which affect the core VFIO code. They've been revised according to the comments from yourself and others. There's also one patch for the memory subsystem. Paolo can you let me know if this

[Qemu-devel] [PATCHv2 4/7] vfio: Record host IOMMU's available IO page sizes

Depending on the host IOMMU type we determine and record the available page sizes for IOMMU translation. We'll need this for other validation in future patches. Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

On Fri, Sep 25, 2015 at 01:20:12PM +0200, Paolo Bonzini wrote: > > > On 24/09/2015 06:33, David Gibson wrote: > > When we have guest visible IOMMUs, we allow notifiers to be registered > > which will be informed of all changes to IOMMU mappings. This is used by > > vfio to keep the host IOMMU

[Qemu-devel] [PATCHv2 6/7] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

At present the memory listener used by vfio to keep host IOMMU mappings in sync with the guest memory image assumes that if a guest IOMMU appears, then it has no existing mappings. This may not be true if a VFIO device is hotplugged onto a guest bus which didn't previously include a VFIO device,

[Qemu-devel] [PATCHv2 3/7] vfio: Check guest IOVA ranges against host IOMMU capabilities

The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit address space. The common x86 IOMMUs support a wide

[Qemu-devel] [PATCHv2 5/7] memory: Allow replay of IOMMU mapping notifications

When we have guest visible IOMMUs, we allow notifiers to be registered which will be informed of all changes to IOMMU mappings. This is used by vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. However, unlike with a memory region listener, an iommu notifier won't be told

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: verify with user before quitting QEMU

On 23 September 2015 at 17:57, Programmingkid wrote: > This patch prevents the user from accidentally quitting QEMU by pushing > Command-Q or by pushing the close button on the main window. When > the user does one of these two things, a dialog box appears verifying >

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: prevent stuck key situation

On 23 September 2015 at 18:21, Programmingkid wrote: > When the user puts QEMU in the background while holding > down a key, QEMU will not receive the keyup event when > the user lets go of the key. When the user goes back to > QEMU, QEMU will think the key is still

[Qemu-devel] [PULL 51/52] docs: describe the QEMU build system structure / design

From: "Daniel P. Berrange" Developers who are new to QEMU, or have a background familiarity with GNU autotools, can have trouble getting their head around the home-grown QEMU build system. This document attempts to explain the structure / design of the configure script and

Re: [Qemu-devel] [PATCH 00/10] target-i386 addressing cleanups

On 23 September 2015 at 21:10, Richard Henderson wrote: > Ping. Just a note that I feel like I've done a lot of tcg related review recently so I'm hoping somebody else can take up the slack with reviewing this set... thanks -- PMM > > On 07/09/2015 12:15 AM, Richard

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On Sep 25, 2015, at 4:14 PM, Peter Maydell wrote: > On 25 September 2015 at 12:58, Programmingkid > wrote: >> >> On Sep 25, 2015, at 2:53 PM, Peter Maydell wrote: >> >>> On 25 September 2015 at 11:24, Programmingkid >>> wrote: >>>

Re: [Qemu-devel] [PULL 0/1] VFIO - fix glib 2.22 compat

On 25 September 2015 at 10:06, Alex Williamson wrote: > Hi Peter, > > I'll likely have another pull next week, but I don't want to sit on > this trivial fix for glib 2.22 compatability. Thanks, > > Alex > > The following changes since commit

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

On 2015-09-22 13:25, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 40 - > tcg/tcg.h | 4 +- > translate-all.c

[Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:

[Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable

Compress lines and remove the variable ret. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:

[Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable

Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:

[Qemu-devel] [PATCH] MAINTAINERS: Add NSIS file for W32, W64 hosts

The NSIS installer configuration is maintained by me. Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7aff162..1ed349d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -262,6 +262,7 @@ L:

[Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute

Signed-off-by: Stefan Weil --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 8367997..584f6df 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -5194,7 +5194,7 @@ void

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On 25 September 2015 at 13:38, Programmingkid wrote: > > On Sep 25, 2015, at 4:14 PM, Peter Maydell wrote: >> Yes, but I was hoping for it in a format that works with >> our patch-handling tools... > > What needs to be changed to make it work with the patch-handling

[Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

Removes the open dialog code that runs when no arguments are supplied with QEMU. Not everyone needs a hard drive or cdrom to boot their target. A user might only need to use their target's bios to do work. With that said, this patch removes the unneeded open dialog code. Signed-off-by: John

[Qemu-devel] [PATCH 1/2] Hw: char: Remove unnecessary variable

Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:

Re: [Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable

On 25 September 2015 at 01:37, Shraddha Barke wrote: > Compress lines and remove the variable ret. > > Change made using Coccinelle script > diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c > index 459c748..ba01050 100644 > --- a/hw/timer/tusb6010.c > +++

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

On 25 September 2015 at 12:58, Programmingkid wrote: > > On Sep 25, 2015, at 2:53 PM, Peter Maydell wrote: > >> On 25 September 2015 at 11:24, Programmingkid >> wrote: >> >>> I don't think Mac OS X adds the -psn argument anymore. It might

[Qemu-devel] [PATCH] disas/cris: Fix typo in comment

Signed-off-by: Stefan Weil --- disas/cris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/cris.c b/disas/cris.c index 1b76a09..4482a41 100644 --- a/disas/cris.c +++ b/disas/cris.c @@ -2492,7 +2492,7 @@ print_with_operands (const struct cris_opcode

Re: [Qemu-devel] [PATCH v3 21/25] tcg: Remove gen_intermediate_code_pc

On 2015-09-22 13:25, Richard Henderson wrote: > It is no longer used, so tidy up everything reached by it. > This includes the gen_opc_* arrays, the search_pc parameter > and the inline gen_intermediate_code_internal functions. > > Reviewed-by: Peter Maydell >

Re: [Qemu-devel] [PATCH v3 22/25] tcg: Remove tcg_gen_code_search_pc

On 2015-09-22 13:25, Richard Henderson wrote: > It's no longer used, so tidy up everything reached by it. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 59

Re: [Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside GIT tree

On Fri, 2015-09-18 at 13:40 +0200, Paolo Bonzini wrote: > > The problem is due to the fact that some sub directory deps > > were listed against SOFTMMU_SUBDIR_RULES instead of SUBDIR_RULES, > > so were only processed for system emulators, not user emalutors. > > > > Signed-off-by: Daniel P.

  1   2   3   >