Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-09 Thread Cao jin
On 12/08/2015 11:01 PM, Markus Armbruster wrote: Cao jin writes: Hi Markus, I have to say, you really did a amazing review for this "trivial "patch, thanks a lot & really appreciate it:) Thanks! I'm afraid the problem you picked isn't trivial, but I hope

Re: [Qemu-devel] QEMU being able to use audio cdroms

2015-12-09 Thread Paolo Bonzini
On 08/12/2015 20:00, Programmingkid wrote: > > I haven't tested it, nobody has ever asked. I wouldn't reject patches > > for such a feature, but I likely wouldn't make reviewing them a priority > > either. > > > > I assume this would be primarily for emulating games/etc that use mixed > >

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-12-09 Thread Alex Bennée
Pavel Fedin writes: > Hello! > >> > On some architectures TARGET_PAGE_ALIGN() is not enough to get the right >> > alignment. For example on ARM TARGET_PAGE_BITS is 10 because some old CPUs >> > support 1K page size, while minimum SMMU page size is 4K. >> > >> > This fixes

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Michael S. Tsirkin
On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: > Hi Michael & Alexander: > Thanks a lot for your comments and suggestions. It's nice that it's appreciated, but you then go on and ignore all that I have written here: https://www.mail-archive.com/kvm@vger.kernel.org/msg123826.html >

Re: [Qemu-devel] Save IDEState data to files when VM shutdown

2015-12-09 Thread Dr. David Alan Gilbert
* Huaicheng Li (lhc...@gmail.com) wrote: > Hi all, > > Please correct me if I’m wrong. > > I made some changes to IDE emulation (add some extra structures to “struct > IDEState") and want to save these info to files when VM shutdowns. So I can > reload these info from files next time when VM

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Lan, Tianyu
On 12/8/2015 1:12 AM, Alexander Duyck wrote: On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu wrote: On 12/5/2015 1:07 AM, Alexander Duyck wrote: We still need to support Windows guest for migration and this is why our patches keep all changes in the driver since it's

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> In general, code running withing a realize() method should not exit() on >> error. Instad, errors should be propagated through the realize() >> method. Additionally, the realize() method

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-09 Thread Li, Liang Z
> On 12/08/2015 04:08 AM, Liang Li wrote: > > +++ b/util/buffer-zero-avx2.c > > @@ -0,0 +1,54 @@ > > +#include "qemu-common.h" > > + > > +#if defined CONFIG_IFUNC && defined CONFIG_AVX2 #include > > + > > +#define AVX2_VECTYPE__m256i > > +#define AVX2_SPLAT(p) _mm256_set1_epi8(*(p))

Re: [Qemu-devel] Save IDEState data to files when VM shutdown

2015-12-09 Thread Huaicheng Li
> Why are you trying to save the state during shutdown? The structure I added into IDEState keeps being updated when VM is up. So I think it’s a safe way to do this during shutdown. When the VM is started again, it can continue from the status saved during last shutdown. Thanks for your

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> In general, code running withing a realize() method should not exit() on > >> error. Instad, errors should be propagated through the

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-12-09 Thread Pavel Fedin
Hello! > So I think in the end, the one page size we care about is the minimum > IOMMU granularity. We don't really care about the target page size at > all and maybe we only care about the host page size for determining what > might share a page with a sub-page mapping. Ok, so, in v2 i

Re: [Qemu-devel] [PATCHv2 00/10] Clean up pseries machine versioning

2015-12-09 Thread David Gibson
On Mon, Dec 07, 2015 at 02:34:30PM +1100, David Gibson wrote: > Thomas Huth recently posted a patches to switch the default USB > controller for the pseries machine type to xHCI, which necessitated > creating a pseries-2.6 machine type version. > > That raised a bunch of comments suggesting

Re: [Qemu-devel] [PATCH RFC for-2.6 0/3] block: Add meta dirty bitmap for migration/persistence

2015-12-09 Thread Vladimir Sementsov-Ogievskiy
On 08.12.2015 04:36, Fam Zheng wrote: On Mon, 12/07 18:47, John Snow wrote: On 12/07/2015 12:59 AM, Fam Zheng wrote: Vladimir, This is what I propose to implement meta bitmap. It's implemented in the HBitmap level to be more efficient, and the interface slightly varies too. I missed it:

Re: [Qemu-devel] [PATCH] qom: change object property iterator API contract

2015-12-09 Thread Daniel P. Berrange
On Tue, Dec 08, 2015 at 09:05:52AM -0700, Eric Blake wrote: > On 11/27/2015 08:27 AM, Daniel P. Berrange wrote: > > Currently the object property iterator API works as follows > > > > ObjectPropertyIterator *iter; > > > > iter = object_property_iter_init(obj); > > while ((prop =

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Peter Maydell
On 9 December 2015 at 10:29, Dr. David Alan Gilbert wrote: > (OK, to be honest I think we should protect every allocation - but I do > have sympathy with the complexity/testing arguments). My view on this is that Linux overcommits, so the actual likely way that "oops, out of

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 9 December 2015 at 10:29, Dr. David Alan Gilbert > wrote: > > (OK, to be honest I think we should protect every allocation - but I do > > have sympathy with the complexity/testing arguments). > > My view on this is that

[Qemu-devel] [PATCH v2 for-2.6] hw/ppc/spapr: Use XHCI as host controller for new spapr machines

2015-12-09 Thread Thomas Huth
The OHCI has some bugs and performance issues, so for newer machines it's preferable to use XHCI instead. Signed-off-by: Thomas Huth --- v2: rebased this patch to David's latest ppc-for-2.6 branch (which already contains the pseries-2.6 machine definition)

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 09/12/2015 10:30, Markus Armbruster wrote: > > My current working assumption is that passing _fatal to > > memory_region_init_ram() & friends is okay even in realize() methods and > > their supporting code, except when the allocation can be

[Qemu-devel] [PATCH v2] qom: change object property iterator API contract

2015-12-09 Thread Daniel P. Berrange
Currently the object property iterator API works as follows ObjectPropertyIterator *iter; iter = object_property_iter_init(obj); while ((prop = object_property_iter_next(iter))) { ... } object_property_iter_free(iter); This has the benefit that the ObjectPropertyIterator struct

Re: [Qemu-devel] [PATCH v3 4/5] crypto: add QCryptoSecret object class for password/key handling

2015-12-09 Thread Daniel P. Berrange
On Tue, Dec 08, 2015 at 09:49:40AM -0700, Eric Blake wrote: > On 11/27/2015 09:30 AM, Daniel P. Berrange wrote: > > Introduce a new QCryptoSecret object class which will be used > > for providing passwords and keys to other objects which need > > sensitive credentials. > > > > > More examples

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 10:30, Markus Armbruster wrote: > My current working assumption is that passing _fatal to > memory_region_init_ram() & friends is okay even in realize() methods and > their supporting code, except when the allocation can be large. I suspect a lot of memory_region_init_ram()s could

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Lan, Tianyu
On 12/9/2015 6:37 PM, Michael S. Tsirkin wrote: On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: Hi Michael & Alexander: Thanks a lot for your comments and suggestions. It's nice that it's appreciated, but you then go on and ignore all that I have written here:

Re: [Qemu-devel] FD passing for chardevs and chardev backend multiplexing

2015-12-09 Thread Daniel P. Berrange
On Tue, Dec 08, 2015 at 10:04:55AM -0700, Eric Blake wrote: > On 12/08/2015 07:59 AM, Daniel P. Berrange wrote: > > > So for this my plan is to stop using the QEMU 'file' backend for char > > devs and instead pass across a pre-opened file descriptor, connected > > to virtlogd. There is no

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Lan, Tianyu
On 12/9/2015 7:28 PM, Michael S. Tsirkin wrote: I remember reading that it's possible to implement a bus driver on windows if required. But basically I don't see how windows can be relevant to discussing guest driver patches. That discussion probably belongs on the qemu maling list, not on

Re: [Qemu-devel] [Minios-devel] [PATCH v6 0/] Begin to disentangle libxenctrl and provide some stable libraries

2015-12-09 Thread Ian Campbell
On Thu, 2015-12-03 at 11:21 +, Ian Campbell wrote: > > Last time  proposed that these precursors (and the corresponding qemu-xen- > traditional + mini-os patches) should go in now: > > tools/Rules.mk: Properly handle libraries with recursive dependencies. > tools: Refactor

Re: [Qemu-devel] [PATCH RFC for-2.6 0/3] block: Add meta dirty bitmap for migration/persistence

2015-12-09 Thread Vladimir Sementsov-Ogievskiy
On 08.12.2015 04:42, Fam Zheng wrote: On Mon, 12/07 17:19, Vladimir Sementsov-Ogievskiy wrote: On 07.12.2015 08:59, Fam Zheng wrote: Vladimir, This is what I propose to implement meta bitmap. It's implemented in the HBitmap level to be more efficient, and the interface slightly varies too.

Re: [Qemu-devel] [PATCH RFC for-2.6 1/3] HBitmap: Introduce "meta" bitmap to track bit changes

2015-12-09 Thread Vladimir Sementsov-Ogievskiy
On 08.12.2015 04:31, Fam Zheng wrote: On Mon, 12/07 16:32, Vladimir Sementsov-Ogievskiy wrote: On 07.12.2015 08:59, Fam Zheng wrote: The meta bitmap will have the same size and granularity as the tracked bitmap, and upon each bit toggle, the corresponding bit in the meta bitmap, at an

Re: [Qemu-devel] FD passing for chardevs and chardev backend multiplexing

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 12:19, Daniel P. Berrange wrote: > > > Now in practice this doesn't work, because qmp_chardev_open_file() > > > passes the O_CREAT|O_TRUNC flags in, which means the qemu_open() > > > call will fail when using the pipe FD pased in via fdsets. > > > > Is it just the O_TRUNC that is

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Laszlo Ersek
On 12/09/15 11:29, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >>> * Markus Armbruster (arm...@redhat.com) wrote: In general, code running withing a realize() method should not exit() on

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Michael S. Tsirkin
On Wed, Dec 09, 2015 at 07:19:15PM +0800, Lan, Tianyu wrote: > On 12/9/2015 6:37 PM, Michael S. Tsirkin wrote: > >On Sat, Dec 05, 2015 at 12:32:00AM +0800, Lan, Tianyu wrote: > >>Hi Michael & Alexander: > >>Thanks a lot for your comments and suggestions. > > > >It's nice that it's appreciated, but

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Laszlo Ersek
On 12/09/15 12:47, Peter Maydell wrote: > On 9 December 2015 at 10:29, Dr. David Alan Gilbert > wrote: >> (OK, to be honest I think we should protect every allocation - but I do >> have sympathy with the complexity/testing arguments). > > My view on this is that Linux

Re: [Qemu-devel] [PATCH v3 1/5] util: add base64 decoding function

2015-12-09 Thread Daniel P. Berrange
On Tue, Dec 08, 2015 at 09:18:30AM -0700, Eric Blake wrote: > On 11/27/2015 09:30 AM, Daniel P. Berrange wrote: > > The standard glib provided g_base64_decode doesn't provide any > > kind of sensible error checking on its input. Add a QEMU custom > > wrapper qbase64_decode which can be used with

Re: [Qemu-devel] Error handling in realize() methods

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 14:12, Dr. David Alan Gilbert wrote: >> > Even if we don't, we should use _abort, not _fatal >> > (programmer error---due to laziness---rather than user error). >> > _fatal should really be restricted to code that is running very >> > close to main(). > No, we used to have

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-09 Thread Ian Campbell
On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > index 5e324ef..c96d974 100644 > --- a/hw/display/xenfb.c > +++ b/hw/display/xenfb.c > @@ -104,9 +104,8 @@ static int common_bind(struct common *c) >  if

Re: [Qemu-devel] [Xen-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-09 Thread Andrew Cooper
On 09/12/15 13:41, Ian Campbell wrote: > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: >> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c >> index 5e324ef..c96d974 100644 >> --- a/hw/display/xenfb.c >> +++ b/hw/display/xenfb.c >> @@ -104,9 +104,8 @@ static int common_bind(struct

Re: [Qemu-devel] [PATCH v4 0/4] Extend TPM support with a QEMU-external

2015-12-09 Thread Silviu Vlăsceanu
Hi, is there any progress with upstreaming this patch or with adding support for CUSE TPM, in general? Or are there other plans for vTPM support? Thank you, Silviu

Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting

2015-12-09 Thread Paolo Bonzini
On 07/12/2015 22:53, Andrew Baumann wrote: >>> I think those should be fixed by modifying lan9118_*_mem_ops and >>> adding .valid.{min,max}_access_size. Not for 2.5, however. >>> (Probably these patches should also be 2.6 + qemu-stable rather >>> than 2.5). > Just to clarify: would you guys

[Qemu-devel] [PATCH v4 4/5] crypto: add QCryptoSecret object class for password/key handling

2015-12-09 Thread Daniel P. Berrange
Introduce a new QCryptoSecret object class which will be used for providing passwords and keys to other objects which need sensitive credentials. The new object can provide secret values directly as properties, or indirectly via a file. The latter includes support for file descriptor passing

[Qemu-devel] [PATCH v4 1/5] util: add base64 decoding function

2015-12-09 Thread Daniel P. Berrange
The standard glib provided g_base64_decode doesn't provide any kind of sensible error checking on its input. Add a QEMU custom wrapper qbase64_decode which can be used with untrustworthy input that can contain invalid base64 characters, embedded NUL characters, or not be NUL terminated at all.

Re: [Qemu-devel] [Qemu-block] QEMU being able to use audio cdroms

2015-12-09 Thread Victor Toso
Hi, On Tue, Dec 08, 2015 at 02:00:39PM -0500, Programmingkid wrote: > > On Dec 8, 2015, at 1:49 PM, John Snow wrote: > > > > > > > On 11/25/2015 03:44 PM, Programmingkid wrote: > >> Is there any platform where a guest in QEMU can play an audio cd? If not, > >> is this a feature that you

[Qemu-devel] [PATCH v4 0/5] Add framework for passing secrets to QEMU

2015-12-09 Thread Daniel P. Berrange
This small series contains the basic patches for adding a secrets object previously posted: WIP: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html v2: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05297.html v3:

[Qemu-devel] [PATCH v4 5/5] crypto: add support for loading encrypted x509 keys

2015-12-09 Thread Daniel P. Berrange
Make use of the QCryptoSecret object to support loading of encrypted x509 keys. The optional 'passwordid' parameter to the tls-creds-x509 object type, provides the ID of a secret object instance that holds the decryption password for the PEM file. # printf "123456" > mypasswd.txt # $QEMU \

Re: [Qemu-devel] [PATCH v3 1/5] util: add base64 decoding function

2015-12-09 Thread Eric Blake
On 12/09/2015 05:50 AM, Daniel P. Berrange wrote: > On Tue, Dec 08, 2015 at 09:18:30AM -0700, Eric Blake wrote: >> On 11/27/2015 09:30 AM, Daniel P. Berrange wrote: >>> The standard glib provided g_base64_decode doesn't provide any >>> kind of sensible error checking on its input. Add a QEMU

Re: [Qemu-devel] [Xen-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-09 Thread Ian Campbell
On Wed, 2015-12-09 at 13:56 +, Andrew Cooper wrote: > On 09/12/15 13:41, Ian Campbell wrote: > > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > > index 5e324ef..c96d974 100644 > > > --- a/hw/display/xenfb.c > > > +++

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-09 Thread Richard Henderson
On 12/09/2015 01:32 AM, Li, Liang Z wrote: I think you means the ' __attribute__((target("avx2")))', I have tried this way, the issue here is: without the ' -mavx2' option for gcc, there are compiling error: '__m256i undeclared', the __attribute__((target("avx2"))) can't solve this issue.

Re: [Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2015-12-09 Thread Didier Pallard
On 12/07/2015 02:59 PM, Marc-André Lureau wrote: Hi On Mon, Dec 7, 2015 at 2:37 PM, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard wrote: Using guest_notifier_mask function in vhost-user case may break

[Qemu-devel] [PATCH v4 3/5] qga: convert to use error checked base64 decode

2015-12-09 Thread Daniel P. Berrange
Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qga/commands-posix.c | 11 +-- qga/commands-win32.c | 11 +--

[Qemu-devel] [PATCH v4 2/5] qemu-char: convert to use error checked base64 decode

2015-12-09 Thread Daniel P. Berrange
Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qapi-schema.json | 2 -- qemu-char.c | 8 +++- qmp-commands.hx | 2

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-09 Thread P J P
Hello Jason, Dmitry, +-- On Tue, 8 Dec 2015, P J P wrote --+ | |1) VMXNET3_CMD_QUIESCE_DEV | | IIUC, it is used to pause the device when the receiver end is unable to | keee-up with the incoming flow. After a brief period, the operation could be | resumed again. | | |2) VMXNET3_REG_DSAL

Re: [Qemu-devel] HTTP access to QEMU Git repositories

2015-12-09 Thread Laszlo Ersek
On 12/09/15 17:09, Kai Noda wrote: > Hello, is it possible to enable Git-over-HTTP on git.qemu.org > ? > > http://git.qemu.org/?p=dtc.git;a=summary > The summary page shows http://git.qemu.org/git/dtc.git but, > > $ curl http://git.qemu.org/git/dtc.git > > > 301 Moved

Re: [Qemu-devel] [PATCH v4 4/5] crypto: add QCryptoSecret object class for password/key handling

2015-12-09 Thread Eric Blake
On 12/09/2015 07:08 AM, Daniel P. Berrange wrote: > Introduce a new QCryptoSecret object class which will be used > for providing passwords and keys to other objects which need > sensitive credentials. > > > More examples are shown in the updated docs. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [Xen-devel] [PATCH v3 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-09 Thread Stefano Stabellini
On Tue, 8 Dec 2015, Jan Beulich wrote: > The remaining log message in pci_msix_write() is wrong, as there guest > behavior may only appear to be wrong: For one, the old logic didn't > take the mask-all bit into account. And then this shouldn't depend on > host device state (i.e. the host may have

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-09 Thread Eduardo Habkost
On Tue, Dec 08, 2015 at 03:07:22PM +0100, Gerd Hoffmann wrote: > rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, > use it for both xen and non-xen init. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_piix.c | 11 +-- > 1 file changed, 5 insertions(+), 6

[Qemu-devel] HTTP access to QEMU Git repositories

2015-12-09 Thread Kai Noda
Hello, is it possible to enable Git-over-HTTP on git.qemu.org ? http://git.qemu.org/?p=dtc.git;a=summary The summary page shows http://git.qemu.org/git/dtc.git but, $ curl http://git.qemu.org/git/dtc.git 301 Moved Permanently Moved Permanently The document has moved

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-09 Thread Alexander Duyck
On Wed, Dec 9, 2015 at 1:28 AM, Lan, Tianyu wrote: > > > On 12/8/2015 1:12 AM, Alexander Duyck wrote: >> >> On Mon, Dec 7, 2015 at 7:40 AM, Lan, Tianyu wrote: >>> >>> On 12/5/2015 1:07 AM, Alexander Duyck wrote: > > > > We still need to

Re: [Qemu-devel] [PATCH v4 1/5] util: add base64 decoding function

2015-12-09 Thread Eric Blake
On 12/09/2015 07:08 AM, Daniel P. Berrange wrote: > The standard glib provided g_base64_decode doesn't provide any > kind of sensible error checking on its input. Add a QEMU custom > wrapper qbase64_decode which can be used with untrustworthy > input that can contain invalid base64 characters,

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-09 Thread Victor Kaplansky
On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard > wrote: > > unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all > > is used to send a message and retries as long as

Re: [Qemu-devel] [Xen-devel] [PATCH v3 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-09 Thread Jan Beulich
>>> On 09.12.15 at 16:55, wrote: > On Tue, 8 Dec 2015, Jan Beulich wrote: >> The remaining log message in pci_msix_write() is wrong, as there guest >> behavior may only appear to be wrong: For one, the old logic didn't >> take the mask-all bit into account. And

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-09 Thread Lan, Tianyu
On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: I thought about what this is doing at the high level, and I do have some value in what you are trying to do, but I also think we need to clarify the motivation a bit more. What you are saying is not really what the patches are doing. And with

[Qemu-devel] i2c data address question was Re: [PATCH RFC] i2c-tiny-usb

2015-12-09 Thread Tim Sander
Hi Paolo and List Am Freitag, 27. November 2015, 13:53:22 schrieb Paolo Bonzini: > On 27/11/2015 13:39, Tim Sander wrote: > > I have one more thing, i2cdetect looks like this: > > 0 1 2 3 4 5 6 7 8 9 a b c d e f > > > > 00: 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f > >

Re: [Qemu-devel] [PATCH v2] xen_pt: fix failure of attaching & detaching a PCI device to VM repeatedly

2015-12-09 Thread Stefano Stabellini
On Wed, 9 Dec 2015, Jianzhong,Chang wrote: > Add pci = [ '$VF_BDF1', '$VF_BDF2', '$VF_BDF3'] in > hvm guest configuration file. After the guest boot up, > detach the VFs in sequence by > "xl pci-detach $DOMID $VF_BDF1" > "xl pci-detach $DOMID $VF_BDF2" > "xl pci-detach $DOMID $VF_BDF3" > and

Re: [Qemu-devel] HTTP access to QEMU Git repositories

2015-12-09 Thread Eric Blake
On 12/09/2015 09:09 AM, Kai Noda wrote: > Hello, is it possible to enable Git-over-HTTP on git.qemu.org ? I don't know, but repo.or.cz offers both mirroring and http access: http://repo.or.cz/qemu.git > I'd like to access to QEMU Git repositories through HTTP proxy which blocks > the Git port

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2015-12-09 Thread Didier Pallard
On 12/09/2015 04:59 PM, Victor Kaplansky wrote: On Mon, Dec 07, 2015 at 02:31:36PM +0100, Marc-André Lureau wrote: Hi On Thu, Dec 3, 2015 at 10:53 AM, Didier Pallard wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send

Re: [Qemu-devel] HTTP access to QEMU Git repositories

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 18:14, Liguori, Anthony wrote: > Alex Bennee and Andreas also should have access as owners. I've just > sent an invite to add Paolo as an owner too. Great, I've created github repos for all of: git://git.qemu-project.org/vgabios.git/

[Qemu-devel] [Bug 1470170] Re: Unsupported syscalls 370 and 355

2015-12-09 Thread John Paul Adrian Glaubitz
Laurent, I just encountered the same missing syscall on qemu-m68k: Unpacking udev (228-2) over (227-2) ... Preparing to unpack .../libsystemd0_228-2_m68k.deb ... Unpacking libsystemd0:m68k (228-2) over (227-2) ... Processing triggers for man-db (2.7.5-1) ... Not building database;

Re: [Qemu-devel] i2c data address question was Re: [PATCH RFC] i2c-tiny-usb

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 17:40, Tim Sander wrote: >> > If there is no slave at the requested address, i2c_start_transfer will >> > return 1. > Ok, that works. Now probably the last problem i see is that i fail to set the > data-address of the i2c-device? > I know the correct offset address for accesses on

Re: [Qemu-devel] HTTP access to QEMU Git repositories

2015-12-09 Thread Liguori, Anthony
Alex Bennee and Andreas also should have access as owners. I've just sent an invite to add Paolo as an owner too. Regards, Anthony Liguori From: Paolo Bonzini on behalf of Paolo Bonzini Sent: Wednesday,

Re: [Qemu-devel] [PATCH v4 1/5] util: add base64 decoding function

2015-12-09 Thread John Snow
On 12/09/2015 09:08 AM, Daniel P. Berrange wrote: > The standard glib provided g_base64_decode doesn't provide any > kind of sensible error checking on its input. Add a QEMU custom > wrapper qbase64_decode which can be used with untrustworthy > input that can contain invalid base64 characters,

Re: [Qemu-devel] [PATCH COLO-Frame v11 19/39] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2015-12-09 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Add checkpoint-delay parameter for migrate-set-parameters, so that > we can control the checkpoint frequency when COLO is in periodic mode. > > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Crosthwaite
On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Tuesday, 8 December 2015 23:40 >> On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann >> wrote: >> >> From: Peter

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 8 December 2015 23:40 > On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Saturday, 5 December 2015 21:26

Re: [Qemu-devel] [PATCH COLO-Frame v11 20/39] COLO: synchronize PVM's state to SVM periodically

2015-12-09 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Do checkpoint periodically, the default interval is 200ms. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Wednesday, 9 December 2015 10:55 > > Yes, that's the same change I made. Is it going to be applied? > > > > It missed the boat for 2.5, but you could help by putting a tested-by > or reviewed-by to the patch. Ok. > > The

[Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints

2015-12-09 Thread Hollis Blanchard
On 11/24/2015 11:20 PM, Stefan Hajnoczi wrote: On Tue, Nov 17, 2015 at 04:37:48PM -0800, Hollis Blanchard wrote: On 11/13/2015 02:23 AM, Stefan Hajnoczi wrote: On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: Recording the MemoryRegion pointers isn't helpful, especially since

Re: [Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 21:54, Hollis Blanchard wrote: > > #0 trace_memory_region_ops_write (mr=0x185b620, addr=16, absaddr=738205712, > value=136, size=4) > at > /scratch1/hblancha/install/customq/qemu-2.4.0/src/trace/generated-tracers.h:7374 > #1 0x0045eb8a in

Re: [Qemu-devel] [PATCH 1/1] Fix do_rt_sigreturn on m68k linux userspace emulation

2015-12-09 Thread Laurent Vivier
Le 09/12/2015 21:54, Michael Karcher a écrit : > do_rt_sigreturn forgets to initialize the signal mask variable before > trying to use it to restore the mask, so the signal mask is undefined > after do_rt_sigreturn. This bug has been in all the time since > 7181155d when do_rt_sigreturn was

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-09 Thread Michael S. Tsirkin
On Thu, Dec 10, 2015 at 12:26:25AM +0800, Lan, Tianyu wrote: > On 12/8/2015 12:50 AM, Michael S. Tsirkin wrote: > >I thought about what this is doing at the high level, and I do have some > >value in what you are trying to do, but I also think we need to clarify > >the motivation a bit more. What

Re: [Qemu-devel] [RFC PATCH 00/40] Sneak peek of virtio and dataplane changes for 2.6

2015-12-09 Thread Paolo Bonzini
On 26/11/2015 11:39, Paolo Bonzini wrote: > I would really prefer to get rid of vring.c as soon as the infrastructure > makes it possible---even if it's faster. We know what makes virtio.c > slower, and it's simpler to fix virtio.c than to convert all the other > models to vring.c _plus_ make

Re: [Qemu-devel] [PATCH 0/1] m68k linux user-space emulation fix (with sign-off this time)

2015-12-09 Thread John Paul Adrian Glaubitz
Hi Laurent! On 12/09/2015 09:54 PM, Michael Karcher wrote: > This patch fixes cmake blocking on m68k when starting the second child > process. cmake relies on getting SIGCHLD to know when the child process > finished, > and the uninitialised sigmask set on return of the first SIGCHLD oftentimes

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Maydell
On 9 December 2015 at 18:54, Peter Crosthwaite wrote: > On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann > wrote: >>> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >>> Is that more likely to be an IP connectivity problem

Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Paolo Bonzini
On 09/12/2015 20:57, Ashok Raj wrote: > +/* > + * We need to read back the value of MSREXT_MCG_CTL that was set by the > + * guest kernel back into Qemu > + */ > +cs->kvm_vcpu_dirty = false; > +cpu_synchronize_state(cs); This should not be necessary. I've only skimmed

Re: [Qemu-devel] [PATCH v2] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-09 Thread Boris Schrijver
Dear all, Thanks for your time so-far. I send a mail to the libcurl development list and got a helpful reaction [1]! I changed my patch accordingly. We now don't have to check for a CURLE_WRITE_ERROR anymore and curl_easy_perform() will return CURLE_OK (0) on success. Please review! commit

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Peter Crosthwaite
On Wed, Dec 9, 2015 at 1:01 PM, Peter Maydell wrote: > On 9 December 2015 at 18:54, Peter Crosthwaite > wrote: >> On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann >> wrote: From: Peter Crosthwaite

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-09 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, 9 December 2015 13:01 > On 9 December 2015 at 18:54, Peter Crosthwaite > wrote: > > On Wed, Dec 9, 2015 at 10:17 AM, Andrew Baumann > > wrote: > >>> From: Peter

Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU

2015-12-09 Thread Paolo Bonzini
On 10/12/2015 00:05, Raj, Ashok wrote: >>> > > +/* >>> > > + * We need to read back the value of MSREXT_MCG_CTL that was set >>> > > by the >>> > > + * guest kernel back into Qemu >>> > > + */ >>> > > +cs->kvm_vcpu_dirty = false; >>> > > +cpu_synchronize_state(cs); >

Re: [Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space

2015-12-09 Thread Mark Cave-Ayland
On 08/12/15 21:28, Peter Maydell wrote: > On 8 December 2015 at 19:59, Richard Henderson wrote: >> On 12/04/2015 07:01 AM, Alex Zuepke wrote: >>> LEON3 allows the CASA instruction to be used from user space >>> if the ASI is set to 0xa (user data). >>> >>> Signed-off-by: Alex

[Qemu-devel] [PATCH 08/74] acpi: extend aml_add() to accept target argument

2015-12-09 Thread Igor Mammedov
it allows to express following ASL expression: Add(arg1, arg2, result) usecases that do not need to store result should pass NULL as 3rd arg that would express Add(arg1, arg2,) construct. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 4 ++--

[Qemu-devel] [PATCH 07/74] acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern

2015-12-09 Thread Igor Mammedov
Currently AML API doesn't compose terms in form of following pattern: Opcode Arg2 Arg2 [Dst] but ASL used in piix4/q35 DSDT ACPI tables uses that form, so for clean conversion of it, AML API should be able to handle an optional 'Dst' argumet used there. Since above pattern is used by

[Qemu-devel] [PATCH 04/74] acpi: add aml_lgreater_equal()

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dc59c08..c1a30a3 100644 --- a/hw/acpi/aml-build.c +++

[Qemu-devel] [PATCH 28/74] pc: acpi: memhp: move MHPD.MSCN method into SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug_acpi_table.c | 48 + hw/i386/acpi-dsdt-mem-hotplug.dsl | 27 + 2 files changed, 49 insertions(+), 26 deletions(-) diff --git

[Qemu-devel] [PATCH 17/74] acpi: add aml_lgreater()

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 8cfa65c..b22e7da 100644 --- a/hw/acpi/aml-build.c +++

[Qemu-devel] [PATCH 38/74] pc: acpi: drop unused CPU_STATUS_LEN from DSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl index 1aff746..53e1389 100644 --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl +++

[Qemu-devel] [PATCH 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/memory_hotplug_acpi_table.c | 12 hw/i386/acpi-dsdt-mem-hotplug.dsl | 8 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/acpi/memory_hotplug_acpi_table.c

[Qemu-devel] [PATCH 50/74] pc: acpi: move FDC0 device from DSDT to SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 38 -- hw/i386/acpi-dsdt-isa.dsl | 18 -- 2 files changed, 32 insertions(+), 24 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index

[Qemu-devel] [PATCH 59/74] pc: acpi: piix4: move remaining PCI hotplug bits into SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 43 +++ hw/i386/acpi-dsdt.dsl | 40 2 files changed, 43 insertions(+), 40 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH 35/74] pc: acpi: factor out memhp code from build_ssdt() into separate function

2015-12-09 Thread Igor Mammedov
before consolidating memhp code in memory_hotplug_acpi_table.c and for simplifying review, first factor out memhp code into new function build_memory_devices() in i386/acpi-build.c Signed-off-by: Igor Mammedov PS: no functional change, only code movement. ---

[Qemu-devel] [PATCH 52/74] pc: acpi: move COM devices from DSDT to SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 27 ++-- hw/i386/acpi-dsdt-isa.dsl | 52 --- hw/i386/acpi-dsdt.dsl | 3 --- hw/i386/q35-acpi-dsdt.dsl | 3 --- 4 files changed, 21

[Qemu-devel] [PATCH 37/74] pc: acpi: memhp: drop not needed stringify(MEMORY_foo) usage

2015-12-09 Thread Igor Mammedov
most of MEMORY_foo defines are not shared with ASL anymore and are used only inside of memory_hotplug_acpi_table.c, so move them there and make them strings. As result we can replace stringify(MEMORY_foo) with just MEMORY_foo, which makes code a bit cleaner. No AML change introduced by this

[Qemu-devel] [PATCH 69/74] pc: acpi: q35: move _PIC() method into SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 8 hw/i386/q35-acpi-dsdt.dsl | 10 -- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b54fb0a..bd8d864 100644 ---

[Qemu-devel] [PATCH 41/74] pc: acpi: cpuhp: move CPST() method into SSDT

2015-12-09 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug_acpi_table.c | 18 ++ hw/i386/acpi-build.c | 3 ++- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 12 include/hw/acpi/cpu_hotplug.h | 1 + 4 files changed, 21 insertions(+), 13

  1   2   3   >