[Qemu-devel] [PATCH] keyboard: fix qemu load empty keymap

2016-11-02 Thread Wang Xin
qemu_find_file do not check file is a directory or just a file. If qemu start with "-k ''", qemu_find_file get a empty string as keymap file name, then, qemu treat the keymap path as keymap file, it makes vnc keyboard input unusable. Signed-off-by: Wang Xin diff

[Qemu-devel] 答复: [PATCH v4 5/5] object: Add 'help' option for all available backends and properties

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> '-object help' prints available user creatable backends. '-object $typename,help' prints relevant properties. Signed-off-by: Lin Ma --- include/qom/object_interfaces.h | 2 ++ qemu-options.hx |

[Qemu-devel] 答复: [PATCH v4 3/5] qapi: add test case for the generated enum value str

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma --- tests/test-qmp-commands.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 81cbe54..9cd61b2 100644 ---

[Qemu-devel] 答复: [PATCH v4 2/5] qapi: auto generate enum value strings

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> Automatically generate enum value strings that containing the acceptable values. (Borrowed Daniel's code.) Signed-off-by: Lin Ma --- scripts/qapi-types.py | 2 ++ scripts/qapi.py| 9 + 2 files changed, 11

[Qemu-devel] 答复: [PATCH v4 4/5] backends: add description for enum class properties

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma --- backends/hostmem.c | 4 crypto/secret.c| 4 crypto/tlscreds.c | 4 net/filter.c | 4 4 files changed, 16 insertions(+) diff --git a/backends/hostmem.c

[Qemu-devel] 答复: [PATCH v4 1/5] qom: Add interface check in object_class_is_abstract

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> Signed-off-by: Lin Ma --- qom/object.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 7a05e35..4096645 100644 --- a/qom/object.c +++ b/qom/object.c @@ -747,7

[Qemu-devel] 答复: [PATCH v4 0/5] object: Add 'help' option for all available backends and properties

2016-11-02 Thread Lin Ma
ping... >>> Lin Ma 2016/10/20 星期四 下午 7:28 >>> V3->V4: * drop the code about manually define interface 'user-creatable' as abstract. * add test case for the generated enum value str. * split the code about adding descriptions to class properties into a separate patch. * minor

Re: [Qemu-devel] [PATCH v3 0/4] nvdimm: hotplug support

2016-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 03:01:33PM +0100, Igor Mammedov wrote: > On Sat, 29 Oct 2016 00:35:36 +0800 > Xiao Guangrong wrote: > > > It is based on my previous patchset, > > "[PATCH 0/8] nvdimm acpi: bug fix and cleanup", these two patchset are > > against commit

Re: [Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support

2016-11-02 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 12:25:01PM +0800, Xiao Guangrong wrote: > > > On 11/03/2016 12:14 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 03, 2016 at 11:51:27AM +0800, Xiao Guangrong wrote: > > > Resend these 3 patches to catch up release window... > > > > > > Igor, > > > > > > this is a open

Re: [Qemu-devel] [kvm-unit-tests PATCHv7 2/3] arm: pmu: Check cycle count increases

2016-11-02 Thread cov
Hi Wei, Thanks for your work on this. On 2016-11-02 16:22, Wei Huang wrote: Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, even for the smallest delta of two subsequent reads. Signed-off-by: Christopher Covington Signed-off-by: Wei Huang

Re: [Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support

2016-11-02 Thread Xiao Guangrong
On 11/03/2016 12:14 PM, Michael S. Tsirkin wrote: On Thu, Nov 03, 2016 at 11:51:27AM +0800, Xiao Guangrong wrote: Resend these 3 patches to catch up release window... Igor, this is a open that i did not pass a buffer as parameter to RFIT as tried the way you suggested, but failed. May be i

Re: [Qemu-devel] [PATCH v9 04/12] vfio iommu: Add support for mediated devices

2016-11-02 Thread Alexey Kardashevskiy
On 03/11/16 00:18, Kirti Wankhede wrote: > > > On 11/2/2016 6:30 PM, Jike Song wrote: >> On 11/02/2016 08:41 PM, Kirti Wankhede wrote: >>> On 11/2/2016 5:51 PM, Jike Song wrote: On 11/02/2016 12:09 PM, Alexey Kardashevskiy wrote: > Or you could just reference and use @mm as KVM and

Re: [Qemu-devel] [PATCH] hw/pci: disable pci-bridge's shpc by default

2016-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 05:16:42PM +0200, Marcel Apfelbaum wrote: > The shpc component is optional while ACPI hotplug is used > for hot-plugging PCI devices into a PCI-PCI bridge. > Disabling the shpc by default will make slot 0 usable at boot time at the cost of breaking all hotplug for all

Re: [Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support

2016-11-02 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 11:51:27AM +0800, Xiao Guangrong wrote: > Resend these 3 patches to catch up release window... > > Igor, > > this is a open that i did not pass a buffer as parameter to RFIT as > tried the way you suggested, but failed. May be i am not very good at > ASL, i need more time

[Qemu-devel] [PATCH v4 3/3] pc: memhp: enable nvdimm device hotplug

2016-11-02 Thread Xiao Guangrong
_GPE.E04 is dedicated for nvdimm device hotplug Signed-off-by: Xiao Guangrong --- default-configs/mips-softmmu-common.mak | 1 + docs/specs/acpi_nvdimm.txt | 5 + hw/acpi/ich9.c | 8 ++-- hw/acpi/nvdimm.c

[Qemu-devel] [PATCH v4 1/3] nvdimm acpi: introduce fit buffer

2016-11-02 Thread Xiao Guangrong
The buffer is used to save the FIT info for all the presented nvdimm devices which is updated after the nvdimm device is plugged or unplugged. In the later patch, it will be used to construct NVDIMM ACPI _FIT method which reflects the presented nvdimm devices after nvdimm hotplug As FIT buffer

[Qemu-devel] [PATCH v4 0/3] nvdimm: hotplug support

2016-11-02 Thread Xiao Guangrong
Resend these 3 patches to catch up release window... Igor, this is a open that i did not pass a buffer as parameter to RFIT as tried the way you suggested, but failed. May be i am not very good at ASL, i need more time to try. So let's keep the way as it is, i will improve it later. Thanks!

[Qemu-devel] [PATCH v5 03/10] pci: Convert msix_init() to Error and fix callers to check it

2016-11-02 Thread Cao jin
msix_init() reports errors with error_report(), which is wrong when it's used in realize(). The same issue was fixed for msi_init() in commit 1108b2f. For some devices(like e1000e, vmxnet3) who won't fail because of msix_init's failure, suppress the error report by passing NULL error object.

[Qemu-devel] [PATCH v5 02/10] hcd-xhci: check & correct param before using it

2016-11-02 Thread Cao jin
usb_xhci_realize() corrects invalid values of property "intrs" automatically, but the uncorrected value is passed to msi_init(), which chokes on invalid values. Delay that until after the correction. Resources allocated by usb_xhci_init() are leaked when msi_init() fails. Fix by calling it

[Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-02 Thread Xiao Guangrong
_FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely mapped into guest address space, so a new function, Read FIT whose UUID is UUID 648B9CF2-CDA1-4312-8AD9-49C4AF32BD62, handle 0x1, function

[Qemu-devel] [PATCH v5 09/10] vmxnet3: remove unnecessary internal msix flag

2016-11-02 Thread Cao jin
Internal flag msix_used is unnecessary, it has the same effect as msix_enabled(). The corresponding msi flag is already dropped in commit 1070048e. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Michael S. Tsirkin

[Qemu-devel] [PATCH v5 06/10] megasas: remove unnecessary megasas_use_msix()

2016-11-02 Thread Cao jin
Also move certain hunk above, to place msix init related code together. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus

[Qemu-devel] [PATCH v5 04/10] megasas: change behaviour of msix switch

2016-11-02 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. Also undo the overwrites of user configuration of msix. CC: Michael S. Tsirkin CC: Hannes Reinecke CC: Paolo Bonzini CC:

[Qemu-devel] [PATCH v5 10/10] msi_init: convert assert to return -errno

2016-11-02 Thread Cao jin
According to the disscussion: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg08215.html Let leaf function returns reasonable -errno, let caller decide how to handle the return value. Suggested-by: Markus Armbruster CC: Markus Armbruster CC:

[Qemu-devel] [PATCH v5 08/10] vmxnet3: fix reference leak issue

2016-11-02 Thread Cao jin
On migration target, msix_vector_use() will be called in vmxnet3_post_load() in second time, without a matching second call to msi_vector_unuse(), which results in vector reference leak. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster

[Qemu-devel] [PATCH v5 05/10] hcd-xhci: change behaviour of msix switch

2016-11-02 Thread Cao jin
Resolve the TODO, msix=auto means msix on; if user specify msix=on, then device creation fail on msix_init failure. CC: Gerd Hoffmann CC: Michael S. Tsirkin CC: Markus Armbruster CC: Marcel Apfelbaum Reviewed-by: Gerd

[Qemu-devel] [PATCH v5 01/10] msix: Follow CODING_STYLE

2016-11-02 Thread Cao jin
CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/msix.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[Qemu-devel] [PATCH v5 00/10] Convert msix_init() to error

2016-11-02 Thread Cao jin
v5 changelog: 1. Address to all comments of Markus 2. Add the given R-b to each commit message. Cao jin (10): msix: Follow CODING_STYLE hcd-xhci: check & correct param before using it pci: Convert msix_init() to Error and fix callers to check it megasas: change behaviour of msix switch

[Qemu-devel] [PATCH v5 07/10] megasas: undo the overwrites of msi user configuration

2016-11-02 Thread Cao jin
Commit afea4e14 seems forgetting to undo the overwrites, which is unsuitable. CC: Hannes Reinecke CC: Paolo Bonzini CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Reviewed-by: Markus

Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features

2016-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2016 at 01:14:07PM +, Peter Maydell wrote: > On 2 November 2016 at 04:35, Michael S. Tsirkin wrote: > > On Tue, Nov 01, 2016 at 03:22:01PM +, Peter Maydell wrote: > >> On 30 October 2016 at 21:23, Michael S. Tsirkin wrote: > >> > The

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

2016-11-02 Thread Zhang Chen
On 11/02/2016 09:29 PM, Eric Blake wrote: On 11/01/2016 08:32 PM, Zhang Chen wrote: I still don't understand the comment in docs/colo-proxy.txt. Me neither. Which part of the docs/colo-proxy.txt? The one quoted below. Perhaps I can explain it more clearly and make the doc better.

[Qemu-devel] [PATCH] intel_iommu: fixing source id during IOTLB hash key calculation

2016-11-02 Thread Jason Wang
Using uint8_t for source id will lose bus num and get the wrong/invalid IOTLB entry. Fixing by using uint16_t instead and enlarge level shift. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Michael S. Tsirkin

[Qemu-devel] slirp: fix ipv6 guest network access with windows host

2016-11-02 Thread Bo Hu
Hello qemu developers, This patch is from android emulator (which is based on qemu2.2) and I hope this patch is also useful to upstream qemu as well. bo >From 021eac8c593a34a6a5e106d187a8e1fd22a1522f Mon Sep 17 00:00:00 2001 From: bohu Date: Wed, 2 Nov 2016 15:56:26

Re: [Qemu-devel] [Qemu-stable] [Qemu-ppc] [PULL 0/4] ppc patches for qemu-2.7 stable branch

2016-11-02 Thread Michael Roth
Quoting David Gibson (2016-10-31 21:26:39) > On Tue, Oct 25, 2016 at 06:57:33PM -0500, Michael Roth wrote: > > Quoting David Gibson (2016-10-24 20:41:29) > > > On Mon, Oct 17, 2016 at 04:24:31PM -0500, Michael Roth wrote: > > > > Quoting Peter Maydell (2016-10-17 13:45:21) > > > > > On 17 October

Re: [Qemu-devel] slirp: fix ipv6 guest network access with windows host

2016-11-02 Thread Samuel Thibault
Hello, Bo Hu, on Wed 02 Nov 2016 16:02:29 -0700, wrote: >     This patch is from android emulator (which is based on qemu2.2) and I hope > this patch is > also useful to upstream qemu as well. Indeed, even if normally we fill all required fields, it's probably better to memset the whole

[Qemu-devel] [kvm-unit-tests PATCHv7 3/3] arm: pmu: Add CPI checking

2016-11-02 Thread Wei Huang
Calculate the numbers of cycles per instruction (CPI) implied by ARM PMU cycle counter values. Signed-off-by: Christopher Covington --- arm/pmu.c | 109 +- 1 file changed, 108 insertions(+), 1 deletion(-) diff

[Qemu-devel] [kvm-unit-tests PATCHv7 2/3] arm: pmu: Check cycle count increases

2016-11-02 Thread Wei Huang
Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, even for the smallest delta of two subsequent reads. Signed-off-by: Christopher Covington Signed-off-by: Wei Huang --- arm/pmu.c | 100

[Qemu-devel] [kvm-unit-tests PATCHv7 0/3] ARM PMU tests

2016-11-02 Thread Wei Huang
Changes from v6: * Add a new pmu testing for KVM mode in config file * Add additional init code, including setting PMCNTENSET and PMCCFILTR, before reading PMCCNTR. ARMv7 support is also provided * Add cycle counter init code for CPI testing * Fix pmu_data compilation issue (for gcc 4.8.5) *

[Qemu-devel] [kvm-unit-tests PATCHv7 1/3] arm: Add PMU test

2016-11-02 Thread Wei Huang
Beginning with a simple sanity check of the control register, add a unit test for the ARM Performance Monitors Unit (PMU). Signed-off-by: Christopher Covington --- arm/Makefile.common | 3 +- arm/pmu.c | 82 +

Re: [Qemu-devel] [Bug 1636217] Re: qemu-kvm 2.7 does not boot kvm VMs with virtio on top of VMware ESX

2016-11-02 Thread Laszlo Ersek
Adding Gerd, Marcel, and Kevin On 10/28/16 10:23, Fabian Grünbichler wrote: > I traced this back to the switch to enabling virtio-1 mode by default in > 2.7 in commit 9a4c0e220d8a4f82b5665d0ee95ef94d8e1509d5 > > forcing the old behaviour with a 2.6 machine type works. I think this issue is a

Re: [Qemu-devel] when we add EL2 to QEMU TCG ARM emulation and the virt board, should it default on or off?

2016-11-02 Thread Laszlo Ersek
On 11/01/16 18:16, Peter Maydell wrote: > I'm working on turning on EL2 support in our TCG ARM emulation, > and one area I'm not sure about is whether it should default to > on or off. > > We have a few precedents: > > For EL3 support: > * the CPU property is enabled by default but can be

[Qemu-devel] [PATCH v2 3/3] target-m68k: add cas/cas2 ops

2016-11-02 Thread Laurent Vivier
Implement CAS using cmpxchg. Implement CAS2 using helper and either cmpxchg when the 32bit addresses are consecutive, or with parallel_cpus+cpu_loop_exit_atomic() otherwise. Suggested-by: Richard Henderson Signed-off-by: Laurent Vivier ---

[Qemu-devel] [PATCH v2 1/3] target-m68k: add abcd/sbcd/nbcd

2016-11-02 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 242 1 file changed, 242 insertions(+) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index d0a3b0f..1cf88a4 100644 --- a/target-m68k/translate.c +++

[Qemu-devel] [PATCH v2 2/3] target-m68k: implement 680x0 movem

2016-11-02 Thread Laurent Vivier
680x0 movem can load/store words and long words and can use more addressing modes. Coldfire can only use long words with (Ax) and (d16,Ax) addressing modes. Signed-off-by: Laurent Vivier --- target-m68k/translate.c | 96 - 1

[Qemu-devel] [PATCH v2 0/3] target-m68k: add movem, BCD and CAS instructions

2016-11-02 Thread Laurent Vivier
This series is another subset of the series I sent in May: https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00501.html This subset contains reworked patches for: - abcd/nbcd/sbcd: remove inline, delay write back to memory and use only 3 digits (and extract it from the bifield patch as

[Qemu-devel] [PULL 0/2] tags/xen-20161102-tag

2016-11-02 Thread Stefano Stabellini
-20161102-tag for you to fetch changes up to 021746c131cdfeab9d82ff918795a9f18d20d7ae: PCMachineState: introduce acpi_build_enabled field (2016-11-02 12:26:12 -0700) Xen 2016/11/02

[Qemu-devel] [PULL 2/2] PCMachineState: introduce acpi_build_enabled field

2016-11-02 Thread Stefano Stabellini
From: Wei Liu Introduce this field to control whether ACPI build is enabled by a particular machine or accelerator. It defaults to true if the machine itself supports ACPI build. Xen accelerator will disable it because Xen is in charge of building ACPI tables for the guest.

[Qemu-devel] [PULL 1/2] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Stefano Stabellini
From: Thomas Huth Olaf Hering reported a build failure due to an undefined reference to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to fix the issue. Signed-off-by: Thomas Huth Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Stefano Stabellini
On Wed, 2 Nov 2016, Peter Maydell wrote: > On 2 November 2016 at 17:34, Stefano Stabellini > wrote: > > On Wed, 2 Nov 2016, Thomas Huth wrote: > >> Olaf Hering reported a build failure due to an undefined reference > >> to 'qemu_log_vprintf'. Explicitely including

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Peter Maydell
On 2 November 2016 at 17:34, Stefano Stabellini wrote: > On Wed, 2 Nov 2016, Thomas Huth wrote: >> Olaf Hering reported a build failure due to an undefined reference >> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to >> fix the issue. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v4 1/2] util/mmap-alloc: check parameter before using

2016-11-02 Thread Thomas Huth
On 02.11.2016 14:44, Cao jin wrote: > Signed-off-by: Cao jin > --- > util/mmap-alloc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c > index 5a85aa3..d713a72 100644 > --- a/util/mmap-alloc.c > +++

Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-11-02 Thread John Snow
On 11/02/2016 03:49 PM, Hervé Poussineau wrote: Le 01/11/2016 à 04:16, John Snow a écrit : v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general

[Qemu-devel] [PATCH] target-i386: fix typo

2016-11-02 Thread Paolo Bonzini
The impact is small because kvm_get_vcpu_events fixes env->hflags, but it is wrong and could cause INITs to be delayed arbitrarily with -machine kernel_irqchip=off. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-11-02 Thread Hervé Poussineau
Le 01/11/2016 à 04:16, John Snow a écrit : v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general proof for ATAPI regardless of the HBA used. All

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Olaf Hering
On Wed, Nov 02, Thomas Huth wrote: > Olaf Hering reported a build failure due to an undefined reference > to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to > fix the issue. > > Signed-off-by: Thomas Huth Tested-by: Olaf Hering Olaf

Re: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

2016-11-02 Thread John Snow
On 10/31/2016 11:16 PM, John Snow wrote: v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general proof for ATAPI regardless of the HBA used.

Re: [Qemu-devel] [PATCH for-2.8? 3/3] block/curl: Drop TFTP "support"

2016-11-02 Thread Jeff Cody
On Wed, Nov 02, 2016 at 06:55:39PM +0100, Max Reitz wrote: > Because TFTP does not support byte ranges, it was never usable with our > curl block driver. Since apparently nobody has ever complained loudly > enough for someone to take care of the issue until now, it seems > reasonable to assume

Re: [Qemu-devel] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol

2016-11-02 Thread Jeff Cody
On Wed, Nov 02, 2016 at 06:55:38PM +0100, Max Reitz wrote: > A follow-up patch will remove the curl block driver's TFTP support, so > remove the protocol from the QAPI schema. > > Signed-off-by: Max Reitz > --- > docs/qmp-commands.txt | 2 +- > qapi/block-core.json | 7

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-02 Thread Jeff Cody
On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any

Re: [Qemu-devel] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support

2016-11-02 Thread Jeff Cody
On Wed, Nov 02, 2016 at 06:55:37PM +0100, Max Reitz wrote: > A follow-up patch will remove the curl block driver's TFTP support; > therefore, we should no longer mention it anywhere in our documentation. > > Signed-off-by: Max Reitz > --- > qemu-options.hx | 6 +++--- > 1

Re: [Qemu-devel] [PATCH v2] mttcg: Handle EXCP_ATOMIC exception

2016-11-02 Thread Alex Bennée
Paolo Bonzini writes: > On 02/11/2016 17:40, Pranith Kumar wrote: >> The patch enables handling atomic code in the guest. This should be >> preferably done in cpu_handle_exception(), but the current assumptions >> regarding when we can execute atomic sections cause a

Re: [Qemu-devel] [Qemu-block] [PULL v2 00/14] Block patches for 2.8

2016-11-02 Thread Peter Maydell
On 2 November 2016 at 17:03, Stefan Hajnoczi wrote: > On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote: >> The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into

[Qemu-devel] [PATCH for-2.8? 3/3] block/curl: Drop TFTP "support"

2016-11-02 Thread Max Reitz
Because TFTP does not support byte ranges, it was never usable with our curl block driver. Since apparently nobody has ever complained loudly enough for someone to take care of the issue until now, it seems reasonable to assume that nobody has ever actually used it. Therefore, it should be safe

[Qemu-devel] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support

2016-11-02 Thread Max Reitz
A follow-up patch will remove the curl block driver's TFTP support; therefore, we should no longer mention it anywhere in our documentation. Signed-off-by: Max Reitz --- qemu-options.hx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx

[Qemu-devel] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol

2016-11-02 Thread Max Reitz
A follow-up patch will remove the curl block driver's TFTP support, so remove the protocol from the QAPI schema. Signed-off-by: Max Reitz --- docs/qmp-commands.txt | 2 +- qapi/block-core.json | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-02 Thread Max Reitz
See patch 3 for the reason why we have actually never supported TFTP at all (except for very small files (i.e. below 256 kB or so)). I would consider this series a bug fix because, well, it doesn't really change any functionality, and the bug is "We don't support TFTP but we pretend we do".

[Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

2016-11-02 Thread John Snow
Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the block_job_start mechanism and start the jobs automatically as we have been doing, with conversions

[Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

2016-11-02 Thread John Snow
Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of nearly-identical interfaces that would have to be edited to keep up with QAPI changes in the future.

[Qemu-devel] [PATCH v3 0/6] jobs: fix transactional race condition

2016-11-02 Thread John Snow
There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave well known state and the QLIST can get corrupted and the transactional jobs can complete

[Qemu-devel] [PATCH v3 6/6] iotests: add transactional failure race test

2016-11-02 Thread John Snow
Add a regression test for the case found by Vladimir. Reported-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/124 | 53 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files

[Qemu-devel] [PATCH v3 2/6] blockjob: add .clean property

2016-11-02 Thread John Snow
Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to enter its cleanup routine. The second job,

[Qemu-devel] [PATCH v3 3/6] blockjob: add .start field

2016-11-02 Thread John Snow
Add an explicit start field to specify the entrypoint. We already have ownership of the coroutine itself AND managing the lifetime of the coroutine, let's take control of creation of the coroutine, too. This will allow us to delay creation of the actual coroutine until we know we'll actually

[Qemu-devel] [PATCH v3 1/6] blockjob: fix dead pointer in txn list

2016-11-02 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Though it is not intended to be reached through normal circumstances, if we do not gracefully deconstruct the transaction QLIST, we may wind up with stale pointers in the list. The rest of this series attempts to address the

Re: [Qemu-devel] [PATCH v9 00/12] virtio-crypto: introduce framework and device emulation

2016-11-02 Thread Halil Pasic
On 10/31/2016 03:52 AM, Gonglei (Arei) wrote: >> > Unfortunately I encountered a problem already on x86_64, more precisely >> > the guest hangs in virtio_crypto_alg_ablkcipher_init_session after the >> > kick. But before I start explaining in detail let me ask you: what are >> > your plans for

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Stefano Stabellini
On Wed, 2 Nov 2016, Thomas Huth wrote: > Olaf Hering reported a build failure due to an undefined reference > to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to > fix the issue. > > Signed-off-by: Thomas Huth The fix makes sense: Acked-by: Stefano Stabellini

Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

2016-11-02 Thread Laurent Vivier
Le 02/11/2016 à 18:23, Stefan Hajnoczi a écrit : > On Wed, Nov 2, 2016 at 5:17 PM, Stefan Hajnoczi wrote: >> On Wed, Nov 2, 2016 at 5:12 PM, Laurent Vivier wrote: >>> Le 02/11/2016 à 18:07, Stefan Hajnoczi a écrit : On Mon, Oct 31, 2016 at 10:50:29AM

Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

2016-11-02 Thread Stefan Hajnoczi
On Wed, Nov 2, 2016 at 5:17 PM, Stefan Hajnoczi wrote: > On Wed, Nov 2, 2016 at 5:12 PM, Laurent Vivier wrote: >> Le 02/11/2016 à 18:07, Stefan Hajnoczi a écrit : >>> On Mon, Oct 31, 2016 at 10:50:29AM +0100, Laurent Vivier wrote: The following changes

Re: [Qemu-devel] Mysterious RST connection with virtio-net NATting VM

2016-11-02 Thread Neil Skrypuch
On October 21, 2016 04:34:38 PM Neil Skrypuch wrote: > I have a NATting VM (let's call this vm/nat) sitting in front of another VM > (let's call this one vm/wget), with vm/wget residing in a private virtual > network, with all network connectivity for vm/wget going through vm/nat. > Additionally,

Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

2016-11-02 Thread Stefan Hajnoczi
On Wed, Nov 2, 2016 at 5:12 PM, Laurent Vivier wrote: > Le 02/11/2016 à 18:07, Stefan Hajnoczi a écrit : >> On Mon, Oct 31, 2016 at 10:50:29AM +0100, Laurent Vivier wrote: >>> The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >>> >>> Merge

Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

2016-11-02 Thread Laurent Vivier
Le 02/11/2016 à 18:07, Stefan Hajnoczi a écrit : > On Mon, Oct 31, 2016 at 10:50:29AM +0100, Laurent Vivier wrote: >> The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >> >> Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into >> staging

Re: [Qemu-devel] [PULL 0/2] M68k for 2.8 patches

2016-11-02 Thread Stefan Hajnoczi
On Mon, Oct 31, 2016 at 10:50:29AM +0100, Laurent Vivier wrote: > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into > staging (2016-10-28 17:59:04 +0100) > > are available in the git

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-11-02 Thread Jianjun Duan
On 11/02/2016 03:45 AM, Juan Quintela wrote: > Jianjun Duan wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such structures. We created VMStateInfo

Re: [Qemu-devel] [Qemu-block] [PULL v2 00/14] Block patches for 2.8

2016-11-02 Thread Stefan Hajnoczi
On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote: > The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: > > Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into > staging (2016-11-01 11:21:02 +) > > are available in the git

[Qemu-devel] [PATCH v1 1/2] arm_generic_timer: Add the ARM Generic Timer

2016-11-02 Thread Alistair Francis
Add the ARM generic timer. This allows the guest to poll the timer for values and also supports secure writes only. Signed-off-by: Alistair Francis --- hw/timer/Makefile.objs | 1 + hw/timer/arm_generic_timer.c | 216

Re: [Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

2016-11-02 Thread Jianjun Duan
On 11/02/2016 03:40 AM, Juan Quintela wrote: > Jianjun Duan wrote: >> Current migration code cannot handle some data structures such as >> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >> in VMStateInfo so that customized handling is supported. >> >>

[Qemu-devel] [PATCH v3 3/3] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kumar Kalever
Document: 1. The new debug and logfile options with their usages 2. New json format and its usage and 3. update "GlusterFS, Device URL Syntax" section in "Invocation" Signed-off-by: Prasanna Kumar Kalever --- qemu-doc.texi | 59

[Qemu-devel] [PATCH v3 0/3] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kumar Kalever
v3: Address review comments by Eric Blake This version split to 3 patches Patch 1/3: Fix QMP definition of BlockdevOptionsGluster, change s/debug-level/debug/ Patch 2/3: Fix QMP definition of BlockdevOptionsNfs, change s/debug-level/debug/ Patch 3/3: no changes to one in v2 v2:

[Qemu-devel] [PATCH v3 2/3] block/nfs: fix QMP to match debug option

2016-11-02 Thread Prasanna Kumar Kalever
The QMP definition of BlockdevOptionsNfs: { 'struct': 'BlockdevOptionsNfs', 'data': { 'server': 'NFSServer', 'path': 'str', '*user': 'int', '*group': 'int', '*tcp-syn-count': 'int', '*readahead-size': 'int',

[Qemu-devel] [PATCH v3 1/3] block/gluster: fix QMP to match debug option

2016-11-02 Thread Prasanna Kumar Kalever
The QMP definition of BlockdevOptionsGluster: { 'struct': 'BlockdevOptionsGluster', 'data': { 'volume': 'str', 'path': 'str', 'server': ['GlusterServer'], '*debug-level': 'int', '*logfile': 'str' } } But instead of 'debug-level we have exported

Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Wed, Nov 2, 2016 at 9:02 PM, Eric Blake wrote: > On 11/02/2016 07:03 AM, Prasanna Kalever wrote: > >>> "debug":"N" does not match the schema; the parameter is named >>> "debug-level", and it is an integer not a string. The parameter is >>> optional; you could just omit it.

Re: [Qemu-devel] [PATCH v2] mttcg: Handle EXCP_ATOMIC exception

2016-11-02 Thread Paolo Bonzini
On 02/11/2016 17:40, Pranith Kumar wrote: > The patch enables handling atomic code in the guest. This should be > preferably done in cpu_handle_exception(), but the current assumptions > regarding when we can execute atomic sections cause a deadlock. > > Signed-off-by: Pranith Kumar

Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars

2016-11-02 Thread Paolo Bonzini
On 02/11/2016 17:40, Daniel P. Berrange wrote: > Could we instead just do: > > Makefile.objs: > > util-obj-y = > include util/Makefile.objs > > util/Makefile.objs: > util-obj-y += util/osdep.o util/cutils.o util/unicode.o > > Yes, you now get the "burden" of adding a directory prefix

[Qemu-devel] [PATCH v1 0/2] Add the generic ARM timer

2016-11-02 Thread Alistair Francis
These two patches and and connect the Generic ARM Timer. This includes support for dropping insecure writes. Alistair Francis (2): arm_generic_timer: Add the ARM Generic Timer xlnx-zynqmp: Connect the ARM Generic Timer hw/arm/xlnx-zynqmp.c | 13 +++ hw/timer/Makefile.objs

[Qemu-devel] [PATCH v1 2/2] xlnx-zynqmp: Connect the ARM Generic Timer

2016-11-02 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 13 + include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 0d86ba3..43c68c5 100644 ---

Re: [Qemu-devel] [PATCH for-2.8?] rules.mak: speedup save-vars load-vars

2016-11-02 Thread Daniel P. Berrange
On Wed, Nov 02, 2016 at 05:24:01PM +0100, Paolo Bonzini wrote: > Unnesting variables spends a lot of time parsing and executing foreach > and if functions. Because actually very few variables have to be > saved and restored, a good strategy is to remember what has to be done > in load-vars, and

Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-02 Thread ashish mittal
On Wed, Nov 2, 2016 at 7:13 AM, Eric Blake wrote: > On 11/02/2016 04:57 AM, Kevin Wolf wrote: IMHO it should allow use of UNIX sockets, as its possible to have SSH setup a tunnel to a IP server, and expose the endpoint via a UNIX socket. So even if your reference

[Qemu-devel] [PATCH v2] mttcg: Handle EXCP_ATOMIC exception

2016-11-02 Thread Pranith Kumar
The patch enables handling atomic code in the guest. This should be preferably done in cpu_handle_exception(), but the current assumptions regarding when we can execute atomic sections cause a deadlock. Signed-off-by: Pranith Kumar --- cpus.c | 9 + 1 file

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-11-02 Thread Paolo Bonzini
On 02/11/2016 11:45, Juan Quintela wrote: >> > +while (qemu_get_byte(f)) { >> > +elm = g_malloc(size); > I think this is not generic enough. We really need to allocate a new > element, and then fill it with default values. > > virtio list code use it in this way. One thing at a

Re: [Qemu-devel] [PATCH] mttcg: Handle EXCP_ATOMIC exception

2016-11-02 Thread Pranith Kumar
Alex Bennée writes: > Pranith Kumar writes: > >> The patch enables handling atomic code in the guest. This should be >> preferably done in cpu_handle_exception(), but the current assumptions >> regarding when we can execute atomic sections cause a deadlock. >> >>

[Qemu-devel] [PATCH] s390x/kvm: fix run_on_cpu sigp conversions

2016-11-02 Thread Cornelia Huck
Commit 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") attempted to convert all users of run_on_cpu to use the new run_on_cpu_data type. It missed to change the called sigp_* routines, however. Fix that. Fixes: 14e6fe12a ("*_run_on_cpu: introduce run_on_cpu_data type") Signed-off-by:

  1   2   3   >