[Qemu-devel] [Bug 1629618] Re: QEMU causes host hang / reset on PPC64EL

2016-11-07 Thread Thomas Huth
No idea (apart from asking why're you're still using 4k pages on the host - hardly anybody seems to do that anymore). Anyway, this sounds like a kernel bug, not a QEMU problem, so you should try to get help via the kernel bug tracker or the KVM mailing list instead. -- You received this bug

Re: [Qemu-devel] [PATCH v1] docs/vhost-user: extend the vhost-user protocol to support the vhost-pci based inter-vm communication

2016-11-07 Thread Marc-André Lureau
Hi I suggest you split this patch for the various "features" you propose. On Mon, Oct 24, 2016 at 11:10 AM Wei Wang wrote: > Signed-off-by: Wei Wang > --- > docs/specs/vhost-user.txt | 81 > +-- > 1 file

[Qemu-devel] Concerning " [PULL 6/6] curses: Use cursesw instead of curses"

2016-11-07 Thread Sergey Smolov
Dear List! I've encountered the same problem as was discussed in this thread: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07898.html Does anybody succeeded in solving the problem? From my side, the problem appears when I run the 'configure' script with

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 07, 2016 at 06:08:42PM +, Daniel P. Berrange wrote: >> On Mon, Nov 07, 2016 at 04:03:58PM -0200, Eduardo Habkost wrote: >> > On Mon, Nov 07, 2016 at 05:41:01PM +, Daniel P. Berrange wrote: >> > > On Mon, Nov 07, 2016 at

Re: [Qemu-devel] [PATCH v11 13/22] vfio: Introduce common function to add capabilities

2016-11-07 Thread Alexey Kardashevskiy
On 05/11/16 08:10, Kirti Wankhede wrote: > Vendor driver using mediated device framework should use > vfio_info_add_capability() to add capabilities. > Introduced this function to reduce code duplication in vendor drivers. > > Signed-off-by: Kirti Wankhede > Signed-off-by:

Re: [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

2016-11-07 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 07, 2016 at 03:40:57PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 07, 2016 at 09:09:58AM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >>

Re: [Qemu-devel] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

2016-11-07 Thread Markus Armbruster
Max Reitz writes: > On 07.11.2016 09:20, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 03.11.2016 08:56, Markus Armbruster wrote: Max Reitz writes: > See patch 3 for the reason why we have actually never

[Qemu-devel] [RFC v2] RBD: Add support readv,writev for rbd

2016-11-07 Thread jazeltq
From: tianqing Rbd can do readv and writev directly, so wo do not need to transform iov to buf or vice versa any more. Signed-off-by: tianqing --- block/rbd.c | 41 - 1 file changed, 36 insertions(+),

[Qemu-devel] [PATCHv2] build-sys: remove libtool left-over

2016-11-07 Thread Marc-André Lureau
Libtool support was removed in commit e999ee44349, there is a few left-over. Signed-off-by: Marc-André Lureau --- v2: - remove .pc and .libs from gitignore - some libtool removal in make clean rule Makefile | 9 +++-- Makefile.objs | 1 - .gitignore

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-07 Thread Alexey Kardashevskiy
On 05/11/16 08:10, Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use most of the code of TYPE1 IOMMU driver for

Re: [Qemu-devel] [PATCH for-2.8] migration: Fix return code of ram_save_iterate()

2016-11-07 Thread Thomas Huth
On 08.11.2016 02:14, David Gibson wrote: > On Fri, Nov 04, 2016 at 02:10:17PM +0100, Thomas Huth wrote: >> qemu_savevm_state_iterate() expects the iterators to return 1 >> when they are done, and 0 if there is still something left to do. >> However, ram_save_iterate() does not obey this rule and

[Qemu-devel] [PATCH v4 6/6] iotests: add transactional failure race test

2016-11-07 Thread John Snow
Add a regression test for the case found by Vladimir. Reported-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow Reviewed-by: Kevin Wolf --- tests/qemu-iotests/124 | 53 ++

[Qemu-devel] [PATCH v4 4/6] blockjob: add block_job_start

2016-11-07 Thread John Snow
Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the block_job_start mechanism and start the jobs automatically as we have been doing, with conversions

Re: [Qemu-devel] [PATCH V3 05/10] intel_iommu: support device iotlb descriptor

2016-11-07 Thread Jason Wang
On 2016年11月08日 07:35, Peter Xu wrote: On Mon, Nov 07, 2016 at 03:09:50PM +0800, Jason Wang wrote: [...] +static bool vtd_process_device_iotlb_desc(IntelIOMMUState *s, + VTDInvDesc *inv_desc) +{ +VTDAddressSpace *vtd_dev_as; +IOMMUTLBEntry

[Qemu-devel] [PATCH v4 3/6] blockjob: add .start field

2016-11-07 Thread John Snow
Add an explicit start field to specify the entrypoint. We already have ownership of the coroutine itself AND managing the lifetime of the coroutine, let's take control of creation of the coroutine, too. This will allow us to delay creation of the actual coroutine until we know we'll actually

[Qemu-devel] [PATCH v4 5/6] blockjob: refactor backup_start as backup_job_create

2016-11-07 Thread John Snow
Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of nearly-identical interfaces that would have to be edited to keep up with QAPI changes in the future.

Re: [Qemu-devel] [PATCH 3/3] net: virtio-net discards TX data after link down

2016-11-07 Thread Jason Wang
On 2016年11月07日 16:20, yuri.benditov...@daynix.com wrote: From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is

[Qemu-devel] [PATCH v4 2/6] blockjob: add .clean property

2016-11-07 Thread John Snow
Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to enter its cleanup routine. The second job,

[Qemu-devel] [PATCH v4 0/6] jobs: fix transactional race condition

2016-11-07 Thread John Snow
There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave well known state and the QLIST can get corrupted and the transactional jobs can complete

[Qemu-devel] [PATCH v4 1/6] blockjob: fix dead pointer in txn list

2016-11-07 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Though it is not intended to be reached through normal circumstances, if we do not gracefully deconstruct the transaction QLIST, we may wind up with stale pointers in the list. The rest of this series attempts to address the

[Qemu-devel] Issue with Keyboard Mapping

2016-11-07 Thread Michael Schem
Hello, I am getting an error message “unknown keycodes `empty_aliases(qwerty)', please report to qemu-devel@nongnu.org” I am wondering if there is a way to manually set what the keycodes should be. Thanks, Michael Schem Research Engineer Skype:

[Qemu-devel] [Bug 1639983] [NEW] e1000 EEPROM have bad checksum

2016-11-07 Thread Paul Dufresne
Public bug reported: I am using qemu-system-i386 to emulate FreeDOS with e1000 nic card. I am using Intel PRODOS v.19.0 (latest version with E1000ODI.COM file). E1000ODI.COM v.5.07 (140116) http://pclosmag.com/html/issues/201208/page11.html Suggest that v.4.75 (120212) was/is working. Oldest

Re: [Qemu-devel] [PATCH] usbredir: free vm_change_state_handler in usbredir destroy dispatch

2016-11-07 Thread Marc-André Lureau
Hi On Tue, Nov 8, 2016 at 9:58 AM Li Qiang wrote: > From: Li Qiang > > In usbredir destroy dispatch function, it doesn't free the vm change > state handler once registered in usbredir_realize function. This will > lead a memory leak issue. This patch avoid

Re: [Qemu-devel] [RFC 13/17] pseries: Move CPU compatibility property to machine

2016-11-07 Thread Alexey Kardashevskiy
On 08/11/16 16:26, David Gibson wrote: > On Fri, Nov 04, 2016 at 06:43:52PM +1100, Alexey Kardashevskiy wrote: >> On 30/10/16 22:12, David Gibson wrote: >>> Server class POWER CPUs have a "compat" property, which is used to set the >>> backwards compatibility mode for the processor. However, this

Re: [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 08:28:25AM -0500, Eric Blake wrote: > On 11/04/2016 05:22 AM, Markus Armbruster wrote: > > Needs a rebase. First error: > > > > CC hw/timer/m48t59.o > > In file included from /work/armbru/qemu/include/exec/cpu-common.h:7:0, > > from

Re: [Qemu-devel] [RFC 15/17] ppc: Check that CPU model stays consistent across migration

2016-11-07 Thread Alexey Kardashevskiy
On 08/11/16 16:29, David Gibson wrote: > On Fri, Nov 04, 2016 at 06:54:48PM +1100, Alexey Kardashevskiy wrote: >> On 30/10/16 22:12, David Gibson wrote: >>> When a vmstate for the ppc cpu was first introduced (a90db15 "target-ppc: >>> Convert ppc cpu savevm to VMStateDescription"), a VMSTATE_EQUAL

[Qemu-devel] [PATCH] usbredir: free vm_change_state_handler in usbredir destroy dispatch

2016-11-07 Thread Li Qiang
From: Li Qiang In usbredir destroy dispatch function, it doesn't free the vm change state handler once registered in usbredir_realize function. This will lead a memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/usb/redirect.c | 5

Re: [Qemu-devel] [RFC 12/17] ppc: Migrate compatibility mode

2016-11-07 Thread Alexey Kardashevskiy
On 08/11/16 16:19, David Gibson wrote: > On Fri, Nov 04, 2016 at 04:58:47PM +1100, Alexey Kardashevskiy wrote: >> On 30/10/16 22:12, David Gibson wrote: >>> Server-class POWER CPUs can be put into several compatibility modes. These >>> can be specified on the command line, or negotiated by the

Re: [Qemu-devel] [PATCH kernel v4 7/7] virtio-balloon: tell host vm's unused page info

2016-11-07 Thread Li, Liang Z
> On 11/06/2016 07:37 PM, Li, Liang Z wrote: > >> Let's say we do a 32k bitmap that can hold ~1M pages. That's 4GB of RAM. > >> On a 1TB system, that's 256 passes through the top-level loop. > >> The bottom-level lists have tens of thousands of pages in them, even > >> on my laptop. Only 1/256

Re: [Qemu-devel] [Qemu-ppc] [RFC 03/17] pseries: Always use core objects for CPU construction

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 10:51:40AM +0100, Greg Kurz wrote: > On Thu, 3 Nov 2016 19:11:48 +1100 > Alexey Kardashevskiy wrote: > > > On 30/10/16 22:11, David Gibson wrote: > > > Currently the pseries machine has two paths for constructing CPUs. On > > > newer machine type

Re: [Qemu-devel] [RFC 11/17] ppc: Add ppc_set_compat_all()

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 03:01:40PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > Once a compatiblity mode is negotiated with the guest, > > h_client_architecture_support() uses run_on_cpu() to update each CPU to > > the new mode. We're going to want this logic

Re: [Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

2016-11-07 Thread John Snow
On 11/03/2016 09:17 AM, Kevin Wolf wrote: Am 02.11.2016 um 18:50 hat John Snow geschrieben: Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of

Re: [Qemu-devel] [RFC 15/17] ppc: Check that CPU model stays consistent across migration

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 06:54:48PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > When a vmstate for the ppc cpu was first introduced (a90db15 "target-ppc: > > Convert ppc cpu savevm to VMStateDescription"), a VMSTATE_EQUAL was used > > to ensure that identical CPU

Re: [Qemu-devel] [RFC 07/17] ppc: Rewrite ppc_set_compat()

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 01:57:45PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:11, David Gibson wrote: > > This rewrites the ppc_set_compat() function so that instead of open coding > > the various compatibility modes, it reads the relevant data from a table. > > This is a first step in

Re: [Qemu-devel] [RFC 08/17] ppc: Rewrite ppc_get_compat_smt_threads()

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 02:37:18PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:11, David Gibson wrote: > > To continue consolidation of compatibility mode information, this rewrites > > the ppc_get_compat_smt_threads() function using the table of compatiblity > > modes in

Re: [Qemu-devel] [RFC 09/17] ppc: Validate compatibility modes when setting

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 02:45:02PM +1100, Alexey Kardashevskiy wrote: > On 31/10/16 19:39, David Gibson wrote: > > On Mon, Oct 31, 2016 at 04:55:42PM +1100, Alexey Kardashevskiy wrote: > >> On 30/10/16 22:12, David Gibson wrote: > >>> Current ppc_set_compat() will attempt to set any compatiblity

Re: [Qemu-devel] [RFC 12/17] ppc: Migrate compatibility mode

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 04:58:47PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > Server-class POWER CPUs can be put into several compatibility modes. These > > can be specified on the command line, or negotiated by the guest during > > boot. > > > > Currently we

Re: [Qemu-devel] [RFC 13/17] pseries: Move CPU compatibility property to machine

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 06:43:52PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > Server class POWER CPUs have a "compat" property, which is used to set the > > backwards compatibility mode for the processor. However, this only makes > > sense for machine types

Re: [Qemu-devel] [RFC 16/17] ppc: Remove counter-productive "sanity checks" in migration

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 04:52:39PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:12, David Gibson wrote: > > When vmstate for the ppc cpu was introduced in a90db158 "target-ppc: > > Convert ppc cpu savevm to VMStateDescription", several "sanity check" > > fields were included, verifying that

Re: [Qemu-devel] [RFC 04/17] pseries: Make cpu_update during CAS unconditional

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 11:45:43AM +0100, Thomas Huth wrote: > On 30.10.2016 12:11, David Gibson wrote: > > spapr_h_cas_compose_response() includes a cpu_update parameter which > > controls whether it includes updated information on the CPUs in the device > > tree fragment returned from the

Re: [Qemu-devel] [RFC 01/17] ppc: Remove some stub POWER6 models

2016-11-07 Thread David Gibson
On Sun, Oct 30, 2016 at 10:11:52PM +1100, David Gibson wrote: > The CPU model table includes stub (commented out) definitions for > CPU_POWERPC_POWER6_5 and CPU_POWERPC_POWER6A. These are not real cpu > models, but represent the POWER6 in some compatiblity modes. If we ever > do implement POWER6

Re: [Qemu-devel] [RFC 06/17] ppc: Rename cpu_version to compat_pvr

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 01:26:41PM +1100, Alexey Kardashevskiy wrote: > On 30/10/16 22:11, David Gibson wrote: > > The 'cpu_version' field in PowerPCCPU is badly named. It's named after the > > 'cpu-version' device tree property where it is advertised, but that meaning > > may not be obvious in

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-11-07 Thread Chunguang Li
> -Original Messages- > From: "Li, Liang Z" > Sent Time: Monday, November 7, 2016 > To: "Chunguang Li" > Cc: "Dr. David Alan Gilbert" , "Amit Shah" > , "pbonz...@redhat.com"

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread Emilio G. Cota
On Mon, Nov 07, 2016 at 15:03:23 +, Peter Maydell wrote: > On 5 November 2016 at 18:42, Peter Maydell wrote: > > With a little luck I may be able to put something up > > on Monday as a sort of minimal-demonstration of how > > this would look in QEMU. > > Generated

Re: [Qemu-devel] [PULL 15/16] spapr_pci: Add a 64-bit MMIO window

2016-11-07 Thread Alexey Kardashevskiy
On 08/11/16 12:16, David Gibson wrote: > On Fri, Nov 04, 2016 at 04:03:31PM +1100, Alexey Kardashevskiy wrote: >> On 17/10/16 13:43, David Gibson wrote: >>> On real hardware, and under pHyp, the PCI host bridges on Power machines >>> typically advertise two outbound MMIO windows from the guest's

Re: [Qemu-devel] [PATCH v4 4/4] target-ppc: Implement bcdctz. instruction

2016-11-07 Thread David Gibson
On Tue, Nov 01, 2016 at 01:24:48PM -0200, Jose Ricardo Ziviani wrote: > bcdctz. converts from BCD to Zoned numeric format. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH v4 3/4] target-ppc: Implement bcdcfz. instruction

2016-11-07 Thread David Gibson
On Tue, Nov 01, 2016 at 01:24:47PM -0200, Jose Ricardo Ziviani wrote: > bcdcfz. converts from Zoned numeric format to BCD. Zoned format uses > a byte to represent a digit where the most significant nibble is 0x3 > or 0xf, depending on the preferred signal. > > Signed-off-by: Jose Ricardo Ziviani

Re: [Qemu-devel] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

2016-11-07 Thread Jeff Cody
On Wed, Nov 02, 2016 at 01:50:55PM -0400, John Snow wrote: > Refactor backup_start as backup_job_create, which only creates the job, > but does not automatically start it. The old interface, 'backup_start', > is not kept in favor of limiting the number of nearly-identical interfaces > that would

Re: [Qemu-devel] [PATCH v3 3/6] blockjob: add .start field

2016-11-07 Thread Jeff Cody
On Wed, Nov 02, 2016 at 01:50:53PM -0400, John Snow wrote: > Add an explicit start field to specify the entrypoint. We already have > ownership of the coroutine itself AND managing the lifetime of the > coroutine, let's take control of creation of the coroutine, too. > > This will allow us to

Re: [Qemu-devel] [PATCH v3 2/6] blockjob: add .clean property

2016-11-07 Thread Jeff Cody
On Wed, Nov 02, 2016 at 01:50:52PM -0400, John Snow wrote: > Cleaning up after we have deferred to the main thread but before the > transaction has converged can be dangerous and result in deadlocks > if the job cleanup invokes any BH polling loops. > > A job may attempt to begin cleaning up, but

Re: [Qemu-devel] [PATCH v4 1/4] target-ppc: Implement bcdcfn. instruction

2016-11-07 Thread David Gibson
On Tue, Nov 01, 2016 at 01:24:45PM -0200, Jose Ricardo Ziviani wrote: > bcdcfn. converts from National numeric format to BCD. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v4 2/4] target-ppc: Implement bcdctn. instruction

2016-11-07 Thread David Gibson
On Tue, Nov 01, 2016 at 01:24:46PM -0200, Jose Ricardo Ziviani wrote: > bcdctn. converts from BCD to National numeric format. National format > uses a byte to represent a digit where the most significant nibble is > always 0x3 and the least sign. nibbles is the digit itself. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 1/6] blockjob: fix dead pointer in txn list

2016-11-07 Thread Jeff Cody
On Wed, Nov 02, 2016 at 01:50:51PM -0400, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy > > Though it is not intended to be reached through normal circumstances, > if we do not gracefully deconstruct the transaction QLIST, we may wind > up with stale pointers in

Re: [Qemu-devel] [PATCH v5 11/17] ppc/xics: Add "native" XICS subclass

2016-11-07 Thread David Gibson
On Wed, Nov 02, 2016 at 11:48:51AM +0100, Cédric Le Goater wrote: > On 10/28/2016 03:00 AM, David Gibson wrote: > > On Thu, Oct 27, 2016 at 07:43:10PM +0200, Cédric Le Goater wrote: > >> On 10/27/2016 05:09 AM, David Gibson wrote: > >>> On Wed, Oct 26, 2016 at 09:13:18AM +0200, Cédric Le Goater

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-07 Thread Jike Song
On 11/08/2016 07:16 AM, Alex Williamson wrote: > On Sat, 5 Nov 2016 02:40:44 +0530 > Kirti Wankhede wrote: > >> VFIO IOMMU drivers are designed for the devices which are IOMMU capable. >> Mediated device only uses IOMMU APIs, the underlying hardware can be >> managed by an

Re: [Qemu-devel] [PULL 15/16] spapr_pci: Add a 64-bit MMIO window

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 04:03:31PM +1100, Alexey Kardashevskiy wrote: > On 17/10/16 13:43, David Gibson wrote: > > On real hardware, and under pHyp, the PCI host bridges on Power machines > > typically advertise two outbound MMIO windows from the guest's physical > > memory space to PCI memory

Re: [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

2016-11-07 Thread John Snow
On 11/07/2016 09:05 PM, Jeff Cody wrote: On Mon, Nov 07, 2016 at 09:02:14PM -0500, John Snow wrote: On 11/03/2016 08:17 AM, Kevin Wolf wrote: Am 02.11.2016 um 18:50 hat John Snow geschrieben: Instead of automatically starting jobs at creation time via backup_start et al, we'd like to

Re: [Qemu-devel] [PATCH for-2.8] migration: Fix return code of ram_save_iterate()

2016-11-07 Thread David Gibson
On Fri, Nov 04, 2016 at 02:10:17PM +0100, Thomas Huth wrote: > qemu_savevm_state_iterate() expects the iterators to return 1 > when they are done, and 0 if there is still something left to do. > However, ram_save_iterate() does not obey this rule and returns > the number of saved pages instead.

Re: [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

2016-11-07 Thread Jeff Cody
On Mon, Nov 07, 2016 at 09:02:14PM -0500, John Snow wrote: > > > On 11/03/2016 08:17 AM, Kevin Wolf wrote: > >Am 02.11.2016 um 18:50 hat John Snow geschrieben: > >>Instead of automatically starting jobs at creation time via backup_start > >>et al, we'd like to return a job object pointer that

Re: [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start

2016-11-07 Thread John Snow
On 11/03/2016 08:17 AM, Kevin Wolf wrote: Am 02.11.2016 um 18:50 hat John Snow geschrieben: Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-11-07 Thread Fam Zheng
On Mon, 11/07 17:39, ashish mittal wrote: > I guess the email subject of the individual patches is OK to > change? Yes, that is fine, as long as it doesn't burden incremental reviewing unnecessarily. Fam

Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs".

2016-11-07 Thread ashish mittal
On Fri, Nov 4, 2016 at 6:04 AM, Stefan Hajnoczi wrote: > Please keep using "block/vxhs: Add Veritas HyperScale VxHS block device > support" as the cover letter email subject. This way tools are able to > automatically mark old versions of this patch series as obsolete. Sent

[Qemu-devel] [PATCH v2 0/2] Add the generic ARM timer

2016-11-07 Thread Alistair Francis
These two patches and and connect the Generic ARM Timer. This includes support for dropping insecure writes. V2: - Fix couter/counter typo Alistair Francis (2): arm_generic_timer: Add the ARM Generic Timer xlnx-zynqmp: Connect the ARM Generic Timer hw/arm/xlnx-zynqmp.c |

[Qemu-devel] [PATCH v2 1/2] arm_generic_timer: Add the ARM Generic Timer

2016-11-07 Thread Alistair Francis
Add the ARM generic timer. This allows the guest to poll the timer for values and also supports secure writes only. Signed-off-by: Alistair Francis --- V2: - Fix couter/counter typo hw/timer/Makefile.objs | 1 + hw/timer/arm_generic_timer.c

[Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

2016-11-07 Thread Ashish Mittal
These changes use a vxhs test server that is a part of the following repository: https://github.com/MittalAshish/libqnio.git Signed-off-by: Ashish Mittal --- v6 changelog: (1) Added iotests for VxHS block device. tests/qemu-iotests/common| 6 ++

Re: [Qemu-devel] [PATCH] ppc/pnv: fix compile breakage on old gcc

2016-11-07 Thread David Gibson
On Mon, Nov 07, 2016 at 07:03:02PM +0100, Cédric Le Goater wrote: > PnvChip is defined twice and this can confuse old compilers : > > CC ppc64-softmmu/hw/ppc/pnv_xscom.o > In file included from qemu.git/hw/ppc/pnv.c:29: > qemu.git/include/hw/ppc/pnv.h:60: error: redefinition of typedef

[Qemu-devel] [PATCH v2 2/2] xlnx-zynqmp: Connect the ARM Generic Timer

2016-11-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 13 + include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 0d86ba3..43c68c5 100644 ---

[Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

2016-11-07 Thread Ashish Mittal
Source code for the qnio library that this code loads can be downloaded from: https://github.com/MittalAshish/libqnio.git Sample command line using the JSON syntax: ./qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k en-us -vga cirrus -device

[Qemu-devel] [PATCH v6 0/2] block/vxhs: Add Veritas HyperScale VxHS block device support

2016-11-07 Thread Ashish Mittal
- Veritas HyperScale block driver in QEMU is designed to provide an accelerated IO path from KVM virtual machines to Veritas HyperScale storage service. - A network IO transfer library that translates block IO from HyperScale block driver to a network IO format to send it to Veritas

Re: [Qemu-devel] [PATCH v1 1/2] arm_generic_timer: Add the ARM Generic Timer

2016-11-07 Thread Alistair Francis
On Thu, Nov 3, 2016 at 1:47 AM, KONRAD Frederic wrote: > > > Le 02/11/2016 à 17:41, Alistair Francis a écrit : >> >> Add the ARM generic timer. This allows the guest to poll the timer for >> values and also supports secure writes only. >> >> Signed-off-by: Alistair

[Qemu-devel] [PATCH v2 1/1] cadence_uart: Check baud rate generator and divider values on migration

2016-11-07 Thread Alistair Francis
The Cadence UART device emulator calculates speed by dividing the baud rate by a 'baud rate generator' & 'baud rate divider' value. The device specification defines these register values to be non-zero and within certain limits. Checks were recently added when writing to these registers but not

Re: [Qemu-devel] [PATCH] Document how x86 gdb_num_core_regs is computed.

2016-11-07 Thread Paolo Bonzini
On 03/11/2016 22:48, Doug Evans wrote: > Hi. > > It helps when reading the code to see how the number is arrived at. > > Signed-off-by: Doug Evans > --- > target-i386/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c >

Re: [Qemu-devel] [QEMU PATCH v2] kvmclock: advance clock by time window between vm_stop and pre_save

2016-11-07 Thread Marcelo Tosatti
On Mon, Nov 07, 2016 at 08:03:50PM +, Dr. David Alan Gilbert wrote: > * Marcelo Tosatti (mtosa...@redhat.com) wrote: > > On Mon, Nov 07, 2016 at 03:46:11PM +, Dr. David Alan Gilbert wrote: > > > * Marcelo Tosatti (mtosa...@redhat.com) wrote: > > > > This patch, relative to pre-copy

[Qemu-devel] [QEMU PATCH v12 4/4] migration: add error_report

2016-11-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..0e6fce4 100644 ---

[Qemu-devel] [QEMU PATCH v12 2/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list.

[Qemu-devel] [QEMU PATCH v12 3/4] tests/migration: Add test for QTAILQ migration

2016-11-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index

[Qemu-devel] [QEMU PATCH v12 1/4] migration: extend VMStateInfo

2016-11-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan ---

[Qemu-devel] [QEMU PATCH v12 0/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
Hi all, I addressed some review comments. For QTAILQ, I hope we can reach a compromise since there are more than one way to do it. For some work such as the ability to initialize newly allocated QTAILQ element with default value, I think it is better to do it later on in a separate series.

Re: [Qemu-devel] [PATCH v11 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-07 Thread Alex Williamson
On Sat, 5 Nov 2016 02:40:46 +0530 Kirti Wankhede wrote: > Add a notifier calback to parent's ops structure of mdev device so that per > device notifer for vfio module is registered through vfio_mdev module. > > Signed-off-by: Kirti Wankhede >

[Qemu-devel] [Bug 732155] Re: system_reset doesn't work with qemu-kvm and latest SeaBIOS

2016-11-07 Thread Matthew Bloch
Hi Thomas, thanks for the triage. I'm a few years past working on this project directly so if it's not affecting anyone else I'd probably just close this bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [V3,6/7] nios2: Add Altera 10M50 GHRD emulation

2016-11-07 Thread Guenter Roeck
On Tue, Oct 18, 2016 at 11:50:30PM +0200, Marek Vasut wrote: > Add the Altera 10M50 Nios2 GHRD model. This allows emulating the > 10M50 development kit with the Nios2 GHRD loaded in the FPGA. It > is possible to boot Linux kernel and run userspace, thus far only > from initrd as storage support is

Re: [Qemu-devel] [PATCH v11 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-07 Thread Alex Williamson
On Sat, 5 Nov 2016 02:40:45 +0530 Kirti Wankhede wrote: > Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers > about DMA_UNMAP. > Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). > Notifier should be registered, if external user

Re: [Qemu-devel] [PATCH V3 09/10] memory: handle alias in memory_region_is_iommu()

2016-11-07 Thread Peter Xu
On Mon, Nov 07, 2016 at 03:09:54PM +0800, Jason Wang wrote: > Cc: Paolo Bonzini > Acked-by: Paolo Bonzini > Signed-off-by: Jason Wang Reviewed-by: Peter Xu

Re: [Qemu-devel] [PATCH V3 08/10] memory: handle alias for iommu notifier

2016-11-07 Thread Peter Xu
On Mon, Nov 07, 2016 at 03:09:53PM +0800, Jason Wang wrote: > Cc: Paolo Bonzini > Acked-by: Paolo Bonzini > Signed-off-by: Jason Wang Reviewed-by: Peter Xu

Re: [Qemu-devel] [PATCH V3 05/10] intel_iommu: support device iotlb descriptor

2016-11-07 Thread Peter Xu
On Mon, Nov 07, 2016 at 03:09:50PM +0800, Jason Wang wrote: [...] > +static bool vtd_process_device_iotlb_desc(IntelIOMMUState *s, > + VTDInvDesc *inv_desc) > +{ > +VTDAddressSpace *vtd_dev_as; > +IOMMUTLBEntry entry; Since "entry" is allocated

Re: [Qemu-devel] [QEMU PATCH v11 0/4] migration: migrate QTAILQ

2016-11-07 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [QEMU PATCH v11 0/4] migration: migrate QTAILQ Message-id:

Re: [Qemu-devel] [PATCH v11 10/22] vfio iommu type1: Add support for mediated devices

2016-11-07 Thread Alex Williamson
On Sat, 5 Nov 2016 02:40:44 +0530 Kirti Wankhede wrote: > VFIO IOMMU drivers are designed for the devices which are IOMMU capable. > Mediated device only uses IOMMU APIs, the underlying hardware can be > managed by an IOMMU domain. > > Aim of this change is: > - To use

Re: [Qemu-devel] [PATCH v3 04/14] qapi: fix schema symbol sections

2016-11-07 Thread Eric Blake
On 11/07/2016 01:30 AM, Marc-André Lureau wrote: > According to docs/qapi-code-gen.txt, there needs to be '##' to start a > and end a symbol section, that's also what the documentation parser > expects. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json

Re: [Qemu-devel] [PATCH v3 05/14] qapi: fix missing symbol @prefix

2016-11-07 Thread Eric Blake
On 11/07/2016 01:30 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 4 ++-- > qapi/block-core.json | 4 ++-- > qapi/crypto.json | 36 ++-- > 3 files changed, 22 insertions(+), 22

[Qemu-devel] [QEMU PATCH v11 2/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. We created VMStateInfo vmstate_info_qtailq for QTAILQ. Similar VMStateInfo can be created for other data structures such as list.

[Qemu-devel] [QEMU PATCH v11 4/4] migration: add error_report

2016-11-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 4ef528c..344863f 100644 ---

[Qemu-devel] [QEMU PATCH v11 1/4] migration: extend VMStateInfo

2016-11-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan ---

[Qemu-devel] [QEMU PATCH v11 0/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
Hi all, I addressed some review comments. For QTAILQ, I hope we can reach a compromise since there are more than one way to do it. For some work such as the ability to initialize newly allocated QTAILQ element with default value, I think it is better to do it later on in a separate series.

[Qemu-devel] [QEMU PATCH v11 3/4] tests/migration: Add test for QTAILQ migration

2016-11-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index

Re: [Qemu-devel] [PATCH v3 02/14] qga/schema: fix double-return in doc

2016-11-07 Thread Eric Blake
On 11/07/2016 01:30 AM, Marc-André Lureau wrote: > guest-get-memory-block-info documentation should have only one > "Returns:". > > Signed-off-by: Marc-André Lureau > --- > qga/qapi-schema.json | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add

2016-11-07 Thread Eric Blake
On 11/07/2016 01:30 AM, Marc-André Lureau wrote: > 'device_add' is incomplete for now, but 'bus' is a common argument for > regarless of the device, and is present in documentation. Add it to the s/regarless/regardless/ > device_add schema definition. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)

2016-11-07 Thread John Snow
On 11/07/2016 08:30 AM, Stefan Hajnoczi wrote: On Sat, Nov 05, 2016 at 06:42:23PM +, Peter Maydell wrote: In particular I think we could: * set up a framework for our in-tree docs/ which gives us a place to put new docs (both for-users and for-developers) -- I think having

Re: [Qemu-devel] [PATCH] nbd: Don't inf-loop on early EOF

2016-11-07 Thread Eric Blake
On 11/07/2016 04:22 PM, Max Reitz wrote: > On 07.11.2016 21:38, Eric Blake wrote: >> Commit 7d3123e converted a single read_sync() into a while loop >> that assumed that read_sync() would either make progress or give >> an error. But when the server hangs up early, the client sees >> EOF (a

Re: [Qemu-devel] [PATCH v1 1/1] cadence_uart: Check baud rate generator and divider values on migration

2016-11-07 Thread Alistair Francis
On Mon, Nov 7, 2016 at 2:13 PM, Peter Maydell wrote: > On 7 November 2016 at 21:53, Alistair Francis > wrote: >> On Sat, Nov 5, 2016 at 6:51 AM, Peter Maydell >> wrote: >>> Usually we just fail the migration if

Re: [Qemu-devel] [PATCH v2 2/6] libqtest: add qmp_eventwait_ref

2016-11-07 Thread Eric Blake
On 11/07/2016 03:13 PM, John Snow wrote: > Wait for an event, but return a copy so we can investigate parameters. > > Signed-off-by: John Snow > --- > tests/libqtest.c | 13 ++--- > tests/libqtest.h | 22 ++ > 2 files changed, 32 insertions(+), 3

  1   2   3   4   >