Re: [Qemu-devel] [PATCH] mttcg: translate-all: Enable locking debug in a debug build

Pranith Kumar writes: > Enable tcg lock debug asserts in a debug build by default instead of > relying on DEBUG_LOCKING. None of the other DEBUG_* macros have > asserts, so this patch removes DEBUG_LOCKING and enable these asserts > in a debug build. > > CC: Richard

Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

Hi, > +/* the definition of MOUSE_EVENT_WHEELUP/MOUSE_EVENT_WHEELDN > + * is ambiguous since ps2_mouse_send_packet expects the bits > + * for buttons 4 and 5 at s->mouse_buttons & 0x18 which > + * matches MOUSE_EVENT_WHEELUP/MOUSE_EVENT_WHEELDN */ > static const int

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

> > > > > + > > > > +/* Note: kernel crypto API realization */ > > > > +static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher > > > > *tfm, > > > > +const uint8_t *key, > > > > +unsigned int keylen) > >

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] cutils: Define min and max marcos Type: series Message-id:

[Qemu-devel] [PATCH] mttcg: translate-all: Enable locking debug in a debug build

Enable tcg lock debug asserts in a debug build by default instead of relying on DEBUG_LOCKING. None of the other DEBUG_* macros have asserts, so this patch removes DEBUG_LOCKING and enable these asserts in a debug build. CC: Richard Henderson CC: Alex Bennée

[Qemu-devel] [PATCH v4 01/10] tcg-mips: Move bswap code to a subroutine

Without the mips32r2 instructions to perform swapping, bswap is quite large, dominating the size of each reverse-endian qemu_ld/qemu_st operation. Create a subroutine in the prologue block. The subroutine requires extra reserved registers (TCG_TMP[2, 3]). Using these within qemu_ld means that

[Qemu-devel] [PATCH v4 08/10] tcg-mips: Add tcg unwind info

Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 44 1 file changed, 44

[Qemu-devel] [PATCH v4 07/10] tcg-mips: Adjust prologue for mips64

Take stack frame parameters out from the function body. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 54

[Qemu-devel] [PATCH v4 06/10] tcg-mips: Adjust load/store functions for mips64

tcg_out_ldst: using a generic ALIAS_PADD to avoid ifdefs tcg_out_ld: generates LD or LW tcg_out_st: generates SD or SW Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie

[Qemu-devel] [PATCH v4 10/10] tcg-mips: Adjust qemu_ld/st for mips64

Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.inc.c | 201 +- 1 file changed, 144

[Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

Changes since v3: * tcg_out_qemu_ld_slow_path: always sign-extend 32-bit loads. Provide a better solution than patch11 in v3. Fix the blocking bug when emulating i386 kernel on mips64el. * Redefine LO_OFF/HI_OFF as v2. On mips64 host, they are defined as link_error, to ensure that

[Qemu-devel] [PATCH v4 03/10] tcg-mips: Support 64-bit opcodes

Bulk patch adding 64-bit opcodes into tcg_out_op. Note that mips64 is as yet neither complete nor enabled. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie ---

[Qemu-devel] [PATCH v4 05/10] tcg-mips: Adjust move functions for mips64

tcg_out_mov: using OPC_OR as most mips assemblers do; tcg_out_movi: extended to 64-bit immediate. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie ---

[Qemu-devel] [PATCH v4 02/10] tcg-mips: Add mips64 opcodes

Since the mips manual tables are in octal, reorg all of the opcodes into that format for clarity. Note that the 64-bit opcodes are as yet unused. Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by:

[Qemu-devel] [PATCH v4 09/10] tcg-mips: Adjust calling conventions for mips64

Cc: Aurelien Jarno Cc: James Hogan Signed-off-by: Richard Henderson Signed-off-by: Jin Guojie --- tcg/mips/tcg-target.h | 19 +++ tcg/mips/tcg-target.inc.c | 21 +++-- 2

[Qemu-devel] [PATCH v4 04/10] tcg-mips: Add bswap32u and bswap64

Without the mips32r2 instructions to perform swapping, bswap is quite large, dominating the size of each reverse-endian qemu_ld/qemu_st operation. Create two subroutines in the prologue block. The subroutines require extra reserved registers (TCG_TMP[2, 3]). Using these within qemu_ld means

Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility

On (Mon) 28 Nov 2016 [13:31:59], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > 39c88f56 added VMState for pcspk but turned it on for > all machine types, this breaks backwards compatibility > to older machine types. > > If this is too

[Qemu-devel] [PATCH for-2.8] intel_iommu: fix incorrect device invalidate

"mask" needs to be inverted before use. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 1b706ad..5f3e351 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@

Re: [Qemu-devel] [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [libvirt] [RFC v2 00/20] qmp: Report bus information on 'query-machines' Type: series Message-id:

Re: [Qemu-devel] [PATCH] virtio-gpu: call cleanup mapping function in resource destroy

On Tue, Nov 29, 2016 at 6:29 AM Li Qiang wrote: > If the guest destroy the resource before detach banking, the 'iov' > and 'addrs' field in resource is not freed thus leading memory > leak issue. This patch avoid this. > > Signed-off-by: Li Qiang >

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

Hi Halil, > > On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: > >>> +static int virtio_crypto_alg_ablkcipher_init_session( > >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, > >>> > > + uint32_t alg, const uint8_t *key, > >>> > > + unsigned int keylen, >

[Qemu-devel] [PATCH] qemu-options: cleanup duplicated help message for kernel_irqchip

Remove the duplicated help message for 'kernel_irqchip'. Signed-off-by: Po-Hsu Lin --- qemu-options.hx |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 4a5b29f..76689c4 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

Hi Michael and Stefan, > > Subject: Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > > > The

Re: [Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

2016-11-28 23:51 GMT+08:00 Aviv B.D : > From: "Aviv Ben-David" > > Adds a list of registered vtd_as's to intel iommu state to save > iteration over each PCI device in a search of the corrosponding domain. > > Signed-off-by: Aviv Ben-David

Re: [Qemu-devel] [PATCH v4] target-ppc: add vextu[bhw][lr]x instructions

On Mon, Nov 28, 2016 at 01:26:42PM +0530, Nikunj A Dadhania wrote: > From: Avinesh Kumar > > vextublx: Vector Extract Unsigned Byte Left > vextuhlx: Vector Extract Unsigned Halfword Left > vextuwlx: Vector Extract Unsigned Word Left > vextubrx: Vector Extract

[Qemu-devel] [PATCH] virtio-gpu: call cleanup mapping function in resource destroy

If the guest destroy the resource before detach banking, the 'iov' and 'addrs' field in resource is not freed thus leading memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/display/virtio-gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver

> > Subject: [virtio-dev] Re: [PATCH v3] crypto: add virtio-crypto driver > > On Mon, 28 Nov 2016 20:08:23 +0800 > Gonglei wrote: > > > +static int virtcrypto_update_status(struct virtio_crypto *vcrypto) > > +{ > > + u32 status; > > + int err; > > + > > +

[Qemu-devel] [PATCH] watchdog: 6300esb: add exit function

From: Li Qiang When the Intel 6300ESB watchdog is hot unplug. The timer allocated in realize isn't freed thus leaking memory leak. This patch avoid this through adding the exit function. Signed-off-by: Li Qiang --- hw/watchdog/wdt_i6300esb.c | 9 +

Re: [Qemu-devel] [PATCH for-2.8] hw: Fix typos found by codespell

On Sat, Nov 19, 2016 at 11:29 AM, Stefan Weil wrote: > Signed-off-by: Stefan Weil Acked-by: Alistair Francis Thanks, Alistair > --- > hw/block/m25p80.c | 4 ++-- > hw/core/generic-loader.c | 4 ++-- >

Re: [Qemu-devel] [PATCH for-2.8] include: Fix typos found by codespell

On Sat, Nov 19, 2016 at 11:47 AM, Stefan Weil wrote: > Add also a missing parenthesis in a comment. > > Signed-off-by: Stefan Weil Acked-by: Alistair Francis Thanks, Alistair > --- > include/hw/dma/xlnx_dpdma.h| 3 ++- >

Re: [Qemu-devel] [PATCH v2 7/8] hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller

On Thu, Sep 8, 2016 at 7:51 AM, Paul Burton wrote: > Add support for emulating the Xilinx AXI Root Port Bridge for PCI > Express as described by Xilinx' PG055 document. This is a PCIe > controller that can be used with certain series of Xilinx FPGAs, and is > used on the

Re: [Qemu-devel] [PATCH v2 1/1] cadence_uart: Check baud rate generator and divider values on migration

On Mon, Nov 28, 2016 at 3:31 AM, Peter Maydell wrote: > On 8 November 2016 at 00:34, Alistair Francis > wrote: >> The Cadence UART device emulator calculates speed by dividing the >> baud rate by a 'baud rate generator' & 'baud rate divider'

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

Hi Wouter, Some of this mess may be partially my fault, but I have not been following the NBD extension proposals up until this point. Are you familiar with the genesis behind this idea and what we are trying to accomplish in general? We had the thought to propose an extension roughly

Re: [Qemu-devel] [PATCH for-2.8 2/2] loader: fix undefined behavior in rom_order_compare()

On Mon, Nov 28, 2016 at 11:57 AM, Laszlo Ersek wrote: > According to ISO C99 / N1256 (referenced in HACKING): > >> 6.5.8 Relational operators >> >> 4 For the purposes of these operators, a pointer to an object that is >> not an element of an array behaves the same as a

Re: [Qemu-devel] [PATCH for-2.8 1/2] loader: fix handling of custom address spaces when adding ROM blobs

On Mon, Nov 28, 2016 at 11:57 AM, Laszlo Ersek wrote: > * Commit 3e76099aacb4 ("loader: Allow a custom AddressSpace when loading > ROMs") introduced the "Rom.as" field: > > (1) It modified the utility callers of rom_insert() to take "as" as a > new parameter from

[Qemu-devel] [PULL 4/6] migration/pcspk: Add a property to state if pcspk is migrated

From: "Dr. David Alan Gilbert" Allow us to turn migration of pcspk off for compatibility. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20161128133201.16104-2-dgilb...@redhat.com> Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PULL 6/6] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

From: Adrian Bunk Building qemu fails in distributions where gcc enables PIE by default (e.g. Debian unstable) with: /usr/bin/ld: -r and -pie may not be used together Use -r instead of -Wl,-r to avoid gcc passing -pie to the linker when PIE is enabled and a relocatable object

[Qemu-devel] [PULL 3/6] pci-assign: sync MSI/MSI-X cap and table with PCIDevice

From: Peter Xu Since commit e1d4fb2d ("kvm-irqchip: x86: add msi route notify fn"), kvm_irqchip_add_msi_route() starts to use pci_get_msi_message() to fetch MSI info. This requires that we setup MSI related fields in PCIDevice. For most devices, that won't be a problem, as

[Qemu-devel] [PULL 2/6] megasas: clean up and fix request completion/cancellation

megasas_command_cancel is a callback; it should report the abort in the frame, not try another abort! Compare for instance with mptsas_request_cancelled. So extract the common bits for request completion in a new function megasas_complete_command, call it from both the .complete and .cancel

[Qemu-devel] [PULL 1/6] megasas: do not call pci_dma_unmap after having freed the frame once

Commit 8cc4678 ("megasas: remove useless check for cmd->frame", 2016-07-17) was wrong because I trusted Coverity too much. It turns out that there _is_ a path through which cmd->frame can become NULL. After megasas_handle_frame's switch (md->frame->header.frame_cmd), megasas_init_firmware can be

[Qemu-devel] [PULL 5/6] migration/pcspk: Turn migration of pcspk off for 2.7 and older

From: "Dr. David Alan Gilbert" To keep backwards migration compatibility allow us to turn pcspk migration off. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20161128133201.16104-3-dgilb...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 0/6] More patches for QEMU 2.8-rc2

The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PATCH] target-m68k: fix CAS

- update flags before setting the result to cmp, because after that cmp == load and flags are always Z, - comparison is signed, so use signed values, - move "cas" after arith_im in the table, otherwise casw can be decoded as an arith_im. Signed-off-by: Laurent Vivier ---

Re: [Qemu-devel] [dpdk-dev] dpdk/vpp and cross-version migration for vhost

2016-11-28 16:28, Maxime Coquelin: > On 11/24/2016 04:24 PM, Kavanagh, Mark B wrote: > > DPDK v16.04 added support for vHost User TSO; as such, by default, > > TSO is advertised to guest devices as an available feature during > > feature negotiation with QEMU. > > However, while the vHost user

[Qemu-devel] [PATCH v2 2/4] 9pfs: introduce transport specific callbacks

Don't call virtio functions from 9pfs generic code, use generic function callbacks instead. Signed-off-by: Stefano Stabellini --- Changes in v2: - constify virtio_9p_transport and V9fsTransport - assert !s->transport. - code style --- hw/9pfs/9p.c | 8

[Qemu-devel] [PATCH v2] ps2: add support for mice with extra/side buttons

This patch introduces the SIDE and EXTRA mouse buttons and implements appropriate event generation for gtk and input-linux input methods. The naming was borrowed from evdev since it is more descriptive than BUTTON4/5. Note that the guest has to switch the ps2 mouse into IMEX mode, otherwise

[Qemu-devel] [PATCH v2 3/4] 9pfs: call v9fs_init_qiov_from_pdu before v9fs_pack

v9fs_xattr_read should not access VirtQueueElement elems directly. Move v9fs_init_qiov_from_pdu up in the file and call v9fs_init_qiov_from_pdu before v9fs_pack. Use v9fs_pack on the new iovec. Signed-off-by: Stefano Stabellini --- Changes in v2: - add a call to

[Qemu-devel] [PATCH v2 1/4] 9pfs: move pdus to V9fsState

pdus are initialized and used in 9pfs common code. Move the array from V9fsVirtioState to V9fsState. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz --- hw/9pfs/9p.c| 7 +++ hw/9pfs/9p.h| 1 + hw/9pfs/virtio-9p.h | 1 - 3

[Qemu-devel] [PATCH v2 4/4] 9pfs: introduce init_out/in_iov_from_pdu

Not all 9pfs transports share memory between request and response. For those who don't, it is necessary to know how much memory is required in the response. Split the existing init_iov_from_pdu function in two: init_out_iov_from_pdu (for writes) and init_in_iov_from_pdu (for reads).

[Qemu-devel] [PATCH v2 0/4] 9pfs: clean-up for multiple transports

Hi all, this small patch series provides a few fixes and clean-ups in preparation for the introduction of a 9pfs Xen transport. Changes in v2: - constify virtio_9p_transport and V9fsTransport - assert !s->transport. - code style - add a call to qemu_iovec_destroy - fix commit description of

Re: [Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Mon, 21 Nov 2016 13:39:32 -0800 > Stefano Stabellini wrote: > > > Not all 9pfs transports share memory between request and response. For > > those who don't, it is necessary to know how much memory is required in > > the

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

** Changed in: cloud-archive Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create fallback mechanism change for security

Re: [Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Mon, 21 Nov 2016 13:39:31 -0800 > Stefano Stabellini wrote: > > > v9fs_xattr_read should not access VirtQueueElement elems directly. > > Move v9fs_init_qiov_from_pdu up in the file and call > > v9fs_init_qiov_from_pdu instead of

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Thu, 24 Nov 2016 15:23:10 +0100 > Greg Kurz wrote: > > > On Thu, 24 Nov 2016 09:31:52 +0100 > > Greg Kurz wrote: > > > > > On Mon, 21 Nov 2016 13:39:30 -0800 > > > Stefano Stabellini wrote: > >

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

On Thu, 24 Nov 2016, Greg Kurz wrote: > > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > > > index 1782e4a..e1a37a4 100644 > > > --- a/hw/9pfs/virtio-9p-device.c > > > +++ b/hw/9pfs/virtio-9p-device.c > > > @@ -20,7 +20,9 @@ > > > #include "hw/virtio/virtio-access.h" > >

[Qemu-devel] [PATCH for-2.8 1/2] loader: fix handling of custom address spaces when adding ROM blobs

* Commit 3e76099aacb4 ("loader: Allow a custom AddressSpace when loading ROMs") introduced the "Rom.as" field: (1) It modified the utility callers of rom_insert() to take "as" as a new parameter from *their* callers, and set "rom->as" from that parameter. The functions covered

[Qemu-devel] [PATCH for-2.8 0/2] loader fixes

While rebasing Michael's patch at to current master, I noticed something was wrong with rom_add_blob() in current master. I'm proposing these fixes. Thanks Laszlo Cc: "Michael S. Tsirkin" Cc: Alistair

[Qemu-devel] [PATCH for-2.8 2/2] loader: fix undefined behavior in rom_order_compare()

According to ISO C99 / N1256 (referenced in HACKING): > 6.5.8 Relational operators > > 4 For the purposes of these operators, a pointer to an object that is > not an element of an array behaves the same as a pointer to the first > element of an array of length one with the type of the object

[Qemu-devel] [PULL 3/4] xen: slightly simplify bufioreq handling

From: Jan Beulich There's no point setting fields always receiving the same value on each iteration, as handle_ioreq() doesn't alter them anyway. Set state and count once ahead of the loop, drop the redundant clearing of data_is_ptr, and avoid the meaningless (because count is

[Qemu-devel] [PULL 4/4] xen: ignore direction in bufioreq handling

From: Jan Beulich There's no way to communicate back read data, so only writes can ever be usefully specified. Ignore the field, paving the road for eventually re-using the bit for something else in a few (many?) years time. Signed-off-by: Jan Beulich

[Qemu-devel] [PULL 1/4] xen_disk: split discard input to match internal representation

From: Olaf Hering The guest sends discard requests as u64 sector/count pairs, but the block layer operates internally with s64/s32 pairs. The conversion leads to IO errors in the guest, the discard request is not processed. domU.cfg: 'vdev=xvda, format=qcow2,

[Qemu-devel] [PULL 2/4] xen: fix quad word bufioreq handling

From: Jan Beulich We should not consume the second slot if it didn't get written yet. Normal writers - i.e. Xen - would not update write_pointer between the two writes, but the page may get fiddled with by the guest itself, and we're better off avoiding to enter an infinite

[Qemu-devel] [PULL for-2.8 0/4] tags/xen-20161128-tag

The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20161128-tag for you to fetch changes up

Re: [Qemu-devel] [PATCH v2 2/3] xen: slightly simplify bufioreq handling

On Fri, 25 Nov 2016, Jan Beulich wrote: > There's no point setting fields always receiving the same value on each > iteration, as handle_ioreq() doesn't alter them anyway. Set state and > count once ahead of the loop, drop the redundant clearing of > data_is_ptr, and avoid the meaningless setting

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix quad word bufioreq handling

On Fri, 25 Nov 2016, Jan Beulich wrote: > We should not consume the second slot if it didn't get written yet. > Normal writers - i.e. Xen - would not update write_pointer between the > two writes, but the page may get fiddled with by the guest itself, and > we're better off avoiding to enter an

Re: [Qemu-devel] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

On Mon, Nov 28, 2016 at 04:42:54PM +0100, Paolo Bonzini wrote: > > Aha, I looked at GCC source code and this is incorrect: "Use -r instead > of -Wl,-r to avoid gcc passing -r to the linker when PIE is enabled". > When GCC sees -r (as opposed to -Wl,-r) it does not pass -pie to the linker. That's

[Qemu-devel] [PATCH] net: mcf: check receive buffer size register value

From: Prasad J Pandit ColdFire Fast Ethernet Controller uses a receive buffer size register(EMRBR) to hold maximum size of all receive buffers. It is set by a user before any operation. If it was set to be zero, ColdFire emulator would go into an infinite loop while

Re: [Qemu-devel] [PATCH v7 5/5] IOMMU: add specific null implementation of iommu_replay to intel_iommu

On Mon, Nov 28, 2016 at 6:36 PM Alex Williamson wrote: > On Mon, 28 Nov 2016 17:51:55 +0200 > "Aviv B.D" wrote: > > > From: "Aviv Ben-David" > > > > Currently the implementation preventing VFIO to work together with > >

[Qemu-devel] [PATCH 2/2] fsl_etsec: Fix various small problems in hexdump code

Fix various small problems in hexdump code, such as: - Reference to non-existing field etsec->nic->nc.name is replaced with nc->name - Type mismatch warnings Signed-off-by: Andrey Smirnov --- hw/net/fsl_etsec/etsec.c | 4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH 1/2] fsl_etsec: Pad short payloads with zeros

Depending on QEMU network setup it is possible for us to receive a complete Ethernet packet that is less 64 bytes long. One such example is when QEMU is configured to use a standalone TAP device (not set to be a part of any bridge) receives and ARP packet. In cases like that we need to add more

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update xen-devel mailing list address

On Fri, 25 Nov 2016, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

On 11/28/2016 06:19 PM, Michael S. Tsirkin wrote: >>> +static int virtio_crypto_alg_ablkcipher_init_session( >>> > > + struct virtio_crypto_ablkcipher_ctx *ctx, >>> > > + uint32_t alg, const uint8_t *key, >>> > > + unsigned int keylen, >>> > > +

Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

On 11/24/2016 07:16 AM, Fabian Lesniak wrote: > This patch introduces the SIDE and EXTRA mouse buttons and implements > appropriate event generation for gtk and input-linux input methods. > > The naming was borrowed from evdev since it is more descriptive than > BUTTON4/5. > > Note that the

Re: [Qemu-devel] [Nbd] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

Hi Stefan, On Mon, Nov 28, 2016 at 11:19:44AM +, Stefan Hajnoczi wrote: > On Sun, Nov 27, 2016 at 08:17:14PM +0100, Wouter Verhelst wrote: > > Quickly: the reason I haven't merged this yes is twofold: > > - I wasn't thrilled with the proposal at the time. It felt a bit > > hackish, and

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

On 28/11/2016 18:12, Eduardo Habkost wrote: >>> > > >>> > > Why not use src_use_reliable_get_clock here, too? (Maybe rename >>> > > it to simply clock_is_reliable?) >> > >> > Because you end up mixing two mental ideas (one: whether the source >> > has KVM_GET_CLOCK, second: whether the

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

On 28/11/2016 17:36, Marcelo Tosatti wrote: > If the source masterclock is disabled, then the guest does > not enable the optimization to not use a global variable > to guarantee monotonicity. Therefore there will be no > time backwards events (the timer backwards events crashed > guests, and

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

On Mon, Nov 28, 2016 at 04:20:55PM +, Stefan Hajnoczi wrote: > On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > > This patch introduces virtio-crypto driver for Linux Kernel. > > > > The virtio crypto device is a virtual cryptography device > > as well as a kind of virtual hardware

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

On Mon, Nov 28, 2016 at 02:45:24PM -0200, Marcelo Tosatti wrote: > On Mon, Nov 28, 2016 at 12:13:22PM -0200, Eduardo Habkost wrote: > > Sorry for not noticing the following issues on the previous > > reviews. I was only paying attention to the vmstate and machine > > code: > > > > On Mon, Nov 21,

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

On Mon, Nov 28, 2016 at 12:13:22PM -0200, Eduardo Habkost wrote: > Sorry for not noticing the following issues on the previous > reviews. I was only paying attention to the vmstate and machine > code: > > On Mon, Nov 21, 2016 at 08:50:04AM -0200, Marcelo Tosatti wrote: > > Check for

Re: [Qemu-devel] [qemu patch 2/2] kvmclock: reduce kvmclock difference on migration

On Mon, Nov 28, 2016 at 02:47:18PM +0100, Paolo Bonzini wrote: > > > On 17/11/2016 13:16, Marcelo Tosatti wrote: > > What QEMU wants is to use KVM_GET_CLOCK at pre_save independently > > of whether masterclock is enabled or not... it just depends > > on KVM_GET_CLOCK being correct for the

Re: [Qemu-devel] [PATCH v7 5/5] IOMMU: add specific null implementation of iommu_replay to intel_iommu

On Mon, 28 Nov 2016 17:51:55 +0200 "Aviv B.D" wrote: > From: "Aviv Ben-David" > > Currently the implementation preventing VFIO to work together with > intel_iommu. > > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c | 7

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

On 28 November 2016 at 16:01, Vijay Kilari wrote: > On Mon, Nov 28, 2016 at 6:31 PM, Peter Maydell > wrote: >> On 23 November 2016 at 12:39, wrote: >>> From: Vijaya Kumar K >>> >>> Reset CPU

Re: [Qemu-devel] [PULL 0/1] Coverity fix on target-i386

On Fri, Nov 25, 2016 at 07:30:00PM -0200, Eduardo Habkost wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] configure: fix LTTng UST tracing backend detection

The detection program needs to be linked with -ldl to build succesfully with recent versions of LTTng-UST. We also need to add -ldl to the libs required to build the LTTng-UST backend (lttng_ust_libs). Signed-off-by: Francis Deslauriers --- configure | 4 ++--

Re: [Qemu-devel] [PATCH v2 5/5] target-m68k: Implement bitfield ops for memory

On 11/27/2016 11:48 AM, Laurent Vivier wrote: >> > +return (int64_t)(data << d.bofs) >> (64 - len); > We must use d.len instead of len, otherwise we shift with 32bit value. > > -return (int64_t)(data << d.bofs) >> (64 - len); > +return (int64_t)(data << d.bofs) >> (64 - d.len);

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

On Mon, Nov 28, 2016 at 08:08:23PM +0800, Gonglei wrote: > This patch introduces virtio-crypto driver for Linux Kernel. > > The virtio crypto device is a virtual cryptography device > as well as a kind of virtual hardware accelerator for > virtual machines. The encryption anddecryption requests >

Re: [Qemu-devel] [PATCH v10 07/10] hbitmap: serialization

On 11/25/2016 09:59 AM, Markus Armbruster wrote: John Snow writes: From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and

Re: [Qemu-devel] [PATCH v3] crypto: add virtio-crypto driver

Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver

Re: [Qemu-devel] [PATCH v6 4/4] hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers

On Mon, Nov 28, 2016 at 6:31 PM, Peter Maydell wrote: > On 23 November 2016 at 12:39, wrote: >> From: Vijaya Kumar K >> >> Reset CPU interface registers of GICv3 when CPU is reset. >> For this, object interface is used,

Re: [Qemu-devel] sane char device writes?

On 28/11/2016 16:53, Michal Suchánek wrote: >> > >> > My idea looks very much like Michal's. I hadn't gone very much beyond >> > the "you need a buffer" step, but anyway you don't need a timer---you >> > can just record a chr_accept_input callback in gd_vc_handler. It will >> > be called when

[Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

From: "Aviv Ben-David" Adds a list of registered vtd_as's to intel iommu state to save iteration over each PCI device in a search of the corrosponding domain. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 94

[Qemu-devel] [PATCH v7 2/5] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

From: "Aviv Ben-David" Supports translation trials without reporting error to guest on translation failure. Signed-off-by: Aviv Ben-David --- exec.c | 3 ++- hw/alpha/typhoon.c | 2 +- hw/i386/amd_iommu.c | 4 ++--

Re: [Qemu-devel] sane char device writes?

Hello, On Fri, 25 Nov 2016 17:16:39 +0100 Paolo Bonzini wrote: > On 24/11/2016 08:51, Thomas Huth wrote: > > > So for this to work an extra buffer would have to be stored in > > > gtk.c somewhere, and possibly similar timer trick used as in > > > console.c > > > > > > Any

[Qemu-devel] [PATCH v7 4/5] IOMMU: add specific replay function with default implemenation

From: "Aviv Ben-David" The default implementation scans the address space and try to find translation for each page, if exists. This callback enables effiecent implementation for intel_iommu and other subsystems with large address space. Signed-off-by: Aviv Ben-David

[Qemu-devel] [PATCH v7 1/5] IOMMU: add option to enable VTD_CAP_CM to vIOMMU capility exposoed to guest

From: "Aviv Ben-David" This capability asks the guest to invalidate cache before each map operation. We can use this invalidation to trap map operations in the hypervisor. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 5 +

[Qemu-devel] [PATCH v7 5/5] IOMMU: add specific null implementation of iommu_replay to intel_iommu

From: "Aviv Ben-David" Currently the implementation preventing VFIO to work together with intel_iommu. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/intel_iommu.c

[Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

From: "Aviv Ben-David" * Advertize Cache Mode capability in iommu cap register. This capability is controlled by "cache-mode" property of intel-iommu device. To enable this option call QEMU with "-device intel-iommu,cache-mode=true". * On page cache invalidation in intel

Re: [Qemu-devel] [PATCH] block/mirror: Fix passing wrong argument to trace_mirror_yield

On Mon, 11/28 16:58, Yang Wei wrote: > mirror_yield is defined in block/trace-event, just like the following: > mirror_yield(void *s, int64_t cnt, int buf_free_count, int in_flight) > so we should exchange arguement 2 and 4 while invoking it. > > Signed-off-by: Yang Wei > ---

Re: [Qemu-devel] [PATCH] rules.mak: Use -r instead of -Wl, -r to fix building when PIE is default

On 28/11/2016 16:38, Paolo Bonzini wrote: > > > On 28/11/2016 16:24, Adrian Bunk wrote: >> On Mon, Nov 28, 2016 at 04:05:33PM +0100, Paolo Bonzini wrote: >>> >>> >>> On 27/11/2016 17:28, Adrian Bunk wrote: Building qemu fails in distributions where gcc enables PIE by default (e.g.

Re: [Qemu-devel] Linux kernel polling for QEMU

On 28/11/2016 16:29, Stefan Hajnoczi wrote: > Thanks for sharing the link. I'll let you know before embarking on an > effort to make epoll support busy_loop. > > At the moment I'm still evaluating whether the good results we've gotten > from polling in QEMU userspace are preserved when polling

  1   2   >