Re: [Qemu-devel] [PATCH 2/2] memory: hmp: dump flat view for 'info mtree'

2016-12-20 Thread Peter Xu
On Mon, Dec 19, 2016 at 10:10:23PM +0800, Peter Xu wrote: > Dumping flat view will be useful to debug the memory rendering logic, > also it'll be much easier with it to know what memory region is handling > what address range. > > Signed-off-by: Peter Xu > --- > memory.c | 31

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-20 Thread Thomas Huth
On 20.12.2016 18:43, Eduardo Habkost wrote: > This moves the KVM and Xen files to the an accel/ subdir. > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > move most of the stub code to libqemustub.a. This way the obj-y > logic for accel/ is simpler: obj-y includes accel/ only

Re: [Qemu-devel] [RFC 6/7] accel: Move accel.c to accel/

2016-12-20 Thread Thomas Huth
On 20.12.2016 18:43, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > Makefile.objs| 2 +- > accel.c => accel/accel.c | 0 > accel/Makefile.objs | 2 ++ > 3 files changed, 3 insertions(+), 1 deletion(-) > rename accel.c => accel/accel.c

Re: [Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU

2016-12-20 Thread Thomas Huth
On 20.12.2016 18:43, Eduardo Habkost wrote: > Now the stubs required by *-user are inside stubs/kvm.c, so > kvm-stub.c is needed only by CONFIG_SOFTMMU. > > Cc: Paolo Bonzini > Cc: k...@vger.kernel.org > Signed-off-by: Eduardo Habkost > --- >

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Zhang Chen
On 12/21/2016 08:18 AM, Stefano Stabellini wrote: On Fri, 16 Dec 2016, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH v6 kernel 5/5] virtio-balloon: tell host vm's unused page info

2016-12-20 Thread Liang Li
This patch contains two parts: One is to add a new API to mm go get the unused page information. The virtio balloon driver will use this new API added to get the unused page info and send it to hypervisor(QEMU) to speed up live migration. During sending the bitmap, some the pages may be modified

[Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process

2016-12-20 Thread Liang Li
The implementation of the current virtio-balloon is not very efficient, the time spends on different stages of inflating the balloon to 7GB of a 8GB idle guest: a. allocating pages (6.5%) b. sending PFNs to host (68.3%) c. address translation (6.1%) d. madvise (19%) It takes about 4126ms for the

[Qemu-devel] [PATCH v6 kernel 4/5] virtio-balloon: define flags and head for host request vq

2016-12-20 Thread Liang Li
Define the flags and head struct for a new host request virtual queue. Guest can get requests from host and then responds to them on this new virtual queue. Host can make use of this virtual queue to request the guest do some operations, e.g. drop page cache, synchronize file system, etc. And the

[Qemu-devel] [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2016-12-20 Thread Liang Li
Add a new feature which supports sending the page information with range array. The current implementation uses PFNs array, which is not very efficient. Using ranges can improve the performance of inflating/deflating significantly. Signed-off-by: Liang Li Cc: Michael S.

[Qemu-devel] [PATCH v6 kernel 1/5] virtio-balloon: rework deflate to add page to a list

2016-12-20 Thread Liang Li
When doing the inflating/deflating operation, the current virtio-balloon implementation uses an array to save 256 PFNS, then send these PFNS to host through virtio and process each PFN one by one. This way is not efficient when inflating/deflating a large mount of memory because too many times of

[Qemu-devel] [PATCH v6 kernel 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-20 Thread Liang Li
This patch set contains two parts of changes to the virtio-balloon. One is the change for speeding up the inflating & deflating process, the main idea of this optimization is to use {pfn|length} to present the page information instead of the PFNs, to reduce the overhead of virtio data

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Zhang Chen
On 12/20/2016 10:42 PM, Eric Blake wrote: On 12/15/2016 08:46 PM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v4 1/2] util/mmap-alloc: check parameter before using

2016-12-20 Thread Cao jin
ping On 11/02/2016 09:44 PM, Cao jin wrote: > Signed-off-by: Cao jin > --- > util/mmap-alloc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c > index 5a85aa3..d713a72 100644 > ---

Re: [Qemu-devel] [PATCH 2/2] pcie: fix typo in comments

2016-12-20 Thread Cao jin
ping On 11/11/2016 11:02 AM, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/pci/pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c > index 99cfb45..39b10b8 100644 > --- a/hw/pci/pcie.c > +++

Re: [Qemu-devel] [PATCH 1/2] vfio: remove a duplicated word in comments

2016-12-20 Thread Cao jin
ping On 11/11/2016 11:01 AM, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/vfio/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 31aaecb..c94987c 100644 > --- a/hw/vfio/pci.c > +++

Re: [Qemu-devel] [PATCH v7 00/10] Convert msix_init() to error

2016-12-20 Thread Cao jin
ping On 11/14/2016 03:25 PM, Cao jin wrote: > v7 changelog: > 1. fix the segfaut bug in patch 2. So drop the all the R-b of it, >please take a look, there is detailed description in the patch. > 2. add the R-b from Hannes Reinecke > > Test: > 1. make check: pass > 2. After applied all the

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2016-12-20 Thread Pavel Dovgalyuk
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > On Tue, Dec 20, 2016 at 11:10 AM, Pavel Dovgalyuk wrote: > >> From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > >> On Tue, Dec 20, 2016 at 10:45:44AM +0300, Pavel Dovgalyuk wrote: > >> > It

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 for-2.9 0/6] HPT resizing for pseries guests (qemu part)

2016-12-20 Thread David Gibson
On Tue, Dec 20, 2016 at 10:19:21AM +0100, Andrea Bolognani wrote: > On Tue, 2016-12-20 at 10:47 +1100, David Gibson wrote: > > > Do we want to expose a knob for controlling this > > > to the user at the libvirt level, or should we just enable > > > resize-hpt unconditionally whenever we detect

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.8.0 is now available

2016-12-20 Thread Holger Schranz
Hi Michael, could it be, that the link to qemu-2.8.0.tar.bz2 is linked to the qemu-2.8.0-rc4.tar.bz2? The link for signature seems it is correct. Best regards Holger Am 20.12.2016 um 22:00 schrieb Michael Roth: Hello, On behalf of the QEMU Team, I'd like to announce the availability of the

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-20 Thread Holger Schranz
Hi Fam, meanwhile I have sent the requested QEMU CLI direct to John. Your request I will try after the reinstall with the released version.So please wait for a while. Best regards Holger Am 21.12.2016 um 00:47 schrieb Fam Zheng: On Tue, 12/20 17:53, Holger Schranz wrote: Hi John, sorry or

Re: [Qemu-devel] [PATCH v2] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1482294077-29807-1-git-send-email-pet...@redhat.com Subject: [Qemu-devel] [PATCH v2] intel_iommu: allow dynamic switch of IOMMU region Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v2] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread Peter Xu
This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU region, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to make

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread David Gibson
On Tue, Dec 20, 2016 at 05:04:33PM -0700, Alex Williamson wrote: > On Tue, 20 Dec 2016 14:38:01 +0800 > Peter Xu wrote: > > > On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: > > > > [...] > > > > > > Yes, this patch just tried to move VT-d forward a bit,

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread David Gibson
On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: > On Tue, 20 Dec 2016 11:44:41 +0800 > Peter Xu wrote: > > > On Mon, Dec 19, 2016 at 09:56:50AM -0700, Alex Williamson wrote: > > > On Mon, 19 Dec 2016 22:41:26 +0800 > > > Peter Xu wrote: > >

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread David Gibson
On Tue, Dec 20, 2016 at 12:16:50PM +0800, Peter Xu wrote: > On Tue, Dec 20, 2016 at 10:30:12AM +1100, David Gibson wrote: > > [...] > > > > +static void vtd_switch_address_space(IntelIOMMUState *s, bool enabled) > > > +{ > > > +GHashTableIter iter; > > > +VTDBus *vtd_bus; > > > +

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread Peter Xu
On Tue, Dec 20, 2016 at 03:57:59PM -0800, no-re...@patchew.org wrote: [...] > /tmp/qemu-test/src/hw/i386/intel_iommu.c: In function > ‘vtd_switch_address_space’: > /tmp/qemu-test/src/hw/i386/intel_iommu.c:1196: warning: implicit declaration > of function ‘trace_vtd_switch_address_space’ >

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread Peter Xu
On Tue, Dec 20, 2016 at 03:02:54PM -0800, no-re...@patchew.org wrote: [...] > === OUTPUT BEGIN === > Checking PATCH 1/1: intel_iommu: allow dynamic switch of IOMMU region... > ERROR: "(foo**)" should be "(foo **)" > #55: FILE: hw/i386/intel_iommu.c:1190: > +while (g_hash_table_iter_next (,

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread Peter Xu
On Tue, Dec 20, 2016 at 05:04:33PM -0700, Alex Williamson wrote: > On Tue, 20 Dec 2016 14:38:01 +0800 > Peter Xu wrote: > > > On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: > > > > [...] > > > > > > Yes, this patch just tried to move VT-d forward a bit,

Re: [Qemu-devel] [PATCHv5 for 2.9 3/6] pseries: Implement HPT resizing

2016-12-20 Thread Suraj Jitindar Singh
On Tue, 2016-12-20 at 16:58 +1100, David Gibson wrote: > This patch implements hypercalls allowing a PAPR guest to resize its > own > hash page table.  This will eventually allow for more flexible memory > hotplug. > > The implementation is partially asynchronous, handled in a special > thread >

Re: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device

2016-12-20 Thread Fam Zheng
On Tue, 12/20 15:04, no-re...@patchew.org wrote: > ERROR: that open brace { should be on the previous line > #287: FILE: util/vfio-helpers.c:214: > +struct vfio_group_status group_status = > +{ .argsz = sizeof(group_status) }; Hmm, it may indeed look better. > ERROR: Use of volatile is

Re: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device

2016-12-20 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20161220163139.12016-1-f...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block

[Qemu-devel] [PATCH 2/3] console: move window ID code from baum to sdl

2016-12-20 Thread Samuel Thibault
This moves the SDL bits for window ID from the baum driver to SDL, as well as fixing the build for non-X11. Signed-off-by: Samuel Thibault --- Difference from v3: Use qemu_console_lookup_by_index and qemu_console_is_graphic to access the console ---

[Qemu-devel] [PATCH 3/3] sdl2: set window ID

2016-12-20 Thread Samuel Thibault
This uses the console API to record the window ID of the SDL2 windows. Signed-off-by: Samuel Thibault --- ui/sdl2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 30d2a3c35d..9a79b17b92 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c

[Qemu-devel] [PATCH 1/3] console: add API to get underlying gui window ID

2016-12-20 Thread Samuel Thibault
This adds two console functions, qemu_console_set_window_id and qemu_graphic_console_get_window_id, to let graphical backend record the window id in the QemuConsole structure, and let the baum driver read it. Signed-off-by: Samuel Thibault --- Difference from v4:

[Qemu-devel] [PATCHv4 0/3] Move getting XWindow ID from baum driver to graphical backend

2016-12-20 Thread Samuel Thibault
Hello, This is a respin of moving getting XWindow ID from baum to actual graphical backends. This only contains the new API, the move of existing code to the new API, and the addition of support for SDL2. Gtk will need more discussion and work. Compared to v3, this makes the API use a

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-20 Thread Stefano Stabellini
On Tue, 20 Dec 2016, Eduardo Habkost wrote: > This moves the KVM and Xen files to the an accel/ subdir. > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > move most of the stub code to libqemustub.a. This way the obj-y > logic for accel/ is simpler: obj-y includes accel/ only

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Stefano Stabellini
On Fri, 16 Dec 2016, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24

Re: [Qemu-devel] [PATCH for-2.9 V4 1/2] Add a new qmp command to start/stop replication

2016-12-20 Thread Stefano Stabellini
On Fri, 16 Dec 2016, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt |

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread Alex Williamson
On Tue, 20 Dec 2016 14:38:01 +0800 Peter Xu wrote: > On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: > > [...] > > > > Yes, this patch just tried to move VT-d forward a bit, rather than do > > > it once and for all. I think we can do better than this in the

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1482158486-18597-1-git-send-email-pet...@redhat.com Subject: [Qemu-devel] [PATCH] intel_iommu: allow

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-20 Thread Fam Zheng
On Tue, 12/20 17:53, Holger Schranz wrote: > Hi John, > > sorry or late. I will reproduce it and send you the QEMU command line > instruction. > > About the guest system: LINUX SuSE SLES11 SP4. > > About 2.7.0 Release: it doesn't run without the patches for the issue: > [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks

2016-12-20 Thread Samuel Thibault
no-re...@patchew.org, on Tue 20 Dec 2016 15:15:43 -0800, wrote: > Your series seems to have some coding style problems. See output below for > more information: > ERROR: suspect code indent for conditional statements (10, 14) > #90: FILE: slirp/tftp.c:393: > + if (blksize > 0) { > +

[Qemu-devel] [PATCH v3 3/3] xlnx-zynqmp: Connect the ARM Generic Timer

2016-12-20 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 14 ++ include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 0d86ba3..f3891ae 100644 ---

Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20161220230732.17862-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device Message-id: 20161220163139.12016-1-f...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-12-20 Thread Samuel Thibault
Hervé Poussineau, on Mon 21 Nov 2016 20:45:49 +0100, wrote: > The blocksize option is defined in RFC 1783. > We now support block sizes between 1 and 1432 bytes, instead of 512 only. > > Signed-off-by: Hervé Poussineau I fixed a couple of trivial things and commited to my

[Qemu-devel] [PULL 1/2] slirp, disas: Replace min/max with MIN/MAX macros

2016-12-20 Thread Samuel Thibault
From: Yuval Shaia Signed-off-by: Yuval Shaia Reviewed-by: Markus Armbruster Reviewed-by: Laurent Vivier Signed-off-by: Samuel Thibault --- disas/m68k.c | 8 ++--

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region Message-id: 1482158486-18597-1-git-send-email-pet...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PULL 2/2] slirp: support dynamic block size for TFTP transfers

2016-12-20 Thread Samuel Thibault
From: Hervé Poussineau The blocksize option is defined in RFC 1783 and RFC 2348. We now support block sizes between 1 and 1428 bytes, instead of 512 only. Signed-off-by: Hervé Poussineau Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks

2016-12-20 Thread Samuel Thibault
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: Open 2.9 development tree (2016-12-20 16:20:16 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination Message-id: 1482187106-85065-1-git-send-email-sochin.ji...@huawei.com Type:

Re: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID Message-id: cover.1482187052.git@skyportsystems.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape module strings Message-id: 1482140507-23607-1-git-send-email-vlad.lu...@windriver.com Type: series === TEST SCRIPT

Re: [Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI

2016-12-20 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI Message-id: 20161201170624.26496-1-ler...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX macros

2016-12-20 Thread Samuel Thibault
I have applied it to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH v2 1/2] arm_generic_timer: Add the ARM Generic Timer

2016-12-20 Thread Alistair Francis
On Fri, Dec 16, 2016 at 1:03 PM, Alistair Francis wrote: > On Tue, Dec 13, 2016 at 5:11 AM, Peter Maydell > wrote: >> On 8 November 2016 at 00:58, Alistair Francis >> wrote: >>> Add the ARM generic timer. This

[Qemu-devel] [PATCH v3 1/3] arm_generic_timer: Add the ARM Generic Timer

2016-12-20 Thread Alistair Francis
Add the ARM generic timer. This allows the guest to poll the timer for values and also supports secure writes only. Signed-off-by: Alistair Francis --- V3: - Use ARM ARM names - Indicate that we don't support all of the registers - Fixup the Makefile CONFIG V2: -

[Qemu-devel] [PATCH v3 2/3] arm_generic_timer: Add support for the ReadBase memory map

2016-12-20 Thread Alistair Francis
Add support for the read only regions in the ReadBase memory map. Signed-off-by: Alistair Francis --- hw/timer/arm_generic_timer.c | 27 +++ include/hw/timer/arm_generic_timer.h | 12 2 files changed, 39 insertions(+)

[Qemu-devel] [PATCH v3 0/3] Add the generic ARM timer

2016-12-20 Thread Alistair Francis
These three patches and and connect the Generic ARM Timer. This includes support for dropping insecure writes and includes the ReadBase memory map. V3: - Add the ReadBase memory map - Update the names to match the ARM ARM V2: - Fix couter/counter typo Alistair Francis (3):

[Qemu-devel] [PATCH] i2c: Allow I2C devices to NAK start events

2016-12-20 Thread minyard
From: Corey Minyard Add a return value to the event handler. Some I2C devices will NAK if they have no data, so allow them to do this. This required the following changes: Go through all the event handlers and change them to return int and return 0. Modify

[Qemu-devel] [PULL 1/1] Move target-* CPU file into a target/ folder

2016-12-20 Thread Thomas Huth
We've currently got 18 architectures in QEMU, and thus 18 target-xxx folders in the root folder of the QEMU source tree. More architectures (e.g. RISC-V, AVR) are likely to be included soon, too, so the main folder of the QEMU sources slowly gets quite overcrowded with the target-xxx folders. To

[Qemu-devel] [PULL 0/1] Move target-xxx folders to target/ folder

2016-12-20 Thread Thomas Huth
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: Open 2.9 development tree (2016-12-20 16:20:16 +) are available in the git repository at: https://github.com/huth/qemu.git tags/target-dirs-20161220 for you to fetch changes up

[Qemu-devel] [PATCH] fsl_etsec: Fix Tx BD ring wrapping handling

2016-12-20 Thread Andrey Smirnov
Current code that handles Tx buffer desciprtor ring scanning employs the following algorithm: 1. Restore current buffer descriptor pointer from TBPTRn 2. Process current descriptor 3. If current descriptor has BD_WRAP flag set set current descriptor pointer to

[Qemu-devel] [ANNOUNCE] QEMU 2.8.0 is now available

2016-12-20 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 2.8.0 release. This release contains 1900+ commits from 201 authors. You can grab the tarball from our download page here: http://wiki.qemu.org/Download The full list of changes are available at:

[Qemu-devel] [PATCH v4 2/7] qcow2: Discard/zero clusters by byte count

2016-12-20 Thread Eric Blake
Passing a byte offset, but sector count, when we ultimately want to operate on cluster granularity, is madness. Clean up the interfaces to take both offset and count as bytes, while still keeping the assertion added previously that the caller must align the values to a cluster. Then rename

[Qemu-devel] [PATCH v4 7/7] tests: Add coverage for recent block geometry fixes

2016-12-20 Thread Eric Blake
Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries.

[Qemu-devel] [PATCH v4 4/7] blkdebug: Add pass-through write_zero and discard support

2016-12-20 Thread Eric Blake
In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. It also allows us to inject errors on those operations, just like we can for read/write/flush. We can also test the contract promised by the

[Qemu-devel] [PATCH v4 6/7] blkdebug: Add ability to override unmap geometries

2016-12-20 Thread Eric Blake
Make it easier to simulate various unusual hardware setups (for example, recent commits 3482b9b and b8d0a98 affect the Dell Equallogic iSCSI with its 15M preferred and maximum unmap and write zero sizing, or b2f95fe deals with the Linux loopback block device having a max_transfer of 64k), by

[Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic

2016-12-20 Thread Eric Blake
Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

[Qemu-devel] [PATCH v4 3/7] blkdebug: Sanity check block layer guarantees

2016-12-20 Thread Eric Blake
Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that

[Qemu-devel] QEMU 2.9 development tree is open!

2016-12-20 Thread Stefan Hajnoczi
The development tree is now open for QEMU 2.9. Thanks for your help and contributions in QEMU 2.8! Peter Maydell is qemu.git maintainer again for the QEMU 2.9 release cycle. Many maintainers will be offline over the coming days until new year. Expect patch review and merging to be slow until

[Qemu-devel] [PATCH v4 0/7] add blkdebug tests

2016-12-20 Thread Eric Blake
Based on Kevin's block-next branch: http://repo.or.cz/qemu/kevin.git/shortlog/refs/heads/block-next Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v4 v3 was: https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00278.html Since then: - Address comments from

[Qemu-devel] [PATCH v4 1/7] qcow2: Assert that cluster operations are aligned

2016-12-20 Thread Eric Blake
qcow2_discard_clusters() is set up to silently ignore sub-cluster head or tail on unaligned requests. However, it is easy to audit the various callers: qcow2_snapshot_create() has always passed aligned data since the call was introduced in 1ebf561; qcow2_co_pdiscard() has passed aligned clusters

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-20 Thread Stefan Weil
On 12/20/16 18:43, Eduardo Habkost wrote: This moves the KVM and Xen files to the an accel/ subdir. I hope that it won't last long until we also get acceleration for Windows and macOS. Those HAXM files will have to be moved as well. Regards, Stefan

Re: [Qemu-devel] [PATCH 22/23] target-arm: Enable EL2 feature bit on A53 and A57

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 5:32 AM, Peter Maydell wrote: > On 19 December 2016 at 22:04, Alistair Francis wrote: >> On Tue, Dec 13, 2016 at 8:11 AM, Edgar E. Iglesias >> wrote: >>> On Tue, Dec 13, 2016 at 10:36:23AM +,

[Qemu-devel] [RFC 5/7] kvm: Move kvm*.c files to accel/

2016-12-20 Thread Eduardo Habkost
While doing it, rename kvm-all.c to kvm-common.c to follow the same pattern used for xen. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Eduardo Habkost --- Makefile.target | 2 -- kvm-all.c => accel/kvm-common.c | 0

[Qemu-devel] [RFC 7/7] accel: Move qtest.c to accel/

2016-12-20 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile.target | 2 +- qtest.c => accel/qtest.c | 0 accel/Makefile.objs | 2 ++ 3 files changed, 3 insertions(+), 1 deletion(-) rename qtest.c => accel/qtest.c (100%) diff --git a/Makefile.target b/Makefile.target index

[Qemu-devel] [RFC 6/7] accel: Move accel.c to accel/

2016-12-20 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile.objs| 2 +- accel.c => accel/accel.c | 0 accel/Makefile.objs | 2 ++ 3 files changed, 3 insertions(+), 1 deletion(-) rename accel.c => accel/accel.c (100%) diff --git a/Makefile.objs b/Makefile.objs index

[Qemu-devel] [RFC 4/7] kvm: Include kvm-stub.o only on CONFIG_SOFTMMU

2016-12-20 Thread Eduardo Habkost
Now the stubs required by *-user are inside stubs/kvm.c, so kvm-stub.c is needed only by CONFIG_SOFTMMU. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Eduardo Habkost --- Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [RFC 2/7] xen: Move xen files to accel/

2016-12-20 Thread Eduardo Habkost
Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xensource.com Signed-off-by: Eduardo Habkost --- Makefile.target| 4 +--- xen-common.c => accel/xen-common.c | 0 xen-hvm.c =>

[Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-20 Thread Eduardo Habkost
This moves the KVM and Xen files to the an accel/ subdir. Instead of moving the *-stubs.c file to accel/ as-is, I tried to move most of the stub code to libqemustub.a. This way the obj-y logic for accel/ is simpler: obj-y includes accel/ only if CONFIG_SOFTMMU is set. The Xen stubs could be

[Qemu-devel] [RFC 1/7] xen: Move xen-*-stub.c to stubs/

2016-12-20 Thread Eduardo Habkost
Move xen stubs to stubs/ so they are handled automatically by libqemustub.a. Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xensource.com Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost

[Qemu-devel] [RFC 3/7] kvm: Move some kvm-stub.c code to stubs/kvm.c

2016-12-20 Thread Eduardo Habkost
Move the kvm-stub.c code that doesn't depend on cpu.h or CONFIG_* defines to stubs/kvm.c. Notes about copyright, licensing, and authorship: * There was no copyright not on the original stubs/kvm.c file. * As include/sysemu/kvm.h and kvm-all.c are licensed as GPLv2+, I am assuming stubs/kvm.c

Re: [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands

2016-12-20 Thread Ben Warren
Hi Eric, > On Dec 20, 2016, at 6:36 AM, Eric Blake wrote: > > On 12/19/2016 04:46 PM, b...@skyportsystems.com > wrote: >> From: Igor Mammedov >> >> Add set-vm-generation-id command to set Virtual Machine >> Generation ID

Re: [Qemu-devel] [PATCH for-2.9 01/10] tests: pc: add memory hotplug acpi tables tests

2016-12-20 Thread Marcel Apfelbaum
On 12/20/2016 06:17 PM, Igor Mammedov wrote: On Tue, 20 Dec 2016 12:40:21 +0200 Marcel Apfelbaum wrote: On 12/06/2016 01:32 AM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 24 1 file

Re: [Qemu-devel] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes

2016-12-20 Thread Eric Blake
On 12/07/2016 10:34 AM, Eric Blake wrote: > On 12/07/2016 10:16 AM, Kevin Wolf wrote: >> Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: >>> Use blkdebug's new geometry constraints to emulate setups that >>> have caused recent regression fixes: write zeroes asserting >>> when running through a

Re: [Qemu-devel] [PATCH for-2.9 05/10] memhp: consolidate scattered MHPD device declaration

2016-12-20 Thread Igor Mammedov
On Tue, 20 Dec 2016 13:00:35 +0200 Marcel Apfelbaum wrote: > On 12/06/2016 01:32 AM, Igor Mammedov wrote: > > since static and dynamic parts of memory MHPD device are now > > in the same table (DSDT), there is no point keeping > > them scattered across the table, so

Re: [Qemu-devel] [PATCH for-2.9 15/17] target-i386: Define static "base" CPU model

2016-12-20 Thread David Hildenbrand
Am 16.12.2016 um 17:02 schrieb Jiri Denemark: On Mon, Dec 05, 2016 at 21:57:45 -0200, Eduardo Habkost wrote: On Mon, Dec 05, 2016 at 07:18:47PM +0100, David Hildenbrand wrote: Am 02.12.2016 um 22:18 schrieb Eduardo Habkost: The query-cpu-model-expand QMP command needs at least one static

[Qemu-devel] [PATCH 2/4] util: Add a notifier list for qemu_vfree()

2016-12-20 Thread Fam Zheng
To allow other code to intercept buffer freeing and do customized unmapping operations. Signed-off-by: Fam Zheng --- include/qemu/notify.h | 1 + util/oslib-posix.c| 9 + 2 files changed, 10 insertions(+) diff --git a/include/qemu/notify.h b/include/qemu/notify.h

[Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device

2016-12-20 Thread Fam Zheng
This series adds a new protocol driver that is intended to achieve about 20% better performance for latency bound workloads (i.e. synchronous I/O) than linux-aio when guest is exclusively accessing a NVMe device, by talking to the device directly instead of through kernel file system layers and

Re: [Qemu-devel] [PATCH 4/4] block: Add VFIO based NVMe driver

2016-12-20 Thread Paolo Bonzini
- Original Message - > From: "Fam Zheng" > To: qemu-devel@nongnu.org > Cc: "Paolo Bonzini" , qemu-bl...@nongnu.org, "Karl > Rister" , "Kevin Wolf" > , "Max Reitz" , borntrae...@de.ibm.com, >

[Qemu-devel] [PATCH 3/4] util: Add VFIO helper library

2016-12-20 Thread Fam Zheng
This is a simple helper library to be used by VFIO device drivers in QEMU, makeing it very easy to interface with /dev/vfio and do DMA mappings. Especially, once initialized, this module proactively maps all guest ram regions to IO address space (in the host IOMMU context) so that in further I/O

Re: [Qemu-devel] [PATCH for-2.9 04/10] memhp: move build_memory_devices() into memory_hotplug.c

2016-12-20 Thread Igor Mammedov
On Tue, 20 Dec 2016 12:44:22 +0200 Marcel Apfelbaum wrote: > On 12/06/2016 01:32 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > include/hw/acpi/memory_hotplug.h | 2 + > > hw/acpi/memory_hotplug.c | 124 > >

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-20 Thread Holger Schranz
Hi John, sorry or late. I will reproduce it and send you the QEMU command line instruction. About the guest system: LINUX SuSE SLES11 SP4. About 2.7.0 Release: it doesn't run without the patches for the issue: [Qemu-devel] [PATCH] iscsi: Fix divide-by-zero regression on raw SG devices (I

[Qemu-devel] [PATCH 4/4] block: Add VFIO based NVMe driver

2016-12-20 Thread Fam Zheng
This is a new protocol driver that exclusively opens a host NVMe controller through VFIO. It achieves better latency than linux-aio. nvme://linux-aio -- fio bs=4k iodepth=1 (IOPS)

[Qemu-devel] [PATCH 1/4] ramblock-notifier: new

2016-12-20 Thread Fam Zheng
From: Paolo Bonzini This adds a notify interface of ram block additions and removals. Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng --- exec.c | 5 include/exec/memory.h | 6 +

Re: [Qemu-devel] [PATCH for-2.9 01/10] tests: pc: add memory hotplug acpi tables tests

2016-12-20 Thread Igor Mammedov
On Tue, 20 Dec 2016 12:40:21 +0200 Marcel Apfelbaum wrote: > On 12/06/2016 01:32 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > tests/bios-tables-test.c | 24 > > 1 file changed, 24 insertions(+) > > > >

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2016-12-20 Thread Stefan Hajnoczi
Thanks for looking into this bug. The QEMU 2.8 release will go ahead as planned today since this is an existing race and there is a potential workaround (i.e. disabling vapic on x86). Stefan

Re: [Qemu-devel] qemu-2.8-rc4 is broken

2016-12-20 Thread Alex Bennée
So having a quick review on #qemu with Stefan I think this is an existing race condition that may have been made more likely with recent changes. AFAICT what is happening is mouse movement in the GUI is translated into PS2 events which are injected as interrupts into the system by GUI thread. For

Re: [Qemu-devel] [PATCH v4 1/7] fw-cfg: support writeable blobs

2016-12-20 Thread Marcel Apfelbaum
On 12/01/2016 07:06 PM, Laszlo Ersek wrote: From: "Michael S. Tsirkin" Useful to send guest data back to QEMU. Changes from Laszlo Ersek : - rebase the patch from Michael Tsirkin's original postings at [1] and [2] to the following patches: - loader:

  1   2   >