Re: [Qemu-devel] [PATCH] spapr: fix buffer-overflow

On Thu, Mar 23, 2017 at 02:04:55PM +0400, Marc-André Lureau wrote: > Running postcopy-test with ASAN produces the following error: > > QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/postcopy-test > ... > = > ==23641==ERROR:

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

On Thu, Mar 23, 2017 at 04:56:30PM -0500, Eric Blake wrote: > On 03/23/2017 04:43 PM, Eric Blake wrote: > > > We'd still have to allow libvirt's use of > > ":key=...:auth_supported=cephx\\;none" on the command line, but from the > > QMP side, we would support exactly one auth method, and libvirt

Re: [Qemu-devel] compile failure if I enable guest_mem_before trace event

On Thu, Mar 23, 2017 at 19:08:11 +, Peter Maydell wrote: > Hi; I thought I'd have a look at the guest_mem_before trace event, > but if I enable it (by deleting "disable" from the line in trace-events) > QEMU doesn't compile: > > CC arm-softmmu/tcg/tcg-op.o > In file included from >

Re: [Qemu-devel] [RFC] Split migration bitmaps by ramblock

Hi Juan, First of all, I like the refactor patchset about RAMState, it makes things clean, great! On 2017/3/24 5:01, Juan Quintela wrote: > Hi > > This series split the migration and unsent bitmaps by ramblock. This > makes it easier to synchronize in small bits. This is on top of the >

Re: [Qemu-devel] [Bug 1675108] [NEW] Cocoa UI always crashes on startup

On Mar 23, 2017, at 7:35 AM, qemu-devel-requ...@nongnu.org wrote: > Message: 15 > Date: Thu, 23 Mar 2017 11:13:02 + > From: Alex Benn?e > To: Peter Maydell > Cc: Bug 1675108 <1675...@bugs.launchpad.net>, QEMU Developers >

Re: [Qemu-devel] Proposal for deprecating unsupported host OSes & architecutures

On 03/23/2017 09:02 PM, Peter Maydell wrote: On 23 March 2017 at 10:33, Paolo Bonzini wrote: I own a MIPS Creator ci20 board (donated by Imagination Technologies). I cannot give it a public IP address, but I can try and use it to do builds every now and then. I think our

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

On 2017/3/24 4:45, Juan Quintela wrote: > We change the meaning of start to be the offset from the beggining of > the block. > > Signed-off-by: Juan Quintela > --- > include/exec/ram_addr.h | 2 ++ > migration/ram.c | 8 > 2 files changed, 6 insertions(+),

[Qemu-devel] [PATCH v2] migration: Fix colo hang in socket_accept_incoming_migration

From: Wang guang The channel socket was initialized manually, but forgot to set QIO_CHANNEL_FEATURE_SHUTDOWN. Thus, the colo_process_incoming_thread would hang at recvmsg. This patch just call qio_channel_socket_new to get channel, Which set QIO_CHANNEL_FEATURE_SHUTDOWN

Re: [Qemu-devel] [PATCH v4 02/16] s390: cio: export more interfaces

* Sebastian Ott [2017-03-23 13:02:46 +0100]: > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > Export the common I/O interfaces those are needed by an I/O > > subchannel driver to actually talk to the subchannel. > > > > Reviewed-by: Pierre Morel

Re: [Qemu-devel] [PATCH v2] xen-platform: separate unplugging of NVMe disks

On Thu, 23 Mar 2017, Paul Durrant wrote: > Commit 090fa1c8 "add support for unplugging NVMe disks..." extended the > existing disk unplug flag to cover NVMe disks as well as IDE and SCSI. > > The recent thread on the xen-devel mailing list [1] has highlighted that > this is not desirable

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

> Perhaps all trace.o files should be put into their own .a instead of > being added directly to the linker line: > > COMMON_LDADDS = $(trace-obj-y) libqemuutil.a libqemustub.a > > I think the linker would only pull in .o files containing symbols that are > actually referenced by the program.

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

On 03/23/2017 04:43 PM, Eric Blake wrote: > We'd still have to allow libvirt's use of > ":key=...:auth_supported=cephx\\;none" on the command line, but from the > QMP side, we would support exactly one auth method, and libvirt will be > updated to match when it starts targetting blockdev-add

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

On 03/23/2017 03:59 PM, Eric Blake wrote: > On 03/23/2017 01:10 PM, Eric Blake wrote: > >>> # @RbdAuthMethod: >>> # >>> # An enumeration of rados auth_supported types >>> # >>> # Since: 2.9 >>> ## >>> -{ 'struct': 'RbdAuthMethod', >>> - 'data': { 'auth': 'RbdAuthSupport' } } >>> +{ 'enum':

[Qemu-devel] [RFC 4/4] q35: Remove fw_cfg* from sysbus whitelist

fw_cfg devices are supposed to be created by the q35 board code, and not manually using -device. Remove them from the whitelist. Suggested-by: Laszlo Ersek Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 2 -- 1 file changed, 2 deletions(-) diff

[Qemu-devel] [RFC 3/4] q35: Remove ioapic devices from sysbus whitelist

An ioapic device is always created by the q35 machine, so "-device ioapic" and "-device kvm-ioapic" never worked before. Remove it from the sysbus whitelist. Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[Qemu-devel] [RFC 2/4] machine: Replace has_dynamic_sysbus with a whitelist

Replace the existing has_dynamic_sysbus flag, that makes the machine accept every single sysbus device type on the command-line, with a short whitelist. Most of the machines already have an internal whitelist implemented using foreach_dynamic_sysbus_device(), so we just encode the existing

Re: [Qemu-devel] [RFC 1/1] qcow2: add ZSTD compression feature

Am 23.03.2017 um 16:35 hat Denis V. Lunev geschrieben: > On 03/23/2017 06:04 PM, Kevin Wolf wrote: > > Am 23.03.2017 um 15:17 hat Eric Blake geschrieben: > >> On 03/23/2017 08:28 AM, Denis V. Lunev wrote: > >>> ZSDT compression algorithm consumes 3-5 times less CPU power with a > >> s/ZSDT/ZSTD/ >

[Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist

Summary --- This series replaces the existing has_dynamic_sysbus flag (that makes the machine accept every single sysbus device type on the command-line) with a short whitelist. This will be helpful when implementing the new query-device-slots command, because each machine type will include

[Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

The xen-backend devices created by the Xen code are not supposed to be treated as dynamic sysbus devices. This is an attempt to change that and see what happens, but I couldn't test it because I don't have a Xen host set up. If this patch breaks anything, this means we have a bug in

Re: [Qemu-devel] [PATCH v3 2/4] qdev: add function qdev_set_id()

On Tue, Nov 22, 2016 at 07:10:57AM +0100, Juergen Gross wrote: > In order to have an easy way to add a new qdev with a specific id > carve out the needed functionality from qdev_device_add() into a new > function qdev_set_id(). > > Signed-off-by: Juergen Gross > Reviewed-by:

[Qemu-devel] [RFC] Split migration bitmaps by ramblock

Hi This series split the migration and unsent bitmaps by ramblock. This makes it easier to synchronize in small bits. This is on top of the RAMState and not-hotplug series. Why? reason 1: People have complained that by the time that we detect that a page is sent, it has already been marked

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

On 03/23/2017 01:10 PM, Eric Blake wrote: >> # @RbdAuthMethod: >> # >> # An enumeration of rados auth_supported types >> # >> # Since: 2.9 >> ## >> -{ 'struct': 'RbdAuthMethod', >> - 'data': { 'auth': 'RbdAuthSupport' } } >> +{ 'enum': 'RbdAuthMethod', >> + 'data': [ 'cephx', 'none' ] } >

Re: [Qemu-devel] [PATCH v3 3/4] xen: create qdev for each backend device

Hi, I am reviewing the existing code that sets has_dynamic_sysbus, and this patch confused me. I have a question below: On Tue, Nov 22, 2016 at 07:10:58AM +0100, Juergen Gross wrote: > Create a qdev plugged to the xen-sysbus for each new backend device. > This device can be used as a parent for

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

Am 23.03.2017 um 11:55 hat Markus Armbruster geschrieben: > BlockdevOptionsRbd member auth-supported is a list of struct > RbdAuthMethod, whose only member is enum RbdAuthSupport. There is no > reason for wrapping the enum in a struct. Delete the wrapper, and > rename the enum. > >

[Qemu-devel] [RFC 0/2] Disable hotplug during migration

Hi This series disable hotplug/unplug during migration. Thank to Markus for explaining where I had to put the checks. Why? Because during migration we will fail if there are changes. For instance, in postcopy, if we add a memory region, we would failing. Same for other devices if they are

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

Hello Stephen, or anyone else affected, Accepted qemu into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.5+dfsg- 5ubuntu10.10 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

Re: [Qemu-devel] [PATCH] tcg/i386: Check the size of instruction being translated

On 03/24/2017 03:58 AM, Pranith Kumar wrote: Sending again since I messed by pbonzini's email. This fixes the bug: 'user-to-root privesc inside VM via bad translation caching' reported by Jann Horn here: https://bugs.chromium.org/p/project-zero/issues/detail?id=1122 CC: Richard Henderson

[Qemu-devel] [PATCH 50/51] ram: Use RAMBitmap type for coherence

Signed-off-by: Juan Quintela --- migration/ram.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1be9a6b..4d62788 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1449,7 +1449,7 @@ void

Re: [Qemu-devel] [PATCH for-2.9 2/5] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts

Am 23.03.2017 um 11:55 hat Markus Armbruster geschrieben: > The conversion from QDict to QemuOpts is pointless. Simply get the > stuff straight from the QDict. > > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH] ram: Split dirty bitmap by RAMBlock

Both the ram bitmap and the unsent bitmap are split by RAMBlock. Signed-off-by: Juan Quintela --- include/exec/ram_addr.h | 13 +++- migration/ram.c | 201 ++-- 2 files changed, 85 insertions(+), 129 deletions(-) diff

[Qemu-devel] [PATCH 2/2] ram: remove migration_bitmap_extend()

We have disabled memory hotplug, so we don't need to handle migration_bitamp there. Signed-off-by: Juan Quintela --- exec.c | 1 - include/exec/ram_addr.h | 2 -- migration/ram.c | 34 -- 3 files changed, 37

[Qemu-devel] [PATCH 51/51] migration: Remove MigrationState parameter from migration_is_idle()

Only user don't have a MigrationState handly. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 +- migration/migration.c | 8 +++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/migration/migration.h

[Qemu-devel] [PATCH 47/51] ram: Change offset field in PageSearchStatus to page

We are moving everything to work on pages, not addresses. Signed-off-by: Juan Quintela --- migration/ram.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 48/51] ram: Use ramblock and page offset instead of absolute offset

This removes the needto pass also the absolute offset. Signed-off-by: Juan Quintela --- migration/ram.c| 56 ++ migration/trace-events | 2 +- 2 files changed, 26 insertions(+), 32 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] migration: Disable hotplug/unplug during migration

Until we have reviewed what can/can't be hotplug during migration, disable it. We can enable it later for the things that we know that work. For instance, memory hotplug during postcopy don't work currently. Signed-off-by: Juan Quintela --- hw/core/qdev.c | 5 +

[Qemu-devel] [PATCH 46/51] ram: Remember last_page instead of last_offset

Signed-off-by: Juan Quintela --- migration/ram.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b1a031e..57b776b 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -171,8 +171,8 @@ struct RAMState

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

On 03/23/2017 02:18 PM, Eric Blake wrote: -if (port) { -/* check for ipv6 */ -if (strchr(host, ':')) { -strbuf = g_strdup_printf("[%s]:%s", host, port); -} else { -

[Qemu-devel] [PATCH 41/51] Add page-size to output in 'info migrate'

From: Chao Fan The number of dirty pages outputed in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian

[Qemu-devel] [PATCH 45/51] ram: Use page number instead of an address for the bitmap operations

We use an unsigned long for the page number. Notice that our bitmaps already got that for the index, so we have that limit. Signed-off-by: Juan Quintela --- migration/ram.c | 76 ++--- 1 file changed, 34 insertions(+), 42

[Qemu-devel] [PATCH 44/51] ram: reorganize last_sent_block

We were setting it far away of when we changed it. Now everything is done inside save_page_header. Once there, reorganize code to pass RAMState. Signed-off-by: Juan Quintela --- migration/ram.c | 36 +++- 1 file changed, 15 insertions(+),

Re: [Qemu-devel] [PATCH for-2.9 1/5] rbd: Clean up runtime_opts

Am 23.03.2017 um 11:55 hat Markus Armbruster geschrieben: > runtime_opts is used for three different purposes: > > * qemu_rbd_open() uses it to accept options it recognizes, such as > "pool" and "image". Other .bdrv_open() methods do it similarly. > > * qemu_rbd_open() accepts additional

[Qemu-devel] [PATCH 38/51] migration: Remove MigrationState from migration_in_postcopy

We need to call for the migrate_get_current() in more that half of the uses, so call that inside. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 +- migration/migration.c | 6 -- migration/ram.c | 22 ++

[Qemu-devel] [PATCH 43/51] ram: ram_discard_range() don't use the mis parameter

Signed-off-by: Juan Quintela --- include/migration/migration.h | 3 +-- migration/postcopy-ram.c | 6 ++ migration/ram.c | 9 +++-- migration/savevm.c| 3 +-- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git

[Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

We change the meaning of start to be the offset from the beggining of the block. Signed-off-by: Juan Quintela --- include/exec/ram_addr.h | 2 ++ migration/ram.c | 8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/exec/ram_addr.h

[Qemu-devel] [PATCH 49/51] ram: rename last_ram_offset() last_ram_pages()

We always use it as pages anyways. Signed-off-by: Juan Quintela --- exec.c | 6 +++--- include/exec/ram_addr.h | 2 +- migration/ram.c | 11 +-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index

[Qemu-devel] [PATCH 40/51] ram: Rename qemu_target_page_bits() to qemu_target_page_size()

It was used as a size in all cases except one. Signed-off-by: Juan Quintela --- exec.c | 4 ++-- include/sysemu/sysemu.h | 2 +- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 8 migration/savevm.c | 8 5 files

[Qemu-devel] [PATCH 36/51] ram: Move QEMUFile into RAMState

We receive the file from save_live operations and we don't use it until 3 or 4 levels of calls down. Signed-off-by: Juan Quintela --- migration/ram.c | 84 + 1 file changed, 37 insertions(+), 47 deletions(-) diff

[Qemu-devel] [PATCH 37/51] ram: Move compression_switch to RAMState

Rename it to preffer_xbzrle that is a more descriptive name. Signed-off-by: Juan Quintela --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 6a39704..591cf89 100644 --- a/migration/ram.c

[Qemu-devel] [PATCH 39/51] ram: We don't need MigrationState parameter anymore

Remove it from callers and callees. Signed-off-by: Juan Quintela --- migration/ram.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cb5f06f..064b2c0 100644 --- a/migration/ram.c +++

[Qemu-devel] [PATCH 29/51] ram: Move last_req_rb to RAMState

It was on MigrationState when it is only used inside ram.c for postcopy. Problem is that we need to access it without being able to pass it RAMState directly. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 -- migration/migration.c | 1 -

[Qemu-devel] [PATCH 35/51] ram: Add QEMUFile to RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c0d6841..7667e73 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -165,6 +165,8 @@ struct

[Qemu-devel] [PATCH 32/51] ram: Remove dirty_bytes_rate

It can be recalculated from dirty_pages_rate. Signed-off-by: Juan Quintela Reviewed-by: Juan Quintela --- include/migration/migration.h | 1 - migration/migration.c | 6 +++--- migration/ram.c | 1 - 3 files changed, 3

[Qemu-devel] [PATCH 33/51] ram: Move dirty_pages_rate to RAMState

Treat it like the rest of ram stats counters. Export its value the same way. As an added bonus, no more MigrationState used in migration_bitmap_sync(); Signed-off-by: Juan Quintela Reviewed-by: Juan Quintela --- include/migration/migration.h | 2 +-

[Qemu-devel] [PATCH 25/51] ram: Move migration_bitmap_rcu into RAMState

Once there, rename the type to be shorter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 86 +++-- 1 file changed, 47 insertions(+), 39 deletions(-) diff

[Qemu-devel] [PATCH 34/51] ram: Move postcopy_requests into RAMState

Signed-off-by: Juan Quintela --- include/migration/migration.h | 6 ++ migration/migration.c | 5 ++--- migration/ram.c | 13 + 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/include/migration/migration.h

[Qemu-devel] [PATCH 20/51] ram: Move xbzrle_cache_miss_rate into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cc19406..c398ff9 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -178,6 +178,8 @@ struct RAMState {

[Qemu-devel] [PATCH 28/51] ram: Remove ram_save_remaining

Just unfold it. Move ram_bytes_remaining() with the rest of exported functions. Signed-off-by: Juan Quintela --- migration/ram.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PATCH 24/51] ram: Move migration_bitmap_mutex into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index a890179..ae2b89f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -184,6 +184,8 @@ struct

[Qemu-devel] [PATCH 31/51] ram: Create ram_dirty_sync_count()

This is a ram field that was inside MigrationState. Move it to RAMState and make it the same that the other ram stats. Signed-off-by: Juan Quintela --- include/migration/migration.h | 2 +- migration/migration.c | 3 +-- migration/ram.c | 6 +- 3

[Qemu-devel] [PATCH 18/51] ram: Move xbzrle_pages into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 721fd66..b4e647a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -174,6 +174,8 @@ struct RAMState {

[Qemu-devel] [PATCH 23/51] ram: Everything was init to zero, so use memset

And then init only things that are not zero by default. Signed-off-by: Juan Quintela --- migration/ram.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c6ba92c..a890179 100644 ---

[Qemu-devel] [PATCH 21/51] ram: Move xbzrle_overflows into RAMState

Once there, remove the now unused AccountingInfo struct and var. Signed-off-by: Juan Quintela --- migration/ram.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c398ff9..3292eb0 100644 ---

[Qemu-devel] [PATCH 30/51] ram: Move src_page_req* to RAMState

This are the last postcopy fields still at MigrationState. Once there Move MigrationSrcPageRequest to ram.c and remove MigrationState parameters where appropiate. Signed-off-by: Juan Quintela --- include/migration/migration.h | 17 +--- migration/migration.c

[Qemu-devel] [PATCH 17/51] ram: Move xbzrle_bytes into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 690ca8f..721fd66 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -172,6 +172,8 @@ struct RAMState {

[Qemu-devel] [PATCH 16/51] ram: Move iterations into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9fa3bd7..690ca8f 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -170,6 +170,8 @@ struct RAMState {

[Qemu-devel] [PATCH 19/51] ram: Move xbzrle_cache_miss into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index b4e647a..cc19406 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -176,6 +176,8 @@ struct RAMState {

[Qemu-devel] [PATCH 27/51] ram: Use the RAMState bytes_transferred parameter

Somewhere it was passed by reference, just use it from RAMState. Signed-off-by: Juan Quintela Reviewed-by: Juan Quintela --- migration/ram.c | 75 + 1 file changed, 27 insertions(+), 48

[Qemu-devel] [PATCH 15/51] ram: Remove norm_mig_bytes_transferred

Its value can be calculated by other exported. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 - migration/migration.c | 3 ++- migration/ram.c | 5 - 3 files changed, 2

[Qemu-devel] [PATCH 14/51] ram: Move norm_pages to RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 57f5858..2c36729 100644 ---

[Qemu-devel] [PATCH 26/51] ram: Move bytes_transferred into RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 090084b..872ea23 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -197,6

[Qemu-devel] [PATCH 13/51] ram: Remove unused pages_skipped variable

For compatibility, we need to still send a value, but just specify it and comment the fact. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 -- migration/migration.c | 3 ++-

[Qemu-devel] [PATCH 08/51] ram: Move num_dirty_pages_period into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 5e53b47..748d047 100644 ---

[Qemu-devel] [PATCH 12/51] ram: Remove unused dup_mig_bytes_transferred()

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 - migration/ram.c | 5 - 2 files changed, 6 deletions(-) diff --git a/include/migration/migration.h

[Qemu-devel] [PATCH 22/51] ram: Move migration_dirty_pages to RAMState

Signed-off-by: Juan Quintela --- migration/ram.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 3292eb0..c6ba92c 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -182,6

[Qemu-devel] [PATCH 10/51] ram: Move iterations_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PATCH 07/51] ram: Move bytes_xfer_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 5881805..5e53b47 100644 --- a/migration/ram.c

[Qemu-devel] [PATCH 05/51] ram: Move bitmap_sync_count into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 1d5bf22..f811e81 100644 ---

[Qemu-devel] [PATCH 09/51] ram: Move xbzrle_cache_miss_prev into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

[Qemu-devel] [PATCH 11/51] ram: Move dup_pages into RAMState

Once there rename it to its actual meaning, zero_pages. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH 04/51] ram: Add dirty_rate_high_cnt to RAMState

We need to add a parameter to several functions to make this work. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 06/51] ram: Move start time into RAMState

Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index f811e81..5881805 100644 ---

[Qemu-devel] [PATCH 01/51] ram: Update all functions comments

Added doc comments for existing functions comment and rewrite them in a common style. Signed-off-by: Juan Quintela --- migration/ram.c | 348 1 file changed, 227 insertions(+), 121 deletions(-) diff --git

[Qemu-devel] [PATCH 02/51] ram: rename block_name to rbname

So all places are consisten on the nambing of a block name parameter. Signed-off-by: Juan Quintela --- migration/ram.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 76f1fc4..21047c5 100644 ---

[Qemu-devel] [PATCH 03/51] ram: Create RAMState

We create a struct where to put all the ram state Start with the following fields: last_seen_block, last_sent_block, last_offset, last_version and ram_bulk_stage are globals that are really related together. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v2 00/51] Creating RAMState for migration

Hi Continuation of previous series, all review comments addressed. New things: - Consolidate all function comments in the same style (yes, docs) - Be much more careful with maintaining comments correct - Move all postcopy fields to RAMState - Move QEMUFile to RAMState - rename

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

Am 23.03.2017 um 11:55 hat Markus Armbruster geschrieben: > We have two list-values options: > > * "server" is a list of InetSocketAddress. We use members "host" and > "port", and silently ignore the rest. > > * "auth-supported" is a list of RbdAuthMethod. We use its only member > "auth".

[Qemu-devel] [Bug 1675549] [NEW] tcg softmmu i386 crashes on BE hardware

Public bug reported: Hi, today i try to test qemu 2.9rc 1 with qemu-system-i386 if i set display as sdl and i push a key on keyboard qemu exit with an error translate-common.c:34:tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()) This issue was not present on qemu 2.8.0

Re: [Qemu-devel] [PATCH 0/3] script for crash-testing -device

On Thu, Mar 23, 2017 at 04:43:01PM +0100, Thomas Huth wrote: > On 22.03.2017 20:13, Eduardo Habkost wrote: > > On Wed, Mar 22, 2017 at 01:00:49PM -0300, Eduardo Habkost wrote: > >> This series adds scripts/device-crashtest.py, that can be used to > >> crash-test -device with multiple

Re: [Qemu-devel] qga-test failure on Linux/sparc

Quoting Peter Maydell (2017-03-23 10:13:13) > Hi; I find that qga-test fails on Linux/sparc host: > > test-qga.c:286:test_qga_get_fsinfo: assertion failed > ret: GenericError opendir("/sys/devices/virtual/block/md0/md0p1/slaves") > > On this box /sys/devices/virtual/block/md0/md0p1/ does indeed

Re: [Qemu-devel] [PATCH for-2.9] disas/microblaze: Remove unused REG_PC define

On Thu, Mar 23, 2017 at 12:42:41PM +, Peter Maydell wrote: > The REG_PC define in disas/microblaze.c clashes with a define in > the Linux SPARC system headers: > > /home/pm215/qemu/disas/microblaze.c:162:0: error: "REG_PC" redefined [-Werror] > #define REG_PC 32 /* PC */ > > In file

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

On 03/23/2017 01:27 PM, Markus Armbruster wrote: >>> - >>> -num_entries = qdict_array_entries(options, prefix); >>> +for (i = 0;; i++) { >>> +sprintf(keybuf, "auth-supported.%d.auth", i); >> >> By my count, and including a trailing NUL, this is 21 bytes + the >> maximum size of a

Re: [Qemu-devel] [PATCH 1/2] vmdk: Optimize I/O by allocating multiple clusters

On Fri, Mar 24, 2017 at 12:40 AM, Kevin Wolf wrote: > Am 11.03.2017 um 12:54 hat Ashijeet Acharya geschrieben: >> The vmdk driver in block/vmdk.c used to allocate cluster by cluster >> which slowed down its I/O performance. >> >> Make vmdk driver allocate multiple clusters at

Re: [Qemu-devel] [PATCH 1/2] vmdk: Optimize I/O by allocating multiple clusters

Am 11.03.2017 um 12:54 hat Ashijeet Acharya geschrieben: > The vmdk driver in block/vmdk.c used to allocate cluster by cluster > which slowed down its I/O performance. > > Make vmdk driver allocate multiple clusters at once to reduce the > overhead costs of multiple separate cluster allocation

[Qemu-devel] compile failure if I enable guest_mem_before trace event

Hi; I thought I'd have a look at the guest_mem_before trace event, but if I enable it (by deleting "disable" from the line in trace-events) QEMU doesn't compile: CC arm-softmmu/tcg/tcg-op.o In file included from /home/petmay01/linaro/qemu-from-laptop/qemu/include/trace-tcg.h:4:0,

Re: [Qemu-devel] [RFC PATCH v4 06/20] core: add new security-policy object

Hi Stefan, On 03/23/2017 06:35 AM, Stefan Hajnoczi wrote: On Wed, Mar 08, 2017 at 03:52:09PM -0500, Brijesh Singh wrote: The object can be used to define global security policy for the guest. "security-policy" is very vague. Lots of parts of QEMU have security related options (e.g. VNC

Re: [Qemu-devel] [PATCH] configure: Fix cut-n-paste errors in OS deprecation warning

On 23 March 2017 at 08:58, Stefan Hajnoczi wrote: > On Tue, Mar 21, 2017 at 06:08:49PM +, Peter Maydell wrote: >> Fix some cut-and-paste errors in the OS deprecation warning >> pointed out by Thomas Huth. >> >> Reported-by: Thomas Huth >> Signed-off-by:

Re: [Qemu-devel] [PATCH for-2.9] qom: Fix regression with 'qom-type'

On 23 March 2017 at 16:24, Markus Armbruster wrote: > Eric Blake writes: > >> Commit 9a6d1ac assumed that 'qom-type' could be removed from QemuOpts >> with no ill effects. However, this command line proves otherwise: >> >> $

Re: [Qemu-devel] [RFC PATCH v4 02/20] memattrs: add debug attribute

Hi Stefan, On 03/23/2017 06:29 AM, Stefan Hajnoczi wrote: On Wed, Mar 08, 2017 at 03:51:28PM -0500, Brijesh Singh wrote: Add a new debug attribute, the attribute should be set when guest memory accesses are performed for debug purposes. The attribute will be used in SEV guest, where we need

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

Eric Blake writes: > On 03/23/2017 05:55 AM, Markus Armbruster wrote: >> We have two list-values options: >> >> * "server" is a list of InetSocketAddress. We use members "host" and >> "port", and silently ignore the rest. >> >> * "auth-supported" is a list of

Re: [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen

On Thu, 23 Mar 2017, Paolo Bonzini wrote: > On 23/03/2017 14:55, Juergen Gross wrote: > > On 23/03/17 14:00, Greg Kurz wrote: > >> On Mon, 20 Mar 2017 11:19:05 -0700 > >> Stefano Stabellini wrote: > >> > >>> Do not use the ring.h header installed on the system. Instead,

  1   2   3   >