Re: [Qemu-devel] [PATCH] tests: Ignore another built executable

2017-04-27 Thread Thomas Huth
On 28.04.2017 04:23, Eric Blake wrote: > Commit 78f86a2b7 added a new test, but forgot to exclude the built > binary from version control. > > Signed-off-by: Eric Blake > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore

[Qemu-devel] [PATCH] tests: Ignore another built executable

2017-04-27 Thread Eric Blake
Commit 78f86a2b7 added a new test, but forgot to exclude the built binary from version control. Signed-off-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 5ab00a9..40c2e3e 100644 ---

[Qemu-devel] [PATCH v5 4/4] RFC: shutdown: Expose full ShutdownCause across QMP

2017-04-27 Thread Eric Blake
Since all reset/shutdown requests have been associated with a reason, we can expose the full reason rather than a simple bool to the guest. Document that any future additions to the enum type will still use a 'host-' or 'guest-' prefix. Signed-off-by: Eric Blake --- v4:

[Qemu-devel] [PATCH v5 3/4] shutdown: Add source information to SHUTDOWN and RESET

2017-04-27 Thread Eric Blake
Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() is already able to tell whether a shutdown was triggered by a host signal (but NOT by a host UI event, such

[Qemu-devel] [PATCH v5 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03185.html v3 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05515.html v4 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05539.html Since then: - fix braindead mistake of mine for using

[Qemu-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-27 Thread Eric Blake
We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

[Qemu-devel] [PATCH v5 1/4] shutdown: Simplify shutdown_signal

2017-04-27 Thread Eric Blake
There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

[Qemu-devel] 答复: Re: New function: Remot USB support in qemu

2017-04-27 Thread yuan.zhong
On Do, 2017-04-27 at 14:30 +0800, yuan.zh...@zte.com.cn wrote:> > Mr. Hoffmann,>> > > > Thank you for your time.> > > > > > This email will describe a new module that I'd like to commit to the> > qemu code source.> > > > We call it as remote usb, and this is features:> > > > 1. real usb device

Re: [Qemu-devel] [PATCH v2 3/3] tests: Add a tester for HMP commands

2017-04-27 Thread Eric Blake
On 03/30/2017 02:50 AM, Thomas Huth wrote: > HMP commands do not get any automatic testing yet, so on certain > QEMU machines, some HMP commands were causing crashes in the past. > Thus we should test HMP commands in our test suite, too, to avoid > that such problems creep in again in the future.

Re: [Qemu-devel] [PATCH 0/2] Fix compilation dependency issues of CONFIG_ARM_V7M

2017-04-27 Thread Wei Huang
On 04/27/2017 04:13 PM, Peter Maydell wrote: > On 27 April 2017 at 18:38, Wei Huang wrote: >> CONFIG_ARM_V7M is used to control the compilation of NVIC and SysTick >> Timer in QEMU. These two devices are not available when CONFIG_ARM_V7M >> is un-defined. This can cause

Re: [Qemu-devel] [PATCH v5 09/19] target/arm: optimize indirect branches

2017-04-27 Thread Emilio G. Cota
On Thu, Apr 27, 2017 at 13:59:56 +0200, Richard Henderson wrote: (snip) > Signed-off-by: Emilio G. Cota > Message-Id: <1493263764-18657-8-git-send-email-c...@braap.org> > [rth: Replace gen_jr global variable with DISAS_EXIT state.] > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v4 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread Eric Blake
On 04/27/2017 04:31 PM, Eric Blake wrote: > v2 was here: > https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03185.html > v3 was here: > https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05515.html > > Since then: > - s/ShutdownType/ShutdownCause/ to avoid conflict with mingw header

[Qemu-devel] [PATCH v3] qmp-shell: add persistent command history

2017-04-27 Thread John Snow
Use the existing readline history function we are utilizing to provide persistent command history across instances of qmp-shell. This assists entering debug commands across sessions that may be interrupted by QEMU sessions terminating, where the qmp-shell has to be relaunched. Signed-off-by:

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Bruce Rogers wrote: > >>> On 4/27/2017 at 03:09 PM, Stefano Stabellini > >>> wrote: > > On Thu, 27 Apr 2017, Bruce Rogers wrote: > >> Commit f0c9d64a exposed the issue that with a xenfv machine using > >> pci passthrough, acpi cpi hotplug code was

Re: [Qemu-devel] [PATCH v5 17/19] tcg/aarch64: Implement goto_ptr

2017-04-27 Thread Emilio G. Cota
On Thu, Apr 27, 2017 at 14:00:04 +0200, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 2 +- > tcg/aarch64/tcg-target.inc.c | 22 -- > 2 files changed, 21 insertions(+), 3 deletions(-) Tested-by: Emilio

[Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

2017-04-27 Thread Eric Blake
We now have macros in place to make it less verbose to add a scalar to QDict and QList, so use them. To make this patch smaller to review, a couple of subdirectories were done in earlier patches. Patch created mechanically via: spatch --sp-file scripts/coccinelle/qobject.cocci \

[Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-04-27 Thread Eric Blake
Commit 62c39b3 introduced test-qga, and at face value, appears to be testing the 'guest-sync' behavior that is recommended for guests in sending 0xff to QGA to force the parser to reset. But this aspect of the test has never actually done anything: the qmp_fd() call chain converts its string

[Qemu-devel] [PATCH v5 07/10] block: Simplify bdrv_append_temp_snapshot() logic

2017-04-27 Thread Eric Blake
Noticed while checking Coccinelle results. Naming a label 'out:' when it is only used on error paths is weird. Also, we had some dead stores to 'ret'. Meanwhile we know that snapshot_options is NULL on success and that QDECREF(NULL) is safe. So merge the two exit paths into one by careful

[Qemu-devel] [PATCH v5 09/10] fdc-test: Avoid deprecated 'change' command

2017-04-27 Thread Eric Blake
Use the preferred blockdev-change-medium command instead. Also, use of 'device' is deprecated; adding an explicit id on the command line lets us use 'id' for both blockdev-change-medium and eject. Signed-off-by: Eric Blake Reviewed-by: John Snow

[Qemu-devel] [PATCH v5 04/10] qobject: Drop useless QObject casts

2017-04-27 Thread Eric Blake
We have macros in place to make it less verbose to add a subtype of QObject to both QDict and QList. While we have made cleanups like this in the past (see commit fcfcd8ffc, for example), having it be automated by Coccinelle makes it easier to maintain. Patch created mechanically via: spatch

[Qemu-devel] [PATCH v5 05/10] qobject: Add helper macros for common scalar insertions

2017-04-27 Thread Eric Blake
Rather than making lots of callers wrap a scalar in a QInt, QString, or QBool, provide helper macros that do the wrapping automatically. Update the Coccinelle script to make mass conversions easy, although the conversion itself will be done as a separate patches to ease review and backport

[Qemu-devel] [PATCH v5 03/10] coccinelle: Add script to remove useless QObject casts

2017-04-27 Thread Eric Blake
We have macros in place to make it less verbose to add a subtype of QObject to both QDict and QList. While we have made cleanups like this in the past (see commit fcfcd8ffc, for example), having it be automated by Coccinelle makes it easier to maintain. The script is separate from the cleanups,

[Qemu-devel] [PATCH v5 02/10] pci: Reduce scope of error injection

2017-04-27 Thread Eric Blake
No one outside of pcie_aer.h was using error injection; mark them static for internal use. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PATCH v5 08/10] QemuOpts: Simplify qemu_opts_to_qdict()

2017-04-27 Thread Eric Blake
Noticed while investigating Coccinelle cleanups. There is no need for a temporary variable when we can use the new macro to do the same thing with less typing. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH v5 00/10] qapi-related cleanups

2017-04-27 Thread Eric Blake
This is a subset of my earlier post "Rip out dynamic JSON parsing"[1], and then a rebase of that work onto master. It is available here: git fetch git://repo.or.cz/qemu/ericb.git qapi-dynamic-json-v5 the tag name is a bit of a misnomer for the current series, but is historically accurate.

[Qemu-devel] [PATCH v5 01/10] pci: Use struct instead of QDict to pass back parameters

2017-04-27 Thread Eric Blake
It's simpler to just use a C struct than it is to bundle things into a QDict in one function just to pull them back out in the caller. Plus, doing this gets rid of one more user of dynamic JSON through qobject_from_jsonf(), as well as a memory leak of the QDict. While cleaning the code, fix

Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later.

2017-04-27 Thread Samuel Thibault
Hello, Thomas Huth, on lun. 24 avril 2017 11:15:56 +0200, wrote: > On 20.04.2017 22:43, Tao Wu wrote: > > The current code looks buggy, we zero ti_i while we access > > ti_dst/ti_src later. Indeed. > > Signed-off-by: Tao Wu > > *mtod(m, struct tcpiphdr *) = *ti;

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 03:09 PM, Stefano Stabellini >>> wrote: > On Thu, 27 Apr 2017, Bruce Rogers wrote: >> Commit f0c9d64a exposed the issue that with a xenfv machine using >> pci passthrough, acpi cpi hotplug code was being executed by mistake. >> Guard calls to

[Qemu-devel] [PATCH v4 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-27 Thread Eric Blake
We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

[Qemu-devel] [PATCH v4 4/4] RFC: shutdown: Expose full ShutdownCause across QMP

2017-04-27 Thread Eric Blake
Since all reset/shutdown requests have been associated with a reason, we can expose the full reason rather than a simple bool to the guest. Document that any future additions to the enum type will still use a 'host-' or 'guest-' prefix. Signed-off-by: Eric Blake --- v4:

[Qemu-devel] [PATCH v4 1/4] shutdown: Simplify shutdown_signal

2017-04-27 Thread Eric Blake
There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

[Qemu-devel] [PATCH v4 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03185.html v3 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg05515.html Since then: - s/ShutdownType/ShutdownCause/ to avoid conflict with mingw header pollution - fix long line Eric Blake (4): shutdown:

Re: [Qemu-devel] [PATCH 0/2] iotests: trivial fixups

2017-04-27 Thread Eric Blake
On 04/27/2017 03:50 PM, John Snow wrote: > Excised from an old patchset from 2015, just a couple of touchups. > > John Snow (2): > iotests: clarify help text > iotests: fix exclusion option Reviewed-by: Eric Blake [eww - we were really using 'ls' instead of 'echo' to

Re: [Qemu-devel] [PATCH v2] scripts: Switch to more portable Perl shebang

2017-04-27 Thread Philippe Mathieu-Daudé
On 04/26/2017 10:16 AM, Kamil Rytarowski wrote: The default NetBSD package manager is pkgsrc and it installs Perl along other third party programs under custom and configurable prefix. The default prefix for binary prebuilt packages is /usr/pkg, and the Perl executable lands in

Re: [Qemu-devel] [PATCH 1/2] target/openrisc: Implement EVBAR register

2017-04-27 Thread Stafford Horne
On Thu, Apr 27, 2017 at 10:55:28AM +1000, Tim Ansell wrote: > I'm about to add support for disabling the inbuilt or1k timer peripheral > (as our SoC does not have it enabled). That isn't really a CPU feature so I > think it still makes sense to have some type of feature field? Maybe CPU > features

Re: [Qemu-devel] [PATCH 0/2] Fix compilation dependency issues of CONFIG_ARM_V7M

2017-04-27 Thread Peter Maydell
On 27 April 2017 at 18:38, Wei Huang wrote: > CONFIG_ARM_V7M is used to control the compilation of NVIC and SysTick > Timer in QEMU. These two devices are not available when CONFIG_ARM_V7M > is un-defined. This can cause problems with ARMv7M code as it is tightly > integrated

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Bruce Rogers wrote: > Commit f0c9d64a exposed the issue that with a xenfv machine using > pci passthrough, acpi cpi hotplug code was being executed by mistake. > Guard calls to acpi_pcihp_device_plug_cb (and corresponding > acpi_pcihp_device_unplug_cb) with a check for

Re: [Qemu-devel] [PATCH v2 0/7] Refactor DMG driver to have chunk size independence

2017-04-27 Thread Ashijeet Acharya
On Thu, Apr 27, 2017 at 1:36 PM, Ashijeet Acharya wrote: > Previously posted series patches: > v1: http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg04641.html > > This series helps to provide chunk size independence for DMG driver to prevent >

[Qemu-devel] [PATCH 2/2] iotests: fix exclusion option

2017-04-27 Thread John Snow
If you are running out-of-tree, the -x option to exclude a certain iotest is broken. Replace porcelain usage of ls with a sturdier awk command. Reviewed-by: Fam Zheng Signed-off-by: John Snow --- tests/qemu-iotests/common | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH 0/2] iotests: trivial fixups

2017-04-27 Thread John Snow
Excised from an old patchset from 2015, just a couple of touchups. John Snow (2): iotests: clarify help text iotests: fix exclusion option tests/qemu-iotests/common | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.9.3

[Qemu-devel] [PATCH 1/2] iotests: clarify help text

2017-04-27 Thread John Snow
Split the help text to highlight the groups of options a little better, carving out a clear "format" and "protocols" section. Signed-off-by: John Snow --- tests/qemu-iotests/common | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 1/2] numa: introduce numa_auto_assign_ram() function in MachineClass

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 12:12:58PM +0200, Laurent Vivier wrote: > We need to change the way we distribute the memory across > the nodes. To keep compatibility between machine type version > introduce a machine type dependent function. > > Signed-off-by: Laurent Vivier > ---

Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 04:46:26PM +0200, Igor Mammedov wrote: > On Thu, 27 Apr 2017 16:05:42 +0200 > Markus Armbruster wrote: > > Igor Mammedov writes: > > > On Thu, 27 Apr 2017 07:54:31 -0500 > > > Eric Blake wrote: [...] > > >> > >

Re: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread Eric Blake
On 04/27/2017 02:49 PM, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > CC util/buffer.o > In file included from >

[Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Bruce Rogers
Commit f0c9d64a exposed the issue that with a xenfv machine using pci passthrough, acpi cpi hotplug code was being executed by mistake. Guard calls to acpi_pcihp_device_plug_cb (and corresponding acpi_pcihp_device_unplug_cb) with a check for xen_enabled(). Without this check I am seeing an error

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 12:08 PM, Stefano Stabellini >>> wrote: > On Thu, 27 Apr 2017, Igor Mammedov wrote: >> On Thu, 27 Apr 2017 10:51:23 -0600 >> "Bruce Rogers" wrote: >> >> > >> > >> > >>> On 4/27/2017 at 10:08 AM, Igor Mammedov

Re: [Qemu-devel] [PATCHv3 4/4] ppc: Rework CPU compatibility testing across migration

2017-04-27 Thread Michael Roth
Quoting David Gibson (2017-04-27 02:28:43) > Migrating between different CPU versions is a bit complicated for ppc. > A long time ago, we ensured identical CPU versions at either end by > checking the PVR had the same value. However, this breaks under KVM > HV, because we always have to use the

Re: [Qemu-devel] [PATCHv3 3/4] pseries: Reset CPU compatibility mode

2017-04-27 Thread Michael Roth
Quoting David Gibson (2017-04-27 02:28:42) > Currently, the CPU compatibility mode is set when the cpu is initialized, > then again when the guest negotiates features. This means if a guest > negotiates a compatibility mode, then reboots, that compatibility mode > will be retained across the

Re: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN Message-id: 20170427192211.30640-1-ebl...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN Message-id:

[Qemu-devel] [PATCH v3 4/4] RFC: shutdown: Expose full ShutdownType across QMP

2017-04-27 Thread Eric Blake
Since all reset/shutdown requests have been associated with a reason, we can expose the full reason rather than a simple bool to the guest. Document that any future additions to the enum type will still use a 'host-' or 'guest-' prefix. Signed-off-by: Eric Blake --- v3: new

[Qemu-devel] [PATCH v3 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-27 Thread Eric Blake
We want to track why a guest was shutdown; in particular, being able to tell the difference between a guest request (such as ACPI request) and host request (such as SIGINT) will prove useful to libvirt. Since all requests eventually end up changing shutdown_requested in vl.c, the logical change is

[Qemu-devel] [PATCH v3 3/4] shutdown: Add source information to SHUTDOWN and RESET

2017-04-27 Thread Eric Blake
Libvirt would like to be able to distinguish between a SHUTDOWN event triggered solely by guest request and one triggered by a SIGTERM or other action on the host. While qemu_kill_report() is already able to tell whether a shutdown was triggered by a host signal (but NOT by a host UI event, such

[Qemu-devel] [PATCH v3 0/4] event: Add source information to SHUTDOWN

2017-04-27 Thread Eric Blake
v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03185.html Since then: - turn it from one patch into a series - update iotests to pass (the combination of -qcow2, -file, and -nbd is sufficient to cover all the changed tests) - add cleanup patch to shutdown_signal initial

[Qemu-devel] [PATCH v3 1/4] shutdown: Simplify shutdown_signal

2017-04-27 Thread Eric Blake
There is no signal 0 (kill(pid, 0) has special semantics to probe whether a process is alive), rather than actually sending a signal 0). So we can use the simpler 0, instead of -1, for our sentinel of whether a shutdown request due to a signal has happened. Suggested-by: Markus Armbruster

Re: [Qemu-devel] [Qemu-stable] [PATCH v3 1/1] qemu-img: wait for convert coroutines to complete

2017-04-27 Thread Peter Lieven
> Am 26.04.2017 um 10:33 schrieb Anton Nefedov : > > On error path (like i/o error in one of the coroutines), it's required to > - wait for coroutines completion before cleaning the common structures > - reenter dependent coroutines so they ever finish > >

Re: [Qemu-devel] [Qemu-devel RFC v2 1/4] msf2: Add Smartfusion2 System timer

2017-04-27 Thread Alistair Francis
On Tue, Apr 25, 2017 at 3:36 AM, sundeep subbaraya wrote: > Hi Alistair, > > On Mon, Apr 24, 2017 at 11:14 PM, Alistair Francis > wrote: > + > +isr = !!(st->regs[R_RIS] & TIMER_RIS_ACK); > +ier = !!(st->regs[R_CTRL] &

Re: [Qemu-devel] [PATCH v2 4/4] 9pfs: handle broken transport

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > The 9p protocol is transport agnostic: if an error occurs when copying data > to/from the client, this should be handled by the transport layer [1] and > the 9p server should simply stop processing requests [2]. > > [1] can be implemented in the transport

Re: [Qemu-devel] [PATCH v2 2/4] 9pfs: drop pdu_push_and_notify()

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > Only pdu_complete() needs to notify the client that a request has completed. > > Signed-off-by: Greg Kurz > --- > hw/9pfs/9p.c |7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c >

Re: [Qemu-devel] [PATCH for-2.9 00/47] qapi: Put type information back into QMP documentation

2017-04-27 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > I'm proposing this is 2.9 because it fixes a documentation regression. > It affects only documentation; generated C code is unchanged except > for the removal of trailing space in PATCH 46. > > Additionally, my series fixes a number of bugs and

Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > The code only uses well known format strings. An unknown format token is a > bug. > > Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini > --- > fsdev/9p-iov-marshal.c |4 ++-- > 1 file changed, 2

Re: [Qemu-devel] [PATCH] virtio-9p/xen-9p: move 9p specific bits to core 9p code

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Greg Kurz wrote: > These bits aren't related to the transport so let's move them to the core > code. > > Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini > --- > hw/9pfs/9p.c |8 +++- > hw/9pfs/9p.h

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Stefano Stabellini
On Thu, 27 Apr 2017, Igor Mammedov wrote: > On Thu, 27 Apr 2017 10:51:23 -0600 > "Bruce Rogers" wrote: > > > > > > > >>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > > > On Thu, 27 Apr 2017 09:44:31 -0600 > > > "Bruce Rogers"

[Qemu-devel] [PATCH 0/2] Fix compilation dependency issues of CONFIG_ARM_V7M

2017-04-27 Thread Wei Huang
CONFIG_ARM_V7M is used to control the compilation of NVIC and SysTick Timer in QEMU. These two devices are not available when CONFIG_ARM_V7M is un-defined. This can cause problems with ARMv7M code as it is tightly integrated with NVIC for processing IRQ and exception. This patchset addresses the

[Qemu-devel] [PATCH 1/2] armv7m: Make armv7m SoC compilation dependent on CONFIG_ARM_V7M

2017-04-27 Thread Wei Huang
In current QEMU, when CONFIG_ARM_V7M is not configured, armv7m_nvic.c and armv7m_systick.c won't be compiled. This causes dependency issues for armv7m SoC because armv7m uses the device "armv7m_nvic". This patch makes the compilation of armv7m.c and other v7m SoC dependent on CONFIG_ARM_V7M.

[Qemu-devel] [PATCH 2/2] armv7m: Use stub functions if CONFIG_ARM_V7M is not defined

2017-04-27 Thread Wei Huang
M-profile CPUs relies on NVIC controller which won't be compiled if CONFIG_ARM_V7M is not defined. To solve the problem, this patch defines four NVIC stub functions. These functions are called when CONFIG_ARM_V7M is not defined. Signed-off-by: Wei Huang ---

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 10:51:23 -0600 "Bruce Rogers" wrote: > > > >>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > > On Thu, 27 Apr 2017 09:44:31 -0600 > > "Bruce Rogers" wrote: > > > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammedov

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 07:25:23PM +0200, Igor Mammedov wrote: [...] > > > # > > > # A discriminated record of NUMA options. (for OptsVisitor) > > > # > > > +# For 'cpu' type as arguments use a set of cpu properties returned > > > +# by query-hotpluggable-cpus[].props, where node-id could be

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 13:32:25 -0300 Eduardo Habkost wrote: > On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > > On Wed, 26 Apr 2017 09:21:38 -0300 > > Eduardo Habkost wrote: > > > > adding Peter to CC list > > > > [...] > > > > > On

Re: [Qemu-devel] [PATCHv3 2/4] pseries: Move CPU compatibility property to machine

2017-04-27 Thread Michael Roth
Quoting David Gibson (2017-04-27 02:28:41) > Server class POWER CPUs have a "compat" property, which is used to set the > backwards compatibility mode for the processor. However, this only makes > sense for machine types which don't give the guest access to hypervisor > privilege - otherwise the

[Qemu-devel] [PATCH] checkpatch: Disallow glib asserts in main code

2017-04-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Glib commit a6a875068779 (from 2013) made many of the glib assert macros non-fatal if a flag is set. This causes two problems: a) Compilers moan that your code is unsafe even though you've put an assert in before the point of use. b)

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > On Thu, 27 Apr 2017 09:44:31 -0600 > "Bruce Rogers" wrote: > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: >> > On Wed, 26 Apr 2017 13:07:02 -0600 >> > Bruce Rogers

Re: [Qemu-devel] [PATCH v17 00/24] qcow2: persistent dirty bitmaps

2017-04-27 Thread John Snow
On 04/26/2017 07:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a new update of qcow2-bitmap series - v17. > > web: > https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v17 > git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v17)

Re: [Qemu-devel] [PATCH for-2.10 07/23] pc: add node-id property to CPU

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 03:14:06PM +0200, Igor Mammedov wrote: > On Wed, 26 Apr 2017 09:21:38 -0300 > Eduardo Habkost wrote: > > adding Peter to CC list > > [...] > > > On Wed, Apr 19, 2017 at 01:14:58PM +0200, Igor Mammedov wrote: > > > On Wed, 12 Apr 2017 18:02:39 -0300

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 06:24:17PM +0200, Markus Armbruster wrote: > No review, just an observation. > > Mao Zhongyi writes: > > > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > > net_socket_fd_init() use the function such as fprintf(),

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > On Thu, 27 Apr 2017 09:44:31 -0600 > "Bruce Rogers" wrote: > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: >> > On Wed, 26 Apr 2017 13:07:02 -0600 >> > Bruce Rogers

Re: [Qemu-devel] [PATCH v2 0/4] Convert non-blocking connect and fix its error reporting

2017-04-27 Thread Markus Armbruster
Mao Zhongyi writes: > v2: > * PATCH 02 reworking of patch 2 following Markus's suggestion that convert > error_report() > in the function called by net_socket_*_init() to Error. Also add many error > handling > information. > * PATCH 03 net_socket_mcast_create(),

Re: [Qemu-devel] [PATCH v2 3/4] net/socket: Convert error report message to Error

2017-04-27 Thread Markus Armbruster
No review, just an observation. Mao Zhongyi writes: > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > net_socket_fd_init() use the function such as fprintf(), perror() to > report an error message. > > Now, convert these functions to Error. > >

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 06:19:50PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Mao Zhongyi writes: > > > >> Currently, socket connection in net is realized by an old > >> mechanism which is non-blocking. > >> > >> That old

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

2017-04-27 Thread Daniel P. Berrange
On Wed, Apr 26, 2017 at 04:04:15PM +0800, Mao Zhongyi wrote: > Currently, socket connection in net is realized by an old > mechanism which is non-blocking. > > That old mechanism may cause net blocks on DNS lookups and > QEmu has already replaced it with QIOchannel in many features, > such as

Re: [Qemu-devel] [PATCH v2] trace: add qemu mutex lock and unlock trace events

2017-04-27 Thread joserz
On Thu, Apr 27, 2017 at 11:59:26AM -0300, jos...@linux.vnet.ibm.com wrote: > On Thu, Apr 27, 2017 at 10:55:04AM +0200, Paolo Bonzini wrote: > > > > > > On 24/04/2017 19:19, Jose Ricardo Ziviani wrote: > > > These trace events were very useful to help me to understand and find a > > > reordering

[Qemu-devel] [Bug 1592351] Re: mouse pointer offset with gtk, gl=on

2017-04-27 Thread undefined
mouse works better with debug & fix patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1592351 Title: mouse pointer offset with gtk,gl=on Status in QEMU: Confirmed Bug description: When I

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

2017-04-27 Thread Markus Armbruster
Markus Armbruster writes: > Mao Zhongyi writes: > >> Currently, socket connection in net is realized by an old >> mechanism which is non-blocking. >> >> That old mechanism may cause net blocks on DNS lookups and >> QEmu has already replaced it with

Re: [Qemu-devel] [PATCH v2 2/4] net/socket: Improve -net socket error reporting

2017-04-27 Thread Markus Armbruster
Mao Zhongyi writes: > When -net socket fails, it first reports a specific error, then > a generic one, like this: > > $ qemu-system-x86_64 -net socket, > qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, > mcast= or udp= is required >

Re: [Qemu-devel] [PATCH v5 04/19] exec-all: export tb_htable_lookup

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Signed-off-by: Emilio G. Cota > Message-Id: <1493263764-18657-2-git-send-email-c...@braap.org> > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH v2 1/2] numa: introduce numa_auto_assign_ram() function in MachineClass

2017-04-27 Thread Eduardo Habkost
On Thu, Apr 27, 2017 at 05:09:26PM +0200, Laurent Vivier wrote: > On 27/04/2017 16:09, Eduardo Habkost wrote: > > On Thu, Apr 27, 2017 at 12:12:58PM +0200, Laurent Vivier wrote: > >> We need to change the way we distribute the memory across > >> the nodes. To keep compatibility between machine

Re: [Qemu-devel] [PATCH v5 03/19] qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > We need to coordinate with the TCG_OVERSIZED_GUEST test in cputlb.c, > and allow 64-bit atomics even though sizeof(void *) == 4. Hmm you say this here but we never actually do it. But the other changes seem fine. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Igor Mammedov
On Thu, 27 Apr 2017 09:44:31 -0600 "Bruce Rogers" wrote: > >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: > > On Wed, 26 Apr 2017 13:07:02 -0600 > > Bruce Rogers wrote: > > > >> Commit f0c9d64a exposed an issue with the code order

[Qemu-devel] [Bug 1592351] Re: mouse pointer offset with gtk, gl=on

2017-04-27 Thread undefined
Mouse still doesn't work properly with 2.9.0 and Ubuntu 17.04 guest -smp 2 -enable-kvm -vga virtio -display gtk,gl=on -m 2048 -cdrom ubuntu-17.04-desktop-amd64.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v5 02/19] tcg/sparc: Use the proper compilation flags for 32-bit

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > We have required a v9 cpu since 9b9c37c36439ee0452632253dac7a31897f27f70. > However, the flags we were using did not reliably enable v8plus, which > meant that the compiler didn't know it could inline 64-bit atomics. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v5 01/19] target/nios2: Fix 64-bit ilp32 compilation

2017-04-27 Thread Alex Bennée
Richard Henderson writes: > Avoid a "cast from pointer to integer of different size" warning > by using the proper host type. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/nios2/translate.c | 2 +- >

[Qemu-devel] [Bug 1064631] Re: Feature request: tls for chardev socket (telnet, tcp, udp)

2017-04-27 Thread Daniel Berrange
This support was introduced in QEMU 2.6 last year. Some info here: https://www.berrange.com/posts/2016/08/16/improving-qemu-security-part-6 -tls-support-for-character-devices/ ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH v2 1/4] net/socket: Convert the non-blocking connection mechanism to QIOchannel

2017-04-27 Thread Markus Armbruster
Mao Zhongyi writes: > Currently, socket connection in net is realized by an old > mechanism which is non-blocking. > > That old mechanism may cause net blocks on DNS lookups and > QEmu has already replaced it with QIOchannel in many features, > such as migration. > >

[Qemu-devel] [Bug 1090604] Re: RFE: Implement support for SMBIOS Type 41 structures

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090604 Title: RFE: Implement support for SMBIOS Type 41 structures Status in QEMU: New

[Qemu-devel] [Bug 1090615] Re: RFE: More info in qemu-img info/check

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090615 Title: RFE: More info in qemu-img info/check Status in QEMU: New Bug

[Qemu-devel] [Bug 1090602] Re: RFE: Allow specifying usb-host device by serial number

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090602 Title: RFE: Allow specifying usb-host device by serial number Status in QEMU: New

[Qemu-devel] [Bug 1184089] Re: [Feature request] loadvm snapshot as read-only

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1184089 Title: [Feature request] loadvm snapshot as read-only Status in QEMU: New Bug

[Qemu-devel] [Bug 1284090] Re: RFE: QMP: report error reason in BLOCK_IO_ERROR message

2017-04-27 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1284090 Title: RFE: QMP: report error reason in BLOCK_IO_ERROR message Status in QEMU: New

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: > On Wed, 26 Apr 2017 13:07:02 -0600 > Bruce Rogers wrote: > >> Commit f0c9d64a exposed an issue with the code order in acpi_setup. >> As of that commit, a xenfv machine type guest will no longer start >>

[Qemu-devel] [Bug 1081416] Re: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots

2017-04-27 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1081416 Title: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots Status in QEMU:

  1   2   3   >