[Qemu-devel] 答复: Re: 答复: Re: [PATCH] vhost: fix a migration failedbecause ofvhost region merge

> > On Wed, Jul 19, 2017 at 03:24:27PM +0200, Igor Mammedov wrote: > > > On Wed, 19 Jul 2017 12:46:13 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > > On Wed, 19 Jul 2017 23:17:32 +0800 > > > > > Peng Hao

Re: [Qemu-devel] [PATCH 1/2] [PATCH] hmp: dump ids includingsocket-id, core-id and so on for 'info registers'

>On Fri, 22 Jul 2017 03:38:55 -0400 >Yi Wang wrote: > >> This patch add output of CPUs' socket-id, core-id, thread-id and >> apic-id for 'info registers', which can be used for querying other >> hmp commands. >> >> Signed-off-by: Yi Wang >>

Re: [Qemu-devel] [PATCH v6 8/8] tpm: Added support for TPM emulator

On Tue, 2017-07-18 at 05:08 -0700, Marc-André Lureau wrote: > Hi > > On Tue, Jul 18, 2017 at 1:49 AM, Amarnath Valluri > wrote: > > This change introduces a new TPM backend driver that can communicate with > > swtpm(software TPM emulator) using unix domain socket

Re: [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration

Hi Peter, On 07/07/2017 11:42 AM, Peter Maydell wrote: This patchset changes the memory region functions - memory_region_init_ram() - memory_region_init_rom() - memory_region_init_rom_device() to all automatically register the backing memory they allocate for migration using

[Qemu-devel] [Bug 1300021] Re: after loadvm the system clock isn't current time

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1300021 Title: after

Re: [Qemu-devel] [PATCH v6 4/8] tpm-backend: Made few interface methods optional

On Tue, 2017-07-18 at 10:15 +, Marc-André Lureau wrote: > Hi > > On Tue, Jul 18, 2017 at 10:48 AM Amarnath Valluri > wrote: > > This allows backend implementations left optional interface > methods. > For mandatory methods assertion checks

Re: [Qemu-devel] [PATCH v6 5/8] tmp backend: Add new api to read backend TpmInfo

On Tue, 2017-07-18 at 09:28 -0500, Eric Blake wrote: > On 07/18/2017 05:39 AM, Marc-André Lureau wrote: > > Hi > > > > On Tue, Jul 18, 2017 at 1:49 AM, Amarnath Valluri > > wrote: > >> TPM configuration options are backend implementation details and shall not > >> be

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

I tried disabling the CmpLegacy bit directly on /target/i386/cpu.c deleting the If statement on "case 0x8001:" or changing "*ecx |= 1 << 1;" to "*ecx |= 0 << 1;" But it didn't work, the VM still sees 8 physical cores. I believe the HTT bit should be enabled by default I tried changing it to

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

> On Jul 21, 2017, at 7:40 PM, Michael S. Tsirkin wrote: > > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote: >> On Fri, 21 Jul 2017 10:49:55 +0100 >> "Daniel P. Berrange" wrote: >> >>> On Fri, Jul 21, 2017 at 11:32:11AM +0200, Igor Mammedov

Re: [Qemu-devel] [PATCH 08/11] qmp.py: Avoid "has_key" usage

On 07/20/2017 01:28 PM, Lukáš Doktor wrote: The "has_key" is deprecated in favor of "__in__" operator. Signed-off-by: Lukáš Doktor Reviewed-by: Philippe Mathieu-Daudé --- scripts/qmp/qmp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

Hi Lukáš, Since comment/indent fixes and code changes are not related I'd rather see this split in at least 2 patches. On 07/20/2017 01:28 PM, Lukáš Doktor wrote: No actual code changes, just a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor

Re: [Qemu-devel] [PATCH 03/11] qemu.py: Use iteritems rather than keys()

On 07/20/2017 01:28 PM, Lukáš Doktor wrote: Let's avoid creating an in-memory list of keys and query for each value and use `iteritems` which is an iterator of key-value pairs. Signed-off-by: Lukáš Doktor Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments

On 07/20/2017 01:28 PM, Lukáš Doktor wrote: The list object is mutable in python and potentially might modify other object's arguments when used as default argument. Reproducer: >>> vm1 = QEMUMachine("qemu") >>> vm2 = QEMUMachine("qemu") >>> vm1._wrapper.append("foo") >>>

[Qemu-devel] [PULL for-2.10 2/2] xen-mapcache: Fix the bug when overlapping emulated DMA operations may cause inconsistency in guest memory mappings

From: Alexey G Under certain circumstances normal xen-mapcache functioning may be broken by guest's actions. This may lead to either QEMU performing exit() due to a caught bad pointer (and with QEMU process gone the guest domain simply appears hung afterwards) or actual use of

[Qemu-devel] [PULL for-2.10 1/2] xen: fix compilation on 32-bit hosts

From: Igor Druzhinin Signed-off-by: Igor Druzhinin Reviewed-by: Stefano Stabellini --- hw/i386/xen/xen-mapcache.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL for-2.10 0/2] please pull xen-20170721-tag

The following changes since commit 91939262ffcd3c85ea6a4793d3029326eea1d649: configure: Drop ancient Solaris 9 and earlier support (2017-07-21 15:04:05 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20170721-tag for you

Re: [Qemu-devel] [PATCH v14 33/34] target/arm: Split out thumb_tr_translate_insn

On Fri, Jul 14, 2017 at 23:42:42 -1000, Richard Henderson wrote: > We need not check for ARM vs Thumb state in order to dispatch > disassembly of every instruction. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 134 >

Re: [Qemu-devel] [PATCH] vhost-user: fix watcher need be removed when vhost-user hotplug

On Fri, Jul 21, 2017 at 11:19:04AM +, Marc-André Lureau wrote: > Hi > > On Fri, Jul 21, 2017 at 7:18 AM w00273186 wrote: > > From: Yunjian Wang > > "nc" is freed after hotplug vhost-user, but the watcher don't be removed. > The

Re: [Qemu-devel] [PULL for-2.10 6/7] xen/mapcache: introduce xen_replace_cache_entry()

On Fri, 21 Jul 2017, Igor Druzhinin wrote: > On 21/07/17 14:50, Anthony PERARD wrote: > > On Tue, Jul 18, 2017 at 03:22:41PM -0700, Stefano Stabellini wrote: > > > From: Igor Druzhinin > > > > ... > > > > > +static uint8_t *xen_replace_cache_entry_unlocked(hwaddr

Re: [Qemu-devel] [PATCH v14 30/34] target/arm: [tcg] Port to generic translation framework

On Fri, Jul 21, 2017 at 19:02:58 -0400, Emilio G. Cota wrote: > On Fri, Jul 14, 2017 at 23:42:39 -1000, Richard Henderson wrote: > > From: Lluís Vilanova > > > > Signed-off-by: Lluís Vilanova > > Message-Id:

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

Hi Marcel On 21/07/2017 01:33, Marcel Apfelbaum wrote: On 20/07/2017 3:44, Kinsella, Ray wrote: That's strange. Please ensure the virtio devices are working in virtio 1.0 mode (disable-modern=0,disable-legacy=1). Let us know any problems you see. Not sure what yet, I will try scaling it with

Re: [Qemu-devel] 答复: Re: [PATCH] vhost: fix a migration failed because ofvhost region merge

On Thu, Jul 20, 2017 at 10:57:57AM +0800, peng.h...@zte.com.cn wrote: > 原始邮件 > 发件人： ; > 收件人： ; > 抄送人： ; ; > ;彭浩10096742;王业超10154425; > ; > 日期：2017年07月19日 23:53

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote: > On Fri, 21 Jul 2017 10:49:55 +0100 > "Daniel P. Berrange" wrote: > > > On Fri, Jul 21, 2017 at 11:32:11AM +0200, Igor Mammedov wrote: > > > w2k used to boot on QEMU until we bumped revision of FADT to rev3 > >

Re: [Qemu-devel] [PATCH v14 08/34] tcg: Add generic translation framework

On Fri, Jul 14, 2017 at 23:42:17 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Signed-off-by: Lluís Vilanova > Message-Id: <150002073981.22386.9870422422367410100.st...@frigg.lan> > [rth: Moved max_insns adjustment from tb_start to

Re: [Qemu-devel] [PATCH v14 34/34] target/arm: Perform per-insn cross-page check only for Thumb

On Fri, Jul 14, 2017 at 23:42:43 -1000, Richard Henderson wrote: > ARM is a fixed-length ISA and we can compute the page crossing > condition exactly once during init_disas_context. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota

Re: [Qemu-devel] [PATCH v14 33/34] target/arm: Split out thumb_tr_translate_insn

On Fri, Jul 14, 2017 at 23:42:42 -1000, Richard Henderson wrote: > We need not check for ARM vs Thumb state in order to dispatch > disassembly of every instruction. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 134 >

Re: [Qemu-devel] [PATCH v14 24/34] target/arm: [tcg] Port to translate_insn

On Fri, Jul 14, 2017 at 23:42:33 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Message-Id:

Re: [Qemu-devel] [PATCH v14 32/34] target/arm: Move ss check to init_disas_context

On Fri, Jul 14, 2017 at 23:42:41 -1000, Richard Henderson wrote: > We can check for single-step just once. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PATCH v14 31/34] target/arm: [a64] Move page and ss checks to init_disas_context

On Fri, Jul 14, 2017 at 23:42:40 -1000, Richard Henderson wrote: > Since AArch64 uses a fixed-width ISA, we can pre-compute the number of > insns remaining on the page. Also, we can check for single-step once. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota

Re: [Qemu-devel] [PATCH v14 30/34] target/arm: [tcg] Port to generic translation framework

On Fri, Jul 14, 2017 at 23:42:39 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Signed-off-by: Lluís Vilanova > Message-Id: <150002631325.22386.10348327185029496649.st...@frigg.lan> > Signed-off-by: Richard Henderson > ---

Re: [Qemu-devel] [PATCH v14 08/34] tcg: Add generic translation framework

Richard Henderson writes: > From: Lluís Vilanova > Signed-off-by: Lluís Vilanova > Message-Id: <150002073981.22386.9870422422367410100.st...@frigg.lan> > [rth: Moved max_insns adjustment from tb_start to init_disas_context. > Removed pc_next return from

Re: [Qemu-devel] [PATCH v14 29/34] target/arm: [tcg, a64] Port to disas_log

On Fri, Jul 14, 2017 at 23:42:38 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v14 27/34] target/arm: [tcg, a64] Port to tb_stop

On Fri, Jul 14, 2017 at 23:42:36 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v14 26/34] target/arm: [tcg] Port to tb_stop

On Fri, Jul 14, 2017 at 23:42:35 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Message-Id:

Re: [Qemu-devel] [PATCH v14 07/34] target/arm: Set is_jmp properly after single-stepping

Richard Henderson writes: > We have generated an exception, so use DISAS_NORETURN. Shouldn't this be folded into patch 4? Thanks, Lluis > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 1 + > target/arm/translate.c | 4 +++- > 2 files changed,

Re: [Qemu-devel] [PATCH v14 04/34] target/arm: Use DISAS_NORETURN

On Fri, Jul 14, 2017 at 23:42:13 -1000, Richard Henderson wrote: > Fold DISAS_EXC and DISAS_TB_JUMP into DISAS_NORETURN. > > In both cases all following code is dead. In the first > case because we have exited the TB via exception; in the > second case because we have exited the TB via goto_tb >

Re: [Qemu-devel] [PATCH v14 03/34] target/i386: Use generic DISAS_* enumerators

Richard Henderson writes: > This target is not sophisticated in its use of cleanups at the > end of the translation loop. For the most part, any condition > that exits the TB is dealt with by emitting the exiting opcode > right then and there. Therefore the only is_jmp indicator that > is

Re: [Qemu-devel] [PATCH v14 02/34] tcg: Add generic DISAS_NORETURN

Richard Henderson writes: > This will allow some amount of cleanup to happen before > switching the backends over to enum DisasJumpType. > Signed-off-by: Richard Henderson Reviewed-by: Lluís Vilanova > --- > include/exec/exec-all.h | 1 + > 1 file

Re: [Qemu-devel] [PATCH v14 25/34] target/arm: [tcg, a64] Port to translate_insn

On Fri, Jul 14, 2017 at 23:42:34 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Message-Id:

Re: [Qemu-devel] [PATCH v14 24/34] target/arm: [tcg] Port to translate_insn

On Fri, Jul 14, 2017 at 23:42:33 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Message-Id:

Re: [Qemu-devel] [PATCH v14 23/34] target/arm: [tcg, a64] Port to breakpoint_check

On Fri, Jul 14, 2017 at 23:42:32 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v14 10/34] target/i386: [tcg] Port to init_disas_context

On Fri, Jul 14, 2017 at 23:42:19 -1000, Richard Henderson wrote: > From: Lluís Vilanova > > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v4 42/43] tcg: introduce regions to split code_gen_buffer

On 07/20/2017 07:59 PM, Emilio G. Cota wrote: This is groundwork for supporting multiple TCG contexts. The naive solution here is to split code_gen_buffer statically among the TCG threads; this however results in poor utilization if translation needs are different across TCG threads. What we

Re: [Qemu-devel] [PATCH v14 07/34] target/arm: Set is_jmp properly after single-stepping

On Fri, Jul 14, 2017 at 23:42:16 -1000, Richard Henderson wrote: > We have generated an exception, so use DISAS_NORETURN. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 1 + > target/arm/translate.c | 4 +++- > 2 files changed, 4 insertions(+), 1

Re: [Qemu-devel] [PATCH v4 35/43] tcg: allocate optimizer temps with tcg_malloc

On 07/20/2017 07:59 PM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. While at it, also allocate temps_used directly as a bitmap of the required size, instead of using a bitmap of TCG_MAX_TEMPS via TCGTempSet. Performance-wise we lose about 1.12% in a translation-heavy

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

On Fri, Jul 21, 2017 at 04:41:58PM +0200, Igor Mammedov wrote: > On Wed, 19 Jul 2017 18:52:56 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 19, 2017 at 03:24:27PM +0200, Igor Mammedov wrote: > > > On Wed, 19 Jul 2017 12:46:13 +0100 > > > "Dr. David Alan Gilbert"

Re: [Qemu-devel] [PATCH v4 11/43] tcg: define CF_PARALLEL and use it for TB hashing along with CF_COUNT_MASK

On 07/20/2017 07:59 PM, Emilio G. Cota wrote: This will enable us to decouple code translation from the value of parallel_cpus at any given time. It will also help us minimize TB flushes when generating code via EXCP_ATOMIC. Note that the declaration of parallel_cpus is brought to exec-all.h to

Re: [Qemu-devel] [PATCH v14 04/34] target/arm: Use DISAS_NORETURN

On Fri, Jul 14, 2017 at 23:42:13 -1000, Richard Henderson wrote: > Fold DISAS_EXC and DISAS_TB_JUMP into DISAS_NORETURN. > > In both cases all following code is dead. In the first > case because we have exited the TB via exception; in the > second case because we have exited the TB via goto_tb >

Re: [Qemu-devel] [PATCH v14 06/34] target/arm: Delay check for magic kernel page

On Fri, Jul 14, 2017 at 23:42:15 -1000, Richard Henderson wrote: > There's nothing magic about the exception that we generate in order > to execute the magic kernel page. We can and should allow gdb to > set a breakpoint at this location. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v14 03/34] target/i386: Use generic DISAS_* enumerators

On Fri, Jul 14, 2017 at 23:42:12 -1000, Richard Henderson wrote: > This target is not sophisticated in its use of cleanups at the > end of the translation loop. For the most part, any condition > that exits the TB is dealt with by emitting the exiting opcode > right then and there. Therefore the

Re: [Qemu-devel] [PATCH v14 02/34] tcg: Add generic DISAS_NORETURN

On Fri, Jul 14, 2017 at 23:42:11 -1000, Richard Henderson wrote: > This will allow some amount of cleanup to happen before > switching the backends over to enum DisasJumpType. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PATCH 4/9] tests: Clean up string interpolation into QMP input (simple cases)

On 07/21/2017 03:08 PM, Eric Blake wrote: >> 2. Support PRId64 and PRIu64, whatever their actual value may be. >> >>a. Support all possible values. This is what we've tried before. >> >>b. Support exactly the host's PRId64 and PRIu64 values. >> Preferences? >> >> I like 2b, but I'm not

[Qemu-devel] [PATCH] qobject: Accept "%"PRId64 in qobject_from_jsonf()

Commit 1792d7d0 was written because PRId64 expands to non-portable crap for some libc, and we had testsuite failures on Mac OS as a result. This in turn makes it difficult to rely on the obvious conversions of 64-bit values into JSON, requiring things such as casting int64_t to long long so we

Re: [Qemu-devel] [PATCH 4/9] tests: Clean up string interpolation into QMP input (simple cases)

On 07/21/2017 11:48 AM, Markus Armbruster wrote: > I forgot that PRId64 expands into non-standard crap on some systems. > > Options: > > 1. Outlaw use of PRI macros, limit integer length modifiers for >conversion specifiers "d" and "u" to "l" and "ll". When PRI macros >creep in, the

Re: [Qemu-devel] [PATCH] vhost: fix a migration failed because of vhost region merge

On Thu, Jul 20, 2017 at 06:22:15PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Jul 19, 2017 at 03:24:27PM +0200, Igor Mammedov wrote: > > > On Wed, 19 Jul 2017 12:46:13 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > >

Re: [Qemu-devel] [PATCH 2/2] [PATCH] hmp: allow apic-id for "info lapic"

On Fri, Jul 21, 2017 at 03:38:56AM -0400, Yi Wang wrote: > Add [apic-id] support for hmp command "info lapic", which is > useful when debugging ipi and so on. Current behavior is not > changed when the parameter isn't specified. > > Signed-off-by: Yi Wang > Signed-off-by:

Re: [Qemu-devel] [PATCH] target/arm: fix TCG temp leak in aarch64 rev16

On Fri, Jul 21, 2017 at 14:16:46 +0100, Peter Maydell wrote: > On 21 July 2017 at 06:42, Emilio G. Cota wrote: > > const leak! patch below -- cut with `git am --scissors'. > > > > Emilio > > > > ---8<--- > > > > Signed-off-by: Emilio G. Cota > >

Re: [Qemu-devel] [PATCH 2/3] Unified Datagram Socket Transport - GRE support

On 07/19/2017 12:32 PM, Anton Ivanov wrote: > > > On 19/07/17 15:40, Eric Blake wrote: >> On 07/18/2017 12:08 PM, anton.iva...@cambridgegreys.com wrote: >>> From: Anton Ivanov >>> >>> This adds GRETAP support to the unified socket driver. >>> >>> +# >>> +#

Re: [Qemu-devel] dirty page count problem

* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi, > Git bisect is pointing to your patch 084140bd49: > exec: fix access to ram_list.dirty_memory when sync dirty bitmap > > trying to diagnose a bug I'm seeing; it looks like the dirty page count > is wrong for some reason. > > Alex

Re: [Qemu-devel] Unified Datagram Socket Transport

Hi Jason, Hi Eric, hi list, I have gone through all comments and addressed everything to which I did not reply separately with clarifications. Before I resubmit I have a couple of architectural questions: 1. Is it OK in its current form: UDST client which cannot be instantiated and the

Re: [Qemu-devel] [PATCH 10/11] qtest.py: Few pylint/style fixes

On Fri, Jul 21, 2017 at 08:57:34AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:42 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:14PM +0200, Lukáš Doktor wrote: > > [...] > >> @@ -83,8 +80,11 @@ class QEMUQtestMachine(qemu.QEMUMachine): > >>

Re: [Qemu-devel] [PATCH 3/3] Unified Datagram Socket Transport - raw support

[snip] +"-netdev raw,id=str,ifname=ifname\n" +"configure a network backend with ID 'str' connected to\n" +"an Ethernet interface named ifname via raw socket.\n" +"This backend does not change the interface settings.\n" +"

Re: [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object

On Fri, Jul 21, 2017 at 08:53:49AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:38 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:13PM +0200, Lukáš Doktor wrote: > >> The "id" is a builtin method to get object's identity and should not be > >> overridden. This might bring some

Re: [Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMonitorProtocol

On Fri, Jul 21, 2017 at 08:50:22AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:35 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:11PM +0200, Lukáš Doktor wrote: > >> There is no need to define QEMUMonitorProtocol as old-style class. > >> > >> Signed-off-by: Lukáš Doktor

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: > >> The naked Exception should not be widely used. It makes sense to be a > >> bit more specific and use better-suited

[Qemu-devel] virtio-net-pci possible limitation on AArch64

Hi, I ran into an interesting limitation (or possibly bug) while trying to attach more than 3 (three) virtio-net-pci NICs to an AArch64 guest. I created 4 network with virsh (see below for xml defitions) - nothing fancy, only 2 of them use NAT. Attaching a virtio-net-pci NIC for each network

Re: [Qemu-devel] [PULL for-2.10 6/7] xen/mapcache: introduce xen_replace_cache_entry()

On 21/07/17 14:50, Anthony PERARD wrote: On Tue, Jul 18, 2017 at 03:22:41PM -0700, Stefano Stabellini wrote: From: Igor Druzhinin ... +static uint8_t *xen_replace_cache_entry_unlocked(hwaddr old_phys_addr, + hwaddr

[Qemu-devel] [PATCH 2/2] qcow2: Fix sector calculation in qcow2_measure()

We used MAX() instead of the intended MIN() when computing how many sectors to view in the current loop iteration of qcow2_measure(), and passed in a value of INT_MAX sectors instead of our more usual limit of BDRV_REQUEST_MAX_SECTORS (the latter avoids 32-bit overflow on conversion to bytes).

[Qemu-devel] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then removed things from block/qapi.c, in preparation for a rewrite to a list of dirty sectors in the next commit 21b5683 in block.c, but the

[Qemu-devel] [PATCH for-2.10 0/2] Bug fixes from byte-based block status

Series 2-4 of my byte-based conversion missed soft freeze, so they are now 2.11 material. However, there are some bug fixes in those series that we should fix now in 2.10 (patch 1 from series two on dirty bitmaps, patch 2 extracted from "qcow2: Switch qcow2_measure() to byte-based iteration" from

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On Fri, Jul 21, 2017 at 2:34 PM, Igor Mammedov wrote: > On Fri, 21 Jul 2017 10:23:38 +0100 > "Daniel P. Berrange" wrote: > >> On Fri, Jul 21, 2017 at 11:06:36AM +0200, Igor Mammedov wrote: >> > On Thu, 20 Jul 2017 21:29:33 +0200 >> > Phil Dennis-Jordan

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

On 21/07/2017 20:28, Kevin O'Connor wrote: On Fri, Jul 21, 2017 at 03:15:46PM +0300, Marcel Apfelbaum wrote: On 21/07/2017 13:04, Gerd Hoffmann wrote: I'd prefer to have a single vendor capability for all resource allocation hints provided by qemu. Sure, the capability looking something like:

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

[snip] +NetUnifiedState *s = (NetUnifiedState *) us; +L2TPV3TunnelParams *p = (L2TPV3TunnelParams *) s->params; How about embedding NetUnifiedState into this structure and keep using NetL2TPV3State? Then: - 's' could be kept and lots of lines of changes could be saved here and

Re: [Qemu-devel] [RFC PATCH for 2.11 12/23] target/arm/translate-a64.c: add FP16 FAGCT to AdvSIMD 3 Same

On 2017-07-21 14:58, Peter Maydell wrote: > On 21 July 2017 at 14:50, Alex Bennée wrote: > > Aurelien Jarno writes: > >> As said in another email, some architectures actually use more than one > >> float_status. We therefore need to implement a

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

> On Jul 21, 2017, at 5:32 AM, Igor Mammedov wrote: > > w2k used to boot on QEMU until we bumped revision of FADT to rev3 > (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > guest OS support.) > > Considering that w2k is ancient and long time

Re: [Qemu-devel] [PATCH 2/2] file-posix: Do runtime check for ofd lock API

> From: Fam Zheng [mailto:f...@redhat.com] > Sent: Friday, 21 July 2017 3:21 > > It is reported that on Windows Subsystem for Linux, ofd operations fail > with -EINVAL. In other words, QEMU binary built with system headers that > exports F_OFD_SETLK doesn't necessarily run in an environment that

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

On Fri, Jul 21, 2017 at 03:15:46PM +0300, Marcel Apfelbaum wrote: > On 21/07/2017 13:04, Gerd Hoffmann wrote: > > I'd prefer to have a single vendor capability for all resource > > allocation hints provided by qemu. > Sure, the capability looking something like: > >[flags:

[Qemu-devel] dirty page count problem

Hi, Git bisect is pointing to your patch 084140bd49: exec: fix access to ram_list.dirty_memory when sync dirty bitmap trying to diagnose a bug I'm seeing; it looks like the dirty page count is wrong for some reason. Alex Bennée spotted a problem where the postcopy test would occasionally

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On Fri, 21 Jul 2017, Phil Dennis-Jordan wrote: On Fri, Jul 21, 2017 at 12:50 PM, BALATON Zoltan wrote: I don't know if this helps but I've found that this same commit also broke booting OS X on q35 with OVMF and Clover (some old versions I had and worked before this

Re: [Qemu-devel] [PATCH 0/2] improve tracing

Vladimir Sementsov-Ogievskiy writes: > Current trace system have a drawback: parameters of trace functions > are calculated even if corresponding tracepoint is disabled. Also, it > looks like trace function are not actually inlined by compiler (at > least for me). > Here is a fix proposal: move

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> Leaving interpolation into JSON to qmp() is more robust than building >> QMP input manually, as explained in the commit before previous. >> >> The case in qpci_plug_device_test() is a bit complicated: it

Re: [Qemu-devel] [PATCH 5/9] tests/libqos/usb: Clean up string interpolation into QMP input

Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> Leaving interpolation into JSON to qmp() is more robust than building >> QMP input manually, as explained in the previous commit. >> >> The case in usb_test_hotplug() slightly more complicated: it > >

Re: [Qemu-devel] [PATCH 4/9] tests: Clean up string interpolation into QMP input (simple cases)

Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> When you build QMP input manually like this >> >> cmd = g_strdup_printf("{ 'execute': 'migrate'," >> "'arguments': { 'uri': '%s' } }", >> uri); >>

Re: [Qemu-devel] [PATCH 16/29] lm32: use QEMU_IS_ALIGNED macro

On 07/18/2017 11:37 AM, Thomas Huth wrote: On 18.07.2017 13:42, Michael Walle wrote: Am 2017-07-18 08:09, schrieb Philippe Mathieu-Daudé: Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé QEMU_IS_ALIGNED()

Re: [Qemu-devel] [PATCH 10/29] net/rocker: use QEMU_IS_ALIGNED macro

On 07/18/2017 02:51 PM, Eric Blake wrote: On 07/18/2017 01:09 AM, Philippe Mathieu-Daudé wrote: Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] Improving QMP test coverage

On 07/21/2017 11:33 AM, Stefan Hajnoczi wrote: >> Output testing style delegates checking ouput to diff. I rather like it >> when text output is readily available. It is when testing QMP. A >> non-trivial example using this style could be useful, as discussing >> ideas tends to be more

Re: [Qemu-devel] [RFC] RFC on Backup tool

Ishani writes: > Thanks for the review. > > - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: > >> On Sun, 07/16 02:13, Ishani Chugh wrote: >>> This is a Request For Comments patch for qemu backup tool. As an >>> Outreachy intern, I am

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

> On Jul 21, 2017, at 5:29 AM, qemu-devel-requ...@nongnu.org wrote: > > From: Igor Mammedov > > On Thu, 20 Jul 2017 21:29:33 +0200 > Phil Dennis-Jordan wrote: > >> On Thu, Jul 20, 2017 at 6:40 PM, Programmingkid >> wrote:

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

On Fri, Jul 21, 2017 at 09:29:15AM -0400, Pankaj Gupta wrote: > > > > A] Problems to solve: > > > -- > > > > > > 1] We are considering two approaches for 'fake DAX flushing interface'. > > > > > > 1.1] fake dax with NVDIMM flush hints & KVM async page fault > > > > > >

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

On Fri, Jul 21, 2017 at 07:16:34AM -0500, Eric Blake wrote: > On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: > > There is not much getting started documentation for qemu-iotests. This > > patch explains how to create a new test and covers the overall testing > > approach. > > > > Cc: Ishani

Re: [Qemu-devel] [PATCH 2/9] qtest: Document calling conventions

Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> From: Eric Blake >> >> We have two flavors of vararg usage in qtest; make it clear that >> qmp() has different semantics than hmp(), and let the compiler >> enforce that hmp() is used

Re: [Qemu-devel] [Qemu-block] [PATCH] block: check BlockDriverState object before dereference

On Mon, Jul 17, 2017 at 11:56:48AM -0400, John Snow wrote: > On 07/11/2017 01:08 PM, P J P wrote: > > From: Prasad J Pandit > > > > When processing ATA_CACHE_FLUSH ide controller command, > > BlockDriverState object could be null. Add check to avoid > > null pointer

Re: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

On 07/21/2017 10:10 AM, Kevin Wolf wrote: > Test cases 030, 041 and 055 used to sleep for a second after calling > block-job-pause to make sure that the block job had time to actually > get into paused state. We can instead poll its status and use that one > second only as a timeout. > > The

Re: [Qemu-devel] Improving QMP test coverage

On Tue, Jul 18, 2017 at 06:24:19PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Thu, Jul 13, 2017 at 05:28:52PM +0200, Markus Armbruster wrote: > >> What can we do to improve QMP testing? Sadly, I don't have the master > >> plan ready. I can tell

Re: [Qemu-devel] [RFC] RFC on Backup tool

On Tue, Jul 18, 2017 at 05:29:11PM -0400, John Snow wrote: > > > On 07/17/2017 03:37 PM, Ishani wrote: > > - On Jul 17, 2017, at 12:48 PM, Fam Zheng f...@redhat.com wrote: > >> On Sun, 07/16 02:13, Ishani Chugh wrote: > > [...] > > >> Only full backup is implemented in this patch, is the

Re: [Qemu-devel] [PATCH] block/vpc: fix uninitialised variable compiler warning

On 21 July 2017 at 09:21, Mark Cave-Ayland wrote: > Since commit cfc87e00 "block/vpc.c: Handle write failures in > get_image_offset()" older versions of gcc (in this case 4.7) incorrectly > warn that "ret" can be used uninitialised in vpc_co_pwritev(). > > Setting

Re: [Qemu-devel] [PATCH for-2.10 3/4] bsd-user/bsdload.c: Remove write-only id_change variable

On 21 July 2017 at 12:12, Thomas Huth wrote: > On 18.07.2017 18:26, Peter Maydell wrote: >> On OpenBSD the compiler complains: >> bsd-user/bsdload.c:54:17: warning: variable 'id_change' set but not used >> [-Wunused-but-set-variable] >> >> This is dead code that was originally

Re: [Qemu-devel] [PATCH] configure: Never use 'uname' to identify target OS

On 13 July 2017 at 16:15, Peter Maydell wrote: > For a very long time we have used 'uname -s' as our fallback if > we don't identify the target OS using a compiler #define. This > obviously doesn't work for cross-compilation, and we've had > a comment suggesting we fix

Re: [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning

On 21 July 2017 at 13:23, Eric Blake wrote: > On 07/19/2017 03:19 AM, Peter Maydell wrote: >> On 18 July 2017 at 23:01, Eric Blake wrote: >>> On 07/18/2017 11:26 AM, Peter Maydell wrote: On OpenBSD the compiler warns: bsd-user/main.c:622:21:

Re: [Qemu-devel] [PATCH] configure: Drop ancient Solaris 9 and earlier support

On 13 July 2017 at 15:21, Peter Maydell wrote: > Solaris 9 was released in 2002, its successor Solaris 10 was > released in 2005, and Solaris 9 was end-of-lifed in 2014. > Nobody has stepped forward to express interest in supporting > Solaris of any flavour, so removing

  1   2   3   4   >