Re: [Qemu-devel] [PATCH v2 06/19] s390x: move s390_virtio_hypercall() to s390-virtio-hcall.h

On 04.09.2017 17:43, David Hildenbrand wrote: > Implemented in hw/s390x/s390-virtio-hcall.c, so let's move it to the > right header file. That's fair. Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v2 05/19] target/s390x: move typedef of S390CPU to its definition

On 04.09.2017 17:43, David Hildenbrand wrote: > Let's move it to the palce where struct S390CPU is defined. s/palce/place/ > Suggested-by: Thomas Huth > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu-qom.h | 2 -- > target/s390x/cpu.h | 4

Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly

On 04.09.2017 17:42, David Hildenbrand wrote: > All but a handfull of filles include exec/cpu-all.h via cpu.h only. > As these files already include cpu.h, let's just drop the additional > include. > > Signed-off-by: David Hildenbrand > --- > dump.c

Re: [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

On 06.09.2017 23:00, Eric Blake wrote: > On 09/05/2017 04:36 AM, Thomas Huth wrote: >> On 01.09.2017 20:03, Eric Blake wrote: >>> When initializing a QPCIBus, track which QTestState the bus is >>> associated with (so that a later patch can then explicitly use >>> that test state for all

Re: [Qemu-devel] [PATCH 3/3] Backup Tool: Test for Incremental Backup

Hello, I apologize for late reply. I was occupied by exams. I will send a revision asap. Thanks. - On Sep 2, 2017, at 4:23 AM, jsnow js...@redhat.com wrote: > On 08/30/2017 10:02 PM, Fam Zheng wrote: >> On Thu, 08/31 00:45, Ishani Chugh wrote: >>> This patch is the test for incremental

Re: [Qemu-devel] [PATCHv5 03/03] colo-compare: Update the COLO document to add the IOThread configuration

On 08/29/2017 03:22 PM, Wang yong wrote: From: Wang Yong Update colo-proxy.txt,add IOThread configuration. Later we have to configure IOThread,if not COLO can not work. Signed-off-by: Wang Yong Signed-off-by: Wang Guang

Re: [Qemu-devel] [PATCHv5 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary

On 08/29/2017 03:22 PM, Wang yong wrote: From: Wang Yong Remove the task which check old packet in the comparing thread, then use IOthread context timer to handle it. Process pactkets in the IOThread which arrived over the socket. we use iothread_get_g_main_context

Re: [Qemu-devel] [PATCH v2 16/19] s390x: allow cpu hotplug via device_add

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > E.g. the following now works: > device_add host-s390-cpu,id=cpu1,core-id=1 > > The system will perform the same checks as when using cpu_add: > - If the core_id is already in use > - If the next sequential core_id isn't used > - If core-id >=

Re: [Qemu-devel] [PATCH v2 14/19] target/s390x: rename next_cpu_id to next_core_id

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > Adapt to the new term "core_id". While at it, fix the type and drop the > initialization to 0 (which is superfluous). > > Signed-off-by: David Hildenbrand Given the prior patch, this rename makes sense. Reviewed-by: Matthew

Re: [Qemu-devel] [PATCH v2 13/19] target/s390x: use "core-id" for cpu number/address/id handling

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > Some time ago we discussed that using "id" as property name is not the > right thing to do, as it is a reserved property for other devices and > will not work with device_add. > > Switch to the term "core-id" instead, and use it as an equivalent

Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to qtest_start()

On 09/05/2017 08:10 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> We already have another qtest_init() in the tree, for the >> top-level qtest.c device; having two functions with different >> signatures is confusing. Rename the libqtest version to >> qtest_start() to

Re: [Qemu-devel] [Qemu devel v7 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

Hi Alistair, On Thu, Sep 7, 2017 at 1:59 AM, Alistair Francis wrote: > On Mon, Aug 28, 2017 at 9:38 AM, Subbaraya Sundeep > wrote: > > Modelled Microsemi's Smartfusion2 SPI controller. > > > > Signed-off-by: Subbaraya Sundeep

Re: [Qemu-devel] [PATCH v2 12/19] target/s390x: set cpu->id for linux user when realizing

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > scc->next_cpu_id is updated when realizing. Setting it just before that > point looks cleaner. > > Signed-off-by: David Hildenbrand Reviewed-by: Matthew Rosato > --- > target/s390x/cpu.c | 11

Re: [Qemu-devel] [PATCH 2/2] i386/cpu/hyperv: support over 64 vcpus for windows guests

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, September 05, 2017 9:17 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; > r...@twiddle.net; mtosa...@redhat.com; vroze...@redhat.com; > Huangweidong (C) >

Re: [Qemu-devel] [PATCH 1/2] pc: add 2.11 machine type

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, September 05, 2017 9:21 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; m...@redhat.com; pbonz...@redhat.com; > r...@twiddle.net; mtosa...@redhat.com; vroze...@redhat.com; > Huangweidong (C) >

Re: [Qemu-devel] [PATCH v2 2/3] hw/arm: Set ignore_memory_transaction_failures for most ARM boards

On Tue, Sep 5, 2017 at 8:53 AM, Peter Maydell wrote: > Set the MachineClass flag ignore_memory_transaction_failures > for almost all ARM boards. This means they retain the legacy > behaviour that accesses to unimplemented addresses will RAZ/WI > rather than aborting,

Re: [Qemu-devel] [PATCH v2 1/3] boards.h: Define new flag ignore_memory_transaction_failures

On Tue, Sep 5, 2017 at 9:03 AM, Richard Henderson wrote: > On 09/05/2017 08:53 AM, Peter Maydell wrote: >> Define a new MachineClass field ignore_memory_transaction_failures. >> If this is flag is true then the CPU will ignore memory transaction >> failures which

Re: [Qemu-devel] [PATCH] trace: Immediately apply per-vCPU state changes if a vCPU is being created

On Wed, Sep 06, 2017 at 18:27:10 +0300, Lluís Vilanova wrote: > Right now, function trace_event_set_vcpu_state_dynamic() asynchronously > enables > events in the case a vCPU is executing TCG code. If the vCPU is being created > this makes some events like "guest_cpu_enter" to not be traced. > >

Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface

On Wed, Sep 06, 2017 at 20:59:02 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- (snip) > +QI_VPUBLIC void qi_set_fini(qi_fini_fn fn, void *data) > +{ > +ERROR_IF(!instr_get_state(), "called outside instrumentation"); > +instr_set_event(fini_fn,

Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on global_qtest

On 09/05/2017 06:05 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> As a general rule, we prefer avoiding implicit global state >> because it makes code harder to safely copy and paste without >> thinking about the global state. It turns out that with the >> recent changes to

Re: [Qemu-devel] [Qemu-block] [PATCH v6 16/29] libqos: Use explicit QTestState for virtio operations

On 09/05/2017 07:43 AM, Paolo Bonzini wrote: >> typedef struct QVirtioDevice { >> const QVirtioBus *bus; >> +QTestState *qts; >> /* Device type */ >> uint16_t device_type; >> } QVirtioDevice; >> @@ -35,12 +36,14 @@ typedef struct QVirtQueue { >> uint16_t last_used_idx; >>

Re: [Qemu-devel] [PATCH v4 11/20] instrument: Track vCPUs

On Wed, Sep 06, 2017 at 21:07:06 +0300, Lluís Vilanova wrote: > Keep a translation between instrumentation's QICPU and CPUState objects to > avoid > exposing QEMU's internals to instrumentation clients. > > Signed-off-by: Lluís Vilanova (snip) > diff --git

Re: [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 09/06/2017 04:10 PM, Eric Blake wrote: >> I'm not a fan of including header files from other header files, so >> changing the include order in the .c files sounds like the better >> solution to me. > > Eww. I like headers to be self-contained. Other than stuff we get from > osdep.h (which we

Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface

On Wed, Sep 06, 2017 at 20:59:02 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > Makefile |5 +++ > configure |1 + > instrument/Makefile.objs |2 + > instrument/control.c

Re: [Qemu-devel] [PATCH v4 03/20] instrument: Add generic library loader

On Wed, Sep 06, 2017 at 20:34:48 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- (snip) > diff --git a/configure b/configure > index 80dcc91c98..05bd7b1950 100755 > --- a/configure > +++ b/configure > @@ -6034,6 +6034,8 @@ fi > echo

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

On 09/06/2017 11:16 AM, Matthew Rosato wrote: > On 09/04/2017 11:43 AM, David Hildenbrand wrote: >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x under TCG. >> >> Let's bail

Re: [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 09/05/2017 06:03 AM, Thomas Huth wrote: > On 05.09.2017 12:12, Thomas Huth wrote: >> On 01.09.2017 20:03, Eric Blake wrote: >>> Drop one more client of global_qtest by teaching all fw_cfg test >>> functionality (invoked through alloc-pc) to pass in an explicit >>> QTestState, adjusting all

Re: [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

On 09/05/2017 04:36 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> When initializing a QPCIBus, track which QTestState the bus is >> associated with (so that a later patch can then explicitly use >> that test state for all communication on the bus, rather than >> blindly

Re: [Qemu-devel] [PATCH v4 00/20] instrument: Add basic event instrumentation

On Wed, Sep 06, 2017 at 20:22:41 +0300, Lluís Vilanova wrote: > This series adds an API to add instrumentation events. > > It also provides additional APIs for: > * Controlling tracing events hmm didn't Stefan say that tracing should be decoupled from this? > * Peek/poke guest memory > >

Re: [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

On 09/01/2017 02:20 PM, Philippe Mathieu-Daudé wrote: > Hi Eric, > > On 09/01/2017 03:03 PM, Eric Blake wrote: >> When initializing a QPCIBus, track which QTestState the bus is >> associated with (so that a later patch can then explicitly use >> that test state for all communication on the bus,

Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support

On Wed, Sep 06, 2017 at 16:28:44 -0400, Emilio G. Cota wrote: > --- /dev/null > +++ b/plugin.c > @@ -0,0 +1,519 @@ (snip) > +/* > + * @lock protects the struct as well as ctx->uninstalling. > + * The lock must be acquired by all API ops. Since some API ops > + * call plugin code

[Qemu-devel] [RFC 2/6] plugin: add initial plugin support

This is still a work in progress, hence the limited public-facing API. I wanted to add more events (e.g. memory and basic block callbacks), but before spending more time on time I'd like to see whether this direction is appreciated by others. The goals are to: - Have a simple implementation that

[Qemu-devel] [RFC 1/6] tcg: keep a pointer to the current TB in TCGContext

Instead of just a copy of tb->cflags. This gives access in TCG to other fields in TB, which will be needed when we implement callbacks from memory accesses performed by TCG-translated code. Signed-off-by: Emilio G. Cota --- tcg/tcg.h | 2 +-

[Qemu-devel] [RFC 0/6] initial plugin support

Related threads: [PATCH 00/13] instrument: Add basic event instrumentation Date: Mon, 24 Jul 2017 20:02:24 +0300 https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07419.html and [PATCH v4 00/20] instrument: Add basic event instrumentation Date: Wed, 6 Sep 2017 20:22:41 +0300

[Qemu-devel] [RFC 6/6] linux-user: support -plugin option

From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota --- linux-user/main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/linux-user/main.c

[Qemu-devel] [RFC 4/6] Makefile: install qemu-api.h as include/qemu-plugin.h

Signed-off-by: Emilio G. Cota --- Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ef72148..326867e 100644 --- a/Makefile +++ b/Makefile @@ -602,8 +602,10 @@ ifneq (,$(findstring qemu-ga,$(TOOLS))) endif endif

Re: [Qemu-devel] [Qemu devel v7 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

On Mon, Aug 28, 2017 at 9:38 AM, Subbaraya Sundeep wrote: > Modelled Microsemi's Smartfusion2 SPI controller. > > Signed-off-by: Subbaraya Sundeep > --- > hw/ssi/Makefile.objs | 1 + > hw/ssi/mss-spi.c | 409 >

[Qemu-devel] [RFC 5/6] vl: support -plugin option

From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota --- vl.c| 10 ++ qemu-options.hx | 17 + 2 files changed, 27 insertions(+) diff --git

[Qemu-devel] [RFC 3/6] configure: add --enable-plugins

For now only add it for ELF platforms, since we rely on the linker's --dynamic-list flag to pass a list of symbols to be exported to the executable. An alternative would be to use -rdynamic, but that would expose all of QEMU's objects to plugins. I have no experience with non-ELF systems but I

Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline qtest_query_target_endianness()

On 09/05/2017 04:25 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> There was only one caller; it's easier to inline things. >> >> Signed-off-by: Eric Blake >> --- >> tests/libqtest.c | 22 ++ >> 1 file changed, 6 insertions(+), 16

Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for tests/multiboot

On 09/04/2017 09:03 AM, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> Right now, tests/multiboot is not run by default during 'make check'; >> but when it is run in-tree, it was leaving some junk behind that could >> accidentally get checked in with a careless 'git add tests'. >>

Re: [Qemu-devel] [PATCH v7 06/22] migration: Improve migration thread error handling

* Juan Quintela (quint...@redhat.com) wrote: > We now report errors also when we finish migration, not only on info > migrate. We plan to use this error from several places, and we want > the first error to happen to win, so we add an mutex to order it. > > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCHv3 1/2] pci: move check for existing devfn into new pci_bus_devfn_available() helper

On 04/09/17 11:01, Yi Min Zhao wrote: > I want to ask a question. According to the next patch, you check > bus->devices[devfn] > and reserved bit separately. Why not move the reserved bit check here? > I think bus->devices[devfn] != NULL or revsered bit set means slot is > unavailable. Primarily

[Qemu-devel] [PULL 7/8] snapshot/tests: Try loadvm twice

From: "Dr. David Alan Gilbert" It's legal to loadvm twice, modify the existing save/loadvm test to do it twice. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170825141940.20740-3-dgilb...@redhat.com> Reviewed-by: Peter Xu

[Qemu-devel] [PATCH] hw/ppc/spapr.c: cleaning up qdev_get_machine() calls

This patch removes the qdev_get_machine() calls that are made in spapr.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. The following changes were made: - spapr_node0_size:

[Qemu-devel] [PULL 4/8] host-utils: Simplify pow2ceil()

From: Markus Armbruster Cc: Radim Krčmář Signed-off-by: Markus Armbruster Message-Id: <1501148776-16890-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v4 20/20] instrument: Add API to manipulate guest memory

It includes access to the guest's memory and vCPU registers. Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs |1 instrument/qemu-instr/state.h | 104 + instrument/state.c| 72

[Qemu-devel] [PULL 6/8] migration: Reset rather than destroy main_thread_load_event

From: "Dr. David Alan Gilbert" migration_incoming_state_destroy doesn't really destroy, it cleans up. After a loadvm it's called, but the loadvm command can be run twice, and so destroying an init-once mutex breaks on the second loadvm. Reported-by: Stafford Horne

[Qemu-devel] [PULL 3/8] host-utils: Proactively fix pow2floor(), switch to unsigned

From: Markus Armbruster The function's stated contract is simple enough: "round down to the nearest power of 2". Suggests the domain is the representable numbers >= 1, because that's the smallest power of two. The implementation doesn't check for domain errors, but returns

[Qemu-devel] [PULL 0/8] migration queue

From: "Dr. David Alan Gilbert" The following changes since commit b07d1c2f5607489d4d4a6a65ce36a3e896ac065e: Revert "kvm: use DIV_ROUND_UP" (2017-09-05 18:55:40 +0100) are available in the git repository at: git://github.com/dagrh/qemu.git tags/pull-migration-20170906a

[Qemu-devel] [PULL 5/8] runstate/migrate: Two more transitions

From: "Dr. David Alan Gilbert" There's a race if someone does a 'stop' near the end of migrate; the migration process goes through two runstates: 'finish migrate' 'postmigrate' If the user issues a 'stop' between the two we end up with invalid state transitions. Add

[Qemu-devel] [PULL 8/8] migration: dump str in migrate_set_state trace

From: Peter Xu Strings are more readable for debugging. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu Message-Id: <1504081950-2528-5-git-send-email-pet...@redhat.com> Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 1/8] migration: Report when bdrv_inactivate_all fails

From: "Dr. David Alan Gilbert" If the bdrv_inactivate_all fails near the end of the migration, the migration will fail and often the only diagnostics in the log are an I/O error which you can't distinguish from an error on the socket connection. Add an error so we know when

[Qemu-devel] [PULL 2/8] xbzrle: Drop unused cache_resize()

From: Markus Armbruster Unused since commit fd8cec XBZRLE: Fix qemu crash when resize the xbzrle cache. Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v4 19/20] instrument: Add event 'guest_user_syscall_ret'

Signed-off-by: Lluís Vilanova --- bsd-user/syscall.c |3 +++ instrument/control.c| 11 +++ instrument/events.h |5 + instrument/events.inc.h | 13 + instrument/load.c |1 +

[Qemu-devel] [PATCH v4 18/20] instrument: Add event 'guest_user_syscall'

Signed-off-by: Lluís Vilanova --- bsd-user/syscall.c |3 +++ instrument/control.c| 14 ++ instrument/events.h |7 +++ instrument/events.inc.h | 16 instrument/load.c |

[Qemu-devel] [PATCH v4 17/20] instrument: Add event 'guest_mem_before_exec'

Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h |4 +++ include/exec/cpu_ldst_useronly_template.h |4 +++ include/exec/helper-gen.h |1 + include/exec/helper-proto.h |1 + include/exec/helper-tcg.h

[Qemu-devel] [PATCH v4 16/20] instrument: Add event 'guest_mem_before_trans'

Signed-off-by: Lluís Vilanova --- Makefile.target |1 + instrument/control.c| 13 +++- instrument/control.h| 36 +- instrument/control.inc.h| 16 +++--- instrument/events.h |

[Qemu-devel] [PATCH v4 15/20] trace: Introduce a proper structure to describe memory accesses

Signed-off-by: Lluís Vilanova --- include/exec/cpu_ldst_template.h | 15 ++ include/exec/cpu_ldst_useronly_template.h | 15 ++ tcg/tcg-op.c | 22 + trace/mem-internal.h

[Qemu-devel] [PATCHv2 0/1] net: Add SunGEM device emulation as found on Apple UniNorth

This is a reworking of Ben's original implementation of the SunGEM device from last year: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg02571.html. The reason for implenting this device is that it allows out-of-the-box networking for most MacOS 9 and MacOS X OSs running under

[Qemu-devel] [PATCHv2 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

From: Benjamin Herrenschmidt This adds a simplistic emulation of the Sun GEM ethernet controller found in Apple ASICs. Currently we only support the Apple UniNorth 1.x variant, but the other Apple or Sun variants should mostly be a matter of adding PCI IDs options. We

[Qemu-devel] [PATCH v4 14/20] instrument: Add event 'guest_cpu_reset'

Signed-off-by: Lluís Vilanova --- instrument/control.c|9 + instrument/events.h |3 +++ instrument/events.inc.h | 11 +++ instrument/load.c |1 + instrument/qemu-instr/control.h |9 +

Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 is specified, so we don't raise

[Qemu-devel] [PATCH v4 13/20] instrument: Add event 'guest_cpu_exit'

Signed-off-by: Lluís Vilanova --- instrument/control.c|9 + instrument/events.h |3 +++ instrument/events.inc.h | 11 +++ instrument/load.c |1 + instrument/qemu-instr/control.h |9 +

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

On 09/04/2017 11:43 AM, David Hildenbrand wrote: > device_del on a CPU will currently do nothing. Let's emmit an error > telling that this is will never work (there is no architecture support > on s390x). Error message copied from ppc. > > (qemu) device_del cpu1 > device_del cpu1 > CPU hot unplug

[Qemu-devel] [PATCH v4 12/20] instrument: Add event 'guest_cpu_enter'

Signed-off-by: Lluís Vilanova --- instrument/control.c|9 instrument/events.h |5 instrument/events.inc.h | 11 ++ instrument/load.c |1 + instrument/qemu-instr/control.h | 44

Re: [Qemu-devel] [PATCH] target/alpha: Switch to do_transaction_failed() hook

On 09/05/2017 08:54 AM, Peter Maydell wrote: > On 8 August 2017 at 13:42, Peter Maydell wrote: >> Switch the alpha target from the old unassigned_access hook >> to the new do_transaction_failed hook. This allows us to >> resolve a ??? in the old hook implementation. >>

[Qemu-devel] [PATCH v4 11/20] instrument: Track vCPUs

Keep a translation between instrumentation's QICPU and CPUState objects to avoid exposing QEMU's internals to instrumentation clients. Signed-off-by: Lluís Vilanova --- cpus-common.c|9 + instrument/control.c | 22 ++

Re: [Qemu-devel] [PATCH v1 2/2] io: include full error message in websocket handshake trace

On 09/06/2017 07:40 AM, Daniel P. Berrange wrote: When the websocket handshake fails it is useful to log the real error message via the trace points for debugging purposes. Fixes bug: #1715186 Signed-off-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v1 1/2] io: send proper HTTP response for websocket errors

Hi Daniel, On 09/06/2017 07:40 AM, Daniel P. Berrange wrote: When any error occurs while processing the websockets handshake, QEMU just terminates the connection abruptly. This is in violation of the HTTP specs and does not help the client understand what they did wrong. This is particularly

[Qemu-devel] [PATCH v4 10/20] instrument: Add support for tracing events

Signed-off-by: Lluís Vilanova --- .gitignore|1 Makefile |3 + instrument/Makefile.objs |1 instrument/error.h|6 ++ instrument/qemu-instr/types.h | 51 +++

[Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface

Signed-off-by: Lluís Vilanova --- Makefile |5 +++ configure |1 + instrument/Makefile.objs |2 + instrument/control.c | 28 + instrument/control.h | 44

Re: [Qemu-devel] [RFC PATCH 00/56] qapi: Use 'size' for byte counts & offsets

Kevin Wolf writes: > Am 07.08.2017 um 16:45 hat Markus Armbruster geschrieben: >> Byte sizes, offsets and the like should use QAPI type 'size' >> (uint64_t). This rule is more honored in the breach than in the >> observance. Fix the obvious offenders. >> >> The series is RFC

[Qemu-devel] [PATCH v4 08/20] instrument: [hmp] Add library loader

Signed-off-by: Lluís Vilanova --- hmp-commands.hx | 28 ++ monitor.c | 60 +++ 2 files changed, 88 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1941e19932..703d7262f5

Re: [Qemu-devel] [PATCH 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

On 06/09/17 07:56, David Gibson wrote: Applied to ppc-for-2.11. >>> >>> Until I discovered that it breaks compile with >>> --enable-trace-backend=ust. So I've removed it again. >> >> Oh that's interesting. I've had --enable-trace-backend=simple as part of >> my default build for a long

[Qemu-devel] [PATCH v4 07/20] instrument: [qapi] Add library loader

Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs |1 instrument/load.h|4 ++ instrument/qmp.c | 88 ++ qapi-schema.json |3 + qapi/instrument.json | 96

[Qemu-devel] [PATCH v4 06/20] instrument: [softmmu] Add command line library loader

Signed-off-by: Lluís Vilanova --- qemu-options.hx | 19 +++ vl.c| 15 +++ 2 files changed, 34 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 9f6e2adfff..6947388aab 100644 --- a/qemu-options.hx +++

[Qemu-devel] [PATCH v4 05/20] instrument: [bsd-user] Add command line library loader

Signed-off-by: Lluís Vilanova --- bsd-user/main.c| 15 +++ bsd-user/syscall.c |5 + 2 files changed, 20 insertions(+) diff --git a/bsd-user/main.c b/bsd-user/main.c index 8a6706a1c8..2cf75290cd 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@

[Qemu-devel] [PATCH v4 04/20] instrument: [linux-user] Add command line library loader

Signed-off-by: Lluís Vilanova --- linux-user/main.c| 19 +++ linux-user/syscall.c |4 2 files changed, 23 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 03666ef657..25253bc28a 100644 --- a/linux-user/main.c +++

[Qemu-devel] [PATCH v4 03/20] instrument: Add generic library loader

Signed-off-by: Lluís Vilanova --- MAINTAINERS |1 Makefile.objs|4 + configure|2 + instrument/Makefile.objs |4 + instrument/cmdline.c | 124 instrument/cmdline.h | 49

[Qemu-devel] [PATCH v4 02/20] instrument: Add configure-time flag

Signed-off-by: Lluís Vilanova --- configure |9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index dd73cce62f..80dcc91c98 100755 --- a/configure +++ b/configure @@ -352,6 +352,7 @@ pie="" qom_cast_debug="yes" trace_backends="log"

[Qemu-devel] [PATCH v4 01/20] instrument: Add documentation

Signed-off-by: Lluís Vilanova --- MAINTAINERS |6 ++ docs/instrument.txt | 174 +++ 2 files changed, 180 insertions(+) create mode 100644 docs/instrument.txt diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH v4 2/3] watchdog.h: Drop local redefinition of actions enum

Eric Blake writes: > On 09/06/2017 06:24 AM, Michal Privoznik wrote: >> We already have enum that enumerates all the action that a > > s/action/actions/ > >> watchdog can take when hitting its timeout: WatchdogAction. >> Use that instead of inventing our own. >> >>

[Qemu-devel] [PATCH v4 00/20] instrument: Add basic event instrumentation

This series adds an API to add instrumentation events. It also provides additional APIs for: * Controlling tracing events * Peek/poke guest memory There's still missing APIs for (can be added in later series?): * Provide something like tracing's per-vCPU trace states (i.e., so that each vCPU

Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on the fly

Eric Blake writes: > On 09/06/2017 06:24 AM, Michal Privoznik wrote: >> Currently, the only time that users can set watchdog action is at >> the start as all we expose is this -watchdog-action command line >> argument. This is suboptimal when users want to plug the device >>

[Qemu-devel] [PATCH v3 00/21] instrument: Add basic event instrumentation

This series adds an API to add instrumentation events. It also provides additional APIs for: * Controlling tracing events * Peek/poke guest memory There's still missing APIs for (can be added in later series?): * Provide something like tracing's per-vCPU trace states (i.e., so that each vCPU

Re: [Qemu-devel] [PATCH v2 00/19] s390x cleanups and CPU hotplug via device_add

On 09/06/2017 12:03 PM, David Hildenbrand wrote: > On 05.09.2017 09:51, Christian Borntraeger wrote: >> I think we certainly want to have device_add as well (as long as the old >> interface stays for a while). >> >> Adding Matt. Can you have a look at the cpu hotplug bits? > > If there is no

Re: [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error

On 09/06/2017 06:51 AM, Juan Quintela wrote: > So far, we had to free the error after each caller, so just do it > here. Once there, tls.c was leaking the error. You mention tls.c, > > Signed-off-by: Juan Quintela > --- > migration/channel.c | 1 - >

[Qemu-devel] [PULL 30/32] target/arm: Move ss check to init_disas_context

From: Richard Henderson We can check for single-step just once. Reviewed-by: Emilio G. Cota Reviewed-by: Lluís Vilanova Signed-off-by: Richard Henderson --- target/arm/translate.c | 13 - 1 file changed, 8

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations

On 09/06/2017 10:02 AM, Eduardo Habkost wrote: > On Wed, Sep 06, 2017 at 03:00:41PM +0200, Kevin Wolf wrote: >> Am 30.08.2017 um 19:01 hat Jeff Cody geschrieben: >>> From: Jeffrey Cody >>> >>> If configured without live block operations enabled, unregister the >>> live block

[Qemu-devel] [PULL 27/32] target/arm: [tcg,a64] Port to disas_log

From: Lluís Vilanova Incrementally paves the way towards using the generic instruction translation loop. Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Lluís Vilanova Message-Id:

[Qemu-devel] [PULL 29/32] target/arm: [a64] Move page and ss checks to init_disas_context

From: Richard Henderson Since AArch64 uses a fixed-width ISA, we can pre-compute the number of insns remaining on the page. Also, we can check for single-step once. Reviewed-by: Emilio G. Cota Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions"

On Wed, Sep 06, 2017 at 04:42:18PM +0200, Juan Quintela wrote: > Eric Blake wrote: > > On 09/06/2017 06:51 AM, Juan Quintela wrote: > >> This reverts commit d4622e55883211072621958d39ddaa73483d201e. > > > > But with no reason why? What bugs are you fixing by reverting this? >

[Qemu-devel] [PULL 21/32] target/arm: [tcg, a64] Port to breakpoint_check

From: Lluís Vilanova Incrementally paves the way towards using the generic instruction translation loop. Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Lluís Vilanova Message-Id:

[Qemu-devel] [PULL 22/32] target/arm: [tcg] Port to translate_insn

From: Lluís Vilanova Incrementally paves the way towards using the generic instruction translation loop. Reviewed-by: Emilio G. Cota Signed-off-by: Lluís Vilanova Message-Id: <150002485863.22386.13949856269576226529.st...@frigg.lan>

Re: [Qemu-devel] [PATCH 5/5] s390x/ccs: add ccw-tester emulated device

On 09/06/2017 05:20 PM, Cornelia Huck wrote: > On Wed, 6 Sep 2017 16:24:13 +0200 > Halil Pasic wrote: > >> On 09/06/2017 03:18 PM, Cornelia Huck wrote: >>> On Tue, 5 Sep 2017 13:16:45 +0200 >>> Halil Pasic wrote: >>> Add a fake

[Qemu-devel] [PULL 16/32] target/arm: [tcg] Port to init_disas_context

From: Lluís Vilanova Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé Message-Id:

[Qemu-devel] [PULL 15/32] target/arm: [tcg] Port to DisasContextBase

From: Lluís Vilanova Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson Reviewed-by: Alex Benneé Message-Id:

Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions"

On 09/06/2017 09:42 AM, Juan Quintela wrote: > Eric Blake wrote: >> On 09/06/2017 06:51 AM, Juan Quintela wrote: >>> This reverts commit d4622e55883211072621958d39ddaa73483d201e. >> >> But with no reason why? What bugs are you fixing by reverting this? > > I put it on the

[Qemu-devel] [PULL 32/32] target/arm: Perform per-insn cross-page check only for Thumb

From: Richard Henderson ARM is a fixed-length ISA and we can compute the page crossing condition exactly once during init_disas_context. Reviewed-by: Emilio G. Cota Signed-off-by: Richard Henderson --- target/arm/translate.c | 58

  1   2   3   4   >