Re: [Qemu-devel] ping RE: question: I found a qemu crash about migration

2017-09-28 Thread Dr. David Alan Gilbert
* wangjie (P) (wangji...@huawei.com) wrote: > Ping? > > From: wangjie (P) > Sent: Tuesday, September 26, 2017 9:10 PM > To: qemu-devel@nongnu.org; kw...@redhat.com; pbonz...@redhat.com > Cc: wangjie (P) ; fuweiwei (C) ; > ebl...@redhat.com;

[Qemu-devel] [PATCH v4 9/9] disas: Add capstone as submodule

2017-09-28 Thread Richard Henderson
Do not require the submodule, but use it if present (in preference even to a system copy). This will allow us to easily use capstone in older systems for which a package is not available, and also easily track bug fixes from upstream. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v4 8/9] disas: Remove monitor_disas_is_physical

2017-09-28 Thread Richard Henderson
Even though there is only one monitor, and thus no race on this global data object, there is also no point in having it. We can just as well record the decision in the read_memory_function that we select. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v4 7/9] ppc: Support Capstone in disas_set_info

2017-09-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas.c | 4 target/ppc/translate_init.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/disas.c b/disas.c index 23c4742f8d..0d212f2ac5 100644 --- a/disas.c +++ b/disas.c @@ -449,6 +449,10 @@

[Qemu-devel] [PATCH v4 6/9] arm: Support Capstone in disas_set_info

2017-09-28 Thread Richard Henderson
Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 3 +++ target/arm/cpu.c | 21 ++--- 2 files changed, 21 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v4 2/9] target/ppc: Convert to disas_set_info hook

2017-09-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 33 - monitor.c | 5 - target/ppc/translate.c | 5 + target/ppc/translate_init.c |

[Qemu-devel] [PATCH v4 3/9] disas: Remove unused flags arguments

2017-09-28 Thread Richard Henderson
Now that every target is using the disas_set_info hook, the flags argument is unused. Remove it. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/disas/disas.h | 4 ++-- include/exec/log.h| 4 ++--

[Qemu-devel] [PATCH v4 5/9] i386: Support Capstone in disas_set_info

2017-09-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 4 target/i386/cpu.c | 7 +++ 2 files changed, 11 insertions(+) diff --git a/disas.c b/disas.c index 746d76c07d..1c44514254 100644 --- a/disas.c +++

[Qemu-devel] [PATCH v4 0/9] Support the Capstone disassembler

2017-09-28 Thread Richard Henderson
Changes since v3: * Adjust how the submodule is detected and invoked. - This should fix the reported patchew failure, - Fixes e.g. -m32 "cross" compilation, or similar abi-changing option sets. r~ Richard Henderson (9): target/i386: Convert to disas_set_info hook

[Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler library

2017-09-28 Thread Richard Henderson
If configured, prefer this over our rather dated copy of the GPLv2-only binutils. This will be especially apparent with the proposed vector extensions to TCG, as disas/i386.c does not handle AVX. Signed-off-by: Richard Henderson --- include/disas/bfd.h | 4

[Qemu-devel] [PATCH v4 1/9] target/i386: Convert to disas_set_info hook

2017-09-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- disas.c | 22 ++ monitor.c | 21 - target/i386/cpu.c | 12 target/i386/translate.c | 8

Re: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 12:47:51PM -0400, Programmingkid wrote: > > > This patch series is an update to: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html > > v3:

[Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Programmingkid
> This patch series is an update to: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html > v4:

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-28 Thread Halil Pasic
On 09/28/2017 05:19 PM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 19:23:12 +0200 > Halil Pasic wrote: > >> Jason found some problems with 3270 which he traced down to insufficient >> output buffer size. I've looked into the underlying issue (and the >> relevant code)

Re: [Qemu-devel] [PATCH 0/2] 3270 improvements

2017-09-28 Thread Cornelia Huck
On Wed, 20 Sep 2017 19:23:12 +0200 Halil Pasic wrote: > Jason found some problems with 3270 which he traced down to insufficient > output buffer size. I've looked into the underlying issue (and the > relevant code) and I saw strange things. Among others an unreasonable

Re: [Qemu-devel] [PATCH v4 02/23] block: Add flag to avoid wasted work in bdrv_is_allocated()

2017-09-28 Thread Eric Blake
On 09/26/2017 01:31 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> Not all callers care about which BDS owns the mapping for a given >> range of the file. In particular, bdrv_is_allocated() cares more >> about finding the largest run of allocated data from the guest >>

Re: [Qemu-devel] [PATCH] docker: Don't mount ccache db if NOUSER=1

2017-09-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On Mon, Sep 25, 2017 at 4:54 AM, Fam Zheng wrote: >> With NOUSER=1 the container runs code as root, which may create >> privileged files that will not be be accssible next time. Skip ccache >> dir mount in this case. >> >>

Re: [Qemu-devel] [PATCH v3 2/3] s390x/ais: enable ais when migration is available

2017-09-28 Thread Cornelia Huck
On Wed, 27 Sep 2017 09:20:29 +0200 Christian Borntraeger wrote: > Instead of unconditionally enabling the KVM AIS capability > in the kvm arch init function, do this in the flic realize function > when we know if migration is available. This requires to initialize > flic

Re: [Qemu-devel] [PATCH] Revert "s390x/ccw: create s390 phb conditionally"

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 15:18:31 +0200 Christian Borntraeger wrote: > This reverts commit d32bd032d8fde41281aae34c16a4aa97e9acfeac. > > Turns out that old QEMUs always created a pci host bridge > and for many CPU models the migration from old QEMUs to new > QEMUs will fail

[Qemu-devel] ehci warning: guest requested more bytes than allowed

2017-09-28 Thread Hongyi Zhao
Hi all, I use the lastest git version of qemu on Debian stretch, then I install the masos sierra as the guest. When I run the macos guest by using the qemu-system-x86_64 from command line, I always see the following info: --- ehci warning: guest requested more bytes than

Re: [Qemu-devel] [PATCH] fixup! scripts: Remove debug parameter from QEMUMonitorProtocol

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 11:33:57AM +0200, Lukáš Doktor wrote: > Dne 27.9.2017 v 15:44 Eduardo Habkost napsal(a): > > On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote: > >> On Wed, 09/27 10:03, Eduardo Habkost wrote: > >>> @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object): > >>>

Re: [Qemu-devel] [PATCH v1 1/5] MAINTAINERS: use KVM s390x maintainers for kvm-stubs.c and kvm_s390x.h

2017-09-28 Thread Christian Borntraeger
On 09/28/2017 03:46 PM, David Hildenbrand wrote: > Forgot it when factoring code out into these files. This is 100% s390x > KVM material. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > MAINTAINERS | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH] Revert "s390x/ccw: create s390 phb conditionally"

2017-09-28 Thread David Hildenbrand
On 28.09.2017 15:18, Christian Borntraeger wrote: > This reverts commit d32bd032d8fde41281aae34c16a4aa97e9acfeac. > > Turns out that old QEMUs always created a pci host bridge > and for many CPU models the migration from old QEMUs to new > QEMUs will fail with > qemu-system-s390x: Unknown savevm

[Qemu-devel] [PATCH v1 5/5] s390x: introduce and use S390_MAX_CPUS

2017-09-28 Thread David Hildenbrand
Will be handy in the future. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 +- target/s390x/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v1 1/5] MAINTAINERS: use KVM s390x maintainers for kvm-stubs.c and kvm_s390x.h

2017-09-28 Thread David Hildenbrand
Forgot it when factoring code out into these files. This is 100% s390x KVM material. Signed-off-by: David Hildenbrand --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 932443df41..772ac209e1 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH v1 4/5] target/s390x: get rid of next_core_id

2017-09-28 Thread David Hildenbrand
core_id is not needed by linux-user, as the core_id a.k.a. CPU address is only accessible from kernel space. Therefore, drop next_core_id and make cpu_index get autoassigned again for linux-user. While at it, shield core_id and cpuid completely from linux-user. cpuid can also only be queried

[Qemu-devel] [PATCH v1 2/5] s390x: raise CPU hotplug irq after really hotplugged

2017-09-28 Thread David Hildenbrand
Let's move it into the machine, so we trigger the IRQ after setting ms->possible_cpus (which SCLP uses to construct the list of online CPUs). This also fixes a problem reported by Thomas Huth, whereby qemu can be crashed using the none machine qemu-s390x-softmmu -M none -monitor stdio ->

[Qemu-devel] [PATCH v1 3/5] s390x/cpumodel: fix max STFL(E) bit number

2017-09-28 Thread David Hildenbrand
Not that it would matter in the near future, but it is actually 2048 bytes, therefore 16384 possible bits. Reviewed-by: Christian Borntraeger Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/cpu_features.c |

[Qemu-devel] [PATCH v1 0/5] s390x: CPU related cleanups and one fix

2017-09-28 Thread David Hildenbrand
Patch 2-5 are split out from the series "[PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)" They make sense even without the SMP TCG changes, which could still take a while. David Hildenbrand (5): MAINTAINERS: use KVM s390x maintainers for kvm-stubs.c and kvm_s390x.h s390x: raise CPU hotplug

Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add

2017-09-28 Thread David Hildenbrand
On 28.09.2017 08:01, Thomas Huth wrote: > On 13.09.2017 15:24, David Hildenbrand wrote: >> E.g. the following now works: >> device_add host-s390-cpu,id=cpu1,core-id=1 > > Hi David, > > FYI, this introduced a possibility to crash QEMU with the none machine: > > $

Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell frontends

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 11:15:47AM +0200, Lukáš Doktor wrote: [...] > > @@ -231,6 +239,7 @@ class PlotShell(object): > > > > def run(self, argv): > > args = self._parser.parse_args(argv) > > This class is not inherited from the `BaseShell`, therefor it > does not contain

[Qemu-devel] [PATCH] Revert "s390x/ccw: create s390 phb conditionally"

2017-09-28 Thread Christian Borntraeger
This reverts commit d32bd032d8fde41281aae34c16a4aa97e9acfeac. Turns out that old QEMUs always created a pci host bridge and for many CPU models the migration from old QEMUs to new QEMUs will fail with qemu-system-s390x: Unknown savevm section or instance 'PCIBUS' 0 qemu-system-s390x: load of

Re: [Qemu-devel] [PATCH v2 0/5] Mark conventional/PCIe/hybrid PCI devices using interface names

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 12:39:23PM +0300, Marcel Apfelbaum wrote: > On 27/09/2017 22:56, Eduardo Habkost wrote: > > Changes v1 -> v2: > > * Use "Conventional PCI" instead of "legacy PCI" > >* Suggested-by: Alex Williamson > > * Mark base-xhci as hybrid too > >*

Re: [Qemu-devel] [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > >>> On 27.09.17 at 21:56, wrote: > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > > .instance_size =

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5] vl: exit if maxcpus is negative

2017-09-28 Thread seeteena
Thanks Thomas. Since you already put them on cc. I will wait for the response. On 09/25/2017 02:21 PM, Thomas Huth wrote: On 25.09.2017 10:43, seeteena wrote: Hi Philippe, I have not seen patch went upstream.. You need to get the attention of a maintainer who could pick up the patch,

Re: [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support

2017-09-28 Thread David Hildenbrand
On 28.09.2017 06:50, Thomas Huth wrote: > On 27.09.2017 19:00, David Hildenbrand wrote: >> This is a neat way to implement low address protection, whereby >> only the first 512 bytes of the first two pages (each 4096 bytes) of >> every address space are protected. >> >> Store a tec of 0 for the

Re: [Qemu-devel] [PATCH v2 2/5] pci: Add interface names to hybrid PCI devices

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 02:08:09PM +1000, David Gibson wrote: > On Wed, Sep 27, 2017 at 04:56:32PM -0300, Eduardo Habkost wrote: > > The following devices support both PCI Express and Conventional > > PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS > > flag and/or conditional

[Qemu-devel] [PATCH] iotests: test clearing unknown autoclear_features by qcow2

2017-09-28 Thread Vladimir Sementsov-Ogievskiy
Test clearing unknown autoclear_features by qcow2 on incoming migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Here is a test, related to this problem, which fails with SIGABRT on master and is successful on 2.9 I've tried to fix it by some interchanges in

Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add

2017-09-28 Thread David Hildenbrand
On 28.09.2017 08:01, Thomas Huth wrote: > On 13.09.2017 15:24, David Hildenbrand wrote: >> E.g. the following now works: >> device_add host-s390-cpu,id=cpu1,core-id=1 > > Hi David, > > FYI, this introduced a possibility to crash QEMU with the none machine: > > $

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Cédric Le Goater
On 09/28/2017 12:03 PM, Benjamin Herrenschmidt wrote: > On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote: >> probably, I just removed the properties under QEMU and could >> boot the guest, with disks and network. > > As long as you don't use LSIs... That I didn't test much. Which the

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-28 Thread Eduardo Habkost
(CCing libvir-list) On Thu, Sep 28, 2017 at 12:42:02PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > > Both -nodefconfig and -no-user-config options do the same thing > > today, we only need one variable to keep track of them. > > What

[Qemu-devel] [Bug 1583784] Re: qio_task_free segfault websocket

2017-09-28 Thread Daniel Berrange
*** This bug is a duplicate of bug 1589923 *** https://bugs.launchpad.net/bugs/1589923 ** This bug has been marked a duplicate of bug 1589923 https websockets not working in 2.5 or 2.6 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread David Hildenbrand
>> In the end that means that you should revert >> >> commit d32bd032d8fde41281aae34c16a4aa97e9acfeac >> Author: Cornelia Huck >> AuthorDate: Thu Jul 6 17:21:52 2017 +0200 >> Commit: Cornelia Huck >> CommitDate: Wed Aug 30 18:23:25 2017 +0200 >> >>

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 14:17:54 +0200 Christian Borntraeger wrote: > I see no point if PCI disable machines. There is no non-PCI x86 machine > besides the isapc. But this has no version whatsoever so it certainly > is not made for being migrated. > As far as I can see and we

Re: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule Message-id: 20170928120621.30288-1-berra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/28/2017 02:07 PM, Cornelia Huck wrote: > On Thu, 28 Sep 2017 12:41:54 +0200 > Christian Borntraeger wrote: > >> On 09/28/2017 12:34 PM, Christian Borntraeger wrote: >>> >>> >>> On 09/27/2017 05:03 PM, Cornelia Huck wrote: On Wed, 27 Sep 2017 15:49:27 +0100

[Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycodemapdb

2017-09-28 Thread Daniel P. Berrange
Replace the number_to_qcode, qcode_to_number and linux_to_qcode tables with automatically generated tables. Missing entries in linux_to_qcode now fixed: KEY_LINEFEED -> Q_KEY_CODE_LF KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS KEY_COMPOSE -> Q_KEY_CODE_COMPOSE KEY_AGAIN -> Q_KEY_CODE_AGAIN

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 12:41:54 +0200 Christian Borntraeger wrote: > On 09/28/2017 12:34 PM, Christian Borntraeger wrote: > > > > > > On 09/27/2017 05:03 PM, Cornelia Huck wrote: > >> On Wed, 27 Sep 2017 15:49:27 +0100 > >> "Dr. David Alan Gilbert"

[Qemu-devel] [PATCH v7 6/6] ui: don't export qemu_input_event_new_key

2017-09-28 Thread Daniel P. Berrange
All public code should use qemu_input_event_send_key* functions instead of creating an event directly. Signed-off-by: Daniel P. Berrange --- include/ui/input.h | 1 - ui/input.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ui/input.h

[Qemu-devel] [PATCH v7 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Daniel P. Berrange
When building the tarball to pass into the docker/vm test image, the code relies on the git submodules being checked out in the main checkout. ie if the developer has not run 'git submodule update --init dtc' many of the docker tests will fail due to the libfdt package not being present in the

[Qemu-devel] [PATCH v7 5/6] ui: convert key events to QKeyCodes immediately

2017-09-28 Thread Daniel P. Berrange
Always use QKeyCode in the InputKeyEvent struct, by converting key numbers to QKeyCode at the time the event is created. This allows the code processing / consuming key events to assume QKeyCode is used. The only place we accept a key number in the InputKeyEvent struct is with QMP commands sent by

[Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
This patch series is an update to: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html v4:

[Qemu-devel] [PATCH v7 3/6] ui: add keycodemapdb repository as a GIT submodule

2017-09-28 Thread Daniel P. Berrange
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a data file mapping between all the different scancode/keycode/keysym sets that are known, and a tool to auto-generate lookup tables for different combinations. It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys. Using it in

[Qemu-devel] [PATCH v7 1/6] build: automatically handle GIT submodule checkout for dtc

2017-09-28 Thread Daniel P. Berrange
Currently if DTC is required by configure and not available in the host OS install, we exit with an error message telling the user to checkout a git submodule or install the library. This introduces automatic handling of the git submodule checkout process and enables it for dtc. This only runs if

Re: [Qemu-devel] [Qemu-stable] [PATCH] migration: disable auto-converge during bulk block migration

2017-09-28 Thread Peter Lieven
Am 25.09.2017 um 22:53 schrieb Michael Roth: Quoting Peter Lieven (2017-09-21 07:32:32) auto-converge and block migration currently do not play well together. During block migration the auto-converge logic detects that ram migration makes no progress and thus throttles down the vm until it

[Qemu-devel] [PATCH] block/mirror: check backing in bdrv_mirror_top_refresh_filename

2017-09-28 Thread Vladimir Sementsov-Ogievskiy
Backing may be zero after failed bdrv_attach_child in bdrv_set_backing_hd, which leads to SIGSEGV. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. We have faced into this SIGSEGV because of image locking: trying to call qemu-img commit on locked image leads to

Re: [Qemu-devel] [PATCH v9 8/8] tpm: Added support for TPM emulator

2017-09-28 Thread Marc-André Lureau
Hi On Thu, Sep 28, 2017 at 11:20 AM, Amarnath Valluri wrote: > This change introduces a new TPM backend driver that can communicate with > swtpm(software TPM emulator) using unix domain socket interface. QEMU talks to > TPM emulator using QEMU's socket-based chardev

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 12:42:02PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > > Both -nodefconfig and -no-user-config options do the same thing > > today, we only need one variable to keep track of them. > > What reason for picking

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > Both -nodefconfig and -no-user-config options do the same thing > today, we only need one variable to keep track of them. What reason for picking -nodefconfig instead of -no-user-config to deprecate ? -nodefconfig predates

Re: [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig

2017-09-28 Thread Daniel P. Berrange
On Wed, Sep 27, 2017 at 05:32:23PM -0300, Eduardo Habkost wrote: > Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we > have no default config files that would be disabled using > -nodefconfig. This series cleans up the code, updates > documentation, and document -nodefconfig as

Re: [Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig

2017-09-28 Thread Paolo Bonzini
On 27/09/2017 22:32, Eduardo Habkost wrote: > Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we > have no default config files that would be disabled using > -nodefconfig. This series cleans up the code, updates > documentation, and document -nodefconfig as deprecated. Don't

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/28/2017 12:34 PM, Christian Borntraeger wrote: > > > On 09/27/2017 05:03 PM, Cornelia Huck wrote: >> On Wed, 27 Sep 2017 15:49:27 +0100 >> "Dr. David Alan Gilbert" wrote: >> >>> * Cornelia Huck (coh...@redhat.com) wrote: On Wed, 27 Sep 2017 15:28:38 +0100

[Qemu-devel] [PATCH v5 6/6] migration: Block migration while handling machine check

2017-09-28 Thread Aravinda Prasad
Block VM migration requests until the machine check error handling is complete as (i) these errors are specific to the source hardware and is irrelevant on the target hardware, (ii) these errors cause data corruption and should be handled before migration. Signed-off-by: Aravinda Prasad

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > > respective qmp command most of `info

[Qemu-devel] [PATCH v5 5/6] ppc: spapr: Enable FWNMI capability

2017-09-28 Thread Aravinda Prasad
Enable the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. Signed-off-by:

[Qemu-devel] [PATCH v5 4/6] target/ppc: Handle NMI guest exit

2017-09-28 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI

[Qemu-devel] [PATCH v5 2/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-09-28 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the

[Qemu-devel] [PATCH v5 3/6] Wrapper function to wait on condition for the main loop mutex

2017-09-28 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. Signed-off-by: Aravinda Prasad --- cpus.c |5 +

[Qemu-devel] [PATCH v5 1/6] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-09-28 Thread Aravinda Prasad
Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] (commit f9a60de3) adds functionality to invoke a private HCALL whenever OS issues instantiate-rtas with a new rtas-base. This is required as QEMU needs to know the updated rtas-base as it allocates error

[Qemu-devel] [PATCH v5 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-09-28 Thread Aravinda Prasad
This series of patches adds support for FWNMI in PowerKVM guests. Memory error such as bit flips that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exception, if the address in error belongs to guest

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-28 Thread Christian Borntraeger
On 09/27/2017 05:03 PM, Cornelia Huck wrote: > On Wed, 27 Sep 2017 15:49:27 +0100 > "Dr. David Alan Gilbert" wrote: > >> * Cornelia Huck (coh...@redhat.com) wrote: >>> On Wed, 27 Sep 2017 15:28:38 +0100 >>> "Dr. David Alan Gilbert" wrote: >>>

Re: [Qemu-devel] [PATCH] default-configs: Enable CONFIG_VMXNET3_PCI only on x86

2017-09-28 Thread Dmitry Fleytman
> On 28 Sep 2017, at 12:52 PM, Thomas Huth wrote: > > The device can not be instantiated on many non-x86 and just prints > some error messages, e.g.: > > $ qemu-system-ppc64 -device vmxnet3 -M g3beige > [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 >

Re: [Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal iothreads

2017-09-28 Thread Stefan Hajnoczi
On Thu, Sep 28, 2017 at 10:59:53AM +0800, Peter Xu wrote: > v4: > - fix comment in patch 1 [Fam, Stefan] > - add one more patch from Stefan to fix the aio glib warning > > v3: > - pick up r-bs (one missing for Fam's on last patch) > - fix patch 1 to create isolated internal container > > v2: > -

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > > > > The command is designed for debugging and produces quite sightly output. For > > respective

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 02:05:37AM +0300, Jan Dakinevich wrote: > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and >

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Cornelia Huck
On Thu, 28 Sep 2017 12:02:35 +0200 Kevin Wolf wrote: > Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > > OK but if it's useful as an hmp command, why not as a qmp command? > > > > The command is designed for debugging and produces quite sightly output. For > >

Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree support

2017-09-28 Thread Benjamin Herrenschmidt
On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote: > probably, I just removed the properties under QEMU and could > boot the guest, with disks and network. As long as you don't use LSIs... > > > Do you have a DT snapshot from pHyp for me to look at ? > > > # lsprop

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-28 Thread Kevin Wolf
Am 28.09.2017 um 01:05 hat Jan Dakinevich geschrieben: > > OK but if it's useful as an hmp command, why not as a qmp command? > > The command is designed for debugging and produces quite sightly output. For > respective qmp command most of `info virtio' output would excessive and > unneccesary.

Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy

2017-09-28 Thread Stefan Hajnoczi
On Thu, Sep 28, 2017 at 10:59:58AM +0800, Peter Xu wrote: > From: Stefan Hajnoczi > > After iothread is enabled internally inside QEMU with GMainContext, we > may encounter this warning when destroying the iothread: > > (qemu-system-x86_64:19925): GLib-CRITICAL **:

[Qemu-devel] [PATCH] default-configs: Enable CONFIG_VMXNET3_PCI only on x86

2017-09-28 Thread Thomas Huth
The device can not be instantiated on many non-x86 and just prints some error messages, e.g.: $ qemu-system-ppc64 -device vmxnet3 -M g3beige [vmxnet3][WR][vmxnet3_init_msix]: Failed to initialize MSI-X, error -95 [vmxnet3][WR][vmxnet3_pci_realize]: Failed to initialize MSI-X, configuration is

Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 05:44:53PM +0800, Fam Zheng wrote: > On Thu, 09/28 09:44, Daniel P. Berrange wrote: > > When building the tarball to pass into the docker/vm test image, > > the code relies on the git submodules being checked out in the > > main checkout. > > > > ie if the developer has

Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

2017-09-28 Thread Fam Zheng
On Thu, 09/28 09:44, Daniel P. Berrange wrote: > When building the tarball to pass into the docker/vm test image, > the code relies on the git submodules being checked out in the > main checkout. > > ie if the developer has not run 'git submodule update --init dtc' > most (all?) of the docker

Re: [Qemu-devel] [PATCH v2 0/5] Mark conventional/PCIe/hybrid PCI devices using interface names

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Changes v1 -> v2: * Use "Conventional PCI" instead of "legacy PCI" * Suggested-by: Alex Williamson * Mark base-xhci as hybrid too * Reported-by: Marcel Apfelbaum * Mark pcie-pci-bridge as PCI

Re: [Qemu-devel] [PATCH v2 5/5] pci: Validate interfaces on base_class_init

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Make sure we don't forget to add the Conventional PCI or PCI Express interface names on PCI device classes in the future. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * s/legacy/conventional/ * Suggested-by: Alex

Re: [Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI

Re: [Qemu-devel] [PATCH] fixup! scripts: Remove debug parameter from QEMUMonitorProtocol

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:44 Eduardo Habkost napsal(a): > On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote: >> On Wed, 09/27 10:03, Eduardo Habkost wrote: >>> @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object): >>> """ >>> self.__events = [] >>> self.__address =

[Qemu-devel] [PATCH v3 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-28 Thread Pavel Butsykin
Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find the last used cluster and cut the tail. Signed-off-by: Pavel Butsykin Reviewed-by: John Snow --- block/qcow2-refcount.c

Re: [Qemu-devel] [PATCH v2 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Change all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE. Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Dmitry Fleytman Cc: Jason Wang

[Qemu-devel] [PATCH v3 0/2] Truncate the tail of the image file in qcow2 shrinking

2017-09-28 Thread Pavel Butsykin
Now after shrinking the qcow2 image, at the end of the image file, there might be a tail that probably will never be used. Although it will not bring any tangible benefit, we can cut the tail if it is. Yes, it will not free up disk space, but if the blocks were be allocated sequentially and the

[Qemu-devel] [PATCH v3 1/2] qcow2: fix return error code in qcow2_truncate()

2017-09-28 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c

Re: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule

2017-09-28 Thread Daniel P. Berrange
On Thu, Sep 28, 2017 at 01:53:25AM -0700, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Type: series > Subject: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT > submodule > Message-id:

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-28 Thread Linu Cherian
On Thu Sep 28, 2017 at 09:54:20AM +0200, Auger Eric wrote: > Hi Linu, Peter, > > On 28/09/2017 09:13, Peter Xu wrote: > > On Thu, Sep 28, 2017 at 12:13:12PM +0530, Linu Cherian wrote: > >> Hi Eric, > >> > >> > >> On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > >>> This series

Re: [Qemu-devel] [PATCH v2 2/5] pci: Add interface names to hybrid PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 28/09/2017 7:08, David Gibson wrote: On Wed, Sep 27, 2017 at 04:56:32PM -0300, Eduardo Habkost wrote: The following devices support both PCI Express and Conventional PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS flag and/or conditional pcie_endpoint_cap_init() calls: *

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-28 Thread Marcel Apfelbaum
On 28/09/2017 10:31, Mark Cave-Ayland wrote: On 25/09/17 09:11, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (mar...@redhat.com) wrote: On 23/09/2017 11:23, Mark Cave-Ayland wrote: On 22/09/17 23:18, Laszlo Ersek wrote: On 09/22/17 14:18, Mark Cave-Ayland wrote: Whilst the underlying

[Qemu-devel] [PATCH v9 4/8] tpm-backend: Made few interface methods optional

2017-09-28 Thread Amarnath Valluri
This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Took the opportunity to remove unused methods: - tpm_backend_get_desc() - TPMDriverOps->handle_startup_error Signed-off-by: Amarnath Valluri

Re: [Qemu-devel] [PATCH 3/5] basevm: Call logging.basicConfig()

2017-09-28 Thread Lukáš Doktor
Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > Just setting level=DEBUG when debug is enabled is not enough: we > need to set up a log handler if we want debug messages generated > using logging.getLogger(...).debug() to be printed. > > This was not a problem before because logging.debug()

[Qemu-devel] [PATCH v9 8/8] tpm: Added support for TPM emulator

2017-09-28 Thread Amarnath Valluri
This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. QEMU talks to TPM emulator using QEMU's socket-based chardev backend device. Swtpm uses two Unix sockets for communications, one for plain TPM commands and

[Qemu-devel] [PATCH v9 2/8] tpm-backend: Move thread handling inside TPMBackend

2017-09-28 Thread Amarnath Valluri
Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_backend_int.h kind of useless, hence removed it.

[Qemu-devel] [PATCH v9 5/8] tmp backend: Add new api to read backend TpmInfo

2017-09-28 Thread Amarnath Valluri
TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., which shall be implemented by the derived classes to

[Qemu-devel] [PATCH v9 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model

2017-09-28 Thread Amarnath Valluri
buffer reallocation is very unlikely to be backend specific. Hence move inside the tis. Signed-off-by: Amarnath Valluri Reviewed-by: Stefan Berger Reviewed-by: Marc-André Lureau --- backends/tpm.c

  1   2   >