[Qemu-devel] ping Re: [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

2018-02-05 Thread Abdallah Bouassida
ping http://patchwork.ozlabs.org/patch/867467/ [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers.

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-05 Thread Markus Armbruster
Eric Blake writes: > On 02/03/2018 03:08 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 02/02/2018 07:03 AM, Markus Armbruster wrote: Error messages print absolute filenames of included files even gave a >>> >>> s/even gave/even when

Re: [Qemu-devel] [PATCH] migration: incoming postcopy advise sanity checks

2018-02-05 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 10:26, Greg Kurz wrote: If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour

[Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

2018-02-05 Thread Christian Borntraeger
This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used by all s390

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

2018-02-05 Thread Markus Armbruster
Eric Blake writes: > On 02/03/2018 03:03 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 02/02/2018 07:03 AM, Markus Armbruster wrote: Whenever qapi-schema.json changes, we run six programs eleven times to update eleven files. This

[Qemu-devel] [PATCH v2] pci/bus: let it has higher migration priority

2018-02-05 Thread Peter Xu
In the past, we prioritized IOMMU migration so that we have such a priority order: IOMMU > PCI Devices When migrating a guest with both vIOMMU and a pcie-root-port, we'll always migrate vIOMMU first, since pci buses will be seen to have the same priority of general PCI devices. That's

Re: [Qemu-devel] [PATCH v3 42/45] pc-bios: Add hppa-firmware.img and git submodule

2018-02-05 Thread Helge Deller
On 04.02.2018 23:40, Philippe Mathieu-Daudé wrote: > Hi Helge, Hi Philippe, > On 01/24/2018 08:26 PM, Richard Henderson wrote: >> Signed-off-by: Richard Henderson >> --- >> Makefile | 3 ++- >> .gitmodules | 3 +++ >>

Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc

2018-02-05 Thread Markus Armbruster
Eric Blake writes: > On 02/03/2018 02:49 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 02/02/2018 07:03 AM, Markus Armbruster wrote: These classes encapsulate accumulating and writing output. Convert C code generation to

Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-05 Thread Markus Armbruster
Zhang Chen writes: > On Sat, Feb 3, 2018 at 3:49 PM, Markus Armbruster wrote: > >> Zhang Chen writes: >> >> > From: zhanghailiang >> > >> > If some errors happen during VM's COLO FT stage, it's

[Qemu-devel] [PATCH] migration: incoming postcopy advise sanity checks

2018-02-05 Thread Greg Kurz
If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour was introduced in 2.11 by commit

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 04/12] s390-ccw: update libc

2018-02-05 Thread Thomas Huth
On 05.02.2018 21:57, Collin L. Walling wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > isdigit > > Added non C-standard function: > itostr > atoui > > Signed-off-by: Collin

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-05 Thread Thomas Huth
On 05.02.2018 21:57, Collin L. Walling wrote: > Add new cylinder/head/sector struct. Use it to calculate > eckd block numbers instead of a BootMapPointer (which used > eckd chs anyway). > > Signed-off-by: Collin L. Walling > --- > pc-bios/s390-ccw/bootmap.c | 28

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-05 Thread Thomas Huth
On 05.02.2018 21:57, Collin L. Walling wrote: > - replace ScsiMbr in ECKD code with BootMapTable > - fix read_block messages to reflect BMT > - reduce ipl_scsi code with BMT struct > > Signed-off-by: Collin L. Walling > --- [...] > @@ -449,10 +451,8 @@ static void

[Qemu-devel] [PATCH v2] block/mirror: change the semantic of 'force' of block-job-cancel

2018-02-05 Thread Liang Li
When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. Libvirt depends on the current

Re: [Qemu-devel] [virtio-dev] [PATCH v1 6/6] vhost-user: add VFIO based accelerators support

2018-02-05 Thread Tiwei Bie
On Mon, Feb 05, 2018 at 06:47:51PM +0100, Paolo Bonzini wrote: > On 25/01/2018 05:03, Tiwei Bie wrote: > > The key difference with PCI passthru is that, in this case only > > the data path of the device (e.g. DMA ring, notify region and > > queue interrupt) is pass-throughed to the VM, the device

Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-05 Thread Zhang Chen
On Sat, Feb 3, 2018 at 3:49 PM, Markus Armbruster wrote: > Zhang Chen writes: > > > From: zhanghailiang > > > > If some errors happen during VM's COLO FT stage, it's important to > > notify the users of this event.

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

2018-02-05 Thread Liang Li
On Mon, Feb 05, 2018 at 02:28:55PM -0500, John Snow wrote: > > > On 01/31/2018 09:19 PM, Liang Li wrote: > > On Tue, Jan 30, 2018 at 03:18:31PM -0500, John Snow wrote: > >> > >> > >> On 01/30/2018 03:38 AM, Liang Li wrote: > >>> When doing drive mirror to a low speed shared storage, if there was

[Qemu-devel] [PATCH v2] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-02-05 Thread Changpeng Liu
Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, for multiple I/O queues scenario, all the I/O queues will share one interrupt vector, while here, enable multiple vectors according to the number of I/O queues. Signed-off-by: Changpeng Liu ---

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-02-05 Thread Wang, Wei W
On Tuesday, February 6, 2018 12:26 AM, Stefan Hajnoczi wrote: > On Fri, Feb 02, 2018 at 09:08:44PM +0800, Wei Wang wrote: > > On 02/02/2018 01:08 AM, Michael S. Tsirkin wrote: > > > On Tue, Jan 30, 2018 at 08:09:19PM +0800, Wei Wang wrote: > > > > Issues: > > > > Suppose we have both the vhost and

Re: [Qemu-devel] [PATCH v4 10/22] RISC-V Linux User Emulation

2018-02-05 Thread Michael Clark
On Tue, Feb 6, 2018 at 12:37 AM, Andreas Schwab wrote: > On Feb 05 2018, Michael Clark wrote: > > > diff --git a/linux-user/riscv/syscall_nr.h > b/linux-user/riscv/syscall_nr.h > > new file mode 100644 > > index 000..bd164ef > > --- /dev/null > > +++

Re: [Qemu-devel] virtio-blk discard support

2018-02-05 Thread Liu, Changpeng
Hi Cathy, Actually the code development from my side has been done for a while, include DISCARD/WRITE ZEROES/WRITE ZEROES with Discard Bit, currently I'm writing the specification related changes, I'll send the specification change for review firstly. > -Original Message- > From: Cathy

Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace GICv3 with KVM

2018-02-05 Thread Alistair Francis
On Mon, Feb 5, 2018 at 4:10 PM, Philippe Mathieu-Daudé wrote: > Hi Christoffer, > > On 02/01/2018 05:53 PM, Christoffer Dall wrote: >> KVM doesn't support emulating a GICv3 in userspace, only GICv2. We >> currently attempt this anyway, and as a result a KVM guest doesn't >>

Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace GICv3 with KVM

2018-02-05 Thread Philippe Mathieu-Daudé
Hi Christoffer, On 02/01/2018 05:53 PM, Christoffer Dall wrote: > KVM doesn't support emulating a GICv3 in userspace, only GICv2. We > currently attempt this anyway, and as a result a KVM guest doesn't > receive interrupts and the user is left wondering why. Report an error > to the user if

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/8] hw/intc/armv7m_nvic: Implement cache ID registers

2018-02-05 Thread Philippe Mathieu-Daudé
Hi Peter, On 02/05/2018 07:57 AM, Peter Maydell wrote: > M profile cores have a similar setup for cache ID registers > to A profile: > * Cache Level ID Register (CLIDR) is a fixed value > * Cache Type Register (CTR) is a fixed value > * Cache Size ID Registers (CCSIDR) are a bank of registers;

Re: [Qemu-devel] [Qemu-arm] [PATCH 5/7] target/arm: Make v7m_push_callee_stack() honour MPU

2018-02-05 Thread Philippe Mathieu-Daudé
On 01/30/2018 12:02 PM, Peter Maydell wrote: > Make v7m_push_callee_stack() honour the MPU by using the > new v7m_stack_write() function. We return a flag to indicate > whether the pushes failed, which we can then use in > v7m_exception_taken() to cause us to handle the derived > exception

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/7] target/arm: Split "get pending exception info" from "acknowledge it"

2018-02-05 Thread Philippe Mathieu-Daudé
On 01/30/2018 12:02 PM, Peter Maydell wrote: > Currently armv7m_nvic_acknowledge_irq() does three things: > * make the current highest priority pending interrupt active > * return a bool indicating whether that interrupt is targeting >Secure or NonSecure state > * implicitly tell the caller

[Qemu-devel] ehabkost away between 13/Feb and 4/Mar

2018-02-05 Thread Eduardo Habkost
Hi, This is a heads-up that I will be away from work and QEMU-related activities between 2018-02-13 and 2018-03-04. If there's anything urgent or quick questions, you can ping me at my personal e-mail address: ehabk...@gmail.com. -- Eduardo

[Qemu-devel] [PULL 21/21] docker: change Fedora images to run with python3

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange Message-Id:

[Qemu-devel] [PULL 18/21] input: add missing JIS keys to virtio input

2018-02-05 Thread Eduardo Habkost
From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S Message-Id: <20180116134217.8725-12-berra...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 20/21] travis: improve python version test coverage

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Currently travis declares ancient python 2.4 is desired. Update that to 2.6 which is the oldest version any targetted distros still needs. If we just list a python 3 version at the top level this will double the number of travis jobs we run which

[Qemu-devel] [PULL 17/21] qemu.py: don't launch again before shutdown()

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim If a VM is launched, files are created and a cleanup is required before a new launch. This cleanup is executed by shutdown(), so shutdown() must be called even if the VM is manually terminated (i.e. using kill). This patch creates a control to make sure

[Qemu-devel] [PULL 19/21] ui: update keycodemapdb to get py3 fixes

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange Message-Id: <20180116134217.8725-13-berra...@redhat.com> Signed-off-by: Eduardo Habkost --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 16/21] qemu.py: cleanup redundant calls in launch()

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim Now that shutdown() is guaranteed to always execute self._load_io_log() and self._post_shutdown(), their calls in 'except' became redundant and we can safely replace it by a call to shutdown(). Reviewed-by: Fam Zheng Reviewed-by: Eduardo

[Qemu-devel] [PULL 13/21] qemu.py: refactor launch()

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim This is just a refactor to separate the exception handler from the actual launch procedure, improving the readability and making future maintenances in this piece of code easier. Reviewed-by: Fam Zheng Reviewed-by: Eduardo Habkost

[Qemu-devel] [PULL 15/21] qemu.py: use poll() instead of 'returncode'

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will: "Check if child process has terminated. Set and return returncode attribute." Let's

[Qemu-devel] [PULL 14/21] qemu.py: always cleanup on shutdown()

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim Currently we only cleanup on shutdown() if the VM is running. To make sure we will always cleanup, this patch makes the self._load_io_log() and the self._post_shutdown() to always be called on shutdown(), regardless the VM running state. Reviewed-by: Fam

[Qemu-devel] [PULL 12/21] qemu.py: better control of created files

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim To launch a VM, we need to create basically two files: the monitor socket (if it's a UNIX socket) and the qemu log file. For the qemu log file, we currently just open the path, which will create the file if it does not exist or overwrite the file if it does

[Qemu-devel] [PULL 11/21] qemu.py: remove unused import

2018-02-05 Thread Eduardo Habkost
From: Amador Pahim Removing 'import sys' as it's not used anywhere. Signed-off-by: Amador Pahim Message-Id: <20171114102246.1-2-apa...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 1 - 1 file changed, 1

[Qemu-devel] [PULL 06/21] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful

[Qemu-devel] [PULL 09/21] scripts: ensure signrom treats data as bytes

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange Message-Id: <20180116134217.8725-10-berra...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/signrom.py | 4

[Qemu-devel] [PULL 05/21] qapi: Adapt to moved location of 'maketrans' function in py3

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange Message-Id: <20180116134217.8725-6-berra...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/qapi.py | 5 - 1 file

[Qemu-devel] [PULL 04/21] qapi: adapt to moved location of StringIO module in py3

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange Message-Id: <20180116134217.8725-5-berra...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/qapi.py | 7

[Qemu-devel] [PULL 02/21] qapi: use items()/values() intead of iteritems()/itervalues()

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over

[Qemu-devel] [PULL 08/21] qapi: force a UTF-8 locale for running Python

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Python2 did not validate locale correctness when reading input data, so would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so if you try to read UTF-8 data in the C locale, it will raise an error for any UTF-8 bytes that aren't

[Qemu-devel] [PULL 10/21] configure: allow use of python 3

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange Message-Id: <20180116134217.8725-11-berra...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- configure | 5 ++--- 1 file

[Qemu-devel] [PULL 07/21] qapi: ensure stable sort ordering when checking QAPI entities

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Reviewed-by: Philippe

[Qemu-devel] [PULL 03/21] qapi: Use OrderedDict from standard library if available

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL 00/21] Python queue, 2018-02-05

2018-02-05 Thread Eduardo Habkost
The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180202-pull-request' into staging (2018-02-02 18:54:11 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git

[Qemu-devel] [PULL 01/21] qapi: convert to use python print function instead of statement

2018-02-05 Thread Eduardo Habkost
From: "Daniel P. Berrange" Python 3 no longer supports the bare "print" statement, it must be called as a normal function with round brackets. It is possible to opt-in to this new syntax with Python 2.6 onwards by importing the "print_function" from the "__future__" module,

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2018-02-05 Thread Eduardo Habkost
On Mon, Feb 05, 2018 at 03:42:02PM +0100, Igor Mammedov wrote: > On Mon, 5 Feb 2018 11:54:01 -0200 > Eduardo Habkost wrote: > > > On Mon, Feb 05, 2018 at 12:22:35PM +0100, Igor Mammedov wrote: > > > On Fri, 2 Feb 2018 16:23:26 -0200 > > > Eduardo Habkost

Re: [Qemu-devel] [PATCH v4 03/22] RISC-V CPU Core Definition

2018-02-05 Thread Michael Clark
On Tue, Feb 6, 2018 at 2:45 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/04/2018 10:22 PM, Michael Clark wrote: > > Add CPU state header, CPU definitions and initialization routines > > > > Signed-off-by: Michael Clark > > --- > > target/riscv/cpu.c

Re: [Qemu-devel] [PATCH v4 03/22] RISC-V CPU Core Definition

2018-02-05 Thread Michael Clark
On Tue, Feb 6, 2018 at 4:04 AM, Igor Mammedov wrote: > On Mon, 5 Feb 2018 19:22:28 +1300 > Michael Clark wrote: > > > Add CPU state header, CPU definitions and initialization routines > > > > Signed-off-by: Michael Clark > > --- > >

Re: [Qemu-devel] [PATCH v4 06/22] RISC-V FPU Support

2018-02-05 Thread Michael Clark
On Tue, Feb 6, 2018 at 3:01 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/04/2018 10:22 PM, Michael Clark wrote: > > +uint64_t helper_fmsub_s(CPURISCVState *env, uint64_t frs1, uint64_t > frs2, > > +uint64_t frs3) > > +{ > > +return

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-02-05 Thread Anatol Pomozov
Hi On Wed, Jan 31, 2018 at 1:12 AM, Kevin Wolf wrote: > Am 31.01.2018 um 00:15 hat Jack Schwartz geschrieben: >> Hi Anatol and Kevin. >> >> Even though I am new to Qemu, I have a patch to deliver for >> multiboot.c (as you know) and so I feel familiar enough to do a review >>

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread Collin L. Walling
This was silly.  Last minute change on my end.  Consider the assertion removed. On 02/05/2018 04:20 PM, no-re...@patchew.org wrote: /var/tmp/patchew-tester-tmp-k5bn7h1w/src/pc-bios/s390-ccw/libc.c: In function ‘itostr’: /var/tmp/patchew-tester-tmp-k5bn7h1w/src/pc-bios/s390-ccw/libc.c:70:20:

Re: [Qemu-devel] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1517864246-11101-1-git-send-email-wall...@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v5 12/12] s390-ccw: interactive boot menu for scsi

2018-02-05 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v5 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-05 Thread Collin L. Walling
Implements an sclp_read function to capture input from the console and a wrapper function that handles parsing certain characters and adding input to a buffer. The input is checked for any erroneous values and is handled appropriately. A prompt will persist until input is entered or the timeout

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-05 Thread Max Reitz
On 2018-02-02 17:07, Vladimir Sementsov-Ogievskiy wrote: > To maintain load/store disabled bitmap there is new approach: > > - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored > - store enabled bitmaps as "auto" to qcow2 > - store disabled bitmaps without "auto" flag to

[Qemu-devel] [PATCH v5 08/12] s390-ccw: read stage2 boot loader data to find menu

2018-02-05 Thread Collin L. Walling
Read the stage2 boot loader data block-by-block. We scan the current block for the string "zIPL" to detect the start of the boot menu banner. We then load the adjacent blocks (previous block and next block) to account for the possibility of menu data spanning multiple blocks. Signed-off-by:

[Qemu-devel] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-05 Thread Collin L. Walling
It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate to the guest after IPL completes and cause unwanted behavior. To avoid this, we clear the write event mask

[Qemu-devel] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-05 Thread Collin L. Walling
- replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 53 ++

[Qemu-devel] [PATCH v5 04/12] s390-ccw: update libc

2018-02-05 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr atoui Signed-off-by: Collin L. Walling Acked-by: Christian

[Qemu-devel] [PATCH v5 07/12] s390-ccw: set up interactive boot menu parameters

2018-02-05 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24

[Qemu-devel] [PATCH v5 09/12] s390-ccw: print zipl boot menu

2018-02-05 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default

[Qemu-devel] [PATCH v5 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-05 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8

[Qemu-devel] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-05 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. Any value set

[Qemu-devel] [PATCH v5 03/12] s390-ccw: refactor IPL structs

2018-02-05 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by:

[Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-05 Thread Collin L. Walling
The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. While storing that data in unused fields of the IPL parameter block works, that approach could

[Qemu-devel] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread Collin L. Walling
--- [v5] --- Note: some areas outside of this patch series could use some cleanup/refactoring/revisiting, but I'd like to defer that to a different series that touches on those areas (if we try to address them all, then this series will never be finished!) As for the irq drain solution

Re: [Qemu-devel] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

2018-02-05 Thread Max Reitz
On 2018-02-05 21:46, Richard W.M. Jones wrote: > > I assume the context of all this is making relative backing file names work > in qcow2 files? Yes, mostly. (https://bugzilla.redhat.com/show_bug.cgi?id=1528931) But it's generally nice for block nodes to print a readable filename when queried

Re: [Qemu-devel] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

2018-02-05 Thread Richard W.M. Jones
On Mon, Feb 05, 2018 at 09:22:30PM +0100, Max Reitz wrote: > This series implements .bdrv_refresh_filename() for the ssh block > driver, along with an appropriate .bdrv_dirname() so we don't chop off > query strings for backing files with relative filenames. > > This series depends on my “block:

Re: [Qemu-devel] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

2018-02-05 Thread Richard W.M. Jones
I assume the context of all this is making relative backing file names work in qcow2 files? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch

[Qemu-devel] [PATCH 2/2] block/ssh: Implement .bdrv_dirname()

2018-02-05 Thread Max Reitz
ssh_bdrv_dirname() is basically the generic bdrv_dirname(), except it takes care not to silently chop off any query string (i.e., host_key_check). Signed-off-by: Max Reitz --- block/ssh.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/ssh.c

[Qemu-devel] [PATCH 1/2] block/ssh: Implement .bdrv_refresh_filename()

2018-02-05 Thread Max Reitz
Signed-off-by: Max Reitz --- block/ssh.c | 53 ++--- 1 file changed, 46 insertions(+), 7 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index c31b2686c3..a5b7e831a4 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -75,6 +75,12

[Qemu-devel] [PATCH 0/2] block/ssh: Implement .bdrv_refresh_filename()

2018-02-05 Thread Max Reitz
This series implements .bdrv_refresh_filename() for the ssh block driver, along with an appropriate .bdrv_dirname() so we don't chop off query strings for backing files with relative filenames. This series depends on my “block: Fix some filename generation issues” series and on Pino's “ssh:

Re: [Qemu-devel] [PATCH] linux-user: Implement copy_file_range

2018-02-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: mvmmv0nk6g7@suse.de Subject: [Qemu-devel] [PATCH] linux-user: Implement copy_file_range === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

2018-02-05 Thread Eric Blake
On 02/05/2018 09:24 AM, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" The SocketAddress 'fd' kind accepts the name of a file descriptor passed to the monitor with the 'getfd' command. This makes it impossible to use the 'fd' kind in cases where a monitor is not

Re: [Qemu-devel] [PATCH 02/10] cuda: don't allow writes to port output pins

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/03/2018 07:37 AM, Mark Cave-Ayland wrote: > Use the direction registers as a mask to ensure that only input pins are > updated upon write. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/macio/cuda.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Allow PC to be set on command line

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/05/2018 12:04 PM, Peter Maydell wrote: > The documentation for the generic loader claims that you can > set the PC for a CPU with an option of the form > -device loader,cpu-num=0,addr=0x1004 > > However if you try this QEMU complains: > cpu_num must be specified when setting a

Re: [Qemu-devel] [PATCH 04/10] cuda: introduce CUDAState parameter to get_counter()

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/03/2018 07:37 AM, Mark Cave-Ayland wrote: > This will be required shortly and also happens to match nicely with the > corresponding signature for set_counter(). > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > ---

Re: [Qemu-devel] [PATCH 05/10] cuda: rename frequency property to tb_frequency

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/03/2018 07:37 AM, Mark Cave-Ayland wrote: > This allows us to more easily differentiate between the timebase frequency > used > to calibrate the MacOS timers and the actual frequency of the hardware clock > as > indicated by CUDA_TIMER_FREQ. > > Signed-off-by: Mark Cave-Ayland

[Qemu-devel] [PULL 45/47] Add the WHPX vcpu API

2018-02-05 Thread Paolo Bonzini
From: "Justin Terry (VM)" Adds support for the Windows Hypervisor Platform accelerator (WHPX) stubs and introduces the whpx.h sysemu API for managing the vcpu scheduling and management. Signed-off-by: Justin Terry (VM) Message-Id:

Re: [Qemu-devel] [PATCH] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-02-05 Thread Paolo Bonzini
On 01/02/2018 06:51, Changpeng Liu wrote: > Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, > for multiple I/O queues scenario, all the I/O queues will share one > interrupt vector, while here, enable multiple vectors according to > the number of I/O queues. > >

Re: [Qemu-devel] [PATCH 08/10] cuda: factor out timebase-derived counter value and load time

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/03/2018 07:37 AM, Mark Cave-Ayland wrote: > Commit b981289c49 "PPC: Cuda: Use cuda timer to expose tbfreq to guest" > altered > the timer calculations from those based upon the hardware CUDA clock frequency > to those based upon the CPU timebase frequency. > > In fact we can isolate the

[Qemu-devel] [PULL 44/47] Add the Windows Hypervisor Platform accelerator.

2018-02-05 Thread Paolo Bonzini
From: "Justin Terry (VM)" Introduces the configure support for the new Windows Hypervisor Platform that allows for hypervisor acceleration from usermode components on the Windows platform. Signed-off-by: Justin Terry (VM) Message-Id:

Re: [Qemu-devel] [PATCH 06/10] cuda: minor cosmetic tidy-ups to get_next_irq_time()

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/03/2018 07:37 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/misc/macio/cuda.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 1/4] ui: avoid risk of 32-bit int overflow in VNC buffer check

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/05/2018 08:49 AM, Daniel P. Berrangé wrote: > For very large framebuffers, it is theoretically possible for the result > of 'vs->throttle_output_offset * VNC_THROTTLE_OUTPUT_LIMIT_SCALE' to > exceed the size of a 32-bit int. For this to happen in practice, the > video RAM would have to be

[Qemu-devel] [PULL 39/47] Add memfd based hostmem

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau Add a new memory backend, similar to hostmem-file, except that it doesn't need to create files. It also enforces memory sealing. This backend is mainly useful for sharing the memory with other processes. Note that Linux supports transparent

Re: [Qemu-devel] [PATCH v4 2/9] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types

2018-02-05 Thread Eric Blake
On 02/05/2018 09:24 AM, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" There are qemu_strtoNN functions for various sized integers. This adds two more for plain int & unsigned int types, with suitable range checking. Reviewed-by: Marc-André Lureau

[Qemu-devel] [PULL 46/47] Introduce the WHPX impl

2018-02-05 Thread Paolo Bonzini
From: "Justin Terry (VM)" Implements the Windows Hypervisor Platform accelerator (WHPX) target. Which acts as a hypervisor accelerator for QEMU on the Windows platform. This enables QEMU much greater speed over the emulated x86_64 path's that are taken on Windows today.

[Qemu-devel] [PULL 38/47] memfd: add hugetlbsize argument

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau Learn to specificy hugetlb size as qemu_memfd_create() argument. Signed-off-by: Marc-André Lureau Message-Id: <20180201132757.23063-4-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 2/4] ui: avoid 'local_err' variable shadowing in VNC SASL auth

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/05/2018 08:49 AM, Daniel P. Berrangé wrote: > The start_auth_sasl() method declares a 'Error *local_err' variable in > an inner if () {...} scope, which shadows a variable of the same name > declared at the start of the method. This is confusing for reviewers and > may trigger compiler

[Qemu-devel] [PULL 41/47] vhost-user-test: make read-guest-mem setup its own qemu

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20180201132757.23063-7-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 27 +++ 1

[Qemu-devel] [PULL 40/47] tests: keep compiling failing vhost-user tests

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau Let's protect the failing tests under a QTEST_VHOST_USER_FIXME environment variable, so we keep compiling the tests and we can easily run them. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 37/47] memfd: add hugetlb support

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau Linux commit 749df87bd7bee5a79cef073f5d032ddb2b211de8 (v4.14-rc1) added a new flag MFD_HUGETLB to memfd_create() that specify the file to be created resides in the hugetlbfs filesystem. This is the generic hugetlbfs filesystem not associated

[Qemu-devel] [PULL 43/47] tests/test-filter-redirector: move close()

2018-02-05 Thread Paolo Bonzini
From: Klim Kireev Since we have separate handler on POLLHUP, which drops data after closing the connection we need to fix this test, because it sends data and instantly close the socket creating race condition. In some cases on other end of socket client closes it

Re: [Qemu-devel] [PATCH 3/4] ui: check VNC audio frequency limit at time of reading from client

2018-02-05 Thread Philippe Mathieu-Daudé
On 02/05/2018 08:49 AM, Daniel P. Berrangé wrote: > The 'vs->as.freq' value is a signed integer, which is read from an > unsigned 32-bit int field on the wire. There is thus a risk of overflow > on 32-bit platforms. Move the frequency limit checking to be done at > time of read before casting to a

[Qemu-devel] [PULL 35/47] cpus: join thread when removing a vCPU

2018-02-05 Thread Paolo Bonzini
If no one joins the thread, its associated memory is leaked. Reported-by: CheneyLin Signed-off-by: Paolo Bonzini --- cpus.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index fe127ac..8d8bb7c 100644 ---

[Qemu-devel] [PULL 36/47] memfd: add error argument, instead of perror()

2018-02-05 Thread Paolo Bonzini
From: Marc-André Lureau This will allow callers to silence error report when the call is allowed to failed. Signed-off-by: Marc-André Lureau Message-Id: <20180201132757.23063-2-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini

  1   2   3   4   5   >