Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

On 12/02/2018 18:30, Vladimir Sementsov-Ogievskiy wrote: > 18.01.2018 13:09, Paolo Bonzini wrote:>> We have three cases: >> >> 1) monitor creates and destroy bitmaps. >> >> 2) monitor also has to read the list.  We know it operates with BQL. >> >> 3) users such as mirror.c create a dirty bitmap in

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 02/12/2018 03:40 PM, Benjamin Herrenschmidt wrote: > On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote: >> On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote: >>> On 12/02/18 09:55, Benjamin Herrenschmidt wrote: Well, we have a problem then. It looks like Qemu broken

[Qemu-devel] [PATCH v3] scripts: Add decodetree.py

To be used to decode ARM SVE, but could be used for any fixed-width ISA. Signed-off-by: Richard Henderson --- Changes since v2: * Fix tests/decode/err_init3.def. * Mark main decoder static by default. * Properly diagnose unspecified bits. * Remove output

[Qemu-devel] [PATCH] vnc: add qapi/error.h include to stubs

Fixes --disable-vnc build failure. Signed-off-by: Gerd Hoffmann --- ui/vnc-stubs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c index f51280549a..06c4ac6296 100644 --- a/ui/vnc-stubs.c +++ b/ui/vnc-stubs.c @@ -1,5 +1,6 @@ #include

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

Your command line looks wrong, because you forgot –icount, but specified other replay options. I tried recording and replaying with your command line and the execution hangs at some moment of replay. The problem may be hidden in –dtb option, because it may add the devices without configuring

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

On Mon, Feb 12, 2018 at 5:47 AM, Pavel Dovgalyuk wrote: > I tested ARM only with –kernel and –initrd. > > Can you provide the full command line and the disk image? > > > The command I tried was: time ./buildroot/output.arm~/host/usr/bin/qemu-system-arm -M versatilepb

Re: [Qemu-devel] [PATCH qemu v7 4/4] ppc/spapr, vfio: Turn off MSIX emulation for VFIO devices

On Fri, Feb 09, 2018 at 06:55:03PM +1100, Alexey Kardashevskiy wrote: > This adds a possibility for the platform to tell VFIO not to emulate MSIX > so MMIO memory regions do not get split into chunks in flatview and > the entire page can be registered as a KVM memory slot and make direct > MMIO

Re: [Qemu-devel] [PATCH qemu v7 3/4] vfio-pci: Allow mmap of MSIX BAR

On Fri, Feb 09, 2018 at 06:55:02PM +1100, Alexey Kardashevskiy wrote: > At the moment we unconditionally avoid mapping MSIX data of a BAR and > emulate MSIX table in QEMU. However it is 1) not always necessary as > a platform may prodive a paravirt interface for MSIX configuration; > 2) can affect

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

On Tue, Feb 13, 2018 at 04:36:30PM +1100, David Gibson wrote: > On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote: > > On 13/02/18 03:06, Alex Williamson wrote: > > > On Mon, 12 Feb 2018 18:05:54 +1100 > > > Alexey Kardashevskiy wrote: > > > > > >> On 12/02/18

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote: > On 13/02/18 03:06, Alex Williamson wrote: > > On Mon, 12 Feb 2018 18:05:54 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 12/02/18 16:19, David Gibson wrote: > >>> On Fri, Feb 09, 2018 at 06:55:01PM +1100,

Re: [Qemu-devel] [PATCH v3] spapr: set vsmt to MAX(8, smp_threads)

On Mon, Feb 12, 2018 at 12:11:27PM +0100, Greg Kurz wrote: > On Sat, 10 Feb 2018 20:23:07 +1100 > David Gibson wrote: > > > On Fri, Feb 09, 2018 at 03:06:49PM +0100, Greg Kurz wrote: > > > On Fri, 9 Feb 2018 09:18:58 +0100 > > > Laurent Vivier

[Qemu-devel] [PATCH v2] vhost-user: fix memory leak

g_free() was moved from vhost_net_cleanup in commit e6bcb1b, so we should free net after vhost_net_cleanup Signed-off-by: linzhecheng diff --git a/net/vhost-user.c b/net/vhost-user.c index cb45512506..d024573e45 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@

[Qemu-devel] [PATCH v13 30/30] sdhci: add Spec v4.2 register definitions

Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci-internal.h | 9 + hw/sd/sdhci.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h index 0092627076..e1bb733aed 100644 ---

Re: [Qemu-devel] 答复: [PATCH] vhost-user: fix memory leak

On 02/13/2018 01:16 AM, linzhecheng wrote: >> -邮件原件- >> 发件人: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] >> 代表 Philippe Mathieu-Daudé >> 发送时间: 2018年2月13日 11:54 >> 收件人: linzhecheng ; qemu-devel@nongnu.org >> 抄送: pbonz...@redhat.com; wangxin (U)

[Qemu-devel] [PATCH v13 25/30] hw/arm/fsl-imx6: implement SDHCI Spec. v3

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- hw/arm/fsl-imx6.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c index e6559a8b12..b6ac72de27 100644 --- a/hw/arm/fsl-imx6.c +++

[Qemu-devel] [PATCH v13 22/30] sdhci: implement CMD/DAT[] fields in the Present State register

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 2 ++ include/hw/sd/sd.h | 4

[Qemu-devel] [PATCH v13 28/30] sdhci: check Spec v3 capabilities qtest

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- tests/sdhci-test.c | 12 tests/Makefile.include | 1 + 2 files changed, 13 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index

Re: [Qemu-devel] [PATCH] tcg: Improve tcg_gen_muli_i32/i64

On 02/11/2018 05:39 PM, Richard Henderson wrote: > Convert multiplication by power of two to left shift. > > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > tcg/tcg-op.c | 24 ++-- > 1 file

[Qemu-devel] [PATCH v13 19/30] sdhci: implement the Host Control 2 register (tuning sequence)

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 10 ++ include/hw/sd/sdhci.h | 1 +

[Qemu-devel] [PATCH v13 27/30] hw/arm/xilinx_zynqmp: enable the UHS-I mode

see the Xilinx datasheet "UG1085" (v1.7) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index

[Qemu-devel] [PATCH v13 29/30] sdhci: add a check_capab_v3() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 39d0f87788..c0b45da88a 100644 ---

[Qemu-devel] [PATCH v13 24/30] hw/arm/bcm2835_peripherals: change maximum block size to 1kB

following the datasheet. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- hw/arm/bcm2835_peripherals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/bcm2835_peripherals.c

[Qemu-devel] [PATCH v13 16/30] hw/arm/xilinx_zynq: fix the capabilities register to match the datasheet

checking Xilinx datasheet "UG585" (v1.12.1) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/xilinx_zynq.c | 53 tests/sdhci-test.c | 5 + 2 files changed, 34

[Qemu-devel] 答复: [PATCH] vhost-user: fix memory leak

> -邮件原件- > 发件人: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com] > 代表 Philippe Mathieu-Daudé > 发送时间: 2018年2月13日 11:54 > 收件人: linzhecheng ; qemu-devel@nongnu.org > 抄送: pbonz...@redhat.com; wangxin (U) ; > lidonglin

[Qemu-devel] [PATCH v13 18/30] sdhci: rename the hostctl1 register

As per the Spec v3.00 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/sd/sdhci.h | 2 +- hw/sd/sdhci.c | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH v13 14/30] hw/arm/exynos4210: access the 64-bit capareg with qdev_prop_set_uint64()

We only set a 32-bit value, but this is a good practice in case this code is used as reference. (missed in 5efc9016e52) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/exynos4210.c | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH v13 23/30] hw/arm/bcm2835_peripherals: implement SDHCI Spec v3

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/bcm2835_peripherals.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c

[Qemu-devel] [PATCH v13 26/30] hw/arm/xilinx_zynqmp: fix the capabilities/spec version to match the datasheet

checking Xilinx datasheet "UG1085" (v1.7) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v13 15/30] hw/arm/exynos4210: add a comment about a very similar SDHCI (Spec. v2)

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- hw/arm/exynos4210.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index d89322c7ea..06f9d1ffa4 100644 ---

[Qemu-devel] [PATCH v13 10/30] sdhci: check the Spec v1 capabilities correctness

Incorrect value will throw an error. Note than Spec v2 is supported by default. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 22 ++- hw/sd/sdhci.c | 99

[Qemu-devel] [PATCH v13 21/30] sdhci: implement UHS-I voltage switch

[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/sd/sd.h| 16 include/hw/sd/sdhci.h |

[Qemu-devel] [PATCH v13 20/30] sdbus: add trace events

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/core.c | 14 -- hw/sd/trace-events | 5 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/sd/core.c b/hw/sd/core.c index

[Qemu-devel] [PATCH v13 04/30] sdhci: add a check_capab_baseclock() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 51af5eac67..d6eb3c3a48 100644 ---

[Qemu-devel] [PATCH v13 08/30] sdhci: use a numeric value for the default CAPAB register

using many #defines is not portable when scaling to different HCI. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 74 +-- 1 file changed, 16

[Qemu-devel] [PATCH v13 12/30] sdhci: Fix 64-bit ADMA2

From: Sai Pavan Boddu The 64-bit ADMA address is not converted to the cpu endianes correctly. This patch fixes the issue and uses a valid mask for the attribute data. Signed-off-by: Sai Pavan Boddu [AF: Re-write commit message] Reviewed-by: Alistair

[Qemu-devel] [PATCH v13 07/30] sdhci: add a 'spec_version property' (default to v2)

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 4 ++-- include/hw/sd/sdhci.h | 2 ++ hw/sd/sdhci.c | 27 +++ 3 files changed, 27 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v13 09/30] sdhci: simplify sdhci_get_fifolen()

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci-internal.h | 4 +++- hw/sd/sdhci.c | 20 +--- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/hw/sd/sdhci-internal.h

[Qemu-devel] [PATCH v13 06/30] sdhci: add qtest to check the SD Spec version

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 7c50c0482b..24feea744a 100644 ---

[Qemu-devel] [PATCH v13 03/30] sdhci: add check_capab_readonly() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index 82f3785a72..51af5eac67 100644 ---

[Qemu-devel] [PATCH v13 05/30] sdhci: add a check_capab_sdma() qtest

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tests/sdhci-test.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c index d6eb3c3a48..7c50c0482b 100644 --- a/tests/sdhci-test.c

[Qemu-devel] [PATCH v13 02/30] sdhci: add qtest to check the SD capabilities register

The PCI model is tested with the pc/x86_64 machine, the SysBus model with the smdkc210/arm machine. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Paolo Bonzini --- tests/sdhci-test.c | 145 +

[Qemu-devel] [PATCH v13 00/30] SDHCI: clean v1/2 Specs, UHS-I cards tuning sequence

This series includes the last versions of both series: - SDHCI: clean v1/v2 Specs (part 2) - SDHCI: add tuning sequence for UHS-I cards (part 3) Since v12: - rebased... - bcc'ing patchew, spaming others Since v11: - rebased due to conflict (IMX_USDHC fd1e5c817964) - QSDHCI uses union (Paolo) -

[Qemu-devel] [PATCH v13 01/30] sdhci: use error_propagate(local_err) in realize()

avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" comments). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sdhci.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] migration: Fix early failure crash

On Mon, Feb 12, 2018 at 04:03:38PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This fixes a crash for the case where a migration exits with an error > very early, this is probably due to my recent error handling change. > > I also add a

Re: [Qemu-devel] [PATCH] vhost-user: fix memory leak

Hi Linzhecheng, On 02/12/2018 11:53 PM, linzhecheng wrote: > fix memory leak > > Signed-off-by: linzhecheng > > diff --git a/net/vhost-user.c b/net/vhost-user.c > index cb45512506..d024573e45 100644 > --- a/net/vhost-user.c > +++ b/net/vhost-user.c > @@ -109,6 +109,7 @@

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

On Fri, Feb 09, 2018 at 08:49:45AM +0100, David Engraf wrote: > Hello David, > > Am 09.02.2018 um 06:33 schrieb David Gibson: > > On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: > > > This patch fixes an incorrect behavior when the -kernel argument has been > > > specified without

[Qemu-devel] [PATCH] vhost-user: fix memory leak

fix memory leak Signed-off-by: linzhecheng diff --git a/net/vhost-user.c b/net/vhost-user.c index cb45512506..d024573e45 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -109,6 +109,7 @@ static int vhost_user_start(int queues, NetClientState *ncs[], CharBackend

[Qemu-devel] gdbstub.c gdb-get-register returns 0, breaking remote gdb call

Unsure the scope of this bug or the proper fix, so bringing it up here first. gdbstub.c:gdb_read_register will return 0, and thus E14, when a remote gdb tries to call a function in the exposed linux kernel. This appears to be because the caller expects to be able to receive a generic register

[Qemu-devel] [PATCH v2] block/nvme: fix Coverity reports

From: Paolo Bonzini 1) string not null terminated in sysfs_find_group_file 2) NULL pointer dereference and dead local variable in nvme_init. Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng --- v2: Fix error path. ---

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/54] Patch Round-up for stable 2.11.1, freeze on 2018-02-12

Quoting Michael Roth (2018-02-06 13:14:21) > Hi everyone, > > > The following new patches are queued for QEMU stable v2.11.1: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The

Re: [Qemu-devel] [PATCH RESEND v12 11/30] sdhci: replace DMA magic value by BLOCK_SIZE_MASK

On Mon, 02/12 15:00, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis Hmm.. Something is going weird here. It's still not in the archive

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

On 13/02/18 03:06, Alex Williamson wrote: > On Mon, 12 Feb 2018 18:05:54 +1100 > Alexey Kardashevskiy wrote: > >> On 12/02/18 16:19, David Gibson wrote: >>> On Fri, Feb 09, 2018 at 06:55:01PM +1100, Alexey Kardashevskiy wrote: At the moment if vfio_memory_listener is

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 13/02/18 01:40, Benjamin Herrenschmidt wrote: > On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote: >> On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote: >>> On 12/02/18 09:55, Benjamin Herrenschmidt wrote: Well, we have a problem then. It looks like Qemu broken

Re: [Qemu-devel] [PATCH] travis: use libgcc-4.8-dev (libgcc-6-dev is not available on Ubuntu 14.04)

On 12/02/2018 19:46, Philippe Mathieu-Daudé wrote: > Travis image is based on Ubuntu Trusty (14.04), since d83414e1fd1 we get: > > $ sudo -E \ > apt-get -yq --no-install-suggests --no-install-recommends --force-yes \ > install \ > libaio-dev libattr1-dev libbrlapi-dev

Re: [Qemu-devel] [PATCH v2 29/29] qapi: Don't create useless directory qapi-generated

On 02/11/2018 03:36 AM, Markus Armbruster wrote: We used to generate first test and later QGA QAPI code into qapi-generated/. Commit b93b63f574 moved the test code to tests/. Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The directory has been unused since. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 28/29] Fix up dangling references to qmp-commands.* in comment and doc

On 02/11/2018 03:36 AM, Markus Armbruster wrote: Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit 5032a16d1d. Fix up the reference to qmp-commands.txt in docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa. Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH] tcg: Improve tcg_gen_muli_i32/i64

On Sun, Feb 11, 2018 at 12:39:34 -0800, Richard Henderson wrote: > Convert multiplication by power of two to left shift. > > Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota Thanks, Emilio

Re: [Qemu-devel] [PATCH v2 27/29] qapi: Move qapi-schema.json to qapi/, rename generated files

On 02/11/2018 03:36 AM, Markus Armbruster wrote: Move qapi-schema.json to qapi/, so it's next to its modules, and all files get generated to qapi/, not just the ones generated for modules. Consistently name the generated files qapi-MODULE.EXT: qmp-commands.[ch] become qapi-commands.[ch],

[Qemu-devel] [PATCH v2 4/5] usb-mtp: Introduce write support for MTP objects

Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a previous SendObjectInfo operation by the

Re: [Qemu-devel] [PATCH v2 26/29] docs: Correct outdated information on QAPI

On 02/11/2018 03:36 AM, Markus Armbruster wrote: * Fix guidance on error classes * Point to generated documentation * Drop plea for documentation, because the QAPI code generator enforces it since commit 3313b6124b * Minor tweaks here and there Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v2 1/5] usb-mtp: Add one more argument when building results

The response to a SendObjectInfo consists of the storageid, parent obejct handle and the handle reserved for the new incoming object Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 50 +++--- 1 file changed, 27 insertions(+), 23

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180212

edup-090218-1' into staging > > (2018-02-09 16:12:34 +) > > > > are available in the Git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180212 > > > > for you to fetch changes up to 51f233ec92cdab7030cb7407dd7f00991

[Qemu-devel] [PATCH v2 3/5] usb-mtp: Support delete of mtp objects

Write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Advertise delete support and mark the store READ/WRITE since some initiators will fail the operation if the store is

[Qemu-devel] [PATCH v2 0/5] Initial write support for MTP object

v2: 3/5: Set mtp store flag to read only 4/5: Fix compiler warnings and change default file permissions 5/5: Fix file permissions These patches implement write support for Qemu's MTP emulation. Simple tests such as delete/move/edit/copy work ok. Current issues/TODO: - File transfers > 4GB

[Qemu-devel] [PATCH v2 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 5 ++--- 1 file changed, 2

[Qemu-devel] [PATCH v2 5/5] usb-mtp: Advertise SendObjectInfo for write support

This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple function to get the filename

Re: [Qemu-devel] [PATCH v2 25/29] docs/devel/writing-qmp-commands: Update for modular QAPI

On 02/11/2018 03:36 AM, Markus Armbruster wrote: With modular code generation, putting stuff right into qapi-schema.json is a bad idea. Update writing-qmp-commands.txt accordingly. Signed-off-by: Markus Armbruster --- docs/devel/writing-qmp-commands.txt | 14

Re: [Qemu-devel] [PATCH v2 24/29] qapi: Empty out qapi-schema.json

On 02/11/2018 03:36 AM, Markus Armbruster wrote: The previous commit improved compile time by including less of the generated QAPI headers. This is impossible for stuff defined directly in qapi-schema.json, because that ends up in headers that that pull in everything. Move everything but

Re: [Qemu-devel] "make check -j4" hangs

On 12/02/2018 20:30, Thomas Huth wrote: > On 12.02.2018 15:42, klim wrote: > [...] >> I just have reverted my 2 commits and >> >> after that make check -j32 hangs >> >> with >> >> GTester: last random seed: R02Sb95a3bf6ab4c05540cec188081a7cc2a >> >> in vhost-user-test >> >> so it is not my fault >

Re: [Qemu-devel] [PATCH v2 23/29] Include less of the generated modular QAPI headers

On 02/11/2018 03:36 AM, Markus Armbruster wrote: In my "build everything" tree, a change to the types in qapi-schema.json triggers a recompile of about 4800 out of 5100 objects. The previous commit split up qmp-commands.h, qmp-event.h, qmp-visit.h, qapi-types.h. Each of these headers still

Re: [Qemu-devel] [PATCH v2 22/29] qapi: Generate separate .h, .c for each module

On 02/11/2018 03:36 AM, Markus Armbruster wrote: Our qapi-schema.json is composed of modules connected by include directives, but the generated code is monolithic all the same: one qapi-types.h with all the types, one qapi-visit.h with all the visitors, and so forth. These monolithic headers

[Qemu-devel] [Bug 1749016] [NEW] VHDX BAT and Metadata Region Header Required Bit Not Set

Public bug reported: When converting a VMDK to VHDX the resulting VHDX's Region table has a small error. According to the VHDX specification the BAT and Metadata entries for the region header required bit should be set to 1. In a VHDX created by qemu-img, this bit is not set. See Table 4: Known

Re: [Qemu-devel] [PATCH v2 20/29] qapi/types qapi/visit: Generate built-in stuff into separate files

On 02/11/2018 03:35 AM, Markus Armbruster wrote: Linking code from multiple separate QAPI schemata into the same program is possible, but involves some weirdness around built-in types: * We generate code for built-in types into .c only with option --builtins. The user is responsible for

Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

On Mon, Feb 12, 2018 at 03:07:26PM -0600, Brijesh Singh wrote: > In current implementation, when -cpu ...,+sev is passed without > appropriate SEV configuration then we populate the Fn8000_001F CPUID but > VMCB will not have SEV bit set hence a guest will be launched as > non-SEV. I think we

Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support

On 2/12/18 12:38 PM, Eduardo Habkost wrote: > On Mon, Feb 12, 2018 at 09:36:52AM -0600, Brijesh Singh wrote: >> AMD EPYC processors support memory encryption feature. The feature >> is reported through CPUID 8000_001F[EAX]. >> >> Fn8000_001F [EAX]: >> Bit 0 Secure Memory Encryption (SME)

Re: [Qemu-devel] [PATCH v2 19/29] qapi: Make code-generating visitors use QAPIGen more

On 02/11/2018 03:35 AM, Markus Armbruster wrote: The use of QAPIGen is rather shallow so far: most of the output accumulation is not converted. Take the next step: convert output accumulation in the code-generating visitor classes. Helper functions outside these classes are not converted.

Re: [Qemu-devel] [PULL 0/7] machine/CPU queue, 2018-02-12

On Mon, Feb 12, 2018 at 04:53:40PM -0200, Eduardo Habkost wrote: > The following changes since commit 8e3fb8029efaf220ab48290cdb5151c682227030: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2018-02-12 13:00:03 +) > > are available in the Git

Re: [Qemu-devel] [PATCH v2 18/29] qapi: Rename generated qmp-marshal.c to qmp-commands.c

On 02/11/2018 03:35 AM, Markus Armbruster wrote: All generated .c are named like their .h, except for qmp-marshal.c and qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely matches generated test-qmp-commands.h. Get rid of this unnecessary complication. Yay for saner naming.

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 03:46 PM, Kevin O'Connor wrote: On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are used by the OperationRegion() in this patch series. The rest was thought of for future extensions. To allow

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: > The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are > used by the OperationRegion() in this patch series. The rest was thought of > for future extensions. > > To allow both firmwares to use PPI, we would need

Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

On 12.02.2018 13:14, Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some

Re: [Qemu-devel] [PATCH v2 17/29] qapi: Record 'include' directives in intermediate representation

On 02/11/2018 03:35 AM, Markus Armbruster wrote: The include directive permits modular QAPI schemata, but the generated code is monolithic all the same. To permit generating modular code, the front end needs to pass more information on inclusions to the back ends. The commit before last added

Re: [Qemu-devel] [PATCH 1/3] qmp: expose s390-specific CPU info

On 12.02.2018 13:14, Viktor Mihajlovski wrote: > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to detect that a CPU has been

Re: [Qemu-devel] [PATCH v3] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code

On 02/12/2018 12:48 PM, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" qemu-io puts the TTY into non-canonical mode, which means no EOF processing is done and thus getchar() will never return the EOF constant. Instead we have to query the TTY attributes to determine

Re: [Qemu-devel] [PATCH v3] tests/migration: Add source to PC boot block

On 02/12/2018 12:34 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The boot block used in the migration test is currently only shipped as a hex (with the source in the git commit message), Would be nice to point to commit ea0c6d62 (I assume that's

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On 02/12/2018 02:45 PM, Kevin O'Connor wrote: On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: I have played around with this patch and some modifications to EDK2. Though for EDK2 the question is whether to try to circumvent their current implementation that uses SMM or use SMM.

Re: [Qemu-devel] [PATCH v2 16/29] qapi: Generate in source order

On 02/11/2018 03:35 AM, Markus Armbruster wrote: The generators' conversion to visitors (merge commit 9e72681d16) changed the processing order of entities from source order to alphabetical order. The next commit needs source order, so change it back. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 15/29] qapi: Record 'include' directives in parse tree

On 02/11/2018 03:35 AM, Markus Armbruster wrote: The parse tree is a list of expressions. Except include expressions currently get replaced by the included file's parse tree. Instead of throwing away the include expression, keep it with the file name expanded so you don't have to track the

Re: [Qemu-devel] [PULL 0/7] machine/CPU queue, 2018-02-12

Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180212185347.8433-1-ehabk...@redhat.com Subject: [Qemu-devel] [PULL 0/7] machine/CPU

Re: [Qemu-devel] [PATCH v2 14/29] qapi: Concentrate QAPISchemaParser.exprs updates in .__init__()

On 02/11/2018 03:35 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- scripts/qapi/common.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) Again, not much mention of

Re: [Qemu-devel] [PATCH v2 13/29] qapi: Lift error reporting from QAPISchema.__init__() to callers

On 02/11/2018 03:35 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- scripts/qapi-gen.py| 8 ++-- scripts/qapi/common.py | 23 +--

Re: [Qemu-devel] [PATCH v2 10/29] qapi: Touch generated files only when they change

On 02/11/2018 03:35 AM, Markus Armbruster wrote: A massive number of objects depends on QAPI-generated headers. In my "build everything" tree, it's roughly 4800 out of 5100. This is particularly annoying when only some of the generated files change, say for a doc fix. Improve qapi-gen.py to

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote: > I have played around with this patch and some modifications to EDK2. Though > for EDK2 the question is whether to try to circumvent their current > implementation that uses SMM or use SMM. With this patch so far I circumvent > it,

Re: [Qemu-devel] [PATCH v2 09/29] qapi-gen: Convert from getopt to argparse

On 02/11/2018 03:35 AM, Markus Armbruster wrote: argparse is nicer to use than getopt, and gives us --help almost for free. Signed-off-by: Markus Armbruster --- scripts/qapi-gen.py| 48 ++-- scripts/qapi/common.py | 43

Re: [Qemu-devel] [PATCH v2 08/29] qapi-gen: New common driver for code and doc generators

On 02/11/2018 03:35 AM, Markus Armbruster wrote: Whenever qapi-schema.json changes, we run six programs eleven times to update eleven files. Similar for qga/qapi-schema.json. This is silly. Replace the six programs by a single program that spits out all eleven files. The programs become

Re: [Qemu-devel] [PATCH v2 03/29] qapi: Generate up-to-date copyright notice

On 02/11/2018 03:35 AM, Markus Armbruster wrote: Each generator carries a copyright notice for the generator itself, and another one for the files it generates. Only the former have been updated along the way, the latter have not, and are all out of date. Fix by copying the generator's

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

On 02/12/2018 03:31 PM, Eric Blake wrote: > On 02/12/2018 08:46 AM, Murilo Opsfelder Araujo wrote: >> On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: >>> From: Yasmin Beatriz >>> >>> fd_write_vmcore can fail to execute for a lot of reasons that can be >>>

Re: [Qemu-devel] "make check -j4" hangs

On 12.02.2018 15:42, klim wrote: [...] > I just have reverted my 2 commits and > > after that make check -j32 hangs > > with > > GTester: last random seed: R02Sb95a3bf6ab4c05540cec188081a7cc2a > > in vhost-user-test > > so it is not my fault You're right. I've bisected the issue again, and

[Qemu-devel] [RFC v6 22/22] hw/vfio/common: Do not print error when viommu translates into an mmio region

On ARM, the MSI doorbell is translated by the virtual IOMMU. As such address_space_translate() returns the MSI controller MMIO region and we get an "iommu map to non memory area" message. Let's remove this latter. Signed-off-by: Eric Auger --- hw/vfio/common.c | 2 -- 1

[Qemu-devel] [RFC v6 21/22] virtio-iommu: Implement set_page_size_mask

We implement the set_page_size_mask callback to allow the virtio-iommu to be aware of any restrictions on the page size mask due to an underlying HW IOMMU. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 16 2

  1   2   3   4   >