Re: [Qemu-devel] [PATCH] simple firmware.json test tool

Hi, > > Perhaps print a few shell commands first? Such as: > > > >( > > VARSTORE=$(mktemp) > > trap 'rm -f -- "$VARSTORE"' EXIT > > cat -- '[VARSTORE_TEMPLATE]' >> "$VARSTORE" > > qemu ... > >) > > > > It really does take separate actions, just like when you create

Re: [Qemu-devel] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code()

On 11/14/18 6:19 PM, Thomas Huth wrote: > Program received signal SIGSEGV, Segmentation fault. > [...] > (gdb) bt > #0 0x55addc68 in onenand_read (opaque=0x57600600, addr=98304, > size=4) at hw/block/onenand.c:612 So the crash is an off-by-one on the line above: ---

[Qemu-devel] [PATCH] 9p: take write lock on fid path updates

Recent commit 5b76ef50f62079a fixed a race where v9fs_co_open2() could possibly overwrite a fid path with v9fs_path_copy() while it is being accessed by some other thread, ie, use-after-free that can be detected by ASAN with a custom 9p client. It turns out that the same can happen at several

[Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

And also the g_malloc doesn't need check return value, remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- target/i386/hax-all.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index

Re: [Qemu-devel] [RFC for-3.2 PATCH 0/7] pcie: Enhanced link speed and width support

I can confirm that these patches work as expected. Thank you kindly Alex for your hard work! Tested-by: Geoffrey McRae On 2018-11-15 07:50, Alex Williamson wrote: QEMU exposes gen1 PCI-express interconnect devices supporting only 2.5GT/s and x1 width. It might not seem obvious that a

[Qemu-devel] [PATCH qemu] configure/fdt: Use more strict test for libfdt version

The libfdt installed in the system is preferred to the dtc submodule by default. The recent libfdt update added a new symbol - fdt_check_full - and this breaks compile if there is an older libfdt installed in the system. This changes the test to force ./configure into using newer libfdt.

Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks

On Thu, Nov 15, 2018 at 03:09:12AM +0800, Zhang Chen wrote: > From: Zhang Chen > > Current COLO mode(independent disk mode) need replication module work > together. Suggested by Dr. David Alan Gilbert . > > Signed-off-by: Zhang Chen Reviewed-by: Peter Xu Regards, -- Peter Xu

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

On Thu, Nov 15, 2018 at 03:16:25AM +0800, Zhang Chen wrote: > On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell > wrote: > > > On 14 November 2018 at 11:06, Thomas Huth wrote: > > > On 2018-11-14 11:47, Peter Xu wrote: > > >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: > > >>> This

[Qemu-devel] [QEMU-PPC] [PATCH] target/ppc: tcg: Implement addex instruction

Implement the addex instruction introduced in ISA V3.00 in qemu tcg. The add extended using alternate carry bit (addex) instruction performs the same operation as the add extended (adde) instruction, but using the overflow (ov) field in the fixed point exception register (xer) as the carry in and

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

Paolo Bonzini 于2018年11月14日周三 下午11:44写道： > On 14/11/2018 02:38, Li Qiang wrote: > > > > > > Paolo Bonzini mailto:pbonz...@redhat.com>> 于2018 > > 年11月14日周三 上午2:27写道： > > > > On 13/11/2018 11:17, Kevin Wolf wrote: > > > Am 13.11.2018 um 02:45 hat Li Qiang geschrieben: > > >> Ping

Re: [Qemu-devel] [PATCH v11 01/31] block: Use bdrv_refresh_filename() to pull

On 10/5/18 6:39 PM, Max Reitz wrote: Before this patch, bdrv_refresh_filename() is used in a pushing manner: Whenever the BDS graph is modified, the parents of the modified edges are supposed to be updated (recursively upwards). However, that is nonviable, considering that we want child changes

Re: [Qemu-devel] [PATCH v11 07/31] iotests.py: Add node_info()

On 10/5/18 6:39 PM, Max Reitz wrote: This function queries a node; since we cannot do that right now, it executes query-named-block-nodes and returns the matching node's object. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PULL V2 24/26] net: ignore packet size greater than INT_MAX

On 2018/11/15 上午12:23, Dima Stepanov wrote: On Wed, Nov 14, 2018 at 10:59:32AM +0800, Jason Wang wrote: On 2018/11/13 下午11:41, Dima Stepanov wrote: Hi Jason, I know that this patch has been already merged to stable, but i have a question: On Fri, Oct 19, 2018 at 11:22:23AM +0800, Jason

Re: [Qemu-devel] [PATCH] RFC: net/socket: learn to talk with a unix dgram socket

On 2018/11/14 下午9:01, Marc-André Lureau wrote: Hi On Wed, Nov 14, 2018 at 7:46 AM Jason Wang wrote: On 2018/11/10 上午3:56, Marc-André Lureau wrote: -net socket has a fd argument, and may be passed pre-opened sockets. TCP sockets use framing. UDP sockets have datagram boundaries. When

Re: [Qemu-devel] [RFC for-3.2 PATCH 0/7] pcie: Enhanced link speed and width support

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 154222737752.9288.484557356059052047.st...@gimli.home Type: series Subject: [Qemu-devel] [RFC for-3.2 PATCH 0/7] pcie: Enhanced link speed and width support === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v2 10/13] file-posix: Audit for read/write 64-bit cleanness

Any use of aio is inherently limited by size_t aio_nbytes in struct aiocb. read() is similarly limited to size_t bytes, although in practice, the ssize_t return means any read attempt on a 32-bit platform for more than 2G will likely return a short read (if that much memory was even available to

[Qemu-devel] [PATCH v2 12/13] block: Document need for audit of read/write 64-bit cleanness

At this time, any block driver that has not been audited for 64-bit cleanness, but which uses byte-based callbacks, should explicitly document that the driver wants the block layer to cap things at 2G. This patch has no semantic change. And it shows that the things I'm not interested in auditing

[Qemu-devel] [PATCH v2 05/13] block: Switch to 64-bit bl.max_transfer

This change has no semantic impact: all drivers either leave the value at 0 (no inherent 32-bit limit is still translated into fragmentation below 2G; see the previous patch for that audit), or set it to a value less than 2G. However, switching to a larger type and enforcing the 2G cap at the

[Qemu-devel] [PATCH v2 09/13] RFC: crypto: Rely on block layer for fragmentation

No need to reimplement fragmentation to BLOCK_CRYPTO_MAX_IO_SIZE ourselves when we can ask the block layer to do it for us. Signed-off-by: Eric Blake --- Question - is this patch for 'crypto' acceptable, or should we stick with just the previous one that marks things as 64-bit clean? ---

[Qemu-devel] [PATCH v2 04/13] block: Removed unused sector-based blocking I/O

We are gradually moving away from sector-based interfaces, towards byte-based. Now that all callers of blocking I/O have been converted to use our preferred byte-based bdrv_p{read,write}(), we can delete the unused bdrv_{read,write}(). Note that the old byte-based code checked that callers

[Qemu-devel] [PATCH v2 13/13] block: Enforce non-zero bl.max_transfer

The raw format driver and the filter drivers default to picking up the same limits as what they wrap, and I've audited that they are otherwise simple enough in their passthrough to be 64-bit clean; it's not worth changing their .bdrv_refresh_limits to advertise anything different. Previous

[Qemu-devel] [PATCH v2 11/13] qcow2: Audit for read/write 64-bit cleanness

The qcow2 read/write functions do their own fragmentation (because of cluster remapping); while we could advertise s->cluster_size and let the block layer do fragmentation for us, that would NOT solve the issue of the block layer handing us a length less than a cluster but at an offset which

[Qemu-devel] [PATCH v2 06/13] blkdebug: Audit for read/write 64-bit cleanness

Since the block layer is never supposed to hand us an offset + bytes that would exceed off_t, we can assert this in rule_check(). With that in place, there is nothing else in the pread, pwrite, or pwrite_zeroes code paths that can't handle inputs larger than 2G (even if the block layer currently

[Qemu-devel] [PATCH v2 08/13] crypto: Audit for read/write 64-bit cleanness

The crypto read/write functions do their own fragmentation (because everything has to go through a bounce buffer); while we could advertise BLOCK_CRYPTO_MAX_IO_SIZE as our max_transfer (and let the block layer do our fragmentation for us), I'm instead choosing to document that this driver is

[Qemu-devel] [PATCH v2 03/13] vvfat: Switch to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the vvfat driver. Ideally, the vvfat driver should switch to doing everything byte-based, but that's a more invasive change that requires a

[Qemu-devel] [PATCH v2 for-4.0 00/13] block: byte-based blocking read/write

Based-on: <20181114210548.1098207-1-ebl...@redhat.com> [file-posix: Better checks of 64-bit copy_range] Based-on: <20181101182738.70462-1-vsement...@virtuozzo.com> [0/7 qcow2 decompress in threads] - more specifically, on Kevin's block-next branch Also available at

[Qemu-devel] [PATCH v2 02/13] vdi: Switch to byte-based calls

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the vdi driver. Ideally, the vdi driver should switch to doing everything byte-based, but that's a more invasive change that requires a bit

[Qemu-devel] [PATCH v2 01/13] qcow2: Prefer byte-based calls into bs->file

We had only a few sector-based stragglers left; convert them to use our preferred byte-based accesses. Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia --- v2: rebased to threaded decompression handling [moved from a different series] v5: commit message tweak v2: indentation fix ---

[Qemu-devel] [PATCH v2 07/13] blklogwrites: Audit for read/write 64-bit cleanness

Nothing in blk_log_writes_co_do_log() is inherently limited by a 32-bit type; document this by updating the refresh_limits callback to document that this driver is 64-bit clean. Signed-off-by: Eric Blake --- block/blklogwrites.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH] hax: Support for Linux hosts

Intel HAXM supports now 32-bit and 64-bit Linux hosts. This patch includes the corresponding userland changes. Since the Darwin userland backend is POSIX-compliant, the hax-darwin.{c,h} files have been renamed to hax-posix.{c,h}. This prefix is consistent with the naming used in the rest of QEMU.

[Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

Many of the current virtio-*-pci device types actually represent 3 different types of devices: * virtio 1.0 non-transitional devices * virtio 1.0 transitional devices * virtio 0.9 ("legacy device" in virtio 1.0 terminology) That would be just an annoyance if it didn't break our device/bus

[Qemu-devel] [PATCH for-3.1?] file-posix: Better checks of 64-bit copy_range

file-posix.c was taking a 64-bit bytes in raw_co_copy_range_to(), passing it through a 32-bit parameter of paio_submit_co_full(), then widening it back to size_t when assigning into acb->aio_nbytes. Looking at io.c, I can't quickly tell if bdrv_co_copy_range_internal() is fragmenting things to

[Qemu-devel] [RFC for-3.2 PATCH 7/7] vfio/pci: Remove PCIe Link Status emulation

Now that the downstream port will virtually negotiate itself to the link status of the downstream devie, we can remove this emulation. It's not clear that it was every terribly useful anyway. Signed-off-by: Alex Williamson --- hw/vfio/pci.c |6 -- 1 file changed, 6 deletions(-) diff

[Qemu-devel] [RFC for-3.2 PATCH 6/7] pcie: Allow generic PCIe root port to specify link speed and width

Allow users to specify speed and width values for the generic PCIe root port. Defaults remain at 2.5GT/s & x1 for compatiblity. Machine based defaults to increase this, such as if we wanted a pc-q35-3.2 machine to default to 16GT/s & x32, can be triggered by implementing an instance_init

[Qemu-devel] [RFC for-3.2 PATCH 3/7] qapi: Define PCIe link speed and width properties

Create properties to be able to define speeds and widths for PCIe links. The only tricky bit here is that our get and set callbacks translate from the fixed QAPI automagic enums to those we define in PCI code to represent the actual register segment value. Signed-off-by: Alex Williamson ---

[Qemu-devel] [RFC for-3.2 PATCH 5/7] pcie: Fill PCIESlot link fields to support higher speeds and widths

Make use of the PCIESlot speed and width fields to update link information beyond those configured in pcie_cap_v1_fill(). This is only called for devices supporting a version 2 capability and automatically skips any non-PCIESlot devices. Only devices with increased link values generate any

Re: [Qemu-devel] [PATCH for-3.2 29/41] slirp: improve a bit the debug macros

Hi On Wed, Nov 14, 2018 at 6:04 PM Daniel P. Berrangé wrote: > > On Wed, Nov 14, 2018 at 04:36:31PM +0400, Marc-André Lureau wrote: > > Let them accept multiple arguments. Simplify the inner argument > > handling of DEBUG_ARGS/DEBUG_MISC_DEBUG_ERROR. > > > > Signed-off-by: Marc-André Lureau > >

[Qemu-devel] [RFC for-3.2 PATCH 2/7] pci: Sync PCIe downstream port LNKSTA on read

The PCIe link speed and width between a downstream device and its upstream port is negotiated on real hardware and susceptible to dynamic changes due to signal issues and power management. In the emulated device case there is no real hardware link, but we still might wish to have some consistency

[Qemu-devel] [RFC for-3.2 PATCH 4/7] pcie: Add link speed and width fields to PCIESlot

Add fields allowing the PCIe link speed and width of a PCIESlot to be configured, with an instance_post_init callback on the root port parent class to set defaults. This allows child classes to via properties, without requiring all implementions to support arbitrary user selected values, and also

[Qemu-devel] [RFC for-3.2 PATCH 1/7] pcie: Create enums for link speed and width

In preparation for reporting higher virtual link speeds and widths, create enums and macros to help us manage them. Signed-off-by: Alex Williamson --- hw/pci/pcie.c |7 --- hw/vfio/pci.c |3 ++- include/hw/pci/pcie_regs.h | 23 +-- 3

[Qemu-devel] [RFC for-3.2 PATCH 0/7] pcie: Enhanced link speed and width support

QEMU exposes gen1 PCI-express interconnect devices supporting only 2.5GT/s and x1 width. It might not seem obvious that a virtual bandwidth limitation can result in a real performance degradation, but it's been reported that in some configurations assigned GPUs might not scale their link speed up

Re: [Qemu-devel] [PATCH for-3.1 v2] build: qga: add macro to force use of native mingw32 assert()

Quoting Daniel P. Berrangé (2018-11-14 10:54:56) > On Wed, Nov 14, 2018 at 10:44:38AM -0600, Michael Roth wrote: > > When building qemu-ga for w32 with VSS support, some parts of qemu-ga > > are not linked against glib, specifically the C++ bits used to > > create the VSS provider DLL. With

Re: [Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests

On 14.11.18 17:21, Markus Armbruster wrote: > David Hildenbrand writes: > >> Basically copy all int64 list tests but adapt them to work on uint64 >> instead. >> >> Signed-off-by: David Hildenbrand >> --- >> tests/test-string-input-visitor.c | 71 +-- >> 1 file

Re: [Qemu-devel] [PATCH v2 07/11] block: Leave BDS.backing_file constant

On 13.11.18 00:08, Eric Blake wrote: > On 8/9/18 5:31 PM, Max Reitz wrote: >> Parts of the block layer treat BDS.backing_file as if it were whatever >> the image header says (i.e., if it is a relative path, it is relative to >> the overlay), other parts treat it like a cache for >>

Re: [Qemu-devel] [PATCH v2 04/11] block: Storage child access function

On 12.11.18 23:32, Eric Blake wrote: > On 8/9/18 5:31 PM, Max Reitz wrote: >> For completeness' sake, add a function for accessing a node's storage >> child, too.  For filters, this is there filtered child; for non-filters, > > s/there/their/ > >> this is bs->file. >> >> Some places are

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

On 14.11.18 18:38, Markus Armbruster wrote: > David Hildenbrand writes: > >> The input visitor has some problems right now, especially >> - unsigned type "Range" is used to process signed ranges, resulting in >> inconsistent behavior and ugly/magical code >> - uint64_t are parsed like int64_t,

Re: [Qemu-devel] [PATCH v2 03/11] block: Filtered children access functions

On 12.11.18 23:17, Eric Blake wrote: > On 8/9/18 5:31 PM, Max Reitz wrote: >> What bs->file and bs->backing mean depends on the node.  For filter >> nodes, both signify a node that will eventually receive all R/W >> accesses.  For format nodes, bs->file contains metadata and data, and >>

Re: [Qemu-devel] [PATCH] cpus: run work items for all vCPUs if single-threaded

On Wed, Nov 14, 2018 at 12:44:00 +0100, Paolo Bonzini wrote: > This avoids the following deadlock: > > 1) a thread calls run_on_cpu for CPU 2 from a timer, and single_tcg_halt_cond > is signaled > > 2) CPU 1 is running and exits. It finds no work item and enters CPU 2 > > 3) because the I/O

Re: [Qemu-devel] [Qemu-block] KVM Forum block no[td]es

On 11/12/18 10:25 AM, Max Reitz wrote: > On 12.11.18 00:36, Nir Soffer wrote: >> On Mon, Nov 12, 2018 at 12:25 AM Max Reitz > > wrote: >> >> This is what I’ve taken from two or three BoF-like get-togethers on >> blocky things.  Amendments are more than welcome,

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

On Wed, Nov 14, 2018 at 7:17 PM Peter Maydell wrote: > On 14 November 2018 at 11:06, Thomas Huth wrote: > > On 2018-11-14 11:47, Peter Xu wrote: > >> On Thu, Nov 01, 2018 at 10:12:26AM +0800, Zhang Chen wrote: > >>> This compilation issue will occur when user use --disable-replication > >>> to

[Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks

From: Zhang Chen Current COLO mode(independent disk mode) need replication module work together. Suggested by Dr. David Alan Gilbert . Signed-off-by: Zhang Chen --- migration/migration.c | 9 + 1 file changed, 9 insertions(+) diff --git a/migration/migration.c b/migration/migration.c

Re: [Qemu-devel] [RFC PATCH 0/3] Series short description

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 154219299016.19470.9372139354280787961.stgit@wayrath Type: series Subject: [Qemu-devel] [RFC PATCH 0/3] Series short description === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [RFC 44/48] cpus: lockstep execution support

On Wed, Nov 14, 2018 at 16:43:22 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Signed-off-by: Emilio G. Cota > > --- > > > > > void cpu_interrupt(CPUState *cpu, int mask); > > diff --git a/cpus.c b/cpus.c > > index 3efe89354d..a446632a5c 100644 > > --- a/cpus.c > > +++ b/cpus.c

Re: [Qemu-devel] [RFC 01/48] cpu: introduce run_on_cpu_no_bql

Emilio G. Cota writes: > On Wed, Nov 14, 2018 at 11:30:19 +, Alex Bennée wrote: >> >> Emilio G. Cota writes: >> >> > This allows us to queue synchronous CPU work without the BQL. >> > >> > Will gain a user soon. >> >> This is also in the cpu-lock series right? > > No, in the cpu-lock

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

On Thu, Oct 18, 2018 at 12:25:12PM +0200, Andrea Bolognani wrote: > On Wed, 2018-10-17 at 12:01 -0300, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > > > The proposal doesn't directly address the interaction between virtio > > > protocol version and

Re: [Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project

* Markus Armbruster (arm...@redhat.com) wrote: > Thomas Huth writes: > > > On 2018-11-14 15:46, Markus Armbruster wrote: > >> Thomas Huth writes: > >> > >>> On 2018-11-14 13:59, Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi, > > > > Based-on:

Re: [Qemu-devel] [PATCH] MAINTAINERS: list myself as maintainer for various Arm boards

On 14/11/2018 3:12 am, Peter Maydell wrote: On 13 November 2018 at 20:10, Alistair Francis wrote: These two and the Xilinx boards seem a little out of place in this patch. I agree they probably aren't maintained as well as they should be, but the patch talks about orphaned boards and these

Re: [Qemu-devel] [RFC 09/48] tcg: reset runtime helpers when flushing the code cache

On Wed, Nov 14, 2018 at 17:01:13 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > In preparation for adding plugin support. One of the clean-up > > actions when uninstalling plugins will be to flush the code > > cache. We'll also have to clear the runtime helpers, since > > some of

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

On Wed, Nov 14, 2018 at 16:11:35 +, Alex Bennée wrote: > > Emilio G. Cota writes: (snip) > I needed to do this: > > modified tcg/tcg.c > @@ -884,7 +884,7 @@ static TCGTemp *tcg_global_reg_new_internal(TCGContext > *s, TCGType type, > > static inline uint32_t tcg_helper_func_hash(const

Re: [Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project

Thomas Huth writes: > On 2018-11-14 15:46, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 2018-11-14 13:59, Markus Armbruster wrote: Marc-André Lureau writes: > Hi, > > Based-on: https://people.debian.org/~sthibault/qemu.git/ slirp branch > > This

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

On Wed, Nov 14, 2018 at 14:41:53 +, Alex Bennée wrote: > Emilio G. Cota writes: (snip) > > -static GHashTable *helper_table; > > +static struct qht helper_table; > > +static bool helper_table_inited; > > Having a flag for initialisation seems a little excessive considering > we've moved that

Re: [Qemu-devel] [PATCH] block/nvme: call blk_drain in NVMe reset code to avoid lockups

On 06/11/2018 12:16, Igor Druzhinin wrote: > When blk_flush called in NVMe reset path S/C queues are already freed > which means that re-entering AIO handling loop having some IO requests > unfinished will lockup or crash as their SG structures being potentially > reused. Call blk_drain before

Re: [Qemu-devel] [PATCH RFC 3/6] qapi: rewrite string-input-visitor

David Hildenbrand writes: > The input visitor has some problems right now, especially > - unsigned type "Range" is used to process signed ranges, resulting in > inconsistent behavior and ugly/magical code > - uint64_t are parsed like int64_t, so big uint64_t values are not > supported and

Re: [Qemu-devel] [PATCH v3 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: cover.1542187291.git.xiezh...@huawei.com Type: series Subject: [Qemu-devel] [PATCH v3 0/4]

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] block: Removed unused sector-based blocking I/O

[Reviving an old series] On 5/3/18 8:36 AM, Alberto Garcia wrote: On Fri 27 Apr 2018 05:43:33 PM CEST, Eric Blake wrote: -static int bdrv_rw_co(BdrvChild *child, int64_t sector_num, uint8_t *buf, - int nb_sectors, bool is_write, BdrvRequestFlags flags) -{ -QEMUIOVector

Re: [Qemu-devel] KVM Forum block no[td]es

On 13.11.18 16:12, Alberto Garcia wrote: > On Sun 11 Nov 2018 11:25:00 PM CET, Max Reitz wrote: > >> Permission system >> = >> >> GRAPH_MOD >> - >> >> We need some way for the commit job to prevent graph changes on its >> chain while it is running. Our current blocker

Re: [Qemu-devel] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code()

On 2018-07-10 18:00, Peter Maydell wrote: > Now that all the callers can handle get_page_addr_code() returning -1, > remove all the code which tries to handle execution from MMIO regions > or small-MMU-region RAM areas. This will mean that we can correctly > execute from these areas, rather than

Re: [Qemu-devel] [RFC 02/48] trace: expand mem_info:size_shift to 3 bits

On Wed, Nov 14, 2018 at 13:03:19 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > This will allow us to trace 16B-long memory accesses. > > > > While at it, add some defines for the mem_info bits and simplify > > trace_mem_get_info by making it a wrapper around trace_mem_build_info. >

Re: [Qemu-devel] [PATCH v3 0/4] fsdev-throttle-qmp: qmp interface for fsdev io throttling

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: cover.1542187291.git.xiezh...@huawei.com Type: series Subject: [Qemu-devel] [PATCH v3 0/4]

Re: [Qemu-devel] [RFC 01/48] cpu: introduce run_on_cpu_no_bql

On Wed, Nov 14, 2018 at 11:30:19 +, Alex Bennée wrote: > > Emilio G. Cota writes: > > > This allows us to queue synchronous CPU work without the BQL. > > > > Will gain a user soon. > > This is also in the cpu-lock series right? No, in the cpu-lock series we add async_run_on_cpu_no_bql;

Re: [Qemu-devel] [RFC 09/48] tcg: reset runtime helpers when flushing the code cache

Emilio G. Cota writes: > In preparation for adding plugin support. One of the clean-up > actions when uninstalling plugins will be to flush the code > cache. We'll also have to clear the runtime helpers, since > some of those runtime helpers may belong to the plugin > being uninstalled. > >

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

On 11/14/2018 05:56 PM, Thomas Huth wrote: > On 2018-11-14 17:49, Peter Maydell wrote: >> On 14 November 2018 at 16:39, Philippe Mathieu-Daudé >> wrote: >>> Hi Thomas, >>> >>> On 14/11/18 17:29, Thomas Huth wrote: Please don't. For rationale, see:

Re: [Qemu-devel] [PATCH resend for-3.1] make-release: add skiboot .version file

Quoting Michael Roth (2018-11-09 10:13:52) > This is needed to build skiboot from tarball-distributed sources > since the git data the make_release.sh script relies on to generate > it is not available. > > Cc: qemu-sta...@nongnu.org > Reported-by: Michael Tokarev > Signed-off-by: Michael Roth

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

On 2018-11-14 17:49, Peter Maydell wrote: > On 14 November 2018 at 16:39, Philippe Mathieu-Daudé > wrote: >> Hi Thomas, >> >> On 14/11/18 17:29, Thomas Huth wrote: >>> Please don't. For rationale, see: >>> https://www.kernel.org/doc/html/v4.19/process/coding-style.html#typedefs >> >> >> Thanks

Re: [Qemu-devel] [PATCH for-3.1 v2] build: qga: add macro to force use of native mingw32 assert()

On Wed, Nov 14, 2018 at 10:44:38AM -0600, Michael Roth wrote: > When building qemu-ga for w32 with VSS support, some parts of qemu-ga > are not linked against glib, specifically the C++ bits used to > create the VSS provider DLL. With 3ebee3b191e, we now define assert() > as g_assert() for all

Re: [Qemu-devel] [PATCH for-3.2 00/41] RFC: slirp: make it again a standalone project

On 2018-11-14 15:46, Markus Armbruster wrote: > Thomas Huth writes: > >> On 2018-11-14 13:59, Markus Armbruster wrote: >>> Marc-André Lureau writes: >>> Hi, Based-on: https://people.debian.org/~sthibault/qemu.git/ slirp branch This series goal is to allow building

Re: [Qemu-devel] [PATCH v2 1/1] qga: update docs with systemd suspend support info

Quoting Daniel Henrique Barboza (2018-11-13 10:55:39) > Commit 067927d62e ("qga: systemd hibernate/suspend/hybrid-sleep > support") failed to update qapi-schema.json after adding systemd > hibernate/suspend/hybrid-sleep capabilities to guest-suspend-* QGA > commands. > > Signed-off-by: Daniel

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

On 14 November 2018 at 16:39, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 14/11/18 17:29, Thomas Huth wrote: >> Please don't. For rationale, see: >> https://www.kernel.org/doc/html/v4.19/process/coding-style.html#typedefs > > > Thanks for the pointer, I am interested in understanding why

[Qemu-devel] [PATCH for-3.1 v2] build: qga: add macro to force use of native mingw32 assert()

When building qemu-ga for w32 with VSS support, some parts of qemu-ga are not linked against glib, specifically the C++ bits used to create the VSS provider DLL. With 3ebee3b191e, we now define assert() as g_assert() for all mingw32 builds via osdep.h, which results in the following build

Re: [Qemu-devel] [PATCH v6 11/11] authz: delete existing ACL implementation

On Thu, Nov 08, 2018 at 12:15:54PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Oct 19, 2018 at 5:51 PM Daniel P. Berrangé > wrote: > > > > From: "Daniel P. Berrange" > > > > The 'qemu_acl' type was a previous non-QOM based attempt to provide an > > authorization facility in QEMU. Because

Re: [Qemu-devel] [RFC 08/48] tcg: export tcg_gen_runtime_helper

Emilio G. Cota writes: > This takes the TCGHelperInfo directly, which will allow us to generate > helpers at run-time. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > tcg/tcg.h | 2 ++ > tcg/tcg.c | 50 +- > 2 files

Re: [Qemu-devel] [RFC 44/48] cpus: lockstep execution support

Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > > void cpu_interrupt(CPUState *cpu, int mask); > diff --git a/cpus.c b/cpus.c > index 3efe89354d..a446632a5c 100644 > --- a/cpus.c > +++ b/cpus.c > + > +static void cpu_lockstep_init(CPUState *cpu) > +{ > +if

Re: [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

Hi Jean, On 11/14/18 5:01 PM, Jean-Philippe Brucker wrote: > On 09/11/2018 11:29, Eric Auger wrote: >> +static void create_virtio_iommu(VirtMachineState *vms, >> +const char *pciehb_nodename, PCIBus *bus) >> +{ >> +const char compat[] = "virtio,pci-iommu"; >> +

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

Hi Thomas, On 14/11/18 17:29, Thomas Huth wrote: On 2018-11-14 16:32, Philippe Mathieu-Daudé wrote: What about enforcing the constness in the typedef? -- >8 -- @@ -32 +32 @@ typedef struct VMStateDescription VMStateDescription; -typedef struct VMStateField VMStateField; +typedef const struct

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

On 2018-11-14 16:32, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 14/11/18 14:29, Marc-André Lureau wrote: >> Because they are supposed to remain const. >> >> Signed-off-by: Marc-André Lureau >> --- >>   include/migration/vmstate.h |   6 +- >>   hw/display/virtio-gpu.c |   4 +- >>  

Re: [Qemu-devel] [PULL V2 24/26] net: ignore packet size greater than INT_MAX

On Wed, Nov 14, 2018 at 10:59:32AM +0800, Jason Wang wrote: > > On 2018/11/13 下午11:41, Dima Stepanov wrote: > >Hi Jason, > > > >I know that this patch has been already merged to stable, but i have a > >question: > > > >On Fri, Oct 19, 2018 at 11:22:23AM +0800, Jason Wang wrote: > >>There should

Re: [Qemu-devel] [PATCH RFC 5/6] test-string-input-visitor: split off uint64 list tests

David Hildenbrand writes: > Basically copy all int64 list tests but adapt them to work on uint64 > instead. > > Signed-off-by: David Hildenbrand > --- > tests/test-string-input-visitor.c | 71 +-- > 1 file changed, 67 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC 07/48] tcg: export TCGHelperInfo

Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > tcg/tcg.h | 7 +++ > tcg/tcg.c | 7 --- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tcg/tcg.h b/tcg/tcg.h > index f4efbaa680..9f9643b470 100644 > --- a/tcg/tcg.h > +++

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

Emilio G. Cota writes: > This will allow us to add TCG helpers at run-time. > > While at it, rename tcg_find_helper to tcg_helper_find for consistency > with the added tcg_helper_foo functions. > > Signed-off-by: Emilio G. Cota > --- > tcg/tcg.c | 59

Re: [Qemu-devel] [PATCH RFC 2/6] qapi: use qemu_strtod() in string-input-visitor

David Hildenbrand writes: > Let's use the new function. > > Signed-off-by: David Hildenbrand > --- > qapi/string-input-visitor.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index

Re: [Qemu-devel] [RFC v8 11/18] virtio-iommu: Add an msi_bypass property

On 09/11/2018 11:29, Eric Auger wrote: > +static void virtio_iommu_register_resv_region(viommu_endpoint *ep, > + uint8_t subtype, > + uint64_t start, uint64_t end) > +{ > +viommu_interval *interval; > +

Re: [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

On 09/11/2018 11:29, Eric Auger wrote: > +static void create_virtio_iommu(VirtMachineState *vms, > +const char *pciehb_nodename, PCIBus *bus) > +{ > +const char compat[] = "virtio,pci-iommu"; > +uint16_t bdf = 0x8; /* 00:01.0 */ > +DeviceState *dev; > +

Re: [Qemu-devel] [RFC v8 10/18] virtio-iommu: Implement probe request

Hi Eric, A few issues creeped in when the resv_mem structure changed On 09/11/2018 11:29, Eric Auger wrote: > +#define SUPPORTED_PROBE_PROPERTIES (\ > +VIRTIO_IOMMU_PROBE_T_NONE | \ > +VIRTIO_IOMMU_PROBE_T_RESV_MEM) You might be missing "1 <<" here, since the properties types are normal

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

Fredrik wrote: > Philippe wrote: > > > Then we will fix this for the 4.0 release. > > What exactly needs to be fixed regarding the psABI? The relevant opcodes > would need to stay, and not be prohibited and removed as Aleksandar has > suggested, since such opcode removal breaks the psABI

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

Hi Fredrik, On Wed, Nov 14, 2018 at 4:31 PM Fredrik Noring wrote: > On Tue, Nov 13, 2018 at 11:51:54PM +0100, Philippe Mathieu-Daudé wrote: [...] > > At some point while reading your reviews, I understood the R5900 > > patches introduced incorrect behaviors for the non-R5900 cpus. In this > >

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

On 14/11/2018 02:38, Li Qiang wrote: > > > Paolo Bonzini mailto:pbonz...@redhat.com>> 于2018 > 年11月14日周三 上午2:27写道： > > On 13/11/2018 11:17, Kevin Wolf wrote: > > Am 13.11.2018 um 02:45 hat Li Qiang geschrieben: > >> Ping what't the status of this patch. > >> > >> I see

Re: [Qemu-devel] [RFC PATCH 1/3] i386: add properties for customizing L2 and L3 caches size

On Wed, 2018-11-14 at 08:14 -0600, Eric Blake wrote: > On 11/14/18 4:56 AM, Dario Faggioli wrote: > > --- > > 0 files changed > > That's an odd diffstat. Why is git not giving you the normal > diffstat > with an actual summary of files changed? > Ah, more weirdness about this submission. :-O

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

On Wed, Nov 14, 2018 at 3:02 PM Aleksandar Markovic wrote: > Philippe Mathieu-Daudé wrote: > > > Can you add: > > > > This reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de. > > > > Or > > > > Fixes: ed4f49ba9 > > > > when applying? > > Sure, I'll add something along that line. > > > If

Re: [Qemu-devel] [PATCH] tests: add /vmstate/simple/array

On 14/11/18 14:21, Marc-André Lureau wrote: A very simple test to show VMSTATE_*_ARRAY usage and result. It could be systematically extended to other primitives, but I leave that as an exercise for others :). If this patch get accepted, please add this good idea to the BiteSizedTasks wiki

Re: [Qemu-devel] [PATCH] vmstate: constify VMStateField

Hi Marc-André, On 14/11/18 14:29, Marc-André Lureau wrote: Because they are supposed to remain const. Signed-off-by: Marc-André Lureau --- include/migration/vmstate.h | 6 +- hw/display/virtio-gpu.c | 4 +- hw/intc/s390_flic_kvm.c | 4 +- hw/nvram/eeprom93xx.c | 6

  1   2   3   >