On 11/22/18 5:11 AM, David Gibson wrote:
> On Fri, Nov 16, 2018 at 11:56:57AM +0100, Cédric Le Goater wrote:
>> The XiveRouter models the second sub-engine of the overall XIVE
>> architecture : the Interrupt Virtualization Routing Engine (IVRE).
>>
>> The IVRE handles event notifications of the
On Thu, Nov 22, 2018 at 03:11:39AM +0100, Philippe Mathieu-Daudé wrote:
> Step in to maintain it, with Laszlo (EDK2) and Gerd (SeaBIOS)
> as designated reviewers.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Gerd Hoffmann
On Thu, Nov 22, 2018 at 12:00:23AM +0100, Samuel Thibault wrote:
> Hello,
>
>
> Marc-André Lureau, le jeu. 22 nov. 2018 02:06:42 +0400, a ecrit:
> > Remove a dependency on QEMU. Use the existing logging facilities.
> > Set SLIRP_DEBUG=tftp to get tftp log.
>
> As mentioned before, I was
On 11/22/18 4:19 AM, David Gibson wrote:
> On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote:
>> The 'sent' status of the LSI interrupt source is modeled with the 'P'
>> bit of the ESB and the assertion status of the source is maintained in
>> an array under the main sPAPRXive
Hi,
> Something somewhere in this call chain should have taken
> the iothread lock, I assume, but I'm not sure where.
>
> Gerd -- what are the rules of the UI subsystem regarding
> multiple threads, and what threads are allowed to call
> UI functions like qemu_input_event_send_key_qcode(),
>
On 11/22/18 4:05 AM, David Gibson wrote:
> On Fri, Nov 16, 2018 at 11:56:54AM +0100, Cédric Le Goater wrote:
>> The first sub-engine of the overall XIVE architecture is the Interrupt
>> Virtualization Source Engine (IVSE). An IVSE can be integrated into
>> another logic, like in a PCI PHB or in
On 16.11.2018 13:52, Paolo Bonzini wrote:
> On 14/11/18 14:04, Alexandro Sanchez Bach wrote:
>> Intel HAXM supports now 32-bit and 64-bit Linux hosts. This patch includes
>> the corresponding userland changes.
>>
>> Since the Darwin userland backend is POSIX-compliant, the hax-darwin.{c,h}
>>
From: Xiao Guangrong
It's the benhcmark of threaded-workqueue, also it's a good
example to show how threaded-workqueue is used
Signed-off-by: Xiao Guangrong
---
tests/Makefile.include | 5 +-
tests/threaded-workqueue-bench.c | 255 +++
2 files
From: Xiao Guangrong
Adapt the compression code to the threaded workqueue
Signed-off-by: Xiao Guangrong
---
migration/ram.c | 308
1 file changed, 110 insertions(+), 198 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index
From: Xiao Guangrong
Adapt the compression code to the threaded workqueue
Signed-off-by: Xiao Guangrong
---
migration/ram.c | 222
1 file changed, 77 insertions(+), 145 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index
From: Xiao Guangrong
This modules implements the lockless and efficient threaded workqueue.
Three abstracted objects are used in this module:
- Request.
It not only contains the data that the workqueue fetches out
to finish the request but also offers the space to save the result
From: Xiao Guangrong
It will be used by threaded workqueue
Signed-off-by: Xiao Guangrong
---
include/qemu/bitops.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index 3f0926cf40..c522958852 100644
--- a/include/qemu/bitops.h
From: Xiao Guangrong
Changelog in v3:
Thanks to Emilio's comments and his example code, the changes in
this version are:
1. move @requests from the shared data struct to each single thread
2. move completion ev from the shared data struct to each single thread
3. move bitmaps from the shared
Add query-display-options command, which allows querying the qemu
display configuration, and -- as an intentional side effect -- makes
DisplayOptions discoverable via query-qmp-schema so libvirt can go
figure which display options are supported.
Use case: commit d4dc4ab1 added rendernode
Hi
On Thu, Nov 22, 2018 at 2:41 AM Samuel Thibault wrote:
>
> Marc-André Lureau, le jeu. 22 nov. 2018 02:06:18 +0400, a ecrit:
> > Somehow, I broke the build and failed to detect it. Please squash!
>
> > +#include "qemu/osdep.h"
> > +
> > +typedef uint32_t tcp_seq;
>
> I preferred to just use
Hi
On Thu, Nov 22, 2018 at 2:54 AM Samuel Thibault
wrote:
>
> to get them out of the hot path.
>
> Signed-off-by: Samuel Thibault
> ---
> slirp/debug.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/slirp/debug.h b/slirp/debug.h
> index ff920f0b87..ad4e07aa01
On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote:
>
> Sorry, didn't think of this in my first reply.
>
> 1) Does the hardware ever actually write back to the EAS? I know it
> does for the END, but it's not clear why it would need to for the
> EAS. If not, we don't need the setter.
Nope,
On Thu, 2018-11-22 at 15:41 +1100, David Gibson wrote:
>
> > +void xive_end_reset(XiveEND *end)
> > +{
> > +memset(end, 0, sizeof(*end));
> > +
> > +/* switch off the escalation and notification ESBs */
> > +end->w1 = END_W1_ESe_Q | END_W1_ESn_Q;
>
> It's not obvious to me what
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181120184148.22501-1-pbonz...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH] nvme: fix out-of-bounds access to the CMB
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
According https://wiki.qemu.org/Contribute/BiteSizedTasks
the 'DEFINE_PROP_PTR' should be replaced by QOM link property.
The first patch replace constant strings with TYPE_ and move some
definition to pc.h header file so that the second patch can work.
Li Qiang (2):
hw: pc: use TYPE_XXX
Use link property instead.
Signed-off-by: Li Qiang
---
hw/i386/pc.c | 2 +-
hw/i386/vmmouse.c | 17 +++--
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 5d3fd86b83..9b343b4fd1 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@
Signed-off-by: Li Qiang
---
hw/i386/pc.c | 9 +++--
hw/sparc64/sun4u.c | 2 +-
include/hw/i386/pc.h | 7 +++
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f095725dba..5d3fd86b83 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@
On Fri, Nov 16, 2018 at 11:56:57AM +0100, Cédric Le Goater wrote:
> The XiveRouter models the second sub-engine of the overall XIVE
> architecture : the Interrupt Virtualization Routing Engine (IVRE).
>
> The IVRE handles event notifications of the IVSE through MMIO stores
> and performs the
On Fri, Nov 16, 2018 at 11:56:55AM +0100, Cédric Le Goater wrote:
> The 'sent' status of the LSI interrupt source is modeled with the 'P'
> bit of the ESB and the assertion status of the source is maintained in
> an array under the main sPAPRXive object. The type of the source is
> stored in the
On Fri, Nov 16, 2018 at 11:56:57AM +0100, Cédric Le Goater wrote:
> The XiveRouter models the second sub-engine of the overall XIVE
> architecture : the Interrupt Virtualization Routing Engine (IVRE).
>
> The IVRE handles event notifications of the IVSE through MMIO stores
> and performs the
On Fri, Nov 16, 2018 at 11:56:58AM +0100, Cédric Le Goater wrote:
> To complete the event routing, the IVRE sub-engine uses an internal
> table containing Event Notification Descriptor (END) structures.
>
> An END specifies on which Event Queue (EQ) the event notification
> data, defined in the
On Wed, Nov 21, 2018 at 02:03:59PM +0100, Maxime Coquelin wrote:
> Hi Wei,
>
> On 10/11/18 4:08 PM, w...@redhat.com wrote:
> >From: Wei Xu
> >
> >(cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6)
> >Signed-off-by: Wei Xu
> >(cherry picked from commit
On Wed, Nov 21, 2018 at 10:39:20PM +0800, Tiwei Bie wrote:
> Hi Wei,
>
> FYI, the latest packed ring series for guest driver doesn't set
> the _F_NEXT bit for indirect descriptors any more. So below hack
> in guest driver is needed to make it work with this series:
OK, will do a test, thanks.
After adding a configuration file under /etc/X11/xorg.conf.d with below lines,
we can finally see remote mouse cursor on the VNC viewer.
Section "Device"
Option "SWcursor" "True"
Identifier "Card0"
Driver "modesetting"
BusID "PCI:10:3:0"
On Fri, Nov 16, 2018 at 11:56:54AM +0100, Cédric Le Goater wrote:
> The first sub-engine of the overall XIVE architecture is the Interrupt
> Virtualization Source Engine (IVSE). An IVSE can be integrated into
> another logic, like in a PCI PHB or in the main interrupt controller
> to manage IPIs.
> >
> > +void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr) {
> > +ram_addr_t ram_addr;
> > +hwaddr paddr;
> > +
> > +assert(code == BUS_MCEERR_AR || code == BUS_MCEERR_AO);
> > +if (addr) {
> > +ram_addr = qemu_ram_addr_from_host(addr);
> > +if
On Thu, Nov 22, 2018 at 03:11:39AM +0100, Philippe Mathieu-Daudé wrote:
> Step in to maintain it, with Laszlo (EDK2) and Gerd (SeaBIOS)
> as designated reviewers.
>
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Eduardo Habkost
> ---
> Note than OpenBIOS also consumes this device
On Wed, Nov 21, 2018 at 6:13 PM Palmer Dabbelt wrote:
>
> On Wed, 21 Nov 2018 15:26:01 PST (-0800), log...@deltatee.com wrote:
> >
> >
> > On 2018-11-21 4:10 p.m., Guenter Roeck wrote:
> >> FWIW, I absoutely agree. If the board can only be used to boot an initrd,
> >> it is quite pointless to
On 2018/11/22 上午1:39, Michael S. Tsirkin wrote:
On Wed, Nov 21, 2018 at 11:30:41AM -0600, Eric Blake wrote:
On 11/21/18 6:23 AM, Michael S. Tsirkin wrote:
I agree it is good to preserve fcntl flags though, so this patch
looks desirable.
Reviewed-by: Daniel P. Berrangé
Sure
Acked-by:
On Wed, 21 Nov 2018 15:26:01 PST (-0800), log...@deltatee.com wrote:
On 2018-11-21 4:10 p.m., Guenter Roeck wrote:
FWIW, I absoutely agree. If the board can only be used to boot an initrd,
it is quite pointless to have it around. Actually it is worse than pointless,
since it will result in
Step in to maintain it, with Laszlo (EDK2) and Gerd (SeaBIOS)
as designated reviewers.
Signed-off-by: Philippe Mathieu-Daudé
---
Note than OpenBIOS also consumes this device (PPC/Sparc).
MAINTAINERS | 13 +
1 file changed, 13 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
On Wed, Nov 21, 2018 at 3:55 PM Palmer Dabbelt wrote:
>
> There's three of us that are paid to work on this.
>
> Signed-off-by: Palmer Dabbelt
Reviewed-by: Alistair Francis
Alistair
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS
On Wed, Nov 21, 2018 at 5:58 PM Palmer Dabbelt wrote:
>
> On Wed, 21 Nov 2018 14:34:44 PST (-0800), Alistair Francis wrote:
> > Ensure that the calculate initrd offset points to a valid address for
> > the architecture.
> >
> > Signed-off-by: Alistair Francis
> > Suggested-by: Alexander Graf
>
On Wed, 21 Nov 2018 14:34:44 PST (-0800), Alistair Francis wrote:
> Ensure that the calculate initrd offset points to a valid address for
> the architecture.
>
> Signed-off-by: Alistair Francis
> Suggested-by: Alexander Graf
> Reported-by: Alexander Graf
> ---
> hw/riscv/virt.c | 7 ++-
>
On Wed, 21 Nov 2018 16:29:09 PST (-0800), phi...@redhat.com wrote:
On 22/11/18 0:46, Palmer Dabbelt wrote:
There was a recent thread about unmaintained files in QEMU where it was
noted that a few RISC-V related files had slipped through the patterns
in our MAINTAINERS file entry. This patch
On 21/11/18 19:58, Max Filippov wrote:
Provide default RAM sizes for all XTFPGA boards, so that when started
without -m option they do the right thing.
Signed-off-by: Max Filippov
Reviewed-by: Philippe Mathieu-Daudé
---
Changes v2->v3:
- add XTFPGA_MMU_RESERVED_MEMORY_SIZE definition and
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181120121558.7660-1-richard.hender...@linaro.org
Type: series
Subject: [Qemu-devel] [PATCH 0/5] tcg: Make bswap support in qemu_ld/st optional
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181120182721.227114-1-stef...@linux.vnet.ibm.com
Type: series
Subject: [Qemu-devel] [PATCH 0/2]
On 22/11/18 0:46, Palmer Dabbelt wrote:
There was a recent thread about unmaintained files in QEMU where it was
noted that a few RISC-V related files had slipped through the patterns
in our MAINTAINERS file entry. This patch adds some more aggressive
pattern matching in an attempt to rectify
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181120182721.227114-1-stef...@linux.vnet.ibm.com
Type: series
Subject: [Qemu-devel] [PATCH 0/2] tpm:
On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote:
> On Wed, 21 Nov 2018 07:35:47 -0500
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote:
> > > On Fri, 16 Nov 2018 17:37:54 +0100
> > > Paolo Bonzini wrote:
> > >
> > > > On 16/11/18
On Fri, Nov 16, 2018 at 05:02:26PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:43 +0100
> Samuel Ortiz wrote:
>
> > In order to decouple ACPI APIs from specific machine types, we are
> > creating an ACPI builder interface that each ACPI platform can choose to
> > implement.
> > This
These machines had names that were too general: there are many E
and U machines, and it's easy for users to get confused about which one
is which. The one configuration that can faithfully match an existing
ASIC-based board has been renamed to 'sifive-hifive1', we'll work
through the emulation
There's three of us that are paid to work on this.
Signed-off-by: Palmer Dabbelt
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e89adc81d5d5..d5ec5e74f328 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -250,7 +250,7 @@ M:
There was a recent thread about unmaintained files in QEMU where it was
noted that a few RISC-V related files had slipped through the patterns
in our MAINTAINERS file entry. This patch adds some more aggressive
pattern matching in an attempt to rectify this situation.
Signed-off-by: Palmer
On Thu, Nov 15, 2018 at 02:28:54PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:38 +0100
> Samuel Ortiz wrote:
>
> > This is the standard way of building SRAT on x86 platfoms. But future
> > machine types could decide to define their own custom SRAT build method
> > through the ACPI
On 2018-11-21 4:10 p.m., Guenter Roeck wrote:
> FWIW, I absoutely agree. If the board can only be used to boot an initrd,
> it is quite pointless to have it around. Actually it is worse than pointless,
> since it will result in people wasting their time trying to get it to work.
As someone who
Hi Igor,
On Thu, Nov 15, 2018 at 01:36:58PM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:35 +0100
> Samuel Ortiz wrote:
>
> > From: Yang Zhong
> >
> > The ACPI MCFG getter is not x86 specific and could be called from
> > anywhere within generic ACPI API, so let's export it.
> So
Hi Igor,
On Wed, Nov 14, 2018 at 11:55:37AM +0100, Igor Mammedov wrote:
> On Mon, 5 Nov 2018 02:40:34 +0100
> Samuel Ortiz wrote:
>
> > From: Yang Zhong
> >
> > The AML build routines for the PCI host bridge and the corresponding
> > DSDT addition are neither x86 nor PC machine type
On Wed, Nov 21, 2018 at 02:36:22PM -0800, Palmer Dabbelt wrote:
> On Wed, 21 Nov 2018 14:23:13 PST (-0800), alistai...@gmail.com wrote:
> >On Wed, Nov 21, 2018 at 2:15 PM Palmer Dabbelt wrote:
> >>
> >>On Wed, 21 Nov 2018 13:49:53 PST (-0800), alistai...@gmail.com wrote:
> >>> On Wed, Nov 21,
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:31 +0400, a ecrit:
> We are moving to g_log() facilities to log errors and probably debug
> messages too. Let's have the "Slirp" prefix on messages slirp produces.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Hello,
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:42 +0400, a ecrit:
> Remove a dependency on QEMU. Use the existing logging facilities.
> Set SLIRP_DEBUG=tftp to get tftp log.
As mentioned before, I was hesitating to replace the tracing with a
DEBUG call. Now that I have merged to my tree
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:28 +0400, a ecrit:
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:30 +0400, a ecrit:
> This will allow to have cflags for the whole slirp.mo -objs.
> It makes it possible to build tests that links only with
> slirp-obj-y (and not the whole common-obj).
>
> It is also a step towards building slirp as a shared
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:41 +0400, a ecrit:
> Make slirp use GLib logging, instead of fprintf(), so that
> applications can filter log, process it etc.
>
> With recent versions of glib, G_MESSAGES_DEBUG must be set to "all" or
> "Slirp" to see slirp debug messages.
>
>
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:36 +0400, a ecrit:
> Make debug statements condiitonal only on slirp_debug flags, instead
> of the pre-processor DEBUG blocks, as it may introduce breakage
> easily, since the debug code isn't always compiled.
>
> Signed-off-by: Marc-André Lureau
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:23 +0400, a ecrit:
> This will allow reusing the function in a following patch.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Ensure that the calculate initrd offset points to a valid address for
the architecture.
Signed-off-by: Alistair Francis
Suggested-by: Alexander Graf
Reported-by: Alexander Graf
---
hw/riscv/virt.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/riscv/virt.c
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:37 +0400, a ecrit:
> Learn to read SLIRP_DEBUG=call,misc,error (all or help also handled)
> to set the slirp_debug flags.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:40 +0400, a ecrit:
> There is no clear benefit in calling an alias DEBUG_ARGS(). Replace
> calls with DEBUG_ARG(), and fix the white-spacing while at it.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:39 +0400, a ecrit:
> Instead, rely on slirp_debug flags, or compile unconditionally (the
> substraction in cksum is unlikely to affect any benchmark result).
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:33 +0400, a ecrit:
> Remove some clutter, and avoids direct call to fprintf().
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
to get them out of the hot path.
Signed-off-by: Samuel Thibault
---
slirp/debug.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/slirp/debug.h b/slirp/debug.h
index ff920f0b87..ad4e07aa01 100644
--- a/slirp/debug.h
+++ b/slirp/debug.h
@@ -17,7 +17,7 @@
extern int
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:38 +0400, a ecrit:
> This fixes some compilation warnings on mingw64.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
On Wed, Nov 21, 2018 at 2:15 PM Palmer Dabbelt wrote:
>
> On Wed, 21 Nov 2018 13:49:53 PST (-0800), alistai...@gmail.com wrote:
> > On Wed, Nov 21, 2018 at 1:26 PM Palmer Dabbelt wrote:
> >>
> >> On Wed, 21 Nov 2018 10:32:45 PST (-0800), alistai...@gmail.com wrote:
> >> > On Wed, Nov 21, 2018 at
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:32 +0400, a ecrit:
> Reduce dependency on QEMU. QEMU could use a custom glib log handler if
> it wants to redirect/filter it.
>
> Signed-off-by: Marc-André Lureau
Applied, thanks!
On Wed, 21 Nov 2018 14:23:13 PST (-0800), alistai...@gmail.com wrote:
On Wed, Nov 21, 2018 at 2:15 PM Palmer Dabbelt wrote:
On Wed, 21 Nov 2018 13:49:53 PST (-0800), alistai...@gmail.com wrote:
> On Wed, Nov 21, 2018 at 1:26 PM Palmer Dabbelt wrote:
>>
>> On Wed, 21 Nov 2018 10:32:45 PST
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:34 +0400, a ecrit:
> icmp_send_error() doesnt actually log messages when DEBUG is enabled.
> Let's use a different define that describes better the tweaked
> behaviour of the function, and avoid uncompiled code.
>
> Signed-off-by: Marc-André Lureau
On 2018-11-21 3:14 p.m., Alistair Francis wrote:
>> and networking works?
>
> Yep, it should. This is for the -nic option [1]. I misunderstood when
> I was going through it.
>
> We can drop this patch then.
>
> 1:
>
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:27 +0400, a ecrit:
> Make all packets expiration time based on virtual clock.
>
> Suggested-by: Paolo Bonzini
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:35 +0400, a ecrit:
> DEBUG_CALL is already handled conditionally.
>
> Signed-off-by: Marc-André Lureau
Applied to my tree, thanks!
On 2018-11-21 3:09 p.m., Alistair Francis wrote:
> Yeah, it's a real pain. I had a go at adding the SD card [1] but never
> got it fully working. Normally I just hack in the virtIO MMIO regions
> and use those.
>
> 1: https://github.com/alistair23/qemu/tree/mainline/alistair/sifive_spi.next
>
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:22 +0400, a ecrit:
> This list is not only used to handle command to execute on guest
> connection, it can also redirect to an arbitrary object, such as a
> chardev. Let's rename the struct and the field to "guestfwd".
>
> Signed-off-by: Marc-André
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:18 +0400, a ecrit:
> Somehow, I broke the build and failed to detect it. Please squash!
> +#include "qemu/osdep.h"
> +
> +typedef uint32_t tcp_seq;
I preferred to just use uint32_t instead of tcp_seq in the couple of
places where this showed up.
>
On Wed, 21 Nov 2018 14:01:34 PST (-0800), log...@deltatee.com wrote:
On 2018-11-21 2:54 p.m., Alistair Francis wrote:
The last time I tested this it worked (although I might not have
tested interrupts) and now it doesn't. Nothing has changed in the
series, my guest software has changed
On 2018-11-21 3:16 p.m., Logan Gunthorpe wrote:
>
>
> On 2018-11-21 3:14 p.m., Alistair Francis wrote:
>>> and networking works?
>>
>> Yep, it should. This is for the -nic option [1]. I misunderstood when
>> I was going through it.
>>
>> We can drop this patch then.
>>
>> 1:
>>
Introduce utility header/object, and replace remaining qemu functions
with SLIRP helpers.
Signed-off-by: Marc-André Lureau
---
slirp/ip.h | 14 +--
slirp/ip6.h | 5 +-
slirp/ip6_icmp.h| 16 ++--
slirp/libslirp.h| 12 ++-
slirp/qtailq.h | 218
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:21 +0400, a ecrit:
> Use g_spawn_async_with_fds() to setup the child.
>
> GSpawn handles reaping the child, and closing parent file descriptors.
>
> Signed-off-by: Marc-André Lureau
Ditto.
Samuel
On Wed, 21 Nov 2018 13:49:53 PST (-0800), alistai...@gmail.com wrote:
On Wed, Nov 21, 2018 at 1:26 PM Palmer Dabbelt wrote:
On Wed, 21 Nov 2018 10:32:45 PST (-0800), alistai...@gmail.com wrote:
> On Wed, Nov 21, 2018 at 10:05 AM Logan Gunthorpe wrote:
>>
>>
>>
>> On 2018-11-21 10:02 a.m.,
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:20 +0400, a ecrit:
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Samuel Thibault
I had actually already included it in my tree.
Samuel
Make state saving optional: this will allow to build SLIRP without
QEMU. (eventually, the vmstate helpers will be extracted, so an
external project & process could save its state)
Signed-off-by: Marc-André Lureau
---
slirp/slirp.h | 3 +
slirp/state.h | 9 +
slirp/slirp.c
Marc-André Lureau, le jeu. 22 nov. 2018 02:06:19 +0400, a ecrit:
> Since commit 12f8def0e02232d7c6416ad9b66640f973c531d1 (v2.9), qemu
> requires Vista. Let's remove some conditional code.
>
> Note that this introduces a missing declaration warning with mingw.
> warning: implicit declaration of
On Wed, Nov 21, 2018 at 2:07 PM Logan Gunthorpe wrote:
>
>
>
> On 2018-11-21 2:55 p.m., Alistair Francis wrote:
> > It is required for networking for PCIe devices. What PCIe device works
> > for you without this patch? Can you tell me your command line
> > arguments.
>
> I can run it without that
On Wed, 21 Nov 2018 14:01:10 PST (-0800), alistai...@gmail.com wrote:
On Wed, Nov 21, 2018 at 1:37 PM Palmer Dabbelt wrote:
On Wed, 21 Nov 2018 11:21:40 PST (-0800), alistai...@gmail.com wrote:
> On Wed, Nov 21, 2018 at 11:19 AM Logan Gunthorpe wrote:
>>
>>
>>
>> On 2018-11-21 12:16 p.m.,
Make debug statements condiitonal only on slirp_debug flags, instead
of the pre-processor DEBUG blocks, as it may introduce breakage
easily, since the debug code isn't always compiled.
Signed-off-by: Marc-André Lureau
---
slirp/debug.h | 15 +++
slirp/misc.c | 6 +-
2 files
On Wed, Nov 21, 2018 at 2:11 PM Alistair Francis wrote:
>
> On Wed, Nov 21, 2018 at 2:07 PM Logan Gunthorpe wrote:
> >
> >
> >
> > On 2018-11-21 2:55 p.m., Alistair Francis wrote:
> > > It is required for networking for PCIe devices. What PCIe device works
> > > for you without this patch? Can
This is a minimal file to build a libslirp shared library.
It has been tested to build on Linux and with mingw64 cross-compilation.
Signed-off-by: Marc-André Lureau
---
slirp/meson.build | 48 +++
1 file changed, 48 insertions(+)
create mode 100644
qemu_set_nonblock() does some event registration with the main loop on
win32, let's have a callback.
Signed-off-by: Marc-André Lureau
---
slirp/libslirp.h | 2 ++
net/slirp.c | 1 +
slirp/misc.c | 2 +-
slirp/tcp_subr.c | 4 ++--
4 files changed, 6 insertions(+), 3 deletions(-)
diff
Reduce dependency on QEMU. QEMU could use a custom glib log handler if
it wants to redirect/filter it.
Signed-off-by: Marc-André Lureau
---
slirp/misc.c | 2 +-
slirp/socket.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/slirp/misc.c b/slirp/misc.c
index
Make slirp use GLib logging, instead of fprintf(), so that
applications can filter log, process it etc.
With recent versions of glib, G_MESSAGES_DEBUG must be set to "all" or
"Slirp" to see slirp debug messages.
Reformat DEBUG_MISC & DEBUG_ERROR calls to not need \n ending.
Signed-off-by:
Introduce a SlirpCb callback to kick the main io-thread.
Add an intermediary sodrop() function that will call SlirpCb.notify
callback when sbdrop() returns true.
Signed-off-by: Marc-André Lureau
---
slirp/libslirp.h | 2 ++
slirp/sbuf.h | 2 +-
slirp/socket.h| 1 +
net/slirp.c
This will allow to have cflags for the whole slirp.mo -objs.
It makes it possible to build tests that links only with
slirp-obj-y (and not the whole common-obj).
It is also a step towards building slirp as a shared library, although
this requires a bit more thoughts to build with
net/slirp.o
Remove a dependency on QEMU. Use the existing logging facilities.
Set SLIRP_DEBUG=tftp to get tftp log.
Signed-off-by: Marc-André Lureau
---
slirp/debug.h | 13 ++---
slirp/slirp.c | 1 +
slirp/tftp.c | 7 ---
Makefile.objs | 1 -
slirp/trace-events | 5
On Wed, Nov 21, 2018 at 2:01 PM Logan Gunthorpe wrote:
>
>
>
> On 2018-11-21 2:54 p.m., Alistair Francis wrote:
> > The last time I tested this it worked (although I might not have
> > tested interrupts) and now it doesn't. Nothing has changed in the
> > series, my guest software has changed
This fixes some compilation warnings on mingw64.
Signed-off-by: Marc-André Lureau
---
slirp/ip6_icmp.c | 2 +-
slirp/ip6_input.c | 2 +-
slirp/ip6_output.c | 4 ++--
slirp/udp6.c | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/slirp/ip6_icmp.c
1 - 100 of 331 matches
Mail list logo
