Re: [Qemu-devel] [PATCH v2 02/13] spapr: Rename xics to intc in interrupt controller agnostic code

2019-01-13 Thread Cédric Le Goater
On 1/11/19 10:00 PM, Greg Kurz wrote: > All this code is used with both the XICS and XIVE interrupt controllers. I am not fond of the name : spapr_dt_intc_irq(), it seems a bit redundant. Nevertheless, Reviewed-by: Cédric Le Goater Thanks, C. > > Signed-off-by: Greg Kurz > --- >

[Qemu-devel] [PATCH 3/7] target/xtensa: extract MMU helpers

2019-01-13 Thread Max Filippov
Move MMU-related helper functions from op_helper.c and helper.c to mmu_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/helper.c | 487 -- target/xtensa/mmu_helper.c | 818

[Qemu-devel] [PATCH 2/7] target/xtensa: extract windowed registers helpers

2019-01-13 Thread Max Filippov
Move helper functions related to register windows from op_helper.c to win_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/op_helper.c | 190 - target/xtensa/win_helper.c | 222

[Qemu-devel] [PATCH 5/7] target/xtensa: extract interrupt and exception helpers

2019-01-13 Thread Max Filippov
Move helper functions related to interrupt and exception handling from op_helper.c and helper.c to exc_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/exc_helper.c | 258

[Qemu-devel] [PATCH 4/7] target/xtensa: extract debug helpers

2019-01-13 Thread Max Filippov
Move HELPER functions related to native debugging from op_helper.c to dbg_helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/dbg_helper.c | 129 target/xtensa/op_helper.c | 92

[Qemu-devel] [PATCH 7/7] target/xtensa: move non-HELPER functions to helper.c

2019-01-13 Thread Max Filippov
Move remaining non-HELPER functions from op_helper.c to helper.c. No functional changes. Signed-off-by: Max Filippov --- target/xtensa/helper.c| 61 --- target/xtensa/op_helper.c | 56 --- 2 files changed,

[Qemu-devel] [PATCH 1/7] target/xtensa: extract FPU helpers

2019-01-13 Thread Max Filippov
Move FPU-related HELPER functions from op_helper.c to fpu_helper.c No functional changes. Signed-off-by: Max Filippov --- target/xtensa/Makefile.objs | 1 + target/xtensa/fpu_helper.c | 166 target/xtensa/op_helper.c | 135

[Qemu-devel] [PATCH 0/7] target/xtensa: group helpers by functionality

2019-01-13 Thread Max Filippov
Hello, this series moves helper functions for FPU, windowed registers, MMU, native debug, interrupt and exception handling from op_helper.c and helper.c to separate *_helper.c files. There's no functional changes. Max Filippov (7): target/xtensa: extract FPU helpers target/xtensa: extract

[Qemu-devel] [PATCH 6/7] target/xtensa: drop dump_state helper

2019-01-13 Thread Max Filippov
Drop unused helper dump_state from op_helper.c Signed-off-by: Max Filippov --- target/xtensa/helper.h| 1 - target/xtensa/op_helper.c | 11 --- 2 files changed, 12 deletions(-) diff --git a/target/xtensa/helper.h b/target/xtensa/helper.h index 2ebba0b2c2bf..89eb97e26514 100644 ---

Re: [Qemu-devel] [PATCH] ftgmac100: implement the new MDIO interface on Aspeed SoC

2019-01-13 Thread Cédric Le Goater
On 1/14/19 4:29 AM, Joel Stanley wrote: > On Fri, 11 Jan 2019 at 23:58, Cédric Le Goater wrote: >> >> The PHY behind the MAC of an Aspeed SoC can be controlled using two >> different MDC/MDIO interfaces. The same registers PHYCR (MAC60) and >> PHYDATA (MAC64) are involved but they have a

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Peter Xu
On Mon, Jan 14, 2019 at 08:02:23AM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: > >> From: Fei Li > >> > >> Let's supplement the msi_uninit() when failing to realize > >> the pci edu device. > >> > >> Cc: Markus Armbruster >

[Qemu-devel] [PATCH] vhost-user-blk: enable discard/write zeroes features

2019-01-13 Thread Changpeng Liu
Linux commit 1f23816b8 "virtio_blk: add discard and write zeroes support" added the support in the Guest kernel, while here enable the feature bits support with vhost-user-blk driver. Also enable the test example utility with DISCARD command support. Signed-off-by: Changpeng Liu ---

Re: [Qemu-devel] [PULLv2 00/65] slirp updates

2019-01-13 Thread Samuel Thibault
no-re...@patchew.org, le dim. 13 janv. 2019 19:16:44 -0800, a ecrit: > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. > > === TEST SCRIPT BEGIN === >

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-13 Thread Pankaj Gupta
> > Until you have images (and hence host page cache) shared between > > multiple guests. People will want to do this, because it means they > > only need a single set of pages in host memory for executable > > binaries rather than a set of pages per guest. Then you have > > multiple guests

Re: [Qemu-devel] [PULLv2 00/65] slirp updates

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190114000326.29847-1-samuel.thiba...@ens-lyon.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190114000326.29847-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULLv2 00/65]

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Markus Armbruster
Peter Xu writes: > On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: >> From: Fei Li >> >> Let's supplement the msi_uninit() when failing to realize >> the pci edu device. >> >> Cc: Markus Armbruster >> Cc: Peter Xu >> Cc: Michael S. Tsirkin >> Cc: Marcel Apfelbaum >> Signed-off-by:

Re: [Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-13 Thread Markus Armbruster
Alex Bennée writes: > Aleksandar Markovic writes: > >> On Monday, January 7, 2019, Alex Bennée wrote: >> >>> >>> Hi, >>> >>> Added a few more updates mostly of IBMers with non corporate emails. >> >> >> Alex, it seems logical to me that you also create a section on gitdm in >> MAINTAINERS, and

Re: [Qemu-devel] [PATCH 0/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

2019-01-13 Thread Markus Armbruster
Leonid Bloch writes: > On 1/11/19 9:14 PM, Markus Armbruster wrote: >> Back in September, Leonid Block added a whole bunch of macros (commit > > * Bloch. :) I apologize for my carelessness. Explanation, no excuse: $ git-log --author=armbru -Sblock -i --oneline | wc -l 167 $

Re: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110191901.5082-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190110191901.5082-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the

Re: [Qemu-devel] [PATCH] hw/vfio/common: Refactor container initialization

2019-01-13 Thread Alexey Kardashevskiy
On 12/01/2019 03:45, Eric Auger wrote: > In vfio_connect_container() the code that selects the > iommu type can benefit from helpers such as > vfio_iommu_get_type() and vfio_init_container(). As > a result we end up with a switch/case on the iommu type > that makes the code a little bit more

Re: [Qemu-devel] [PATCH 1/5] vfio: update kernel headers.

2019-01-13 Thread Gerd Hoffmann
On Fri, Jan 11, 2019 at 09:32:43AM -0600, Eric Blake wrote: > On 1/11/19 3:31 AM, Gerd Hoffmann wrote: > > Temporary, for testing convinience. > > convenience > > > > > Once qemu master is synced with the linux 5.0-rc1 headers > > this is not needed any more. > > What's the timeline for when

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-13 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 10/01/19 14:30, Pavel Dovgalyuk wrote: > > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > > (including > external > > ones). > > qemu_start_warp_timer uses the deadline for setting warp timer (which > > should

[Qemu-devel] [PATCH v1 4/5] i386: enable CPUID.1F leaf generation based on spec

2019-01-13 Thread Like Xu
This patch uses the new socket/die/core/thread model to generate cpuid.1f eax/ebx/ecx/edx values especially the subleaf 2 which keeps die level information and adds an option in the cpu_x86_cpuid. Signed-off-by: Like Xu --- target/i386/cpu.c | 57

[Qemu-devel] [PATCH v1 3/5] i386: extend x86_apicid_* functions for smp_dies support

2019-01-13 Thread Like Xu
This patch rewrites the width/offset-apicid calculation with compatibility. It keeps the original symmetry as a default method and sets the die_id as well as node_id for leageacy numde_node auto-configuration. Signed-off-by: Like Xu --- hw/i386/pc.c | 37 +++---

[Qemu-devel] [PATCH v1 0/5] Introduce cpu die topology and enable CPUID.1F for i386

2019-01-13 Thread Like Xu
As we know, die is a rectangular piece of a semiconductor wafer. It's very common that chip manufacturers put a multi-core die in one package and one die always has a one-to-one relationship with one socket. Inside the die, it cotains multi-cores and core contains threads topologically. We

[Qemu-devel] [PATCH v1 2/5] vl.c: add -smp, dies=* command line support

2019-01-13 Thread Like Xu
This patch updates the check rules on legeacy -smp parse from user command and it's designed to obey the same restrictions as socket/core/thread model. Signed-off-by: Like Xu --- hmp.c | 3 +++ hw/core/machine.c | 12 vl.c | 33

[Qemu-devel] [PATCH v1 1/5] cpu: introduce die, the new cpu toppolgy emulation level

2019-01-13 Thread Like Xu
Following codes on smp_cores, the smp_dies/nr_dies/die-id is added to machine and CPUState. In addition to enable_cpuid_0xb, enable_cpuid_0x1f is introduced to track wether host is a new MCP macine or just ignored. The number for die level_type on Intel is 5 while core type keeps 2.

[Qemu-devel] [PATCH v1 5/5] i386: add CPUID.1F to cpuid_data with host_cpuid check

2019-01-13 Thread Like Xu
When cs->nr_dies is larger than 1, the CPUID.1F should be generated and is added to cpuid_data.entries for guest awareness. This patch provides a return option in kvm_has_cpuid_1f for default choice. Signed-off-by: Like Xu --- target/i386/kvm.c | 34 +-

[Qemu-devel] [Bug 1802150] Re: Guest undefined when destroyed on host after migration

2019-01-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802150 Title: Guest

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

2019-01-13 Thread Fam Zheng
> On Jan 9, 2019, at 21:59, Daniel P. Berrangé wrote: > > On Wed, Jan 09, 2019 at 01:55:04PM +, Daniel P. Berrangé wrote: >> On Wed, Nov 14, 2018 at 05:58:07PM +0800, Fam Zheng wrote: >>> On Sun, 11/11 18:20, Brad Smith wrote: ping. >>> >>> Queued. Will send a pull request soon. >>

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

2019-01-13 Thread Peter Xu
On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: > From: Fei Li > > Let's supplement the msi_uninit() when failing to realize > the pci edu device. > > Cc: Markus Armbruster > Cc: Peter Xu > Cc: Michael S. Tsirkin > Cc: Marcel Apfelbaum > Signed-off-by: Fei Li > --- > hw/misc/edu.c

Re: [Qemu-devel] [PATCH] ftgmac100: implement the new MDIO interface on Aspeed SoC

2019-01-13 Thread Joel Stanley
On Fri, 11 Jan 2019 at 23:58, Cédric Le Goater wrote: > > The PHY behind the MAC of an Aspeed SoC can be controlled using two > different MDC/MDIO interfaces. The same registers PHYCR (MAC60) and > PHYDATA (MAC64) are involved but they have a different layout. > > BIT31 of the Feature Register

Re: [Qemu-devel] [PULLv2 00/65] slirp updates

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190114000326.29847-1-samuel.thiba...@ens-lyon.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH 0/9] target/mips: Limited support for R5900 multimedia instructions

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1547403692.git.nor...@nocrew.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: cover.1547403692.git.nor...@nocrew.org Subject: [Qemu-devel] [PATCH 0/9] target/mips: Limited support for

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-13 Thread Dave Chinner
On Sun, Jan 13, 2019 at 03:38:21PM -0800, Matthew Wilcox wrote: > On Mon, Jan 14, 2019 at 10:29:02AM +1100, Dave Chinner wrote: > > Until you have images (and hence host page cache) shared between > > multiple guests. People will want to do this, because it means they > > only need a single set of

Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2019-01-13 Thread Alexey Kardashevskiy
On 04/01/2019 04:37, Dr. David Alan Gilbert wrote: > * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: >> >> >> On 17/12/2018 23:47, Philippe Mathieu-Daudé wrote: >>> On 12/17/18 2:27 AM, Alexey Kardashevskiy wrote: On 14/12/2018 22:07, Philippe Mathieu-Daudé wrote: > Hi Alexey, >

[Qemu-devel] [PATCH 15/17] target/arm: Add allocation tag storage for user-only

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 82 +++-- 1 file changed, 71 insertions(+), 11 deletions(-) diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c index b125f49258..87328c7a9a 100644 --- a/target/arm/mte_helper.c +++

[Qemu-devel] [PATCH 17/17] tests/tcg/aarch64: Add mte smoke tests

2019-01-13 Thread Richard Henderson
??? Requires a quite recent aarch64 assembler. Use .inst instead? Signed-off-by: Richard Henderson --- tests/tcg/aarch64/mte-1.c | 27 + tests/tcg/aarch64/mte-2.c | 39 +++ tests/tcg/aarch64/Makefile.target | 4 3 files

[Qemu-devel] [PATCH 16/17] target/arm: Enable MTE

2019-01-13 Thread Richard Henderson
??? It does not yet work for system mode. Signed-off-by: Richard Henderson --- target/arm/cpu.c | 10 ++ target/arm/cpu64.c | 1 + 2 files changed, 11 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 5eff6995ee..aae30207b9 100644 --- a/target/arm/cpu.c +++

[Qemu-devel] [PATCH 13/17] target/arm: Set PSTATE.TCO on exception entry

2019-01-13 Thread Richard Henderson
R0085 specifies that exception handlers begin with tag checks overridden. Signed-off-by: Richard Henderson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index df43deb0f8..1e9ccf0b2e 100644 ---

[Qemu-devel] [PATCH 14/17] tcg: Introduce target-specific page data for user-only

2019-01-13 Thread Richard Henderson
At the same time, remember MAP_SHARED as PAGE_SHARED. When mapping new pages, make sure that old target-specific page data is removed. Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 10 -- accel/tcg/translate-all.c | 28 linux-user/mmap.c

[Qemu-devel] [PATCH 07/17] target/arm: Implement ADDG, SUBG instructions

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 2 ++ target/arm/internals.h | 3 ++ target/arm/mte_helper.c| 34 ++ target/arm/translate-a64.c | 71 ++ 4 files changed, 87 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH 11/17] target/arm: Implement the STGP instruction

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 60865945e4..911d6f06b3 100644 --- a/target/arm/translate-a64.c +++

[Qemu-devel] [PATCH 08/17] target/arm: Implement the GMI instruction

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 6 ++ target/arm/translate-a64.c | 6 ++ 3 files changed, 13 insertions(+) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index 47577207b2..ef340cb6f9 100644 ---

[Qemu-devel] [PATCH 06/17] target/arm: Implement the IRG instruction

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 55 ++ target/arm/translate-a64.c | 7 + 3 files changed, 63 insertions(+) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index

[Qemu-devel] [PATCH 12/17] target/arm: Implement the LDGV and STGV instructions

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 2 ++ target/arm/mte_helper.c| 51 ++ target/arm/translate-a64.c | 34 - 3 files changed, 81 insertions(+), 6 deletions(-) diff --git a/target/arm/helper-a64.h

[Qemu-devel] [PATCH 10/17] target/arm: Implement LDG, STG, ST2G instructions

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 3 ++ target/arm/mte_helper.c| 53 +++ target/arm/translate-a64.c | 106 + 3 files changed, 162 insertions(+) diff --git a/target/arm/helper-a64.h

[Qemu-devel] [PATCH 05/17] target/arm: Suppress tag check for sp+offset

2019-01-13 Thread Richard Henderson
R0078 specifies that base register, or base register plus immediate offset, is unchecked when the base register is SP. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] [PATCH 03/17] target/arm: Add MTE system registers

2019-01-13 Thread Richard Henderson
This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, RGSR_EL1, GCR_EL1, and PSTATE.TCO. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 + target/arm/translate.h | 11 ++ target/arm/helper.c| 45 ++

[Qemu-devel] [PATCH 09/17] target/arm: Implement the SUBP instruction

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 6583ad93b1..98ff60c161 100644 --- a/target/arm/translate-a64.c +++

[Qemu-devel] [PATCH 04/17] target/arm: Fill in helper_mte_check

2019-01-13 Thread Richard Henderson
Implements the rules of "PE generation of Checked and Unchecked accesses" which aren't already covered by XXX. Implements the rules of "PE handling of Tag Check Failure". Does not implement tag physical address space, so all operations reduce to unchecked so far. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH 00/17] target/arm: Implement ARMv8.5-MemTag

2019-01-13 Thread Richard Henderson
Based-on: 20190110124951.15473-1-richard.hender...@linaro.org aka the TBID patch set, which itself is based on the BTI patch set. The full tree is available at https://github.org/rth7680/qemu.git tgt-arm-mte This extension isl also spelled MTE in the ARM. This patch set only attempts to

[Qemu-devel] [PATCH 02/17] target/arm: Extract TCMA with ARMVAParameters

2019-01-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/internals.h | 1 + target/arm/helper.c| 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 6c018e773c..2922324f63 100644 --- a/target/arm/internals.h +++

[Qemu-devel] [PATCH 01/17] target/arm: Add MTE_ACTIVE to tb_flags

2019-01-13 Thread Richard Henderson
When MTE is fully enabled, i.e. access to tags are enabled and tag checks affect the PE, then arrange to perform the check while stripping the TBI. The check is not yet implemented, just the plumbing to that point. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 13

Re: [Qemu-devel] [PATCH 3/4] accel/tcg: Add cluster number to TCG TB hash

2019-01-13 Thread Aleksandar Markovic
On Tuesday, January 8, 2019, Peter Maydell wrote: > Include the cluster number in the hash we use to look > up TBs. This is important because a TB that is valid > for one cluster at a given physical address and set > of CPU flags is not necessarily valid for another: > the two clusters may have

[Qemu-devel] [PULL 61/65] build-sys: use a seperate slirp-obj-y && slirp.mo

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau This will allow to have cflags for the whole slirp.mo -objs. It makes it possible to build tests that links only with slirp-obj-y (and not the whole common-obj). It is also a step towards building slirp as a shared library, although this requires a bit more thoughts to

[Qemu-devel] [PULL 63/65] slirp: call into g_debug() for DEBUG macros

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Make slirp use GLib logging, instead of fprintf(), so that applications can filter log, process it etc. With recent versions of glib, G_MESSAGES_DEBUG must be set to "all" or "Slirp" to see slirp debug messages. Reformat DEBUG_MISC & DEBUG_ERROR calls to not need \n

[Qemu-devel] [PULL 58/65] slirp: replace DEBUG_ARGS with DEBUG_ARG

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau There is no clear benefit in calling an alias DEBUG_ARGS(). Replace calls with DEBUG_ARG(), and fix the white-spacing while at it. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/arp_table.c | 12 ++-- slirp/debug.h | 2 --

[Qemu-devel] [PULL 52/65] slirp: replace a DEBUG block with WITH_ICMP_ERROR_MSG

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau icmp_send_error() doesnt actually log messages when DEBUG is enabled. Let's use a different define that describes better the tweaked behaviour of the function, and avoid uncompiled code. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault ---

[Qemu-devel] [PULL 65/65] slirp: check data length while emulating ident function

2019-01-13 Thread Samuel Thibault
From: Prasad J Pandit While emulating identification protocol, tcp_emu() does not check available space in the 'sc_rcv->sb_data' buffer. It could lead to heap buffer overflow issue. Add check to avoid it. Reported-by: Kira <864786...@qq.com> Signed-off-by: Prasad J Pandit Signed-off-by: Samuel

[Qemu-devel] [PULL 64/65] slirp: Mark debugging calls as unlikely

2019-01-13 Thread Samuel Thibault
to get them out of the hot path. Signed-off-by: Samuel Thibault Reviewed-by: Marc-André Lureau --- slirp/debug.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/slirp/debug.h b/slirp/debug.h index 25a5d59439..269d97d807 100644 --- a/slirp/debug.h +++ b/slirp/debug.h

[Qemu-devel] [PULL 62/65] slirp: set G_LOG_DOMAIN

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau We are moving to g_log() facilities to log errors and probably debug messages too. Let's have the "Slirp" prefix on messages slirp produces. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 ++ 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL 48/65] slirp: rename exec_list

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau This list is not only used to handle command to execute on guest connection, it can also redirect to an arbitrary object, such as a chardev. Let's rename the struct and the field to "guestfwd". Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault ---

[Qemu-devel] [PULL 55/65] slirp: introduce SLIRP_DEBUG environment variable

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Learn to read SLIRP_DEBUG=call,misc,error (all or help also handled) to set the slirp_debug flags. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/misc.c | 8 slirp/slirp.c | 15 +++ 2 files changed, 15 insertions(+), 8

[Qemu-devel] [PULL 50/65] slirp: replace a fprintf with g_critical()

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Reduce dependency on QEMU. QEMU could use a custom glib log handler if it wants to redirect/filter it. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/socket.c

[Qemu-devel] [PULL 40/65] slirp: remove dead TCP_ACK_HACK code

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Untouched since original introduction in 2004. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/tcp_input.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 09/12] tests/tcg/mips: Test R5900 three-operand MADDU1

2019-01-13 Thread Aleksandar Markovic
On Sunday, January 13, 2019, Fredrik Noring wrote: > Hi Aleksandar, > > > - Suggestion: The next MIPS pull request is scehuled for Friday, > > Jan 18, 2018. It would be fantastic if you could prepare the > > following by Jan 14: > > > > * Add 32 TCGv_i64 registers that would represent higher

[Qemu-devel] [PULL 51/65] slirp: replace some fprintf() with DEBUG_MISC

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Remove some clutter, and avoids direct call to fprintf(). Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/slirp.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index

[Qemu-devel] [PULL 46/65] slirp: Enable fork_exec support on Windows

2019-01-13 Thread Samuel Thibault
g_spawn_async_with_fds is portable on Windows, so we can now enable fork_exec support there. Thanks Daniel P. Berrangé for the notice! Signed-off-by: Samuel Thibault Reviewed-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- slirp/misc.c | 14 ++ 1 file changed, 2

[Qemu-devel] [PULL 57/65] slirp: remove remaining DEBUG blocks

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Instead, rely on slirp_debug flags, or compile unconditionally (the substraction in cksum is unlikely to affect any benchmark result). Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/cksum.c | 4 slirp/ip_icmp.c | 5 ++---

[Qemu-devel] [PULL 59/65] slirp: factor out guestfwd addition checks

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau This will allow reusing the function in a following patch. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/misc.c | 7 --- slirp/slirp.c | 23 +-- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PULL 49/65] slirp: use virtual time for packet expiration

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Make all packets expiration time based on virtual clock. Suggested-by: Paolo Bonzini Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/if.c| 2 +- slirp/slirp.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 60/65] slirp: add clock_get_ns() callback

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- net/slirp.c | 6 ++ slirp/if.c | 2 +- slirp/ip6_icmp.c | 4 ++-- slirp/libslirp.h | 2 ++ slirp/slirp.c| 12 +--- 5 files changed, 16 insertions(+), 10 deletions(-)

[Qemu-devel] [PULL 36/65] slirp: add a callback to log guest errors

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- net/slirp.c | 7 +++ slirp/dhcpv6.c | 6 +++--- slirp/ip6_icmp.c | 7 +++ slirp/libslirp.h | 2 ++ 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/net/slirp.c

[Qemu-devel] [PULL 56/65] slirp: use %p for pointers format

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau This fixes some compilation warnings on mingw64. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 2 +- slirp/ip6_input.c | 2 +- slirp/ip6_output.c | 4 ++-- slirp/udp6.c | 6 +++--- 4 files changed, 7 insertions(+), 7

[Qemu-devel] [PULL 47/65] slirp: drop

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Since commit 12f8def0e02232d7c6416ad9b66640f973c531d1 (v2.9), qemu requires Vista. Let's remove some conditional code. Note that this introduces a missing declaration warning with mingw. warning: implicit declaration of function 'inet_ntop' See also:

[Qemu-devel] [PULL 29/65] slirp: remove unused HAVE_INET_ATON

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 833f25a965..5126711849 100644 ---

[Qemu-devel] [PULL 53/65] slirp: no need to make DPRINTF conditional on DEBUG

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau DEBUG_CALL is already handled conditionally. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/bootp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/slirp/bootp.c b/slirp/bootp.c index 5ab6692038..4c9a77eb98 100644

[Qemu-devel] [PULL 44/65] slirp: simplify fork_exec()

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Use g_spawn_async_with_fds() to setup the child. GSpawn handles reaping the child, and closing parent file descriptors. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/misc.c | 75 +--- 1 file

[Qemu-devel] [PULL 35/65] slirp: improve a bit the debug macros

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Let them accept multiple arguments. Simplify the inner argument handling of DEBUG_ARGS/DEBUG_MISC_DEBUG_ERROR. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/arp_table.c | 12 ++-- slirp/bootp.c | 3 +-- slirp/cksum.c |

[Qemu-devel] [PULL 54/65] slirp: always build with debug statements

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Make debug statements condiitonal only on slirp_debug flags, instead of the pre-processor DEBUG blocks, as it may introduce breakage easily, since the debug code isn't always compiled. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/debug.h |

[Qemu-devel] [PULL 39/65] slirp: NULL is defined by stddef.h

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h | 4 1 file changed, 4 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index d1b6bcefbb..fdf397256b 100644 --- a/slirp/slirp.h +++

[Qemu-devel] [PULL 42/65] net: do not depend on slirp internals

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Only slirp/libslirp.h should be included. Instead of using some slirp declarations and utility functions directly, let's copy them in net/util.h. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by:

[Qemu-devel] [PULL 23/65] slirp: remove unused HAVE_ARPA_INET_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 47811e36dc..e95284071a 100644 ---

[Qemu-devel] [PULL 34/65] slirp: replace error_report() with g_critical()

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Reduce dependency on QEMU. QEMU could use a custom log handler if it wants to redirect/filter it. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 2 +- slirp/misc.c | 2 +- slirp/slirp.c| 6 +++--- 3 files changed, 5

[Qemu-devel] [PULL 38/65] slirp: remove unused sbflush()

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/sbuf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/slirp/sbuf.h b/slirp/sbuf.h index a722ecb629..644c201341 100644 --- a/slirp/sbuf.h +++ b/slirp/sbuf.h @@

[Qemu-devel] [PULL 33/65] slirp: remove unused global slirp_instance

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 05c203c8c7..d1b6bcefbb 100644 --- a/slirp/slirp.h +++

[Qemu-devel] [PULL 25/65] slirp: remove unused HAVE_SYS_SELECT_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/main.h | 4 slirp/slirp.h| 4 slirp/slirp_config.h | 6 -- 3 files changed, 14 deletions(-) diff --git a/slirp/main.h

[Qemu-devel] [PULL 16/65] slirp: remove PROBE_CONN dead-code

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Nobody cares for over 14y. Somebody can revert or rewrite if interested by that. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.c| 41

[Qemu-devel] [PULL 45/65] slirp: replace error_report() with g_critical()

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Reduce dependency on QEMU. QEMU could use a custom log handler if it wants to redirect/filter it. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- slirp/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/misc.c

[Qemu-devel] [PULL 43/65] glib-compat: add g_spawn_async_with_fds() fallback

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- include/glib-compat.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fdf95a255d..8a078c5288 100644

[Qemu-devel] [PULL 26/65] slirp: remove HAVE_SYS_IOCTL_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h| 2 +- slirp/slirp_config.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index

[Qemu-devel] [PULL 41/65] slirp: replace ARRAY_SIZE with G_N_ELEMENTS

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Do not require QEMU macro. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/ncsi.c | 2 +- slirp/tftp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PULL 37/65] slirp: remove #if notdef dead code

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/ip_input.c | 200 -- slirp/tcp_input.c | 39 - 2 files changed, 239 deletions(-) diff --git

[Qemu-devel] [PULL 27/65] slirp: remove HAVE_SYS_FILIO_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h| 2 +- slirp/slirp_config.h | 6 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index

[Qemu-devel] [PULL 22/65] slirp: remove unused HAVE_SYS_STROPTS_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h| 5 - slirp/slirp_config.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index fba77d0c3d..400f585cec

[Qemu-devel] [PULL 30/65] slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau One more step towards making the project independent from QEMU. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/ip.h | 8 +--- slirp/ip6.h | 3 ++-

[Qemu-devel] [PULL 31/65] slirp: replace SIZEOF_CHAR_P with glib equivalent

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Samuel Thibault --- slirp/ip.h | 2 +- slirp/slirp_config.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/slirp/ip.h b/slirp/ip.h index

[Qemu-devel] [PULL 20/65] slirp: remove unused HAVE_SYS_BITYPES_H

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Signed-off-by: Samuel Thibault --- slirp/slirp.h| 4 slirp/slirp_config.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index 4c3c672ee6..57955a8965

[Qemu-devel] [PULL 08/65] slirp: remove Monitor dependency, return a string for info

2019-01-13 Thread Samuel Thibault
From: Marc-André Lureau There is nothing performance-sensitive in returning an allocated string for info, and handling the monitor_printf() on the caller side. Signed-off-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- net/slirp.c | 7 --- slirp/libslirp.h | 2 +-

  1   2   >