Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid()

2020-01-13 Thread Markus Armbruster
Laurent Vivier writes: > Le 13/01/2020 à 16:15, Markus Armbruster a écrit : >> Greg Kurz writes: >> >>> On Mon, 6 Jan 2020 15:23:38 -0300 >>> Daniel Henrique Barboza wrote: >>> 'err_out' can be removed and be replaced by 'return -errno' in its only instance in the function.

Re: Semihosting, arm, riscv, ppc and common code

2020-01-13 Thread Benjamin Herrenschmidt
On Tue, 2020-01-14 at 09:32 +0200, Liviu Ionescu wrote: > > On 14 Jan 2020, at 08:25, Benjamin Herrenschmidt < > > b...@kernel.crashing.org> wrote: > > > > I noticed that the bulk of arm-semi.c (or riscv-semi.c) is > > trivially > > made completely generic by doing a couple of changes: > > Last

[PATCH] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks

2020-01-13 Thread pannengyuan
From: Pan Nengyuan Receive/transmit/event vqs forgot to cleanup in vhost_vsock_unrealize. This patch save receive/transmit vq pointer in realize() and cleanup vqs through those vq pointers in unrealize(). The leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from:

[PATCH] virtio-9p-device: fix memleak in virtio_9p_device_unrealize

2020-01-13 Thread pannengyuan
From: Pan Nengyuan v->vq forgot to cleanup in virtio_9p_device_unrealize, the memory leak stack is as follow: Direct leak of 14336 byte(s) in 2 object(s) allocated from: #0 0x7f819ae43970 (/lib64/libasan.so.5+0xef970) ??:? #1 0x7f819872f49d (/lib64/libglib-2.0.so.0+0x5249d) ??:? #2

Re: Semihosting, arm, riscv, ppc and common code

2020-01-13 Thread Liviu Ionescu
> On 14 Jan 2020, at 08:25, Benjamin Herrenschmidt > wrote: > > I noticed that the bulk of arm-semi.c (or riscv-semi.c) is trivially > made completely generic by doing a couple of changes: Last year I did a similar exercise in OpenOCD, where I took the Arm semihosting code from the Arm

Re: [PATCH v2 2/3] memory: Allow a MemoryRegion to be marked no_vhost

2020-01-13 Thread Michael S. Tsirkin
On Mon, Jan 13, 2020 at 05:36:46PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow a memory region to be marked as 'no_vhost' and > exclude that region from vhost's list build. > > Signed-off-by: Dr. David Alan Gilbert I thought we agreed vfio needs this

Re: [PATCH v2 0/3] exclude hyperv synic sections from vhost

2020-01-13 Thread Michael S. Tsirkin
On Mon, Jan 13, 2020 at 06:58:30PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 13/01/20 18:36, Dr. David Alan Gilbert (git) wrote: > > > > > > Hyperv's synic (that we emulate) is a feature that allows the guest > > > to place some magic (4k) pages of

Re: [RFC PATCH 3/3] Introduce Configurable Number of Memory Slots Exposed by vhost-user:

2020-01-13 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 02:00:47AM -0500, Raphael Norwitz wrote: > The current vhost-user implementation in Qemu imposes a limit on the > maximum number of memory slots exposed to a VM using a vhost-user > device. This change provides a new protocol feature > VHOST_USER_F_CONFIGURE_SLOTS which,

Re: [RFC PATCH 1/3] Fixed Error Handling in vhost_user_set_mem_table_postcopy

2020-01-13 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 02:00:45AM -0500, Raphael Norwitz wrote: > The current vhost_user_set_mem_table_postcopy() implementation > populates each region of the VHOST_USER_SET_MEM_TABLE > message without first checking if there are more than > VHOST_MEMORY_MAX_NREGIONS already populated. This can

Semihosting, arm, riscv, ppc and common code

2020-01-13 Thread Benjamin Herrenschmidt
Hi Folks ! So I started "porting" over (read: copying) the arm semihosting code to ppc to mimmic what Keith did for risv (mostly for picolibc support). I noticed that the bulk of arm-semi.c (or riscv-semi.c) is trivially made completely generic by doing a couple of changes: - Make most

Re: PCIe device paththrough via vfio issue

2020-01-13 Thread Alexey Kardashevskiy
On 14/01/2020 03:28, Alex Williamson wrote: > On Mon, 13 Jan 2020 18:49:21 +0300 > yurij wrote: > >> Hello everybody! >> >> I have a specific PCIe device (sorry, but I can't tell about what is it >> and what it does) but PCI configuration space consists of 4 BARs (lspci >> output brief): >>

Re: [PATCH 5/7] target/ppc: Add privileged message send facilities

2020-01-13 Thread David Gibson
On Thu, Jan 09, 2020 at 08:13:38AM +0100, Cédric Le Goater wrote: > void helper_book3s_msgclr(CPUPPCState *env, target_ulong rb) > { > -int irq = book3s_dbell2irq(rb); > +int irq = book3s_dbell2irq(rb, 1); > >>> > >>> true/false are preferred to 0/1 for bool types. >

Re: [PATCH 0/4] migration: Replace gemu_log with qemu_log

2020-01-13 Thread Warner Losh
On Mon, Jan 13, 2020, 8:03 PM Josh Kunz wrote: > The linux-user and bsd-user trees both widely use a function called > `gemu_log` (notice the 'g') for miscellaneous and strace logging. This > function predates the newer `qemu_log` function, and has a few drawbacks > compared to `qemu_log`: > >

[PATCH 4/4] bsd-user: Replace gemu_log with qemu_log

2020-01-13 Thread Josh Kunz
gemu_log is an old logging mechanism used to implement strace logging in the bsd-user tree. It logs directly to stderr and cannot easily be redirected. This change instead causes strace to log via the qemu_log subsystem which has fine-grained logging control, and a centralized mechanism for log

[PATCH 2/4] linux-user: Use `qemu_log' for strace

2020-01-13 Thread Josh Kunz
This change switches linux-user strace logging to use the newer `qemu_log` logging subsystem rather than the older `gemu_log` (notice the "g") logger. `qemu_log` has several advantages, namely that it allows logging to a file, and provides a more unified interface for configuration of logging (via

[PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-13 Thread Josh Kunz
This change introduces a new logging mask "LOG_USER", which is used for masking general user-mode logging. This change also switches all non-strace uses of `gemu_log' in linux-user/ to use `qemu_log_mask(LOG_USER, ...)' instead. This allows the user to easily log to a file, and to mask out these

[PATCH 3/4] linux-user: remove gemu_log from the linux-user tree

2020-01-13 Thread Josh Kunz
Now that all uses have been migrated to `qemu_log' it is no longer needed. Signed-off-by: Josh Kunz --- linux-user/main.c | 9 - linux-user/qemu.h | 1 - 2 files changed, 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 0bf40c4d27..945b6adf3a 100644 ---

[PATCH 0/4] migration: Replace gemu_log with qemu_log

2020-01-13 Thread Josh Kunz
The linux-user and bsd-user trees both widely use a function called `gemu_log` (notice the 'g') for miscellaneous and strace logging. This function predates the newer `qemu_log` function, and has a few drawbacks compared to `qemu_log`: 1. Always logs to `stderr`, no logging redirection. 2.

Re: [BUG qemu 4.0] segfault when unplugging virtio-blk-pci device

2020-01-13 Thread Eryu Guan
On Mon, Jan 13, 2020 at 04:38:55PM +, Stefan Hajnoczi wrote: > On Thu, Jan 09, 2020 at 12:58:06PM +0800, Eryu Guan wrote: > > On Tue, Jan 07, 2020 at 03:01:01PM +0100, Julia Suvorova wrote: > > > On Tue, Jan 7, 2020 at 2:06 PM Eryu Guan wrote: > > > > > > > > On Thu, Jan 02, 2020 at

Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32

2020-01-13 Thread Richard Henderson
On 1/10/20 8:02 AM, Jeff Kubascik wrote: > -env->pc -= insn_len; > +if (env->aarch64) > +env->pc -= insn_len; > +else > +env->regs[15] -= insn_len; QEMU requires all braces. See CODING_STYLE. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH] target/riscv: Set mstatus.DS & FS correctly

2020-01-13 Thread Richard Henderson
On 1/9/20 11:05 PM, shihpo.h...@sifive.com wrote: > Because ctx->mstatus_fs changes dynamically during runtime, we should > remove the mstatus_fs check at the translation stage. This change is incorrect. The actual bug is in cpu_get_tb_cpu_state(), as I just noticed during review: "[PATCH 2/3]

[PATCH 1/2] pvpanic: introduce crashloaded for pvpanic

2020-01-13 Thread zhenwei pi
Add bit 1 for pvpanic. This bit means that guest hits a panic, but guest wants to handle error by itself. Typical case: Linux guest runs kdump in panic. It will help us to separate the abnormal reboot from normal operation. Signed-off-by: zhenwei pi --- docs/specs/pvpanic.txt | 8 ++-- 1

[PATCH 0/2] pvpanic: implement crashloaded event for pvpanic

2020-01-13 Thread zhenwei pi
Guest may handle panic by itself, then just reboot without pvpanic notification. Then We can't separate the abnormal reboot from normal operation. Declear bit 1 for pvpanic as crashloaded event. It should work with guest kernel side. Link: https://lkml.org/lkml/2019/12/14/265 Before running

[PATCH 2/2] pvpanic: implement crashloaded event handling

2020-01-13 Thread zhenwei pi
Handle bit 1 write, then post event to monitor. Suggested by Paolo, declear a new event, using GUEST_PANICKED could cause upper layers to react by shutting down or rebooting the guest. In advance for extention, add GuestPanicInformation in event message. Signed-off-by: zhenwei pi ---

Re: [PATCH 3/3] remove redundant check for fpu csr read and write interface

2020-01-13 Thread Richard Henderson
On 1/9/20 10:12 PM, LIU Zhiwei wrote: > The read or write interface must be called after the predicate fs return 0. > And the predicate will check (!env->debugger && !riscv_cpu_fp_enabled(env)), > S0 no need to check again. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/csr.c | 24

Re: [PATCH 2/3] RISC-V: use FIELD macro to define tb flags

2020-01-13 Thread Richard Henderson
On 1/9/20 10:12 PM, LIU Zhiwei wrote: > if (riscv_cpu_fp_enabled(env)) { > -*flags |= TB_FLAGS_MSTATUS_FS; > +flags = FIELD_DP32(flags, TB_FLAGS, FS, (env->mstatus & MSTATUS_FS)); > } This is wrong. You're inserting the low two bits of env->mstatus & MSTATUS_FS into

RE: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-13 Thread Zengtao (B)
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Monday, January 13, 2020 5:06 PM > To: Zengtao (B) > Cc: Peter Maydell; Michael S. Tsirkin; qemu-triv...@nongnu.org; > qemu-devel@nongnu.org; Shannon Zhao; qemu-...@nongnu.org > Subject: Re: [PATCH]

Re: [PATCH 10/15] memory: Replace current_machine by qdev_get_machine()

2020-01-13 Thread Alistair Francis
On Sun, Jan 12, 2020 at 11:45 PM Philippe Mathieu-Daudé wrote: > > On 1/12/20 10:48 AM, Alistair Francis wrote: > > On Thu, Jan 9, 2020 at 11:29 PM Philippe Mathieu-Daudé > > wrote: > >> > >> As we want to remove the global current_machine, > >> replace 'current_machine' by

Re: [PATCH 15/15] vl: Make current_machine a local variable

2020-01-13 Thread Alistair Francis
On Fri, Jan 10, 2020 at 1:34 AM Philippe Mathieu-Daudé wrote: > > Since we now only use current_machine in vl.c, stop exporting > it as a global variable in "hw/board.h", and make it static > to vl.c. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 14/15] accel/accel: Replace current_machine by qdev_get_machine()

2020-01-13 Thread Alistair Francis
On Fri, Jan 10, 2020 at 1:40 AM Philippe Mathieu-Daudé wrote: > > As we want to remove the global current_machine, > replace 'current_machine' by MACHINE(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daudé I feel like this could be squashed with the one that adds this function, but

Re: [PATCH 13/15] accel: Replace current_machine->accelerator by current_accel() method

2020-01-13 Thread Alistair Francis
On Fri, Jan 10, 2020 at 1:38 AM Philippe Mathieu-Daudé wrote: > > As we want to remove the global current_machine, > replace 'current_machine->accelerator' by current_accel(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > accel/kvm/kvm-all.c | 4

Re: [PATCH 12/15] accel: Introduce the current_accel() method

2020-01-13 Thread Alistair Francis
On Fri, Jan 10, 2020 at 1:27 AM Philippe Mathieu-Daudé wrote: > > We want to remove the global current_machine. The accel/ > code access few times current_machine->accelerator. Introduce > the current_accel() method first, it will then be easier to > replace 'current_machine' by

Re: [PATCH 11/15] exec: Replace current_machine by qdev_get_machine()

2020-01-13 Thread Alistair Francis
On Fri, Jan 10, 2020 at 1:37 AM Philippe Mathieu-Daudé wrote: > > As we want to remove the global current_machine, > replace 'current_machine' by MACHINE(qdev_get_machine()). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > exec.c | 10 ++ > 1

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2020-01-13 Thread John G Johnson
> On Jan 3, 2020, at 7:59 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 02, 2020 at 11:03:22AM +, Felipe Franciosi wrote: >>> On Jan 2, 2020, at 10:42 AM, Stefan Hajnoczi wrote: >>> On Fri, Dec 20, 2019 at 10:22:37AM +, Daniel P. Berrangé wrote: On Fri, Dec 20, 2019 at 09:47:12AM

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-13 Thread David Gibson
On Mon, Jan 13, 2020 at 10:13:27AM +0100, Andrea Bolognani wrote: > On Wed, 2020-01-08 at 13:34 +1100, Alexey Kardashevskiy wrote: > > On 07/01/2020 20:39, Andrea Bolognani wrote: > > > On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: > > > > Petitboot kernel+initramdisk almost

Re: [PATCH] scsi-disk: define props in scsi_block_disk to avoid memleaks

2020-01-13 Thread Pan Nengyuan
On 1/14/2020 6:56 AM, John Snow wrote: > CC qemu-block > > On 1/13/20 1:20 AM, pannengy...@huawei.com wrote: >> From: Pan Nengyuan >> >> scsi_block_realize() use scsi_realize() to init some props, but >> these props is not defined in scsi_block_disk_properties, so they will >> not be freed.

Re: [PULL 00/41] tcg patch queue

2020-01-13 Thread Richard Henderson
On 1/13/20 12:06 PM, Richard Henderson wrote: > On 1/13/20 11:50 AM, Richard Henderson wrote: >> On 1/13/20 11:10 AM, Richard Henderson wrote: >>> Details of this test system? >>> >>> I suppose I'll grab your tarball just to see if the binaries are >>> different... >> >> Ho hum. Something is

[Bug 1859359] Re: xHCI and event ring handling

2020-01-13 Thread Benjamin David Lunt
Hi Hector, guys, I think I have found my/the error: xHCI, version 1.0, Page 136: "Note: The detection of a Cycle bit mismatch in an Event TRB processed by software indicates the location of the xHC Event Ring Enqueue Pointer and that the Event Ring is empty. Software shall write the ERDP

[PATCH v3 00/11] 9pfs: readdir optimization

2020-01-13 Thread Christian Schoenebeck
As previously mentioned, I was investigating performance issues with 9pfs. Raw file read/write of 9pfs is actually quite good, provided that client picked a reasonable high msize (maximum message size). I would recommend to log a warning on 9p server side if a client attached with a small msize

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-13 Thread Alexey Kardashevskiy
On 13/01/2020 20:13, Andrea Bolognani wrote: > On Wed, 2020-01-08 at 13:34 +1100, Alexey Kardashevskiy wrote: >> On 07/01/2020 20:39, Andrea Bolognani wrote: >>> On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: Petitboot kernel+initramdisk almost replaces SLOF + GRUB. >>> >>>

[PATCH v3 06/11] tests/virtio-9p: added splitted readdir test

2020-01-13 Thread Christian Schoenebeck
The previous, already existing readdir test simply used a 'count' parameter big enough to retrieve all directory entries with a single Treaddir request. In this new 'splitted' readdir test, directory entries are retrieved, splitted over several Treaddir requests by picking small 'count'

[PATCH v3 04/11] hw/9pfs/9p-synth: added directory for readdir test

2020-01-13 Thread Christian Schoenebeck
This will provide the following virtual files by the 9pfs synth driver: - /ReadDirDir/ReadDirFile99 - /ReadDirDir/ReadDirFile98 ... - /ReadDirDir/ReadDirFile1 - /ReadDirDir/ReadDirFile0 This virtual directory and its virtual 100 files will be used by the upcoming 9pfs readdir tests.

[PATCH v3 10/11] 9pfs: T_readdir latency optimization

2020-01-13 Thread Christian Schoenebeck
Make top half really top half and bottom half really bottom half: Each T_readdir request handling is hopping between threads (main I/O thread and background I/O driver threads) several times for every individual directory entry, which sums up to huge latencies for handling just a single T_readdir

[PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-13 Thread Christian Schoenebeck
A client establishes a session by sending a Tversion request along with a 'msize' parameter which client uses to suggest server a maximum message size ever to be used for communication (for both requests and replies) between client and server during that session. If client suggests a 'msize'

[PATCH v3 01/11] tests/virtio-9p: add terminating null in v9fs_string_read()

2020-01-13 Thread Christian Schoenebeck
The 9p protocol sends strings in general without null termination over the wire. However for future use of this functions it is beneficial for the delivered string to be null terminated though for being able to use the string with standard C functions which often rely on strings being null

[PATCH v3 08/11] 9pfs: readdir benchmark

2020-01-13 Thread Christian Schoenebeck
This patch is not intended to be merged. It just provides a temporary benchmark foundation for coneniently A/B comparison of the subsequent 9p readdir optimization patches: * hw/9pfs/9p-synth: increase amount of simulated files for readdir test to 2000 files. * tests/virtio-9p: measure wall

[PATCH v3 05/11] tests/virtio-9p: added readdir test

2020-01-13 Thread Christian Schoenebeck
The first readdir test simply checks the amount of directory entries returned by 9pfs server, according to the created amount of virtual files on 9pfs synth driver side. Then the subsequent readdir test also checks whether all directory entries have the expected file names (as created on 9pfs

[PATCH v3 09/11] hw/9pfs/9p-synth: avoid n-square issue in synth_readdir()

2020-01-13 Thread Christian Schoenebeck
This patch is just a temporary benchmark hack, not intended to be merged! 9pfs synth driver's readdir() implementation has a severe n-square performance problem. This patch is a quick and dirty hack to prevent that performance problem from tainting the readdir() benchmark results. In its current

[PATCH v3 03/11] 9pfs: validate count sent by client with T_readdir

2020-01-13 Thread Christian Schoenebeck
A good 9p client sends T_readdir with "count" parameter that's sufficiently smaller than client's initially negotiated msize (maximum message size). We perform a check for that though to avoid the server to be interrupted with a "Failed to encode VirtFS reply type 41" error message by bad clients.

Re: [PATCH qemu v4] spapr: Kill SLOF

2020-01-13 Thread Alexey Kardashevskiy
On 13/01/2020 18:05, David Gibson wrote: > On Fri, Jan 10, 2020 at 11:51:32AM +1100, Alexey Kardashevskiy wrote: >> >> >> On 10/01/2020 10:32, Alexey Kardashevskiy wrote: >>> >>> >>> On 10/01/2020 10:05, Alexey Kardashevskiy wrote: On 08/01/2020 17:18, Alexey Kardashevskiy wrote:

[PATCH v3 07/11] tests/virtio-9p: failing splitted readdir test

2020-01-13 Thread Christian Schoenebeck
This patch is not intended to be merged. It resembles an issue (with debug messages) where the splitted readdir test fails because server is interrupted with transport error "Failed to decode VirtFS request type 40", which BTW fails both with the unoptimized and with the optimized 9p readdir code.

[PATCH v3 11/11] hw/9pfs/9p.c: benchmark time on T_readdir request

2020-01-13 Thread Christian Schoenebeck
This patch is not intended to be merged, it measures and prints the time the 9p server spends on handling a T_readdir request. It prints the total time it spent on handling the request, and also the time it spent on I/O (fs driver) only. Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c |

Re: [PATCH 4/7] target/ppc: Add SPR TBU40

2020-01-13 Thread Philippe Mathieu-Daudé
On 11/28/19 2:46 PM, Cédric Le Goater wrote: From: Suraj Jitindar Singh The spr TBU40 is used to set the upper 40 bits of the timebase register, present on POWER5+ and later processors. This register can only be written by the hypervisor, and cannot be read. Signed-off-by: Suraj Jitindar

Re: [PATCH v3 10/17] hw/arm/allwinner-h3: add Boot ROM support

2020-01-13 Thread Philippe Mathieu-Daudé
On 1/8/20 9:00 PM, Niek Linnenbank wrote: A real Allwinner H3 SoC contains a Boot ROM which is the first code that runs right after the SoC is powered on. The Boot ROM is responsible for loading user code (e.g. a bootloader) from any of the supported external devices and writing the downloaded

Re: [PATCH v3 06/17] hw/arm/allwinner: add CPU Configuration module

2020-01-13 Thread Philippe Mathieu-Daudé
On 1/8/20 9:00 PM, Niek Linnenbank wrote: Various Allwinner System on Chip designs contain multiple processors that can be configured and reset using the generic CPU Configuration module interface. This commit adds support for the Allwinner CPU configuration interface which emulates the

Re: [PATCH 6/7] target/ppc: add support for Hypervisor Facility Unavailable Exception

2020-01-13 Thread David Gibson
On Wed, Jan 08, 2020 at 04:36:50PM +0100, Cédric Le Goater wrote: > On 12/19/19 6:12 AM, David Gibson wrote: > > On Thu, Nov 28, 2019 at 02:46:59PM +0100, Cédric Le Goater wrote: > >> The privileged message send and clear instructions (msgsndp & msgclrp) > >> are privileged, but will generate a

Re: [PATCH v3 12/17] hw/arm/allwinner: add RTC device support

2020-01-13 Thread Philippe Mathieu-Daudé
On 1/8/20 9:00 PM, Niek Linnenbank wrote: Allwinner System-on-Chips usually contain a Real Time Clock (RTC) for non-volatile system date and time keeping. This commit adds a generic Allwinner RTC device that supports the RTC devices found in Allwinner SoC family sun4i (A10), sun7i (A20) and

Re: [PATCH] scsi-disk: define props in scsi_block_disk to avoid memleaks

2020-01-13 Thread John Snow
CC qemu-block On 1/13/20 1:20 AM, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > scsi_block_realize() use scsi_realize() to init some props, but > these props is not defined in scsi_block_disk_properties, so they will > not be freed. > > This patch defines these prop in

Re: [PATCH] qemu-deprecated: Remove text about Python 2

2020-01-13 Thread John Snow
On 1/9/20 4:51 AM, Thomas Huth wrote: > Python 2 support has been removed, so we should now also remove > the announcement text for the deprecation. > > Signed-off-by: Thomas Huth Reviewed-by: John Snow > --- > qemu-deprecated.texi | 8 > 1 file changed, 8 deletions(-) > > diff

Re: [PULL 00/41] tcg patch queue

2020-01-13 Thread Richard Henderson
On 1/13/20 11:50 AM, Richard Henderson wrote: > On 1/13/20 11:10 AM, Richard Henderson wrote: >> Details of this test system? >> >> I suppose I'll grab your tarball just to see if the binaries are different... > > Ho hum. Something is different. I reproduce the problem with your tarball. Well,

Re: [PULL 00/41] tcg patch queue

2020-01-13 Thread Richard Henderson
On 1/13/20 11:10 AM, Richard Henderson wrote: > Details of this test system? > > I suppose I'll grab your tarball just to see if the binaries are different... Ho hum. Something is different. I reproduce the problem with your tarball. r~

Re: [PULL 00/41] tcg patch queue

2020-01-13 Thread Richard Henderson
On 1/10/20 5:51 AM, Peter Maydell wrote: >> Improve -static and -pie linking >> Add cpu_{ld,st}*_mmuidx_ra >> Remove MMU_MODE*_SUFFIX >> Move tcg headers under include/ > > This makes the x86-64 'ls' binary in the linux-user-tests > tarball segfault: > >

[PATCH v5 16/20] linux-user: Add support for FDFMT ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling formatting of a floppy drive. FDFMTTRK's third agrument is a pointer to the structure: struct format_descr { unsigned int device,head,track; }; defined in Linux kernel header . Since all

[PATCH v5 18/20] configure: Detect kcov support and introduce CONFIG_KCOV

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic kcov is kernel code coverage tracing tool. It requires kernel 4.4+ compiled with certain kernel options. Its interface consists of three ioctls. This patch checks if kcov support is present on build machine, and stores the result in variable CONFIG_KCOV, meant to be

[PATCH v5 08/20] linux-user: xtensa: Remove unused constant TARGET_NR_syscall_count

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Currently, there is no usage of TARGET_NR_syscall_count for target xtensa, and there is no obvious indication if there is some planned usage in future. Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic --- cc: Max Filippov ---

[PATCH v5 20/20] linux-user: Add support for KCOV_INIT_TRACE ioctl

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_INIT_TRACE ioctl plays the role in kernel coverage tracing. This ioctl's third argument is of type 'unsigned long', and the implementation in QEMU is straightforward. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 1 +

[PATCH v5 11/20] linux-user: Add support for FS_IOC32_VERSION ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_VERSION ioctls are identical to FS_IOC_VERSION ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Signed-off-by: Aleksandar Markovic ---

[PATCH v5 19/20] linux-user: Add support for KCOV_ ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_ENABLE and KCOV_DISABLE play the role in kernel coverage tracing. These ioctls do not use the third argument of ioctl() system call and are straightforward to implement in QEMU. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 5 +

[PATCH v5 13/20] linux-user: Add support for FITRIM ioctl

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic FITRIM ioctl accepts a pointer to the structure struct fstrim_range { __u64 start; __u64 len; __u64 minlen; }; as its third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation

[PATCH v5 17/20] linux-user: Add support for FDGETFDCSTAT ioctl

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic FDGETFDCSTAT's third agrument is a pointer to the structure: struct floppy_fdc_state { int spec1; int spec2; int dtr; unsigned char version; unsigned char dor; unsigned long address; unsigned int rawcmd:2; unsigned int reset:1;

[PATCH v5 10/20] linux-user: Add support for FS_IOC32_FLAGS ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_FLAGS ioctls are identical to FS_IOC_FLAGS ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Signed-off-by: Aleksandar Markovic ---

[PATCH v5 15/20] linux-user: Add support for FD ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands for controlling error reporting of a floppy drive. FDSETEMSGTRESH's third agrument is a pointer to the structure: struct floppy_max_errors { unsigned int abort, /* number of errors to be

[PATCH v5 14/20] linux-user: Add support for FIFREEZE and FITHAW ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FIFREEZE and FITHAW ioctls accept an integer as their third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation too for consistency (however, many of ioctls in FI* group became old enough that

[PATCH v5 12/20] linux-user: Add support for FS_IOC_FSXATTR ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR accept a pointer to the structure struct file_clone_range { __s64 src_fd; __u64 src_offset; __u64 src_length; __u64 dest_offset; }; as their third argument. These ioctls were relatively

[PATCH v5 01/20] linux-user: Fix some constants in termbits.h

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Some constants were defined in terms of host, instead of target, as they should be. Some additional trivial changes in this patch were forced by checkpatch.pl. Reviewed-by: Max Filippov Signed-off-by: Aleksandar Markovic --- linux-user/aarch64/termbits.h| 4

[PATCH v5 09/20] linux-user: Add support for FS_IOC_VERSION ioctls

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic A very specific thing for these two ioctls is that their code implies that their third argument is of type 'long', but the kernel uses that argument as if it is of type 'int'. This anomaly is recognized also in commit 6080723 (linux-user: Implement FS_IOC_GETFLAGS and

[PATCH v5 07/20] linux-user: xtensa: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update xtensa syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic --- cc: Max Filippov --- linux-user/xtensa/syscall_nr.h | 38 -- 1 file changed, 36

[PATCH v5 02/20] linux-user: alpha: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update alpha syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- cc: Richard Henderson --- linux-user/alpha/syscall_nr.h | 35 +++ 1 file changed, 35 insertions(+) diff --git

[PATCH v5 03/20] linux-user: m68k: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update m68k syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- cc: Laurent Vivier --- linux-user/m68k/syscall_nr.h | 50 +++- 1 file changed, 49 insertions(+), 1

[PATCH v5 06/20] linux-user: x86_64: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update x86_64 syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- cc: Paolo Bonzini cc: Richard Henderson cc: Eduardo Habkost --- linux-user/x86_64/syscall_nr.h | 24 1 file

[PATCH v5 05/20] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update mips syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- linux-user/mips/cpu_loop.c | 78 +- linux-user/mips/syscall_nr.h | 45

[PATCH v5 04/20] linux-user: microblaze: Update syscall numbers to kernel 5.5 rc3 level

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update microblaze syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- cc: Edgar E. Iglesias --- linux-user/microblaze/syscall_nr.h | 45 ++ 1 file changed, 45

[PATCH v5 00/20] linux-user: Misc patches for 5.0

2020-01-13 Thread Aleksandar Markovic
From: Aleksandar Markovic This series is a collection of linux-user patches I recently accumulated. The summary of the patches is as follows: Patch 1: Fix for some issues in termbits.h files. Patches 2-7: Updating syscall numbers Patch 8: A minor xtensa cleanup Patches 9-14: Adding support for

Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:11PM +0100, Eric Auger wrote: [...] > +VirtIOIOMMUEndpoint *virtio_iommu_get_endpoint(VirtIOIOMMU *s, uint32_t > ep_id); > +VirtIOIOMMUEndpoint *virtio_iommu_get_endpoint(VirtIOIOMMU *s, uint32_t > ep_id) Is the extra definition trying to workaround the compiler

Re: [PATCH 066/104] virtiofsd: passthrough_ll: add renameat2 support

2020-01-13 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:38:26PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Miklos Szeredi > > > > > > No glibc support yet, so use syscall(). > > > > It exists in

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: > +/** > + * The bus number is used for lookup when SID based operations occur. > + * In that case we lazily populate the IOMMUPciBus array from the bus hash > + * table. At the time the IOMMUPciBus is created (iommu_find_add_as), the bus

Re: [PATCH] qemu-nbd: Convert invocation documentation to rST

2020-01-13 Thread Eric Blake
On 1/13/20 12:08 PM, Peter Maydell wrote: The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo format, which we present to the user as: * a qemu-nbd manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user

Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid()

2020-01-13 Thread Greg Kurz
On Mon, 13 Jan 2020 17:32:31 +0100 Laurent Vivier wrote: > Le 13/01/2020 à 16:15, Markus Armbruster a écrit : > > Greg Kurz writes: > > > >> On Mon, 6 Jan 2020 15:23:38 -0300 > >> Daniel Henrique Barboza wrote: > >> > >>> 'err_out' can be removed and be replaced by 'return -errno' > >>> in

Re: [PATCH v12 02/13] virtio-iommu: Add skeleton

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:08PM +0100, Eric Auger wrote: > This patchs adds the skeleton for the virtio-iommu device. > > Signed-off-by: Eric Auger Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions

2020-01-13 Thread Peter Xu
On Thu, Jan 09, 2020 at 03:43:10PM +0100, Eric Auger wrote: > Implement a callback called on PCI bus enumeration that > initializes for a given device on the bus hierarchy > an IOMMU memory region. The PCI bus hierarchy is stored > locally in IOMMUPciBus and IOMMUDevice objects. > > At the time

Re: [PULL 0/3] capstone update

2020-01-13 Thread Richard Henderson
On 1/10/20 6:07 AM, Peter Maydell wrote: > On Wed, 8 Jan 2020 at 04:23, Richard Henderson > wrote: >> >> The following changes since commit 035eed4c0d257c905a556fa0f4865a0c077b4e7f: >> >> Merge remote-tracking branch >> 'remotes/vivier/tags/q800-for-5.0-pull-request' into staging (2020-01-07

Re: [RFC PATCH 0/3] vhost-user: Lift Max Ram Slots Limitation

2020-01-13 Thread Raphael Norwitz
Ping On Mon, Dec 09, 2019 at 02:00:44AM -0500, Raphael Norwitz wrote: > > In QEMU today, a VM with a vhost-user device can hot add memory a > maximum of 8 times. See these threads, among others: > > [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html >

Re: [PATCH v3 03/17] hw/arm/allwinner-h3: add Clock Control Unit

2020-01-13 Thread Niek Linnenbank
Hi, Just a friendly reminder for review of this patch and the others in this series that don't yet have a reviewed-by tag :-) Regards, Niek On Wed, Jan 8, 2020 at 9:00 PM Niek Linnenbank wrote: > The Clock Control Unit is responsible for clock signal generation, > configuration and

Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2020-01-13 Thread Jason Andryuk
On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote: > > On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné wrote: > > > > On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wrote: > > > On Fri, Mar 15, 2019 at 12:28 PM Andrew Cooper > > > wrote: > > > > > > > > On 15/03/2019 09:17, Paul

Re: [PATCH v2 0/3] exclude hyperv synic sections from vhost

2020-01-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/01/20 18:36, Dr. David Alan Gilbert (git) wrote: > > > > Hyperv's synic (that we emulate) is a feature that allows the guest > > to place some magic (4k) pages of RAM anywhere it likes in GPA. > > This confuses vhost's RAM section merging when

Re: [kvm-unit-tests PATCH v2 16/16] arm/arm64: ITS: pending table migration test

2020-01-13 Thread Andrew Jones
On Fri, Jan 10, 2020 at 03:54:12PM +0100, Eric Auger wrote: > Add two new migration tests. One testing the migration of > a topology where collection were unmapped. The second test > checks the migration of the pending table. > > Signed-off-by: Eric Auger > --- > arm/gic.c | 148

Re: [kvm-unit-tests PATCH v2 14/16] arm/run: Allow Migration tests

2020-01-13 Thread Andrew Jones
On Fri, Jan 10, 2020 at 03:54:10PM +0100, Eric Auger wrote: > Let's link getchar.o to use puts and getchar from the > tests. > > Then allow tests belonging to the migration group to > trigger the migration from the test code by putting > "migrate" into the uart. Then the code can wait for the >

Re: [kvm-unit-tests PATCH v2 13/16] arm/arm64: ITS: INT functional tests

2020-01-13 Thread Andrew Jones
On Fri, Jan 10, 2020 at 03:54:09PM +0100, Eric Auger wrote: > Triggers LPIs through the INT command. > > the test checks the LPI hits the right CPU and triggers > the right LPI intid, ie. the translation is correct. > > Updates to the config table also are tested, along with inv > and invall

Re: [PATCH v2 0/3] exclude hyperv synic sections from vhost

2020-01-13 Thread Paolo Bonzini
On 13/01/20 18:36, Dr. David Alan Gilbert (git) wrote: > > Hyperv's synic (that we emulate) is a feature that allows the guest > to place some magic (4k) pages of RAM anywhere it likes in GPA. > This confuses vhost's RAM section merging when these pages > land over the top of hugepages. Can you

[PATCH] qemu-nbd: Convert invocation documentation to rST

2020-01-13 Thread Peter Maydell
The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo format, which we present to the user as: * a qemu-nbd manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-nbd manpage * part of the

  1   2   3   >