Re: [PATCH] aspeed/smc: Fix DMA support for AST2600

2020-03-19 Thread Joel Stanley
On Fri, 20 Mar 2020 at 05:39, Cédric Le Goater wrote: > > Recent firmwares uses SPI DMA transfers in U-Boot to load the > different images (kernel, initrd, dtb) in the SoC DRAM. The AST2600 > FMC model is missing the masks to be applied on the DMA registers > which resulted in incorrect values.

[PATCH] aspeed/smc: Fix DMA support for AST2600

2020-03-19 Thread Cédric Le Goater
Recent firmwares uses SPI DMA transfers in U-Boot to load the different images (kernel, initrd, dtb) in the SoC DRAM. The AST2600 FMC model is missing the masks to be applied on the DMA registers which resulted in incorrect values. Fix that and wire the SPI controllers which have DMA support on

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Yan Zhao
On Fri, Mar 20, 2020 at 12:09:18PM +0800, Alex Williamson wrote: > On Thu, 19 Mar 2020 23:06:56 -0400 > Yan Zhao wrote: > > > On Fri, Mar 20, 2020 at 10:34:40AM +0800, Alex Williamson wrote: > > > On Thu, 19 Mar 2020 21:30:39 -0400 > > > Yan Zhao wrote: > > > > > > > On Thu, Mar 19, 2020 at

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 23:06:56 -0400 Yan Zhao wrote: > On Fri, Mar 20, 2020 at 10:34:40AM +0800, Alex Williamson wrote: > > On Thu, 19 Mar 2020 21:30:39 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 09:09:21PM +0800, Alex Williamson wrote: > > > > On Thu, 19 Mar 2020 01:05:54

Re: Qemu API documentation

2020-03-19 Thread Priyamvad Acharya
Thanks Alex, I will check it out. Have you look at below issue which I mention in my previous email? >>> *>> qemu-system-arm: Unknown device 'soc' for default sysbusAborted >>> (core>> dumped)** >>> >> On Thu, 19 Mar 2020 at 20:09, Alex Bennée wrote: > > Priyamvad Acharya writes: > > >

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Yan Zhao
On Fri, Mar 20, 2020 at 10:34:40AM +0800, Alex Williamson wrote: > On Thu, 19 Mar 2020 21:30:39 -0400 > Yan Zhao wrote: > > > On Thu, Mar 19, 2020 at 09:09:21PM +0800, Alex Williamson wrote: > > > On Thu, 19 Mar 2020 01:05:54 -0400 > > > Yan Zhao wrote: > > > > > > > On Thu, Mar 19, 2020 at

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 21:30:39 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 09:09:21PM +0800, Alex Williamson wrote: > > On Thu, 19 Mar 2020 01:05:54 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 11:49:26AM +0800, Alex Williamson wrote: > > > > On Wed, 18 Mar 2020 21:17:03

RE: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-19 Thread Chenqun (kuhn)
Gentle ping. Any other suggestions about this? Thanks. >-Original Message- >From: Chenqun (kuhn) >Sent: Wednesday, March 11, 2020 11:29 AM >To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org >Cc: Zhanghailiang ; Chenqun (kuhn) >; Euler Robot ; >Kevin Wolf ; Ronnie Sahlberg >; Paolo

Re: [PATCH v14 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Yan Zhao
On Thu, Mar 19, 2020 at 09:09:21PM +0800, Alex Williamson wrote: > On Thu, 19 Mar 2020 01:05:54 -0400 > Yan Zhao wrote: > > > On Thu, Mar 19, 2020 at 11:49:26AM +0800, Alex Williamson wrote: > > > On Wed, 18 Mar 2020 21:17:03 -0400 > > > Yan Zhao wrote: > > > > > > > On Thu, Mar 19, 2020 at

Re: [PATCH v4 0/2] add new options to set smbios type 4 fields

2020-03-19 Thread Heyi Guo
On 2020/3/19 22:46, Igor Mammedov wrote: On Wed, 18 Mar 2020 14:48:18 +0800 Heyi Guo wrote: Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to present CPU speed to their users. Normally these information can be fetched from host smbios. it's

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Yan Zhao
On Fri, Mar 20, 2020 at 12:57:30AM +0800, Kirti Wankhede wrote: > > > On 3/19/2020 6:36 PM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 02:15:34 -0400 > > Yan Zhao wrote: > > > >> On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: > >>> On Thu, 19 Mar 2020 00:15:33 -0400 > >>>

Re: [PATCH 0/5] QEMU Gating CI

2020-03-19 Thread Cleber Rosa
On Thu, Mar 19, 2020 at 05:33:01PM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On Tue, 17 Mar 2020 at 14:13, Cleber Rosa wrote: > >> > >> On Tue, Mar 17, 2020 at 09:29:32AM +, Peter Maydell wrote: > >> > Ah, I see. My assumption was that this was all stuff that you were >

[PATCH v2 0/2] Replaced locks with lock guard macros

2020-03-19 Thread dnbrdsky
From: Daniel Brodsky This patch set adds: - a fix for lock guard macros so they can be used multiple times in the same function - replacement of locks with lock guards where appropriate v1 -> v2: - fixed whitespace churn - added cover letter so patch set referenced correctly Daniel Brodsky

[PATCH v2 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread dnbrdsky
From: Daniel Brodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: Daniel Brodsky --- block/iscsi.c | 11 +++---

[PATCH v2 1/2] lockable: fix __COUNTER__ macro to be referenced properly

2020-03-19 Thread dnbrdsky
From: Daniel Brodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Fixes: 3284c3ddc4 Signed-off-by: Daniel Brodsky --- include/qemu/lockable.h | 2 +- include/qemu/rcu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Fri, 20 Mar 2020 01:46:41 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content

Re: [PATCH] ext4: Give 32bit personalities 32bit hashes

2020-03-19 Thread Linus Walleij
On Thu, Mar 19, 2020 at 4:25 PM Peter Maydell wrote: > On Thu, 19 Mar 2020 at 15:13, Linus Walleij wrote: > > On Tue, Mar 17, 2020 at 12:58 PM Peter Maydell > > wrote: > > > What in particular does this personality setting affect? > > > My copy of the personality(2) manpage just says: > > > >

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Daniel Brodsky
On Thu, Mar 19, 2020 at 1:53 PM Eric Blake wrote: > > Hmm. This one is a different failure than the other patchew warnings > about variable redefinition; but is still evidence that it is missing > your "[PATCH] misc: fix __COUNTER__ macro to be referenced properly". > At any rate, the fact that

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Daniel Brodsky
On Thu, Mar 19, 2020 at 1:48 PM Eric Blake wrote: > > On 3/19/20 11:19 AM, dnbrd...@gmail.com wrote: > > From: danbrodsky > > > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > > - replaced result with QEMU_LOCK_GUARD if all unlocks at function end > > - replaced result with

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Fri, 20 Mar 2020 01:55:10 +0530 Kirti Wankhede wrote: > On 3/19/2020 9:52 PM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 20:22:41 +0530 > > Kirti Wankhede wrote: > > > >> On 3/19/2020 9:15 AM, Alex Williamson wrote: > >>> On Thu, 19 Mar 2020 01:11:11 +0530 > >>> Kirti Wankhede

[PATCH v15 Kernel 6/7] vfio iommu: Adds flag to indicate dirty pages tracking capability support

2020-03-19 Thread Kirti Wankhede
Flag VFIO_IOMMU_INFO_DIRTY_PGS in VFIO_IOMMU_GET_INFO indicates that driver support dirty pages tracking. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- drivers/vfio/vfio_iommu_type1.c | 3 ++- include/uapi/linux/vfio.h | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-)

[PATCH v15 Kernel 3/7] vfio iommu: Add ioctl definition for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
IOMMU container maintains a list of all pages pinned by vfio_pin_pages API. All pages pinned by vendor driver through this API should be considered as dirty during migration. When container consists of IOMMU capable device and all pages are pinned and mapped, then all pages are marked dirty. Added

[PATCH v15 Kernel 7/7] vfio: Selective dirty page tracking if IOMMU backed device pins pages

2020-03-19 Thread Kirti Wankhede
Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 2:31 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it

[PATCH v15 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-03-19 Thread Kirti Wankhede
DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while guest driver could access those pages, host device or vendor driver can dirty these mapped pages. Such pages

[PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To

[PATCH v15 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-19 Thread Kirti Wankhede
- Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at the 0th offset of migration region to get/set VFIO device related information. Defined members of structure and usage on read/write access. - Defined device states and state

[PATCH v15 Kernel 0/7] KABIs to support migration for VFIO devices

2020-03-19 Thread Kirti Wankhede
Hi, This patch set adds: * New IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with respect to IOMMU container rather than per device. All pages pinned by vendor driver through vfio_pin_pages external API has to be marked as dirty during migration. When IOMMU capable device is

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 2:39 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can

[PATCH v15 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-03-19 Thread Kirti Wankhede
vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic variable is overkill. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- drivers/vfio/vfio_iommu_type1.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c

Re: [PATCH v2 6/8] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector

2020-03-19 Thread Programmingkid
> On Mar 17, 2020, at 6:46 PM, David Gibson wrote: > > On Tue, Mar 17, 2020 at 11:06:15AM -0400, Programmingkid wrote: >> >>> On Mar 17, 2020, at 7:01 AM, qemu-ppc-requ...@nongnu.org wrote: >>> >>> Message: 3 >>> Date: Tue, 17 Mar 2020 11:47:32 +0100 >>> From: Cédric Le Goater >>> To: David

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread Eric Blake
On 3/19/20 11:19 AM, dnbrd...@gmail.com wrote: From: danbrodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: danbrodsky ---

Re: [PULL v3 00/16] Linux user for 5.0 patches

2020-03-19 Thread Peter Maydell
On Thu, 19 Mar 2020 at 09:29, Laurent Vivier wrote: > > The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: > > qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-19 Thread Peter Maydell
Thanks, that's pretty clear. I expect you'll find the bug is just that QEMU doesn't get the semantics of an iret from userspace correct. The helper_iret_protected() function is probably a good place to look. -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PATCH] misc: fix __COUNTER__ macro to be referenced properly

2020-03-19 Thread Eric Blake
On 3/19/20 11:19 AM, dnbrd...@gmail.com wrote: From: danbrodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Signed-off-by: danbrodsky Thanks - this appears to be your first contribution to qemu. Typically, the S-o-b should match

Re: [PULL 3/4] s390/ipl: sync back loadparm

2020-03-19 Thread Peter Maydell
On Tue, 10 Mar 2020 at 15:09, Christian Borntraeger wrote: > > From: Halil Pasic > > We expose loadparm as a r/w machine property, but if loadparm is set by > the guest via DIAG 308, we don't update the property. Having a > disconnect between the guest view and the QEMU property is not nice in >

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 9:52 PM, Alex Williamson wrote: On Thu, 19 Mar 2020 20:22:41 +0530 Kirti Wankhede wrote: On 3/19/2020 9:15 AM, Alex Williamson wrote: On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: + +static int verify_bitmap_size(uint64_t npages, uint64_t bitmap_size) +{

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-19 Thread Robert Henry
yes, it is intentional. I don't yet understand why, but am talking to those who do. https://github.com/dotnet/runtime/blob/1b02665be501b695b9c22c1ebd69148c07a225f6/src/coreclr/src/pal/src/arch/amd64/context2.S#L183 -- You received this bug notification because you are a member of qemu-

Re: [PATCH v6 14/61] target/riscv: vector single-width bit shift instructions

2020-03-19 Thread Alistair Francis
On Tue, Mar 17, 2020 at 8:35 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 25 > target/riscv/insn32.decode | 9 +++ >

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-19 Thread Peter Maydell
Is dotnet intentionally doing an iret? It seems like an odd thing for a userspace program to do, given it's basically "return from interrupt". -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866892

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH v2 6/6] scripts/coverity-scan: Add Docker support

2020-03-19 Thread Peter Maydell
Add support for running the Coverity Scan tools inside a Docker container rather than directly on the host system. Signed-off-by: Peter Maydell --- v1->v2: * various bug fixes * added --src-tarball rather than putting the whole source tree in the 'secrets' directory * docker file package

[PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc

2020-03-19 Thread Peter Maydell
All the Coverity-specific definitions of qemu_mutex_lock() and friends have a trailing semicolon. This works fine almost everywhere because of QEMU's mandatory-braces coding style and because most callsites are simple, but target/s390x/sigp.c has a use of qemu_mutex_trylock() as an if() statement,

[PATCH v2 5/6] scripts/run-coverity-scan: Script to run Coverity Scan build

2020-03-19 Thread Peter Maydell
Add a new script to automate the process of running the Coverity Scan build tools and uploading the resulting tarball to the website. This is intended eventually to be driven from Travis, but it can be run locally, if you are a maintainer of the QEMU project on the Coverity Scan website and have

[PATCH v2 0/6] Automation of Coverity Scan uploads (via Docker)

2020-03-19 Thread Peter Maydell
v1 of this series was over a year ago: https://patchew.org/QEMU/20181113184641.4492-1-peter.mayd...@linaro.org/ I dusted it off and fixed some stuff because Paolo reports that the machine he was previously using for uploads can't run the Coverity tools any more. The first four patches are fixes

[PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h

2020-03-19 Thread Peter Maydell
The target_flat.h file is a QEMU header, so we should include it using quotes, not angle brackets. Coverity otherwise is unable to find the header: "../linux-user/flatload.c", line 40: error #1712: cannot open source file "target_flat.h" #include ^ because

[PATCH v2 2/6] thread.h: Fix Coverity version of qemu_cond_timedwait()

2020-03-19 Thread Peter Maydell
For Coverity's benefit, we provide simpler versions of functions like qemu_mutex_lock(), qemu_cond_wait() and qemu_cond_timedwait(). When we added qemu_cond_timedwait() in commit 3dcc9c6ec4ea, a cut and paste error meant that the Coverity version of qemu_cond_timedwait() was using the wrong _impl

[PATCH v2 1/6] osdep.h: Drop no-longer-needed Coverity workarounds

2020-03-19 Thread Peter Maydell
In commit a1a98357e3fd in 2018 we added some workarounds for Coverity not being able to handle the _Float* types introduced by recent glibc. Newer versions of the Coverity scan tools have support for these types, and will fail with errors about duplicate typedefs if we have our workaround.

Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319161925.1818377-2-dnbrd...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v5 2/3] net: tulip: add .can_receive routine

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 6:40 PM, P J P wrote: From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v3: define .can_receive

Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files

2020-03-19 Thread Aleksandar Markovic
On Thursday, March 19, 2020, Laurent Vivier wrote: > Le 19/03/2020 à 17:24, Aleksandar Markovic a écrit : > >> I think we should first introduce a linux-user/generic/termbits.h as we > >> have an asm-generic/termbits.h in the kernel and use it with all the > >> targets except alpha, mips, hppa,

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 9:15 AM, Alex Williamson wrote: On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-19 Thread Robert Henry
I have confirmed that the dotnet guest application is executing a "iretq" instruction when this guest kernel bug is hit. A first round of analysis shows nothing unreasonable at the point the iretq is executed. The $rsp points into the middle of a mapped in page, the returned-to $rip looks

Re: [PATCH v10 01/16] s390x: Move diagnose 308 subcodes and rcs into ipl.h

2020-03-19 Thread Claudio Imbrenda
On Wed, 18 Mar 2020 10:30:32 -0400 Janosch Frank wrote: > They are part of the IPL process, so let's put them into the ipl > header. > > Signed-off-by: Janosch Frank Reviewed-by: Claudio Imbrenda > --- > hw/s390x/ipl.h | 11 +++ > target/s390x/diag.c | 11 --- > 2

Re: [PATCH v3] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-19 Thread Paolo Bonzini
On 19/03/20 19:07, Roman Bolshakov wrote: >> From the other thread discussions, I'd keep you at least listed as >> designated reviewer: >> >> R: Roman Bolshakov >> > Sounds good to me, thanks. I'll add you back. Anyway as long as it's me sending pull requests, M vs. R doesn't change much.

Re: [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-19 Thread Dr. David Alan Gilbert
* Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > On Wed, Mar 18, 2020 at 12:48 PM Dr. David Alan Gilbert > wrote: > > > * Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > > > Save and restore RSS/hash report configuration. > > > > > > Signed-off-by: Yuri Benditovich > > > --- >

Re: [PATCH v3] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-19 Thread Roman Bolshakov
On Thu, Mar 19, 2020 at 06:06:15PM +0100, Philippe Mathieu-Daudé wrote: > On 3/19/20 2:55 PM, Roman Bolshakov wrote: > > Cameron signed up for taking HVF ownership. > > > > Cc: Cameron Esfahani > > Cc: Nikita Leshenko > > Cc: Sergio Andres Gomez Del Real > > Cc: Patrick Colp > > Cc: Liran

Re: [PULL v2 00/11] Bitmaps patches

2020-03-19 Thread John Snow
On 3/19/20 1:57 PM, Peter Maydell wrote: > On Wed, 18 Mar 2020 at 20:24, John Snow wrote: >> >> The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: >> >> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into >> staging (2020-03-17 18:33:05 +) >>

Re: [PULL 00/20] Ide patches

2020-03-19 Thread John Snow
On 3/19/20 8:33 AM, Peter Maydell wrote: > On Tue, 17 Mar 2020 at 23:23, John Snow wrote: >> >> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: >> >> qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) >> >> are available in the Git repository at:

Re: [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-19 Thread Juan Quintela
Hi Yuri Yuri Benditovich wrote: > On Wed, Mar 18, 2020 at 12:48 PM Dr. David Alan Gilbert > wrote: > > * Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > > Save and restore RSS/hash report configuration. > > > > Signed-off-by: Yuri Benditovich > > --- > > hw/net/virtio-net.c |

Re: [PULL v2 00/11] Bitmaps patches

2020-03-19 Thread Peter Maydell
On Wed, 18 Mar 2020 at 20:24, John Snow wrote: > > The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-03-17 18:33:05 +) > > are available in the Git repository at: > >

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2020 at 07:12:20PM +0200, Yuri Benditovich wrote: > > > On Wed, Mar 18, 2020 at 11:42 AM Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2020 at 11:15:24AM +0200, Yuri Benditovich wrote: > > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is > > 16-bit field. >

Re: [PATCH v3 02/10] fw_cfg: Migrate ACPI table mr sizes separately

2020-03-19 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:27:32AM +, Shameerali Kolothum Thodi wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: 11 March 2020 21:10 > > To: Shameerali Kolothum Thodi > > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > >

[PATCH] misc: fix __COUNTER__ macro to be referenced properly

2020-03-19 Thread dnbrdsky
From: danbrodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Signed-off-by: danbrodsky --- include/qemu/lockable.h | 2 +- include/qemu/rcu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] lockable: replaced locks with lock guard macros where appropriate

2020-03-19 Thread dnbrdsky
From: danbrodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: danbrodsky --- block/iscsi.c | 23 +++

Re: [PATCH v4 2/3] net: tulip: add .can_recieve routine

2020-03-19 Thread P J P
+-- On Thu, 19 Mar 2020, Philippe Mathieu-Daudé wrote --+ | Typo "can_recieve" -> "can_receive" in subject. Oops! Fixed it, sent revised patch v5. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D

Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2020 at 02:54:11PM +0100, David Hildenbrand wrote: > Why does the balloon driver not support VIRTIO_F_IOMMU_PLATFORM? It is > absolutely not clear to me. The introducing commit mentioned that it > "bypasses DMA". I fail to see that. Well sure one can put the balloon behind an

[PATCH v5 3/3] net: tulip: flush queued packets post receive

2020-03-19 Thread P J P
From: Prasad J Pandit Call qemu_flush_queued_packets to flush queued packets once they are read in tulip_receive(). Suggested-by: Jason Wang Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 2 ++ 1 file changed, 2 insertions(+) Update v4: call qemu_flush_queued_packets() ->

[PATCH v5 1/3] net: tulip: check frame size and r/w data length

2020-03-19 Thread P J P
From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Limit iterations over descriptors to avoid potential infinite loop issue in tulip_xmit_list_update. Reported-by:

[PATCH v5 2/3] net: tulip: add .can_receive routine

2020-03-19 Thread P J P
From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v3: define .can_receive routine ->

[PATCH v5 0/3] net: tulip: add checks to avoid OOB access

2020-03-19 Thread P J P
From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel driver ->

Re: [PATCH v6 12/61] target/riscv: vector integer add-with-carry / subtract-with-borrow instructions

2020-03-19 Thread Alistair Francis
On Tue, Mar 17, 2020 at 8:31 AM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 33 ++ > target/riscv/insn32.decode | 11 ++ > target/riscv/insn_trans/trans_rvv.inc.c | 78

Re: [PATCH v2] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-19 Thread Paolo Bonzini
On 19/03/20 14:43, Roman Bolshakov wrote: > On Wed, Mar 18, 2020 at 11:47:15AM +0100, Paolo Bonzini wrote: >> >> Queued, thanks. >> > > Hi Paolo, > > I'm going to send v3 shortly to include Cameron as maintainer. Okay! Paolo

Re: [PATCH 00/13] microvm: add acpi support

2020-03-19 Thread Paolo Bonzini
On 19/03/20 14:40, Gerd Hoffmann wrote: >> Also, can you confirm that it builds without CONFIG_I440FX and >> CONFIG_Q35? You probably need to add "imply ACPI" and possibly some >> '#include "config-devices.h"' and '#ifdef CONFIG_ACPI' here and there. > Hmm, is there some way to do this without

Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-19 Thread David Hildenbrand
[...] >> >> I asked this question already to Michael (cc) via a different channel, >> but hare is it again: >> >> Why does the balloon driver not support VIRTIO_F_IOMMU_PLATFORM? It is >> absolutely not clear to me. The introducing commit mentioned that it >> "bypasses DMA". I fail to see that.

Re: [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2020 at 07:19:26PM +0200, Yuri Benditovich wrote: > > > On Wed, Mar 18, 2020 at 12:48 PM Dr. David Alan Gilbert > wrote: > > * Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > > Save and restore RSS/hash report configuration. > > > > Signed-off-by: Yuri

Re: [PATCH v5 7/7] virtio-net: add migration support for RSS and hash report

2020-03-19 Thread Yuri Benditovich
On Wed, Mar 18, 2020 at 12:48 PM Dr. David Alan Gilbert wrote: > * Yuri Benditovich (yuri.benditov...@daynix.com) wrote: > > Save and restore RSS/hash report configuration. > > > > Signed-off-by: Yuri Benditovich > > --- > > hw/net/virtio-net.c | 26 ++ > > 1 file

Re: [PATCH 1/4] tests/vm: write raw console log

2020-03-19 Thread Alex Bennée
Cleber Rosa writes: > On Mon, Mar 16, 2020 at 03:22:07PM +0100, Philippe Mathieu-Daudé wrote: >> On 3/16/20 3:16 PM, Alex Bennée wrote: >> > >> > Gerd Hoffmann writes: >> > >> > > Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal >> > > to watch the install console. >> > > >> >

Re: [PATCH v5 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-19 Thread Yuri Benditovich
On Wed, Mar 18, 2020 at 11:42 AM Michael S. Tsirkin wrote: > On Wed, Mar 18, 2020 at 11:15:24AM +0200, Yuri Benditovich wrote: > > Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is > > 16-bit field. > > > > Signed-off-by: Yuri Benditovich > > Hmm this is exactly my patch isn't it? If yes

Re: [PATCH v1] configure: record sphinx output

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 3:39 PM, Olaf Hering wrote: If configure fails to run due to errors in the expected sphinx environment no helpful message is recorded. Write all of the output to config.log to assist with debugging. Signed-off-by: Olaf Hering --- configure | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v6 09/61] target/riscv: add vector amo operations

2020-03-19 Thread Alistair Francis
On Tue, Mar 17, 2020 at 8:25 AM LIU Zhiwei wrote: > > Vector AMOs operate as if aq and rl bits were zero on each element > with regard to ordering relative to other instructions in the same hart. > Vector AMOs provide no ordering guarantee between element operations > in the same vector AMO

Re: [PATCH v3] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-19 Thread Philippe Mathieu-Daudé
On 3/19/20 2:55 PM, Roman Bolshakov wrote: Cameron signed up for taking HVF ownership. Cc: Cameron Esfahani Cc: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Patrick Colp Cc: Liran Alon Cc: Heiher Signed-off-by: Roman Bolshakov --- Changes since v2: Removed myself from the

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 6:36 PM, Alex Williamson wrote: On Thu, 19 Mar 2020 02:15:34 -0400 Yan Zhao wrote: On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: On Thu, 19 Mar 2020 00:15:33 -0400 Yan Zhao wrote: On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: On

[PATCH] aio-posix: fix io_uring with external events

2020-03-19 Thread Stefan Hajnoczi
When external event sources are disabled fdmon-io_uring falls back to fdmon-poll. The ->need_wait() callback needs to watch for this so it can return true when external event sources are disabled. It is also necessary to call ->wait() when AioHandlers have changed because io_uring is

Re: [PATCH v6 11/61] target/riscv: vector widening integer add and subtract

2020-03-19 Thread Alistair Francis
On Tue, Mar 17, 2020 at 8:29 AM LIU Zhiwei wrote: > > Reviewed-by: Richard Henderson > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/helper.h | 49 +++ > target/riscv/insn32.decode | 16 +++ >

Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files

2020-03-19 Thread Laurent Vivier
Le 19/03/2020 à 17:24, Aleksandar Markovic a écrit : >> I think we should first introduce a linux-user/generic/termbits.h as we >> have an asm-generic/termbits.h in the kernel and use it with all the >> targets except alpha, mips, hppa, sparc and xtensa. >> >> I think this

Re: [PATCH 0/5] QEMU Gating CI

2020-03-19 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 17 Mar 2020 at 14:13, Cleber Rosa wrote: >> >> On Tue, Mar 17, 2020 at 09:29:32AM +, Peter Maydell wrote: >> > Ah, I see. My assumption was that this was all stuff that you were >> > working on, so that I would then be able to test that it worked correctly,

Re: [EXTERNAL] [PATCH v2] target/ppc: Fix ISA v3.0 (POWER9) slbia implementation

2020-03-19 Thread Cédric Le Goater
On 3/19/20 7:44 AM, Nicholas Piggin wrote: > The new ISA v3.0 slbia variants have not been implemented for TCG, > which can lead to crashing when a POWER9 machine boots Linux using > the hash MMU, for example ("disable_radix" kernel command line). > > Add them. > > Signed-off-by: Nicholas Piggin

Re: [PATCH 0/4] linux-user: Fix some issues in termbits.h files

2020-03-19 Thread Aleksandar Markovic
> I think we should first introduce a linux-user/generic/termbits.h as we > have an asm-generic/termbits.h in the kernel and use it with all the > targets except alpha, mips, hppa, sparc and xtensa. > > I think this linux-user/generic/termbits.h could be copied from >

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 20:22:41 +0530 Kirti Wankhede wrote: > On 3/19/2020 9:15 AM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 01:11:11 +0530 > > Kirti Wankhede wrote: > > > >> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > >> - Start dirty pages tracking while migration is

Re: [PATCH 1/1] conf: qemu 9pfs: add 'multidevs' option

2020-03-19 Thread Ján Tomko
On a Thursday in 2020, Christian Schoenebeck wrote: On Donnerstag, 19. März 2020 14:10:26 CET Ján Tomko wrote: On a Tuesday in 2020, Christian Schoenebeck wrote: >Introduce new 'multidevs' option for filesystem. > > I don't like the 'multidevs' name, but cannot think of anything beter.

Re: [PATCH v1 1/1] target/riscv: Don't set write permissions on dirty PTEs

2020-03-19 Thread Alistair Francis
On Wed, Mar 18, 2020 at 9:52 PM Palmer Dabbelt wrote: > > On Tue, 03 Mar 2020 17:16:59 PST (-0800), Alistair Francis wrote: > > The RISC-V spec specifies that when a write happens and the D bit is > > clear the implementation will set the bit in the PTE. It does not > > describe that the PTE

Re: [PATCH 1/1] conf: qemu 9pfs: add 'multidevs' option

2020-03-19 Thread Daniel P . Berrangé
On Thu, Mar 19, 2020 at 04:57:41PM +0100, Christian Schoenebeck wrote: > On Donnerstag, 19. März 2020 14:10:26 CET Ján Tomko wrote: > > On a Tuesday in 2020, Christian Schoenebeck wrote: > > >Introduce new 'multidevs' option for filesystem. > > > > > > > > > > I don't like the 'multidevs' name,

Re: [PATCH 1/1] conf: qemu 9pfs: add 'multidevs' option

2020-03-19 Thread Christian Schoenebeck
On Donnerstag, 19. März 2020 14:10:26 CET Ján Tomko wrote: > On a Tuesday in 2020, Christian Schoenebeck wrote: > >Introduce new 'multidevs' option for filesystem. > > > > > > I don't like the 'multidevs' name, but cannot think of anything > beter. > > 'collisions' maybe? Not sure if

Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-19 Thread Halil Pasic
On Thu, 19 Mar 2020 14:54:11 +0100 David Hildenbrand wrote: > On 27.02.20 13:24, Halil Pasic wrote: > > On Wed, 26 Feb 2020 16:11:03 +0100 > > Janosch Frank wrote: > > > >> On 2/26/20 3:59 PM, David Hildenbrand wrote: > >>> On 26.02.20 13:20, Janosch Frank wrote: > Ballooning in protected

Re: [PULL 00/13] x86 and machine queue for 5.0 soft freeze

2020-03-19 Thread Peter Maydell
On Wed, 18 Mar 2020 at 01:17, Eduardo Habkost wrote: > > The following changes since commit d649689a8ecb2e276cc20d3af6d416e3c299cb17: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-03-17 18:33:05 +) > > are available in the Git repository at: > >

Re: [PATCH] ext4: Give 32bit personalities 32bit hashes

2020-03-19 Thread Peter Maydell
On Thu, 19 Mar 2020 at 15:13, Linus Walleij wrote: > On Tue, Mar 17, 2020 at 12:58 PM Peter Maydell > wrote: > > What in particular does this personality setting affect? > > My copy of the personality(2) manpage just says: > > > >PER_LINUX32 (since Linux 2.2) > > [To be

Re: [PATCH] ext4: Give 32bit personalities 32bit hashes

2020-03-19 Thread Linus Walleij
On Tue, Mar 17, 2020 at 11:29 PM Andreas Dilger wrote: > That said, I'd think it would be preferable for ease of use and > compatibility that applications didn't have to be modified > (e.g. have QEMU or glibc internally set PER_LINUX32 for this > process before the 32-bit syscall is called,

Re: [PATCH] ext4: Give 32bit personalities 32bit hashes

2020-03-19 Thread Linus Walleij
On Tue, Mar 17, 2020 at 12:58 PM Peter Maydell wrote: > On Tue, 17 Mar 2020 at 11:31, Linus Walleij wrote: > > > > It was brought to my attention that this bug from 2018 was > > still unresolved: 32 bit emulators like QEMU were given > > 64 bit hashes when running 32 bit emulation on 64 bit

  1   2   3   >