[Bug 1880539] Re: I/O write make QXL abort in qxl_set_mode()

2020-07-10 Thread Alexander Bulekov
Here's a qtest reproducer for this: cat << EOF | ./i386-softmmu/qemu-system-i386 -M q35,accel=qtest -qtest null -nographic -vga qxl -qtest stdio -nodefaults outl 0xcf8 0x8804 outb 0xcfc 0xff outl 0xcf8 0x8819 outl 0xcfc 0x87caff7a outb 0x86 0x23 EOF -- You received this bug notification

Re: [PATCH v5 1/4] target/i386: add missing vmx features for several CPU models

2020-07-10 Thread Chenyi Qiang
On 7/11/2020 12:48 AM, Eduardo Habkost wrote: On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote: On 7/10/2020 6:12 AM, Eduardo Habkost wrote: I'm very sorry for taking so long to review this. Question below: On Fri, Jun 19, 2020 at 03:31:11PM +0800, Chenyi Qiang wrote: Add

Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-07-10 Thread Corey Minyard
On Fri, Jul 10, 2020 at 11:53:13AM +0200, Philippe Mathieu-Daudé wrote: > Corey, this series is now fully reviewed :) Ok, I've pulled this in and added the extra reviews that came in. I'll work on getting it out Monday. Thanks, -corey > > On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote: > >

[PULL v3 41/47] cpu-throttle: new module, extracted from cpus.c

2020-07-10 Thread Paolo Bonzini
From: Claudio Fontana move the vcpu throttling functionality into its own module. This functionality is not specific to any accelerator, and it is used currently by migration to slow down guests to try to have migrations converge, and by the cocoa MacOS UI to throttle speed. cpu-throttle

[PULL v3 00/47] Misc patches for QEMU 5.1 soft freeze

2020-07-10 Thread Paolo Bonzini
The following changes since commit 45db94cc90c286a9965a285ba19450f448760a09: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20200707' into staging (2020-07-10 16:43:40 +0100) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[PULL v3 47/47] linux-headers: update again to 5.8

2020-07-10 Thread Paolo Bonzini
5.8-rc1 inadvertently broke userspace ABI compatibility. Merge again with latest kvm/master to undo that. Signed-off-by: Paolo Bonzini --- linux-headers/asm-arm/unistd-common.h | 1 + linux-headers/asm-x86/kvm.h | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH for-5.1] tcg: Save/restore vecop_list around minmax fallback

2020-07-10 Thread Richard Henderson
Forgetting this asserts when tcg_gen_cmp_vec is called from within tcg_gen_cmpsel_vec. Fixes: 72b4c792c7a Signed-off-by: Richard Henderson --- I found this while testing SVE2 (and the patch is included in the large SVE2 patch set), but it seems like it should be reproducible with master.

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-10 Thread Paolo Bonzini
On 10/07/20 06:36, Thomas Huth wrote: > > In short this goes away if I again set icount to enabled for qtest, > basically ensuring that --enable-tcg is there and then reenabling icount. > > qtest was forcing icount and shift=0 by creating qemu options, in order to > misuse its counter feature,

[Bug 697510] Re: Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2020-07-10 Thread Alexander Bulekov
Here is a qtest reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 -nographic -M q35,accel=qtest -qtest stdio -drive if=none,id=drive0,file=null-co://,file.read-zeroes=on,format=raw -device lsi53c895a,id=scsi0 -device scsi-hd,drive=drive0,bus=scsi0.0,channel=0,scsi-id=0,lun=0 -monitor

[PATCH 0/1] MAINTAINERS: Add Python library stanza

2020-07-10 Thread John Snow
John Snow (1): MAINTAINERS: Add Python library stanza MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.21.3

[PATCH 1/1] MAINTAINERS: Add Python library stanza

2020-07-10 Thread John Snow
I'm proposing that I split the actual Python library off from the other miscellaneous python scripts we have and declare it maintained. Add myself as a maintainer of this folder, along with Cleber. Signed-off-by: John Snow --- MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1

Re: [RFC 00/65] target/riscv: support vector extension v0.9

2020-07-10 Thread Alistair Francis
On Fri, Jul 10, 2020 at 5:59 AM wrote: > > From: Frank Chang > > This patchset implements the vector extension v0.9 for RISC-V on QEMU. > > This patchset is sent as RFC because RVV v0.9 is still in draft state. > However, as RVV v1.0 should be ratified soon and there shouldn't be > critical

Re: [PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-10 Thread Richard Henderson
On 7/9/20 7:13 AM, Alex Bennée wrote: > Not all compilers support the -Wpsabi (clang-9 in my case). > > Fixes: bac8d222a > Signed-off-by: Alex Bennée > --- > tests/plugin/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/plugin/Makefile

Re: [PATCH v1 09/13] target/sh4: revert to using cpu_lduw_code to decode gusa

2020-07-10 Thread Richard Henderson
On 7/9/20 7:13 AM, Alex Bennée wrote: > The translator_ld* functions very much expect us to be decoding one > instruction at a time. Otherwise we will see weirdness such as: > > qemu-sh4: warning: plugin_disas: 6 bytes left over > > when we use the disas functions. For what SH4 is doing here

Re: [PATCH v1 04/13] cputlb: ensure we save the IOTLB data in case of reset

2020-07-10 Thread Richard Henderson
On 7/9/20 7:13 AM, Alex Bennée wrote: > Any write to a device might cause a re-arrangement of memory > triggering a TLB flush and potential re-size of the TLB invalidating > previous entries. This would cause users of qemu_plugin_get_hwaddr() > to see the warning: > > invalid use of

Re: [PATCH 1/2] iotests: Drop readarray from _do_filter_img_create

2020-07-10 Thread Alex Bennée
Max Reitz writes: > Some systems where we run tests on do not have a 4.x bash, so they do > not have readarray. While it looked a bit nicer than messing with > `head` and `tail`, we do not really need it, so we might as well not use > it. I've fixed the cirrus build failure by brew

[PATCH] Emulate dip switch language layout settings on SUN keyboard

2020-07-10 Thread Henrik Carlqvist
SUN Type 4, 5 and 5c keyboards have dip switches to choose the language layout of the keyboard. Solaris makes an ioctl to query the value of the dipswitches and uses that value to select keyboard layout. Also the SUN bios like the one in the file ss5.bin uses this value to support at least some

[PATCH 1/2] tests: fix "make check-qtest" for modular builds

2020-07-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include index 98af2c2d9338..6a0276fd42dd 100644 --- a/tests/qtest/Makefile.include +++ b/tests/qtest/Makefile.include @@ -277,6

[PATCH 2/2] Revert "vga: build virtio-gpu as module"

2020-07-10 Thread Gerd Hoffmann
This reverts commit 8d5a24c83dba90b08ef163bbf166d6dfbad9019b. Compiling all virtio-gpu objects into a single module isn't a good plan because the individual objects have different CONFIG_* dependencies. Leads to module load failures on s390x due to vga support being disabled, which in turn breaks

[PATCH 0/2] module fixes

2020-07-10 Thread Gerd Hoffmann
Gerd Hoffmann (2): tests: fix "make check-qtest" for modular builds Revert "vga: build virtio-gpu as module" util/module.c| 6 -- hw/display/Makefile.objs | 23 ++- tests/qtest/Makefile.include | 1 + 3 files changed, 11 insertions(+), 19

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

2020-07-10 Thread Alberto Garcia
On Fri 10 Jul 2020 06:43:59 PM CEST, no-re...@patchew.org wrote: > /tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may > be used uninitialized in this function [-Werror=maybe-uninitialized] > } else if (type != expected_type) { >^ >

Re: [PATCH v1] target/riscv: fix pmp implementation

2020-07-10 Thread Alistair Francis
On Mon, Jul 6, 2020 at 2:45 AM Alexandre Mergnat wrote: > > The end address calculation for NA4 mode is wrong because the address > used isn't shifted. > > That imply all NA4 setup are not applied by the PMP. I'm not sure what you mean here, can you clarify this? > > The solution is to use the

Re: [PATCH] cpu: Add starts_halted() method

2020-07-10 Thread Eduardo Habkost
On Fri, Jul 10, 2020 at 05:02:38PM -0300, Thiago Jung Bauermann wrote: > > Philippe Mathieu-Daudé writes: > > > On 7/9/20 5:26 AM, Thiago Jung Bauermann wrote: > >> > >> Thiago Jung Bauermann writes: > >> > >>> I'm seeing the vcpu being KVM_RUN'd too early twice during hotplug. > >>> Both of

Re: [PATCH] cpu: Add starts_halted() method

2020-07-10 Thread Thiago Jung Bauermann
Alex Bennée writes: > Thiago Jung Bauermann writes: > >> Eduardo Habkost writes: >> >>> On Wed, Jul 08, 2020 at 09:11:55PM +0100, Peter Maydell wrote: On Wed, 8 Jul 2020 at 18:36, Eduardo Habkost wrote: > > On Wed, Jul 08, 2020 at 06:09:49PM +0100, Peter Maydell wrote: >

Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent

2020-07-10 Thread Eduardo Habkost
On Fri, Jul 10, 2020 at 11:12:33AM +0200, Philippe Mathieu-Daudé wrote: > On 7/9/20 10:05 PM, Eduardo Habkost wrote: > > On Fri, Jun 26, 2020 at 04:15:40PM +0200, Philippe Mathieu-Daudé wrote: > >> On 6/26/20 4:03 PM, BALATON Zoltan wrote: > >>> On Fri, 26 Jun 2020, Philippe Mathieu-Daudé

Re: [PATCH] tests: improve performance of device-introspect-test

2020-07-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > Total execution time with "-m slow" and x86_64 QEMU, drops from 3 > minutes 15 seconds, down to 54 seconds. > > Individual tests drop from 17-20 seconds, down to 3-4 seconds. Nice! A few observations on this test (impatient readers may skip to "Conclusions"): *

Re: [PATCH] cpu: Add starts_halted() method

2020-07-10 Thread Thiago Jung Bauermann
Philippe Mathieu-Daudé writes: > On 7/9/20 5:26 AM, Thiago Jung Bauermann wrote: >> >> Thiago Jung Bauermann writes: >> >>> I'm seeing the vcpu being KVM_RUN'd too early twice during hotplug. >>> Both of them are before cpu_reset() and ppc_cpu_reset(). >> >> Hm, rereading the message

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-07-10 Thread Jan Klos
Yep, I read the Reddit thread, had no idea this was possible. Still, both solutions are ugly workarounds and it would be nice to fix this properly. But at least I don't have to patch and compile QEMU on my own anymore. -- You received this bug notification because you are a member of qemu-

[PATCH] linux-user: Add several IFTUN ioctls

2020-07-10 Thread Josh Kunz
This change includes most widely-available if_tun ioctls that are integer typed. Tested by compiling all linux-user emulators. This patch has also been used successfully to run several binaries that utilize these ioctls for several months. Linux Header:

Re: [PATCH v5 19/20] tests/acpi: add microvm test

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:55 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > tests/qtest/bios-tables-test.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index

Re: [PATCH v5 18/20] tests/acpi: allow override blkdev

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:54 +0200 Gerd Hoffmann wrote: > microvm needs virtio-blk instead of ide. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v5 16/20] microvm: wire up hotplug

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:52 +0200 Gerd Hoffmann wrote: > The cpu hotplug code handles the initialization of coldplugged cpus > too, so it is needed even in case cpu hotplug is not supported. > > Wire cpu hotplug up for microvm. > Without this we get a broken MADT table. > > Signed-off-by:

Re: [PATCH v7 17/47] block: Re-evaluate backing file handling in reopen

2020-07-10 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Reopening a node's backing child needs a bit of special handling because the "backing" child has different defaults than all other children (among other things). Adding filter support here is a bit more difficult than just using the child access functions.

Re: [PATCH v5 15/20] x86: move cpu plug from pc to x86

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:51 +0200 Gerd Hoffmann wrote: > The cpu hotplug code handles the initialization of coldplugged cpus > too, so it is needed even in case cpu hotplug is not supported. > > Move the code from pc to x86, so microvm can use it. it's very convinient to have all hotplug

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-10 Thread Igor Mammedov
On Thu, 9 Jul 2020 14:33:32 +0200 Gerd Hoffmann wrote: > Hi, > > > > +scope = aml_scope("\\"); > > > +pkg = aml_package(4); > > > +aml_append(pkg, aml_int(5)); /* SLEEP_CONTROL_REG.SLP_TYP */ > > > > I'm not sure what does the comment refer to here. > > It's the register

Re: Updates on libcapstone?

2020-07-10 Thread Richard Henderson
On 7/9/20 6:07 AM, Philippe Mathieu-Daudé wrote: > I remember you had a series related to capstone, but eventually there > was a problem so you postponed it until some patches were merged > upstream, do you remember? I do. My biggest problem with libcapstone is that it doesn't have an automated

Re: [PATCH 0/2] keepalive default

2020-07-10 Thread Vladimir Sementsov-Ogievskiy
09.07.2020 20:14, Vladimir Sementsov-Ogievskiy wrote: 09.07.2020 18:34, Eric Blake wrote: On 7/9/20 3:35 AM, Daniel P. Berrangé wrote: On Wed, Jul 08, 2020 at 10:15:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! We understood, that keepalive is almost superfluous with default 2

Re: [PATCH 3/3] cpu-timers, icount: new modules

2020-07-10 Thread Claudio Fontana
On 7/10/20 8:33 AM, Cornelia Huck wrote: > On Thu, 9 Jul 2020 20:46:56 +0200 > Claudio Fontana wrote: > >> On 7/9/20 8:38 PM, Claudio Fontana wrote: >>> On 7/8/20 5:05 PM, Paolo Bonzini wrote: On 08/07/20 17:00, Claudio Fontana wrote: >> Bisectable, 100% failure rate, etc. :( Can

Re: [PULL 10/41] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-07-10 Thread John Snow
On 7/7/20 3:08 AM, Alex Bennée wrote: > From: Robert Foley > Hi, this creates some pylint regressions, can they please be addressed first? > We add the ConsoleSocket object, which has a socket interface > and which will consume all arriving characters on the > socket, placing them into an

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
@Langston will do tomorrow. s390x ABI requires heavy changes to the python script. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885332 Title: Error in user-mode calculation of ELF aux vector's

Re: [RFC PATCH] configure: remove all dependencies on a (re)configure

2020-07-10 Thread Richard Henderson
On 7/8/20 10:53 AM, Alex Bennée wrote: > The previous code was brittle and missed cases such as the mipn32 > variants which for some reason has the 64 bit syscalls. This leads to > a number of binary targets having deps lines like: > >

Re: [PATCH v4 0/7] riscv: Switch to use generic platform fw_dynamic type opensbi bios images

2020-07-10 Thread Alistair Francis
On Fri, Jul 10, 2020 at 11:59 AM Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 10:05 PM Bin Meng wrote: > > > > From: Bin Meng > > > > The RISC-V generic platform is a flattened device tree (FDT) based > > platform where all platform specific functionality is provided based > > on FDT

Re: [PATCH v4 0/7] riscv: Switch to use generic platform fw_dynamic type opensbi bios images

2020-07-10 Thread Alistair Francis
On Thu, Jul 9, 2020 at 10:05 PM Bin Meng wrote: > > From: Bin Meng > > The RISC-V generic platform is a flattened device tree (FDT) based > platform where all platform specific functionality is provided based > on FDT passed by previous booting stage. The support was added in > the upstream

Re: [PATCH v5 07/20] microvm: make virtio irq base runtime configurable

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:43 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov > --- > include/hw/i386/microvm.h | 2 +- > hw/i386/microvm.c | 11 +++ > 2 files changed, 8 insertions(+), 5 deletions(-) > >

Re: [PATCH v5 04/20] acpi: ged: add control regs

2020-07-10 Thread Igor Mammedov
On Tue, 7 Jul 2020 14:53:40 +0200 Gerd Hoffmann wrote: > Add control regs (sleep, reset) for hw-reduced acpi. > > Signed-off-by: Gerd Hoffmann with below comments addressed: Reviewed-by: Igor Mammedov > --- > include/hw/acpi/generic_event_device.h | 7 >

Re: [PATCH v1] configure: fix malloc check

2020-07-10 Thread Richard Henderson
On 7/7/20 10:13 AM, Olaf Hering wrote: > Avoid random return value. > > Fixes commit f2dfe54c74f768a5bf78c9e5918918727f9d9459 > > Signed-off-by: Olaf Hering > --- > configure | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v5 5/5] vhost-user-blk: default num_queues to -smp N

2020-07-10 Thread Raphael Norwitz
On Fri, Jul 10, 2020 at 5:53 AM Stefan Hajnoczi wrote: > > On Thu, Jul 09, 2020 at 11:02:24AM -0700, Raphael Norwitz wrote: > > On Mon, Jul 6, 2020 at 7:00 AM Stefan Hajnoczi wrote: > > > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > > > index a00b854736..39aec42dae 100644

Re: [PATCH v4 7/7] Makefile: Ship the generic platform bios images for RISC-V

2020-07-10 Thread Alistair Francis
On Thu, Jul 9, 2020 at 10:11 PM Bin Meng wrote: > > From: Bin Meng > > Update the install blob list to include the generic platform > fw_dynamic bios images. > > Signed-off-by: Bin Meng You didn't address the comments in v3. Thinking about this more though it looks like we currently don't

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Langston
@Dimitry To confirm that this is really the same issue (and not an unrelated crash in the same function), could you post: 1. the ELF headers ("readelf -h"), 2. the program headers ("readelf -l"), and 3. the output (the AUX VECTOR section) from this GDB script (suitably modified for your

Re: [RFC 01/65] target/riscv: fix rsub gvec tcg_assert_listed_vecop assertion

2020-07-10 Thread Alistair Francis
On Fri, Jul 10, 2020 at 9:13 AM Richard Henderson wrote: > > On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang > > > > gvec should provide vecop_list to avoid: > > "tcg_tcg_assert_listed_vecop: code should not be reached bug" assertion. > > > > Signed-off-by: Frank Chang >

Re: [PATCH] disas/riscv: Fix incorrect disassembly for `imm20` operand.

2020-07-10 Thread Richard Henderson
On 7/7/20 8:43 AM, Wei Wu wrote: > static int32_t operand_imm20(rv_inst inst) > { > -return (((int64_t)inst << 32) >> 44) << 12; > +return ((int64_t)inst << 32) >> 44; > } There's no point in casting to int64_t, for one. But it would be better to use sextract32(inst, 12, 20). r~

Re: [PULL 0/1] qemu-openbios queue 20200707

2020-07-10 Thread Peter Maydell
On Tue, 7 Jul 2020 at 22:08, Mark Cave-Ayland wrote: > > The following changes since commit eb2c66b10efd2b914b56b20ae90655914310c925: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-07-06' > into staging (2020-07-07 19:47:26 +0100) > > are available in the Git

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
> runs just fine on top of the Linux kernel in QEMU full-system emulation, but crashes before main in user-mode emulation So it seems system vs user-mode is not the issue here, probably it is related to gdb mode in user-mode qemu. -- You received this bug notification because you are a member

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
@langston0 Thanks for detailed explanation, got the same problem for qemu-s390. The way to reproduce (linux kernel >= 4.8, for example: Ubuntu 18.04): # Register qemu binfmt_misc handlers $ docker run --rm --privileged multiarch/qemu-user-static --reset -p yes $ cat Dockerfile.s390x FROM

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2020-07-10 Thread Dmitry
BTW, before "sudo bash -c "echo -1 > /proc/sys/fs/binfmt_misc/qemu- s390x" njs-s390 also works on the host: $ ./njs-s390 -c 'console.log("hello")' hello $ file njs-s390 njs-s390: ELF 64-bit MSB executable, IBM S/390, version 1 (GNU/Linux), statically linked,

Re: [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions

2020-07-10 Thread Richard Henderson
On 7/7/20 9:58 AM, Philippe Mathieu-Daudé wrote: > I couldn't run Sarah's test suite on Fedora 30: > > /usr/lib/gcc/avr/9.2.0/../../../../avr/bin/ld: cannot find > crtatmega2560.o: No such file or directory > /usr/lib/gcc/avr/9.2.0/../../../../avr/bin/ld: cannot find -lm >

[PATCH] .cirrus.yml: add bash to the brew packages

2020-07-10 Thread Alex Bennée
Like the sed we include earlier we want something more recent for iotests to work. Fixes: 57ee95ed Cc: Max Reitz Signed-off-by: Alex Bennée --- .cirrus.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 69342ae031bc..f287d23c5b9b 100644

Re: [RFC 57/65] target/riscv: rvv-0.9: floating-point min/max instructions

2020-07-10 Thread Alex Bennée
frank.ch...@sifive.com writes: > From: Frank Chang > > Signed-off-by: Frank Chang > --- > target/riscv/vector_helper.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c > index

Re: [PATCH v4 11/40] tests/vm: change scripts to use self._config

2020-07-10 Thread Alex Bennée
Alex Bennée writes: > From: Robert Foley > > This change converts existing scripts to using for example self.ROOT_PASS, > to self._config['root_pass']. > We made similar changes for GUEST_USER, and GUEST_PASS. > This allows us also to remove the change in basevm.py, > which adds __getattr__

Re: [RFC 14/65] target/riscv: rvv-0.9: stride load and store instructions

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > # *** Vector loads and stores are encoded within LOADFP/STORE-FP *** > -vlb_v ... 100 . 0 . 000 . 111 @r2_nfvm > -vlh_v ... 100 . 0 . 101 . 111 @r2_nfvm > -vlw_v ... 100 . 0 . 110 .

Re: [RFC 13/65] target/riscv: rvv-0.9: configure instructions

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > -static bool trans_vsetvl(DisasContext *ctx, arg_vsetvl *a) > +static bool trans_vsetvl(DisasContext *s, arg_vsetvl *a) Do not mix this change with anything else. > +rd = tcg_const_i32(a->rd); > +rs1 = tcg_const_i32(a->rs1); Any time

Re: [RFC 12/65] target/riscv: rvv-0.9: update check functions

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > +#define REQUIRE_RVV do {\ > +if (s->mstatus_vs == 0) \ > +return false; \ > +} while (0) You've used this macro already back in patch 7. I guess it should not have been there? Or this bit belongs there, one or the other.

Re: [RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > -static void vext_clear(void *tail, uint32_t cnt, uint32_t tot) > +static void vext_clear(void *tail, uint32_t vta, uint32_t cnt, uint32_t tot) > { > +/* tail element undisturbed */ > +if (vta == 0) { > +return; > +} > + >

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-10 Thread Andrey Shinkevich
On 10.07.2020 18:24, Max Reitz wrote: On 09.07.20 16:52, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead track the node above it, we have to split that "bottom" node

Re: [RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child name

2020-07-10 Thread Eduardo Habkost
On Fri, Jul 10, 2020 at 11:05:29AM +0200, Philippe Mathieu-Daudé wrote: > +Stefan for tracing PoV > > On 7/9/20 9:48 PM, Eduardo Habkost wrote: > > On Fri, Jun 26, 2020 at 04:26:33PM +0200, Philippe Mathieu-Daudé wrote: > >> On 6/26/20 1:00 PM, BALATON Zoltan wrote: > >>> On Fri, 26 Jun 2020,

Re: [RFC 10/65] target/riscv: rvv-0.9: remove MLEN calculations

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > As in RVV 0.9 design, MLEN is hardcoded with value 1 (Section 4.5). > Thus, remove all MLEN related calculations. > > Signed-off-by: Frank Chang > --- > target/riscv/insn_trans/trans_rvv.inc.c | 44 + >

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

2020-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1594396418.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [RFC 09/65] target/riscv: rvv-0.9: add vlenb register

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 228b9bdb5d..871c2ddfa1 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -317,6 +317,7 @@ static void riscv_cpu_reset(DeviceState *dev) > env->mstatus &=

[PATCH 0/2] block: add logging facility for long standing IO requests

2020-07-10 Thread Denis V. Lunev
There are severe delays with IO requests processing if QEMU is running in virtual machine or over software defined storage. Such delays potentially results in unpredictable guest behavior. For example, guests over IDE or SATA drive could remount filesystem read-only if write is performed longer

Re: [RFC 08/65] target/riscv: rvv-0.9: update mstatus_vs by tb_flags

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > Signed-off-by: Frank Chang > --- > target/riscv/cpu.h | 2 ++ > target/riscv/translate.c | 1 + > 2 files changed, 3 insertions(+) This belongs with the second half of the previous

[PATCH 2/2] block: add logging facility for long standing IO requests

2020-07-10 Thread Denis V. Lunev
There are severe delays with IO requests processing if QEMU is running in virtual machine or over software defined storage. Such delays potentially results in unpredictable guest behavior. For example, guests over IDE or SATA drive could remount filesystem read-only if write is performed longer

Re: [RFC 07/65] target/riscv: rvv-0.9: add vector context status

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > Signed-off-by: Frank Chang > --- > target/riscv/cpu.h | 4 ++ > target/riscv/cpu_bits.h | 1 + > target/riscv/cpu_helper.c | 13 ++ >

[PATCH 1/2] block/block-backend: add converter from BlockAcctStats to BlockBackend

2020-07-10 Thread Denis V. Lunev
Right now BlockAcctStats is always reside on BlockBackend. This structure is not used in any other place. Thus we are able to create a converter from one pointer to another. Signed-off-by: Denis V. Lunev CC: Vladimir Sementsov-Ogievskiy CC: Kevin Wolf CC: Max Reitz --- block/block-backend.c

Re: [RFC 07/65] target/riscv: rvv-0.9: add vector context status

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > --- a/target/riscv/cpu_bits.h > +++ b/target/riscv/cpu_bits.h > @@ -376,6 +376,7 @@ > #define MSTATUS_SPP 0x0100 > #define MSTATUS_MPP 0x1800 > #define MSTATUS_FS 0x6000 > +#define MSTATUS_VS

Re: [PATCH 0/2] iotests: More _filter_img_create fixes

2020-07-10 Thread John Snow
On 7/10/20 12:32 PM, Max Reitz wrote: > Hi, > > I’m sorry. > > John, could I ask you to test whether this series fixes the problems > you’re seeing? > This is based on kwolf/block, I see. By the time you return to reading work email, this link will have information for you:

[PULL v2 00/32] AVR port

2020-07-10 Thread Philippe Mathieu-Daudé
'remotes/armbru/tags/pull-error-2020-07-07-v2'= into staging (2020-07-10 14:41:23 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/avr-port-20200710 for you to fetch changes up to 23623ca1f27427d76cc111eb567cac6ce18dab3a: target/avr/disas: Fix store

[PULL v2 09/32] target/avr: Add instruction helpers

2020-07-10 Thread Philippe Mathieu-Daudé
From: Michael Rolnik Add helpers for instructions that need to interact with QEMU. Also, add stubs for unimplemented instructions. Instructions SPM and WDR are left unimplemented because they require emulation of complex peripherals. The implementation of instruction SLEEP is very limited due to

Re: [RFC 06/65] target/riscv: rvv-0.9: add vcsr register

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > +[CSR_VCSR] ={ vs, read_vcsr,write_vcsr > }, As long as you have the vext_spec argument, you need a separate vs_0_9 predicate function, so that this csr is not available to VEXT_VERSION_0_07_1. r~

Re: [PULL 00/10] Modules 20200707 patches

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/7/20 3:42 PM, Gerd Hoffmann wrote: > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-07-06 11:40:10 +0100) > > are available in the Git repository

Re: [PATCH v4 36/40] gitlab: split build-disabled into two phases

2020-07-10 Thread Philippe Mathieu-Daudé
On 7/10/20 6:26 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 7/10/20 4:58 PM, Alex Bennée wrote: >>> >>> Thomas Huth writes: >>> On 01/07/2020 15.56, Alex Bennée wrote: > As we run check-qtest in "SLOW" mode this can timeout so split into > two jobs. >

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-10 Thread Paolo Bonzini
On 10/07/20 18:02, Eduardo Habkost wrote: > On Fri, Jul 10, 2020 at 09:22:42AM +0200, Paolo Bonzini wrote: >> On 09/07/20 21:13, Eduardo Habkost wrote: Doesn't this require intercepting MOV-to-CR3 when the guest is in PAE mode, so that the hypervisor can validate the high bits in the

Re: [PATCH v5 1/4] target/i386: add missing vmx features for several CPU models

2020-07-10 Thread Eduardo Habkost
On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote: > > > On 7/10/2020 6:12 AM, Eduardo Habkost wrote: > > > > I'm very sorry for taking so long to review this. Question > > below: > > > > On Fri, Jun 19, 2020 at 03:31:11PM +0800, Chenyi Qiang wrote: > > > Add some missing VMX

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

2020-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1594396418.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 2/2] iotests: Set LC_ALL=C for sort

2020-07-10 Thread Eric Blake
On 7/10/20 11:32 AM, Max Reitz wrote: Otherwise the result is basically unpredictable. (Note that the precise environment variable to control sorting order is LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the sorting order to be messed up if LC_ALL is set in the environment.)

[PULL 1/1] 9p: null terminate fs driver options list

2020-07-10 Thread Greg Kurz
From: Prasad J Pandit NULL terminate fs driver options' list, validate_opt() looks for a null entry to terminate the loop. Fixes: aee7f3ecd8b7 ("fsdev: Error out when unsupported option is passed") Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang Message-Id:

[PATCH] fixup! qemu-img: Deprecate use of -b without -F

2020-07-10 Thread Eric Blake
Port to BSD truncate. Signed-off-by: Eric Blake --- tests/qemu-iotests/114 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/114 b/tests/qemu-iotests/114 index 143683381334..d0609c499388 100755 --- a/tests/qemu-iotests/114 +++ b/tests/qemu-iotests/114 @@

Re: [RFC 05/65] target/riscv: remove vsll.vi, vsrl.vi, vsra.vi insns from using gvec

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > vsll.vi, vsrl.vi, vsra.vi cannot use shli gvec as it requires the > shift immediate value to be within the range: [0.. SEW bits]. > Otherwise, it will hit the assertion: > tcg_debug_assert(shift >= 0 && shift < (8 <<

Re: [PATCH 1/2] iotests: Drop readarray from _do_filter_img_create

2020-07-10 Thread Eric Blake
On 7/10/20 11:32 AM, Max Reitz wrote: Some systems where we run tests on do not have a 4.x bash, so they do not have readarray. While it looked a bit nicer than messing with `head` and `tail`, we do not really need it, so we might as well not use it. Reported-by: Claudio Fontana

[PULL 0/1] 9p fixes for 5.1 2020-07-10

2020-07-10 Thread Greg Kurz
The following changes since commit b6d7e9b66f59ca6ebc6e9b830cd5e7bf849d31cf: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2020-07-10 09:01:28 +0100) are available in the Git repository at: https://github.com/gkurz/qemu.git tags/9p-fix-2020-07-10

[PATCH 0/2] iotests: More _filter_img_create fixes

2020-07-10 Thread Max Reitz
Hi, I’m sorry. John, could I ask you to test whether this series fixes the problems you’re seeing? Max Reitz (2): iotests: Drop readarray from _do_filter_img_create iotests: Set LC_ALL=C for sort tests/qemu-iotests/common.filter | 12 ++-- 1 file changed, 6 insertions(+), 6

[RFC 3/3] x68: acpi: trigger SMI before scanning for hotplugged CPUs

2020-07-10 Thread Igor Mammedov
In case firmware has negotiated CPU hotplug SMI feature, generate AML to describe SMI IO port region and send SMI to firmware on each CPU hotplug SCI. It might be not really usable, but should serve as a starting point to discuss how better to deal with split hotplug sequence during hot-add ( ex

Re: [PATCH v4 36/40] gitlab: split build-disabled into two phases

2020-07-10 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/10/20 4:58 PM, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> On 01/07/2020 15.56, Alex Bennée wrote: As we run check-qtest in "SLOW" mode this can timeout so split into two jobs. Signed-off-by: Alex Bennée Reviewed-by:

Re: [RFC 04/65] target/riscv: fix vill bit index in vtype register

2020-07-10 Thread Richard Henderson
On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > vill bit is at vtype[XLEN-1]. > > Signed-off-by: Frank Chang > --- > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson Alistair, this one should be queued for

[RFC 1/3] x86: lpc9: let firmware negotiate CPU hotplug SMI feature

2020-07-10 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hotplug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base. Using the negotiated feature, follow up patches will insert SMI upcall into AML code, to make sure that firmware

[PATCH v11 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-07-10 Thread Alberto Garcia
Now that the implementation of subclusters is complete we can finally add the necessary options to create and read images with this feature, which we call "extended L2 entries". Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- qapi/block-core.json |

[PATCH 2/2] iotests: Set LC_ALL=C for sort

2020-07-10 Thread Max Reitz
Otherwise the result is basically unpredictable. (Note that the precise environment variable to control sorting order is LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the sorting order to be messed up if LC_ALL is set in the environment.) Reported-by: John Snow Signed-off-by:

Re: [PULL v2] Block layer patches

2020-07-10 Thread Eric Blake
On 7/9/20 7:17 AM, Kevin Wolf wrote: The following changes since commit 8796c64ecdfd34be394ea277a53df0c76996: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20200706-pull-request' into staging (2020-07-08 16:33:59 +0100) are available in the Git repository at:

[PATCH 1/2] iotests: Drop readarray from _do_filter_img_create

2020-07-10 Thread Max Reitz
Some systems where we run tests on do not have a 4.x bash, so they do not have readarray. While it looked a bit nicer than messing with `head` and `tail`, we do not really need it, so we might as well not use it. Reported-by: Claudio Fontana Signed-off-by: Max Reitz ---

[RFC 2/3] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use

2020-07-10 Thread Igor Mammedov
There were reports of guest crash on CPU hotplug, when using q35 machine type and QVMF with Secure Boot, due to hotplugged CPU trying to process SMI at default SMI handler location without it being relocated by firmware first. Fix it by refusing hotplug if firmware hasn't negotiatiad CPU hotplug

[RFC 0/3] x86: fix cpu hotplug with secure boot

2020-07-10 Thread Igor Mammedov
CPU hotplug with Secure Boot was not really supported and firmware wasn't aware of hotplugged CPUs (which might lead to guest crashes). During 4.2 we introduced locked SMI handler RAM arrea to make sure that guest OS wasn't able to inject its own SMI handler and OVMF added initial CPU hotplug

  1   2   3   4   >