[PATCH v8 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-22 Thread Joelle van Dyne
A workaround added in early days of 64-bit OSX forced x86_64 if the host machine had 64-bit support. This creates issues when cross- compiling for ARM64. Additionally, the user can always use --cpu=* to manually set the host CPU and therefore this workaround should be removed. Reviewed-by: Peter

[PATCH v8 10/11] darwin: detect CoreAudio for build

2021-01-22 Thread Joelle van Dyne
On iOS there is no CoreAudio, so we should not assume Darwin always has it. Signed-off-by: Joelle van Dyne --- configure | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/configure b/configure index b8ae4609fd..70061e195d 100755 ---

[PATCH v8 08/11] configure: cross compile should use x86_64 cpu_family

2021-01-22 Thread Joelle van Dyne
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index d4588ed892..b8ae4609fd 100755 --- a/configure +++ b/configure @@ -6445,9 +6445,12 @@ if test "$cross_compile" =

[PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v8 03/11] configure: check for sys/disk.h

2021-01-22 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build| 1 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 27110075df..6818d97df5 100644 ---

[PATCH v8 05/11] osdep: build with non-working system() function

2021-01-22 Thread Joelle van Dyne
Build without error on hosts without a working system(). If system() is called, return -1 with ENOSYS. Signed-off-by: Joelle van Dyne --- configure| 20 include/qemu/osdep.h | 12 2 files changed, 32 insertions(+) diff --git a/configure b/configure

[PATCH v8 06/11] darwin: remove redundant dependency declaration

2021-01-22 Thread Joelle van Dyne
Meson will find CoreFoundation, IOKit, and Cocoa as needed. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index de7487a0c7..0fd3f14c5e 100755 --- a/configure +++ b/configure @@ -781,7 +781,6 @@

[PATCH v8 07/11] darwin: fix cross-compiling for Darwin

2021-01-22 Thread Joelle van Dyne
Add objc to the Meson cross file as well as detection of Darwin. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 0fd3f14c5e..d4588ed892 100755 --- a/configure +++ b/configure @@ -6422,6

[PATCH v8 01/11] block: feature detection for host block support

2021-01-22 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v8 00/11] iOS and Apple Silicon host support

2021-01-22 Thread Joelle van Dyne
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported the changes to master, re-wrote a lot of the build script changes for meson, and broke up the patches into more

[PATCH v8 02/11] configure: cross-compiling with empty cross_prefix

2021-01-22 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v8 04/11] slirp: feature detection for smbd

2021-01-22 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 22 +- meson.build | 2 +- net/slirp.c | 16 3 files changed, 30

[Bug 1745895] Re: Unable to migrate vhost-net to virtio-1.0-capable kernel

2021-01-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1745895 Title: Unable to

[Bug 1800156] Re: windows 8.1 loose grab/leave window on windowed

2021-01-22 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1800156 Title: windows

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Yonggang Luo
On Sat, Jan 23, 2021 at 4:44 AM Paolo Bonzini wrote: > > > > Il ven 22 gen 2021, 09:00 罗勇刚(Yonggang Luo) ha scritto: >> >> Hi Paolo, as python and meson are required dependencies to building qemu now, >> can we detecting python/meson at the very begining of configure, >> even before the --help

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Joelle van Dyne
Unfortunately, this doesn't work for iOS, which defines system() but throws a compile time error if you try to call it. -j On Fri, Jan 22, 2021 at 3:17 PM Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 23:12, Peter Maydell wrote: > > > > On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: >

Re: [PATCH] spapr: Adjust firmware path of PCI devices

2021-01-22 Thread Alexey Kardashevskiy
On 23/01/2021 04:01, Greg Kurz wrote: It is currently not possible to perform a strict boot from USB storage: $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ -boot strict=on \ -device qemu-xhci \ -device usb-storage,drive=disk,bootindex=0 \

Re: [PATCH v2 1/1] spapr_caps.c: check user input before warning about TCG only caps

2021-01-22 Thread David Gibson
On Wed, Jan 20, 2021 at 07:54:06AM -0300, Daniel Henrique Barboza wrote: > Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and > cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing > when introducing cap-ccf-assist. > > These warning messages, although benign

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2021-01-22 Thread Brian Norris
Just to follow-up here, since nobody followed up for months... On Mon, Aug 10, 2020 at 2:41 PM Brian Norris wrote: > On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau > wrote: > > On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell > > wrote: > > > On Sat, 8 Aug 2020 at 02:35, Brian Norris > > >

Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-22 Thread Minwoo Im
On 21-01-22 10:42:36, Keith Busch wrote: > On Fri, Jan 22, 2021 at 09:07:34PM +0900, Minwoo Im wrote: > > index b525fca14103..3dedefb8ebba 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -4435,6 +4435,9 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice > > *pci_dev) > >

[PATCH] hvf: Fetch cr4 before evaluating CPUID(1)

2021-01-22 Thread Alexander Graf
The CPUID function 1 has a bit called OSXSAVE which tells user space the status of the CR4.OSXSAVE bit. Our generic CPUID function injects that bit based on the status of CR4. With Hypervisor.framework, we do not synchronize full CPU state often enough for this function to see the CR4 update

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 22:26, Laszlo Ersek wrote: > I'm drifting towards an overhaul of coroutine-sigaltstack, based on my > personal understanding of POSIX, but given that I can absolutely not > *test* coroutine-sigaltstack on the platforms where it actually matters, > an "overhaul" by me would be

Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

2021-01-22 Thread Rebecca Cran
On 1/22/21 2:03 PM, Richard Henderson wrote: On 1/21/21 6:45 PM, Rebecca Cran wrote: cpsr_write(env, spsr, mask, CPSRWriteRaw); -if (!arm_singlestep_active(env)) { -env->uncached_cpsr &= ~PSTATE_SS; -} +env->pstate &= ~PSTATE_SS; Why are you

Re: [PATCH v2 3/3] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU

2021-01-22 Thread Rebecca Cran
On 1/22/21 2:06 PM, Richard Henderson wrote: On 1/21/21 6:45 PM, Rebecca Cran wrote: Enable FEAT_DIT for the "max" AARCH64 CPU. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 5 + 1 file changed, 5 insertions(+) There is also a 32-bit "max" cpu

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/22/21 11:14, Peter Maydell wrote: > On Fri, 22 Jan 2021 at 08:50, Max Reitz wrote: >> >> On 20.01.21 18:25, Laszlo Ersek wrote: >> >> [...] >> >>> A simple grep for SIGUSR2 seems to indicate that SIGUSR2 is not used by >>> system emulation for anything else, in practice. Is it possible to

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64   -display none   -hda archlinux.qcow2   -m 4G   -netdev user,id=n1,hostfwd=tcp::-:22   -device virtio-net-pci,netdev=n1 --> THIS WORKS - meaning I can ssh into the vm via port qemu-system-x86_64   -display none   -hda

Re: [PATCHv9 0/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 21:52, Maxim Uvarov wrote: > > v9: - cosmetic changes (move if from patch2 to patch3, rename function name >and define). > v8: - use gpio 0 and 1, align dtb with kernel gpio-restart, gpio-poweroff, >change define names, trigger on upper front. (Peter

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: - qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev - user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> - WORKS - meaning I can ssh into the vm via port + qemu-system-x86_64 + -display none + -hda archlinux.qcow2 + -m 4G

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> WORKS - meaning I can ssh into the vm via port qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 23:12, Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > > > Build without error on hosts without a working system(). An assertion > > will trigger if system() is called. > > > > Signed-off-by: Joelle van Dyne > > configure| 19

Re: [PATCH v7 03/11] configure: check for sys/disk.h

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > configure | 9 + > block.c| 2 +- > block/file-posix.c | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > >

Re: [PATCH v7 04/11] slirp: feature detection for smbd

2021-01-22 Thread Joelle van Dyne
On Fri, Jan 22, 2021 at 2:49 PM Peter Maydell wrote: > > On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > > > Replace Windows specific macro with a more generic feature detection > > macro. Allows slirp smb feature to be disabled manually as well. > > > > Signed-off-by: Joelle van Dyne

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne wrote: > > Build without error on hosts without a working system(). An assertion > will trigger if system() is called. > > Signed-off-by: Joelle van Dyne configure| 19 +++ Can we do the "does system() exist?" check in

[Bug 1912857] Re: virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
** Description changed: qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> WORKS - meaning I can ssh into the vm via port qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev

Re: [PATCH v7 04/11] slirp: feature detection for smbd

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- > +if test "$slirp_smbd" = "yes" ; then > + echo

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:41 PM, Philippe Mathieu-Daudé wrote: > On 1/22/21 11:34 PM, Philippe Mathieu-Daudé wrote: >> On 1/20/21 4:29 AM, Taylor Simpson wrote: >>> Add file to default-configs >>> Add hexagon to meson.build >>> Add hexagon to target/meson.build >>> Add target/hexagon/meson.build >>> Change

Re: [PATCH v7 06/11] darwin: remove redundant dependency declaration

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:20, Joelle van Dyne wrote: > > Meson will find CoreFoundation, IOKit, and Cocoa as needed. > > Signed-off-by: Joelle van Dyne > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index 82ce28c660..4c485dd962 100755 > ---

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 11:34 PM, Philippe Mathieu-Daudé wrote: > On 1/20/21 4:29 AM, Taylor Simpson wrote: >> Add file to default-configs >> Add hexagon to meson.build >> Add hexagon to target/meson.build >> Add target/hexagon/meson.build >> Change scripts/qemu-binfmt-conf.sh >> >> We can build a

Re: [PATCH v7 07/11] darwin: fix cross-compiling for Darwin

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:18, Joelle van Dyne wrote: > > Add objc to the Meson cross file as well as detection of Darwin. > > Signed-off-by: Joelle van Dyne Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:16, Joelle van Dyne wrote: > > A workaround added in early days of 64-bit OSX forced x86_64 if the > host machine had 64-bit support. This creates issues when cross- > compiling for ARM64. Additionally, the user can always use --cpu=* to > manually set the host CPU and

Re: [PATCH v7 34/35] Hexagon build infrastructure

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:29 AM, Taylor Simpson wrote: > Add file to default-configs > Add hexagon to meson.build > Add hexagon to target/meson.build > Add target/hexagon/meson.build > Change scripts/qemu-binfmt-conf.sh > > We can build a hexagon-linux-user target and run programs on the Hexagon > scalar

RE: [PATCH v7 12/35] Hexagon (target/hexagon) instruction attributes

2021-01-22 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 11:54 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

Re: [PATCH] target/mips: fetch code with translator_ld

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/18/21 6:40 PM, Richard Henderson wrote: > On 1/16/21 8:13 AM, Philippe Mathieu-Daudé wrote: >> +++ b/target/mips/tlb_helper.c >> @@ -21,7 +21,7 @@ >> #include "cpu.h" >> #include "internal.h" >> #include "exec/exec-all.h" >> -#include "exec/cpu_ldst.h" >> +#include "exec/translator.h" >>

RE: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-01-22 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 12:09 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

[PATCHv9 1/3] hw: gpio: implement gpio-pwr driver for qemu reset/poweroff

2021-01-22 Thread Maxim Uvarov
Implement gpio-pwr driver to allow reboot and poweroff machine. This is simple driver with just 2 gpios lines. Current use case is to reboot and poweroff virt machine in secure mode. Secure pl066 gpio chip is needed for that. Signed-off-by: Maxim Uvarov Reviewed-by: Hao Wu Reviewed-by: Peter

[PATCHv9 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Maxim Uvarov
Add secure pl061 for reset/power down machine from the secure world (Arm Trusted Firmware). Connect it with gpio-pwr driver. Signed-off-by: Maxim Uvarov Reviewed-by: Andrew Jones --- hw/arm/Kconfig| 1 + hw/arm/virt.c | 56 ++-

[Bug 1912857] [NEW] virtio-serial blocks hostfwd ssh on windows 10 host

2021-01-22 Thread Ven Karri
Public bug reported: qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev user,id=n1,hostfwd=tcp::-:22 -device virtio-net-pci,netdev=n1 --> WORKS - meaning I can ssh into the vm via port qemu-system-x86_64 -display none -hda archlinux.qcow2 -m 4G -netdev

[PATCHv9 2/3] arm-virt: refactor gpios creation

2021-01-22 Thread Maxim Uvarov
No functional change. Just refactor code to better support secure and normal world gpios. Signed-off-by: Maxim Uvarov Reviewed-by: Andrew Jones --- hw/arm/virt.c | 57 --- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git

[PATCHv9 0/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Maxim Uvarov
v9: - cosmetic changes (move if from patch2 to patch3, rename function name and define). v8: - use gpio 0 and 1, align dtb with kernel gpio-restart, gpio-poweroff, change define names, trigger on upper front. (Peter Maydell). v7: - same as v6, but resplit patches: patch 2 no

RE: [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers

2021-01-22 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Friday, January 22, 2021 2:30 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; > laur...@vivier.eu; a...@rev.ng; Brian Cain >

Re: [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/22/21 9:30 PM, Philippe Mathieu-Daudé wrote: > Hi Taylor, > > On 1/20/21 4:28 AM, Taylor Simpson wrote: >> The majority of helpers are generated. Define the helper functions needed >> then include the generated file >> >> Signed-off-by: Taylor Simpson >> --- >> target/hexagon/helper.h

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/22/21 22:34, Laszlo Ersek wrote: > On 01/22/21 21:38, Laszlo Ersek wrote: >> The behavior of "savemask=0" is a platform trait that platforms are not >> required to document (the behavior is unspecified, not >> implementation-defined), so it really boils down to where this code >> actually

Re: [PATCH 19/25] hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 20:48, Luc Michel wrote: > > On 19:06 Thu 21 Jan , Peter Maydell wrote: > > Switch the CMSDK APB dualtimer device over to using its Clock input; > > the pclk-frq property is now ignored. > > > > Signed-off-by: Peter Maydell > > --- > > hw/timer/cmsdk-apb-dualtimer.c |

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/22/21 21:38, Laszlo Ersek wrote: > On 01/21/21 18:24, Paolo Bonzini wrote: >> On 21/01/21 17:44, Peter Maydell wrote: >>> On Thu, 21 Jan 2021 at 16:10, Daniel P. Berrangé >>> wrote: FWIW The libucontext impl is all ASM based and has coverage for all the arches we care about:

Re: [PATCH 3/4] hw/riscv: virt: Limit RAM size in a 32-bit system

2021-01-22 Thread Alistair Francis
On Fri, Jan 22, 2021 at 4:34 AM Bin Meng wrote: > > From: Bin Meng > > RV32 supports 34-bit physical address hence the maximum RAM size > should be limitted. Limit the RAM size to 10 GiB, which leaves > some room for PCIe high mmio space. > > Signed-off-by: Bin Meng Reviewed-by: Alistair

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 19:29, Laszlo Ersek wrote: > OK, I'll try my hand at it; I hope I won't be eating my words. The more I look at it, the less comfortable I am with the existent code. For example, I don't understand why the original commit -- 3194c8ceeba0, "coroutine: adding sigaltstack method (.c

Re: [PATCH 2/4] hw/riscv: virt: Drop the 'link_up' parameter of gpex_pcie_init()

2021-01-22 Thread Alistair Francis
On Fri, Jan 22, 2021 at 4:32 AM Bin Meng wrote: > > From: Bin Meng > > `link_up` is never used in gpex_pcie_init(). Drop it. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/virt.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) >

Re: [PATCH 1/4] hw/riscv: Drop 'struct MemmapEntry'

2021-01-22 Thread Alistair Francis
On Fri, Jan 22, 2021 at 4:31 AM Bin Meng wrote: > > From: Bin Meng > > There is already a MemMapEntry type defined in hwaddr.h. Let's drop > the RISC-V defined `struct MemmapEntry` and use the existing one. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > >

Re: [PATCH v2 2/3] target/arm: Add support for FEAT_DIT, Data Independent Timing

2021-01-22 Thread Richard Henderson
On 1/21/21 6:45 PM, Rebecca Cran wrote: > Add support for FEAT_DIT. DIT (Data Independent Timing) is a required > feature for ARMv8.4. Since virtual machine execution is largely > nondeterministic and TCG is outside of the security domain, it's > implemented as a NOP. > > Signed-off-by: Rebecca

Re: [PATCH v2 3/3] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU

2021-01-22 Thread Richard Henderson
On 1/21/21 6:45 PM, Rebecca Cran wrote: > Enable FEAT_DIT for the "max" AARCH64 CPU. > > Signed-off-by: Rebecca Cran > Reviewed-by: Richard Henderson > --- > target/arm/cpu64.c | 5 + > 1 file changed, 5 insertions(+) There is also a 32-bit "max" cpu in cpu.c. r~

Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

2021-01-22 Thread Richard Henderson
On 1/21/21 6:45 PM, Rebecca Cran wrote: > cpsr has been treated as being the same as spsr, but it isn't. > Since PSTATE_SS isn't in cpsr, remove it and move it into env->pstate. > > Signed-off-by: Rebecca Cran > --- > target/arm/helper-a64.c | 4 +--- > target/arm/helper.c | 4 ++-- >

Re: [PATCH v1 2/3] target/microblaze: use MMUAccessType instead of int in mmu_translate

2021-01-22 Thread Richard Henderson
On 1/21/21 2:18 PM, Joe Komlodi wrote: > Using MMUAccessType makes it more clear what the variable's use is. > No functional change. > > Signed-off-by: Joe Komlodi > --- > target/microblaze/mmu.c | 2 +- > target/microblaze/mmu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 20/25] hw/watchdog/cmsdk-apb-watchdog: Convert to use Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Switch the CMSDK APB watchdog device over to using its Clock input; > the wdogclk_frq property is now ignored. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/watchdog/cmsdk-apb-watchdog.c | 18 ++ > 1 file

Re: [PATCH 19/25] hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Switch the CMSDK APB dualtimer device over to using its Clock input; > the pclk-frq property is now ignored. > > Signed-off-by: Peter Maydell > --- > hw/timer/cmsdk-apb-dualtimer.c | 42 ++ > 1 file changed, 37

[PATCH v2 11/12] qapi/meson: Restrict system-mode specific modules

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/meson.build | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/meson.build b/qapi/meson.build index b301a46f04a..7aca8d50484 100644 --- a/qapi/meson.build +++ b/qapi/meson.build @@ -18,8 +18,6 @@ endif

[PATCH v2 08/12] meson: Restrict emulation code

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Richard Henderson --- meson.build | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index 396ea3aa19b..b5afa2923b3 100644 --- a/meson.build +++ b/meson.build @@ -1809,16 +1809,18 @@ qemuutil

[PATCH v2 06/12] meson: Merge trace_events_subdirs array

2021-01-22 Thread Philippe Mathieu-Daudé
The trace_events_subdirs array is split in two different locations, merge it as one. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi --- meson.build | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index

[PATCH v2 07/12] meson: Restrict some trace event directories to user/system emulation

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefan Hajnoczi --- meson.build | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/meson.build b/meson.build index c43538a1523..396ea3aa19b 100644 --- a/meson.build +++ b/meson.build @@ -1683,22

[PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- pc-bios/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/meson.build b/pc-bios/meson.build index fab323af84e..68705d405ce 100644 --- a/pc-bios/meson.build +++ b/pc-bios/meson.build @@ -16,6 +16,7 @@ foreach f : fds

[PATCH v2 05/12] meson: Restrict block subsystem processing

2021-01-22 Thread Philippe Mathieu-Daudé
Avoid generating module_block.h and block-gen.c if we are not going to use them. Signed-off-by: Philippe Mathieu-Daudé --- Cc: qemu-bl...@nongnu.org --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 61cbb89cd44..181f8795f5a

[PATCH v2 01/12] configure: Only check for audio drivers if system-mode is selected

2021-01-22 Thread Philippe Mathieu-Daudé
Acked-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daudé --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 6f6a319c2f6..a4476d457e0 100755 --- a/configure +++ b/configure @@ -2324,6 +2324,12 @@ if test -z "$want_tools"; then fi fi

[PATCH v2 12/12] qapi/meson: Restrict UI module to system emulation and tools

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Gerd Hoffmann --- qapi/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/meson.build b/qapi/meson.build index 7aca8d50484..0652569bc43 100644 --- a/qapi/meson.build +++ b/qapi/meson.build @@ -43,7 +43,6 @@

[PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation

2021-01-22 Thread Philippe Mathieu-Daudé
Beside a CPU device, user-mode emulation doesn't access anything else from qdev subsystem. Tools don't need anything from qdev. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier Cc: Eduardo Habkost --- stubs/qdev.c | 23 +++ MAINTAINERS | 1 +

[PATCH v2 00/12] buildsys: Do not build various objects if not necessary

2021-01-22 Thread Philippe Mathieu-Daudé
In this series we deselect a bunch of features when they not required, so less objects are built. While this reduce pressure on CI and slow systems, this is particularly helpful for developers regularly testing multiple build configurations. All CI tests pass:

[PATCH v2 10/12] qapi/meson: Remove QMP from user-mode emulation

2021-01-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- qapi/meson.build | 10 +++--- tests/meson.build | 7 ++- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/qapi/meson.build b/qapi/meson.build index 2839871b478..b301a46f04a 100644 --- a/qapi/meson.build

[PATCH v2 04/12] meson: Do not build optional libraries by default

2021-01-22 Thread Philippe Mathieu-Daudé
The following libraries will be selected if a feature requires it: - capstone - fdt - SLiRP Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- Cc: Marc-André Lureau Cc: David Gibson Cc: Samuel Thibault --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 02/12] tests/meson: Only build softfloat objects if TCG is selected

2021-01-22 Thread Philippe Mathieu-Daudé
Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- Cc: Richard Henderson Cc: Alex Bennée Cc: Emilio G. Cota --- tests/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 29ebaba48d2..6f1ff926d26

Re: [PATCH 8/8] configure: automatically parse command line for meson -D options

2021-01-22 Thread Paolo Bonzini
Il ven 22 gen 2021, 09:00 罗勇刚(Yonggang Luo) ha scritto: > Hi Paolo, as python and meson are required dependencies to building qemu > now, > can we detecting python/meson at the very begining of configure, > even before the --help parameter. > We could and I did it in the first version. However

Re: Thread safety of coroutine-sigaltstack

2021-01-22 Thread Laszlo Ersek
On 01/21/21 18:24, Paolo Bonzini wrote: > On 21/01/21 17:44, Peter Maydell wrote: >> On Thu, 21 Jan 2021 at 16:10, Daniel P. Berrangé >> wrote: >>> FWIW The libucontext impl is all ASM based and has coverage for all the >>> arches we care about: >>> >>>     https://github.com/kaniini/libucontext

getting the console output for s390 cdrom-test?

2021-01-22 Thread Peter Maydell
Hi; I've been looking at why the s390 cdrom test has an intermittent failure on my aarch64 box. Looking at some TCG debug log output I think what is happening is that sometimes execution diverges from a successful run inside virtio_scsi_setup() and we end up failing a vs_assert(), which triggers a

Re: [PATCH 18/25] hw/timer/cmsdk-apb-timer: Convert to use Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Switch the CMSDK APB timer device over to using its Clock input; the > pclk-frq property is now ignored. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/timer/cmsdk-apb-timer.c | 18 ++ > 1 file changed, 14

Re: [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers

2021-01-22 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/20/21 4:28 AM, Taylor Simpson wrote: > The majority of helpers are generated. Define the helper functions needed > then include the generated file > > Signed-off-by: Taylor Simpson > --- > target/hexagon/helper.h| 85 > target/hexagon/op_helper.c | 1066 >

Re: [PATCH 17/25] hw/arm/stellaris: Create Clock input for watchdog

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create and connect the Clock input for the watchdog device on the > Stellaris boards. Because the Stellaris boards model the ability to > change the clock rate by programming PLL registers, we have to create > an output Clock on the ssys_state

Re: [PATCH 16/25] hw/arm/stellaris: Convert SSYS to QOM device

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Convert the SSYS code in the Stellaris boards (which encapsulates the > system registers) to a proper QOM device. This will provide us with > somewhere to put the output Clock whose frequency depends on the > setting of the PLL configuration

Re: [PATCH] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-22 Thread Peter Xu
On Fri, Jan 22, 2021 at 09:08:51PM +0100, Eugenio Pérez wrote: > Cannot destroy address spaces of IOMMU-aware virtio devices without it, > since they can contain memory listeners. > > Fixes: c611c76417f ("virtio: add MemoryListener to cache ring translations") > Buglink:

[PATCH v7 08/11] configure: cross compile should use x86_64 cpu_family

2021-01-22 Thread Joelle van Dyne
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 7e5ec7a5a1..f487be3cfe 100755 --- a/configure +++ b/configure @@ -6466,9 +6466,12 @@ if test "$cross_compile" =

[PATCH v7 10/11] darwin: detect CoreAudio for build

2021-01-22 Thread Joelle van Dyne
On iOS there is no CoreAudio, so we should not assume Darwin always has it. Signed-off-by: Joelle van Dyne --- configure | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f487be3cfe..fb671258e6 100755 ---

[PATCH v7 06/11] darwin: remove redundant dependency declaration

2021-01-22 Thread Joelle van Dyne
Meson will find CoreFoundation, IOKit, and Cocoa as needed. Signed-off-by: Joelle van Dyne --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 82ce28c660..4c485dd962 100755 --- a/configure +++ b/configure @@ -781,7 +781,6 @@ Darwin) fi

[PATCH v7 07/11] darwin: fix cross-compiling for Darwin

2021-01-22 Thread Joelle van Dyne
Add objc to the Meson cross file as well as detection of Darwin. Signed-off-by: Joelle van Dyne --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 4c485dd962..7e5ec7a5a1 100755 --- a/configure +++ b/configure @@ -6443,6 +6443,7 @@ echo

[PATCH v7 02/11] configure: cross-compiling with empty cross_prefix

2021-01-22 Thread Joelle van Dyne
The iOS toolchain does not use the host prefix naming convention. So we need to enable cross-compile options while allowing the PREFIX to be blank. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- configure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v7 11/11] darwin: remove 64-bit build detection on 32-bit OS

2021-01-22 Thread Joelle van Dyne
A workaround added in early days of 64-bit OSX forced x86_64 if the host machine had 64-bit support. This creates issues when cross- compiling for ARM64. Additionally, the user can always use --cpu=* to manually set the host CPU and therefore this workaround should be removed. Signed-off-by:

[PATCH v7 04/11] slirp: feature detection for smbd

2021-01-22 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 22 +- meson.build | 2 +- net/slirp.c | 16 3 files changed, 30

[PATCH v7 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v7 01/11] block: feature detection for host block support

2021-01-22 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- configure| 13 + meson.build | 2 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33

[PATCH v7 00/11] iOS and Apple Silicon host support

2021-01-22 Thread Joelle van Dyne
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported the changes to master, re-wrote a lot of the build script changes for meson, and broke up the patches into more

[PATCH v7 05/11] osdep: build with non-working system() function

2021-01-22 Thread Joelle van Dyne
Build without error on hosts without a working system(). An assertion will trigger if system() is called. Signed-off-by: Joelle van Dyne --- configure| 19 +++ include/qemu/osdep.h | 11 +++ 2 files changed, 30 insertions(+) diff --git a/configure

[PATCH v7 03/11] configure: check for sys/disk.h

2021-01-22 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- configure | 9 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 32be5d225d..951de427bb 100755 ---

[Bug 1912846] [NEW] Assertion hit on hot-unplugging virtio iommu enabled device

2021-01-22 Thread Eugenio Pérez
Public bug reported: >From commit ("2d24a646 device-core: use RCU for list of children of a bus") an assertion is hit when removing a iommu aware virtio device, since as->listeners are not properly removed. To reproduce: /home/qemu/build/x86_64-softmmu/qemu-system-x86_64 -qmp

[PATCH] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-22 Thread Eugenio Pérez
Cannot destroy address spaces of IOMMU-aware virtio devices without it, since they can contain memory listeners. Fixes: c611c76417f ("virtio: add MemoryListener to cache ring translations") Buglink: https://bugs.launchpad.net/qemu/+bug/1912846 Signed-off-by: Eugenio Pérez --- hw/virtio/virtio.c

Re: [PATCH 15/25] hw/arm/musca: Create and connect ARMSSE Clocks

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create and connect the two clocks needed by the ARMSSE. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/arm/musca.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/hw/arm/musca.c b/hw/arm/musca.c >

  1   2   3   4   >