Re: USB pass through into Mac OS 9.x with qemu-system-ppc

2021-02-16 Thread Gerd Hoffmann
Hi, > Thanks for the explanation. I've been successful in passing through an > USB 2.0 stick into Mac OS 9.x when connected to a real USB 1.1 hub in > a old Apple keyboard. Ah, neat trick to force the device into usb1 mode. take care, Gerd

Re: [PATCH 1/5] qcow2-bitmap: make bytes_covered_by_bitmap_cluster() public

2021-02-16 Thread Vladimir Sementsov-Ogievskiy
16.02.2021 19:45, Vladimir Sementsov-Ogievskiy wrote: Rename bytes_covered_by_bitmap_cluster() to bdrv_dirty_bitmap_serialization_coverage() and make it public. It is needed as we are going to make load_bitmap_data() public in the next commit. Not we are not. So the last sentence should be

Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported

2021-02-16 Thread Michal Privoznik
On 2/17/21 12:07 AM, John Snow wrote: On 2/16/21 5:23 PM, Eduardo Habkost wrote: On Tue, Jan 26, 2021 at 08:48:25AM +0100, Michal Privoznik wrote: When management applications (like Libvirt) want to check whether memory-backend-file.pmem is supported they can list object properties using

Re: USB pass through into Mac OS 9.x with qemu-system-ppc

2021-02-16 Thread Gerd Hoffmann
> Hi Gerd, > > Thanks for looking into this. It looks to me that the usb storage > device nicely reports endpoints 1 and 2 when asked, but that the host > only ever communicates with endpoint 1. EP 1 is host -> device. EP 2 is device -> host. So the host sends requests but the device never

Re: USB pass through into Mac OS 9.x with qemu-system-ppc

2021-02-16 Thread Howard Spoelstra
On Tue, Feb 16, 2021 at 4:42 PM Howard Spoelstra wrote: > > On Tue, Feb 16, 2021 at 3:48 PM Gerd Hoffmann wrote: > > > > Hi, > > > > > Please find another pcap file attached. This one stems from an attempt > > > to pass through a midi device when running qemu-system-ppc with Mac OS > > > 9.2

Re: [PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210217070944.2371327-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210217070944.2371327-1-marcandre.lur...@redhat.com Subject: [PATCH v2] qga:

[PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-16 Thread marcandre . lureau
From: Marc-André Lureau qmp_disable_command() now takes an enum for the reason, to be able to give more explicit error messages. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1928806 Signed-off-by: Marc-André Lureau --- v2: - replace string with an enum for disabling reason - remove

Re: [PATCH] fuzz-test: remove unneccessary debugging flags

2021-02-16 Thread Thomas Huth
On 16/02/2021 19.13, Alexander Bulekov wrote: These flags cause the output to look strange for 'make check', and they aren't needed to reproduce bugs, if they reappear. Suggested-by: Peter Maydell Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz-test.c | 3 +-- 1 file changed, 1

Re: [PATCH v4 18/24] python/qemu: add qemu package itself to pipenv

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:50PM -0500, John Snow wrote: > This adds the python qemu packages themselves to the pipenv manifest. > 'pipenv sync' will create a virtual environment sufficient to use the SDK. > 'pipenv sync --dev' will create a virtual environment sufficient to use > and test the

Re: [PATCH v4 17/24] python/qemu: add isort to pipenv

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:49PM -0500, John Snow wrote: > isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret > certain "from ..." clauses that are not related to imports. > > Require 5.0.5 or greater. > > isort can be run with 'isort -c qemu' from the python root. > >

Re: [PATCH v4 16/24] python: move .isort.cfg into setup.cfg

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:48PM -0500, John Snow wrote: > Signed-off-by: John Snow > --- > python/.isort.cfg | 7 --- > python/setup.cfg | 8 > 2 files changed, 8 insertions(+), 7 deletions(-) > delete mode 100644 python/.isort.cfg > Reviewed-by: Cleber Rosa signature.asc

Re: [PATCH v4 15/24] python: add mypy to pipenv

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:47PM -0500, John Snow wrote: > 0.730 appears to be about the oldest version that works with the > features we want, including nice human readable output (to make sure > iotest 297 passes), and type-parameterized Popen generics. > > 0.770, however, supports adding

Re: [PATCH] pc-bios/s390-ccw: Use memory barriers in virtio code

2021-02-16 Thread Richard Henderson
On 2/16/21 8:15 AM, Thomas Huth wrote: > On 16/02/2021 15.40, Halil Pasic wrote: >> On Tue, 16 Feb 2021 12:00:56 +0100 >> Thomas Huth wrote: >> >>> According to the virtio specification, a memory barrier should be >>> used before incrementing the idx field in the "available" ring. >>> So far, we

Re: [PATCH v4 13/24] python: Add flake8 to pipenv

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:45PM -0500, John Snow wrote: > flake8 3.5.x does not support the --extend-ignore syntax used in the > .flake8 file to gracefully extend default ignores, so 3.6.x is our > minimum requirement. There is no known upper bound. > > flake8 can be run from the python/

Re: [PATCH v4 12/24] python: move flake8 config to setup.cfg

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:44PM -0500, John Snow wrote: > Update the comment concerning the flake8 exception to match commit > 42c0dd12, whose commit message stated: > > A note on the flake8 exception: flake8 will warn on *any* bare except, > but pylint's is context-aware and will suppress the

Re: [PATCH v4 11/24] python: add pylint to pipenv

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:43PM -0500, John Snow wrote: > We are specifying >= pylint 2.6.x for two reasons: > > 1. For setup.cfg support, added in pylint 2.5.x > 2. To clarify that we are using a version that has incompatibly dropped > bad-whitespace checks. > > Signed-off-by: John Snow >

Re: [PATCH v2 1/3] target/arm: Add support for FEAT_SSBS, Speculative Store Bypass Safe

2021-02-16 Thread Richard Henderson
On 2/16/21 2:45 PM, Rebecca Cran wrote: > Add support for FEAT_SSBS. SSBS (Speculative Store Bypass Safe) is an > optional feature in ARMv8.0, and mandatory in ARMv8.5. > > Signed-off-by: Rebecca Cran > --- > target/arm/cpu.h | 15 +++- > target/arm/helper.c| 37

Re: [PATCH v4 09/24] python: add pylint import exceptions

2021-02-16 Thread John Snow
On 2/16/21 10:07 PM, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote: Pylint 2.5.x and 2.6.x have regressions that make import checking inconsistent, see: https://github.com/PyCQA/pylint/issues/3609 https://github.com/PyCQA/pylint/issues/3624

Re: [PATCH v4 08/24] python: Add pipenv support

2021-02-16 Thread John Snow
On 2/16/21 9:59 PM, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote: pipenv is a tool used for managing virtual environments with pinned, explicit dependencies. It is used for precisely recreating python virtual environments. pipenv uses two files to do this: (1)

Re: [PATCH v4 05/24] python: add qemu package installer

2021-02-16 Thread John Snow
On 2/16/21 9:23 PM, Cleber Rosa wrote: On Thu, Feb 11, 2021 at 01:58:37PM -0500, John Snow wrote: Add setup.cfg and setup.py, necessary for installing a package via pip. Add a rst document explaining the basics of what this package is Nitpick 1: setup.cfg and setup.py are indeed used by pip,

Re: [PATCH v4 00/24] python: create installable package

2021-02-16 Thread Cleber Rosa
On Mon, Feb 15, 2021 at 04:32:29PM -0500, John Snow wrote: > On 2/11/21 9:52 PM, Cleber Rosa wrote: > > On Thu, Feb 11, 2021 at 01:58:32PM -0500, John Snow wrote: > > > This series factors the python/qemu directory as an installable > > > package. It does not yet actually change the mechanics of

Re: [PATCH v4 10/24] python: move pylintrc into setup.cfg

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:42PM -0500, John Snow wrote: > Delete the empty settings now that it's sharing a home with settings for > other tools. > > pylint can now be run from this folder as "pylint qemu". > > Signed-off-by: John Snow > --- > python/qemu/machine/pylintrc | 58

Re: [PATCH v4 09/24] python: add pylint import exceptions

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:41PM -0500, John Snow wrote: > Pylint 2.5.x and 2.6.x have regressions that make import checking > inconsistent, see: > > https://github.com/PyCQA/pylint/issues/3609 > https://github.com/PyCQA/pylint/issues/3624 > https://github.com/PyCQA/pylint/issues/3651 > >

Re: [PATCH v4 08/24] python: Add pipenv support

2021-02-16 Thread Cleber Rosa
On Tue, Feb 16, 2021 at 09:59:47PM -0500, Cleber Rosa wrote: > On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote: > > pipenv is a tool used for managing virtual environments with pinned, > > explicit dependencies. It is used for precisely recreating python > > virtual environments. > > >

Re: [PATCH v4 08/24] python: Add pipenv support

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:40PM -0500, John Snow wrote: > pipenv is a tool used for managing virtual environments with pinned, > explicit dependencies. It is used for precisely recreating python > virtual environments. > > pipenv uses two files to do this: > > (1) Pipfile, which is similar in

Re: [PATCH v4 07/24] python: add directory structure README.rst files

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:39PM -0500, John Snow wrote: > Add short readmes to python/, python/qemu/, python/qemu/machine, > python/qemu/qmp, and python/qemu/utils that explain the directory > hierarchy. These readmes are visible when browsing the source on > e.g. gitlab/github and are designed

Re: [PATCH v3 0/7] CPU unplug timeout/LMB unplug cleanup in DRC reconfiguration

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:39PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This is marked as a v3 as it started as a result of discussions that > followed the v2 [1]. > > The idea with this series is to add CPU hotunplug timeout to avoid the > situations where the kernel refuses to

Re: [PATCH v3 7/7] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:46PM -0300, Daniel Henrique Barboza wrote: > Handling errors in memory hotunplug in the pSeries machine is more complex > than any other device type, because there are all the complications that other > devices has, and more. > > For instance, determining a timeout

Re: [PATCH v4 06/24] python: add VERSION file

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:38PM -0500, John Snow wrote: > Python infrastructure as it exists today is not capable reliably of > single-sourcing a package version from a parent directory. The authors > of pip are working to correct this, but as of today this is not possible. > > The problem is

Re: [PATCH v4 05/24] python: add qemu package installer

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:37PM -0500, John Snow wrote: > Add setup.cfg and setup.py, necessary for installing a package via > pip. Add a rst document explaining the basics of what this package is Nitpick 1: setup.cfg and setup.py are indeed used by pip, your statement is correct. But, it

Re: [PATCH v3 6/7] spapr_drc.c: add hotunplug timeout for CPUs

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:45PM -0300, Daniel Henrique Barboza wrote: > There is a reliable way to make a CPU hotunplug fail in the pseries > machine. Hotplug a CPU A, then offline all other CPUs inside the guest > but A. When trying to hotunplug A the guest kernel will refuse to do > it,

Re: [PATCH v3 5/7] spapr_drc.c: introduce unplug_timeout_timer

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:44PM -0300, Daniel Henrique Barboza wrote: > The LoPAR spec provides no way for the guest kernel to report failure of > hotplug/hotunplug events. This wouldn't be bad if those operations were > granted to always succeed, but that's far for the reality. > > What ends

Re: [PATCH v3 4/7] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request()

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:43PM -0300, Daniel Henrique Barboza wrote: > spapr_drc_detach() is not the best name for what the function does. > The function does not detach the DRC, it makes an uncommited attempt > to do it. It'll mark the DRC as pending unplug, via the 'unplug_request' > flag,

Re: [PATCH v3 5/7] spapr_drc.c: introduce unplug_timeout_timer

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:44PM -0300, Daniel Henrique Barboza wrote: > The LoPAR spec provides no way for the guest kernel to report failure of > hotplug/hotunplug events. This wouldn't be bad if those operations were > granted to always succeed, but that's far for the reality. > > What ends

Re: [PATCH v3 3/7] spapr_drc.c: use spapr_drc_release() in isolate_physical/set_unusable

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 07:52:42PM -0300, Daniel Henrique Barboza wrote: > When moving a physical DRC to "Available", drc_isolate_physical() will > move the DRC state to STATE_PHYSICAL_POWERON and, if the DRC is marked > for unplug, call spapr_drc_detach(). For physical DRCs, drck->empty_state >

Re: [PATCH v3 2/7] spapr_pci.c: simplify spapr_pci_unplug_request() function handling

2021-02-16 Thread David Gibson
On Tue, Feb 16, 2021 at 02:44:44PM -0300, Daniel Henrique Barboza wrote: > > > On 2/16/21 2:16 PM, Greg Kurz wrote: > > On Tue, 16 Feb 2021 13:09:43 -0300 > > Daniel Henrique Barboza wrote: > > > > > > > > > > > On 2/16/21 12:50 PM, Greg Kurz wrote: > > > > On Thu, 11 Feb 2021 19:52:41 -0300

Re: [PATCH v3 1/7] spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical()

2021-02-16 Thread David Gibson
On Mon, Feb 15, 2021 at 11:40:06AM +0100, Greg Kurz wrote: > On Thu, 11 Feb 2021 19:52:40 -0300 > Daniel Henrique Barboza wrote: > > > drc_isolate_logical() is used to move the DRC from the "Configured" to the > > "Available" state, erroring out if the DRC is in the unexpected "Unisolate" > >

Re: [PATCH v2 3/7] device_tree: add qemu_fdt_setprop_string_array helper

2021-02-16 Thread David Gibson
On Thu, Feb 11, 2021 at 05:19:41PM +, Alex Bennée wrote: > A string array in device tree is simply a series of \0 terminated > strings next to each other. As libfdt doesn't support that directly > we need to build it ourselves. Hm, that might not make a bad extension to libfdt... > >

Re: [PATCH v4 04/24] python: create utils sub-package

2021-02-16 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:36PM -0500, John Snow wrote: > Create a space for miscellaneous things that don't belong strictly in > "qemu.machine" nor "qemu.qmp" packages. > > Signed-off-by: John Snow > --- > python/qemu/machine/__init__.py | 8 >

Re: [PATCH RFC v3 00/12] hw/block/nvme: metadata and end-to-end data protection support

2021-02-16 Thread Keith Busch
On Mon, Feb 15, 2021 at 12:02:28AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > This is RFC v3 of a series that adds support for metadata and end-to-end data > protection. > > First, on the subject of metadata, in v1, support was restricted to > extended logical blocks, which was pretty

Re: [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210216233611.33400-1-vgo...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210216233611.33400-1-vgo...@redhat.com Subject: [PATCH 0/3] virtiofsd: Add options to

[PATCH 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-16 Thread Vivek Goyal
Luis Henriques reported that fstest generic/099 fails with virtiofs. Little debugging showed that we don't enable acl support. So this patch series provides option to enable/disable posix acl support. By default it is disabled. I have run blogbench and pjdfstests with posix acl enabled and things

[PATCH 2/3] virtiofsd: Add umask to seccom allow list

2021-02-16 Thread Vivek Goyal
Next patch is going to make use of "umask" syscall. So allow it. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c index ea852e2e33..f0313c5ce4

[PATCH 3/3] virtiofsd: Change umask if posix acls are enabled

2021-02-16 Thread Vivek Goyal
When parent directory has default acl and a file is created in that directory, then umask is ignored and final file permissions are determined using default acl instead. (man 2 umask). Currently, fuse applies the umask and sends modified mode in create request accordingly. fuse server can set

[PATCH 1/3] virtiofsd: Add an option to enable/disable posix acls

2021-02-16 Thread Vivek Goyal
fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse server to enable posix acls. Add virtiofsd option "-o posix_acl/no_posix_acl" to let users enable/disable posix acl support. By default it is disabled as of now. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-16 Thread Peter Xu
Hi, Andrey, On Sat, Feb 13, 2021 at 12:34:07PM +0300, Andrey Gruzdev wrote: > On 12.02.2021 19:11, Peter Xu wrote: > > On Fri, Feb 12, 2021 at 09:52:52AM +0100, David Hildenbrand wrote: > > > On 12.02.21 04:06, Peter Xu wrote: > > > > On Thu, Feb 11, 2021 at 10:09:58PM +0100, David Hildenbrand

Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command

2021-02-16 Thread Keith Busch
On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote: > From: Minwoo Im > > Format NVM admin command can make a namespace or namespaces to be > with different LBA size and metadata size with protection information > types. > > This patch introduces Format NVM command with LBA format,

Re: [PATCH RFC v3 11/12] hw/block/nvme: support multiple lba formats

2021-02-16 Thread Keith Busch
On Mon, Feb 15, 2021 at 12:02:39AM +0100, Klaus Jensen wrote: > From: Minwoo Im > > This patch introduces multiple LBA formats supported with the typical > logical block sizes of 512 bytes and 4096 bytes as well as metadata > sizes of 0, 8, 16 and 64 bytes. The format will be chosed based on the

Re: [PATCH RFC v3 09/12] hw/block/nvme: add verify command

2021-02-16 Thread Keith Busch
On Mon, Feb 15, 2021 at 12:02:37AM +0100, Klaus Jensen wrote: > From: Gollu Appalanaidu > > See NVM Express 1.4, section 6.14 ("Verify Command"). > > Signed-off-by: Gollu Appalanaidu > [k.jensen: rebased, refactored for e2e] > Signed-off-by: Klaus Jensen Verify is a generic block command

Re: [PATCH RFC v3 08/12] hw/block/nvme: end-to-end data protection

2021-02-16 Thread Keith Busch
On Mon, Feb 15, 2021 at 12:02:36AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Add support for namespaces formatted with protection information. The > type of end-to-end data protection (i.e. Type 1, Type 2 or Type 3) is > selected with the `pi` nvme-ns device parameter. If the number of

Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported

2021-02-16 Thread John Snow
On 2/16/21 5:23 PM, Eduardo Habkost wrote: On Tue, Jan 26, 2021 at 08:48:25AM +0100, Michal Privoznik wrote: When management applications (like Libvirt) want to check whether memory-backend-file.pmem is supported they can list object properties using 'qom-list-properties'. However, 'pmem' is

[PATCH v2 1/3] target/arm: Add support for FEAT_SSBS, Speculative Store Bypass Safe

2021-02-16 Thread Rebecca Cran
Add support for FEAT_SSBS. SSBS (Speculative Store Bypass Safe) is an optional feature in ARMv8.0, and mandatory in ARMv8.5. Signed-off-by: Rebecca Cran --- target/arm/cpu.h | 15 +++- target/arm/helper.c| 37 target/arm/internals.h | 6

[PATCH v2 2/3] target/arm: Enable FEAT_SSBS for "max" AARCH64 CPU

2021-02-16 Thread Rebecca Cran
Set ID_AA64PFR1_EL1.SSBS to 2 and ID_PFR2.SSBS to 1. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index c255f1bcc393..f0a9e968c9c1 100644 ---

[PATCH v2 3/3] target/arm: Set ID_PFR2.SSBS to 1 for "max" 32-bit CPU

2021-02-16 Thread Rebecca Cran
Enable FEAT_SSBS for the "max" 32-bit CPU. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 5cf6c056c50f..88a6b183d325 100644 --- a/target/arm/cpu.c +++

[PATCH v2 0/3] target/arm: Add support for FEAT_SSBS

2021-02-16 Thread Rebecca Cran
Add support for FEAT_SSBS, Speculative Store Bypass Safe. SSBS is an optional feature in ARMv8.0 and is mandatory in ARMv8.5. Changes from v1 to v2: o Removed changes to cpsr_write_from_spsr_elx and cpsr_read_for_spsr_elx. o Moved the SSBS case in translate-a64.c above DIT to keep the numbers

Re: [PATCH v4 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 17:04:12 -0800 isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata > > Declare PNP0C01 device to reserve MMCONFIG region to conform to the > spec better and play nice with guest BIOSes/OSes. > > According to PCI Firmware Specification[0], MMCONFIG region must be >

Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported

2021-02-16 Thread Eduardo Habkost
On Tue, Jan 26, 2021 at 08:48:25AM +0100, Michal Privoznik wrote: > When management applications (like Libvirt) want to check whether > memory-backend-file.pmem is supported they can list object > properties using 'qom-list-properties'. However, 'pmem' is > declared always (and thus reported

Re: [PATCH v4 04/10] acpi/core: always set SCI_EN when SMM isn't supported

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 17:04:09 -0800 isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata > > If SMM is not supported, ACPI fixed hardware doesn't support > legacy-mode. ACPI-only platform. Where SCI_EN in PM1_CNT register is > always set. > The bit tells OS legacy mode(SCI_EN cleared) or ACPI

Re: [PATCH v4 03/10] ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 17:04:08 -0800 isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata > > The following patch will introduce incompatible behavior of SMM. > Introduce a property to keep the old behavior for compatibility. > To enable smm compat, use "-global ICH9-LPC.smm-compat=on" or >

Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 20:26:10 +0200 Marian Postevca wrote: > Igor Mammedov writes: > > > hmm, looks like adding instead of removing > > > Do you mean that the commit message does not describe the change > correctly, or that my refactoring is too extreme? I've meant that diff-stat shows that

Re: [PATCH v3 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-16 Thread Igor Mammedov
On Tue, 16 Feb 2021 10:13:25 -0800 Isaku Yamahata wrote: > On Tue, Feb 16, 2021 at 08:45:48AM -0500, > "Michael S. Tsirkin" wrote: > > > On Tue, Feb 16, 2021 at 01:43:01AM -0800, Isaku Yamahata wrote: > > > On Mon, Feb 15, 2021 at 01:48:32PM +0100, > > > Igor Mammedov wrote: > > > > > >

Re: [PATCH] hw/display/tcx: Drop unnecessary code for handling BGR format outputs

2021-02-16 Thread Mark Cave-Ayland
On 16/02/2021 10:11, Peter Maydell wrote: Would you like this to go via a qemu-sparc PR or is it easier to go as part of a group alongside your other display surface patches via target-arm.next? I'm happy either way -- if you don't happen to have anything else queued up for sparc I can just

Re: [PATCH v2 11/42] esp: apply transfer length adjustment when STC is zero at TC load time

2021-02-16 Thread Mark Cave-Ayland
On 16/02/2021 07:33, Philippe Mathieu-Daudé wrote: On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: Perform the length adjustment whereby a value of 0 in the STC represents a transfer length of 0x1 at the point where the TC is loaded at the 0x1 -> 64 KiB? I'd prefer to keep these as they

Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers

2021-02-16 Thread Mark Cave-Ayland
On 16/02/2021 07:30, Philippe Mathieu-Daudé wrote: Are you planning to review any more of this series? I'm keen to put out a (hopefully final) v3 soon, but I'll hold off for little while if you want more time to look over the remaining patches. I talked about this series with Laurent on

Re: [PATCH v8 00/35] Hexagon patch series

2021-02-16 Thread Peter Maydell
On Tue, 16 Feb 2021 at 20:59, Taylor Simpson wrote: > > -Original Message- > > From: Richard Henderson > > I've completed review of this round, and there are some nits. But they're > > minor enough that I wouldn't even mind them being addressed via the > > normal > > development

Re: [PATCH 02/10] qemu-options: update to show preferred boolean syntax for -chardev

2021-02-16 Thread Peter Maydell
On Tue, 16 Feb 2021 at 19:10, Daniel P. Berrangé wrote: > > The preferred syntax is to use "foo=on|off", rather than a bare > "foo" or "nofoo". > > Signed-off-by: Daniel P. Berrangé > -"-chardev > socket,id=id[,host=host],port=port[,to=to][,ipv4][,ipv6][,nodelay][,reconnect=seconds]\n" > -

[Bug 1906193] Re: riscv32 user mode emulation: fork return values broken

2021-02-16 Thread Alistair Francis
A fix has been merged into master. ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906193 Title: riscv32 user mode emulation: fork

RE: [PATCH v8 00/35] Hexagon patch series

2021-02-16 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 7:23 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain ; Peter Maydell > > Subject: Re: [PATCH v8 00/35] Hexagon

Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user

2021-02-16 Thread Claudio Fontana
Hello Eric, On 2/16/21 8:34 PM, Eric Blake wrote: > On 2/16/21 4:46 AM, Claudio Fontana wrote: > > In the subject, s/slit/split/ thanks, fixed. > >> XXX Should we assert that cpu hidden flag SVME is not set, >> when attempting to generate VMRUN and related instructions >> in CONFIG_USER_ONLY?

Re: [RFC PATCH v4 3/7] ebpf: Added eBPF RSS program.

2021-02-16 Thread Toke Høiland-Jørgensen
> From: Andrew > > RSS program and Makefile to build it. > The bpftool used to generate '.h' file. > The data in that file may be loaded by libbpf. > EBPF compilation is not required for building qemu. > You can use Makefile if you need to regenerate rss.bpf.skeleton.h. > > Signed-off-by: Yuri

Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user

2021-02-16 Thread Eric Blake
On 2/16/21 4:46 AM, Claudio Fontana wrote: In the subject, s/slit/split/ > XXX Should we assert that cpu hidden flag SVME is not set, > when attempting to generate VMRUN and related instructions > in CONFIG_USER_ONLY? > > XXX Similarily, should we check for CONFIG_USER_ONLY when > attempting to

Re: [PATCH 00/33] migration: capture error reports into Error object

2021-02-16 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Feb 15, 2021 at 07:01:28PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, Feb 15, 2021 at 06:38:05PM +, Dr. David Alan Gilbert wrote: > > > > One thing to check, and I *think*

Re: [PATCH v2] linux-user/mmap: Return EFAULT/EINVAL for invalid addresses

2021-02-16 Thread Laurent Vivier
Le 16/02/2021 à 20:01, Richard Purdie a écrit : > When using qemu-i386 to build qemux86 webkitgtk on musl, it sits in an > infinite loop of mremap calls of ever decreasing/increasing addresses. > > I suspect something in the musl memory allocation code loops > indefinitely if it only sees ENOMEM

[PATCH 08/10] docs: update to show preferred boolean syntax for -vnc

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". The on|off syntax has been supported since -vnc switched to use QemuOpts in commit 4db14629c38611061fc19ec6927405923de84f08 Signed-off-by: Daniel P. Berrangé --- docs/system/vnc-security.rst | 8 1 file

[PATCH 07/10] docs: update to show preferred boolean syntax for -chardev

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". Signed-off-by: Daniel P. Berrangé --- docs/COLO-FT.txt | 8 docs/ccid.txt | 6 -- docs/colo-proxy.txt| 16

Re: [PATCH 1/5] qcow2-bitmap: make bytes_covered_by_bitmap_cluster() public

2021-02-16 Thread Eric Blake
On 2/16/21 10:45 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename bytes_covered_by_bitmap_cluster() to > bdrv_dirty_bitmap_serialization_coverage() and make it public. It is > needed as we are going to make load_bitmap_data() public in the next > commit. > > Signed-off-by: Vladimir

[PATCH 09/10] docs: update to show preferred boolean syntax for -cpu

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "+foo" or "-foo" Signed-off-by: Daniel P. Berrangé --- docs/COLO-FT.txt | 4 ++-- docs/interop/firmware.json | 2 +- docs/system/cpu-models-x86.rst.inc | 4 ++-- 3 files changed, 5 insertions(+), 5

[PATCH 06/10] qemu-options: update to show preferred boolean syntax for -vnc

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". The on|off syntax has been supported since -vnc switched to use QemuOpts in commit 4db14629c38611061fc19ec6927405923de84f08 Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 16 1 file

[PATCH 10/10] target/i386: update to show preferred boolean syntax for -cpu

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "+foo" or "-foo" Signed-off-by: Daniel P. Berrangé --- target/i386/cpu.c | 2 +- tests/qtest/test-x86-cpuid-compat.c | 52 ++--- 2 files changed, 27 insertions(+), 27 deletions(-) diff

[PATCH 04/10] qemu-options: update to show preferred boolean syntax for -netdev

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bdf159c929..fb2050cda9 100644 ---

[PATCH 05/10] qemu-options: update to show preferred boolean syntax for -incoming

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index fb2050cda9..da0ddf8a3a 100644 ---

[PATCH 03/10] qemu-options: update to show preferred boolean syntax for -spice

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 972ef412cc..bdf159c929 100644

[PATCH 02/10] qemu-options: update to show preferred boolean syntax for -chardev

2021-02-16 Thread Daniel P . Berrangé
The preferred syntax is to use "foo=on|off", rather than a bare "foo" or "nofoo". Signed-off-by: Daniel P. Berrangé --- qemu-options.hx | 78 - 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index

[PATCH 01/10] gdbstub: use preferred boolean option syntax

2021-02-16 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 759bb00bcf..3ee40479b6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3505,7 +3505,7 @@ int gdbserver_start(const char *device) if

[PATCH 00/10] qemu-options: always use key=on|off syntax for bool option docs

2021-02-16 Thread Daniel P . Berrangé
In discussing the proposal to deprecate the short form bool options without a value, it was pointed out that the docs mostly use the short form: https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg05018.html This series converts all usage of the short form into the canonical key=on|off

Re: [PATCH v5 00/11] virtio-mem: vfio support

2021-02-16 Thread Alex Williamson
On Tue, 16 Feb 2021 19:49:09 +0100 David Hildenbrand wrote: > On 16.02.21 19:33, Alex Williamson wrote: > > On Mon, 15 Feb 2021 15:03:43 +0100 > > David Hildenbrand wrote: > > > >> On 08.02.21 09:28, David Hildenbrand wrote: > >>> On 27.01.21 13:45, Michael S. Tsirkin wrote: > On

Re: [PATCH v5 11/11] vfio: Disable only uncoordinated discards for VFIO_TYPE1 iommus

2021-02-16 Thread Alex Williamson
On Thu, 21 Jan 2021 12:05:40 +0100 David Hildenbrand wrote: > We support coordinated discarding of RAM using the RamDiscardMgr for > the VFIO_TYPE1 iommus. Let's unlock support for coordinated discards, > keeping uncoordinated discards (e.g., via virtio-balloon) disabled if > possible. > > This

[PATCH v2] linux-user/mmap: Return EFAULT/EINVAL for invalid addresses

2021-02-16 Thread Richard Purdie
When using qemu-i386 to build qemux86 webkitgtk on musl, it sits in an infinite loop of mremap calls of ever decreasing/increasing addresses. I suspect something in the musl memory allocation code loops indefinitely if it only sees ENOMEM and only exits when it hits other errors such as EFAULT or

Re: [PATCH v11 12/12] migration: introduce snapshot-{save,load,delete} QMP commands

2021-02-16 Thread John Snow
On 2/4/21 7:48 AM, Daniel P. Berrangé wrote: savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined.

Re: [PATCH v5 01/11] memory: Introduce RamDiscardMgr for RAM memory regions

2021-02-16 Thread David Hildenbrand
+/** + * @is_populated: + * + * Check whether the given range within the #MemoryRegion is completely + * populated (i.e., no parts are currently discarded). There are no + * alignment requirements for the range. + * + * @rdm: the #RamDiscardMgr + * @mr: the

Re: [PATCH v5 00/11] virtio-mem: vfio support

2021-02-16 Thread David Hildenbrand
On 16.02.21 19:33, Alex Williamson wrote: On Mon, 15 Feb 2021 15:03:43 +0100 David Hildenbrand wrote: On 08.02.21 09:28, David Hildenbrand wrote: On 27.01.21 13:45, Michael S. Tsirkin wrote: On Thu, Jan 21, 2021 at 12:05:29PM +0100, David Hildenbrand wrote: A virtio-mem device manages a

[PULL 3/6] tools/virtiofsd: Replace the word 'whitelist'

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Dr. David Alan

[PULL 4/6] virtiofsd: Save error code early at the failure callsite

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Change error code handling slightly in lo_setattr(). Right now we seem to jump to out_err and assume that "errno" is valid and use that to send reply. But if caller has to do some other operations before jumping to out_err, then it does the dance of first saving errno to

[PULL 2/6] virtiofsd: vu_dispatch locking should never fail

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz pthread_rwlock_rdlock() and pthread_rwlock_wrlock() can fail if a deadlock condition is detected or the current thread already owns the lock. They can also fail, like pthread_rwlock_unlock(), if the mutex wasn't properly initialized. None of these are ever expected to happen with

[PULL 0/6] virtiofs queue

2021-02-16 Thread Dr. David Alan Gilbert (git)
: https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210216 for you to fetch changes up to 26ec1909648e0c06ff06ebc3ddb2f88ebeeaa6a9: virtiofsd: Do not use a thread pool by default (2021-02-16 17:54:18 +) virtiofsd pull 2021-02-1

[PULL 5/6] viriofsd: Add support for FUSE_HANDLE_KILLPRIV_V2

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal This patch adds basic support for FUSE_HANDLE_KILLPRIV_V2. virtiofsd can enable/disable this by specifying option "-o killpriv_v2/no_killpriv_v2". By default this is enabled as long as client supports it Enabling this option helps with performance in write path. Without this

[PULL 6/6] virtiofsd: Do not use a thread pool by default

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Currently we created a thread pool (With 64 max threads per pool) for each virtqueue. We hoped that this will provide us with better scalability and performance. But in practice, we are getting better numbers in most of the cases when we don't create a thread pool at all and a

[PULL 1/6] virtiofsd: Allow to build it without the tools

2021-02-16 Thread Dr. David Alan Gilbert (git)
From: Wainer dos Santos Moschetta This changed the Meson build script to allow virtiofsd be built even though the tools build is disabled, thus honoring the --enable-virtiofsd option. Fixes: cece116c939d219070b250338439c2d16f94e3da (configure: add option for virtiofsd) Signed-off-by: Wainer

Re: [PATCH v5 07/11] vfio: Support for RamDiscardMgr in the vIOMMU case

2021-02-16 Thread Alex Williamson
On Thu, 21 Jan 2021 12:05:36 +0100 David Hildenbrand wrote: > vIOMMU support works already with RamDiscardMgr as long as guests only > map populated memory. Both, populated and discarded memory is mapped > into _space_memory, where vfio_get_xlat_addr() will find that > memory, to create the vfio

Re: [PATCH v5 06/11] vfio: Sanity check maximum number of DMA mappings with RamDiscardMgr

2021-02-16 Thread Alex Williamson
On Thu, 21 Jan 2021 12:05:35 +0100 David Hildenbrand wrote: > Although RamDiscardMgr can handle running into the maximum number of > DMA mappings by propagating errors when creating a DMA mapping, we want > to sanity check and warn the user early that there is a theoretical setup > issue and

  1   2   3   4   >