04.06.2021 00:27, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:11AM +0300, Vladimir Sementsov-Ogievskiy wrote:
OK, that's a big rewrite of the logic.
Pre-patch we have an always running coroutine - connection_co. It does
reply receiving and reconnecting. And it leads to a lot of difficult
04.06.2021 00:11, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:10AM +0300, Vladimir Sementsov-Ogievskiy wrote:
req->receiving is a flag of request being in one concrete yield point
in nbd_co_do_receive_one_chunk().
Such kind of boolean flag is always better to unset before scheduling
the
03.06.2021 23:48, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:06AM +0300, Vladimir Sementsov-Ogievskiy wrote:
nbd_open() does it (through nbd_establish_connection()).
Actually we lost that call on reconnect path in 1dc4718d849e1a1fe
"block/nbd: use non-blocking connect: fix vm hang on
03.06.2021 23:04, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:05AM +0300, Vladimir Sementsov-Ogievskiy wrote:
Split out part, that we want to reuse for nbd_open().
Split out the part that we want to reuse for nbd_open().
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/nbd.c |
03.06.2021 23:53, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote:
We are going to reuse the script to generate a qcow2_ function in
Is qcow2_ right here? Looking ahead to patch 30/33, it looks like you
meant nbd_, at least in the context of
Hello, I have tested this patch with our qemu and it works, thank you.
What are the next steps for this patch? So is it approved and ready to go
in mainline?
Thanks,
Swetha.
On Thu, Jun 3, 2021 at 10:30 AM Swetha Joshi
wrote:
>
> Oh okay, thank you. I will test this by eod today!
>
>
> On
On Fri, Jun 4, 2021 at 10:38 AM Alistair Francis wrote:
>
> On Fri, Jun 4, 2021 at 12:34 PM Bin Meng wrote:
> >
> > On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis
> > wrote:
> > >
> > > On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote:
> > > >
> > > > On Fri, Jun 4, 2021 at 7:21 AM Alistair
On Fri, Jun 4, 2021 at 12:34 PM Bin Meng wrote:
>
> On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis wrote:
> >
> > On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote:
> > >
> > > On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis
> > > wrote:
> > > >
> > > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng
On Fri, Jun 4, 2021 at 10:33 AM Alistair Francis wrote:
>
> On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote:
> >
> > On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis
> > wrote:
> > >
> > > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote:
> > > >
> > > > On Mon, May 31, 2021 at 12:33 PM Alistair
On Fri, Jun 4, 2021 at 12:11 PM Bin Meng wrote:
>
> On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis wrote:
> >
> > On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote:
> > >
> > > On Mon, May 31, 2021 at 12:33 PM Alistair Francis
> > > wrote:
> > >
> > > Please write some commit message, for
On Fri, Jun 4, 2021 at 7:21 AM Alistair Francis wrote:
>
> On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote:
> >
> > On Mon, May 31, 2021 at 12:33 PM Alistair Francis
> > wrote:
> >
> > Please write some commit message, for example, what is supported in
> > this initial version, and what is not.
On Thu, Jun 3, 2021 at 7:05 PM Philippe Mathieu-Daudé wrote:
>
> Extract FPU helpers to their own file: fpu_helper.c,
> so it is easier to focus on the generic helpers in
> op_helper.c.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
>
On Thu, Jun 3, 2021 at 7:03 PM Philippe Mathieu-Daudé wrote:
>
> IEC binary prefixes ease code review: the unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> target/microblaze/mmu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2
On Tue, Jun 1, 2021 at 11:10 PM Bin Meng wrote:
>
> On Mon, May 31, 2021 at 12:33 PM Alistair Francis
> wrote:
> >
>
> Please write some commit message here
Done.
>
> > Signed-off-by: Alistair Francis
> > ---
> > include/hw/riscv/opentitan.h | 5 -
> > hw/riscv/opentitan.c | 14
On Tue, Jun 1, 2021 at 11:05 PM Bin Meng wrote:
>
> On Mon, May 31, 2021 at 12:33 PM Alistair Francis
> wrote:
>
> Please write some commit message, for example, what is supported in
> this initial version, and what is not.
I'll add something.
>
> >
> > Signed-off-by: Alistair Francis
> > ---
On Thu, Jun 03, 2021 at 01:48:35PM +0200, Vitaly Kuznetsov wrote:
> For the beginning, just test 'hv-passthrough' and a couple of custom
> Hyper-V enlightenments configurations through QMP. Later, it would
> be great to complement this by checking CPUID values from within the
> guest.
>
>
On Thu, Jun 03, 2021 at 01:48:34PM +0200, Vitaly Kuznetsov wrote:
> When Hyper-V SynIC is enabled, we may need to allow Windows guests to make
> hypercalls (POST_MESSAGES/SIGNAL_EVENTS). No issue is currently observed
> because KVM is very permissive, allowing these hypercalls regarding of
> guest
On Thu, Jun 03, 2021 at 01:48:33PM +0200, Vitaly Kuznetsov wrote:
> According to TLFS, Hyper-V guest is supposed to check
> HV_HYPERCALL_AVAILABLE privilege bit before accessing
> HV_X64_MSR_GUEST_OS_ID/HV_X64_MSR_HYPERCALL MSRs but at least some
> Windows versions ignore that. As KVM is very
On Thu, Jun 03, 2021 at 01:48:31PM +0200, Vitaly Kuznetsov wrote:
> To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we
> need to expand and set the corresponding CPUID leaves early. Modify
> x86_cpu_get_supported_feature_word() to call newly intoduced Hyper-V
> specific
On Thu, Jun 03, 2021 at 01:48:30PM +0200, Vitaly Kuznetsov wrote:
> Return 'false' when hyperv_expand_features() sets an error.
>
> No functional change intended.
>
> Signed-off-by: Vitaly Kuznetsov
Reviewed-by: Eduardo Habkost
--
Eduardo
On Thu, Jun 03, 2021 at 01:48:29PM +0200, Vitaly Kuznetsov wrote:
> Currently, the only eVMCS version, supported by KVM (and described in TLFS)
> is '1'. When Enlightened VMCS feature is enabled, QEMU takes the supported
> eVMCS version range (from KVM_CAP_HYPERV_ENLIGHTENED_VMCS enablement) and
>
On Thu, Jun 03, 2021 at 01:48:28PM +0200, Vitaly Kuznetsov wrote:
> Clarify the fact that 'hv-passthrough' only enables features which are
> already known to QEMU and that it overrides all other 'hv-*' settings.
>
> Signed-off-by: Vitaly Kuznetsov
Reviewed-by: Eduardo Habkost
--
Eduardo
On Thu, Jun 03, 2021 at 01:48:27PM +0200, Vitaly Kuznetsov wrote:
> While this is very unlikely to change, let's avoid hardcoding '12' as
> 'hyperv_vendor_id' length.
>
> No functional change intended.
>
> Signed-off-by: Vitaly Kuznetsov
Reviewed-by: Eduardo Habkost
--
Eduardo
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 58 +++--
1 file changed, 13 insertions(+), 45 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 9caf1ecf9c..be7583780d 100644
--- a/fpu/softfloat.c
+++
Keep the intermediate results in FloatParts instead of
converting back and forth between float64. Use muladd
instead of separate mul+add.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 53 +
1 file changed, 23
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 336 ++--
1 file changed, 42 insertions(+), 294 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index acaab6a127..5a2a872408 100644
--- a/fpu/softfloat.c
+++
For the normal case of no additional scaling, this reduces the
profile contribution of int64_to_float64 to the testcase in the
linked issue from 0.81% to 0.04%.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/134
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
Rename to parts$N_log2. Though this is partly a ruse, since I do not
believe the code will succeed for float128 without work. Which is ok
for now, because we do not need this for more than float32 and float64.
Since berkeley-testfloat-3 doesn't support log2, compare float64_log2
vs the system
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 76 +
1 file changed, 14 insertions(+), 62 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 737f5d7701..ae2e7aa274 100644
--- a/fpu/softfloat.c
+++
From: Alex Bennée
Fix the trivial typo in extF80_lt_quiet, and re-enable
all of the floatx80 tests that are now fixed.
Signed-off-by: Alex Bennée
Message-ID: <87bl9iyahr@linaro.org>
[rth: Squash the fix for lt_quiet, and enable that too.]
Signed-off-by: Richard Henderson
---
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 50 +++--
1 file changed, 11 insertions(+), 39 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 5a2a872408..770badd447 100644
--- a/fpu/softfloat.c
+++
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 100 +++-
1 file changed, 13 insertions(+), 87 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index ae2e7aa274..9c26ba5960 100644
--- a/fpu/softfloat.c
+++
Since this is the first such, this includes all of the
packing and unpacking routines as well.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 339 +++-
1 file changed, 136 insertions(+), 203 deletions(-)
diff --git
Rename to parts$N_modrem. This was the last use of a lot
of the legacy infrastructure, so remove it as required.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
include/fpu/softfloat-macros.h | 34 +
fpu/softfloat.c| 1339 +++-
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 82 +
1 file changed, 22 insertions(+), 60 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 770badd447..c32b1c7113 100644
--- a/fpu/softfloat.c
+++
Use an enumeration instead of raw 32/64/80 values.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
include/fpu/softfloat-helpers.h | 5 +-
include/fpu/softfloat-types.h | 10 +++-
include/fpu/softfloat.h | 4 +-
fpu/softfloat.c | 32 ++--
Many qemu softfloat will check floatx80_rounding_precision
even when berkeley testfloat will not. So begin with
floatx80_precision_x, so that's the one we use
when !FUNC_EFF_ROUNDINGPRECISION.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tests/fp/fp-test.c | 8
1
This is the last use of commonNaNT and all of the routines
that use it, so remove all of them for Werror.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c| 276 -
fpu/softfloat-specialize.c.inc | 175
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 82 +++--
1 file changed, 11 insertions(+), 71 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 9c26ba5960..5a320e5302 100644
--- a/fpu/softfloat.c
+++
With floatx80_precision_x, the rounding happens across
the break between words. Notice this case with
frac_lsb = round_mask + 1 -> 0
and check the bits in frac_hi as needed.
In addition, since frac_shift == 0, we won't implicitly clear
round_mask via the right-shift, so explicitly clear
Rename to parts$N_compare. Rename all of the intermediate
functions to ftype_do_compare. Rename the hard-float functions
to ftype_hs_compare. Convert float128 to FloatParts128.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 208
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 116 ++--
1 file changed, 13 insertions(+), 103 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 74787d5a6e..9caf1ecf9c 100644
--- a/fpu/softfloat.c
+++
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 5a320e5302..74787d5a6e 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -5792,10 +5792,12 @@
From: David Hildenbrand
The float128 implementation is straight-forward.
Unfortuantely, we don't have any tests we can simply adjust/unlock.
Signed-off-by: David Hildenbrand
Message-Id: <20210517142739.38597-24-da...@redhat.com>
[rth: Update for changed parts_minmax return value]
Rename to parts$N_uint_to_float.
Reimplement uint64_to_float128 with FloatParts128.
Reviewed-by: Alex Bennée
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 83 ---
fpu/softfloat-parts.c.inc | 23 +++
Remove frac_lsb, frac_lsbm1, roundeven_mask. Compute
these from round_mask in parts$N_uncanon_normal.
With floatx80, round_mask will not be tied to frac_shift.
Everything else is easily computable.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 29
Rename to parts$N_sqrt.
Reimplement float128_sqrt with FloatParts128.
Reimplement with the inverse sqrt newton-raphson algorithm from musl.
This is significantly faster than even the berkeley sqrt n-r algorithm,
because it does not use division instructions, only multiplication.
Ordinarily,
Rename to parts$N_scalbn.
Reimplement float128_scalbn with FloatParts128.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 103 +-
fpu/softfloat-parts.c.inc | 21
2 files changed, 55 insertions(+), 69
Rename to parts$N_float_to_uint. Reimplement
float128_to_uint{32,64}{_round_to_zero} with FloatParts128.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 357 +-
fpu/softfloat-parts.c.inc | 68 +++-
2 files
Rename to parts$N_minmax. Combine 3 bool arguments to a bitmask.
Introduce ftype_minmax functions as a common optimization point.
Fold bfloat16 expansions into the same macro as the other types.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
fpu/softfloat.c |
We will need to treat the non-normal cases of floatx80 specially,
so split out the normal case that we can reuse.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 8 ++
fpu/softfloat-parts.c.inc | 59 +--
2 files
Rename to parts$N_sint_to_float.
Reimplement int{32,64}_to_float128 with FloatParts128.
Reviewed-by: Alex Bennée
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 136 +++---
fpu/softfloat-parts.c.inc | 32
The following changes since commit 453d9c61dd5681159051c6e4d07e7b2633de2e70:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210603'
into staging (2021-06-03 16:59:46 +0100)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-fpu
On Fri, Apr 16, 2021 at 11:09:11AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> OK, that's a big rewrite of the logic.
>
> Pre-patch we have an always running coroutine - connection_co. It does
> reply receiving and reconnecting. And it leads to a lot of difficult
> and unobvious code around
On Fri, Apr 16, 2021 at 11:09:10AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> req->receiving is a flag of request being in one concrete yield point
> in nbd_co_do_receive_one_chunk().
>
> Such kind of boolean flag is always better to unset before scheduling
> the coroutine, to avoid double
On Fri, Apr 16, 2021 at 11:09:09AM +0300, Vladimir Sementsov-Ogievskiy wrote:
In the subject: s/clinent/client/
> We already have two similar helpers for other state. Let's add another
> one for convenience.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/nbd.c | 25
On Fri, Apr 16, 2021 at 11:09:08AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> The only last step we need to reuse the function is coroutine-wrapper.
> nbd_open() may be called from non-coroutine context. So, generate the
> wrapper and use it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
>
On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We are going to reuse the script to generate a qcow2_ function in
Is qcow2_ right here? Looking ahead to patch 30/33, it looks like you
meant nbd_, at least in the context of this series.
--
Eric Blake, Principal
On Fri, Apr 16, 2021 at 11:09:07AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We'll need a possibility of non-blocking nbd_co_establish_connection(),
> so that it returns immediately, and it returns success only if
> connections was previously established in background.
only if a connection was
On Fri, Apr 16, 2021 at 11:09:06AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> nbd_open() does it (through nbd_establish_connection()).
> Actually we lost that call on reconnect path in 1dc4718d849e1a1fe
> "block/nbd: use non-blocking connect: fix vm hang on connect()"
> when we have introduced
On Thu, Jun 03, 2021 at 08:36:42PM +0100, Dr. David Alan Gilbert wrote:
> * Steven Sistare (steven.sist...@oracle.com) wrote:
> > On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote:
> > > * Steven Sistare (steven.sist...@oracle.com) wrote:
> > >> On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote:
On Thu, Jun 03, 2021 at 03:11:28PM -0400, John Snow wrote:
> On 6/3/21 3:26 AM, Philippe Mathieu-Daudé wrote:
> > I haven't reviewed earlier version, but I wonder about the "build from
> > sources" use case (this is not a template for distributions but for the
> > mainstream project), so maybe
On Thu, 3 Jun 2021 at 16:59, Peter Maydell wrote:
>
> The following changes since commit a97978bcc2d1f650c7d411428806e5b03082b8c7:
>
> Merge remote-tracking branch 'remotes/dg-gitlab/tags/ppc-for-6.1-20210603'
> into staging (2021-06-03 10:00:35 +0100)
>
> are available
On 6/3/21 1:17 AM, ishii.shuuic...@fujitsu.com wrote:
Hi, Richard.
Thank you for your comment.
My first thought is that -cpu max can simply enable the extensions, without
extra flags. The max cpu has all of the features that we can enable, and as I
see it this is just one more.
Let me
On Fri, Apr 16, 2021 at 11:09:05AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Split out part, that we want to reuse for nbd_open().
Split out the part that we want to reuse for nbd_open().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/nbd.c | 79
On Fri, Apr 16, 2021 at 11:09:04AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We are going to reuse the script to generate a qcow2_ function in
> further commit. Prepare the script now.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/block-coroutine-wrapper.py | 7 ---
> 1
On Fri, Apr 16, 2021 at 11:09:03AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> block/nbd doesn't need underlying sioc channel anymore. So, we can
> update nbd/client-connection interface to return only one top-most io
> channel, which is more straight forward.
>
> Signed-off-by: Vladimir
On Thu, Jun 03, 2021 at 10:29:35AM +0200, Laszlo Ersek wrote:
> On 06/02/21 21:19, Tom Lendacky wrote:
> > Just a quick ping on this series...
>
> Right, I'm unsure who is supposed to merge this... Do you remember who
> usually merges the SEV-related patch series (plural)?
I'm queueing this
* Steven Sistare (steven.sist...@oracle.com) wrote:
> On 5/24/2021 6:39 AM, Dr. David Alan Gilbert wrote:
> > * Steven Sistare (steven.sist...@oracle.com) wrote:
> >> On 5/20/2021 9:13 AM, Dr. David Alan Gilbert wrote:
> >>> On the 'restart' branch of questions; can you explain,
> >>> other than
On Fri, Apr 16, 2021 at 11:09:02AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Currently sioc pointer is used just to pass from socket-connection to
> nbd negotiation. Drop the field, and use local variables instead. With
> next commit we'll update nbd/client-connection.c to behave
>
On 6/3/21 3:26 AM, Philippe Mathieu-Daudé wrote:
I haven't reviewed earlier version, but I wonder about the "build from
sources" use case (this is not a template for distributions but for the
mainstream project), so maybe add:
## Build environment (in case you built QEMU from source)
-
On Tue, Jun 01, 2021 at 04:17:41PM -0400, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> KVM_RUN_X86_BUS_LOCK is a requirement for:
> [PATCH v4] i386: Add ratelimit for bus locks acquired in guest
> Message-Id: <20210521043820.29678-1-chenyi.qi...@intel.com>
I forgot to
On 5/25/21 9:45 AM, Alex Bennée wrote:
There are two justifications for making this change. The first is that
i386 emulation is typically for smaller machines where having a 1gb of
generated code is overkill for basic emulation. The second is the
propensity of self-modifying code (c.f.
On Fri, Apr 16, 2021 at 11:09:01AM +0300, Vladimir Sementsov-Ogievskiy wrote:
For the subject line, might read better as:
block/nbd: don't touch s->sioc in nbd_teardown_connection()
> Negotiation during reconnect is now done in thread, and s->sioc is not
in a thread
> available during
On 6/3/21 4:06 AM, Emanuele Giuseppe Esposito wrote:
On 03/06/2021 01:23, John Snow wrote:
On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote:
Alsp add a new _qmp_timer field to the QEMUMachine class.
Let's change the default socket timeout to None, so that if
a subclass needs to add a
On 6/3/21 10:12 AM, Peter Maydell wrote:
The virt_is_acpi_enabled() function is specific to the virt board, as
is the check for its 'ras' property. Use the new acpi_ghes_present()
function to check whether we should report memory errors via
acpi_ghes_record_errors().
This avoids a link error
On 6/3/21 10:12 AM, Peter Maydell wrote:
Allow code elsewhere in the system to check whether the ACPI GHES
table is present, so it can determine whether it is OK to try to
record an error by calling acpi_ghes_record_errors().
(We don't need to migrate the new 'present' field in AcpiGhesState,
On 6/3/21 10:12 AM, Peter Maydell wrote:
+softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c',
'aml-build-stub.c', 'ghes-stub.c'))
softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss)
softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c',
'aml-build-stub.c',
-
03.06.2021 21:16, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:09:00AM +0300, Vladimir Sementsov-Ogievskiy wrote:
monitor_cur() is used by socket_get_fd, but it doesn't work in
connection thread. Let's monitor directly to cover this thing. We are
going to unify connection establishing path in
On Fri, Apr 16, 2021 at 11:09:00AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> monitor_cur() is used by socket_get_fd, but it doesn't work in
> connection thread. Let's monitor directly to cover this thing. We are
> going to unify connection establishing path in nbd_open and reconnect,
> so we
On Thu, Jun 03, 2021 at 10:13:30AM +0200, Claudio Fontana wrote:
> On 6/1/21 8:48 PM, Eduardo Habkost wrote:
> > +Vitaly
> >
> > On Sat, May 29, 2021 at 11:13:12AM +0200, Claudio Fontana wrote:
> >> we need to expand features first, before we attempt to check them
> >> in the accel realizefn code
On 5/17/21 7:27 AM, David Hildenbrand wrote:
+if (unlikely(nan_a || nan_b)) {
Perhaps better as (dcmask_a | dcmask_b) & DCMASK_NAN ?
+if (sig_a || sig_b) {
Similarly.
+} else if (unlikely(inf_a && inf_b)) {
+switch (type) {
+case S390_MINMAX_TYPE_JAVA:
+
On Fri, Apr 16, 2021 at 11:08:58AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Use a new possibility of negotiation in connect thread. Now we are on
> the way of simplifying connection_co. We want to move the whole
> reconnect code to NBDClientConnection. NBDClientConnection already
> updated to
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Since 00f2cfbbec6 ("glib: bump min required glib library version to
> 2.48") we can use g_auto/g_autoptr to have the compiler automatically
> free an allocated variable when it goes out of scope, removing this
> burden on the developers.
>
>
03.06.2021 19:17, Eric Blake wrote:
On Fri, Apr 16, 2021 at 11:08:55AM +0300, Vladimir Sementsov-Ogievskiy wrote:
Add an option for thread to retry connection until success. We'll use
for a thread to retry connection until it succeeds.
nbd/client-connection both for reconnect and for
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 6 +
target/s390x/insn-data.def | 4
target/s390x/translate_vx.c.inc | 39 +++--
target/s390x/vec_fpu_helper.c | 2 ++
4 files
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 4 +++
target/s390x/translate_vx.c.inc | 47 -
target/s390x/vec_fpu_helper.c | 44 +-
3 files changed, 87
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 2 ++
target/s390x/translate_vx.c.inc | 23 ++--
target/s390x/vec_fpu_helper.c | 47 +
3 files changed, 70 insertions(+), 2
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 4 +++
target/s390x/translate_vx.c.inc | 38 ++--
target/s390x/vec_fpu_helper.c | 44 -
3 files changed, 77
On 5/17/21 7:27 AM, David Hildenbrand wrote:
In addition to 32/128bit variants, we also have to support the
"Signal-on-QNaN (SQ)" bit.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 12 +++
target/s390x/translate_vx.c.inc | 57 -
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 4 ++
target/s390x/translate_vx.c.inc | 74 ++---
target/s390x/vec_fpu_helper.c | 46 +++-
3 files changed, 109 insertions(+),
On Thu, Jun 03, 2021 at 03:37:18PM +0200, Paolo Bonzini wrote:
> For block host devices, I/O can happen through either the kernel file
> descriptor I/O system calls (preadv/pwritev, io_submit, io_uring)
> or the SCSI passthrough ioctl SG_IO.
>
> In the latter case, the size of each transfer can
On 5/17/21 7:27 AM, David Hildenbrand wrote:
In case of 128bit, we always have a single element. Add new helpers for
reading/writing 32/128 bit floats.
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 8
target/s390x/translate_vx.c.inc | 85
Oh okay, thank you. I will test this by eod today!
On Thu, Jun 3, 2021 at 10:22 AM Peter Maydell
wrote:
> On Fri, 28 May 2021 at 20:41, Swetha Joshi
> wrote:
> >
> > I apologize for the delay, here are the repro steps:
> > 1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak
> > 2. In
On 5/17/21 7:27 AM, David Hildenbrand wrote:
... and prepare for 32/128 bit support.
Signed-off-by: David Hildenbrand
---
target/s390x/vec_fpu_helper.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
r~
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 -
target/s390x/translate_vx.c.inc | 3 +--
target/s390x/vec_fpu_helper.c | 29 +++--
3 files changed, 8 insertions(+), 25 deletions(-)
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 -
target/s390x/translate_vx.c.inc | 6 +-
target/s390x/vec_fpu_helper.c | 21 +
3 files changed, 6 insertions(+), 22 deletions(-)
Reviewed-by:
On Fri, 28 May 2021 at 20:41, Swetha Joshi wrote:
>
> I apologize for the delay, here are the repro steps:
> 1. Remove CONFIG_ARM_VIRT=y from arm-softmmu.mak
> 2. In .gitlab-ci.yml, crossbuild.yml and in tests/vm/Makefile.include, in all
> the places where we disable kvm using -disable-kvm,
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 2 --
target/s390x/translate_vx.c.inc | 8 +++
target/s390x/vec_fpu_helper.c | 42 +
3 files changed, 20 insertions(+), 32 deletions(-)
On 5/17/21 7:27 AM, David Hildenbrand wrote:
Signed-off-by: David Hildenbrand
---
target/s390x/helper.h | 1 -
target/s390x/translate_vx.c.inc | 7 ++-
target/s390x/vec_fpu_helper.c | 29 +++--
3 files changed, 13 insertions(+), 24 deletions(-)
1 - 100 of 378 matches
Mail list logo