Re: [PATCH] hw/i386/pc: Document pc_system_ovmf_table_find

On 29/06/2021 1:03, Tom Lendacky wrote: > On 6/22/21 7:58 AM, Dov Murik wrote: >> +cc: Tom Lendacky >> >> On 22/06/2021 15:47, Philippe Mathieu-Daudé wrote: >>> On 6/22/21 2:44 PM, Dov Murik wrote: Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Dov Murik ---

Re: [PATCH v2 00/28] target/mips: Explode 60% of the 32K-lines translate.c

On 12/8/20 12:08 AM, Philippe Mathieu-Daudé wrote: > On 11/23/20 9:44 PM, Philippe Mathieu-Daudé wrote: >> Since v1: >> - Addressed Richard review comments >> >> Patches missing review: 1,3,4,21,22,25 >> >> Hi, >> >> This series, while boring, helps maintainability. >> >> I simply exploded 60% of

[PATCH] hw/mips/jazz: Map the UART devices unconditionally

When using the Magnum ARC firmware we can see accesses to the UART1 beeing rejected, because the device is not mapped: $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected Invalid access at addr

Re: [PATCH v2] hw/nvme: fix pin-based interrupt behavior (again)

On Jun 17 20:55, Klaus Jensen wrote: From: Klaus Jensen Jakub noticed[1] that, when using pin-based interrupts, the device will unconditionally deasssert when any CQEs are acknowledged. However, the pin should not be deasserted if other completion queues still holds unacknowledged CQEs. The

Re: [PATCH] hw/nvme: fix missing check for PMR capability

On Jun 7 11:47, Klaus Jensen wrote: From: Klaus Jensen Qiang Liu reported that an access on an unknown address is triggered in memory_region_set_enabled because a check on CAP.PMRS is missing for the PMRCTL register write when no PMR is configured. Cc: qemu-sta...@nongnu.org Fixes:

[PATCH v2] misc: Fix "havn't" typo

Fix "havn't (make)" -> "haven't (made)" typo. Reviewed-by: Luis Pires Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/desc-msos.c | 2 +- target/s390x/translate.c | 6 -- tcg/tcg-op.c | 2 +- tcg/arm/tcg-target.c.inc | 6 -- tcg/sparc/tcg-target.c.inc | 6

[PATCH v2 1/1] migration: Unregister yank if migration setup fails

Currently, if a qemu instance is started with "-incoming defer" and an incorect parameter is passed to "migrate_incoming", it will print the expected error and reply with "duplicate yank instance" for any upcoming "migrate_incoming" command. This renders current qemu process unusable, and

[PATCH v2] tcg: Avoid including 'trace-tcg.h' in target translate.c

The root trace-events only declares a single TCG event: $ git grep -w tcg trace-events trace-events:115:# tcg/tcg-op.c trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" and only a tcg/tcg-op.c uses it: $ git grep -l

Re: [PATCH 3/5] hw/pci-host/bonito: Allow PCI config accesses smaller than 32-bit

On 6/24/21 10:49 PM, BALATON Zoltan wrote: > On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: >> When running the official PMON firmware for the Fuloong 2E, we see >> 8-bit and 16-bit accesses to PCI config space: >> >>  $ qemu-system-mips64el -M fuloong2e -bios pmon_2e.bin \ >>    -trace -trace

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

On 6/24/21 10:43 PM, BALATON Zoltan wrote: > On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: >> Test the PMON firmware. As the firmware is not redistributable, >> it has to be downloaded manually first. Then it can be used by >> providing its path via the PMON_BIN_PATH environment variable: >>

Re: [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart

On 6/17/21 7:49 PM, Philippe Mathieu-Daudé wrote: > Extract the microMIPS ISA and Code Compaction ASE translation > routines to different source files. Patches rebased and already > reviewed, except patch #1. > > Philippe Mathieu-Daudé (4): > target/mips: Add declarations for generic TCG

Re: [PATCH 1/1] util/uri: do not check argument of uri_free()

On 6/28/21 11:55 PM, Heinrich Schuchardt wrote: > uri_free() checks if its argument is NULL in uri_clean() and g_free(). > There is no need to check the argument before the call. > > Signed-off-by: Heinrich Schuchardt > --- > block/nfs.c | 4 +--- > block/ssh.c | 4 +--- > capstone| 2 +-

Re: [PATCH] target/s390x: Use explicit stores to env->cc_op

On 6/29/21 2:29 AM, Richard Henderson wrote: > Remove cc_op as a TCG global and store to it directly. > This will help simplify the fix for some fpu bugs. > > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h| 98 ++--- > target/s390x/crypto_helper.c | 6 +- >

[Bug 1745316] Re: SDL1.x>SDL2 regressions: non-usbtablet mouse position reporting is broken, and VGA/compatmonitor/serial/etc view switching is unusable

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1745316 Title:

[Bug 1883560] Re: mips linux-user builds occasionly crash randomly only to be fixed by a full clean re-build

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883560 Title: mips

Re: [PULL 15/28] osdep: provide ROUND_DOWN macro

On 6/25/21 4:18 PM, Paolo Bonzini wrote: > osdep.h provides a ROUND_UP macro to hide bitwise operations for the > purpose of rounding a number up to a power of two; add a ROUND_DOWN > macro that does the same with truncation towards zero. > > While at it, change the formatting of some comments. >

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

在 2021/6/28 下午7:18, Yuri Benditovich 写道: On Wed, Jun 23, 2021 at 3:47 AM Jason Wang wrote: 在 2021/6/22 下午5:09, Toke Høiland-Jørgensen 写道: Daniel P. Berrangé writes: On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: Jason Wang writes: 在 2021/6/22 上午11:29, Yuri

Re: [RFC PATCH 09/11] target/riscv: Update CSR mclicbase in CLIC mode

On 2021/6/26 下午11:31, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:52寫道： The machine mode mclicbase CSR is an XLEN-bit read-only register providing the base address of CLIC memory mapped registers. Signed-off-by: LIU Zhiwei

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

On 2021/6/26 下午11:26, Frank Chang wrote: Frank Chang mailto:frank.ch...@sifive.com>> 於 2021年6月26日 週六 下午11:03寫道： LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道： The Core-Local Interrupt Controller (CLIC) provides low-latency, vectored, pre-emptive

Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

Tested-by: Akihiko Odaki 2021年6月29日(火) 1:09 Philippe Mathieu-Daudé : > > Avoid accessing QCryptoTLSCreds internals by using > the qcrypto_tls_creds_check_endpoint() helper. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qemu-nbd.c | 19 +++ > 1 file changed, 7 insertions(+),

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

On 2021/6/26 下午11:20, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道： + +/* + * riscv_clic_create: + * + * @addr: base address of M-Mode CLIC memory-mapped registers + * @prv_s: have smode region + * @prv_u: have umode region

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

Hi Frank, Thanks for a lot of good points. On 2021/6/26 下午11:03, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道： +static uint8_t +riscv_clic_get_interrupt_level(RISCVCLICState *clic, uint8_t intctl) +{ +    int nlbits = clic->nlbits; +

[PATCH] coreaudio: Commit the result of init in the end

init_out_device may only commit some part of the result and leave the state inconsistent when it encounters an error. Commit the result in the end of the function so that it commits the result iif it sees no error. With this change, handle_voice_change can rely on core->outputDeviceID to know

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021年6月29日(火) 6:19 BALATON Zoltan : > > On Mon, 28 Jun 2021, Akihiko Odaki wrote: > > 2021年6月28日(月) 17:57 BALATON Zoltan : > >> > >> On Mon, 28 Jun 2021, Akihiko Odaki wrote: > >>> This change brings two new features: > >>> - The window will be resizable if "Zoom To Fit" is eanbled > >>> - The

Re: [PATCH v4 3/3] fuzz: make object-name matching case-insensitive

On 210628 0123, Alexander Bulekov wrote: > We have some configs for devices such as the AC97 and ES1370 that were > not matching memory-regions correctly, because the configs provided > lowercase names. To resolve these problems and prevent them from > occurring again in the future, convert both

[PATCH] target/s390x: Use explicit stores to env->cc_op

Remove cc_op as a TCG global and store to it directly. This will help simplify the fix for some fpu bugs. Signed-off-by: Richard Henderson --- target/s390x/helper.h| 98 ++--- target/s390x/crypto_helper.c | 6 +- target/s390x/fpu_helper.c| 40 +++---

Re: [PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

On Mon, Jun 28, 2021 at 02:06:01PM +0100, Stefan Hajnoczi wrote: > On Thu, Jun 24, 2021 at 04:42:26PM -0400, Igor Mammedov wrote: > > Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices), > > regressed network interface naming for Linux guests in some cases. > > This reverts PCI slot

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

On 6/11/21 6:40 AM, Alex Bennée wrote: Cleber Rosa Junior writes: On Wed, Jun 9, 2021 at 11:26 AM Alex Bennée wrote: Cleber Rosa Junior writes: > On Wed, Jun 9, 2021 at 9:36 AM Alex Bennée wrote: > > Cleber Rosa writes: > > > To run basic jobs on custom runners, the

Re: [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

On Mon, Jun 28, 2021 at 12:27:46AM +0800, huang...@chinatelecom.cn wrote: > +static void dirtyrate_global_dirty_log_stop(void) > +{ > +qemu_mutex_lock_iothread(); One thing I missed: maybe we want to sync dirty before stop, so the value will be more accurate. Perhaps a call to

Re: [PATCH v5 13/14] target/hexagon: import additional tests

On Fri, Jun 25, 2021 at 6:56 PM Taylor Simpson wrote: > > > On Sat, Jun 19, 2021 at 4:49 AM Alessandro Di Federico via < > qemu-devel@nongnu.org> wrote: > >> From: Niccolò Izzo >> >> Signed-off-by: Alessandro Di Federico >> Signed-off-by: Niccolò Izzo >> --- >> > > > > +.text >> +

Re: [PATCH] hw/i386/pc: Document pc_system_ovmf_table_find

On 6/22/21 7:58 AM, Dov Murik wrote: > +cc: Tom Lendacky > > On 22/06/2021 15:47, Philippe Mathieu-Daudé wrote: >> On 6/22/21 2:44 PM, Dov Murik wrote: >>> Suggested-by: Philippe Mathieu-Daudé >>> Signed-off-by: Dov Murik >>> --- >>> hw/i386/pc_sysfw.c | 14 ++ >>> 1 file changed,

[PATCH v3 9/9] target/nios2: Use pc_next for pc + 4

We have pre-computed the next instruction address into dc->base.pc_next, so we might as well use it. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v3 4/9] target/nios2: Add DisasContextBase to DisasContext

Migrate the is_jmp, tb and singlestep_enabled fields from DisasContext into the base. Use pc_first instead of tb->pc. Increment pc_next prior to decode, leaving the address of the current insn in dc->pc. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 70

[PATCH v3 5/9] target/nios2: Convert to TranslatorOps

Signed-off-by: Richard Henderson --- target/nios2/translate.c | 128 --- 1 file changed, 65 insertions(+), 63 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 12f987651a..66f4c25b06 100644 --- a/target/nios2/translate.c +++

[PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction

Direct assignments to env during translation do not work. As it happens, the only way we can get here is if env->pc is already set to dc->pc. We will trap on the first insn we execute anywhere on the page. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 3 ++- 1 file changed,

[PATCH v3 8/9] target/nios2: Inline handle_instruction

Move handle_instruction into nios2_tr_translate_insn as the only caller. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 66 +++- 1 file changed, 31 insertions(+), 35 deletions(-) diff --git a/target/nios2/translate.c

[PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction

Signed-off-by: Richard Henderson --- target/nios2/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 6fd4330b31..9e71267b42 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@

[PATCH v3 1/9] target/nios2: Replace DISAS_TB_JUMP with DISAS_NORETURN

The only semantic of DISAS_TB_JUMP is that we've done goto_tb, which is the same as DISAS_NORETURN -- we've exited the tb. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v3 3/9] target/nios2: Use global cpu_R

We do not need to copy this into DisasContext. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 73 +++- 1 file changed, 34 insertions(+), 39 deletions(-) diff --git a/target/nios2/translate.c

[PATCH v3 0/9] target/nios2: Convert to TranslatorOps

I've reached a point where *all* targets must use the translator loop. Do that, plus some other obvious cleanups. Changes for v3: * Improve the commentary on patch 4 (pmm). * Inline handle_instruction. * Use pc_next for pc+4 (pmm). Changes for v2: * Fix (drop) singlestep check for

[PATCH v3 2/9] target/nios2: Use global cpu_env

We do not need to copy this into DisasContext. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/nios2/translate.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index

Re: [PATCH v4 4/8] hw/intc: GICv3 ITS Command processing

Hi Eric, Have taken care of the pending & latest "process_int" comment(below) by renaming it to process_its_cmd to keep it more generic since it is also handles other ITS commands and interrupt trigger both by INT command as well as GITS_TRANSLATER write.Have added comments for this function as

Re: [PATCH v4 3/8] hw/intc: GICv3 ITS command queue framework

Hi Eric, Please find my responses to your latest comments (taken care of) inline:- On Mon, 2021-06-21 at 12:03 +0200, Eric Auger wrote: > > On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > > Hi Eric, > > > > Please find my responses inline (below):- > > > > On Sun, 2021-06-13 at 16:13

[PATCH 1/1] util/uri: do not check argument of uri_free()

uri_free() checks if its argument is NULL in uri_clean() and g_free(). There is no need to check the argument before the call. Signed-off-by: Heinrich Schuchardt --- block/nfs.c | 4 +--- block/ssh.c | 4 +--- capstone| 2 +- util/uri.c | 22 ++ 4 files changed, 9

Re: [PATCH v4 2/8] hw/intc: GICv3 ITS register definitions added

Hi Eric, Have taken care of your latest comment,please find response inline :- On Mon, 2021-06-21 at 11:51 +0200, Eric Auger wrote: > Hi Shashi, > > On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > > Hi Eric, > > > > Please find my responses inline (below):- > > > > On Sat, 2021-06-12

Re: [PATCH 11/11] python: remove auto-generated pyproject.toml file

On 6/25/21 12:45 PM, John Snow wrote: For reasons that at-present escape me, pipenv insists on creating a stub pyproject.toml file. This file is a nuisance, because its mere presence changes the behavior of various tools. For instance, this stub file will cause "pip install --user -e ." to

Re: [PATCH 10/11] python: Update help text on 'make clean', 'make distclean'

On 6/25/21 12:45 PM, John Snow wrote: Just for visual parity with everything else. Signed-off-by: John Snow --- python/Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/python/Makefile b/python/Makefile index 4ed37c29f0..06f78f760a 100644 ---

Re: [PATCH 09/11] python: Update help text on 'make check', 'make develop'

On 6/25/21 12:45 PM, John Snow wrote: Update for visual parity with the other targets. Signed-off-by: John Snow --- python/Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Wainer dos Santos Moschetta diff --git a/python/Makefile b/python/Makefile

Re: [PATCH 08/11] python: add 'make check-venv' invocation

On 6/25/21 12:45 PM, John Snow wrote: This is a *third* way to run the Python tests. Unlike the first two (check-pipenv, check-tox), this version does not require any specific interpreter version -- making it a lot easier to tell people to run it as a quick smoketest prior to submission to

Re: [RFC PATCH 03/11] hw/intc: Add CLIC device

On 2021/6/28 下午10:30, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年6月28日 週一 下午9:03寫道： On 2021/6/28 下午6:16, Frank Chang wrote: LIU Zhiwei mailto:zhiwei_...@c-sky.com>> 於 2021年4月9日 週五 下午3:57寫道： The Core-Local Interrupt Controller (CLIC) provides

Re: QEMU hosting

On 6/20/21 12:14 PM, Thomas Markey wrote: Dear all Would it be possible, may I ask, for the QEMU website to be updated to show that Fosshost is supporting the project? The fosshost logo with a link back to https://fosshost.org will be more than sufficient, or just a

Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers

On 6/28/21 9:33 AM, Philippe Mathieu-Daudé wrote: I don't mind the ordering, just that there's a reason. Is that OK if I reword as: --- We want to extract the microMIPS ISA and Code Compaction ASE to new compilation units. We will first extract this code as included source files (.c.inc),

Re: [PULL 00/10] Block Jobs patches

On Mon, Jun 28, 2021 at 07:19:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 28.06.2021 19:09, Peter Maydell wrote: > > On Fri, 25 Jun 2021 at 14:00, Vladimir Sementsov-Ogievskiy > > wrote: > > > > > > The following changes since commit > > > e0da9171e02f4534124b9a9e0782b38376c6: > > >

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

On Mon, 28 Jun 2021, Akihiko Odaki wrote: 2021年6月28日(月) 17:57 BALATON Zoltan : On Mon, 28 Jun 2021, Akihiko Odaki wrote: This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button

Re: [PATCH 07/11] python: update help text for check-tox

Hi, On 6/25/21 12:45 PM, John Snow wrote: Move it up near the check-pipenv help text, and update it to suggest parity. (At the time I first added it, I wasn't sure if I would be keeping it, but I've come to appreciate it as it has actually helped uncover bugs I would not have noticed without

Re: [PATCH 06/11] python: rename 'venv-check' target to 'check-pipenv'

On 6/25/21 12:45 PM, John Snow wrote: Well, Cleber was right, this is a better name. In preparation for adding a different kind of virtual environment check (One that simply uses whichever version of Python you happen to have), rename this test 'check-pipenv' so that it matches the CI job

Re: [PATCH v7 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

On Mon, Jun 28, 2021 at 02:31:48PM +0200, Emanuele Giuseppe Esposito wrote: > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > docs/devel/testing.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH v7 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

On Mon, Jun 28, 2021 at 02:31:47PM +0200, Emanuele Giuseppe Esposito wrote: > If -gdb and -valgrind are both defined, return an error. > > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 6 +- > 1 file changed, 5

Re: [PATCH 05/11] python: Add no-install usage instructions

On 6/25/21 12:45 PM, John Snow wrote: It's not encouraged, but it's legitimate to want to know how to do. Signed-off-by: John Snow --- python/README.rst | 28 1 file changed, 28 insertions(+) Reviewed-by: Wainer dos Santos Moschetta diff --git

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

On Mon, Jun 28, 2021 at 4:31 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > > On 6/25/21 12:45 PM, John Snow wrote: > > tox is already testing the most recent versions. Let's use pipenv to > > test the oldest versions we claim to support. This matches the stylistic > > choice to

Re: [PATCH 04/11] python: README.rst touchups

On 6/25/21 12:45 PM, John Snow wrote: Clarifying a few points; removing the reference to 'setuptools' because it referenced anywhere else in this document and doesn't really provide any useful information to a Python newcomer. Adjusting the language elsewhere to be less ambiguous and have

Re: [PATCH v2] hw/nvme: fix pin-based interrupt behavior (again)

On Thu, Jun 17, 2021 at 08:55:42PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Jakub noticed[1] that, when using pin-based interrupts, the device will > unconditionally deasssert when any CQEs are acknowledged. However, the > pin should not be deasserted if other completion queues still

Re: [PATCH] hw/nvme: fix missing check for PMR capability

On Mon, Jun 07, 2021 at 11:47:57AM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Qiang Liu reported that an access on an unknown address is triggered in > memory_region_set_enabled because a check on CAP.PMRS is missing for the > PMRCTL register write when no PMR is configured. > > Cc:

Re: [PATCH 03/11] python: Re-lock pipenv at *oldest* supported versions

On 6/25/21 12:45 PM, John Snow wrote: tox is already testing the most recent versions. Let's use pipenv to test the oldest versions we claim to support. This matches the stylistic choice to have pipenv always test our oldest supported Python version, 3.6. Currently tox is testing with 3.6 too.

Re: [PATCH 01/11] python: expose typing information via PEP 561

On Mon, Jun 28, 2021 at 4:12 PM Wainer dos Santos Moschetta < waine...@redhat.com> wrote: > Hi, > > On 6/25/21 12:45 PM, John Snow wrote: > > https://www.python.org/dev/peps/pep-0561/#specification > > Create 'py.typed' files in each subpackage that indicate to mypy that > > this is a typed

Re: [PATCH 02/11] python: Remove global pylint suppressions

On 6/25/21 12:45 PM, John Snow wrote: These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables --

Re: [PATCH 01/11] python: expose typing information via PEP 561

Hi, On 6/25/21 12:45 PM, John Snow wrote: https://www.python.org/dev/peps/pep-0561/#specification Create 'py.typed' files in each subpackage that indicate to mypy that this is a typed module, so that users of any of these packages can use mypy to check their code as well. Note: Theoretically

Re: [PULL 00/10] Block Jobs patches

On Fri, 25 Jun 2021 at 14:00, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit e0da9171e02f4534124b9a9e0782b38376c6: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210624-pull-request' > into staging (2021-06-25 09:10:37 +0100) > > are available in the

Re: [PATCH v4 2/2] tests/tcg: port SYS_HEAPINFO to a system test

On Wed, 23 Jun 2021 at 14:48, Alex Bennée wrote: > > This allows us to check our new SYS_HEAPINFO implementation generates > sane values. > > Signed-off-by: Alex Bennée > --- > tests/tcg/aarch64/system/semiheap.c | 74 + > 1 file changed, 74 insertions(+) > create

Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

On Mon, Jun 28, 2021 at 06:09:10PM +0200, Philippe Mathieu-Daudé wrote: > Avoid accessing QCryptoTLSCreds internals by using > the qcrypto_tls_creds_check_endpoint() helper. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qemu-nbd.c | 19 +++ > 1 file changed, 7 insertions(+),

Re: [PATCH v4 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO

On Wed, 23 Jun 2021 at 14:47, Alex Bennée wrote: > > The previous numbers were a guess at best and rather arbitrary without > taking into account anything that might be loaded. Instead of using > guesses based on the state of registers implement a new function that: > > a) scans the

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

Hi, On 6/24/21 5:27 PM, Philippe Mathieu-Daudé wrote: Test the PMON firmware. As the firmware is not redistributable, it has to be downloaded manually first. Then it can be used by providing its path via the PMON_BIN_PATH environment variable: In the code it is used PMON2E_BIN_PATH. $

Re: [PATCH 4/5] tests/acceptance: Test Linux on the Fuloong 2E machine

On 6/24/21 5:27 PM, Philippe Mathieu-Daudé wrote: Test the kernel from Lemote rescue image: http://dev.lemote.com/files/resource/download/rescue/rescue-yl Once downloaded, set the RESCUE_YL_PATH environment variable to point to the downloaded image and test as: $

Re: [PATCH v2 3/6] block: Clarify that @bytes is no limit on *pnum

> > > +++ b/include/block/block_int.h > > > @@ -347,6 +347,11 @@ struct BlockDriver { > > >    * clamped to bdrv_getlength() and aligned to request_alignment, > > >    * as well as non-NULL pnum, map, and file; in turn, the driver > > >    * must return an error or set pnum to an

Re: [PATCH v7 5/7] virtiofsd: Add capability to change/restore umask

* Vivek Goyal (vgo...@redhat.com) wrote: > On Mon, Jun 28, 2021 at 07:36:18PM +0100, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > On Mon, Jun 28, 2021 at 05:12:13PM +0100, Dr. David Alan Gilbert wrote: > > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > > >

Re: [PATCH v7 5/7] virtiofsd: Add capability to change/restore umask

On Mon, Jun 28, 2021 at 07:36:18PM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > On Mon, Jun 28, 2021 at 05:12:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > > When parent directory has default acl and a file is

Re: [PATCH 06/20] target/loongarch: Add main translation routines

On 6/28/21 2:04 PM, Song Gao wrote: > This patch add main translation routines and > basic functions for translation. > > Signed-off-by: Song Gao > --- > target/loongarch/helper.h| 10 + > target/loongarch/op_helper.c | 28 +++ > target/loongarch/translate.c | 537 >

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

On 6/28/21 9:35 AM, Ulrich Weigand wrote: @@ -506,6 +534,7 @@ uint64_t HELPER(cgeb)(CPUS390XState *env, uint64_t v2, uint32_t m34) { int old_mode = s390_swap_bfp_rounding_mode(env, round_from_m34(m34)); int64_t ret = float32_to_int64(v2, >fpu_status); +env->cc_op =

Re: [PATCH 03/20] target/loongarch: Add core definition

On 6/28/21 2:04 PM, Song Gao wrote: > This patch add target state header,target definitions > and initialization routines. > > Signed-off-by: Song Gao > --- > target/loongarch/cpu-param.h | 21 ++ > target/loongarch/cpu-qom.h | 41 > target/loongarch/cpu.c | 451 >

Re: [PATCH 01/20] target/loongarch: Add README

On 6/28/21 2:04 PM, Song Gao wrote: > This patch give an introduction to the LoongArch target. > > Signed-off-by: Song Gao > --- > MAINTAINERS | 5 + > target/loongarch/README | 16 > 2 files changed, 21 insertions(+) > create mode 100644

Re: [PATCH v7 5/7] virtiofsd: Add capability to change/restore umask

* Vivek Goyal (vgo...@redhat.com) wrote: > On Mon, Jun 28, 2021 at 05:12:13PM +0100, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > When parent directory has default acl and a file is created in that > > > directory, then umask is ignored and final file

Re: [PATCH v7 3/7] virtiofsd: Add support for extended setxattr

* Vivek Goyal (vgo...@redhat.com) wrote: > On Mon, Jun 28, 2021 at 04:49:02PM +0100, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > Add the bits to enable support for setxattr_ext if fuse offers it. Do not > > > enable it by default yet. Let passthrough_ll opt-in.

Re: [PATCH v7 3/7] virtiofsd: Add support for extended setxattr

On Mon, Jun 28, 2021 at 04:49:02PM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > Add the bits to enable support for setxattr_ext if fuse offers it. Do not > > enable it by default yet. Let passthrough_ll opt-in. Enabling it by deafult > > kind of automatically

Re: [PATCH v3 2/3] avocado_qemu: Add SMMUv3 tests

Hi, On 6/21/21 5:08 AM, Eric Auger wrote: Add new tests checking the good behavior of the SMMUv3 protecting 2 virtio pci devices (block and net). We check the guest boots and we are able to install a package. Different guest configs are tested: standard, passthrough an strict=0. This is tested

Re: [PATCH v7 7/7] virtiofsd: Add an option to enable/disable posix acls

* Vivek Goyal (vgo...@redhat.com) wrote: > fuse has an option FUSE_POSIX_ACL which needs to be opted in by fuse > server to enable posix acls. As of now we are not opting in for this, > so posix acls are disabled on virtiofs by default. > > Add virtiofsd option "-o posix_acl/no_posix_acl" to let

Re: [PATCH v7 5/7] virtiofsd: Add capability to change/restore umask

On Mon, Jun 28, 2021 at 05:12:13PM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > When parent directory has default acl and a file is created in that > > directory, then umask is ignored and final file permissions are > > determined using default acl instead.

Re: [PATCH v7 6/7] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

* Vivek Goyal (vgo...@redhat.com) wrote: > When posix access acls are set on a file, it can lead to adjusting file > permissions (mode) as well. If caller does not have CAP_FSETID and it > also does not have membership of owner group, this will lead to clearing > SGID bit in mode. > > Current

Re: [PATCH] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL

On 6/28/21 9:32 AM, Ulrich Weigand wrote: Don't clear out env->fpu_status.float_exception_flags in handle_exceptions. Wait until we're actually done with the data. I don't really know much about qemu internals, but this is really confusing me, sorry. Aren't env->fpu_status and env->cc_op two

Re: [PATCH 15/18] target/arm: Implement MVE long shifts by immediate

On 6/28/21 9:54 AM, Richard Henderson wrote: On 6/28/21 6:58 AM, Peter Maydell wrote:   { +  # The v8.1M MVE shift insns overlap in encoding with MOVS/ORRS +  # and are distinguished by having Rm==13 or 15. Those are UNPREDICTABLE +  # cases for MOVS/ORRS. We decode the MVE cases first,

Re: [PULL 0/7] misc fixes (docs, plugins, tests)

On Fri, 25 Jun 2021 at 10:14, Alex Bennée wrote: > - skip hppa/s390x signals test until fixes arrive FWIW, an intermittent I just saw (x86 host): timeout --foreground 60 /home/petmay01/linaro/qemu-for-merges/build/all-linux-static/qemu-sh4 signals > signals.out qemu: uncaught target signal

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

On Wed, Jun 23, 2021 at 06:04:19PM +0200, Kevin Wolf wrote: > > This is fine, but it means that this flag will present in all ranges, > > instead of only in unallocated ranges (what this patch is doing). > > An argument for always having the flag would be that it's probably > useful for a tool to

Re: [PATCH 18/18] target/arm: Implement MVE shifts by register

On 6/28/21 6:58 AM, Peter Maydell wrote: Implement the MVE shifts by register, which perform shifts on a single general-purpose register. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h | 2 ++ target/arm/translate.h | 1 + target/arm/t32.decode | 5 +

Re: [PATCH] tests: Boot and halt a Linux guest on the Raspberry Pi 2 machine

On Mon, 31 May 2021 at 12:39, Philippe Mathieu-Daudé wrote: > > Add a test booting and quickly shutdown a raspi2 machine, > to test the power management model: > Applied to target-arm.next, thanks. -- PMM

Re: [PATCH v3] Add basic power management to raspi.

On Sat, 26 Jun 2021 at 11:16, Philippe Mathieu-Daudé wrote: > > Hi Nolan, Peter, > > On 6/25/21 11:02 PM, Nolan Leake wrote: > > diff --git hw/arm/bcm2835_peripherals.c hw/arm/bcm2835_peripherals.c > > Odd, usually the diff line comes with a/ b/ prefix, I can not > apply your patch (git version

Re: [PATCH 17/18] target/arm: Implement MVE shifts by immediate

On 6/28/21 6:58 AM, Peter Maydell wrote: + UQSHL_ri 1110101 0010 1 0 ... .. 00 @mve_sh_ri + URSHR_ri 1110101 0010 1 0 ... .. 01 @mve_sh_ri + SRSHR_ri 1110101 0010 1 0 ... .. 10 @mve_sh_ri + SQSHL_ri 1110101 0010 1

Re: [PATCH v7 6/7] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

* Vivek Goyal (vgo...@redhat.com) wrote: > When posix access acls are set on a file, it can lead to adjusting file > permissions (mode) as well. If caller does not have CAP_FSETID and it > also does not have membership of owner group, this will lead to clearing > SGID bit in mode. > > Current

Re: [PATCH v2 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

On Jun 17 21:06, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nvm to allow cancellation. I posted an RFC back in March ("hw/block/nvme: convert ad-hoc aio tracking to aiocb") and I've applied some feedback from Stefan and reimplemented

Re: [PATCH v3 1/2] hw/nvme: fix endianess conversion and add controller list

On Jun 17 11:31, Klaus Jensen wrote: On Jun 14 21:59, Gollu Appalanaidu wrote: Add the controller identifiers list CNS 0x13, available list of ctrls in NVM Subsystem that may or may not be attached to namespaces. In Identify Ctrl List of the CNS 0x12 and 0x13 no endian conversion for the nsid

Re: [PATCH 16/18] target/arm: Implement MVE long shifts by register

On 6/28/21 6:58 AM, Peter Maydell wrote: + LSLL_rr1110101 0010 1 ... 0 ... 1 1101 @mve_shl_rr + ASRL_rr1110101 0010 1 ... 0 ... 1 0010 1101 @mve_shl_rr + UQRSHLL64_rr 1110101 0010 1 ... 1 ... 1 1101 @mve_shl_rr + SQRSHRL64_rr 1110101 0010

Re: [PATCH] tests/qtest/nvme-test: add persistent memory region test

On Jun 18 16:04, Gollu Appalanaidu wrote: This will test the PMR functionality. Signed-off-by: Gollu Appalanaidu --- tests/qtest/nvme-test.c | 78 - 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/tests/qtest/nvme-test.c

  1   2   3   4   >