[PATCH v2] block/nbd.c: Fixed IO request coroutine not being wakeup when kill NBD server

2022-03-08 Thread Rao Lei
During the IO stress test, the IO request coroutine has a probability that is can't be awakened when the NBD server is killed. The GDB stack is as follows: (gdb) bt 0 0x7f2ff990cbf6 in __ppoll (fds=0x55575de85000, nfds=1, timeout=, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:44 1

Re: [PATCH v5 00/15] vDPA shadow virtqueue

2022-03-08 Thread Jason Wang
On Wed, Mar 9, 2022 at 3:30 PM Michael S. Tsirkin wrote: > On Wed, Mar 09, 2022 at 11:38:35AM +0800, Jason Wang wrote: > > > > 在 2022/3/8 下午8:16, Michael S. Tsirkin 写道: > > > On Tue, Mar 08, 2022 at 12:37:33PM +0100, Eugenio Perez Martin wrote: > > > > On Tue, Mar 8, 2022 at 11:48 AM Michael S.

Re: [PATCH] block/nbd.c: Fixed IO request coroutine not being wakeup when kill NBD server.

2022-03-08 Thread Rao, Lei
On 3/3/2022 10:05 PM, Rao, Lei wrote: On 3/3/2022 5:25 PM, Vladimir Sementsov-Ogievskiy wrote: 03.03.2022 05:21, Rao Lei wrote: During the stress test, the IO request coroutine has a probability that it can't be awakened when the NBD server is killed. The GDB statck is as follows: (gdb)

Re: [PATCH v5 00/15] vDPA shadow virtqueue

2022-03-08 Thread Michael S. Tsirkin
On Wed, Mar 09, 2022 at 11:38:35AM +0800, Jason Wang wrote: > > 在 2022/3/8 下午8:16, Michael S. Tsirkin 写道: > > On Tue, Mar 08, 2022 at 12:37:33PM +0100, Eugenio Perez Martin wrote: > > > On Tue, Mar 8, 2022 at 11:48 AM Michael S. Tsirkin > > > wrote: > > > > On Tue, Mar 08, 2022 at 04:20:53PM

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
On Tue, 8 Mar 2022, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 8 Mar 2022, Laine

Re: [PATCH 2/2] hw/arm/virt: Fix gic-version=max when CONFIG_ARM_GICV3_TCG is unset

2022-03-08 Thread Andrew Jones
On Tue, Mar 08, 2022 at 07:24:52PM +0100, Eric Auger wrote: > In TCG mode, if gic-version=max we always select GICv3 even if > CONFIG_ARM_GICV3_TCG is unset. We shall rather select GICv2. > This also brings the benefit of fixing qos tests errors for tests > using gic-version=max with

Re: [PATCH 1/2] hw/intc: Rename CONFIG_ARM_GIC_TCG into CONFIG_ARM_GICV3_TCG

2022-03-08 Thread Andrew Jones
On Tue, Mar 08, 2022 at 07:24:51PM +0100, Eric Auger wrote: > CONFIG_ARM_GIC_TCG actually guards the compilation of TCG GICv3 > specific files. So let's rename it into CONFIG_ARM_GICV3_TCG > > Signed-off-by: Eric Auger > --- > hw/intc/Kconfig | 2 +- > hw/intc/meson.build | 4 ++-- > 2

Re: [PATCH 5/5] avocado/replay_kernel.py: make tcg-icount check in run_vm()

2022-03-08 Thread Pavel Dovgalyuk
On 07.03.2022 11:47, Cédric Le Goater wrote: On 3/3/22 16:35, Daniel Henrique Barboza wrote: The icount framework relies on TCG availability. If QEMU is built with --disable-tcg we won't have icount either, and then this test will fail with the following message in an IBM POWER9 host:

[PATCH 13/14] iotests: make qemu_img_log() check log level

2022-03-08 Thread John Snow
Improve qemu_img_log() to actually check if logging is turned on. If it isn't, revert to the behavior of qemu_img(). This is done so that there really is no way to avoid scrutinizing qemu-ing subprocess calls by accident. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 19

[PATCH 12/14] iotests: remove qemu_img_pipe_and_status()

2022-03-08 Thread John Snow
With the exceptional 'create' calls removed in the prior commit, change qemu_img_log() and img_info_log() to call qemu_img() directly instead. In keeping with the spirit of diff-based tests, allow these calls to qemu_img() to return an unchecked non-zero status code -- because any error we'd see

[PATCH 11/14] iotests: replace qemu_img_log('create', ...) calls

2022-03-08 Thread John Snow
qemu_img_log() calls into qemu_img_pipe(), which always removes output for 'create' commands on success anyway. Replace all of these calls to the simpler qemu_img_create(...) which doesn't log, but raises a detailed exception object on failure instead. Blank lines are removed from output files

[PATCH 14/14] iotests: make img_info_log() call qemu_img_log()

2022-03-08 Thread John Snow
Add configurable filters to qemu_img_log(), and re-write img_info_log() to call into qemu_img_log() with a custom filter instead. After this patch, every last call to qemu_img() is now guaranteed to either have its return code checked for zero, OR have its output actually visibly logged

[PATCH 08/14] iotests/149: Remove qemu_img_pipe() call

2022-03-08 Thread John Snow
qemu_img_pipe calls blank their output when the command being run is a 'create' call and the command succeeds. Thus, the normative output for this command in iotest 149 is to print a blank line. We can remove the logging from this invocation and use a checked invocation, but we still need to

[PATCH 06/14] iotests: change supports_quorum to use qemu_img

2022-03-08 Thread John Snow
Similar to other recent changes: use the qemu_img() invocation that supports throwing loud, nasty exceptions when it fails for surprising reasons. (Why would "--help" ever fail? I don't know, but eliminating *all* calls to qemu-img that do not go through qemu_img() is my goal, so qemu_img_pipe()

[PATCH 10/14] iotests: use qemu_img() in has_working_luks()

2022-03-08 Thread John Snow
Admittedly a mostly lateral move, but qemu_img() is essentially the replacement for qemu_img_pipe_and_status(). It will give slightly better diagnostics on crash. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH 07/14] iotests: replace unchecked calls to qemu_img_pipe()

2022-03-08 Thread John Snow
qemu_img_pipe() discards the return code from qemu-img in favor of returning just its output. Some tests using this function don't save, log, or check the output either, though, which is unsafe. Replace all of these calls with a checked version. Tests affected are 194, 202, 203, 234, 262, and

[PATCH 09/14] iotests: remove remaining calls to qemu_img_pipe()

2022-03-08 Thread John Snow
As part of moving all python iotest invocations of qemu-img onto a single qemu_img() implementation, remove a few lingering uses of qemu_img_pipe() from outside of iotests.py itself. Several cases here rely on the knowledge that qemu_img_pipe() suppresses *all* output on a successful case when

[PATCH 02/14] iotests: use qemu_img_json() when applicable

2022-03-08 Thread John Snow
qemu_img_json() gives better diagnostic information on failure. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 546b142a6c..7b37938d45

[PATCH 03/14] iotests: add qemu_img_info()

2022-03-08 Thread John Snow
Add qemu_img_info() by analogy with qemu_img_measure() and qemu_img_check(). Modify image_size() to use this function instead to take advantage of the better diagnostic information on failure provided (ultimately) by qemu_img(). Signed-off-by: John Snow --- tests/qemu-iotests/065| 5

[PATCH 04/14] iotests/remove-bitmap-from-backing: use qemu_img_info()

2022-03-08 Thread John Snow
This removes two more usages of qemu_img_pipe() and replaces them with calls to qemu_img(), which provides better diagnostic information on failure. Signed-off-by: John Snow --- tests/qemu-iotests/tests/remove-bitmap-from-backing | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 01/14] iotests: add qemu_img_json()

2022-03-08 Thread John Snow
qemu_img_json() is a new helper built on top of qemu_img() that tries to pull a valid JSON document out of the stdout stream. In the event that the return code is negative (the program crashed), or the code is greater than zero and did not produce valid JSON output, the VerboseProcessError raised

[PATCH 05/14] iotests: add qemu_img_map() function

2022-03-08 Thread John Snow
Add a qemu_img_map() function by analogy with qemu_img_measure(), qemu_img_check(), and qemu_img_info() that all return JSON information. Replace calls to qemu_img_pipe('map', '--output=json', ...) with this new function, which provides better diagnostic information on failure. Signed-off-by:

[PATCH 00/14] iotests: ensure all qemu-img calls are either checked or logged

2022-03-08 Thread John Snow
Based-On: 20220308015728.1269649-1-js...@redhat.com Hi, this series ensures all calls to qemu-img ultimately go through qemu_img(). After the previous series, qemu_img() is a function that defaults to raising a VerboseProcessError exception when qemu-img returns a non-zero exit code. After this

Re: TCG Floating Point Support (Work in Progress)

2022-03-08 Thread gaosong
 On 2021/10/2 上午10:07, Matt wrote: Not at the moment but it would certainly be a useful addition for the unit tests if we could test arbitrary sequences of TCG ops. I'm not sure how much test harness would be needed to exercise that though. On a related note, in addition to testing TCG->Host

Re: [PATCH v5 00/15] vDPA shadow virtqueue

2022-03-08 Thread Jason Wang
在 2022/3/8 下午8:16, Michael S. Tsirkin 写道: On Tue, Mar 08, 2022 at 12:37:33PM +0100, Eugenio Perez Martin wrote: On Tue, Mar 8, 2022 at 11:48 AM Michael S. Tsirkin wrote: On Tue, Mar 08, 2022 at 04:20:53PM +0800, Jason Wang wrote: Not by itself but I'm not sure we can guarantee guest will

[RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

2022-03-08 Thread Fabiano Rosas
QEMU reports MMU support to the guest via the ibm,architecture-vec-5 property of the /chosen node. Byte number 26 specifies Radix Table Expansions, currently only GTSE (Guest Translation Shootdown Enable). This feature determines whether the tlbie instruction (and others) are HV privileged. Up

[RFC PATCH 2/2] linux-headers: Add KVM_CAP_PPC_GTSE

2022-03-08 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- This is here just to facilitate review/testing of the feature. --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 00af3bc333..15f19fd958 100644 ---

[PATCH v4] target/riscv: Add isa extenstion strings to the device tree

2022-03-08 Thread Atish Patra
The Linux kernel parses the ISA extensions from "riscv,isa" DT property. It used to parse only the single letter base extensions until now. A generic ISA extension parsing framework was proposed[1] recently that can parse multi-letter ISA extensions as well. Generate the extended ISA string by

Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-08 Thread Joel Stanley
On Tue, 8 Mar 2022 at 17:23, Patrick Williams wrote: > > On Tue, Mar 08, 2022 at 09:14:07AM +0100, Cédric Le Goater wrote: > > > > >> There are two flash devices on the FMC. I can fix it inline since > > >> it is the only change I would request. > > > > > > Yes, there are. I think all of the

Re: [PATCH v3] target/riscv: Add isa extenstion strings to the device tree

2022-03-08 Thread Atish Patra
On Sat, Mar 5, 2022 at 10:43 PM Frank Chang wrote: > > On Sun, Mar 6, 2022 at 2:12 PM Atish Kumar Patra wrote: >> >> >> >> On Sat, Mar 5, 2022 at 9:36 PM Frank Chang wrote: >>> >>> On Sun, Mar 6, 2022 at 7:42 AM Atish Kumar Patra >>> wrote: On Sat, Mar 5, 2022 at 10:05 AM

Re: [PATCH 04/11] edk2: .git can be a file

2022-03-08 Thread Eric Blake
On Tue, Mar 08, 2022 at 03:55:14PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > roms/Makefile.edk2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2 > index 3d75a842a4df..a669019fe5b2 100644 > ---

Re: [PATCH v3] target/riscv: Add isa extenstion strings to the device tree

2022-03-08 Thread Atish Patra
On Tue, Mar 8, 2022 at 2:53 PM Atish Patra wrote: > > On Sat, Mar 5, 2022 at 10:43 PM Frank Chang wrote: > > > > On Sun, Mar 6, 2022 at 2:12 PM Atish Kumar Patra > > wrote: > >> > >> > >> > >> On Sat, Mar 5, 2022 at 9:36 PM Frank Chang wrote: > >>> > >>> On Sun, Mar 6, 2022 at 7:42 AM Atish

Re: [PATCH v3] target/riscv: Add isa extenstion strings to the device tree

2022-03-08 Thread Atish Patra
On Sat, Mar 5, 2022 at 10:47 PM Frank Chang wrote: > > Typo in patch title: > s/extenstion/extension/g > Thanks for catching it. Will fix it. > Regards, > Frank Chang > > On Sat, Feb 26, 2022 at 3:45 PM Frank Chang wrote: >> >> >> >> Atish Patra 於 2022年2月23日 週三 上午6:39寫道: >>> >>> The Linux

Re: [RFC PATCH 1/3] target/riscv: Rename timer & timecmp to mtimer and mtimecmp

2022-03-08 Thread Atish Patra
On Tue, Mar 8, 2022 at 1:33 PM Alistair Francis wrote: > > On Fri, Mar 4, 2022 at 2:08 PM Anup Patel wrote: > > > > On Fri, Mar 4, 2022 at 8:50 AM Atish Patra wrote: > > > > > > Currently, the aclint and ibex timer devices uses the "timer" & > > > "timecmp" to generate the m-mode timer

Re: [PULL 00/11] Python patches

2022-03-08 Thread Peter Maydell
On Mon, 7 Mar 2022 at 22:15, John Snow wrote: > > The following changes since commit b49872aa8fc0f3f5a3036cc37aa2cb5c92866f33: > > Merge remote-tracking branch > 'remotes/hreitz-gitlab/tags/pull-block-2022-03-07' into staging (2022-03-07 > 17:14:09 +) > > are available in the Git

[PULL 00/12] Hexagon (target/hexagon) queue

2022-03-08 Thread Taylor Simpson
-20220308 for you to fetch changes up to ebbf0ee1335548fe9b42fcd1ff031aea2d27cc1a: target/hexagon: remove unused variable (2022-03-08 13:27:00 -0800) Hexagon bug fixes and additional tests Also includes a patch from Zongyuan Li

[PULL 01/12] Hexagon (target/hexagon) fix bug in circular addressing

2022-03-08 Thread Taylor Simpson
From: Michael Lambert Versions V3 and earlier should treat the "K_const" and "length" values as unsigned. Modified circ_test_v3() in tests/tcg/hexagon/circ.c to reproduce the bug Signed-off-by: Michael Lambert Signed-off-by: Taylor Simpson Message-Id:

[PULL 03/12] Hexagon (target/hexagon) properly set FPINVF bit in sfcmp.uo and dfcmp.uo

2022-03-08 Thread Taylor Simpson
Instead of checking for nan arguments, use float??_unordered_quiet test cases added in a subsequent patch to more extensively test USR bits Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-4-tsimp...@quicinc.com> Reviewed-by: Richard Henderson --- target/hexagon/op_helper.c | 6

[PULL 05/12] Hexagon (target/hexagon) properly handle NaN in dfmin/dfmax/sfmin/sfmax

2022-03-08 Thread Taylor Simpson
The float??_minnum implementation differs from Hexagon for SNaN, it returns NaN, but Hexagon returns the other input. So, we use float??_minimum_number. Test cases added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson Message-Id: <20220308190410.22355-1-tsimp...@quicinc.com>

[PULL 02/12] Hexagon HVX (target/hexagon) fix bug in HVX saturate instructions

2022-03-08 Thread Taylor Simpson
Two tests added to tests/tcg/hexagon/hvx_misc.c v21.uw = vadd(v11.uw, v10.uw):sat v25:24.uw = vsub(v17:16.uw, v27:26.uw):sat Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-3-tsimp...@quicinc.com> Reviewed-by: Richard Henderson --- target/hexagon/macros.h | 4 +-

[PULL 11/12] Hexagon (target/hexagon) assignment to c4 should wait until packet commit

2022-03-08 Thread Taylor Simpson
On Hexagon, c4 is an alias for predicate registers P3:0. If we assign to c4 inside a packet with reads from predicate registers, the predicate reads should get the old values. Test case added to tests/tcg/hexagon/preg_alias.c Co-authored-by: Michael Lambert Signed-off-by: Taylor Simpson

[PULL 07/12] Hexagon (tests/tcg/hexagon) add floating point instructions to usr.c

2022-03-08 Thread Taylor Simpson
Tests to confirm floating point instructions are properly setting exception bits in USR Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-8-tsimp...@quicinc.com> Acked-by: Richard Henderson --- tests/tcg/hexagon/usr.c | 339 1 file changed,

[PULL 09/12] Hexagon (tests/tcg/hexagon) fix inline asm in preg_alias.c

2022-03-08 Thread Taylor Simpson
Replace consecutive inline asm blocks with a single one with proper outputs/inputs/clobbers rather than making assumptions about register values being carried between separate blocks. Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-10-tsimp...@quicinc.com> Reviewed-by: Richard

[PULL 08/12] Hexagon (tests/tcg/hexagon) update overflow test

2022-03-08 Thread Taylor Simpson
Add a test that sets USR multiple times in a packet Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-9-tsimp...@quicinc.com> Acked-by: Richard Henderson --- tests/tcg/hexagon/overflow.c | 61 +++- 1 file changed, 60 insertions(+), 1 deletion(-)

[PULL 10/12] Hexagon (target/hexagon) fix bug in conv_df2uw_chop

2022-03-08 Thread Taylor Simpson
Fix typo that checked for 32 bit nan instead of 64 bit Test case added in tests/tcg/hexagon/usr.c Signed-off-by: Taylor Simpson Message-Id: <20220210021556.9217-11-tsimp...@quicinc.com> Reviewed-by: Richard Henderson --- target/hexagon/op_helper.c | 2 +- tests/tcg/hexagon/usr.c| 4

[PULL 12/12] target/hexagon: remove unused variable

2022-03-08 Thread Taylor Simpson
From: Zongyuan Li When building with clang version 13.0.0 (eg. Fedora 13.0.0-3.fc35), two unused variables introduced by macro GATHER_FUNCTION and SCATTER_FUNCTION will cause building process failure due to [-Werror -Wunused-variable]. Signed-off-by: Zongyuan Li Resolves:

[PULL 04/12] Hexagon (target/hexagon) properly handle denorm in arch_sf_recip_common

2022-03-08 Thread Taylor Simpson
The arch_sf_recip_common function was calling float32_getexp which adjusts for denorm, but the we actually need the raw exponent bits. This function is called from 3 instructions sfrecipa sffixupn sffixupd Test cases added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson

[PULL 06/12] Hexagon (tests/tcg/hexagon) test instructions that might set bits in USR

2022-03-08 Thread Taylor Simpson
Hexagon has ~200 instructions that set the saturate bit in USR, these were broken into groups of similar instructions and one instruction from each group is tested with at least one input that does not saturate and at least one input that does saturate. Signed-off-by: Taylor Simpson Message-Id:

Re: [RFC PATCH 1/3] target/riscv: Rename timer & timecmp to mtimer and mtimecmp

2022-03-08 Thread Alistair Francis
On Fri, Mar 4, 2022 at 2:08 PM Anup Patel wrote: > > On Fri, Mar 4, 2022 at 8:50 AM Atish Patra wrote: > > > > Currently, the aclint and ibex timer devices uses the "timer" & > > "timecmp" to generate the m-mode timer interrupt. In future, > > we will have timer interrupt injected to S/VS mode

Re: [PATCH] hw/dma/xlnx_csu_dma: Set TYPE_XLNX_CSU_DMA class_size

2022-03-08 Thread Alistair Francis
On Wed, Mar 9, 2022 at 1:07 AM Peter Maydell wrote: > > In commit 00f05c02f9e7342f we gave the TYPE_XLNX_CSU_DMA object its > own class struct, but forgot to update the TypeInfo::class_size > accordingly. This meant that not enough memory was allocated for the > class struct, and the

Re: [PATCH v4 22/33] target/nios2: Introduce dest_gpr

2022-03-08 Thread Richard Henderson
On 3/8/22 01:07, Peter Maydell wrote: I assume the TCG dead-code elimination will mostly throw away the write-to-R_ZERO stuff, but here for rdctl I suspect it won't. I believe it will. We don't indicate that normal load has side effects (as opposed to guest load), so it should all fall out

Re: [PATCH v4 17/33] target/nios2: Prevent writes to read-only or reserved control fields

2022-03-08 Thread Richard Henderson
On 3/8/22 10:24, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: Create an array of masks which detail the writable and readonly bits for each control register. Apply them when writing to control registers. Signed-off-by: Richard Henderson diff --git

Re: [PATCH v4 17/33] target/nios2: Prevent writes to read-only or reserved control fields

2022-03-08 Thread Peter Maydell
On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: > > Create an array of masks which detail the writable and readonly > bits for each control register. Apply them when writing to > control registers. > > Signed-off-by: Richard Henderson > diff --git a/target/nios2/cpu.c

Re: [PATCH v4 33/33] hw/nios2: Machine with a Vectored Interrupt Controller

2022-03-08 Thread Richard Henderson
On 3/7/22 22:43, Mark Cave-Ayland wrote: +    qdev_realize(DEVICE(cpu), NULL, _fatal); +    object_unref(CPU(cpu)); I believe this can be replaced with qdev_realize_and_unref()? Oh, nice. I copied this from hw/arm/virt, which has code between these two points. +    if (nms->vic) { +  

Re: [PATCH v4 31/33] hw/nios2: Introduce Nios2MachineState

2022-03-08 Thread Richard Henderson
On 3/7/22 22:39, Mark Cave-Ayland wrote:   static void nios2_10m50_ghrd_init(MachineState *machine)   { +    Nios2MachineState *nms = NIOS2_MACHINE(machine);   Nios2CPU *cpu;   DeviceState *dev;   MemoryRegion *address_space_mem = get_system_memory(); @@ -101,15 +109,29 @@ static

Re: [PATCH v4 30/33] hw/intc: Vectored Interrupt Controller (VIC)

2022-03-08 Thread Richard Henderson
On 3/8/22 01:27, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: From: Amir Gonnen Implement nios2 Vectored Interrupt Controller (VIC). VIC is connected to EIC. It needs to update rha, ril, rrs and rnmi fields on Nios2CPU before raising an IRQ. For that purpose,

Re: [PATCH v4 18/33] target/nios2: Implement cpuid

2022-03-08 Thread Richard Henderson
On 3/8/22 00:52, Peter Maydell wrote: I guess. This will have no effect as all our nios2 boards are single-CPU. Reviewed-by: Peter Maydell Oh, fair enough. I didn't even think of that (even though I've just spent quite a bit of time on interrupts, and there's no sign of an inter-processor

Re: [PATCH v4 21/33] target/nios2: Use tcg_constant_tl

2022-03-08 Thread Richard Henderson
On 3/8/22 01:00, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: Replace current uses of tcg_const_tl, and remove the frees. Signed-off-by: Richard Henderson --- @@ -675,8 +663,8 @@ static void divu(DisasContext *dc, uint32_t code, uint32_t flags) TCGv

Re: [PATCH v4 17/33] target/nios2: Prevent writes to read-only or reserved control fields

2022-03-08 Thread Richard Henderson
On 3/8/22 00:57, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: Create an array of masks which detail the writable and readonly bits for each control register. Apply them when writing to control registers. Signed-off-by: Richard Henderson What's the

Re: [PATCH v4 12/33] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields

2022-03-08 Thread Richard Henderson
On 3/8/22 00:12, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: Sink the set of env->exception to the end of nios2_cpu_do_interrupt. This splits the two things the patch is doing between the subject line and the commit message body; the subject is supposed to be

Re: [PATCH v4 15/33] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields

2022-03-08 Thread Richard Henderson
On 3/8/22 00:46, Peter Maydell wrote: @@ -130,24 +128,25 @@ void helper_mmu_write_tlbacc(CPUNios2State *env, uint32_t v) void helper_mmu_write_tlbmisc(CPUNios2State *env, uint32_t v) { Nios2CPU *cpu = env_archcpu(env); +uint32_t new_pid = FIELD_EX32(v, CR_TLBMISC, PID); +

Re: [PATCH v4 11/33] target/nios2: Use hw/registerfields.h for CR_STATUS fields

2022-03-08 Thread Richard Henderson
On 3/8/22 00:08, Peter Maydell wrote: +#define CR_STATUS_RSIE (1u << R_CR_STATUS_RSIE_SHIFT) Since these are all 1 bit fields you can use #define CR_STATUS_PIE R_CR_STATUS_PIE_MASK etc rather than manually shifting by the shift count. Quite right, thanks. r~

Re: [PATCH v4 07/33] linux-user/nios2: Trim target_pc_regs to sp and pc

2022-03-08 Thread Richard Henderson
On 3/8/22 00:00, Peter Maydell wrote: On Tue, 8 Mar 2022 at 07:20, Richard Henderson wrote: The only thing this struct is used for is passing startup values from elfload.c to the cpu. We do not need all registers to be represented, we do not need the kernel internal stack slots. The

Re: [PULL 0/7] s390x, tests and misc patches

2022-03-08 Thread Peter Maydell
On Mon, 7 Mar 2022 at 18:26, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305' into > staging (2022-03-05 18:03:15 +) > > are available in the Git

Re: [PATCH v4] Hexagon (target/hexagon) properly handle NaN in dfmin/dfmax/sfmin/sfmax

2022-03-08 Thread Richard Henderson
On 3/8/22 09:04, Taylor Simpson wrote: The float??_minnum implementation differs from Hexagon for SNaN, it returns NaN, but Hexagon returns the other input. So, we use float??_minimum_number. Test cases added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson ---

Re: [PATCH] tests/avocado: Cancel BootLinux tests in case there is no free port

2022-03-08 Thread Thomas Huth
On 07/03/2022 19.48, Daniel P. Berrangé wrote: On Mon, Mar 07, 2022 at 07:31:50PM +0100, Thomas Huth wrote: On 07/03/2022 13.50, Daniel P. Berrangé wrote: On Mon, Feb 28, 2022 at 12:43:25PM +0100, Thomas Huth wrote: The BootLinux tests are currently failing with an ugly python stack trace on

[PATCH v4] Hexagon (target/hexagon) properly handle NaN in dfmin/dfmax/sfmin/sfmax

2022-03-08 Thread Taylor Simpson
The float??_minnum implementation differs from Hexagon for SNaN, it returns NaN, but Hexagon returns the other input. So, we use float??_minimum_number. Test cases added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 14 ++-

Re: [PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init()

2022-03-08 Thread Hao Wu
On Tue, Mar 8, 2022 at 10:09 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 3/8/22 07:03, Peter Maydell wrote: > > In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). > > Use g_autofree so we free it rather than leaking it. > > > > (Detected with the clang

Re: [PULL 00/18] migration queue

2022-03-08 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (philippe.mathieu.da...@gmail.com) wrote: > On 3/3/22 15:46, Peter Maydell wrote: > > On Wed, 2 Mar 2022 at 18:32, Dr. David Alan Gilbert (git) > > wrote: > > > > > > From: "Dr. David Alan Gilbert" > > > > > > The following changes since commit > > >

Re: [PULL 00/18] migration queue

2022-03-08 Thread Philippe Mathieu-Daudé
On 3/3/22 15:46, Peter Maydell wrote: On Wed, 2 Mar 2022 at 18:32, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The following changes since commit 64ada298b98a51eb2512607f6e6180cb330c47b1: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220302' into

Re: [PATCH 07/13] hw/mips/gt64xxx_pci: Resolve gt64120_register()

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow Now that gt64120_register() lost its pic parameter, there is an opportunity to remove it. gt64120_register() is old style by wrapping qdev API, and the new style is to use qdev directly. So take the opportunity and modernize

[PATCH 2/2] hw/arm/virt: Fix gic-version=max when CONFIG_ARM_GICV3_TCG is unset

2022-03-08 Thread Eric Auger
In TCG mode, if gic-version=max we always select GICv3 even if CONFIG_ARM_GICV3_TCG is unset. We shall rather select GICv2. This also brings the benefit of fixing qos tests errors for tests using gic-version=max with CONFIG_ARM_GICV3_TCG unset. Signed-off-by: Eric Auger --- v2 -> v3: - Use

[PATCH 0/2] hw/arm/virt: Fix make check-qtest-aarch64 when CONFIG_ARM_GIC_TCG is unset

2022-03-08 Thread Eric Auger
When CONFIG_ARM_GIC_TCG is unset, qtests fail with ERROR:../qom/object.c:715:object_new_with_type: assertion failed: (type != NULL) This is due to the fact a bunch tests use gic-version=max which currectly unconditionally selects GICv3, ignoring the fact this latter may have been disabled. This

[PATCH 1/2] hw/intc: Rename CONFIG_ARM_GIC_TCG into CONFIG_ARM_GICV3_TCG

2022-03-08 Thread Eric Auger
CONFIG_ARM_GIC_TCG actually guards the compilation of TCG GICv3 specific files. So let's rename it into CONFIG_ARM_GICV3_TCG Signed-off-by: Eric Auger --- hw/intc/Kconfig | 2 +- hw/intc/meson.build | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/intc/Kconfig

Re: [PATCH 06/13] hw/isa/piix4: Replace some magic IRQ constants

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx_pci to piix4". gt64xxx_pci used magic constants, and probably didn't want to use piix4-specific constants. Now that the interrupt handing resides

[PULL 5/9] hw/i2c: pmbus: update MAINTAINERS

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare add self to MAINTAINERS for the PMBus subsystem and related sensors, and set PMBus as maintained. Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-6-tit...@google.com> Signed-off-by: Philippe

Re: [PATCH 04/13] hw/isa/piix4: Pass PIIX4State as opaque parameter for piix4_set_irq()

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow Passing PIIX4State rather than just the qemu_irq allows for resolving the global piix4_dev variable. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin

[PULL 4/9] hw/i2c: pmbus: refactor uint handling

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare This change cleans up the inputs to pmbus_receive uint, the length of received data is contained in PMBusDevice state and doesn't need to be passed around. Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id:

Re: [PATCH 05/13] hw/isa/piix4: Resolve global instance variable

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow Now that piix4_set_irq's opaque parameter references own PIIX4State, piix4_dev becomes redundant. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin

[PULL 0/9] I²C / SMBus / PMBus patches for 2022-03-08

2022-03-08 Thread Philippe Mathieu-Daudé
/philmd/qemu.git tags/pmbus-20220308 for you to fetch changes up to 5f14cd7032beab6cac8d7ed1b09efc58baddb48c: hw/sensor: add Renesas raa228000 device (2022-03-08 18:46:48 +0100) I²C / SMBus / PMBus patches - Add some Renesas models

Re: [PATCH 03/13] hw/isa/piix4: Resolve redundant i8259[] attribute

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx_pci to piix4" where i8259[] was moved from MaltaState to PIIX4State to make the code movement more obvious. However, i8259[] seems redundant to

[PULL 7/9] hw/sensor: add Intersil ISL69260 device model

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-8-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 + hw/arm/Kconfig

Re: [PATCH 01/13] hw/mips/gt64xxx_pci: Fix PCI IRQ levels to be preserved during migration

2022-03-08 Thread Richard Henderson
On 3/7/22 03:43, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow Based on commit e735b55a8c11dd455e31ccd4420e6c9485191d0c: piix_pci: eliminate PIIX3State::pci_irq_levels PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. The

[PULL 6/9] hw/i2c: Added linear mode translation for pmbus devices

2022-03-08 Thread Philippe Mathieu-Daudé
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-7-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 18 ++

[PULL 9/9] hw/sensor: add Renesas raa228000 device

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-10-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/sensor/isl_pmbus_vr.c | 50

[PULL 3/9] hw/i2c: pmbus: add PEC unsupported warning

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare Signed-off-by: Titus Rwantare Acked-by: Corey Minyard Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220307200605.4001451-4-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PULL 8/9] hw/sensor: add Renesas raa229004 PMBus device

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare The Renesas RAA229004 is a PMBus Multiphase Voltage Regulator Signed-off-by: Titus Rwantare Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-9-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé

[PULL 2/9] hw/i2c: pmbus: fix error returns and guard against out of range accesses

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-3-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c | 47 ---

[PULL 1/9] hw/i2c: pmbus: add registers

2022-03-08 Thread Philippe Mathieu-Daudé
From: Titus Rwantare - add the VOUT_MIN and STATUS_MFR registers Signed-off-by: Titus Rwantare Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-Id: <20220307200605.4001451-2-tit...@google.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pmbus_device.c |

Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

2022-03-08 Thread Patrick Williams
On Tue, Mar 08, 2022 at 09:14:07AM +0100, Cédric Le Goater wrote: > > >> There are two flash devices on the FMC. I can fix it inline since > >> it is the only change I would request. > > > > Yes, there are. I think all of the Facebook systems have dual FMC, for > > redundancy in hardware, but

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily,

2022-03-08 Thread Philippe Mathieu-Daudé
On 8/3/22 14:53, Corey Minyard wrote: On Mon, Mar 07, 2022 at 01:00:02AM +0100, Philippe Mathieu-Daudé wrote: On 5/3/22 00:42, Titus Rwantare wrote: On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote: On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote: v2: - split PMBus

Re: [PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init()

2022-03-08 Thread Richard Henderson
On 3/8/22 07:03, Peter Maydell wrote: In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). Use g_autofree so we free it rather than leaking it. (Detected with the clang leak sanitizer.) Signed-off-by: Peter Maydell --- hw/misc/npcm7xx_clk.c | 4 ++-- 1 file changed, 2

Re: [qemu-web PATCH] Announce Google Summer of Code 2022

2022-03-08 Thread Thomas Huth
On 08/03/2022 17.15, Stefan Hajnoczi wrote: QEMU has been accepted into Google Summer of Code 2022. Let people know so they can apply! Signed-off-by: Stefan Hajnoczi --- _posts/2022-03-07-gsoc-2022.md | 35 ++ 1 file changed, 35 insertions(+) create mode

Re: [PATCH v3] target/arm: Fix sve2 ldnt1 and stnt1

2022-03-08 Thread Richard Henderson
On 3/8/22 01:56, Peter Maydell wrote: -# SVE2 64-bit gather non-temporal load -# (scalar plus unpacked 32-bit unscaled offsets) +# SVE2 64-bit gather non-temporal load (scalar plus 64-bit unscaled offsets) LDNT1_zprz 1100010 msz:2 00 rm:5 1 u:1 0 pg:3 rn:5 rd:5 \ -

Re: [PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init()

2022-03-08 Thread Philippe Mathieu-Daudé
On 8/3/22 18:03, Peter Maydell wrote: In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). Use g_autofree so we free it rather than leaking it. (Detected with the clang leak sanitizer.) Signed-off-by: Peter Maydell --- hw/misc/npcm7xx_clk.c | 4 ++-- 1 file changed, 2

Re: [PATCH] hw/dma/xlnx_csu_dma: Set TYPE_XLNX_CSU_DMA class_size

2022-03-08 Thread Philippe Mathieu-Daudé
On 8/3/22 16:02, Peter Maydell wrote: In commit 00f05c02f9e7342f we gave the TYPE_XLNX_CSU_DMA object its own class struct, but forgot to update the TypeInfo::class_size accordingly. This meant that not enough memory was allocated for the class struct, and the initialization of xcdc->read in

Re: [PULL 00/18] target-arm queue

2022-03-08 Thread Peter Maydell
On Mon, 7 Mar 2022 at 16:47, Peter Maydell wrote: > > Last lot of target-arm stuff: cleanups, bug fixes; nothing major here. > > -- PMM > > The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305'

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin wrote: > > > > On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 8 Mar 2022, Laine Stump wrote: > > > > > > > Aha! the domain of qemu-devel@nongnu.org

Re: [PATCH v3 3/5] iotests: Remove explicit checks for qemu_img() == 0

2022-03-08 Thread John Snow
On Tue, Mar 8, 2022, 10:16 AM Eric Blake wrote: > On Mon, Mar 07, 2022 at 08:57:26PM -0500, John Snow wrote: > > qemu_img() returning zero ought to be the rule, not the > > exception. Remove all explicit checks against the condition in > > preparation for making non-zero returns an Exception. >

[PATCH] hw/misc/npcm7xx_clk: Don't leak string in npcm7xx_clk_sel_init()

2022-03-08 Thread Peter Maydell
In npcm7xx_clk_sel_init() we allocate a string with g_strdup_printf(). Use g_autofree so we free it rather than leaking it. (Detected with the clang leak sanitizer.) Signed-off-by: Peter Maydell --- hw/misc/npcm7xx_clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

  1   2   3   >