Re: [PATCH v2] target/ppc: Fix BookE debug interrupt generation

2022-04-25 Thread Lucas Mateus Martins Araujo e Castro
On 20/04/2022 22:17, Bin Meng wrote: From: Bin Meng Per E500 core reference manual [1], chapter 8.4.4 "Branch Taken Debug Event" and chapter 8.4.5 "Instruction Complete Debug Event": "A branch taken debug event occurs if both MSR[DE] and DBCR0[BRT] are set ... Branch taken debug events

[PATCH 2/9] qemu/xatth.h: Update for Windows build

2022-04-25 Thread Bin Meng
From: Bin Meng Windows does not have . Signed-off-by: Bin Meng --- include/qemu/xattr.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/xattr.h b/include/qemu/xattr.h index f1d0f7be74..b08a934acc 100644 --- a/include/qemu/xattr.h +++ b/include/qemu/xattr.h

Re: [PATCH 14/18] audio: Require AudioState in AUD_add_capture

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:57AM +0200, Martin Kletzander wrote: > Since all callers require a valid audiodev this function can now safely > abort in case of missing AudioState. > > Signed-off-by: Martin Kletzander > --- > audio/audio.c | 6 ++ > 1 file changed, 2 insertions(+), 4

[PATCH qemu 6/9] target/riscv: rvv: Add mask agnostic for vector fix-point arithmetic instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/vector_helper.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index

[PATCH 1/9] hw/9pfs: Compile 9p-local.c and 9p-proxy.c for Linux and macOS

2022-04-25 Thread Bin Meng
From: Bin Meng For better readability, Windows support of 9pfs local backend driver will be provided in a separate 9p-local-win32.c file, hence let's only compile 9p-local.c for Linux and macOS. As we don't plan to support 9p proxy on Windows, apply the same to 9p-proxy.c. Signed-off-by: Bin

Re: [PATCH 04/18] hw/audio/lm4549: Add errp error reporting to init function

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:47AM +0200, Martin Kletzander wrote: > This will be used in future commit. > > Signed-off-by: Martin Kletzander > --- > hw/audio/lm4549.c | 3 ++- > hw/audio/lm4549.h | 3 ++- > hw/audio/pl041.c | 2 +- > 3 files changed, 5 insertions(+), 3 deletions(-)

[PATCH 3/9] hw/9pfs: Extract common stuff to 9p-local.h

2022-04-25 Thread Bin Meng
From: Guohuai Shi Some macros (e.g.: VIRTFS_META_DIR) are used by both Linux and macOS, and will be used by the upcoming Windows support too, extract them from 9p-local.c to 9p-local.h. Note local_is_mapped_file_metadata()is changed to an inline function. Signed-off-by: Guohuai Shi

[PATCH qemu 7/9] target/riscv: rvv: Add mask agnostic for vector floating-point instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 12 + target/riscv/vector_helper.c| 36 + 2 files changed, 48 insertions(+) diff --git

[PULL 12/14] iotests: remove qemu_io_silent() and qemu_io_silent_check().

2022-04-25 Thread Hanna Reitz
From: John Snow Like qemu-img, qemu-io returning 0 should be the norm and not the exception. Remove all calls to qemu_io_silent that just assert the return code is zero (That's every last call, as it turns out), and replace them with a normal qemu_io() call. qemu_io_silent_check() appeared to

[PATCH qemu 8/9] target/riscv: rvv: Add mask agnostic for vector mask instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 3 +++ target/riscv/vector_helper.c| 13 + 2 files changed, 16 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PATCH 0/9] 9pfs: Add 9pfs support for Windows host

2022-04-25 Thread Bin Meng
At present there is no Windows support for 9p file system. This series adds initial Windows support for 9p file system. 'local' file system backend driver is supported on Windows, including open, read, write, close, rename, remove, etc. All security models are supported. The mapped (mapped-xattr)

[PATCH qemu 2/9] target/riscv: rvv: Add mask agnostic for vector load / store instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 9 + target/riscv/vector_helper.c| 20 2 files changed, 29 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PULL 09/14] iotests/migration-permissions: use assertRaises() for qemu_io() negative test

2022-04-25 Thread Hanna Reitz
From: John Snow Modify this test to use assertRaises for its negative testing of qemu_io. If the exception raised does not match the one we tell it to expect, we get *that* exception unhandled. If we get no exception, we get a unittest assertion failure and the provided emsg printed to screen.

Re: [PATCH 15/18] audio: Be more strict during audio backend initialisation

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:58AM +0200, Martin Kletzander wrote: > Now that audiodev= is required and audio_init() will not be called > without and AudioDev we can remove the fallback functionality and error > out in case audio drivers fail initialisation or when the driver does > not exist. >

[PATCH qemu 5/9] target/riscv: rvv: Add mask agnostic for vector integer comparison instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 10 ++ 2 files changed, 11 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PATCH qemu 3/9] target/riscv: rvv: Add mask agnostic for vx instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 2 ++ target/riscv/vector_helper.c| 3 +++ 2 files changed, 5 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PULL 08/14] iotests: rebase qemu_io() on top of qemu_tool()

2022-04-25 Thread Hanna Reitz
From: John Snow Rework qemu_io() to be analogous to qemu_img(); a function that requires a return code of zero by default unless disabled explicitly. Tests that use qemu_io(): 030 040 041 044 055 056 093 124 129 132 136 148 149 151 152 163 165 205 209 219 236 245 248 254 255 257 260 264 280 298

[PATCH qemu 0/9] Add mask agnostic behavior for rvv instructions

2022-04-25 Thread ~eopxd
According to v-spec, agnostic elements can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set masked-off elements' bits to all 1s". An option 'rvv_ma_all_1s' is added to

[PATCH qemu 4/9] target/riscv: rvv: Add mask agnostic for vector integer shift instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 9 + 2 files changed, 10 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PULL 13/14] iotests: make qemu_io_log() check return codes by default

2022-04-25 Thread Hanna Reitz
From: John Snow Just like qemu_img_log(), upgrade qemu_io_log() to enforce a return code of zero by default. Tests that use qemu_io_log(): 242 245 255 274 303 307 nbd-reconnect-on-open Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id:

[PULL 07/14] iotests: create generic qemu_tool() function

2022-04-25 Thread Hanna Reitz
From: John Snow reimplement qemu_img() in terms of qemu_tool() in preparation for doing the same with qemu_io(). Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id: <20220418211504.943969-7-js...@redhat.com> Signed-off-by: Hanna Reitz ---

[PATCH qemu 1/9] target/riscv: rvv: Add mask agnostic for vv instructions

2022-04-25 Thread ~eopxd
From: Yueh-Ting (eop) Chen This is the first commit regarding the mask agnostic behavior. Added option 'rvv_ma_all_1s' to enable the behavior, the option is default to false. Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/cpu.c | 1 +

[PULL 11/14] iotests: remove qemu_io_pipe_and_status()

2022-04-25 Thread Hanna Reitz
From: John Snow I know we just added it, sorry. This is done in favor of qemu_io() which *also* returns the console output and status, but with more robust error handling on failure. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id:

[PULL 10/14] iotests/image-fleecing: switch to qemu_io()

2022-04-25 Thread Hanna Reitz
From: John Snow This test expects failure ... but only sometimes. When? Why? It's for reads of a region not defined by a bitmap. Adjust the test to be more explicit about what it expects to fail and why. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id:

[PULL 04/14] iotests: Don't check qemu_io() output for specific error strings

2022-04-25 Thread Hanna Reitz
From: John Snow A forthcoming commit updates qemu_io() to raise an exception on non-zero return by default, and changes its return type. In preparation, simplify some calls to qemu_io() that assert that specific error message strings do not appear in qemu-io's output. Asserting that all of

[PULL 00/14] Block patches

2022-04-25 Thread Hanna Reitz
The following changes since commit 754f756cc4c6d9d14b7230c62b5bb20f9d655888: Merge tag 'pull-target-arm-20220422-1' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-04-22 08:03:18 -0700) are available in the Git repository at: https://gitlab.com/hreitz/qemu.git

[PULL 05/14] iotests/040: Don't check image pattern on zero-length image

2022-04-25 Thread Hanna Reitz
From: John Snow qemu-io fails on read/write beyond end-of-file on raw images, so skip these invocations when running the zero-length image tests. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id: <20220418211504.943969-5-js...@redhat.com> Signed-off-by:

[PULL 14/14] iotests/108: Fix when missing user_allow_other

2022-04-25 Thread Hanna Reitz
FUSE exports' allow-other option defaults to "auto", which means that it will try passing allow_other as a mount option, and fall back to not using it when an error occurs. We make no effort to hide fusermount's error message (because it would be difficult, and because users might want to know

Re: [PATCH] target/xtensa: import core lx106

2022-04-25 Thread Max Filippov
On Sun, Apr 24, 2022 at 10:40 PM Simon Safar wrote: > On Sat, Apr 23, 2022, at 2:26 PM, Max Filippov wrote: > > It's for a (future...) Lisp compiler! Somewhat in the style of MicroPython; > > the idea > > is to make code editable on the fly, without reflashing (... or restarting, > > even). > >

[PULL 03/14] iotests/163: Fix broken qemu-io invocation

2022-04-25 Thread Hanna Reitz
From: John Snow The 'read' commands to qemu-io were malformed, and this invocation only worked by coincidence because the error messages were identical. Oops. There's no point in checking the patterning of the reference image, so just check the empty image by itself instead. (Note: as of this

[PULL 01/14] block: add 'force' parameter to 'blockdev-change-medium' command

2022-04-25 Thread Hanna Reitz
From: "Denis V. Lunev" 'blockdev-change-medium' is a convinient wrapper for the following sequence of commands: * blockdev-open-tray * blockdev-remove-medium * blockdev-insert-medium * blockdev-close-tray and should be used f.e. to change ISO image inside the CD-ROM tray. Though the guest

[PULL 06/14] iotests/040: Fix TestCommitWithFilters test

2022-04-25 Thread Hanna Reitz
From: John Snow Without this change, asserting that qemu_io always returns 0 causes this test to fail in a way we happened not to be catching previously: qemu.utils.VerboseProcessError: Command '('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io', '--cache', 'writeback',

[PULL 02/14] iotests: replace calls to log(qemu_io(...)) with qemu_io_log()

2022-04-25 Thread Hanna Reitz
From: John Snow This makes these callsites a little simpler, but the real motivation is a forthcoming commit will change the return type of qemu_io(), so removing users of the return value now is helpful. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Message-Id:

Re: [PATCH 03/18] hw/audio: Simplify hda audio init

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 02:35:03PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > > No return values are used anywhere, so switch the functions to be void > > and add support for error reporting using errp for use in next patches. > >

Re: [PATCH v5 04/13] mm/shmem: Restrict MFD_INACCESSIBLE memory against RLIMIT_MEMLOCK

2022-04-25 Thread David Hildenbrand
On 13.04.22 19:52, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 06:24:56PM +0200, David Hildenbrand wrote: >> On 12.04.22 16:36, Jason Gunthorpe wrote: >>> On Fri, Apr 08, 2022 at 08:54:02PM +0200, David Hildenbrand wrote: >>> RLIMIT_MEMLOCK was the obvious candidate, but as we discovered

Re: [PATCH 07/18] Introduce machine's default-audiodev property

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:50AM +0200, Martin Kletzander wrote: > Many machine types have default audio devices with no way to set the > underlying > audiodev. Instead of adding an option for each and every one of them this new > property can be used as a default during machine initialisation

Re: [PATCH 0/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-04-25 Thread Gerd Hoffmann
On Thu, Mar 31, 2022 at 04:24:28PM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 31, 2022 at 10:35:46AM +0200, Gerd Hoffmann wrote: > > > > > Looks good. > Acked-by: Michael S. Tsirkin > > > Who's merging this? Yourself? Just posted v2 with all the reviews, tests and acks added. Will

[PATCH v2 3/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-04-25 Thread Gerd Hoffmann
Don't register firmware as rom, not needed (see comment). Add x86_firmware_configure() call for proper sev initialization. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Tested-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S.

[PATCH v2 2/3] i386: factor out x86_firmware_configure()

2022-04-25 Thread Gerd Hoffmann
move sev firmware setup to separate function so it can be used from other code paths. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- include/hw/i386/x86.h | 3 +++

[PATCH v2 1/3] i386: move bios load error message

2022-04-25 Thread Gerd Hoffmann
Switch to usual goto-end-of-function error handling style. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- hw/i386/x86.c | 9 ++--- 1 file changed, 6

[PATCH v2 0/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-04-25 Thread Gerd Hoffmann
v2: - rebased to latest master, post-freeze repost. - picked up review tags. Gerd Hoffmann (3): i386: move bios load error message i386: factor out x86_firmware_configure() i386: firmware parsing and sev setup for -bios loaded firmware include/hw/i386/x86.h | 3 +++ hw/i386/pc_sysfw.c

Re: [PATCH 06/18] ui/vnc: Require audiodev=

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:49AM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > ui/vnc.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index badf1d7664fe..2e7af139b030 100644 > --- a/ui/vnc.c > +++

Re: [PATCH v5 2/3] aspeed/hace: Support AST2600 HACE

2022-04-25 Thread Cédric Le Goater
On 4/22/22 07:19, Steven Lee wrote: The aspeed ast2600 accumulative mode is described in datasheet ast2600v10.pdf section 25.6.4: 1. Allocating and initiating accumulative hash digest write buffer with initial state. * Since QEMU crypto/hash api doesn't provide the API to set initial

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-04-25 Thread Chao Peng
On Sun, Apr 24, 2022 at 09:59:37AM -0700, Andy Lutomirski wrote: > > > On Fri, Apr 22, 2022, at 3:56 AM, Chao Peng wrote: > > On Tue, Apr 05, 2022 at 06:03:21PM +, Sean Christopherson wrote: > >> On Tue, Apr 05, 2022, Quentin Perret wrote: > >> > On Monday 04 Apr 2022 at 15:04:17 (-0700),

Re: [RFC 00/18] vfio: Adopt iommufd

2022-04-25 Thread Jason Gunthorpe
On Mon, Apr 25, 2022 at 11:10:14AM +0100, Daniel P. Berrangé wrote: > > However, with iommufd there's no reason that QEMU ever needs more than > > a single instance of /dev/iommufd and we're using per device vfio file > > descriptors, so it seems like a good time to revisit this. > > I assume

Re: [PATCH 13/18] audio: Make AUD_register_card fallible and require audiodev=

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 02:34:08PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 25, 2022 at 10:21:56AM +0200, Martin Kletzander wrote: > > Now that all callers support error reporting with errp and all > > machine-default > > devices use an explicit audiodev, this can be changed. To make the

Re: [PATCH 05/18] tests/qtest: Specify audiodev= and -audiodev

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:48AM +0200, Martin Kletzander wrote: > This will enable removing deprecated default audiodev support. > > I did not figure out how to make the audiodev represented as an > interface node, so this is a workaround. I am not sure what would be > the proper way. Not

Re: [PATCH 13/18] audio: Make AUD_register_card fallible and require audiodev=

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:56AM +0200, Martin Kletzander wrote: > Now that all callers support error reporting with errp and all machine-default > devices use an explicit audiodev, this can be changed. To make the detection > easier make AUD_register_card() return false on error. > >

Re: [PATCH 03/18] hw/audio: Simplify hda audio init

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > No return values are used anywhere, so switch the functions to be void > and add support for error reporting using errp for use in next patches. Making it 'void' makes sense, but I'm not sure we need the Error **errp addition,

Live Migration ToDo

2022-04-25 Thread Artyom
Hello! I would like to see a list of suggestions/ideas/tickets for improving live migration (especially performance and algorithms). There is a page https://wiki.qemu.org/ToDo/LiveMigration, but it has not been updated for a long time. Thanks

Re: [PATCH v2] target/xtensa: import core lx106

2022-04-25 Thread Simon Safar
Hi Max, On Sat, Apr 23, 2022, at 2:41 PM, Max Filippov wrote: > I've noticed that this file is not from the original overlay (which I happen > to have here: > https://github.com/jcmvbkbc/xtensa-toolchain-build/blob/master/overlays/original/lx106.tar.gz), > but has been changed (by adding '& ~1'

Re: [PATCH] target/xtensa: import core lx106

2022-04-25 Thread Simon Safar
On Sat, Apr 23, 2022, at 2:26 PM, Max Filippov wrote: > > It's for a (future...) Lisp compiler! Somewhat in the style of MicroPython; > > the idea > > is to make code editable on the fly, without reflashing (... or restarting, > > even). > > Interesting. Do you use libisa or do you do

Re: [qemu.qmp PATCH 06/12] move README.rst to FILES.rst and update

2022-04-25 Thread Kashyap Chamarthy
On Fri, Apr 22, 2022 at 02:49:34PM -0400, John Snow wrote: > The intent is to use README.rst as the new package-level readme that > will be bundled with the source and be displayed on the GitLab landing > page; so move the old "git level readme" over to FILES.rst instead, and > update it

Re: [qemu.qmp PATCH 11/12] remove sub-dependency pins from Pipfile

2022-04-25 Thread Kashyap Chamarthy
On Fri, Apr 22, 2022 at 02:49:39PM -0400, John Snow wrote: > Now that we've got a Pipfile.lock generated that works, we can remove > the static pins from the Pipfile to allow various dependencies to be > added or removed as necessary when updating our direct dependencies in > the future. > > So

Re: [PATCH 02/18] hw/input/tsc210x: Extract common init code into new function

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:45AM +0200, Martin Kletzander wrote: > This deduplicates several lines and will make future changes more > concise. > > Signed-off-by: Martin Kletzander > --- > hw/input/tsc210x.c | 68 -- > 1 file changed, 24

Re: [PATCH 01/18] hw/audio: Remove -soundhw support

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:21:44AM +0200, Martin Kletzander wrote: > One thing I am not sure about is whether to keep the aliases of ac97 and > es1370 in the qdev_alias_table. I'm not sure we have any prior art in this respect. I feel it is a bit odd-ball that AC97 and ES1370 are uppercase in

Re: [PATCH v3 6/6] 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host

2022-04-25 Thread Greg Kurz
On Mon, 25 Apr 2022 14:21:00 +0200 Christian Schoenebeck wrote: > qemu_mknodat() is expected to behave according to its POSIX API, and > therefore should always return exactly -1 on any error, and errno > should be set for the actual error code. > > Signed-off-by: Christian Schoenebeck > ---

Re: [PATCH 18/18] audio/spiceaudio: Fail initialisation when not using spice

2022-04-25 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 10:22:01AM +0200, Martin Kletzander wrote: > The caller would already fail, but this way the message can better > express the reason for the failure. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2043498 > > Signed-off-by: Martin Kletzander > --- >

Re: [PATCH] hw/crypto: add Allwinner sun4i-ss crypto device

2022-04-25 Thread LABBE Corentin
Le Mon, Apr 25, 2022 at 11:19:16AM +0100, Daniel P. Berrangé a écrit : > On Sun, Apr 24, 2022 at 09:10:23PM +0200, LABBE Corentin wrote: > > Le Thu, Apr 21, 2022 at 01:38:00PM +0100, Peter Maydell a écrit : > > > On Sun, 10 Apr 2022 at 20:12, Corentin Labbe wrote: > > > > > > > > From: Corentin

Re: Signing QEMU up for GitLab for Open Source?

2022-04-25 Thread Alex Bennée
Stefan Hajnoczi writes: > [[PGP Signed Part:Undecided]] > Hi, > QEMU needs to enroll in GitLab for Open Source before July 1st to > receive 50,000 CI/CD pipeline minutes and GitLab Ultimate features: > > https://about.gitlab.com/blog/2022/02/04/ultimate-perks-for-open-source-projects/ >

[PATCH v3 2/6] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS

2022-04-25 Thread Christian Schoenebeck
mknod() on macOS does not support creating sockets, so divert to call sequence socket(), bind() and chmod() respectively if S_IFSOCK was passed with mode argument. Link: https://lore.kernel.org/qemu-devel/17933734.zYzKuhC07K@silver/ Signed-off-by: Christian Schoenebeck Reviewed-by: Will Cohen

[PATCH v3 4/6] 9pfs: fix wrong errno being sent to Linux client on macOS host

2022-04-25 Thread Christian Schoenebeck
Linux and macOS only share some errno definitions with equal macro name and value. In fact most mappings for errno are completely different on the two systems. This patch converts some important errno values from macOS host to corresponding Linux errno values before eventually sending such error

[PATCH v3 6/6] 9pfs: fix qemu_mknodat() to always return -1 on error on macOS host

2022-04-25 Thread Christian Schoenebeck via
qemu_mknodat() is expected to behave according to its POSIX API, and therefore should always return exactly -1 on any error, and errno should be set for the actual error code. Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p-util-darwin.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v3 5/6] 9pfs: fix removing non-existent POSIX ACL xattr on macOS host

2022-04-25 Thread Christian Schoenebeck
When mapped POSIX ACL is used, we are ignoring errors when trying to remove a POSIX ACL xattr that does not exist. On Linux hosts we would get ENODATA in such cases, on macOS hosts however we get ENOATTR instead. As we can be sure that ENOATTR is defined as being identical on Linux hosts (at

[PATCH v3 1/6] 9pfs: fix qemu_mknodat(S_IFREG) on macOS

2022-04-25 Thread Christian Schoenebeck
mknod() on macOS does not support creating regular files, so divert to openat_file() if S_IFREG is passed with mode argument. Furthermore, 'man 2 mknodat' on Linux says: "Zero file type is equivalent to type S_IFREG". Link: https://lore.kernel.org/qemu-devel/17933734.zYzKuhC07K@silver/

[PATCH v3 3/6] 9pfs: fix wrong encoding of rdev field in Rgetattr on macOS

2022-04-25 Thread Christian Schoenebeck
The 'rdev' field in 9p reponse 'Rgetattr' is of type dev_t, which is actually a system dependant type and therefore both the size and encoding of dev_t differ between macOS and Linux. So far we have sent 'rdev' to guest in host's dev_t format as-is, which caused devices to appear with wrong

[PATCH v3 0/6] 9pfs: macOS host fixes

2022-04-25 Thread Christian Schoenebeck
A bunch of fixes for recently (in QEMU 7.0) added 9p support on macOS hosts. Note: there are still issues to address with case-insensitive file systems on macOS hosts. I sent a separate RFC on that icase issue: https://lore.kernel.org/qemu-devel/1757498.AyhHxzoH2B@silver/ v2 -> v3: * Explicit

Re: [PATCH v3 00/12] iotests: add enhanced debugging info to qemu-io failures

2022-04-25 Thread Hanna Reitz
On 18.04.22 23:14, John Snow wrote: GitLab: https://gitlab.com/jsnow/qemu/-/commits/iotests_qemu_io_diagnostics Howdy, This series does for qemu_io() what we've done for qemu_img() and makes it a function that checks the return code by default and raises an Exception when things do not go

Re: [PATCH v3 2/3] hw/audio/ac97: Remove unimplemented reset functions

2022-04-25 Thread Víctor Colombo
On 23/04/2022 06:36, BALATON Zoltan wrote: The warm_reset() and cold_reset() functions are not implemented and do nothing so no point in calling them or keep around as dead code. Therefore remove them for now. Signed-off-by: BALATON Zoltan --- hw/audio/ac97.c | 17 + 1 file

Re: [PATCH v3 1/3] hw/audio/ac97: Coding style fixes to avoid checkpatch errors

2022-04-25 Thread Víctor Colombo
On 23/04/2022 06:36, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- v3: Fixed misalignments and drop spaces before commas hw/audio/ac97.c | 733 1 file changed, 360 insertions(+), 373 deletions(-) Reviewed-by: Víctor Colombo

Re: [PATCH v2] Only advertise aio=io_uring if support is actually available

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 03:30:46PM -0500, Eric Blake wrote: > On Thu, Apr 21, 2022 at 02:27:55PM -0500, Eric Blake wrote: > > On Thu, Apr 21, 2022 at 06:50:48PM +0200, Dirk Müller wrote: > > > Change --help output for aio option to only list the aio backend options > > > that > > > are actually

Re: [PATCH] Only advertise aio=io_uring if support is actually available

2022-04-25 Thread Dirk Müller
On Mittwoch, 20. April 2022 10:33:38 CEST Daniel P. Berrangé wrote: Hi Daniel, > If we're going to conditionalize this, then we really ought to be > address it fully, because 'native' is also platform specific. Good point. I can do that as well. > IOW, we would end up needing something more

Re: [qemu.qmp PATCH 02/12] update maintainer metadata

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 02:49:30PM -0400, John Snow wrote: > Modify "QEMU Developer Team" to "QEMU Project", as this matches the > spelling we use for the collective on gitlab.com/qemu-project. > > Add myself as the principal maintainer contact. > > Signed-off-by: John Snow > --- > setup.cfg |

Re: [PATCH v8 00/17] vfio-user server in QEMU

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:05PM -0400, Jagannathan Raman wrote: > This is v8 of the server side changes to enable vfio-user in QEMU. > > Thank you very much for reviewing the last revision of this series! I posted some minor comments. I hope the next revision or the one after it will be

Re: [qemu.qmp PATCH 09/12] add LGPLv2+ and GPLv2 LICENSE files

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 02:49:37PM -0400, John Snow wrote: > This clarifies that the majority of this package is LGPLv2+. Copyright > blurbs that pointed to QEMU's "COPYING" file are amended to point to > this repository's "LICENSE" file instead. > > The only file that is not already licensed as

Re: [qemu.qmp PATCH 04/12] update project URLs

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote: > Point to this library's URLs instead of the entire project's. > > Signed-off-by: John Snow > --- > setup.cfg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/setup.cfg b/setup.cfg > index c21f2ce..0a1c215

Re: [PATCH v8 16/17] vfio-user: handle reset of remote device

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:21PM -0400, Jagannathan Raman wrote: > Adds handler to reset a remote device > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/remote/vfio-user-obj.c | 20 > 1 file changed, 20

Re: [PATCH v2] target/xtensa: import core lx106

2022-04-25 Thread Max Filippov
On Sun, Apr 24, 2022 at 10:24 PM Simon Safar wrote: > On Sat, Apr 23, 2022, at 2:41 PM, Max Filippov wrote: > > I've noticed that this file is not from the original overlay (which I happen > > to have here: > >

Re: [PATCH] hw/crypto: add Allwinner sun4i-ss crypto device

2022-04-25 Thread Daniel P . Berrangé
On Sun, Apr 24, 2022 at 09:10:23PM +0200, LABBE Corentin wrote: > Le Thu, Apr 21, 2022 at 01:38:00PM +0100, Peter Maydell a écrit : > > On Sun, 10 Apr 2022 at 20:12, Corentin Labbe wrote: > > > > > > From: Corentin LABBE > > > > > > The Allwinner A10 has a cryptographic offloader device which >

Re: [PATCH v3 for 7.1 1/1] block: add 'force' parameter to 'blockdev-change-medium' command

2022-04-25 Thread Hanna Reitz
On 13.04.22 00:18, Denis V. Lunev wrote: 'blockdev-change-medium' is a convinient wrapper for the following sequence of commands: * blockdev-open-tray * blockdev-remove-medium * blockdev-insert-medium * blockdev-close-tray and should be used f.e. to change ISO image inside the CD-ROM

Signing QEMU up for GitLab for Open Source?

2022-04-25 Thread Stefan Hajnoczi
Hi, QEMU needs to enroll in GitLab for Open Source before July 1st to receive 50,000 CI/CD pipeline minutes and GitLab Ultimate features: https://about.gitlab.com/blog/2022/02/04/ultimate-perks-for-open-source-projects/ https://about.gitlab.com/solutions/open-source/ CI/CD minutes also become

Re: [RFC 00/18] vfio: Adopt iommufd

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 04:09:43PM -0600, Alex Williamson wrote: > [Cc +libvirt folks] > > On Thu, 14 Apr 2022 03:46:52 -0700 > Yi Liu wrote: > > > With the introduction of iommufd[1], the linux kernel provides a generic > > interface for userspace drivers to propagate their DMA mappings to

Re: [qemu.qmp PATCH 01/12] fork qemu.qmp from qemu.git

2022-04-25 Thread Daniel P . Berrangé
On Fri, Apr 22, 2022 at 02:49:29PM -0400, John Snow wrote: > Split python/ from qemu.git, using these commands: > > > git subtree split -P python/ -b python-split-v3 > > mkdir ~/src/tmp > > cd ~/src/tmp > > git clone --no-local --branch python-split-v3 --single-branch ~/src/qemu > > cd qemu > >

Re: [PATCH v8 13/17] vfio-user: handle DMA mappings

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:18PM -0400, Jagannathan Raman wrote: > +static void dma_unregister(vfu_ctx_t *vfu_ctx, vfu_dma_info_t *info) > +{ > +VfuObject *o = vfu_get_private(vfu_ctx); > +AddressSpace *dma_as = NULL; > +MemoryRegion *mr = NULL; > +ram_addr_t offset; > + > +

Re: [PATCH v2] error-report: fix g_date_time_format assertion

2022-04-25 Thread Daniel P . Berrangé
On Sun, Apr 24, 2022 at 06:50:35PM +0800, Haiyue Wang wrote: > The 'g_get_real_time' returns the number of microseconds since January > 1, 1970 UTC, but 'g_date_time_new_from_unix_utc' needs the number of > seconds, so it will cause the invalid time input: > > (process:279642): GLib-CRITICAL

Re: [PATCH v8 12/17] vfio-user: IOMMU support for remote device

2022-04-25 Thread Stefan Hajnoczi
On Wed, Apr 20, 2022 at 11:15:16AM +, Jag Raman wrote: > > > > On Apr 19, 2022, at 4:45 PM, Jag Raman wrote: > > > > Assign separate address space for each device in the remote processes. > > > > Signed-off-by: Elena Ufimtseva > > Signed-off-by: John G Johnson > > Signed-off-by:

Re: [PATCH v8 15/17] vfio-user: handle device interrupts

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:20PM -0400, Jagannathan Raman wrote: > +static MSIMessage vfu_object_msi_prepare_msg(PCIDevice *pci_dev, > + unsigned int vector) > +{ > +MSIMessage msg; > + > +msg.address = 0; > +msg.data = vector; > + > +

Re: [PATCH] nvme: fix bit buckets

2022-04-25 Thread Klaus Jensen
+qemu-devel On Apr 22 09:37, Keith Busch wrote: > We can't just ignore the bit buckets since the data offsets read from > disk need to be accounted for. We could either split into multiple reads > for the actual user data requested and skip the buckets, or we could > have a place holder for

[PATCH v2 36/43] Enable common virtio pci support for LoongArch

2022-04-25 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- softmmu/qdev-monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 12fe60c467..bb5897fc76 100644 --- a/softmmu/qdev-monitor.c

[PATCH v2 38/43] hw/loongarch: Add LoongArch ls7a rtc device support

2022-04-25 Thread Xiaojuan Yang
This patch add ls7a rtc device support. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- MAINTAINERS| 1 + hw/loongarch/Kconfig | 1 + hw/loongarch/loongson3.c | 4 + hw/rtc/Kconfig | 3 + hw/rtc/ls7a_rtc.c | 322

[PATCH v2 24/43] target/loongarch: Add constant timer support

2022-04-25 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/constant_timer.c | 64 +++ target/loongarch/cpu.c| 2 + target/loongarch/cpu.h| 4 ++ target/loongarch/internals.h | 6 +++

[PATCH v2 40/43] hw/loongarch: Add LoongArch ls7a acpi device support

2022-04-25 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- MAINTAINERS| 2 + hw/acpi/Kconfig| 4 + hw/acpi/ls7a.c | 374 + hw/acpi/meson.build| 1 + hw/loongarch/Kconfig | 2 +

[PATCH v2 22/43] target/loongarch: Add MMU support for LoongArch CPU.

2022-04-25 Thread Xiaojuan Yang
Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/cpu-param.h | 2 +- target/loongarch/cpu.c| 24 +++ target/loongarch/cpu.h| 51 ++ target/loongarch/internals.h | 9 + target/loongarch/machine.c| 17 ++

Re: [PATCH v8 14/17] vfio-user: handle PCI BAR accesses

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:19PM -0400, Jagannathan Raman wrote: > +static size_t vfu_object_bar_rw(PCIDevice *pci_dev, int pci_bar, > +hwaddr bar_offset, char * const buf, > +hwaddr len, const bool is_write) > +{ > +

[PATCH v2 30/43] hw/loongarch: Add support loongson3 virt machine type.

2022-04-25 Thread Xiaojuan Yang
Emulate a 3A5000 board use the new loongarch instruction. 3A5000 belongs to the Loongson3 series processors. The board consists of a 3A5000 cpu model and the virt bridge. The host 3A5000 board is really complicated and contains many functions.Now for the tcg softmmu mode only part functions are

[PATCH v2 43/43] target/loongarch: 'make check-tcg' support

2022-04-25 Thread Xiaojuan Yang
From: Song Gao Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Acked-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/tcg/configure.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index

[PATCH v2 42/43] tests/tcg/loongarch64: Add hello/memory test in loongarch64 system

2022-04-25 Thread Xiaojuan Yang
- We write a very minimal softmmu harness. - This is a very simple smoke test with no need to run a full Linux/kernel. - The Makefile.softmmu-target record the rule to run. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- MAINTAINERS

[PATCH v2 29/43] target/loongarch: Add timer related instructions support.

2022-04-25 Thread Xiaojuan Yang
This includes: -RDTIME{L/H}.W -RDTIME.D Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- target/loongarch/disas.c | 3 ++ target/loongarch/helper.h | 2 ++ target/loongarch/insn_trans/trans_extra.c.inc | 33 +++

Re: [PATCH v8 12/17] vfio-user: IOMMU support for remote device

2022-04-25 Thread Stefan Hajnoczi
On Tue, Apr 19, 2022 at 04:44:17PM -0400, Jagannathan Raman wrote: > +static AddressSpace *remote_iommu_find_add_as(PCIBus *pci_bus, > + void *opaque, int devfn) > +{ > +RemoteIommu *iommu = opaque; > +RemoteIommuElem *elem = NULL; > + > +

[PATCH v2 32/43] hw/intc: Add LoongArch ls7a interrupt controller support(PCH-PIC)

2022-04-25 Thread Xiaojuan Yang
This patch realize the PCH-PIC interrupt controller. Signed-off-by: Xiaojuan Yang Signed-off-by: Song Gao --- MAINTAINERS | 1 + hw/intc/Kconfig | 4 + hw/intc/loongarch_pch_pic.c | 434 hw/intc/meson.build

<    1   2   3   >