Re: Ping: Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

On 03.08.23 17:43, ThinerLogoer wrote: At 2023-07-28 18:45:20, "David Hildenbrand" wrote: Whatever you prefer! If I resend the patch, I would keep you the author and only add my Co-authored-by: Signed-off-by:. Just let me know. Hello, I wonder whether you have planned to resubmit the

Re: [PATCH v3 14/17] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

Hi Zhao, On 8/2/23 18:49, Moger, Babu wrote: > Hi Zhao, > > Hitting this error after this patch. > > ERROR:../target/i386/cpu.c:257:max_processor_ids_for_cache: code should > not be reached > Bail out! ERROR:../target/i386/cpu.c:257:max_processor_ids_for_cache: code > should not be reached >

Re: [PATCH v3 2/3] qmp: update virtio feature maps, vhost-user-gpio introspection

On Thu, 03 Aug 2023 17:54, Jonah Palmer wrote: Add new virtio transport feature to transport feature map: - VIRTIO_F_RING_RESET Add new vhost-user protocol feature to vhost-user protocol feature map and enumeration: - VHOST_USER_PROTOCOL_F_STATUS Add new virtio device features for several

Re: [PATCH v3 3/3] vhost-user: move VhostUserProtocolFeature definition to header file

On Thu, 03 Aug 2023 17:55, Jonah Palmer wrote: Move the definition of VhostUserProtocolFeature to include/hw/virtio/vhost-user.h. Remove previous definitions in hw/scsi/vhost-user-scsi.c, hw/virtio/vhost-user.c, and hw/virtio/virtio-qmp.c. Previously there were 3 separate definitions of this

Re: [PATCH 04/44] Introduce BCM2838 SoC

On Wed, 26 Jul 2023 at 14:52, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838.c | 110 +++ > hw/arm/bcm2838_peripherals.c | 72 ++ > hw/arm/meson.build | 2 + >

Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang

On Mon, Jul 31, 2023 at 02:04:42PM +0200, Thomas Huth wrote: > On 31/07/2023 11.32, Daniel P. Berrangé wrote: > > On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote: > ... > > > Or do you see another possibility how we could fix that timeout problem in > > > the 64-bit MSYS2 job? Still

Re: [PULL 0/9] Fixes for 8.1-rc3

On 8/3/23 04:09, Thomas Huth wrote: The following changes since commit fb695ae3fdfe34ce7bf2eaa4595d48ca809c8841: Merge tag 'pull-qapi-2023-08-02' of https://repo.or.cz/qemu/armbru into staging (2023-08-02 06:51:53 -0700) are available in the Git repository at:

Re: [PATCH 01/44] Split out common part of BCM283X classes

On Wed, 26 Jul 2023 at 14:43, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2836.c | 102 ++- > hw/arm/raspi.c | 2 +- > include/hw/arm/bcm2836.h | 26 +- > 3 files changed, 83 insertions(+), 47

Re: [PATCH 01/44] Split out common part of BCM283X classes

On Thu, 3 Aug 2023 at 16:48, Peter Maydell wrote: > > On Wed, 26 Jul 2023 at 14:43, Sergey Kambalin wrote: > > > > Signed-off-by: Sergey Kambalin > > --- > > hw/arm/bcm2836.c | 102 ++- > > hw/arm/raspi.c | 2 +- > >

Re: [PATCH v7 00/14] linux-user: brk fixes

On 8/3/23 17:20, Richard Henderson wrote: On 8/3/23 08:01, Helge Deller wrote: If it does, it replaces patches 1,2 & 4-6 from Richard's v7 patch series. The patch you gave below has no overlap with 1,2,4,5 at all. Yes, ignore this Your patch series is fine as-is (the

Re: [PATCH v7 00/14] linux-user: brk fixes

On 8/3/23 17:11, Richard Henderson wrote: On 8/3/23 08:01, Helge Deller wrote: * Joel Stanley : On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: 143551 brk(NULL) = 0x0009b000 143551 brk(0x0009b8fc) = 0x0009b000 I think the problem is the brk with 9b000 here. It's not 64k aligned (=pages

RE: [PATCH v2] Fix SEGFAULT on getting physical address of MMIO region.

> > Apply save_iotlb_data() to io_readx() as well as to io_writex(). > > Could we have a bit more detail in the commit message about > when you can get this segfault? > > In particular, does this happen only if you're using plugins? > I think so. It crashes on specific addresses when plugin

Re: [PATCH v9 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

On Thu, Aug 03, 2023 at 08:48:22PM +0900, Jeuk Kim wrote: > Dear Stefan, > I'm really sorry, but could you please put this patch series > instead of v8, which was previously merged into block-next? > The fixes from v8 are below. > Please let me know if you have any comments or issues. I hope you

[PULL for-8.1 2/2] block/blkio: add more comments on the fd passing handling

From: Stefano Garzarella As Hanna pointed out, it is not clear in the code why qemu_open() can fail, and why blkio_set_int("fd") is not enough to discover the `fd` property support. Let's fix them by adding more details in the code comments. Suggested-by: Hanna Czenczek Reviewed-by: Hanna

[PULL for-8.1 0/2] Block patches

The following changes since commit 9ba37026fcf6b7f3f096c0cca3e1e7307802486b: Update version for v8.1.0-rc2 release (2023-08-02 08:22:45 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to

[PULL for-8.1 1/2] block/blkio: close the fd when blkio_connect() fails

From: Stefano Garzarella libblkio drivers take ownership of `fd` only after a successful blkio_connect(), so if it fails, we are still the owners. Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for virtio-blk") Suggested-by: Hanna Czenczek Signed-off-by: Stefano

[PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

Migration bandwidth is a very important value to live migration. It's because it's one of the major factors that we'll make decision on when to switchover to destination in a precopy process. This value is currently estimated by QEMU during the whole live migration process by monitoring how fast

[PATCH for-8.2 v2 1/2] qapi/migration: Deduplicate migration parameter field comments

We used to have three objects that have always the same list of parameters and comments are always duplicated: - @MigrationParameter - @MigrationParameters - @MigrateSetParameters Before we can deduplicate the code, it's fairly straightforward to deduplicate the comments first, so for each

[PATCH for-8.2 v2 0/2] migration: Add max-switchover-bandwidth parameter

v2: - Fix wordings, reindent qapi doc [Markus] - Added a pre-requisite patch to dedup documents in qapi/migration - Rename available-bandwidth to max-switchover-bandwidth [Dan] This is the v2 series to add the new parameter to guide migration switchover calculations. For more information on the

Re: [PATCH 02/44] Split out common part of peripherals

On Wed, 26 Jul 2023 at 14:44, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2835_peripherals.c | 198 +++ > hw/arm/bcm2836.c | 24 ++-- > include/hw/arm/bcm2835_peripherals.h | 29 +++- >

Re: [PATCH 01/44] Split out common part of BCM283X classes

On Wed, 26 Jul 2023 at 14:43, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2836.c | 102 ++- > hw/arm/raspi.c | 2 +- > include/hw/arm/bcm2836.h | 26 +- > 3 files changed, 83 insertions(+), 47

Ping: Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

At 2023-07-28 18:45:20, "David Hildenbrand" wrote: > > >Whatever you prefer! If I resend the patch, I would keep you the author >and only add my Co-authored-by: Signed-off-by:. > >Just let me know. > Hello, I wonder whether you have planned to resubmit the current patch anytime soon, or is it

Re: [PATCH v2 1/2] migration: Split await_return_path_close_on_source

On Thu, Aug 03, 2023 at 04:24:16PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 03, 2023 at 11:15:41AM -0400, Peter Xu wrote: > > On Thu, Aug 03, 2023 at 11:45:38AM -0300, Fabiano Rosas wrote: > > > Peter Xu writes: > > > > > > > On Wed, Aug 02, 2023 at 04:58:38PM -0300, Fabiano Rosas wrote: >

[RFC PATCH post-8.1] hw/xen: Clean up event channel 'type_val' handling to use union

From: David Woodhouse A previous implementation of this stuff used a 64-bit field for all of the port information (vcpu/type/type_val) and did atomic exchanges on them. When I implemented that in Qemu I regretted my life choices and just kept it simple with locking instead. So there's no need

Re: [PATCH v2 0/2] block/blkio: fix fd leak and add more comments for the fd passing

On Thu, Aug 03, 2023 at 10:28:23AM +0200, Stefano Garzarella wrote: > Hanna discovered an fd leak in the error path, and a few comments to > improve in the code. > > v2: > - avoid to use `fd_supported` to track a valid fd [Hanna] > > v1: >

Re: [PATCH v2 1/2] migration: Split await_return_path_close_on_source

On Thu, Aug 03, 2023 at 11:15:41AM -0400, Peter Xu wrote: > On Thu, Aug 03, 2023 at 11:45:38AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Wed, Aug 02, 2023 at 04:58:38PM -0300, Fabiano Rosas wrote: > > >> Peter Xu writes: > > >> > > >> > On Wed, Aug 02, 2023 at 11:36:43AM

Re: [PATCH v7 00/14] linux-user: brk fixes

On 8/3/23 08:01, Helge Deller wrote: If it does, it replaces patches 1,2 & 4-6 from Richard's v7 patch series. The patch you gave below has no overlap with 1,2,4,5 at all. r~

Re: [PATCH v2 1/2] migration: Split await_return_path_close_on_source

On Thu, Aug 03, 2023 at 11:45:38AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Aug 02, 2023 at 04:58:38PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Wed, Aug 02, 2023 at 11:36:43AM -0300, Fabiano Rosas wrote: > >> >> This function currently has a

Re: [PATCH v2] Fix SEGFAULT on getting physical address of MMIO region.

On Thu, 3 Aug 2023 at 12:00, Mikhail Tyutin wrote: > > Apply save_iotlb_data() to io_readx() as well as to io_writex(). Could we have a bit more detail in the commit message about when you can get this segfault? In particular, does this happen only if you're using plugins? thanks -- PMM

[PATCH v2] Allowing setting and overriding parameters in smb.conf

>From a6dfb322a88965281e3bba00a92f8d5e437bfa95 Mon Sep 17 00:00:00 2001 From: Henrik Carlqvist Date: Thu, 3 Aug 2023 16:52:25 +0200 Subject: [PATCH] Allowing setting and overriding parameters in smb.conf, moving some parameters from the [qemu] section to the [global] section to allow them to

Re: [PATCH v7 00/14] linux-user: brk fixes

On 8/3/23 08:01, Helge Deller wrote: * Joel Stanley : On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: 143551 brk(NULL) = 0x0009b000 143551 brk(0x0009b8fc) = 0x0009b000 I think the problem is the brk with 9b000 here. It's not 64k aligned (=pages size of your ppc64le). Please try with this

Re: [PATCH] hw/riscv: split RAM into low and high memory

On Mon, Jul 31, 2023 at 09:53:17AM +0800, Fei Wu wrote: > riscv virt platform's memory started at 0x8000 and > straddled the 4GiB boundary. Curiously enough, this choice > of a memory layout will prevent from launching a VM with > a bit more than 2000MiB and PCIe pass-thru on an x86 host, due

Re: [PATCH v3 1/3] qmp: remove virtio_list, search QOM tree instead

On Thu, Aug 03, 2023 at 10:54:58AM -0400, Jonah Palmer wrote: > The virtio_list duplicates information about virtio devices that already > exist in the QOM composition tree. Instead of creating this list of > realized virtio devices, search the QOM composition tree instead. > > This patch

Re: [PATCH v2 2/2] migration: Replace the return path retry logic

Peter Xu writes: > On Wed, Aug 02, 2023 at 05:04:45PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> >> +if (await_return_path_close_on_source(s)) { >> >> +trace_migration_return_path_pause_err(); >> >> +return MIG_THR_ERR_FATAL; >> >> +} >> > >>

Re: [PATCH v7 00/14] linux-user: brk fixes

* Joel Stanley : > On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: > > > 143551 brk(NULL) = 0x0009b000 > > > 143551 brk(0x0009b8fc) = 0x0009b000 > > > > I think the problem is the brk with 9b000 here. > > It's not 64k aligned (=pages size of your ppc64le). > > > > Please try with this patch on

Re: [PATCH v2] Fix SEGFAULT on getting physical address of MMIO region.

On 8/3/23 03:58, Mikhail Tyutin wrote: Apply save_iotlb_data() to io_readx() as well as to io_writex(). Signed-off-by: Dmitriy Solovev Signed-off-by: Mikhail Tyutin --- accel/tcg/cputlb.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-)

[PATCH v3 3/3] vhost-user: move VhostUserProtocolFeature definition to header file

Move the definition of VhostUserProtocolFeature to include/hw/virtio/vhost-user.h. Remove previous definitions in hw/scsi/vhost-user-scsi.c, hw/virtio/vhost-user.c, and hw/virtio/virtio-qmp.c. Previously there were 3 separate definitions of this over 3 different files. Now only 1 definition of

[PATCH v3 2/3] qmp: update virtio feature maps, vhost-user-gpio introspection

Add new virtio transport feature to transport feature map: - VIRTIO_F_RING_RESET Add new vhost-user protocol feature to vhost-user protocol feature map and enumeration: - VHOST_USER_PROTOCOL_F_STATUS Add new virtio device features for several virtio devices to their respective feature

[PATCH v3 1/3] qmp: remove virtio_list, search QOM tree instead

The virtio_list duplicates information about virtio devices that already exist in the QOM composition tree. Instead of creating this list of realized virtio devices, search the QOM composition tree instead. This patch modifies the QMP command qmp_x_query_virtio to instead recursively search the

[PATCH v3 0/3] qmp, vhost-user: Remove virtio_list & update virtio introspection

These patches update a few things related to virtio introspection via. QMP/HMP commands. 1. Remove 'virtio_list' and instead query the QOM composition tree to find any active & realized virtio devices. The 'virtio_list' was duplicating information about virtio devices that was already available

Re: [PATCH] target/m68k: Map FPU exceptions to FPSR register

On 8/2/23 20:52, Keith Packard via wrote: Add helpers for reading/writing the 68881 FPSR register so that changes in floating point exception state can be seen by the application. Call these helpers in pre_load/post_load hooks to synchronize exception state. Signed-off-by: Keith Packard ---

Re: [PATCH v2 1/2] migration: Split await_return_path_close_on_source

Peter Xu writes: > On Wed, Aug 02, 2023 at 04:58:38PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Aug 02, 2023 at 11:36:43AM -0300, Fabiano Rosas wrote: >> >> This function currently has a straight-forward part which is waiting >> >> for the thread to join and a complicated

Re: [PATCH] target/arm: Do not use gen_mte_checkN in trans_STGP

On 8/3/23 06:10, Peter Maydell wrote: On Thu, 27 Jul 2023 at 17:33, Richard Henderson -mop = MO_128; -if (s->align_mem) { -mop |= MO_ALIGN_8; -} -mop = finalize_memop_pair(s, mop); +mop = MO_128 | MO_ALIGN | MO_ATOM_IFALIGN_PAIR; So here we're implicitly assuming

Re: [PATCH] linux-user/elfload: Set V in ELF_HWCAP for RISC-V

On 8/3/23 10:14, Nathan Egge wrote: From: "Nathan Egge" Set V bit for hwcap if misa is set. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1793 Signed-off-by: Nathan Egge --- Tested with the example program described in the bug: === #include #include #define

Re: [PATCH v7 00/14] linux-user: brk fixes

On Thu, 3 Aug 2023 at 13:55, Helge Deller wrote: > > 143551 brk(NULL) = 0x0009b000 > > 143551 brk(0x0009b8fc) = 0x0009b000 > > I think the problem is the brk with 9b000 here. > It's not 64k aligned (=pages size of your ppc64le). > > Please try with this patch on top of Richard's series: > > > @@

Re: [PATCH v5 4/5] qmp: Added new command to retrieve eBPF blob.

On Wed, Aug 02, 2023 at 11:41:22PM +0300, Andrew Melnychenko wrote: > Now, the binary objects may be retrieved by id. > It would require for future qmp commands that may require specific > eBPF blob. > > Added command "request-ebpf". This command returns > eBPF program encoded base64. The program

Re: [PATCH v1 6/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_BCAST_REG

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Introduce a model of Xilinx Versal's Configuration Frame broadcast > controller (CFRAME_BCAST_REG). > > Signed-off-by: Francisco Iglesias > --- > hw/misc/xlnx-versal-cframe-reg.c | 173 +++ >

Re: [RFC PATCH for-8.2 00/18] crypto: Provide clmul.h and host accel

On Thu, 13 Jul 2023 at 23:14, Richard Henderson wrote: > > Inspired by Ard Biesheuvel's RFC patches [1] for accelerating > carry-less multiply under emulation. > > This is less polished than the AES patch set: > > (1) Should I split HAVE_CLMUL_ACCEL into per-width HAVE_CLMUL{N}_ACCEL? > The

Re: [PATCH v1 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Introduce a model of Xilinx Versal's Configuration Frame controller > (CFRAME_REG). > > Signed-off-by: Francisco Iglesias > --- > MAINTAINERS | 2 + > hw/misc/meson.build | 1 + >

Re: [PATCH v7 00/14] linux-user: brk fixes

On 8/3/23 15:11, Joel Stanley wrote: Hi Richard, On Thu, 3 Aug 2023 at 01:53, Richard Henderson wrote: Builds on Helge's v6, incorporating my feedback plus some other minor cleanup. This succeeds for the armhf static binary on ppc64le host that was previously segfaulting. However, the arm

Re: [PATCH v1 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Connect the Configuration Frame controller (CFRAME_REG) and the > Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the > Versal machine. > > Signed-off-by: Francisco Iglesias > +/* CFRAME REG */ > +for (i = 0; i <

Re: [PATCH v2 1/2] block/blkio: close the fd when blkio_connect() fails

On 03.08.23 10:28, Stefano Garzarella wrote: libblkio drivers take ownership of `fd` only after a successful blkio_connect(), so if it fails, we are still the owners. Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for virtio-blk") Suggested-by: Hanna Czenczek

Re: [PATCH v1 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to > the Versal machine. > > Signed-off-by: Francisco Iglesias > --- > hw/arm/xlnx-versal.c | 42 >

Re: [PATCH v1 4/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal's CFU_SFR

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Introduce a model of Xilinx Versal's Configuration Frame Unit's Single > Frame Read port (CFU_SFR). > > Signed-off-by: Francisco Iglesias > --- > hw/misc/xlnx-versal-cfu.c | 88 +++ >

Re: [PATCH v1 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Introduce a model of Xilinx Versal's Configuration Frame Unit's data out > port (CFU_FDRO). > > Signed-off-by: Francisco Iglesias > --- > hw/misc/xlnx-versal-cfu.c | 105 ++ >

Re: [PATCH v3 1/5] vhost: fix the fd leak

Am 31.07.23 um 14:10 schrieb Li Feng: > When the vhost-user reconnect to the backend, the notifer should be > cleanup. Otherwise, the fd resource will be exhausted. > > Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") > > Signed-off-by: Li Feng > Reviewed-by: Raphael Norwitz

Re: [PATCH v1 2/8] hw/misc: Introduce a model of Xilinx Versal's CFU_APB

On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: > > Introduce a model of the software programming interface (CFU_APB) of > Xilinx Versal's Configuration Frame Unit. > > Signed-off-by: Francisco Iglesias > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 0/6] Add nRF51 DETECT signal with test

On Fri, 28 Jul 2023 at 17:04, Chris Laplante wrote: > > This patch series implements the nRF51 DETECT signal > in the GPIO peripheral. A qtest is added exercising the signal. > > To implement the test, named out-GPIO IRQ interception had to be added > to the qtest framework. I also took the

[PATCH] linux-user/elfload: Set V in ELF_HWCAP for RISC-V

From: "Nathan Egge" Set V bit for hwcap if misa is set. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1793 Signed-off-by: Nathan Egge --- linux-user/elfload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index

Re: [PATCH v7 00/14] linux-user: brk fixes

Hi Richard, On Thu, 3 Aug 2023 at 01:53, Richard Henderson wrote: > > Builds on Helge's v6, incorporating my feedback plus > some other minor cleanup. This succeeds for the armhf static binary on ppc64le host that was previously segfaulting. However, the arm static binary on ppc64le host now

Re: [PATCH] target/arm: Do not use gen_mte_checkN in trans_STGP

On Thu, 27 Jul 2023 at 17:33, Richard Henderson wrote: > > STGP writes to tag memory, it does not check it. > This happened to work because we wrote tag memory first > so that the check always succeeded. > > Signed-off-by: Richard Henderson > --- > target/arm/tcg/translate-a64.c | 41

[PATCH trivial for-8.1] stubs/colo.c: spelling

Signed-off-by: Michael Tokarev --- stubs/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/colo.c b/stubs/colo.c index f33379d0fd..08c9f982d5 100644 --- a/stubs/colo.c +++ b/stubs/colo.c @@ -24 +24 @@ void migrate_start_colo_process(MigrationState *s) -

Re: [RFC PATCH 08/19] HostMem: Add private property to indicate to use kvm gmem

On 03.08.23 00:53, Isaku Yamahata wrote: On Wed, Aug 02, 2023 at 04:14:29PM +0200, David Hildenbrand wrote: On 02.08.23 10:03, Xiaoyao Li wrote: On 8/2/2023 1:21 AM, David Hildenbrand wrote: On 31.07.23 18:21, Xiaoyao Li wrote: From: Isaku Yamahata Signed-off-by: Isaku Yamahata

Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids()

On 8/3/23 09:05, Andrew Jones wrote: On Thu, Aug 03, 2023 at 08:36:57AM -0300, Daniel Henrique Barboza wrote: On 8/3/23 06:29, Andrew Jones wrote: On Wed, Aug 02, 2023 at 03:00:58PM -0300, Daniel Henrique Barboza wrote: cpu->cfg.mvendorid is a 32 bit field and kvm_set_one_reg() always

Re: [PATCH v7 13/14] linux-user: Adjust initial brk when interpreter is close to executable

Hi Richard, Thanks for putting this all together! I'll test asap. I haven't checked yet, but Akihiko did send a revised v2 patch series, while my v6 series included his older v1 patches. We should consider his latest series... One other thing below On 8/3/23 03:53, Richard Henderson

Re: [PATCH v2 08/11] hw/loongarch/virt: add plug handler for TPM on SysBus

On 7/20/23 13:57, Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: TPM needs to know its own base address in order to generate its DSDT device entry. Signed-off-by: Joelle van Dyne It would be great to also cover the crb-device  with tests: from tests/qtest/meson.build:

Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids()

On Thu, Aug 03, 2023 at 08:36:57AM -0300, Daniel Henrique Barboza wrote: > > > On 8/3/23 06:29, Andrew Jones wrote: > > On Wed, Aug 02, 2023 at 03:00:58PM -0300, Daniel Henrique Barboza wrote: > > > cpu->cfg.mvendorid is a 32 bit field and kvm_set_one_reg() always write > > > a target_ulong val,

[PATCH v9 3/4] hw/ufs: Support for UFS logical unit

This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/lu.c | 1445

[PATCH v9 2/4] hw/ufs: Support for Query Transfer Requests

This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi --- hw/ufs/trace-events | 1 + hw/ufs/ufs.c| 980

[PATCH v9 4/4] tests/qtest: Introduce tests for UFS

This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 +

[PATCH v9 0/4] hw/ufs: Add Universal Flash Storage (UFS) support

Dear Stefan, I'm really sorry, but could you please put this patch series instead of v8, which was previously merged into block-next? The fixes from v8 are below. Please let me know if you have any comments or issues. Thank you very much, Jeuk Since v8: - Fix compilation warnings (Mike Maslenkin

[PATCH v9 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage

Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches to handle UFS logical

Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids()

On 8/3/23 06:29, Andrew Jones wrote: On Wed, Aug 02, 2023 at 03:00:58PM -0300, Daniel Henrique Barboza wrote: cpu->cfg.mvendorid is a 32 bit field and kvm_set_one_reg() always write a target_ulong val, i.e. a 64 bit field in a 64 bit host. Given that we're passing a pointer to the mvendorid

[PATCH] Add api to read CPU registers in TCG plugins

From: Aleksandr Anenkov This commit: - adds a plugin API to read the registers of the current CPU - introduces qemu_plugin_reg_ctx structure for faster data gathering of a set of registers without memory reallocation - adds an example plugin showing how to work with this API - fixes for GDB

Re: QEMU developers fortnightly conference for 2023-08-08

Mark Burton wrote: > Are too many people away right now? Hi Some of us are still working O:-) But I think that the easiest way to cancel it is if nobody puts an agenda. Later, Juan.

Re: [PATCH 3/8] gitlab: always use updated msys installer

On Wed, Aug 02, 2023 at 05:49:42PM +0200, Thomas Huth wrote: > On 01/08/2023 15.03, Daniel P. Berrangé wrote: > > We current reference an msys installer binary from mid-2022, which means > > after installation, it immediately has to re-download a bunch of newer > > content. This wastes precious CI

[PULL 3/9] gitlab: print timestamps during windows msys jobs

From: Daniel P. Berrangé It is hard to get visibility into where time is consumed in our Windows msys jobs. Adding a few log console messages with the timestamp will aid in our debugging. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-Id:

[PULL 9/9] gitlab: disable FF_SCRIPT_SECTIONS on msys jobs

From: Daniel P. Berrangé The FF_SCRIPT_SECTIONS=1 variable should ordinarily cause output from each line of the job script to be presented in a collapsible section with execution time listed. While it works on Linux shared runners, when used with Windows runners with PowerShell, this option

[PULL 5/9] gitlab: drop $CI_PROJECT_DIR from cache path

From: Daniel P. Berrangé The gitlab cache is limited to only handle content within the $CI_PROJECT_DIR hierarchy, and as such relative paths are always implicitly relative to $CI_PROJECT_DIR. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-Id:

[PULL 6/9] gitlab: always populate cache for windows msys jobs

From: Daniel P. Berrangé The cache is used to hold the msys installer. Even if the build phase fails, we should still populate the cache as the installer will be valid for next time. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-Id:

[PULL 7/9] configure: support passthrough of -Dxxx args to meson

From: Daniel P. Berrangé This can be useful for setting some meson global options, such as the optimization level or debug state.xs Signed-off-by: Daniel P. Berrangé Message-Id: <20230801130403.164060-7-berra...@redhat.com> [thuth: Move the help text into the section with the other --...

[PULL 8/9] gitlab: disable optimization and debug symbols in msys build

From: Daniel P. Berrangé Building at -O2, adds 33% to the build time, over -O2. IOW a build that takes 45 minutes at -O0, takes 60 minutes at -O2. Turning off debug symbols drops it further, down to 38 minutes. IOW, a "-O2 -g" build is 58% slower than a "-O0" build on msys in the gitlab CI

[PULL 2/9] gitlab: remove duplication between msys jobs

From: Daniel P. Berrangé Although they share a common parent, the two msys jobs still have massive duplication in their script definitions that can easily be collapsed. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-Id: <20230801130403.164060-2-berra...@redhat.com>

[PULL 4/9] gitlab: always use updated msys installer

From: Daniel P. Berrangé We current reference an msys installer binary from mid-2022, which means after installation, it immediately has to re-download a bunch of newer content. This wastes precious CI time. The msys project publishes an installer binary with a fixed URL that always references

[PULL 0/9] Fixes for 8.1-rc3

The following changes since commit fb695ae3fdfe34ce7bf2eaa4595d48ca809c8841: Merge tag 'pull-qapi-2023-08-02' of https://repo.or.cz/qemu/armbru into staging (2023-08-02 06:51:53 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-03

[PULL 1/9] util/oslib-win32: Fix compiling with Clang from MSYS2

Clang complains: ../util/oslib-win32.c:483:56: error: omitting the parameter name in a function definition is a C2x extension [-Werror,-Wc2x-extensions] win32_close_exception_handler(struct _EXCEPTION_RECORD*, ^ Fix it by adding parameter

RE: [RFC PATCH] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 27 July 2023 16:43 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; ricar...@google.com; > k...@vger.kernel.org; Jonathan Cameron ; > Linuxarm > Subject: Re: [RFC

[PATCH v2] Fix SEGFAULT on getting physical address of MMIO region.

Apply save_iotlb_data() to io_readx() as well as to io_writex(). Signed-off-by: Dmitriy Solovev Signed-off-by: Mikhail Tyutin --- accel/tcg/cputlb.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/accel/tcg/cputlb.c

Re: [PATCH] hw/virtio: Add a protection against duplicate vu_scmi_stop calls

On 03/08/2023 11.50, Michael S. Tsirkin wrote: On Thu, Aug 03, 2023 at 09:38:20AM +0200, Thomas Huth wrote: On 03/08/2023 09.10, Milan Zamazal wrote: Fabiano Rosas writes: Milan Zamazal writes: The QEMU CI fails in virtio-scmi test occasionally. As reported by Thomas Huth, this happens

Re: [PATCH 3/3] target/m68k: Support semihosting on non-ColdFire targets

On Wed, 2 Aug 2023 at 17:20, Keith Packard via wrote: > > According to the m68k semihosting spec: > > "The instruction used to trigger a semihosting request depends on the > m68k processor variant. On ColdFire, "halt" is used; on other processors > (which don't implement "halt"), "bkpt #0" may

Re: [PATCH 1/3] target/m68k: Pass semihosting arg to exit

On Wed, 2 Aug 2023 at 17:20, Keith Packard via wrote: > > Instead of using d0 (the semihost function number), use d1 (the > provide exit status). > > Signed-off-by: Keith Packard > --- > target/m68k/m68k-semi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 0/3] target/m68k: Fix a few semihosting bugs

On Wed, 2 Aug 2023 at 17:20, Keith Packard via wrote: > > The first two patches mirror similar patches I recently sent for nios2. > > 1. Use correct parameter for EXIT (d1 instead of d0) > 2. Fix use of deposit64 in LSEEK (argument order was incorrect) > > The second patch has also been

Re: [PATCH] hw/virtio: Add a protection against duplicate vu_scmi_stop calls

On Thu, Aug 03, 2023 at 09:38:20AM +0200, Thomas Huth wrote: > On 03/08/2023 09.10, Milan Zamazal wrote: > > Fabiano Rosas writes: > > > > > Milan Zamazal writes: > > > > > > > The QEMU CI fails in virtio-scmi test occasionally. As reported by > > > > Thomas Huth, this happens most likely

Re: Format type of qemu NVMe virtual drive reverted back to its default (512 bytes block size) after performing hot plugout/plugin operation on that drive.

On Jul 25 16:53, Ashutosh Sharma wrote: > Hi, > > I have a virtual system created using qemu 7.2. In that system, I > attached/hot plugged a virtual NVMe drive. This drive had a default > block size of 512 bytes. > > admin@node-3:~$ sudo nvme list > Node SN

Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids()

On Wed, Aug 02, 2023 at 03:00:58PM -0300, Daniel Henrique Barboza wrote: > cpu->cfg.mvendorid is a 32 bit field and kvm_set_one_reg() always write > a target_ulong val, i.e. a 64 bit field in a 64 bit host. > > Given that we're passing a pointer to the mvendorid field, the reg is > reading 64

Re: [RFC PATCH 05/19] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

On 8/2/2023 1:10 AM, Claudio Fontana wrote: On 7/31/23 18:21, Xiaoyao Li wrote: From: Chao Peng Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that backen'ed both by hva-based shared memory and gmem fd based

Re: QEMU developers fortnightly conference for 2023-08-08

Are too many people away right now? Cheers Mark. On 3 Aug 2023, at 10:33, juan.quint...@gmail.com wrote: WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. Hi Do you have any

QEMU developers fortnightly conference for 2023-08-08

Hi Do you have any topics for next week QEMU call? You can answer this email or use the wiki: https://wiki.qemu.org/QEMUCall Thanks, Juan. QEMU developers fortnightly conference call Tuesday 2023-08-08 ⋅ 15:00 – 16:00 Central European Time - Madrid Location https://meet.jit.si/kvmcallmeeting

[PATCH v2 2/2] block/blkio: add more comments on the fd passing handling

As Hanna pointed out, it is not clear in the code why qemu_open() can fail, and why blkio_set_int("fd") is not enough to discover the `fd` property support. Let's fix them by adding more details in the code comments. Suggested-by: Hanna Czenczek Reviewed-by: Hanna Czenczek Signed-off-by:

[PATCH v2 0/2] block/blkio: fix fd leak and add more comments for the fd passing

Hanna discovered an fd leak in the error path, and a few comments to improve in the code. v2: - avoid to use `fd_supported` to track a valid fd [Hanna] v1: https://lore.kernel.org/qemu-devel/20230801160332.122564-1-sgarz...@redhat.com/ Stefano Garzarella (2): block/blkio: close the fd when

<    1   2   3   >