On 9/4/23 08:00, Alex Bennée wrote:
Due to the b4 dropping the vdso.so in the patch this fails:
Program build-vdso.sh found: YES
(/home/alex/lsrc/qemu.git/linux-user/build-vdso.sh)
../../linux-user/s390x/meson.build:24:0: ERROR: File vdso.so does not exist.
A full log can be found at
On Tue, Sep 05, 2023 at 05:36:15PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 29.08.23 20:58, Eric Blake wrote:
> > Upcoming additions to support NBD 64-bit effect lengths allow for the
> > possibility to distinguish between payload length (capped at 32M) and
> > effect length (64 bits,
On Tue, Sep 05, 2023 at 05:41:33PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > > @@ -1899,7 +1899,7 @@ static int coroutine_fn
> > > > nbd_co_send_simple_reply(NBDClient *client,
> > > > NBDRequest *request,
> > > >
On Wed, 2023-09-06 at 17:50 +0200, Philippe Mathieu-Daudé wrote:
> +rth/pm215/dhildenb
>
> On 5/9/23 16:50, Richard Purdie wrote:
> > On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote:
> > > Richard Purdie writes:
> > >
> > > > With qemu 8.1.0 we see boot hangs fox x86-64 targets.
> > > >
>
On Wed, Sep 06, 2023 at 02:04:45PM +0100, Jonathan Cameron wrote:
> On Thu, 31 Aug 2023 21:29:14 -0400
> Gregory Price wrote:
>
> Hi Gregory,
>
> Some comments inline, but I'm happy to add this to my staging tree in the
> meantime
> as it stands (might be a few days until I push a new branch
On Wed, Sep 6, 2023 at 6:01 PM Albert Esteve wrote:
>
>
> On Wed, Sep 6, 2023 at 4:43 PM Philippe Mathieu-Daudé
> wrote:
>
>> On 6/9/23 16:33, Albert Esteve wrote:
>>
>> > I note you ignored my comment regarding adding a 'Error **'
>> argument in
>> > the previous version:
>> >
>>
On 9/6/23 17:08, Avihai Horon wrote:
Initialization of mig_stats, compression_counters and VFIO bytes
transferred is hard-coded in migration code path and snapshot code path.
Make the code cleaner by initializing them in migrate_init().
Suggested-by: Cédric Le Goater
Signed-off-by: Avihai
On 6/9/23 17:50, Philippe Mathieu-Daudé wrote:
+rth/pm215/dhildenb
On 5/9/23 16:50, Richard Purdie wrote:
On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote:
Richard Purdie writes:
With qemu 8.1.0 we see boot hangs fox x86-64 targets.
These are fixed by
On Wed, Sep 6, 2023 at 4:43 PM Philippe Mathieu-Daudé
wrote:
> On 6/9/23 16:33, Albert Esteve wrote:
>
> > I note you ignored my comment regarding adding a 'Error **'
> argument in
> > the previous version:
> >
>
From: Alexander Ivanov
Write a pattern to the last cluster, extend the image by 1 claster, repair
and check that the last cluster still has the same pattern.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
From: Alexander Ivanov
Images repairing in parallels_open() was added, thus parallels tests fail.
Access to an image leads to repairing the image. Further image check don't
detect any corruption. Remove reads after image creation in test 131.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis
From: Alexander Ivanov
In this test cluster size is 64k, but modern tools generate images with
cluster size 1M. Calculate cluster size using track field from image header.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
tests/qemu-iotests/131
From: Alexander Ivanov
Replace hardcoded numbers by variables.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
tests/qemu-iotests/131 | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git
From: Alexander Ivanov
Place data_start/data_end calculation after reading the image header
to s->header. Set s->data_start to the offset calculated in
parallels_test_data_off(). Call bdrv_check() if data_off is incorrect.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
From: Alexander Ivanov
data_off field of the parallels image header can be corrupted. Check if
this field greater than the header + BAT size and less than file size.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
block/parallels.c | 80
From: Alexander Ivanov
Fill the image with a pattern to generate entries in the BAT, set the first
BAT entry outside the image, try to read the corrupted image. At the image
opening it should be repaired, check for zeroes in the first cluster.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis
From: Alexander Ivanov
Write a pattern to the first cluster. Corrupt the data_off field and check
if the field was repaired on image opening and the pattern has not changed.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
From: Alexander Ivanov
Fill a parallels image with a pattern and write another pattern to the
second cluster. Corrupt the image and check if the pattern changes. Repair
the image and check the patterns on guest and host sides.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
From: Alexander Ivanov
This patch is technically necessary as git patch rendering could result
in moving some code from one place to the another and that hits
checkpatch.pl warning. This problem specifically happens within next
series.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V.
From: Alexander Ivanov
The BDRVParallelsState structure contains data_end field that is measured
in sectors. In parallels_open() initially this field is set by data_off
field from parallels image header.
According to the parallels format documentation, data_off field contains
an offset, in
From: Alexander Ivanov
In the next patch we will need the offset of the data area for host cluster
index calculation. Add this field and setting up code.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
block/parallels.c | 7 ---
From: Alexander Ivanov
Cluster offsets must be unique among all the BAT entries. Find duplicate
offsets in the BAT and fix it by copying the content of the relevant
cluster to a newly allocated cluster and set the new cluster offset to the
duplicated entry.
Add host_cluster_index() helper to
Driver changes are driving by me for now. At least we need to get
functionally complete check and repair procedure for now.
Signed-off-by: Denis V. Lunev
Reviewed-by: Vladimir Sementsov-Ogievskiy
CC: Stefan Hajnoczi
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git
+rth/pm215/dhildenb
On 5/9/23 16:50, Richard Purdie wrote:
On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote:
Richard Purdie writes:
With qemu 8.1.0 we see boot hangs fox x86-64 targets.
These are fixed by 0d58c660689f6da1e3feff8a997014003d928b3b (softmmu:
Use async_run_on_cpu in
From: Alexander Ivanov
Repair an image at opening if the image is unclean or out-of-image
corruption was detected.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
block/parallels.c | 70 +--
1 file
From: Alexander Ivanov
In the on of the next patches we need to repair leaks without changing
leaks and leaks_fixed info in res. Also we don't want to print any warning
about leaks. Add "explicit" argument to skip info changing if the argument
is false.
Signed-off-by: Alexander Ivanov
From: Alexander Ivanov
Initially data_end is set to the data_off image header field and must not
be greater than the file size.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
block/parallels.c | 5 +
1 file changed, 5 insertions(+)
diff
From: Alexander Ivanov
bdrv_co_getlength() should be used in coroutine context. Replace
bdrv_getlength() by bdrv_co_getlength() in parallels_check_outside_image().
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
---
block/parallels.c | 2 +-
1 file
Merge tag 'pull-request-2023-08-31' of https://gitlab.com/thuth/qemu into
staging (2023-09-05 09:22:13 -0400)
are available in the Git repository at:
https://src.openvz.org/scm/~den/qemu.git tags/pull-parallels-2023-09-06
for you to fetch changes up to
On Wed, Sep 6, 2023 at 4:21 PM Philippe Mathieu-Daudé
wrote:
> On 6/9/23 13:15, Albert Esteve wrote:
> > This API manages objects (in this iteration,
> > dmabuf fds) that can be shared along different
> > virtio devices, associated to a UUID.
> >
> > The API allows the different devices to add,
On Wed, Sep 06, 2023 at 06:08:52PM +0300, Avihai Horon wrote:
> VFIO migration is not compatible with postcopy migration. A VFIO device
> in the destination can't handle page faults for pages that have not been
> sent yet.
>
> Doing such migration will cause the VM to crash in the destination:
>
On Wed, Sep 06, 2023 at 03:19:32PM +0100, Joao Martins wrote:
> On 06/09/2023 14:59, “William Roche wrote:
> > From: William Roche
> >
> > A memory page poisoned from the hypervisor level is no longer readable.
> > Thus, it is now treated as a zero-page for the ram saving migration phase.
> >
>
test-bdrv-drain is failing. I think my coroutine wrapper patch might
be necessary:
https://gitlab.com/qemu-project/qemu/-/jobs/5029372308#L4907
I have dropped this patch series for the time being. Feel free to
remove my patches and send a new revision.
I will debug the test-bdrv-drain issue.
Background snapshot allows creating a snapshot of the VM while it's
running and keeping it small by not including dirty RAM pages.
The way it works is by first stopping the VM, saving the non-iterable
devices' state and then starting the VM and saving the RAM while write
protecting it with UFFD.
VFIO migration is not compatible with postcopy migration. A VFIO device
in the destination can't handle page faults for pages that have not been
sent yet.
Doing such migration will cause the VM to crash in the destination:
qemu-system-x86_64: VFIO_MAP_DMA failed: Bad address
qemu-system-x86_64:
If a device with enable-migration=on is added and it causes a migration
blocker, adding the device should fail with a proper error.
This is not the case with multiple device migration blocker when the
blocker already exists. If the blocker already exists and a device with
enable-migration=on is
The functions in target.c are not static, yet they don't have a proper
migration prefix. Add such prefix.
Signed-off-by: Avihai Horon
Reviewed-by: Cédric Le Goater
---
migration/migration.h | 4 ++--
migration/migration.c | 6 +++---
migration/savevm.c| 2 +-
migration/target.c| 8
Initialization of mig_stats, compression_counters and VFIO bytes
transferred is hard-coded in migration code path and snapshot code path.
Make the code cleaner by initializing them in migrate_init().
Suggested-by: Cédric Le Goater
Signed-off-by: Avihai Horon
---
migration/migration.c | 14
Hello,
Recently added VFIO migration is not compatible with some of the
pre-existing migration features. This was overlooked and today these
combinations are not blocked by QEMU. This series fixes it.
Postcopy migration:
VFIO migration is not compatible with postcopy migration. A VFIO device
in
Add a new .save_prepare() handler to struct SaveVMHandlers. This handler
is called early, even before migration starts, and can be used by
devices to perform early checks.
Refactor migrate_init() to be able to return errors and call
.save_prepare() from there.
Suggested-by: Peter Xu
Hello Nina,
On 9/1/23 17:57, Nina Schoetterl-Glausch wrote:
From: Pierre Morel
On interception of STSI(15.1.x) the System Information Block
(SYSIB) is built from the list of pre-ordered topology entries.
Signed-off-by: Pierre Morel
Co-developed-by: Nina Schoetterl-Glausch
Signed-off-by:
On 6/9/23 16:33, Albert Esteve wrote:
I note you ignored my comment regarding adding a 'Error **' argument in
the previous version:
https://lore.kernel.org/qemu-devel/911eef0c-d04f-2fcf-e78b-2475cd7af...@linaro.org/
On 1/9/23 11:55, Michael Tokarev wrote:
25.08.2023 06:36, Zhao Liu wrote:
From: Zhao Liu
Hi all,
This patchset is the follow up tests of previous topology fixes in
smbios [1].
In this patchset, add these test cases:
1. Add the case to test 2 newly added topology helpers (patch 1):
*
Hey,
What's the latest on this work? It seems that all patches are acked:
https://lore.kernel.org/qemu-riscv/20230526162308.22892-1-rkan...@rivosinc.com/
It'll probably conflict with current Alistair's riscv-to-apply.next though, so
perhaps Rajnesh could gather the acks and send a rebased
On 06.09.23 16:14, David Hildenbrand wrote:
On 29.08.23 00:26, Philippe Mathieu-Daudé wrote:
On 25/8/23 15:21, David Hildenbrand wrote:
Let's return the number of free slots instead of only checking if there
is a free slot. While at it, check all address spaces, which will also
consider SMM
The following changes since commit 2d8fbcb1eecd8d39171f457e583428758321d69d:
Merge tag 'pull-request-2023-08-31' of https://gitlab.com/thuth/qemu into
staging (2023-09-05 09:22:13 -0400)
are available in the Git repository at:
https://github.com/legoater/qemu/ tags/pull-ppc-20230906
On 11/8/23 15:50, Tim Wiederhake wrote:
The isolated part will be generated by a script.
Signed-off-by: Tim Wiederhake
---
target/i386/cpu.c | 677 +---
target/i386/feature_word_info.c.inc | 676 +++
2 files changed, 677
On Wed, Sep 6, 2023 at 4:27 PM Philippe Mathieu-Daudé
wrote:
> Hi Albert,
>
> On 6/9/23 13:15, Albert Esteve wrote:
> > Add three new vhost-user protocol
> > `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`.
> > These new messages are sent from vhost-user
> > back-ends to interact with the
On 21/8/23 11:54, Tim Wiederhake wrote:
On Thu, 2023-08-17 at 12:07 +0100, Daniel P. Berrangé wrote:
On Fri, Aug 11, 2023 at 03:50:09PM +0200, Tim Wiederhake wrote:
This is the data file that will be used to generate the C code.
All information, including the comments, is preserved.
On Wed, Sep 6, 2023 at 4:22 PM Stefano Garzarella wrote:
>out = subprocess.check_output(["cargo", "read-manifest"])
> ^^^
> File "/usr/lib64/python3.11/subprocess.py", line 466, in check_output
>return
Hi Albert,
On 6/9/23 13:15, Albert Esteve wrote:
Add three new vhost-user protocol
`VHOST_USER_BACKEND_SHARED_OBJECT_* messages`.
These new messages are sent from vhost-user
back-ends to interact with the virtio-dmabuf
table in order to add or remove themselves as
virtio exporters, or lookup
On 06/09/2023 14:59, “William Roche wrote:
> From: William Roche
>
> A memory page poisoned from the hypervisor level is no longer readable.
> Thus, it is now treated as a zero-page for the ram saving migration phase.
>
> The migration of a VM will crash Qemu when it tries to read the
> memory
On Wed, Sep 06, 2023 at 12:45:29PM +0200, Paolo Bonzini wrote:
This allows building libblkio at the same time as QEMU, if QEMU is
configured with --enable-blkio --enable-download.
Signed-off-by: Paolo Bonzini
---
subprojects/libblkio.wrap | 6 ++
1 file changed, 6 insertions(+)
create mode
On Fri, Aug 11, 2023 at 03:50:09PM +0200, Tim Wiederhake wrote:
> This is the data file that will be used to generate the C code.
> All information, including the comments, is preserved.
>
> Signed-off-by: Tim Wiederhake
I'd use json I think - we don't use xml widely in qemu ATM.
> ---
>
On 6/9/23 13:15, Albert Esteve wrote:
This API manages objects (in this iteration,
dmabuf fds) that can be shared along different
virtio devices, associated to a UUID.
The API allows the different devices to add,
remove and/or retrieve the objects by simply
invoking the public functions that
On 9/6/23 16:11, Avihai Horon wrote:
On 05/09/2023 19:13, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 9/1/23 17:49, Peter Xu wrote:
On Thu, Aug 31, 2023 at 03:57:00PM +0300, Avihai Horon wrote:
Add a new .save_prepare() handler to struct
On 05/09/2023 19:13, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 9/1/23 17:49, Peter Xu wrote:
On Thu, Aug 31, 2023 at 03:57:00PM +0300, Avihai Horon wrote:
Add a new .save_prepare() handler to struct SaveVMHandlers. This
handler
is called early,
On 2023/09/06 16:56, Huang Rui wrote:
On Wed, Sep 06, 2023 at 11:39:09AM +0800, Akihiko Odaki wrote:
On 2023/09/06 12:09, Huang Rui wrote:
On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote:
On 2023/09/05 18:08, Huang Rui wrote:
On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko
On 29.08.23 00:26, Philippe Mathieu-Daudé wrote:
On 25/8/23 15:21, David Hildenbrand wrote:
Let's return the number of free slots instead of only checking if there
is a free slot. While at it, check all address spaces, which will also
consider SMM under x86 correctly.
Make the stub return
The test actually requires Python bindings to libnbd rather than libnbd
itself. Clarify that inside the message.
Signed-off-by: Denis V. Lunev
CC: Kevin Wolf
CC: Hanna Reitz
CC: Eric Blake
CC: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/nbd-multiconn | 2 +-
1 file changed, 1
Each particular testcase could skipped intentionally and accidentally.
For example the test is not designed for a particular image format or
is not run due to the missed library.
The latter case is unwanted in reality. Though the discussion has
revealed that failing the test in such a case would
We need to check that we are able to create large enough file which is
used as an export base rather than connection URL. Unfortunately, there
are cases when the TEST_IMG_FILE is not defined. We should fallback to
TEST_IMG in that case.
This problem has been detected when running
./check -nbd
Some time ago there was a discussion in the QEMU mailing list about
the situation when some IO tests were not run and thus the patch
has added a regression, namely
https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02381.html
This series contains a possible answer to the problem. Let us
From: William Roche
A Qemu VM can survive a memory error, as qemu can relay the error to the
VM kernel which could also deal with it -- poisoning/off-lining the impacted
page.
This situation creates a hole in the VM memory address space that the VM kernel
knows about (an unreadable page or set
From: William Roche
A memory page poisoned from the hypervisor level is no longer readable.
Thus, it is now treated as a zero-page for the ram saving migration phase.
The migration of a VM will crash Qemu when it tries to read the
memory address space and stumbles on the poisoned page with a
On Wed, 6 Sept 2023 at 09:07, Hao Xu wrote:
> On 5/18/23 00:26, Stefan Hajnoczi wrote:
> > On Wed, 17 May 2023 at 11:54, Alex Bennée wrote:
> > Hi Alex,
> > There were two unresolved issues:
> >
> > 1. How to inject SIGBUS when the guest accesses a page that's beyond
> > the end-of-file.
>
> Hi
Am 01.09.23 um 13:48 schrieb Janosch Frank:
Bound APQNs have to be reset before tearing down the secure config via
s390_machine_unprotect(). Otherwise the Ultravisor will return a error
code.
So let's do a subsystem_reset() which includes a AP reset before the
unprotect call. We'll do a full
Am 10.07.23 um 14:34 schrieb Fiona Ebner:
> Hi,
> since a while we have about a dozen people reporting [0] VMs rarely
> getting stuck with the QEMU process looping and just doing ppoll() and
> not much else (example strace [1] output and stacktrace [2]).
>
> Just wanted to ask if anybody here has
On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek wrote:
>
> The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
>
> Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into
> staging (2023-08-28 16:07:04 -0400)
>
> are available in the Git repository at:
>
>
Before commit "hw/ide: reset: cancel async DMA operation before
resetting state", this test would fail, because a reset with a
pending write operation would lead to an unsolicited write to the
first sector of the disk.
The test writes a pattern to the beginning of the disk and verifies
that it is
If there is a pending DMA operation during ide_bus_reset(), the fact
that the IDEState is already reset before the operation is canceled
can be problematic. In particular, ide_dma_cb() might be called and
then use the reset IDEState which contains the signature after the
reset. When used to
From: Marc-André Lureau
"blob" resources don't have an associated pixman image:
#0 pixman_image_get_stride (image=0x0) at ../pixman/pixman-image.c:921
#1 0x562327c25236 in virtio_gpu_save (f=0x56232bb13b00,
opaque=0x56232b555a60, size=0, field=0x5623289ab6c8 <__compound_literal.3+104>,
From: Marc-André Lureau
Don't forget to unmap the resource memory.
Fixes: commit 9462ff469 ("virtio-gpu/win32: allocate shareable 2d
resources/images")
Signed-off-by: Marc-André Lureau
---
hw/display/virtio-gpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On 5/18/23 00:26, Stefan Hajnoczi wrote:
On Wed, 17 May 2023 at 11:54, Alex Bennée wrote:
Hi Alex,
There were two unresolved issues:
1. How to inject SIGBUS when the guest accesses a page that's beyond
the end-of-file.
Hi Stefan,
Does this SIGBUS issue exist if the guest kernel can be
On Thu, 31 Aug 2023 21:29:14 -0400
Gregory Price wrote:
> Create a new device to emulate the SK hynix Niagara MHSLD platform.
>
> This device has custom CCI commands that allow for applying isolation
> to each memory block between hosts. This enables an early form of
> dynamic capacity, whereby
On Fri, 2023-09-01 at 11:48 +, Janosch Frank wrote:
> Bound APQNs have to be reset before tearing down the secure config via
> s390_machine_unprotect(). Otherwise the Ultravisor will return a error
> code.
>
> So let's do a subsystem_reset() which includes a AP reset before the
> unprotect
On Wed, Sep 06, 2023 at 12:25:30PM +0200, David Hildenbrand wrote:
> On 04.09.23 18:38, Daniel P. Berrangé wrote:
> > On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote:
> > > Changing the structure of qdict so that it can preserve order when
> > > iterating qdict. This will fix
On Wed, 2023-09-06 at 10:21 +0200, Thomas Huth wrote:
> On 05/09/2023 17.25, Nina Schoetterl-Glausch wrote:
> > On Tue, 2023-09-05 at 15:26 +0200, Thomas Huth wrote:
> > > On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote:
> > > > From: Pierre Morel
> > > >
> > > > On interception of
For migration purposes, users might want to reuse the default RAM
backend id, but specify a different memory backend.
For example, to reuse "pc.ram" on q35, one has to set
-machine q35,memory-backend=pc.ram
Only then, can a memory backend with the id "pc.ram" be created
manually.
Let's
It's easy to miss that memory-backend-file with "share=off" (default)
will always try opening the file R/W as default, and fail if we don't
have write permissions to the file.
In that case, the user has to explicit specify "readonly=on,rom=off" to
get usable RAM, for example, for VM templating.
"-mem-path" corresponds to "memory-backend-file,share=off" and,
therefore, creates a private COW mapping of the file. For multi-proces
QEMU, we need proper shared file-backed memory.
Let's make that clearer.
Signed-off-by: David Hildenbrand
---
docs/devel/multi-process.rst | 5 +++--
1 file
open() does not fail on directories when opening them readonly (O_RDONLY).
Currently, we succeed opening such directories and fail later during
mmap(), resulting in a misleading error message.
$ ./qemu-system-x86_64 \
-object memory-backend-file,id=ram0,mem-path=tmp,readonly=true,size=1g
fallocate() will fail, let's print a nicer error message.
Suggested-by: Peter Xu
Reviewed-by: Peter Xu
Signed-off-by: David Hildenbrand
---
softmmu/physmem.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 88482bd32a..c520c2ac55
Let's add some details about VM templating, focusing on the VM memory
configuration only.
There is much more to VM templating (VM state? block devices?), but I leave
that as future work.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Hildenbrand
---
MAINTAINERS |
Currently, if a file does not exist yet, file_ram_open() will create new
empty file and open it writable. However, it even does that when
readonly=true was specified.
Specifying O_RDONLY instead to create a new readonly file would
theoretically work, however, ftruncate() will refuse to resize the
Let's remap with the proper protection that we can derive from
RAM_READONLY.
Reviewed-by: Peter Xu
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: David Hildenbrand
---
softmmu/physmem.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/softmmu/physmem.c
For now, "share=off,readonly=on" would always result in us opening the
file R/O and mmap'ing the opened file MAP_PRIVATE R/O -- effectively
turning it into ROM.
Especially for VM templating, "share=off" is a common use case. However,
that use case is impossible with files that lack write
There is a difference between how we open a file and how we mmap it,
and we want to support writable private mappings of readonly files. Let's
define RAM_READONLY and RAM_READONLY_FD flags, to replace the single
"readonly" parameter for file-related functions.
In memory_region_init_ram_from_fd()
Currently, when using a true R/O NVDIMM (ROM memory backend) with a label
area, the VM can easily crash QEMU by trying to write to the label area,
because the ROM memory is mmap'ed without PROT_WRITE.
[root@vm-0 ~]# ndctl disable-region region0
disabled 1 region
[root@vm-0 ~]# ndctl
If there are no more comments, I'll queue this myself soon.
---
This is the result of the previous discussion of:
* "[PATCH v2] softmmu/physmem: try opening file readonly before failure
in file_ram_open" [1]
* "[PATCH v1 0/3] softmmu/physmem: file_ram_open() readonly
improvements" [2]
On Wed, Sep 6, 2023 at 1:15 PM Albert Esteve wrote:
> This API manages objects (in this iteration,
> dmabuf fds) that can be shared along different
> virtio devices, associated to a UUID.
>
> The API allows the different devices to add,
> remove and/or retrieve the objects by simply
> invoking
Hi, Jonathan
On 2023-09-05 22:34, jonathan.cameron wrote:
>
> As I understand it the distinction is more about the format / contents of
> that memory
> than how you access them.
Yes, RCH DP RCRB includes registers from PCIe Type 1 Config Header and
PCIe capabilities and extended capabilities
v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html
v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html
v3 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg06126.html
v4 link ->
Add hash function to uuid module using the
djb2 hash algorithm.
Add a couple simple unit tests for the hash
function, checking collisions for similar UUIDs.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Albert Esteve
---
include/qemu/uuid.h| 2 ++
tests/unit/test-uuid.c | 27
This API manages objects (in this iteration,
dmabuf fds) that can be shared along different
virtio devices, associated to a UUID.
The API allows the different devices to add,
remove and/or retrieve the objects by simply
invoking the public functions that reside in the
virtio-dmabuf file.
For
Add three new vhost-user protocol
`VHOST_USER_BACKEND_SHARED_OBJECT_* messages`.
These new messages are sent from vhost-user
back-ends to interact with the virtio-dmabuf
table in order to add or remove themselves as
virtio exporters, or lookup for virtio dma-buf
shared objects.
The action taken
On Tue, Sep 5, 2023 at 10:07 PM Marc-André Lureau
wrote:
> Indeed, and it is disabled not by Kconfig but by meson:
> system_ss.add(when: [pixman, 'CONFIG_ATI_VGA'], if_true:
> files('ati.c', 'ati_2d.c', 'ati_dbg.c'))
It's better to add a "depends on", so that it fails to compile with
On Wed, Sep 06, 2023 at 12:14:54PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/9/23 11:00, Daniel P. Berrangé wrote:
> > On Wed, Sep 06, 2023 at 06:42:16AM +0200, Philippe Mathieu-Daudé wrote:
> > > On 5/9/23 18:23, Peter Xu wrote:
> > > > Drop the enum in qapi because it is never used in QMP
This allows building libblkio at the same time as QEMU, if QEMU is
configured with --enable-blkio --enable-download.
Signed-off-by: Paolo Bonzini
---
subprojects/libblkio.wrap | 6 ++
1 file changed, 6 insertions(+)
create mode 100644 subprojects/libblkio.wrap
diff --git
Hi Igor, Hi Michael,
On 9/6/23 10:19, Igor Mammedov wrote:
On Tue, 5 Sep 2023 16:43:54 -0400
"Michael S. Tsirkin" wrote:
On Tue, Sep 05, 2023 at 07:45:12PM +0200, Marcello Sylverster Bauer wrote:
Hi Michael,
On 9/5/23 18:44, Michael S. Tsirkin wrote:
On Tue, Sep 05, 2023 at 05:05:33PM
101 - 200 of 286 matches
Mail list logo
