[PULL 07/51] os-posix.c: create and export os_set_runas()

2023-09-07 Thread Paolo Bonzini
From: Michael Tokarev Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake Reviewed-by: Richard Henderson Message-ID: <20230901101302.3618955-3-...@tls.msk.ru> Signed-off-by: Paolo Bonzini --- include/sysemu/os-posix.h | 1 + os-posix.c| 23 --- 2

[PULL 09/51] os-posix.c, softmmu/vl.c: move os_parse_cmd_args() into qemu_init()

2023-09-07 Thread Paolo Bonzini
From: Michael Tokarev This will stop linking softmmu-specific os_parse_cmd_args() into every qemu executable which happens to use other functions from os-posix.c, such as os_set_line_buffering() or os_setup_signal_handling(). Also, since there's no win32-specific options, *all* option parsing

Re: [PATCH v2 3/3] hw/cxl: Support 4 HDM decoders at all levels of topology

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:35, Jonathan Cameron wrote: Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP and CXL Type 3 end points. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 10 hw/cxl/cxl-component-utils.c | 27 + hw/cxl/cxl-host.c

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2023-09-07 Thread Cédric Le Goater
Hello Joao, Cedric, you mentioned that you take a look at this after you come back, not sure if that's still the plan. But it's been a while since the last version, so would you have me repost/rebase on the latest (post your PR)? Yes please. That's next on the TODO list (after some downstream

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

2023-09-07 Thread Mattias Nissler
On Tue, Sep 5, 2023 at 3:45 PM Peter Xu wrote: > > On Tue, Sep 05, 2023 at 09:38:39AM +0200, Mattias Nissler wrote: > > It would be nice to use a property on the device that originates the > > DMA operation to configure this. However, I don't see how to do this > > in a reasonable way without

Re: [PATCH v2] docs/devel: Add cross-compiling doc

2023-09-07 Thread Andrew Jones
On Thu, Sep 07, 2023 at 02:31:20PM +0200, Andrew Jones wrote: > On Thu, Sep 07, 2023 at 11:20:55AM +0100, Alex Bennée wrote: > > > > Andrew Jones writes: > > > > > Add instructions for how to cross-compile QEMU for RISC-V. The > > > file is named generically because there's no reason not to

Re: [PATCH v2 2/3] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:35, Jonathan Cameron wrote: As an encoded version of these key configuration parameters is available in a register, provide functions to extract it again so as to avoid the need for duplicating the storage. Whilst here update the _enc() function to include additional values as

Re: [PATCH v2 1/3] hw/cxl: Push cxl_decoder_count_enc() and cxl_decode_ig() into .c

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:35, Jonathan Cameron wrote: There is no strong justification for keeping these in the header so push them down into the associated cxl-component-utils.c file. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 18

Re: [PATCH] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:35, Thomas Huth wrote: TARGET_BIG_ENDIAN is *always* defined, either as 0 for little endian targets or as 1 for big endian targets. So we can use this as a value directly in places that need such a 0 or 1 for some reason, instead of taking a detour through an additional local

Re: [PATCH v2] docs/devel: Add cross-compiling doc

2023-09-07 Thread Andrew Jones
On Thu, Sep 07, 2023 at 11:20:55AM +0100, Alex Bennée wrote: > > Andrew Jones writes: > > > Add instructions for how to cross-compile QEMU for RISC-V. The > > file is named generically because there's no reason not to collect > > other architectures steps into the same file, especially because

Re: [PATCH] contrib/plugins: add Darwin support

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:44, Paolo Bonzini wrote: Under Darwin, using -shared makes it impossible to have undefined symbols and -bundle has to be used instead; so detect the OS and use different options. Based-on: <20230907101811.469236-1-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- This

Re: riscv64 virt board crash upon startup

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 13:25, Laszlo Ersek wrote: This is with QEMU v8.1.0-391-gc152379422a2. I use the command line from (scroll to the bottom): https://github.com/tianocore/edk2/commit/49f06b664018 (with "-full-screen" removed). The crash is as follows: Unexpected error in

Re: [PATCH 1/2] tcg: Add gvec compare with immediate and scalar operand

2023-09-07 Thread gaosong
在 2023/9/7 下午3:39, gaosong 写道: Hi, Richard 在 2023/8/31 上午11:09, Richard Henderson 写道: Signed-off-by: Richard Henderson ---   accel/tcg/tcg-runtime.h  |  25 ++   include/tcg/tcg-op-gvec-common.h |   6 ++   accel/tcg/tcg-runtime-gvec.c |  26 ++   tcg/tcg-op-gvec.c 

Re: [PATCH RESEND v5 14/57] target/loongarch: Implement xvadd/xvsub

2023-09-07 Thread gaosong
在 2023/9/7 下午4:31, Song Gao 写道: +static bool gen_xvaddsub_q(DisasContext *ctx, arg_vvv *a, + void (*func)(TCGv_i64, TCGv_i64, TCGv_i64, +TCGv_i64, TCGv_i64, TCGv_i64)) +{ +if (!check_vec(ctx, 32)) { +return true; +

Re: [PATCH 2/2] target/arm: Use tcg_gen_gvec_cmpi for compare vs 0

2023-09-07 Thread gaosong
在 2023/8/31 上午11:09, Richard Henderson 写道: Signed-off-by: Richard Henderson --- target/arm/tcg/translate.c | 56 ++ 1 file changed, 9 insertions(+), 47 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index

Re: [PATCH] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value

2023-09-07 Thread Peter Maydell
On Thu, 7 Sept 2023 at 12:35, Thomas Huth wrote: > > TARGET_BIG_ENDIAN is *always* defined, either as 0 for little endian > targets or as 1 for big endian targets. So we can use this as a value > directly in places that need such a 0 or 1 for some reason, instead > of taking a detour through an

Re: [PATCH] migration: Unify and trace vmstate field_exists() checks

2023-09-07 Thread Fabiano Rosas
Peter Xu writes: > For both save/load we actually share the logic on deciding whether a field > should exist. Merge the checks into a helper and use it for both save and > load. When doing so, add documentations and reformat the code to make it > much easier to read. > > The real benefit here

Re: [PATCH v7 2/4] virtio-dmabuf: introduce virtio-dmabuf

2023-09-07 Thread Albert Esteve
On Thu, Sep 7, 2023 at 10:19 AM Philippe Mathieu-Daudé wrote: > On 7/9/23 09:43, Albert Esteve wrote: > > This API manages objects (in this iteration, > > dmabuf fds) that can be shared along different > > virtio devices, associated to a UUID. > > > > The API allows the different devices to add,

[PATCH] contrib/plugins: add Darwin support

2023-09-07 Thread Paolo Bonzini
Under Darwin, using -shared makes it impossible to have undefined symbols and -bundle has to be used instead; so detect the OS and use different options. Based-on: <20230907101811.469236-1-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- This replaces Philippe's patch to link with

[PATCH] ff

2023-09-07 Thread Paolo Bonzini
--- .gitlab-ci.d/cirrus/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml index a9444902ec8..8c71c70574a 100644 --- a/.gitlab-ci.d/cirrus/build.yml +++ b/.gitlab-ci.d/cirrus/build.yml @@ -29,7 +29,7 @@

Re: [PATCH 0/3] hw/mips/jazz: Rework the NIC init code

2023-09-07 Thread Thomas Huth
On 01/09/2023 12.15, Michael Tokarev wrote: 25.08.2023 20:51, Thomas Huth wrote: The NIC init code of the jazz machines is rather cumbersome, with a for-loop around it that is always left after the first iteration. This patch series reworks this a little bit to make the code more readable and

[PATCH v2 3/3] hw/cxl: Support 4 HDM decoders at all levels of topology

2023-09-07 Thread Jonathan Cameron via
Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP and CXL Type 3 end points. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 10 hw/cxl/cxl-component-utils.c | 27 + hw/cxl/cxl-host.c | 65 ++---

[PATCH v2 2/3] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-07 Thread Jonathan Cameron via
As an encoded version of these key configuration parameters is available in a register, provide functions to extract it again so as to avoid the need for duplicating the storage. Whilst here update the _enc() function to include additional values as defined in the CXL 3.0 specification. Whilst

[PATCH v2 1/3] hw/cxl: Push cxl_decoder_count_enc() and cxl_decode_ig() into .c

2023-09-07 Thread Jonathan Cameron via
There is no strong justification for keeping these in the header so push them down into the associated cxl-component-utils.c file. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 18 ++ hw/cxl/cxl-component-utils.c |

[PATCH v2 0/3] hw/cxl: Support emulating 4 HDM decoders throughout topology

2023-09-07 Thread Jonathan Cameron via
v2: - New patch to push previously static inline functions out of cxl_component.h - Add the CXL r3.0 expanded set of decoder counts - making it more obviously why a switch function makes sense. - Use computed difference in HDM1 and HDM0 decoder registers sets instead of 0x20 / 4. -

[PATCH] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value

2023-09-07 Thread Thomas Huth
TARGET_BIG_ENDIAN is *always* defined, either as 0 for little endian targets or as 1 for big endian targets. So we can use this as a value directly in places that need such a 0 or 1 for some reason, instead of taking a detour through an additional local variable or something similar.

Re: [PATCH v2 3/3] gdbstub: replace exit(0) with proper shutdown

2023-09-07 Thread Clément Chigot
Hi Peter, On Mon, Sep 4, 2023 at 2:46 PM Clément Chigot wrote: > > On Mon, Sep 4, 2023 at 11:42 AM Peter Maydell > wrote: > > > > On Mon, 4 Sept 2023 at 10:36, Clément Chigot wrote: > > > > > > On Mon, Sep 4, 2023 at 11:23 AM Peter Maydell > > > wrote: > > > > > > > > On Wed, 23 Aug 2023 at

Re: [RFC 0/3] qmp: make qmp_device_add() a coroutine

2023-09-07 Thread Paolo Bonzini
On 9/6/23 21:01, Stefan Hajnoczi wrote: It is not safe to call drain_call_rcu() from qmp_device_add() because some call stacks are not prepared for drain_call_rcu() to drop the Big QEMU Lock (BQL). For example, device emulation code is protected by the BQL but when it calls aio_poll() -> ... ->

[PATCH v3 5/5] gdbstub: replace exit calls with proper shutdown for softmmu

2023-09-07 Thread Clément Chigot
This replaces the exit calls by shutdown requests, ensuring a proper cleanup of Qemu. Features like net/vhost-vdpa.c are expecting qemu_cleanup to be called to remove their last residuals. Signed-off-by: Clément Chigot --- gdbstub/gdbstub.c | 5 +++-- gdbstub/softmmu.c | 6

[PATCH v3 0/5] Risc-V/gdb: replace exit calls with proper shutdown

2023-09-07 Thread Clément Chigot
This series replaces some of the call to exit in hardware used by Risc-V boards or made when gdb is requested to exit by shutdown requests. Otherwise, the gdb connection can be abruptly disconnected resulting in the last gdb packet "Wxx" being not sent. For the gdbstub modification, gdb_exit

[PATCH v3 4/5] hw/char: riscv_htif: replace exit calls with proper shutdown

2023-09-07 Thread Clément Chigot
This replaces the exit calls by shutdown requests, ensuring a proper cleanup of Qemu. Otherwise, some connections like gdb could be broken before its final packet ("Wxx") is being sent. This part, being done inside qemu_cleanup function, can be reached only when the main loop exits after a

Re: [PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-07 Thread Jonathan Cameron via
On Tue, 5 Sep 2023 18:55:23 +0200 Philippe Mathieu-Daudé wrote: > On 5/9/23 17:06, Jonathan Cameron wrote: > > On Tue, 5 Sep 2023 15:56:39 +0100 > > Jonathan Cameron via wrote: > > > >> On Mon, 4 Sep 2023 20:26:59 +0200 > >> Philippe Mathieu-Daudé wrote: > >> > >>> On 4/9/23 18:47,

[PATCH v3 3/5] hw/misc/sifive_test.c: replace exit calls with proper shutdown

2023-09-07 Thread Clément Chigot
This replaces the exit calls by shutdown requests, ensuring a proper cleanup of Qemu. Otherwise, some connections like gdb could be broken before its final packet ("Wxx") is being sent. This part, being done inside qemu_cleanup function, can be reached only when the main loop exits after a

[PATCH v3 1/5] softmmu: add means to pass an exit code when requesting a shutdown

2023-09-07 Thread Clément Chigot
As of now, the exit code was either EXIT_FAILURE when a panic shutdown was requested or EXIT_SUCCESS otherwise. However, some hardware could want to pass more complex exit codes. Thus, introduce a new shutdown request function allowing that. Signed-off-by: Clément Chigot ---

[PATCH v3 2/5] softmmu: pass the main loop status to gdb "Wxx" packet

2023-09-07 Thread Clément Chigot
gdb_exit function aims to close gdb sessions and sends the exit code of the current execution. It's being called by qemu_cleanup once the main loop is over. Until now, the exit code sent was always 0. Now that hardware can shutdown this main loop with custom exit codes, these codes must be

riscv64 virt board crash upon startup

2023-09-07 Thread Laszlo Ersek
This is with QEMU v8.1.0-391-gc152379422a2. I use the command line from (scroll to the bottom): https://github.com/tianocore/edk2/commit/49f06b664018 (with "-full-screen" removed). The crash is as follows: Unexpected error in object_property_find_err() at

Re: [PATCH 0/5] contrib/plugins: Build fixes for Darwin

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 12:57, Paolo Bonzini wrote: On 9/7/23 12:49, Philippe Mathieu-Daudé wrote: - Fix string formats - Link with GLib Alex, Thomas: FWIW, plugins aren't build on CI. They become tested with my patch "configure: unify recursion into sub-Makefiles", which is how I got into this business. 

Re: [PULL 00/14] Block patches

2023-09-07 Thread Hanna Czenczek
On 06.09.23 15:18, Stefan Hajnoczi wrote: On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek wrote: The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81: Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 -0400) are

Re: [PATCH v3 2/3] i386: Explicitly ignore unsupported BUS_MCEERR_AO MCE on AMD guest

2023-09-07 Thread Gupta, Pankaj
On 9/6/2023 10:53 PM, John Allen wrote: From: William Roche AMD guests can't currently deal with BUS_MCEERR_AO MCE injection as it panics the VM kernel. We filter this event and provide a warning message. Signed-off-by: William Roche --- v3: - New patch --- target/i386/kvm/kvm.c | 13

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2023-09-07 Thread Joao Martins
On 22/06/2023 22:48, Joao Martins wrote: > Hey, > > This series introduces support for vIOMMU with VFIO device migration, > particurlarly related to how we do the dirty page tracking. > > Today vIOMMUs serve two purposes: 1) enable interrupt remaping 2) > provide dma translation services for

Re: CXL Namespaces of ACPI disappearing in Qemu demo

2023-09-07 Thread Jonathan Cameron via
On Wed, 6 Sep 2023 19:22:19 +0800 Yuquan Wang wrote: > Hi, Jonathan > On 2023-09-05 22:34, jonathan.cameron wrote: > > > > As I understand it the distinction is more about the format / contents of > > that memory > > than how you access them. > > Yes, RCH DP RCRB includes registers from

Re: [PATCH 0/5] contrib/plugins: Build fixes for Darwin

2023-09-07 Thread Paolo Bonzini
On 9/7/23 12:49, Philippe Mathieu-Daudé wrote: - Fix string formats - Link with GLib Alex, Thomas: FWIW, plugins aren't build on CI. They become tested with my patch "configure: unify recursion into sub-Makefiles", which is how I got into this business. So I'll queue these patches and

Re: [PATCH] contrib/plugins: fix -Wformat issues

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 12:34, Paolo Bonzini wrote: On macOS, compiling contrib/plugins incurs several -Wformat warnings; fix them. Signed-off-by: Paolo Bonzini --- contrib/plugins/cache.c| 10 +- contrib/plugins/drcov.c| 2 +- contrib/plugins/howvec.c | 4 ++--

[PATCH 4/5] contrib/plugins/lockstep: Fix string format

2023-09-07 Thread Philippe Mathieu-Daudé
This fixes on Darwin: plugins/lockstep.c:138:25: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] us->pc, them->pc, g_slist_length(divergence_log), ^~

[PATCH 3/5] contrib/plugins/howvec: Fix string format

2023-09-07 Thread Philippe Mathieu-Daudé
This fixes on Darwin: plugins/howvec.c:186:40: warning: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] class->count); ^~~~

[PATCH 5/5] contrib/plugins: Link with GLib

2023-09-07 Thread Philippe Mathieu-Daudé
This fixes on Darwin: ld: symbol(s) not found for architecture arm64 "_g_string_append_printf", referenced from: _log_stats in cache.o _log_top_insns in cache.o _append_stats_line in cache.o ld: symbol(s) not found for architecture arm64 "_g_string_free",

[PATCH 1/5] contrib/plugins/cache: Fix string format

2023-09-07 Thread Philippe Mathieu-Daudé
This fixes on Darwin: plugins/cache.c:550:28: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] l1_daccess, ^~ plugins/cache.c:551:28: warning: format

[PATCH 2/5] contrib/plugins/drcov: Fix string format

2023-09-07 Thread Philippe Mathieu-Daudé
This fixes on Darwin: plugins/drcov.c:52:13: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] start_code, end_code, entry, path); ^~ plugins/drcov.c:52:25: warning: format specifies

[PATCH 0/5] contrib/plugins: Build fixes for Darwin

2023-09-07 Thread Philippe Mathieu-Daudé
Trivial: - Fix string formats - Link with GLib Alex, Thomas: FWIW, plugins aren't build on CI. Based-on: <20230907101811.469236-1-pbonz...@redhat.com> Philippe Mathieu-Daudé (5): contrib/plugins/cache: Fix string format contrib/plugins/drcov: Fix string format contrib/plugins/howvec: Fix

Re: [PATCH] contrib/plugins: remove -soname argument

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 12:18, Paolo Bonzini wrote: -soname is not needed for runtime-loaded modules. For example, Meson says: if not isinstance(target, build.SharedModule) or target.force_soname: # Add -Wl,-soname arguments on Linux, -install_name on OS X

Re: [PATCH v4 07/11] softmmu/physmem: Never return directories from file_ram_open()

2023-09-07 Thread David Hildenbrand
On 07.09.23 12:31, Mario Casquero wrote: Tested-by: Mario Casquero Thanks Mario! -- Cheers, David / dhildenb

[PATCH] contrib/plugins: fix -Wformat issues

2023-09-07 Thread Paolo Bonzini
On macOS, compiling contrib/plugins incurs several -Wformat warnings; fix them. Signed-off-by: Paolo Bonzini --- contrib/plugins/cache.c| 10 +- contrib/plugins/drcov.c| 2 +- contrib/plugins/howvec.c | 4 ++-- contrib/plugins/lockstep.c | 6 +++--- 4 files changed, 11

Re: [PATCH v4 07/11] softmmu/physmem: Never return directories from file_ram_open()

2023-09-07 Thread Mario Casquero
This series has been successfully tested by QE. Specify a directory for the mem-path of a memory-backend-file object. Check the error message has been improved without referring to a device, which can lead to confusion. Tested-by: Mario Casquero On Wed, Sep 6, 2023 at 2:07 PM David

Re: [PATCH v2] docs/devel: Add cross-compiling doc

2023-09-07 Thread Alex Bennée
Andrew Jones writes: > Add instructions for how to cross-compile QEMU for RISC-V. The > file is named generically because there's no reason not to collect > other architectures steps into the same file, especially because > several subsections like those for cross-compiling QEMU dependencies >

[PATCH] contrib/plugins: remove -soname argument

2023-09-07 Thread Paolo Bonzini
-soname is not needed for runtime-loaded modules. For example, Meson says: if not isinstance(target, build.SharedModule) or target.force_soname: # Add -Wl,-soname arguments on Linux, -install_name on OS X commands += linker.get_soname_args(

Re: [PATCH v22 17/20] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-07 Thread Thomas Huth
On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-07 Thread Daniel P . Berrangé
On Thu, Sep 07, 2023 at 10:35:22AM +0100, Peter Maydell wrote: > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > Kevin Wolf writes: > > > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > >> By the time of the 8.2.0 release, it will have been 2 years and 6 > > >>

Re: [PATCH] hw/riscv: split RAM into low and high memory

2023-09-07 Thread Wu, Fei
On 9/7/2023 5:10 PM, Eric Auger wrote: > Hi, > > On 9/7/23 09:16, Philippe Mathieu-Daudé wrote: >> Widening Cc to ARM/VFIO. >> >> On 4/8/23 11:15, Wu, Fei wrote: >>> On 8/3/2023 11:07 PM, Andrew Jones wrote: On Mon, Jul 31, 2023 at 09:53:17AM +0800, Fei Wu wrote: > riscv virt platform's

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > By the time of the 8.2.0 release, it will have been 2 years and 6 > releases since we accidentally broke setting of array properties > for user creatable devices: > > https://gitlab.com/qemu-project/qemu/-/issues/1090 > > Some context: > > * Initial identification

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-07 Thread Peter Maydell
On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > Kevin Wolf writes: > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > >> By the time of the 8.2.0 release, it will have been 2 years and 6 > >> releases since we accidentally broke setting of array properties > >> for

Re: [PATCH 0/1] qom: fix setting of qdev array properties

2023-09-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: >> By the time of the 8.2.0 release, it will have been 2 years and 6 >> releases since we accidentally broke setting of array properties >> for user creatable devices: >> >>

Re: [PATCH v5 20/20] linux-user/s390x: Add vdso

2023-09-07 Thread Alex Bennée
Richard Henderson writes: > On 9/4/23 08:00, Alex Bennée wrote: >> Due to the b4 dropping the vdso.so in the patch this fails: >>Program build-vdso.sh found: YES >> (/home/alex/lsrc/qemu.git/linux-user/build-vdso.sh) >>../../linux-user/s390x/meson.build:24:0: ERROR: File vdso.so does

Re: [PATCH] docs/devel: Add cross-compiling doc

2023-09-07 Thread Alex Bennée
Andrew Jones writes: > Add instructions for how to cross-compile QEMU for RISC-V. The > file is named generically because there's no reason not to collect > other architectures steps into the same file, especially because > several subsections like those for cross-compiling QEMU dependencies >

Re: [PATCH] hw/riscv: split RAM into low and high memory

2023-09-07 Thread Eric Auger
Hi, On 9/7/23 09:16, Philippe Mathieu-Daudé wrote: > Widening Cc to ARM/VFIO. > > On 4/8/23 11:15, Wu, Fei wrote: >> On 8/3/2023 11:07 PM, Andrew Jones wrote: >>> On Mon, Jul 31, 2023 at 09:53:17AM +0800, Fei Wu wrote: riscv virt platform's memory started at 0x8000 and straddled the

Re: [PATCH v3 32/32] hw/riscv/shakti_c: Check CPU type in machine_run_board_init()

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan --- hw/riscv/shakti_c.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

Re: [PATCH v3 0/6] vfio/migration: Block VFIO migration with postcopy and background snapshot

2023-09-07 Thread Cédric Le Goater
[ ... ] Applied to vfio-next. On that topic I am preparing a PR. Juan, Peter, Leonardo, is it ok for you if these migration changes go through the VFIO tree ? Thanks, C.

Re: [PATCH v3 30/32] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init()

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do it by ourselves. Signed-off-by: Gavin Shan --- hw/arm/sbsa-ref.c | 21 +++-- 1 file changed, 3 insertions(+), 18

Re: [PATCH v22 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-09-07 Thread Thomas Huth
On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch ---

Re: [PATCH v3 27/32] machine: Print CPU model name instead of CPU type name

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: The names of supported CPU models instead of CPU types should be printed when the user specified CPU type isn't supported, to be consistent with the output from '-cpu ?'. Correct the error messages to print CPU model names instead of CPU type names.

Re: [PATCH v22 15/20] tests/avocado: s390x cpu topology polarization

2023-09-07 Thread Thomas Huth
On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

Re: [PATCH v3 28/32] hw/arm/virt: Check CPU type in machine_run_board_init()

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: Set mc->valid_cpu_types so that the user specified CPU type can be validated in machine_run_board_init(). We needn't to do the check by ourselves. Signed-off-by: Gavin Shan --- hw/arm/virt.c | 21 +++-- 1 file changed, 3 insertions(+), 18

Re: [PATCH v3 24/32] machine: Constify MachineClass::valid_cpu_types[i]

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: Constify MachineClass::valid_cpu_types[i], as suggested by Richard Henderson. Suggested-by: Richard Henderson Signed-off-by: Gavin Shan --- hw/m68k/q800.c | 2 +- include/hw/boards.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v3 0/6] vfio/migration: Block VFIO migration with postcopy and background snapshot

2023-09-07 Thread Cédric Le Goater
On 9/6/23 17:08, Avihai Horon wrote: Hello, Recently added VFIO migration is not compatible with some of the pre-existing migration features. This was overlooked and today these combinations are not blocked by QEMU. This series fixes it. Postcopy migration: VFIO migration is not compatible

Re: [PATCH v3 01/32] cpu: Add helper cpu_model_from_type()

2023-09-07 Thread Philippe Mathieu-Daudé
On 7/9/23 02:35, Gavin Shan wrote: Add helper cpu_model_from_type() to extract the CPU model name from the CPU type name in two circumstances: (1) The CPU type name is the combination of the CPU model name and suffix. (2) The CPU type name is same to the CPU model name. The helper will be used

Re: [PATCH] docs/devel: Add cross-compiling doc

2023-09-07 Thread Andrew Jones
On Thu, Sep 07, 2023 at 01:13:33PM +1000, Alistair Francis wrote: > On Wed, Jul 26, 2023 at 10:08 PM Andrew Jones wrote: > > > > Add instructions for how to cross-compile QEMU for RISC-V. The > > file is named generically because there's no reason not to collect > > other architectures steps into

[PATCH] disas/riscv: Fix the typo of inverted order of pmpaddr13 and pmpaddr14

2023-09-07 Thread Alvin Chang
Fix the inverted order of pmpaddr13 and pmpaddr14 in csr_name(). Signed-off-by: Alvin Chang --- disas/riscv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disas/riscv.c b/disas/riscv.c index 3873a69157..8e89e1d115 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@

[PATCH v2] docs/devel: Add cross-compiling doc

2023-09-07 Thread Andrew Jones
Add instructions for how to cross-compile QEMU for RISC-V. The file is named generically because there's no reason not to collect other architectures steps into the same file, especially because several subsections like those for cross-compiling QEMU dependencies using meson and a cross-file could

[PATCH RESEND v5 51/57] target/loongarch: Implement xvinsgr2vr xvpickve2gr

2023-09-07 Thread Song Gao
This patch includes: - XVINSGR2VR.{W/D}; - XVPICKVE2GR.{W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/insns.decode | 7 +++ target/loongarch/disas.c| 17 target/loongarch/insn_trans/trans_vec.c.inc | 48 + 3 files changed,

[PATCH RESEND v5 06/57] target/loongarch: Use gen_helper_gvec_3 for 3OP vector instructions

2023-09-07 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/helper.h | 214 +- target/loongarch/vec_helper.c | 444 +--- target/loongarch/insn_trans/trans_vec.c.inc | 19 +- 3 files changed, 326 insertions(+), 351 deletions(-) diff --git

[PATCH RESEND v5 08/57] target/loongarch: Use gen_helper_gvec_2 for 2OP vector instructions

2023-09-07 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/helper.h | 58 - target/loongarch/vec_helper.c | 124 ++-- target/loongarch/insn_trans/trans_vec.c.inc | 16 ++- 3 files changed, 101 insertions(+), 97 deletions(-) diff --git

[PATCH RESEND v5 27/57] target/loongarch; Implement xvdiv/xvmod

2023-09-07 Thread Song Gao
This patch includes: - XVDIV.{B/H/W/D}[U]; - XVMOD.{B/H/W/D}[U]. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 17 + target/loongarch/disas.c| 17 + target/loongarch/vec_helper.c

[PATCH RESEND v5 12/57] target/loongarch: check_vec support check LASX instructions

2023-09-07 Thread Song Gao
Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/cpu.h | 2 ++ target/loongarch/cpu.c | 2 ++ target/loongarch/insn_trans/trans_vec.c.inc | 6 ++ 3 files changed, 10 insertions(+) diff --git a/target/loongarch/cpu.h

[PATCH RESEND v5 25/57] target/loongarch: Implement xvmul/xvmuh/xvmulw{ev/od}

2023-09-07 Thread Song Gao
This patch includes: - XVMUL.{B/H/W/D}; - XVMUH.{B/H/W/D}[U]; - XVMULW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVMULW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 38 target/loongarch/disas.c

[PATCH RESEND v5 13/57] target/loongarch: Add avail_LASX to check LASX instructions

2023-09-07 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/translate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/loongarch/translate.h b/target/loongarch/translate.h index 89b49a859e..195f53573a 100644 --- a/target/loongarch/translate.h +++

[PATCH RESEND v5 49/57] target/loongarch: Implement xvfcmp

2023-09-07 Thread Song Gao
This patch includes: - XVFCMP.cond.{S/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/helper.h | 8 +- target/loongarch/insns.decode | 3 + target/loongarch/disas.c| 93 +

[PATCH RESEND v5 15/57] target/loongarch: Implement xvreplgr2vr

2023-09-07 Thread Song Gao
This patch includes: - XVREPLGR2VR.{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 5 target/loongarch/disas.c| 10 +++ target/loongarch/insn_trans/trans_vec.c.inc | 29 - 3

[PATCH RESEND v5 18/57] target/loongarch: Implement xvsadd/xvssub

2023-09-07 Thread Song Gao
This patch includes: - XVSADD.{B/H/W/D}[U]; - XVSSUB.{B/H/W/D}[U]. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 18 ++ target/loongarch/disas.c| 17 +

[PATCH RESEND v5 36/57] target/loongarch: Implement xvsllwil xvextl

2023-09-07 Thread Song Gao
This patch includes: - XVSLLWIL.{H.B/W.H/D.W}; - XVSLLWIL.{HU.BU/WU.HU/DU.WU}; - XVEXTL.Q.D, VEXTL.QU.DU. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 9 + target/loongarch/disas.c| 9 +

[PATCH RESEND v5 26/57] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od}

2023-09-07 Thread Song Gao
This patch includes: - XVMADD.{B/H/W/D}; - XVMSUB.{B/H/W/D}; - XVMADDW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVMADDW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 34 ++ target/loongarch/disas.c

[PATCH RESEND v5 20/57] target/loongarch: Implement xvaddw/xvsubw

2023-09-07 Thread Song Gao
This patch includes: - XVADDW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVSUBW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVADDW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode | 45 target/loongarch/disas.c| 43 +++

[PATCH RESEND v5 54/57] target/loongarch: Implement xvshuf xvperm{i} xvshuf4i

2023-09-07 Thread Song Gao
This patch includes: - XVSHUF.{B/H/W/D}; - XVPERM.W; - XVSHUF4i.{B/H/W/D}; - XVPERMI.{W/D/Q}; - XVEXTRINS.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/helper.h | 3 + target/loongarch/insns.decode | 21 target/loongarch/disas.c

[PATCH RESEND v5 43/57] target/loongarch: Implement xvpcnt

2023-09-07 Thread Song Gao
This patch includes: - VPCNT.{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 5 + target/loongarch/disas.c| 5 + target/loongarch/vec_helper.c | 3 ++-

[PATCH RESEND v5 37/57] target/loongarch: Implement xvsrlr xvsrar

2023-09-07 Thread Song Gao
This patch includes: - XVSRLR[I].{B/H/W/D}; - XVSRAR[I].{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 17 + target/loongarch/disas.c| 18 ++ target/loongarch/vec_helper.c

[PATCH RESEND v5 22/57] target/loongarch: Implement xvabsd

2023-09-07 Thread Song Gao
This patch includes: - XVABSD.{B/H/W/D}[U]. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 9 + target/loongarch/disas.c| 9 + target/loongarch/insn_trans/trans_vec.c.inc | 8 3 files

[PATCH RESEND v5 41/57] target/loongarch: Implement xvssrlrn xvssrarn

2023-09-07 Thread Song Gao
This patch includes: - XVSSRLRN.{B.H/H.W/W.D}; - XVSSRARN.{B.H/H.W/W.D}; - XVSSRLRN.{BU.H/HU.W/WU.D}; - XVSSRARN.{BU.H/HU.W/WU.D}; - XVSSRLRNI.{B.H/H.W/W.D/D.Q}; - XVSSRARNI.{B.H/H.W/W.D/D.Q}; - XVSSRLRNI.{BU.H/HU.W/WU.D/DU.Q}; - XVSSRARNI.{BU.H/HU.W/WU.D/DU.Q}. Signed-off-by: Song Gao ---

[PATCH RESEND v5 44/57] target/loongarch: Implement xvbitclr xvbitset xvbitrev

2023-09-07 Thread Song Gao
This patch includes: - XVBITCLR[I].{B/H/W/D}; - XVBITSET[I].{B/H/W/D}; - XVBITREV[I].{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode | 27 + target/loongarch/disas.c| 25

[PATCH RESEND v5 56/57] target/loongarch: Move simply DO_XX marcos togther

2023-09-07 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/vec.h| 42 ++ target/loongarch/vec_helper.c | 48 --- 2 files changed, 42 insertions(+), 48 deletions(-) diff --git a/target/loongarch/vec.h b/target/loongarch/vec.h index

[PATCH RESEND v5 01/57] target/loongarch: Renamed lsx*.c to vec* .c

2023-09-07 Thread Song Gao
Renamed lsx_helper.c to vec_helper.c and trans_lsx.c.inc to trans_vec.c.inc So LASX can used them. Signed-off-by: Song Gao --- target/loongarch/translate.c| 2 +- target/loongarch/{lsx_helper.c => vec_helper.c} | 2 +-

[PATCH RESEND v5 55/57] target/loongarch: Implement xvld xvst

2023-09-07 Thread Song Gao
This patch includes: - XVLD[X], XVST[X]; - XVLDREPL.{B/H/W/D}; - XVSTELM.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode | 18 +++ target/loongarch/disas.c| 24 target/loongarch/insn_trans/trans_vec.c.inc | 143 ++--

[PATCH RESEND v5 03/57] target/loongarch: Use gen_helper_gvec_4_ptr for 4OP + env vector instructions

2023-09-07 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/helper.h | 16 +- target/loongarch/vec_helper.c | 12 +++ target/loongarch/insn_trans/trans_vec.c.inc | 35 - 3 files changed, 41 insertions(+), 22 deletions(-) diff --git

<    1   2   3   4   >