[PATCH v4 33/47] hw/m68k/q800: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse If a corresponding NIC configuration was found, it will have a MAC address already assigned, so use that. Else, generate and assign a default one. Using qemu_find_nic_info() is simpler than the alternative of using qemu_configure_nic_device() and then having to fetch the

[PATCH v4 12/47] hw/mips/fuloong2e: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse The previous behaviour was: *if* the first NIC specified on the command line was an RTL8139 (or unspecified model) then it gets assigned to PCI slot 7, which is where the Fuloong board had an RTL8139. All other devices (including the first, if it was specified as anything

[PATCH v4 22/47] hw/arm/aspeed: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Acked-by: Cédric Le Goater --- hw/arm/aspeed.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index cc59176563..bed5e4f40b 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@

[PATCH v4 35/47] hw/mips/mipssim: use qemu_create_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse The MIPS SIM platform instantiates its NIC only if a corresponding configuration exists for it. Use qemu_create_nic_device() function for that. Signed-off-by: David Woodhouse --- hw/mips/mipssim.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH v4 36/47] hw/mips/jazz: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/mips/jazz.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c index 0d2348aa5a..5bf3e328db 100644 --- a/hw/mips/jazz.c +++ b/hw/mips/jazz.c @@ -119,15 +119,19 @@ static

[PATCH v4 44/47] net: remove qemu_check_nic_model()

2024-01-26 Thread David Woodhouse
From: David Woodhouse There are no callers of this function any more, as they have all been converted to qemu_{create,configure}_nic_device(). Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- include/net/net.h | 1 - net/net.c | 13 - 2 files changed, 14

[PATCH v4 26/47] hw/net/lan9118: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preseve the existing behaviour for now. Signed-off-by: David Woodhouse --- hw/arm/kzm.c | 4 ++--

[PATCH v4 29/47] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Rather than just using qemu_configure_nic_device(), populate the MAC address in the system-registers device by peeking at the NICInfo before it's assigned to the device. Generate the MAC address early, if there is no matching -nic option. Otherwise the MAC address wouldn't

[PATCH v4 20/47] hw/xtensa/virt: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/xtensa/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xtensa/virt.c b/hw/xtensa/virt.c index a6cf646e99..5310a88861 100644 --- a/hw/xtensa/virt.c +++ b/hw/xtensa/virt.c @@

[PATCH v4 40/47] hw/riscv: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/riscv/microchip_pfsoc.c | 14 ++ hw/riscv/sifive_u.c| 7 +-- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/hw/riscv/microchip_pfsoc.c b/hw/riscv/microchip_pfsoc.c

[PATCH v4 38/47] hw/net/lasi_i82596: use qemu_create_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Create the device only if there is a corresponding NIC config for it. Remove the explicit check on nd_table[0].used from hw/hppa/machine.c which (since commit d8a3220005d7) tries to do the same thing. The lasi_82596 support has been disabled since it was first introduced,

[PATCH v4 03/47] net: add qemu_create_nic_bus_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse This will instantiate any NICs which live on a given bus type. Each bus is allowed *one* substitution (for PCI it's virtio → virtio-net-pci, for Xen it's xen → xen-net-device; no point in overengineering it unless we actually want more). Signed-off-by: David Woodhouse

[PATCH v4 37/47] hw/net/lasi_i82596: Re-enable build

2024-01-26 Thread David Woodhouse
From: David Woodhouse When converting to the shiny build-system-du-jour, a typo prevented the last_i82596 driver from being built. Correct the config option name to re-enable the build. And include "sysemu/sysemu.h" so it actually builds. Fixes: b1419fa66558 ("meson: convert hw/net")

[PATCH v4 09/47] hw/arm/virt: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/arm/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5cbc69dff8..ad8e7edb8c 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1454,9 +1454,7

[PATCH v4 34/47] hw/microblaze: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/microblaze/petalogix_ml605_mmu.c | 3 +-- hw/microblaze/petalogix_s3adsp1800_mmu.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/microblaze/petalogix_ml605_mmu.c

[PATCH v4 19/47] hw/sparc64/sun4u: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse The first sunhme NIC gets placed a function 1 on slot 1 of PCI bus A, and the rest are dynamically assigned on PCI bus B. Previously, any PCI NIC would get the special treatment purely by virtue of being first in the list. Signed-off-by: David Woodhouse Reviewed-by:

[PATCH v4 15/47] hw/ppc/prep: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Previously, the first PCI NIC would be placed in PCI slot 3 and the rest would be dynamically assigned. Even if the user overrode the default NIC type and made it something other than PCNet. Now, the first PCNet NIC (that is, anything not explicitly specified to be

[PATCH v4 04/47] hw/pci: add pci_init_nic_devices(), pci_init_nic_in_slot()

2024-01-26 Thread David Woodhouse
From: David Woodhouse The loop over nd_table[] to add PCI NICs is repeated in quite a few places. Add a helper function to do it. Some platforms also try to instantiate a specific model in a specific slot, to match the real hardware. Add pci_init_nic_in_slot() for that purpose. Signed-off-by:

[PATCH v4 21/47] hw/arm/allwinner: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/arm/allwinner-a10.c | 6 +- hw/arm/allwinner-h3.c | 6 +- hw/arm/allwinner-r40.c | 27 ++- 3 files changed, 4 insertions(+), 35 deletions(-) diff --git

[PATCH v4 02/47] net: report list of available models according to platform

2024-01-26 Thread David Woodhouse
From: David Woodhouse By noting the models for which a configuration was requested, we can give the user an accurate list of which NIC models were actually available on the platform/configuration that was otherwise chosen. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant ---

[PATCH v4 32/47] hw/m68k/mcf5208: use qemu_create_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/m68k/mcf5208.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index d22d8536db..0cfb806c20 100644 --- a/hw/m68k/mcf5208.c +++

[PATCH v4 42/47] hw/sparc/sun4m: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Obtain the MAC address from the NIC configuration if there is one, or generate one explicitly so that it can be placed in the PROM. Signed-off-by: David Woodhouse --- hw/sparc/sun4m.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH v4 00/47] Rework matching of network devices to -nic options

2024-01-26 Thread David Woodhouse
Most platforms iterating directly over the nd_table[] are doing one of two things. Either they are creating the NIC for their platform and want to find a matching -nic configuration for it, if such exists. Or they are only going to create that platform NIC if a matching config *does* exist.

[PATCH v4 11/47] hw/loongarch: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Song Gao --- hw/loongarch/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index c9a680e61a..0ad7d8c887 100644 --- a/hw/loongarch/virt.c +++

[PATCH v4 27/47] hw/arm/highbank: use qemu_create_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/arm/highbank.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index c21e18d08f..6a0e20e58d 100644 --- a/hw/arm/highbank.c +++

[PATCH v4 05/47] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling pci_init_nic_devices() for the rest. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/pc.c| 31

[PATCH v4 16/47] hw/ppc/spapr: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Avoid directly referencing nd_table[] by first instantiating any spapr-vlan devices using a qemu_get_nic_info() loop, then calling pci_init_nic_devices() to do the rest. No functional change intended. Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth ---

[PATCH v4 08/47] hw/arm/sbsa-ref: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Leif Lindholm --- hw/arm/sbsa-ref.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 477dca0637..f0171176ea 100644 --- a/hw/arm/sbsa-ref.c +++

[PATCH v4 47/47] net: make nb_nics and nd_table[] static in net/net.c

2024-01-26 Thread David Woodhouse
From: David Woodhouse Also remove the stale declaration of host_net_devices; the actual definition was removed long ago in commit 7cc28cb06104 ("net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands") Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth ---

[PATCH v4 10/47] hw/hppa: use pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/hppa/machine.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 9e611620cc..a1045b48cc 100644 --- a/hw/hppa/machine.c +++

[PATCH v4 31/47] hw/net/etraxfs-eth: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Thomas Huth --- hw/cris/axis_dev88.c | 9 - hw/net/etraxfs_eth.c | 5 ++--- include/hw/cris/etraxfs.h | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/cris/axis_dev88.c

[PATCH v2] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-01-26 Thread David Woodhouse
From: David Woodhouse We can't just embed labels directly into files like qemu-options.hx which are included from multiple top-level RST files, because Sphinx sees the labels as duplicate: https://github.com/sphinx-doc/sphinx/issues/9707 So add an 'emitrefs' option to the Sphinx hxtool-doc

intermittent failure in test-aio-multithread

2024-01-26 Thread Peter Maydell
Anybody got any idea about this one? ERROR:../tests/unit/test-aio-multithread.c:371:test_multi_fair_mutex: assertion failed (counter == atomic_counter): (316636 == 316637) (test program exited with status code -6) See https://gitlab.com/qemu-project/qemu/-/issues/2127 for links to the CI job

Re: [PATCH 2/2] bulk: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Thomas Huth
On 25/01/2024 17.56, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h | 9 +++ hw/i386/vmmouse.c

Re: [PATCH 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-01-26 Thread Thomas Huth
On 26/01/2024 11.44, Philippe Mathieu-Daudé wrote: Hi Thomas, On 26/1/24 09:39, Thomas Huth wrote: Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth ---   target/arm/tcg/cpu-v7m.c   | 292

Re: [PATCH v3 45/46] net: remove qemu_show_nic_models(), qemu_find_nic_model()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 17:49 +0100, Thomas Huth wrote: > > Can we please keep "Available" instead of "Supported" ? ... since not each > NIC is supported on each machine type... Done, thanks. smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH v3 00/46] Rework matching of network devices to -nic options

2024-01-26 Thread Thomas Huth
On 25/01/2024 01.38, Jason Wang wrote: On Wed, Jan 24, 2024 at 9:14 PM David Woodhouse wrote: Hi Jason, I think this series probably lives or dies with you. I think it's a worthwhile cleanup, but I no longer have an immediate need for it; I shipped a slightly ugly workaround in QEMU 8.2.

Re: [PATCH v3 45/46] net: remove qemu_show_nic_models(), qemu_find_nic_model()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse These old functions can be removed now too. Let net_param_nic() print the full set of network devices directly, and also make it note that a list more specific to this platform/config will be available by using '-nic model=help'

Re: [PULL 00/17] aspeed queue

2024-01-26 Thread Cédric Le Goater
) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20240126 for you to fetch changes up to b40769f4b49d15485ffaaa7acade3e3593ee6daa: hw/fsi: Update MAINTAINER list (2024-01-26 14:22:08 +0100

Re: [PATCH v3 42/46] hw/xtensa/xtfpga: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xtensa/xtfpga.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index fbad1c83a3..f49e6591dc 100644 ---

Re: [PATCH v3 36/46] hw/mips/jazz: use qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 17:29 +0100, Thomas Huth wrote: > On 08/01/2024 21.27, David Woodhouse wrote: > > From: David Woodhouse > > > > Extract the MAC address from the NICInfo, or generate one explicitly if > > there was no corresponding NIC configuration, to put it in the PROM. > > Uh, I don't

Re: [PATCH v3 39/46] hw/riscv: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/riscv/microchip_pfsoc.c | 14 ++ hw/riscv/sifive_u.c| 7 +-- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/hw/riscv/microchip_pfsoc.c

Re: [PATCH v3 38/46] hw/openrisc/openrisc_sim: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/openrisc/openrisc_sim.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index

Re: [PATCH v2 14/14] contrib/plugins/execlog: fix new warnings

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > ‘g_pattern_match_string’ is deprecated, > Use 'g_pattern_spec_match_string' instead. Unfortunately this isn't enough as we can still build on older glibs: /* Ask for warnings for anything that was marked deprecated in * the defined version, or before. It is a

Re: [PATCH v3 37/46] hw/net/lasi_i82596: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/net/lasi_i82596.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/lasi_i82596.c b/hw/net/lasi_i82596.c index 6a3147fe2d..2bb4f2c4ca 100644 ---

Re: [PATCH v3 36/46] hw/mips/jazz: use qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Extract the MAC address from the NICInfo, or generate one explicitly if there was no corresponding NIC configuration, to put it in the PROM. Uh, I don't see any MAC handling in the patch below? Is this the right comment for

Re: [PATCH v2 13/14] MAINTAINERS: Add myself as reviewer for TCG Plugins

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 11/14] plugins: remove non per_vcpu inline operation from API

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > Now we have a thread-safe equivalent of inline operation, and that all > plugins were changed to use it, there is no point to keep the old API. > > In more, it will help when we implement more functionality (conditional > callbacks), as we can assume that we operate on

[Bug 1225187] Re: qemu hangs in windows 7 host with -serial pipe:windbg

2024-01-26 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1225187 Title: qemu hangs in windows 7 host with -serial pipe:windbg Status in QEMU: Invalid Bug

Re: [PATCH v3 31/46] hw/net/etraxfs-eth: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/cris/axis_dev88.c | 9 - hw/net/etraxfs_eth.c | 5 ++--- include/hw/cris/etraxfs.h | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v3 35/46] hw/mips/mipssim: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse The MIPS SIM platform instantiates its NIC only if a corresponding configuration exists for it. Use qemu_create_nic_device() function for that. Signed-off-by: David Woodhouse --- hw/mips/mipssim.c | 13 +++-- 1 file

Re: [PATCH v3 46/46] net: make nb_nics and nd_table[] static in net/net.c

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Please add: "Also remove the leftover definition of host_net_devices which has been forgotten to be removed in commit 7cc28cb061040cb089." (or so) With that: Reviewed-by: Thomas Huth Signed-off-by: David Woodhouse ---

Re: [PATCH v2 05/14] tests/plugin: add test plugin for inline operations

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > For now, it simply performs instruction, bb and mem count, and ensure > that inline vs callback versions have the same result. Later, we'll > extend it when new inline operations are added. > > Use existing plugins to test everything works is a bit cumbersome, as >

Re: [PATCH v3 44/46] hw/pci: remove pci_nic_init_nofail()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse This function is no longer used. Signed-off-by: David Woodhouse --- hw/pci/pci.c | 72 include/hw/pci/pci.h | 3 -- 2 files changed, 75 deletions(-) Reviewed-by:

Re: [PATCH v3 43/46] net: remove qemu_check_nic_model()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Please add a short patch description à la "All callers have been converted in the previous patches, so this is not required anymore". With that: Reviewed-by: Thomas Huth Signed-off-by: David Woodhouse ---

Re: [PATCH v3 34/46] hw/microblaze: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/microblaze/petalogix_ml605_mmu.c | 3 +-- hw/microblaze/petalogix_s3adsp1800_mmu.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PULL 00/17] aspeed queue

2024-01-26 Thread Peter Maydell
in the Git repository at: > > https://github.com/legoater/qemu/ tags/pull-aspeed-20240126 > > for you to fetch changes up to b40769f4b49d15485ffaaa7acade3e3593ee6daa: > > hw/fsi: Update MAINTAINER list (2024-01-26 14:22:08 +0100) > > --

Re: [PATCH v3 32/46] hw/m68k/mcf5208: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.27, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/m68k/mcf5208.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index d22d8536db..0cfb806c20 100644 ---

Re: [PATCH v3 27/46] hw/arm/highbank: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/highbank.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index c21e18d08f..6a0e20e58d 100644 ---

Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 15:33 +, Peter Maydell wrote: > On Fri, 26 Jan 2024 at 15:20, David Woodhouse wrote: > > > > On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > > > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > > > +   

Re: [PATCH 06/10] m68k: Clean up includes

2024-01-26 Thread Thomas Huth
On 25/01/2024 17.34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git m68k include/hw/audio/asc.h include/hw/m68k/*.h All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include

KVM Forum 2024?

2024-01-26 Thread Brian Cain
All, https://kvm-forum.qemu.org/ shows a plan for "Spring 2024" - so that's as soon as ~mid-March or as late as mid-June? I'd like to understand if we think that it's more likely to be later in that range? Last year was mid June I think? So should we expect something similar this year?

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 15:26, Zhao Liu wrote: > > On Thu, Jan 25, 2024 at 04:34:02PM +, Peter Maydell wrote: > > Date: Thu, 25 Jan 2024 16:34:02 + > > From: Peter Maydell > > Subject: [PATCH 04/10] aspeed: Clean up includes > > X-Mailer: git-send-email 2.34.1 > > > > This commit was

Re: [PATCH v3 10/46] hw/hppa: use pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/hppa/machine.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index c8da7c18d5..19d477105e 100644 ---

Re: [PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 16:14 +0100, Thomas Huth wrote: > > >    /* Legacy helper function.  Should go away when machine config files are > >   implemented.  */ > > -void smc91c111_init(NICInfo *nd, uint32_t base, qemu_irq irq) > > +void smc91c111_init(uint32_t base, qemu_irq irq) > >    { > >  

Re: [PATCH 10/10] misc: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:08PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:08 + > From: Peter Maydell > Subject: [PATCH 10/10] misc: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 15:20, David Woodhouse wrote: > > On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > > +const char *alias); > > > +bool

Re: [PATCH 02/10] hyperv: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:00PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:00 + > From: Peter Maydell > Subject: [PATCH 02/10] hyperv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH 06/10] m68k: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:04PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:04 + > From: Peter Maydell > Subject: [PATCH 06/10] m68k: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:01PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:01 + > From: Peter Maydell > Subject: [PATCH 03/10] disas/riscv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: >

Re: [PATCH v3 09/46] hw/arm/virt: use pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 2793121cb4..8cf9237001 100644 --- a/hw/arm/virt.c +++

Re: [PATCH 07/10] include: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:05PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:05 + > From: Peter Maydell > Subject: [PATCH 07/10] include: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH 08/10] cxl: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:06PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:06 + > From: Peter Maydell > Subject: [PATCH 08/10] cxl: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes. > > All .c should include

Re: [PATCH v3 07/46] hw/alpha/dp264: use pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/alpha/dp264.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index 03495e1e60..52a1fa310b 100644 --- a/hw/alpha/dp264.c +++

Re: [PATCH 09/10] riscv: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:07PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:07 + > From: Peter Maydell > Subject: [PATCH 09/10] riscv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH 05/10] acpi: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:03PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:03 + > From: Peter Maydell > Subject: [PATCH 05/10] acpi: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:02PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:02 + > From: Peter Maydell > Subject: [PATCH 04/10] aspeed: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes. > > All .c should include

Re: [PULL 11/33] scsi: only access SCSIDevice->requests from one thread

2024-01-26 Thread Hanna Czenczek
On 26.01.24 14:18, Kevin Wolf wrote: Am 25.01.2024 um 18:32 hat Hanna Czenczek geschrieben: On 23.01.24 18:10, Kevin Wolf wrote: Am 23.01.2024 um 17:40 hat Hanna Czenczek geschrieben: On 21.12.23 22:23, Kevin Wolf wrote: From: Stefan Hajnoczi Stop depending on the AioContext lock and

spapr watchdog vs watchdog_perform_action() / QMP watchdog-set-action

2024-01-26 Thread Peter Maydell
Hi; one of the "bitesized tasks" we have listed is to convert watchdog timers which directly call qemu_system_reset_request() on watchdog timeout to call watchdog_perform_action() instead. This means they honour the QMP commands that let the user specifiy the behaviour on watchdog expiry:

Re: [PATCH v1 2/3] virtio-gpu.c: add resource_destroy class method

2024-01-26 Thread Philippe Mathieu-Daudé
Hi Manos, On 26/1/24 15:41, Manos Pitsidianakis wrote: When destroying/unrefing resources, devices such as virtio-gpu-rutabaga need to do their own bookkeeping (free rutabaga resources that are associated with the virtio_gpu_simple_resource). This commit adds a class method so that

Re: [PATCH v3 0/9] Enabling DCD emulation support in Qemu

2024-01-26 Thread Jonathan Cameron via
On Thu, 16 Nov 2023 16:09:03 -0800 Ira Weiny wrote: > nifan.cxl@ wrote: > > From: Fan Ni > > > > > > The patch series are based on Jonathan's branch cxl-2023-09-26. > > Finally getting around to trying this new series and the patch series does not > seem to apply on top of this branch? >

Re: [PATCH v3 01/46] net: add qemu_{configure,create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 14:43 +, Peter Maydell wrote: > > > +NICInfo *qemu_find_nic_info(const char *typename, bool match_default, > > +    const char *alias); > > +bool qemu_configure_nic_device(DeviceState *dev, bool match_default, > > +  

Re: [PATCH v2 04/14] plugins: add inline operation per vcpu

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > Extends API with three new functions: > qemu_plugin_register_vcpu_{tb, insn, mem}_exec_inline_per_vcpu(). > > Those functions takes a qemu_plugin_u64_t as input. > > This allows to have a thread-safe and type-safe version of inline > operations. > > Signed-off-by:

Re: [PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preserve the existing behaviour for now. Signed-off-by: David Woodhouse ---

Re: [PATCH v2 02/14] plugins: scoreboard API

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > We introduce a cpu local storage, automatically managed (and extended) > by QEMU itself. Plugin allocate a scoreboard, and don't have to deal > with how many cpus are launched. > > This API will be used by new inline functions but callbacks can benefit > from this as

Re: [PULL v3 00/18] Block layer patches

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 12:28, Kevin Wolf wrote: > > The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057: > > Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into > staging (2024-01-25 12:33:42 +) > > are available in the Git repository at: > >

Re: [PATCH v3 24/46] hw/arm/fsl: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/fsl-imx25.c | 2 +- hw/arm/fsl-imx6.c | 2 +- hw/arm/fsl-imx6ul.c | 2 +- hw/arm/fsl-imx7.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v3 23/46] hw/arm/exynos4: use qemu_create_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/exynos4_boards.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index b0e13eb4f0..003992189b 100644 ---

Re: [PATCH v3 21/46] hw/arm/allwinner: use qemu_configure_nic_device()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/allwinner-a10.c | 6 +- hw/arm/allwinner-h3.c | 6 +- hw/arm/allwinner-r40.c | 27 ++- 3 files changed, 4 insertions(+), 35 deletions(-) diff

Re: [PATCH v4 33/66] i386/tdx: Make memory type private by default

2024-01-26 Thread David Hildenbrand
On 25.01.24 04:22, Xiaoyao Li wrote: By default (due to the recent UPM change), restricted memory attribute is shared. Convert the memory region from shared to private at the memory slot creation time. add kvm region registering function to check the flag and convert the region, and add memory

Re: [PATCH v4 45/66] memory: Introduce memory_region_init_ram_guest_memfd()

2024-01-26 Thread David Hildenbrand
On 25.01.24 04:23, Xiaoyao Li wrote: Introduce memory_region_init_ram_guest_memfd() to allocate private guset memfd on the MemoryRegion initialization. It's for the use case of TDVF, which must be private on TDX case. Signed-off-by: Xiaoyao Li --- include/exec/memory.h | 6 ++

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-26 Thread Fabiano Rosas
Peter Maydell writes: > On Fri, 26 Jan 2024 at 14:36, Fabiano Rosas wrote: >> >> pet...@redhat.com writes: >> >> > From: Fabiano Rosas >> > >> > The 'max' cpu is not expected to be stable in terms of features across >> > QEMU versions, so it should not be expected to migrate. >> > >> > While

Re: [PATCH v3 2/9] hw/hppa/machine: Disable default devices with --nodefaults option

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 15:49 +0100, Helge Deller wrote: > > > As part of the -nic rework¹ I plan to allow the user to explicitly > > specify "lasi_82596" as the model if they want one, or else the default > > -nic will be a PCI one as it is at the moment. OK? > > Yes, that would be great. Looks

Re: [PATCH v3 2/9] hw/hppa/machine: Disable default devices with --nodefaults option

2024-01-26 Thread Helge Deller
On 1/26/24 13:02, David Woodhouse wrote: On Fri, 2024-01-12 at 11:29 +0100, del...@kernel.org wrote: From: Helge Deller Recognize the qemu --nodefaults option, which will disable the following default devices on hppa: - lsi53c895a SCSI controller, - artist graphics card, - LASI 82596 NIC, -

Re: [PATCH v3 20/46] hw/xtensa/virt: use pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xtensa/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xtensa/virt.c b/hw/xtensa/virt.c index a6cf646e99..5310a88861 100644 --- a/hw/xtensa/virt.c +++

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Peter Maydell
On Mon, 8 Jan 2024 at 20:49, David Woodhouse wrote: > > From: David Woodhouse > > Most code which directly accesses nd_table[] and nb_nics uses them for > one of two things. Either "I have created a NIC device and I'd like a > configuration for it", or "I will create a NIC device *if* there is a

[PATCH v1 3/3] virtio-gpu-rutabaga.c: override resource_destroy method

2024-01-26 Thread Manos Pitsidianakis
When the Rutabaga GPU device frees resources, it calls rutabaga_resource_unref for that resource_id. However, when the generic VirtIOGPU functions destroys resources, it only removes the virtio_gpu_simple_resource from the device's VirtIOGPU->reslist list. The rutabaga resource associated with

[PATCH v1 2/3] virtio-gpu.c: add resource_destroy class method

2024-01-26 Thread Manos Pitsidianakis
When destroying/unrefing resources, devices such as virtio-gpu-rutabaga need to do their own bookkeeping (free rutabaga resources that are associated with the virtio_gpu_simple_resource). This commit adds a class method so that virtio-gpu-rutabaga can override it in the next commit.

[PATCH v1 1/3] hw/display/virtio-gpu.c: use reset_bh class method

2024-01-26 Thread Manos Pitsidianakis
While the VirtioGPU type has a reset_bh field to specify a reset callback, it's never used. virtio_gpu_reset() calls the general virtio_gpu_reset_bh() function for all devices that inherit from VirtioGPU. While no devices override reset_bh at the moment, a device reset might require special logic

[PATCH v1 0/3] Fix resource freeing bugs in virtio-gpu-rutabaga

2024-01-26 Thread Manos Pitsidianakis
While testing the rutabaga gpu device, we noticed that if the device is reset, it stops working and complains about missing resource ids. A quick investigation discovered that the generic VirtIOGPU implementation frees all resources, but for Rutabaga, they are tied with rutabaga objects that

<    1   2   3   4   >