Re: [PATCH v3 0/5] hw/arm/aspeed: Check for CPU types in machine_run_board_init()

2024-01-26 Thread Cédric Le Goater
On 1/25/24 06:55, Philippe Mathieu-Daudé wrote: Series fully reviewed. Since v2: - Addressed Gavin & Richard review comments. - Collected R-b tags Since v1: - Follow suggestions from Cédric from [*] [*] https://lore.kernel.org/qemu-devel/e13c655b-7904-4e47-a673-4efd13c26...@kaod.org/

Re: [PATCH v12 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Cédric Le Goater
On 1/26/24 11:49, Ninad Palsule wrote: Hello, Please review the patch-set version 12. I have incorporated review comments from Cedric. v12: - Minor changes. - Added reviewed by tags. Ninad Palsule (11): hw/fsi: Introduce IBM's Local bus hw/fsi: Introduce IBM's scratchpad device

Re: [PATCH] tests/avocado/machine_aspeed.py: Update buildroot images to 2023.11

2024-01-26 Thread Cédric Le Goater
On 1/9/24 18:35, Cédric Le Goater wrote: Compared to mainline buildroot, these images have some customization : - Linux version is bumped to 6.6.3 and built with a custom config - U-Boot is switched to the one provided by OpenBMC for more support - defconfigs extra tools for dev See branch [1]

[PATCH v2 5/5] hw/cxl: Standardize all references on CXL r3.1 and minor updates

2024-01-26 Thread Jonathan Cameron via
Previously not all references mentioned any spec version at all. Given r3.1 is the current specification available for evaluation at www.computeexpresslink.org update references to refer to that. Hopefully this won't become a never ending job. A few structure definitions have been updated to add

[PATCH v2 3/5] hw/cxl: Update RAS Capability Definitions for version 3.

2024-01-26 Thread Jonathan Cameron via
Part of bringing all of CXL emulation inline with CXL r3.1. No functional changes. Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 5 - hw/cxl/cxl-component-utils.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/5] hw/cxl: Update mailbox status registers.

2024-01-26 Thread Jonathan Cameron via
Whilst the reported version was 1 so there should be no changes, a couple of fields (where the value 0 was valid) were not defined. Make those explicit and update references to be based on CXL r3.1. Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 17

[PATCH v2 2/5] hw/cxl: Update link register definitions.

2024-01-26 Thread Jonathan Cameron via
Not actually implemented, but we need to reserve more space for the larger version of the structure in CXL r3.1. Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v12 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Cédric Le Goater
On 1/26/24 11:49, Ninad Palsule wrote: Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff. --- docs/specs/fsi.rst | 126 +++ docs/specs/index.rst | 1 + 2 files changed, 127 insertions(+) create

[PATCH v2 1/5] hw/cxl: Update HDM Decoder capability to version 3

2024-01-26 Thread Jonathan Cameron via
Part of standardizing the QEMU code on CXL r3.1. No fuctional changes as everything added is optional and it is set as not implemented. Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_component.h | 16 ++-- hw/cxl/cxl-component-utils.c | 10 +-

[PATCH v2 0/5 qemu] hw/cxl: Update CXL emulation to reflect and reference r3.1

2024-01-26 Thread Jonathan Cameron via
v2: Thanks Fan for the quick review! - Fixed some wrong section numbers. Last year a reviewer requested that the versioning and references in the CXL code pointed out at a specific available specification revision (Sorry I can't remember who!) That drew my attention to the complete mess of

Re: [PATCH] hw/timer/hpet: fix IRQ routing in legacy support mode

2024-01-26 Thread David Woodhouse
On Thu, 2023-10-19 at 01:00 +0100, David Woodhouse wrote: > From: David Woodhouse > > The interrupt from timer 0 in legacy mode is supposed to go to IRQ 0 on > the i8259 and IRQ 2 on the I/O APIC. The generic x86 GSI handling can't > cope with IRQ numbers differing between the two chips (despite

Re: [PATCH v4 1/6] hw/xen: Set XenBackendInstance in the XenDevice before realizing it

2024-01-26 Thread David Woodhouse
On Sat, 2023-12-02 at 01:41 +, Volodymyr Babchuk wrote: > From: David Woodhouse > > This allows a XenDevice implementation to know whether it was created > by QEMU, or merely discovered in XenStore after the toolstack created > it. This will allow us to create frontend/backend nodes only

[PATCH v2 12/12] tests/acpi: Update DSDT.cxl to reflect change _STA return value.

2024-01-26 Thread Jonathan Cameron via
_STA will now return 0xB (in common with most other devices) rather than not setting the bits to indicate this fake device has not been enabled, and self tests haven't passed. Signed-off-by: Jonathan Cameron --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - tests/data/acpi/q35/DSDT.cxl

Re: [PATCH v2 01/14] plugins: implement inline operation relative to cpu_index

2024-01-26 Thread Alex Bennée
Pierrick Bouvier writes: > Instead of working on a fixed memory location, allow to address it based > on cpu_index, an element size and a given offset. > Result address: ptr + offset + cpu_index * element_size. > > With this, we can target a member in a struct array from a base pointer. > >

[PATCH v2 11/12] hw/i386: Fix _STA return value for ACPI0017

2024-01-26 Thread Jonathan Cameron via
Found whilst testing a series for the linux kernel that actually bothers to check if enabled is set. 0xB is the option used for vast majority of DSDT entries in QEMU. It is a little odd for a device that doesn't really exist and is simply a hook to tell the OS there is a CEDT table but 0xB seems a

[PATCH v2 10/12] tests/acpi: Allow update of DSDT.cxl

2024-01-26 Thread Jonathan Cameron via
The _STA value returned currently indicates the ACPI0017 device is not enabled. Whilst this isn't a real device, setting _STA like this may prevent an OS from enumerating it correctly and hence from parsing the CEDT table. Signed-off-by: Jonathan Cameron ---

[PATCH v2 09/12] hw/mem/cxl_type3: Fix potential divide by zero reported by coverity

2024-01-26 Thread Jonathan Cameron via
Fixes Coverity ID 1522368. Currently error_fatal is set if interleave_ways_dec() is going to return 0 but we should handle that zero return explicitly. Reported-by: Stefan Hajnoczi Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- Note this is a stop gap until a more complex HDM

[PATCH v2 08/12] hw/cxl: Pass NULL for a NULL MemoryRegionOps

2024-01-26 Thread Jonathan Cameron via
From: Li Zhijian a NULL parameter is enough for a NULL MemoryRegionOps Reviewed-by: Fan Ni Signed-off-by: Li Zhijian Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-component-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cxl/cxl-component-utils.c

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Michael Tokarev
26.01.2024 14:01, Daniel P. Berrangé: [] We should try to use O_CLOEXEC everywhere, but at the same time QEMU links to a large number of libraries, and we can't assume that they've reliably used O_CLOEXEC. Non-QEMU owned code that is mapped in process likely dwarfs QEMU owned code by a factor of

[PATCH v2 07/12] hw/cxl: Pass CXLComponentState to cache_mem_ops

2024-01-26 Thread Jonathan Cameron via
From: Li Zhijian cache_mem_ops.{read,write}() interprets opaque as CXLComponentState(cxl_cstate) instead of ComponentRegisters(cregs). Fortunately, cregs is the first member of cxl_cstate, so their values are the same. Fixes: 9e58f52d3f8 ("hw/cxl/component: Introduce CXL components (8.1.x,

[PATCH v2 05/12] hw/cxl/mbox: Remove dead code

2024-01-26 Thread Jonathan Cameron via
From: Davidlohr Bueso Two functions were reported to have dead code, remove the bogus branches altogether, as well as a misplaced qemu_log call. Reported-by: Peter Maydell Reviewed-by: Fan Ni Signed-off-by: Davidlohr Bueso Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 43

[PATCH v2 06/12] hw/cxl/device: read from register values in mdev_reg_read()

2024-01-26 Thread Jonathan Cameron via
From: Hyeonggon Yoo <42.hye...@gmail.com> In the current mdev_reg_read() implementation, it consistently returns that the Media Status is Ready (01b). This was fine until commit 25a52959f99d ("hw/cxl: Add support for device sanitation") because the media was presumed to be ready. However, as per

[PATCH v2 04/12] cxl/cdat: Fix header sum value in CDAT checksum

2024-01-26 Thread Jonathan Cameron via
From: Ira Weiny The addition of the DCD support for CXL type-3 devices extended the CDAT table large enough that the checksum being returned was incorrect.[1] This was because the checksum value was using the header length field rather than each of the 4 bytes of the length field. This was

[PATCH v2 03/12] hw/pci-bridge/cxl_upstream: Drop g_malloc() failure handling

2024-01-26 Thread Jonathan Cameron via
As a failure of g_malloc() will result in QEMU exiting, it won't return a NULL to check. As such, drop the incorrect handling of such NULL returns in the cdat table building code. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/cxl_upstream.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH v2 02/12] hw/mem/cxl_type3: Drop handling of failure of g_malloc0() and g_malloc()

2024-01-26 Thread Jonathan Cameron via
As g_malloc0/g_malloc() will just exit QEMU on failure there is no point in checking for it failing. Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- v2: Fix up description to include g_malloc() --- hw/mem/cxl_type3.c | 52 +++--- 1 file changed,

Re: [PATCH v3 2/9] hw/hppa/machine: Disable default devices with --nodefaults option

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-12 at 11:29 +0100, del...@kernel.org wrote: > From: Helge Deller > > Recognize the qemu --nodefaults option, which will disable the > following default devices on hppa: > - lsi53c895a SCSI controller, > - artist graphics card, > - LASI 82596 NIC, > - tulip PCI NIC, > - second

[PATCH v2 01/12] cxl/cdat: Handle cdat table build errors

2024-01-26 Thread Jonathan Cameron via
From: Ira Weiny The callback for building CDAT tables may return negative error codes. This was previously unhandled and will result in potentially huge allocations later on in ct3_build_cdat() Detect the negative error code and defer cdat building. Fixes: f5ee7413d592 ("hw/mem/cxl-type3: Add

[PATCH v2 00/12 qemu] CXL emulation fixes and minor cleanup.

2024-01-26 Thread Jonathan Cameron via
v2: - Patch description fixes to correctly refer to g_malloc() either with or instead of g_malloc0() depending on the patch. - Add missing brackets for QEMU style as reported by checkpatch. - Gathered some tags from Fan (thanks!) This set includes the majority of fixes I currently have

Re: [PATCH 09/12] hw/mem/cxl_type3: Fix potential divide by zero reported by coverity

2024-01-26 Thread Jonathan Cameron via
On Wed, 24 Jan 2024 15:53:58 -0800 fan wrote: > On Wed, Jan 24, 2024 at 12:40:57PM +, Jonathan Cameron wrote: > > Fixes Coverity ID 1522368. > > > > Currently error_fatal is set if interleave_ways_dec() is going to return 0 > > but we should handle that zero return explicitly. > > > >

Re: [PATCH 5/5] hw/cxl: Standardize all references on CXL r3.1 and minor updates

2024-01-26 Thread Jonathan Cameron via
On Wed, 24 Jan 2024 12:58:19 -0800 fan wrote: > On Wed, Jan 24, 2024 at 01:48:14PM +, Jonathan Cameron wrote: > > Previously not all references mentioned any spec version at all. > > Given r3.1 is the current specification available for evaluation at > > www.computeexpresslink.org update

Re: [PATCH v4] hw/char/imx_serial: Implement receive FIFO and ageing timer for imx serial.

2024-01-26 Thread Peter Maydell
On Thu, 25 Jan 2024 at 15:22, Rayhan Faizel wrote: > > This patch implements a 32 half word FIFO as per imx serial device > specifications. If a non empty FIFO is below the trigger level, an ageing > timer will tick for a duration of 8 characters. On expiry, AGTIM will be set > triggering an

Re: [PATCH] iotests/277: Use iotests.sock_dir for socket creation

2024-01-26 Thread Kevin Wolf
Am 24.01.2024 um 17:22 hat Andrey Drobyshev geschrieben: > If socket path is too long (longer than 108 bytes), socket can't be > opened. This might lead to failure when test dir path is long enough. > Make sure socket is created in iotests.sock_dir to avoid such a case. > > This commit basically

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Kevin Wolf
Am 26.01.2024 um 12:04 hat Andrey Drobyshev geschrieben: > On 1/26/24 12:24, Kevin Wolf wrote: > > Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: > >> There're tests whose logic implies running without O_DIRECT set, > >> otherwise they fail when running iotests in '-nocache' mode. For

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 12:20 +0100, Thomas Huth wrote: > On 26/01/2024 12.13, David Woodhouse wrote: > > On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: > > > On 08/01/2024 21.26, David Woodhouse wrote: > > > > From: David Woodhouse > > > > > > > > Eliminate direct access to nd_table[] and

Re: [PATCH 1/2] scripts/coccinelle: Add cpu_env.cocci_template script

2024-01-26 Thread Paolo Bonzini
On Fri, Jan 26, 2024 at 11:38 AM Philippe Mathieu-Daudé wrote: > > On 25/1/24 17:56, Philippe Mathieu-Daudé wrote: > > Add a Coccinelle script to convert the following slow path > > (due to the QOM cast macro): > > > >_CPU(..)->env > > > > to the following fast path: > > > >cpu_env(..) >

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 26/01/2024 12.13, David Woodhouse wrote: On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: > On 08/01/2024 21.26, David Woodhouse wrote: > > From: David Woodhouse > > > > Eliminate direct access to nd_table[] and nb_nics by processing the the > > Xen and ISA NICs first and then calling pci_init_nic_devices() for the > > rest. > >

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Most code which directly accesses nd_table[] and nb_nics uses them for one of two things. Either "I have created a NIC device and I'd like a configuration for it", or "I will create a NIC device *if* there is a configuration for

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Andrey Drobyshev
On 1/26/24 12:24, Kevin Wolf wrote: > Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: >> There're tests whose logic implies running without O_DIRECT set, >> otherwise they fail when running iotests in '-nocache' mode. For these >> tests let's add _require_no_o_direct() helper which can

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2024 at 01:45:39PM +0300, Michael Tokarev wrote: > 26.01.2024 12:06, Daniel P. Berrangé wrote: > > On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: > > > Le 25/01/2024 à 23:29, Michael Tokarev a écrit : > > > > > I think the way using sysconf(_SC_OPEN_MAX) is more

[PATCH v12 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through the bridge. The

[PATCH v12 08/11] hw/arm: Hook up FSI module in AST2600

2024-01-26 Thread Ninad Palsule
This patchset introduces IBM's Flexible Service Interface(FSI). Time for some fun with inter-processor buses. FSI allows a service processor access to the internal buses of a host POWER processor to perform configuration or debugging. FSI has long existed in POWER processes and so comes with

[PATCH v12 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driving CFAM engine accesses into the POWER

[PATCH v12 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SBEFIFO and I2C masters. The engines hang

[PATCH v12 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/fsi/engine-scratchpad.c - dropped FSI_SCRATCHPAD - included FSIBus

[PATCH v12 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery [ clg: - removed lbus_add_device() bc unused

[PATCH v12 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Ninad Palsule
Added maintainer for IBM FSI model Reviewed-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- v11: - Added Cedric as reviewer. --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dfaca8323e..39deb8ee1f 100644 --- a/MAINTAINERS +++

[PATCH v12 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers can be read or written from LBUS slave.

[PATCH v12 09/11] hw/fsi: Added qtest

2024-01-26 Thread Ninad Palsule
Added basic qtests for FSI model. Acked-by: Thomas Huth Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff --- tests/qtest/aspeed-fsi-test.c | 205 ++ tests/qtest/meson.build | 1 + 2 files changed, 206 insertions(+) create mode 100644

[PATCH v12 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Ninad Palsule
Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff. --- docs/specs/fsi.rst | 126 +++ docs/specs/index.rst | 1 + 2 files changed, 127 insertions(+) create mode 100644 docs/specs/fsi.rst diff --git

[PATCH v12 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Ninad Palsule
Hello, Please review the patch-set version 12. I have incorporated review comments from Cedric. v12: - Minor changes. - Added reviewed by tags. Ninad Palsule (11): hw/fsi: Introduce IBM's Local bus hw/fsi: Introduce IBM's scratchpad device hw/fsi: Introduce IBM's FSI Bus hw/fsi:

[PATCH v12 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address space of the CFAM to

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Michael Tokarev
26.01.2024 12:06, Daniel P. Berrangé wrote: On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: Le 25/01/2024 à 23:29, Michael Tokarev a écrit : I think the way using sysconf(_SC_OPEN_MAX) is more portable, simpler and cleaner than the one using /proc/self/fd. A fallback that

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling pci_init_nic_devices() for the rest. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/pc.c

Re: [PATCH 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-01-26 Thread Philippe Mathieu-Daudé
Hi Thomas, On 26/1/24 09:39, Thomas Huth wrote: Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth --- target/arm/tcg/cpu-v7m.c | 292 + target/arm/tcg/cpu32.c |

Re: [PATCH 1/2] scripts/coccinelle: Add cpu_env.cocci_template script

2024-01-26 Thread Philippe Mathieu-Daudé
On 25/1/24 17:56, Philippe Mathieu-Daudé wrote: Add a Coccinelle script to convert the following slow path (due to the QOM cast macro): _CPU(..)->env to the following fast path: cpu_env(..) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 +

Re: [PATCH v11 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Ninad Palsule
Hello Cedric, On 1/26/24 02:57, Cédric Le Goater wrote: On 1/26/24 04:40, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- v11:   - Added Cedric as reviewer. Reviewed-by: Cédric Le Goater Added the tag. Thanks for the review. Regards, Ninad

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Ninad Palsule
Hello Cedric, I did some minor comments. v12 should be queued for upstream. I will reorder the Signed-off (mine) trailers. Thanks a lot for detailed review. Regards, Ninad

Re: [PATCH v11 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Ninad Palsule
Hello Cedric, +QEMU files related to FSI interface: + - ``hw/fsi/aspeed-apb2opb.c`` + - ``include/hw/fsi/aspeed-apb2opb.h`` + - ``hw/fsi/opb.c`` + - ``include/hw/fsi/opb.h`` + - ``hw/fsi/fsi.c`` + - ``include/hw/fsi/fsi.h`` + - ``hw/fsi/fsi-master.c`` + - ``include/hw/fsi/fsi-master.h`` + -

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Kevin Wolf
Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: > There're tests whose logic implies running without O_DIRECT set, > otherwise they fail when running iotests in '-nocache' mode. For these > tests let's add _require_no_o_direct() helper which can be put in the > preabmle and which makes

Re: [PATCH] iotests/264: Use iotests.sock_dir for socket creation

2024-01-26 Thread Kevin Wolf
Am 25.01.2024 um 14:52 hat Andrey Drobyshev geschrieben: > If socket path is too long (longer than 108 bytes), socket can't be > opened. This might lead to failure when test dir path is long enough. > Make sure socket is created in iotests.sock_dir to avoid such a case. > > This commit basically

Re: [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Ninad Palsule
Hello Cedric, + +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) +{ +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev); +    AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); +    int i; + Please add a comment regarding the OPBus model here, something like : /*  * TODO: The

[PATCH] vhost-user: fix the issue of vhost deadlock in nested virtualization

2024-01-26 Thread Hao Chen
I run "dpdk-vdpa" and "qemur-L2" in "qemu-L1". In a nested virtualization environment, "qemu-L2" vhost-user socket sends a "VHOST_USER_IOTLB_MSG" message to "dpdk-vdpa" and blocks waiting for "dpdk-vdpa" to process the message. If "dpdk-vdpa" doesn't complete the processing of the

Re: [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Ninad Palsule
Hello Cedric, v9:    - Initialized registers.    - Fixed the address check. v11:    - Replaced for loop with memset.    - Removed Joel's review tag as per Cedric. Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad

Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Ninad Palsule
Hello Cedric, +#include "hw/fsi/fsi.h" + +#include "hw/qdev-properties.h" + +#define ENGINE_CONFIG_NEXT    BE_BIT(0) BE_BIT is not used much. I wonder if we should keep it. Agree. It is only used at couple of places. Removed BE_BIT() Anyhow, Reviewed-by: Cédric Le Goater

Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Ninad Palsule
Hello Cedric, + +static void fsi_slave_reset(DeviceState *dev) +{ +    FSISlaveState *s = FSI_SLAVE(dev); +    int i; + +    /* Initialize registers */ +    for (i = 0; i < FSI_SLAVE_CONTROL_NR_REGS; i++) { +    s->regs[i] = 0; +    } memset would be better. Replaced for loop with

Re: [PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Ninad Palsule
Hello Cedric, Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad

Re: [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Ninad Palsule
Hello Cedric,   +static uint64_t fsi_scratchpad_read(void *opaque, hwaddr addr, unsigned size) +{ +    FSIScratchPad *s = SCRATCHPAD(opaque); +    int reg = TO_REG(addr); + +    trace_fsi_scratchpad_read(addr, size); + +    if (reg >= FSI_SCRATCHPAD_NR_REGS) { usually, the model logs a

Re: [PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Ninad Palsule
Hello Cedric,     - included an empty hw/fsi/trace-events ] Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Added tag. Thank you for the review. Regards, Ninad

Re: [PATCH v2 00/14] TCG Plugin inline operation enhancement

2024-01-26 Thread Pierrick Bouvier
A polite ping to request review on this series, especially for scoreboard [02/14] which is the main addition compared to v1. On 1/18/24 07:23, Pierrick Bouvier wrote: This series adds a new thread-safe API to declare inline operation inside plugins. As well, it removes the existing non

Re: [PATCH v2 3/4] qapi: blockdev-backup: add discard-source parameter

2024-01-26 Thread Fiona Ebner
Am 25.01.24 um 18:22 schrieb Vladimir Sementsov-Ogievskiy: > > Hmm. Taking maximum is not optimal for usual case without > discard-source: user may want to work in smaller granularity than > source, to save disk space. > > In case with discarding we have two possibilities: > > - either take

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: > Le 25/01/2024 à 23:29, Michael Tokarev a écrit : > > Initially in async-teardown.c, but the same construct is used > > elsewhere too. > > > > Signed-off-by: Michael Tokarev > > --- > > include/sysemu/os-posix.h | 1 + > >

RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-01-26 Thread Wentao Jia
Hi, Eugenio Thanks for you comments, Our team has made new change about the patch, these features in hw/virtio/virtio.h:DEFINE_VIRTIO_COMMON_FEATURES, they are turned off by default , and can be turned on from at qemu command line Do you have comments about this patch? Best Regards Wentao Jia

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Cédric Le Goater
Hello Ninad, On 1/26/24 04:40, Ninad Palsule wrote: Hello, Please review the patch-set version 11. I have incorporated review comments from Cedric. v10: - Moved aspeed-apb2opb to hw/fsi directory - Split some patches. - Fixed crash. - make check Ok: 319

Re: [PATCH v11 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- v11: - Added Cedric as reviewer. Reviewed-by: Cédric Le Goater Thanks, C. --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH v11 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedri's signoff. --- docs/specs/fsi.rst | 138 +++ docs/specs/index.rst | 1 + 2 files changed, 139 insertions(+) create

Re: [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are

Re: [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC)

[PATCH 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-01-26 Thread Thomas Huth
Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth --- target/arm/tcg/cpu-v7m.c | 292 + target/arm/tcg/cpu32.c | 261 -

[PATCH 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged helper functions that require additional functions for linking. The reduced set of the linux-user functions works fine as stubs in this case, so change the #ifdef statement accordingly. Signed-off-by: Thomas Huth ---

[PATCH 3/3] target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
Now that we made sure that ARM_V7M code only gets compiled if really needed, we can drop the hard requirement for CONFIG_ARM_V7M in the Kconfig file. Signed-off-by: Thomas Huth --- target/arm/Kconfig | 4 1 file changed, 4 deletions(-) diff --git a/target/arm/Kconfig b/target/arm/Kconfig

[PATCH 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
We've got a switch to disable v7m code since a long time - but it currently cannot be disabled since linking then fails due to missing functions. But thanks to the clean-ups that have been done during the past years, it's not that difficult anymore to finally make it possible to disable

Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the

Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers

Re: [PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/fsi/engine-scratchpad.c -

Re: [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers

Re: [PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery [

Re: [PATCH v2] mailmap: Fix Stefan Weil email

2024-01-26 Thread Michael Tokarev
23.01.2024 11:21, Philippe Mathieu-Daudé: Commit 5204b499a6 ("mailmap: Fix Stefan Weil author email") corrected authorship for patch received at qemu-devel@nongnu.org, correct now for patch received at qemu-triv...@nongnu.org. Update other authorship email for Stefan's commits. Applied to

Re: [PATCH v2] qemu-docs: Update options for graphical frontends

2024-01-26 Thread Michael Tokarev
22.01.2024 07:22, Yihuan Pan wrote: The command line options `-ctrl-grab` and `-alt-grab` have been removed in QEMU 7.1. Instead, use the `-display sdl,grab-mod=` option to specify the grab modifiers. Applied to trivial-patches, thanks! /mjt Resolves:

Re: Why invtsc (CPUID_APM_INVTSC) is unmigratable?

2024-01-26 Thread Xiaoyao Li
On 1/25/2024 6:05 AM, Marcelo Tosatti wrote: On Wed, Jan 24, 2024 at 10:52:46PM +0800, Xiaoyao Li wrote: On 1/23/2024 11:39 PM, Marcelo Tosatti wrote: On Sat, Jan 20, 2024 at 05:44:07PM +0800, Xiaoyao Li wrote: On 1/20/2024 12:14 AM, Marcelo Tosatti wrote: On Fri, Jan 19, 2024 at 02:46:22PM

Re: [PATCH] qapi/migration.json: Fix the member name for MigrationCapability

2024-01-26 Thread Michael Tokarev
19.01.2024 16:53, Han Han: s/@compression/@compress/ Fixes: 864128df46 Please post all patches to qemu-devel@. I'm picking this one up because it is an obvious an trivial fix, but it's still a good idea to let the migration/qapi people to know. Thanks, /mjt Signed-off-by: Han Han ---

<    1   2   3   4