[PATCH 5/6] disas/cris: Remove struct cris_disasm_data

2024-04-12 Thread Richard Henderson
As the structure contains one element, pass the element around instead of the structure. Signed-off-by: Richard Henderson --- disas/cris.c | 187 +-- 1 file changed, 76 insertions(+), 111 deletions(-) diff --git a/disas/cris.c b/disas/cris.c

[PATCH 3/6] disas/cris: Drop with_reg_prefix

2024-04-12 Thread Richard Henderson
The *_without_reg_prefix functions are all commented out. Remove them, remove all 'with_reg_prefix' parameters, and remove all of the conditions that test them. Signed-off-by: Richard Henderson --- disas/cris.c | 188 +-- 1 file changed, 32

[PATCH 1/6] disas/cris: Untabify

2024-04-12 Thread Richard Henderson
Nothing but whitespace changes. Signed-off-by: Richard Henderson --- disas/cris.c | 2266 +- 1 file changed, 1133 insertions(+), 1133 deletions(-) diff --git a/disas/cris.c b/disas/cris.c index 409a224c5d..d62f9e3264 100644 --- a/disas/cris.c +++

[PATCH 4/6] disas/cris: Use GString in print_with_operands and subroutines

2024-04-12 Thread Richard Henderson
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1. Use GString in the core of the disassembler instead of buffering the string locally. Instead of info->print_address_func, use format_hex for addresses. Printing a hex number is what print_address_func does, and using format_hex

[PATCH 0/6] disas/cris: Use GString instead of sprintf

2024-04-12 Thread Richard Henderson
More sprintf cleanup encouraged by the Apple deprecation. Probably there's a more minimal patch. On the other hand, there's certainly a larger cleanup possible. r~ Richard Henderson (6): disas/cris: Untabify disas/cris: Remove TRACE_CASE and related code disas/cris: Drop with_reg_prefix

[PATCH 6/6] disas/cris: Improve output of register names

2024-04-12 Thread Richard Henderson
Add REGISTER_PREFIX as a string literal that may be concatenated with other string literals. Use a table of the 16 register names instead of using g_string_append_printf. Signed-off-by: Richard Henderson --- disas/cris.c | 45 + 1 file changed, 25

[PATCH 2/6] disas/cris: Remove TRACE_CASE and related code

2024-04-12 Thread Richard Henderson
The disassembler_options variable is never set within QEMU, so this code is never enabled. Remove it all. Signed-off-by: Richard Henderson --- disas/cris.c | 114 ++- 1 file changed, 3 insertions(+), 111 deletions(-) diff --git a/disas/cris.c

Re: [PATCH v6 10/12] hw/mem/cxl_type3: Add dpa range validation for accesses to DC regions

2024-04-12 Thread Gregory Price
On Mon, Mar 25, 2024 at 12:02:28PM -0700, nifan@gmail.com wrote: > From: Fan Ni > > All dpa ranges in the DC regions are invalid to access until an extent > covering the range has been added. Add a bitmap for each region to > record whether a DC block in the region has been backed by DC

Re: [PULL 0/1] target/sparc late fix

2024-04-12 Thread Richard Henderson
~ Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-04-12 16:01:04 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-sp-20240412 for you to fetch changes up to c84f5198b0b676ad67962b5250af1b0d0842e319: target/sparc

Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax"

2024-04-12 Thread Peter Xu
On Fri, Apr 12, 2024 at 11:58:43AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Apr 11, 2024 at 04:41:16PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Thu, Apr 11, 2024 at 11:31:08PM +0530, Het Gala wrote: > >> >> I just wanted to highlight couple of

Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus

2024-04-12 Thread BALATON Zoltan
On Thu, 11 Apr 2024, BALATON Zoltan wrote: Real 460EX SoC apparently does not expose a bridge device and having it appear on PCI bus confuses an AmigaOS file system driver that uses this to detect which machine it is running on. Signed-off-by: BALATON Zoltan --- Here's another version that

Re: [PATCH] target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT

2024-04-12 Thread M Bazz
Hi Philippe, On Fri, Apr 12, 2024 at 7:14 AM Philippe Mathieu-Daudé wrote: > > Hi Bazz, > > On 12/4/24 06:18, M Bazz wrote: > > On Thu, Apr 11, 2024, 10:15 PM Richard Henderson > > mailto:richard.hender...@linaro.org>> wrote: > > > > Reads are done with execute access. It is not clear

Re: [PATCH v3 03/27] util/hexdump: Use a GString for qemu_hexdump_line

2024-04-12 Thread Richard Henderson
On 4/12/24 10:41, Philippe Mathieu-Daudé wrote: -void qemu_hexdump_line(char *line, const void *bufptr, size_t len) +GString *qemu_hexdump_line(GString *str, const void *vbuf, size_t len)   { -    const char *buf = bufptr; -    int i, c; +    const uint8_t *buf = vbuf; +    size_t i; -    if

[PULL 1/1] target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT

2024-04-12 Thread Richard Henderson
Reads are done with execute access. It is not clear whether writes are legal at all -- for now, leave helper_st_asi unchanged, so that we continue to raise an mmu fault. This generalizes the exiting code for ASI_KERNELTXT to be usable for ASI_USERTXT as well, by passing down the MemOpIdx to use.

[PULL 0/1] target/sparc late fix

2024-04-12 Thread Richard Henderson
://gitlab.com/rth7680/qemu.git tags/pull-sp-20240412 for you to fetch changes up to c84f5198b0b676ad67962b5250af1b0d0842e319: target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT (2024-04-12 11:48:26 -0700) target

Re: [PATCH] target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT

2024-04-12 Thread Mark Cave-Ayland
On 12/04/2024 03:15, Richard Henderson wrote: Reads are done with execute access. It is not clear whether writes are legal at all -- for now, leave helper_st_asi unchanged, so that we continue to raise an mmu fault. This generalizes the exiting code for ASI_KERNELTXT to be usable for

Re: [PATCH v3 11/27] backends/tpm: Use qemu_hexdump_line to avoid sprintf

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1. Using qemu_hexdump_line both fixes the deprecation warning and simplifies the code base. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1. Using qemu_hexdump_line both fixes the deprecation warning and simplifies the code base. Note that this drops the "0x" prefix to every byte, which should be

Re: [PATCH v3 07/27] system/qtest: Replace sprintf by qemu_hexdump_line

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1. Using qemu_hexdump_line both fixes the deprecation warning and simplifies the code base. Signed-off-by: Philippe Mathieu-Daudé ` [rth: Use

Re: [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x"

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Trivial arithmetic can be used for emitting the nibbles, rather than full-blown printf formatting. Signed-off-by: Richard Henderson --- util/hexdump.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Philippe

Re: [PATCH v3 04/27] util/hexdump: Add unit_len and block_len to qemu_hexdump_line

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Generalize the current 1 byte unit and 4 byte blocking within the output. Signed-off-by: Richard Henderson --- include/qemu/cutils.h | 6 +- hw/virtio/vhost-vdpa.c | 2 +- util/hexdump.c | 30 +- 3 files

Re: [PATCH v3 03/27] util/hexdump: Use a GString for qemu_hexdump_line

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Allocate a new, or append to an existing GString instead of using a fixed sized buffer. Require the caller to determine the length of the line -- do not bound len here. Signed-off-by: Richard Henderson --- include/qemu/cutils.h | 15

Re: [PATCH] MAINTAINERS: Update my email address

2024-04-12 Thread Philippe Mathieu-Daudé
Hi Bin, On 12/4/24 14:37, Bin Meng wrote: The Wind River email address might change in the future. Use my personal email address instead. Signed-off-by: Bin Meng --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 1/6] hw/misc: Don't special case RESET_TYPE_COLD in npcm7xx_clk, gcr

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 18:08, Peter Maydell wrote: The npcm7xx_clk and npcm7xx_gcr device reset methods look at the ResetType argument and only handle RESET_TYPE_COLD, producing a warning if another reset type is passed. This is different from how every other three-phase-reset method we have works, and

Re: [PATCH 6/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 18:08, Peter Maydell wrote: Some devices and machines need to handle the reset before a vmsave snapshot is loaded differently -- the main user is the handling of RNG seed information, which does not want to put a new RNG seed into a ROM blob when we are doing a snapshot load.

Re: [PATCH 6/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD

2024-04-12 Thread Richard Henderson
On 4/12/24 09:08, Peter Maydell wrote: Some devices and machines need to handle the reset before a vmsave snapshot is loaded differently -- the main user is the handling of RNG seed information, which does not want to put a new RNG seed into a ROM blob when we are doing a snapshot load.

Re: [PATCH 5/6] docs/devel/reset: Update to new API for hold and exit phase methods

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 18:08, Peter Maydell wrote: Update the reset documentation's example code to match the new API for the hold and exit phase method APIs where they take a ResetType argument. Signed-off-by: Peter Maydell --- docs/devel/reset.rst | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods

2024-04-12 Thread Richard Henderson
On 4/12/24 09:08, Peter Maydell wrote: We pass a ResetType argument to the Resettable class enter phase method, but we don't pass it to hold and exit, even though the callsites have it readily available. This means that if a device cared about the ResetType it would need to record it in the

Re: [PATCH 5/6] docs/devel/reset: Update to new API for hold and exit phase methods

2024-04-12 Thread Richard Henderson
On 4/12/24 09:08, Peter Maydell wrote: Update the reset documentation's example code to match the new API for the hold and exit phase method APIs where they take a ResetType argument. Signed-off-by: Peter Maydell --- docs/devel/reset.rst | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Daniel Henrique Barboza
On 4/12/24 13:52, Aleksei Filippov wrote: On 12.04.2024 19:00, Daniel Henrique Barboza wrote: Thanks for giving it a go. You're right, this patch alone is not enough and we'll need your patch too. But note that, with what you've said in mind, your patch will also end up setting mtval2

Re: [PATCH 2/6] allwinner-i2c, adm1272: Use device_cold_reset() for software-triggered reset

2024-04-12 Thread Richard Henderson
On 4/12/24 09:08, Peter Maydell wrote: Rather than directly calling the device's implementation of its 'hold' reset phase, call device_cold_reset(). This means we don't have to adjust this callsite when we add another argument to the function signature for the hold and exit reset methods.

Re: [PATCH 1/6] hw/misc: Don't special case RESET_TYPE_COLD in npcm7xx_clk, gcr

2024-04-12 Thread Richard Henderson
On 4/12/24 09:08, Peter Maydell wrote: The npcm7xx_clk and npcm7xx_gcr device reset methods look at the ResetType argument and only handle RESET_TYPE_COLD, producing a warning if another reset type is passed. This is different from how every other three-phase-reset method we have works, and

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Daniel Henrique Barboza
On 4/12/24 14:12, Peter Maydell wrote: On Tue, 9 Apr 2024 at 18:53, Daniel Henrique Barboza wrote: raise_mmu_exception(), as is today, is prioritizing guest page faults by checking first if virt_enabled && !first_stage, and then considering the regular inst/load/store faults. There's no

Re: [PATCH v2 01/13] tests: Remove Ubuntu 20.04 container

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 15:24, Thomas Huth wrote: Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Peter Maydell
On Tue, 9 Apr 2024 at 18:53, Daniel Henrique Barboza wrote: > > raise_mmu_exception(), as is today, is prioritizing guest page faults by > checking first if virt_enabled && !first_stage, and then considering the > regular inst/load/store faults. > > There's no mention in the spec about guest page

Re: [PATCH v2 12/13] block/ssh: Use URI parsing code from glib

2024-04-12 Thread Markus Armbruster
Eric Blake writes: > On Fri, Apr 12, 2024 at 03:24:14PM +0200, Thomas Huth wrote: >> Since version 2.66, glib has useful URI parsing functions, too. >> Use those instead of the QEMU-internal ones to be finally able >> to get rid of the latter. >> >> Reviewed-by: Richard W.M. Jones >>

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Aleksei Filippov
On 12.04.2024 19:00, Daniel Henrique Barboza wrote: Thanks for giving it a go. You're right, this patch alone is not enough and we'll need your patch too. But note that, with what you've said in mind, your patch will also end up setting mtval2 and env->guest_phys_fault_addr in case a PMP

Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods

2024-04-12 Thread Edgar E. Iglesias
On Fri, Apr 12, 2024 at 6:09 PM Peter Maydell wrote: > > We pass a ResetType argument to the Resettable class enter > phase method, but we don't pass it to hold and exit, even though > the callsites have it readily available. This means that if > a device cared about the ResetType it would need

Re: [PATCH v3 17/51] target/arm: Add cpu properties for SME

2024-04-12 Thread Richard Henderson
On 4/12/24 04:36, Peter Maydell wrote: + 4) Disable the 512-bit vector length. This results in all the other + lengths supported by ``max`` defaulting to enabled + (128, 256, 1024 and 2048):: + + $ qemu-system-aarch64 -M virt -cpu max,sve512=off + I just noticed this while I was

Re: [PULL 0/2] Final build system fixes for 9.0

2024-04-12 Thread Peter Maydell
On Fri, 12 Apr 2024 at 11:04, Paolo Bonzini wrote: > > The following changes since commit 02e16ab9f4f19c4bdd17c51952d70e2ded74c6bf: > > Update version for v9.0.0-rc3 release (2024-04-10 18:05:18 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git

Re: [PATCH v4 02/10] hw/core: create Resettable QOM interface

2024-04-12 Thread Peter Maydell
On Fri, 12 Apr 2024 at 14:38, Edgar E. Iglesias wrote: > > On Fri, Apr 12, 2024 at 3:05 PM Peter Maydell > wrote: > > > > On Thu, 11 Apr 2024 at 18:23, Philippe Mathieu-Daudé > > wrote: > > > > > > On 11/4/24 15:43, Peter Maydell wrote: > > > > On Wed, 21 Aug 2019 at 17:34, Damien Hedde > >

[PATCH 1/6] hw/misc: Don't special case RESET_TYPE_COLD in npcm7xx_clk, gcr

2024-04-12 Thread Peter Maydell
The npcm7xx_clk and npcm7xx_gcr device reset methods look at the ResetType argument and only handle RESET_TYPE_COLD, producing a warning if another reset type is passed. This is different from how every other three-phase-reset method we have works, and makes it difficult to add new reset types. A

[PATCH 5/6] docs/devel/reset: Update to new API for hold and exit phase methods

2024-04-12 Thread Peter Maydell
Update the reset documentation's example code to match the new API for the hold and exit phase method APIs where they take a ResetType argument. Signed-off-by: Peter Maydell --- docs/devel/reset.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/devel/reset.rst

[PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods

2024-04-12 Thread Peter Maydell
We pass a ResetType argument to the Resettable class enter phase method, but we don't pass it to hold and exit, even though the callsites have it readily available. This means that if a device cared about the ResetType it would need to record it in the enter phase method to use later on. Pass the

[PATCH 0/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD

2024-04-12 Thread Peter Maydell
Some devices and machines need to handle the reset before a vmsave snapshot is loaded differently -- the main user is the handling of RNG seed information, which does not want to put a new RNG seed into a ROM blob when we are doing a snapshot load. Currently this kind of reset handling is

[PATCH 2/6] allwinner-i2c, adm1272: Use device_cold_reset() for software-triggered reset

2024-04-12 Thread Peter Maydell
Rather than directly calling the device's implementation of its 'hold' reset phase, call device_cold_reset(). This means we don't have to adjust this callsite when we add another argument to the function signature for the hold and exit reset methods. Signed-off-by: Peter Maydell ---

[PATCH 6/6] reset: Add RESET_TYPE_SNAPSHOT_LOAD

2024-04-12 Thread Peter Maydell
Some devices and machines need to handle the reset before a vmsave snapshot is loaded differently -- the main user is the handling of RNG seed information, which does not want to put a new RNG seed into a ROM blob when we are doing a snapshot load. Currently this kind of reset handling is

[PATCH 3/6] scripts/coccinelle: New script to add ResetType to hold and exit phases

2024-04-12 Thread Peter Maydell
We pass a ResetType argument to the Resettable class enter phase method, but we don't pass it to hold and exit, even though the callsites have it readily available. This means that if a device cared about the ResetType it would need to record it in the enter phase method to use later on. We

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Daniel Henrique Barboza
On 4/12/24 11:15, Aleksei Filippov wrote: On 09.04.2024 20:52, Daniel Henrique Barboza wrote: raise_mmu_exception(), as is today, is prioritizing guest page faults by checking first if virt_enabled && !first_stage, and then considering the regular inst/load/store faults. There's no

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()

2024-04-12 Thread Alex Williamson
On Wed, 10 Apr 2024 18:06:03 +0200 Philippe Mathieu-Daudé wrote: > sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, > resulting in painful developper experience. Use g_strdup_printf() > instead. Isn't this code only compiled for Linux hosts? Maybe still a valid change, but the

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a > dynamic field 'align' but introduced a bug. qemu_iovec_discard_back() > is now passed the wanted iov length instead of the actually required > amount that

Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax"

2024-04-12 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Apr 11, 2024 at 04:41:16PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Thu, Apr 11, 2024 at 11:31:08PM +0530, Het Gala wrote: >> >> I just wanted to highlight couple of pointers: >> >> 1. though we are using 'channels' in the precopy tests for

Re: [PATCH v2 13/13] util/uri: Remove the old URI parsing code

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 03:24:15PM +0200, Thomas Huth wrote: > Now that we switched all consumers of the URI code to use the URI > parsing functions from glib instead, we can remove our internal > URI parsing code since it is not used anymore. > > Signed-off-by: Thomas Huth > --- >

Re: [PATCH v2 12/13] block/ssh: Use URI parsing code from glib

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 03:24:14PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. > > Reviewed-by: Richard W.M. Jones > Signed-off-by: Thomas Huth > --- >

Re: [PULL 0/2] Final build system fixes for 9.0

2024-04-12 Thread Peter Maydell
On Fri, 12 Apr 2024 at 11:04, Paolo Bonzini wrote: > > The following changes since commit 02e16ab9f4f19c4bdd17c51952d70e2ded74c6bf: > > Update version for v9.0.0-rc3 release (2024-04-10 18:05:18 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git

Re: [PATCH v3 24/27] hw/net/rocker: Replace sprintf() by snprintf()

2024-04-12 Thread Richard Henderson
On 4/12/24 03:58, Philippe Mathieu-Daudé wrote: On 12/4/24 09:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. Use snprintf() instead. Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 11/13] block/nfs: Use URI parsing code from glib

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 03:24:13PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. > > Signed-off-by: Thomas Huth > --- > block/nfs.c | 110

Re: [PATCH v2 10/13] block/nbd: Use URI parsing code from glib

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 03:24:12PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. The g_uri_get_host() also takes care > of removing the square brackets from

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 09:40:18AM -0500, Eric Blake wrote: > > @@ -364,57 +363,57 @@ static int > > qemu_gluster_parse_uri(BlockdevOptionsGluster *gconf, > > QAPI_LIST_PREPEND(gconf->server, gsconf); > > > > /* transport */ > > -if (!uri->scheme || !strcmp(uri->scheme,

[PATCH for-9.0?] usb-storage: Fix BlockConf defaults

2024-04-12 Thread Kevin Wolf
Commit 30896374 started to pass the full BlockConf from usb-storage to scsi-disk, while previously only a few select properties would be forwarded. This enables the user to set more properties, e.g. the block size, that are actually taking effect. However, now the calls to

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-12 Thread Eric Blake
On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. > > Signed-off-by: Thomas Huth > --- > block/gluster.c | 71

Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax"

2024-04-12 Thread Peter Xu
On Thu, Apr 11, 2024 at 04:41:16PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Apr 11, 2024 at 11:31:08PM +0530, Het Gala wrote: > >> I just wanted to highlight couple of pointers: > >> 1. though we are using 'channels' in the precopy tests for 'migrate' QAPI, > >> we > >>   

Re: [PATCH for-9.0] target/riscv: prioritize pmp errors in raise_mmu_exception()

2024-04-12 Thread Aleksei Filippov
On 09.04.2024 20:52, Daniel Henrique Barboza wrote: raise_mmu_exception(), as is today, is prioritizing guest page faults by checking first if virt_enabled && !first_stage, and then considering the regular inst/load/store faults. There's no mention in the spec about guest page fault being a

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-12 Thread Peter Xu
Yu, On Thu, Apr 11, 2024 at 06:36:54PM +0200, Yu Zhang wrote: > > 1) Either a CI test covering at least the major RDMA paths, or at least > > periodically tests for each QEMU release will be needed. > We use a batch of regression test cases for the stack, which covers the > test for QEMU. I

Re: [PATCH v4 02/10] hw/core: create Resettable QOM interface

2024-04-12 Thread Edgar E. Iglesias
On Fri, Apr 12, 2024 at 3:05 PM Peter Maydell wrote: > > On Thu, 11 Apr 2024 at 18:23, Philippe Mathieu-Daudé > wrote: > > > > On 11/4/24 15:43, Peter Maydell wrote: > > > On Wed, 21 Aug 2019 at 17:34, Damien Hedde > > > wrote: > > >> > > >> This commit defines an interface allowing

[PATCH v2 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-12 Thread Thomas Huth
According to our support policy, we'll soon drop our official support for Ubuntu 20.04 ("Focal Fossa") in QEMU. Thus we should update the Travis jobs now to a newer release (Ubuntu 22.04 - "Jammy Jellyfish") for future testing. Since all jobs are using this release now, we can drop the entries

[PATCH v2 11/13] block/nfs: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 56

[PATCH v2 12/13] block/ssh: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Reviewed-by: Richard W.M. Jones Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file

[PATCH v2 08/13] Remove glib compatibility code that is not required anymore

2024-04-12 Thread Thomas Huth
Now that we bumped the minumum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-report.c | 10 -- 2 files changed, 18 deletions(-) diff --git a/qga/commands-posix-ssh.c

[PATCH v2 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-12 Thread Thomas Huth
This update adds the removing of the EXTERNALLY-MANAGED marker files that has been added to the lcitool recently. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 3 ++- tests/docker/dockerfiles/centos8.docker | 1 +

[PATCH v2 10/13] block/nbd: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. The g_uri_get_host() also takes care of removing the square brackets from IPv6 addresses, so we can drop that part of the QEMU code now, too.

[PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-12 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. Signed-off-by: Thomas Huth --- block/gluster.c | 71 - 1 file changed, 35 insertions(+), 36

[PATCH v2 00/13] Drop old distros, bump glib and switch to glib URI parsing code

2024-04-12 Thread Thomas Huth
In the QEMU 9.1 development cycle, we can drop the support for Ubuntu 20.04 and CentOS 8 since the following major versions of these distributions are available since 2 years already. This allows us to bump the minimum version of glib to 2.66 which comes with a nice set of URI parsing functions.

[PATCH v2 07/13] Bump minimum glib version to v2.66

2024-04-12 Thread Thomas Huth
Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can look into bumping the glib version to a new minimum for further clean-ups. According to repology.org, available versions are: CentOS Stream 9: 2.66.7 Debian 11: 2.66.8 Fedora 38: 2.74.1 Freebsd:

[PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-12 Thread Thomas Huth
RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream container to major version 9 now. Signed-off-by: Thomas Huth ---

[PATCH v2 13/13] util/uri: Remove the old URI parsing code

2024-04-12 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 99 --- util/uri.c | 1466

[PATCH v2 01/13] tests: Remove Ubuntu 20.04 container

2024-04-12 Thread Thomas Huth
Since Ubuntu 22.04 is now available since two years, we can stop actively supporting the previous LTS version of Ubuntu now. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/ubuntu2004.docker | 157 - tests/lcitool/refresh | 1 - 2 files

[PATCH v2 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-12 Thread Thomas Huth
We need the latest fixes for the lcitool to be able to properly update our CentOS docker file to CentOS Stream 9. Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index

[PATCH v2 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-12 Thread Thomas Huth
From: Paolo Bonzini RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major version 9 now.

Re: [PATCH v4 02/10] hw/core: create Resettable QOM interface

2024-04-12 Thread Peter Maydell
On Thu, 11 Apr 2024 at 18:23, Philippe Mathieu-Daudé wrote: > > On 11/4/24 15:43, Peter Maydell wrote: > > On Wed, 21 Aug 2019 at 17:34, Damien Hedde > > wrote: > >> > >> This commit defines an interface allowing multi-phase reset. This aims > >> to solve a problem of the actual single-phase

[PATCH] MAINTAINERS: Update my email address

2024-04-12 Thread Bin Meng
The Wind River email address might change in the future. Use my personal email address instead. Signed-off-by: Bin Meng --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f1f6922025..50729a0985 100644 --- a/MAINTAINERS

Re: [PATCH for-9.1 4/9] Bump minimum glib version to v2.66

2024-04-12 Thread Paolo Bonzini
On 4/12/24 12:58, Thomas Huth wrote: On 12/04/2024 12.16, Paolo Bonzini wrote: On Thu, Mar 28, 2024 at 3:06 PM Thomas Huth wrote: Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can look into bumping the glib version to a new minimum for further clean-ups. According to

Re: [PATCH] Makefile: fix use of -j without an argument

2024-04-12 Thread Matheus Tavares Bernardino
On Fri, 12 Apr 2024 10:02:54 +0200 Paolo Bonzini wrote: > > On Thu, Apr 11, 2024 at 5:46 PM Matheus Tavares Bernardino > wrote: > > +$(if $(filter -j, $(MAKEFLAGS)) \ > > +,, \ > > +$(or \ > > + $(filter -l% -j%, $(MAKEFLAGS)), \ > > +

Re: [PATCH] Makefile: preserve --jobserver-auth argument when calling ninja

2024-04-12 Thread Paolo Bonzini
On Fri, Apr 12, 2024 at 1:52 PM Fiona Ebner wrote: > > Am 02.04.24 um 10:17 schrieb Martin Hundebøll: > > Qemu wraps its call to ninja in a Makefile. Since ninja, as opposed to > > make, utilizes all CPU cores by default, the qemu Makefile translates > > the absense of a `-jN` argument into

Re: [PATCH] Makefile: preserve --jobserver-auth argument when calling ninja

2024-04-12 Thread Fiona Ebner
Am 02.04.24 um 10:17 schrieb Martin Hundebøll: > Qemu wraps its call to ninja in a Makefile. Since ninja, as opposed to > make, utilizes all CPU cores by default, the qemu Makefile translates > the absense of a `-jN` argument into `-j1`. This breaks jobserver > functionality, so update the -jN

Re: [PATCH v3 17/51] target/arm: Add cpu properties for SME

2024-04-12 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:08, Richard Henderson wrote: > > Mirror the properties for SVE. The main difference is > that any arbitrary set of powers of 2 may be supported, > and not the stricter constraints that apply to SVE. > +SME CPU Property Examples > +- > + > + 1)

Re: [PATCH-for-9.0?] docs: i386: pc: Update maximum CPU numbers for PC Q35

2024-04-12 Thread Zhao Liu
Hi Philippe, On Fri, Apr 12, 2024 at 11:57:35AM +0200, Philippe Mathieu-Daudé wrote: > Date: Fri, 12 Apr 2024 11:57:35 +0200 > From: Philippe Mathieu-Daudé > Subject: Re: [PATCH-for-9.0?] docs: i386: pc: Update maximum CPU numbers > for PC Q35 > > > -SMP is supported with up to 255 CPUs. > >

Re: [PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-12 Thread Thomas Huth
On 12/04/2024 13.10, Philippe Mathieu-Daudé wrote: On 12/4/24 08:20, Thomas Huth wrote: A9MPCORE, ARM11MPCORE and A15MPCORE are defined twice, once in hw/cpu/Kconfig and once in hw/arm/Kconfig. This is only possible by accident, since hw/cpu/Kconfig is never included from hw/Kconfig. Fix it by

Re: [PULL 0/2] Final build system fixes for 9.0

2024-04-12 Thread Peter Maydell
On Fri, 12 Apr 2024 at 12:07, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 12/4/24 12:03, Paolo Bonzini wrote: > > The following changes since commit 02e16ab9f4f19c4bdd17c51952d70e2ded74c6bf: > > > >Update version for v9.0.0-rc3 release (2024-04-10 18:05:18 +0100) > > > > are available

Re: [PATCH] target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT

2024-04-12 Thread Philippe Mathieu-Daudé
Hi Bazz, On 12/4/24 06:18, M Bazz wrote: On Thu, Apr 11, 2024, 10:15 PM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: Reads are done with execute access.  It is not clear whether writes are legal at all -- for now, leave helper_st_asi unchanged, so that we

Re: [PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 08:20, Thomas Huth wrote: A9MPCORE, ARM11MPCORE and A15MPCORE are defined twice, once in hw/cpu/Kconfig and once in hw/arm/Kconfig. This is only possible by accident, since hw/cpu/Kconfig is never included from hw/Kconfig. Fix it by declaring the switches only in hw/cpu/Kconfig (since

Re: [PULL 0/2] Final build system fixes for 9.0

2024-04-12 Thread Paolo Bonzini
> Since these 2 patches don't modify what we can build with v9.0.0-rc3, > would it be acceptable to merge them without having to produce a > v9.0.0-rc4 tag before the final release? I didn't want to ask you about that, but I agree it would not be an issue. Paolo

Re: [PULL 0/2] Final build system fixes for 9.0

2024-04-12 Thread Philippe Mathieu-Daudé
Hi Peter, On 12/4/24 12:03, Paolo Bonzini wrote: The following changes since commit 02e16ab9f4f19c4bdd17c51952d70e2ded74c6bf: Update version for v9.0.0-rc3 release (2024-04-10 18:05:18 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

Re: [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/kvm/kvm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-9.1 4/9] Bump minimum glib version to v2.66

2024-04-12 Thread Thomas Huth
On 12/04/2024 12.16, Paolo Bonzini wrote: On Thu, Mar 28, 2024 at 3:06 PM Thomas Huth wrote: Now that we dropped support for CentOS 8 and Ubuntu 20.04, we can look into bumping the glib version to a new minimum for further clean-ups. According to repology.org, available versions are:

Re: [PATCH v5 1/3] qio: add support for SO_PEERCRED for socket channel

2024-04-12 Thread Paolo Bonzini
On Thu, Apr 11, 2024 at 2:14 PM Anthony Harivel wrote: > > The function qio_channel_get_peercred() returns a pointer to the > credentials of the peer process connected to this socket. > > This credentials structure is defined in as follows: > > struct ucred { > pid_t pid;/* Process

Re: [PATCH v3 24/27] hw/net/rocker: Replace sprintf() by snprintf()

2024-04-12 Thread Philippe Mathieu-Daudé
On 12/4/24 09:33, Richard Henderson wrote: From: Philippe Mathieu-Daudé sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. Use snprintf() instead. Signed-off-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH v5 0/3] Add support for the RAPL MSRs series

2024-04-12 Thread Paolo Bonzini
On Thu, Apr 11, 2024 at 2:14 PM Anthony Harivel wrote: > > Dear maintainers, > > First of all, thank you very much for your review of my patch > [1]. > > In this version (v5), I have attempted to address all the problems > addressed by Daniel during the last review. I've been more careful with >

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-12 Thread Thomas Huth
On 12/04/2024 12.37, Paolo Bonzini wrote: RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major

[PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-12 Thread Paolo Bonzini
RHEL 9 (and thus also the derivatives) are available since two years now, so according to QEMU's support policy, we can drop the active support for the previous major version 8 now. Thus upgrade our CentOS Stream build environment playbooks to major version 9 now. Signed-off-by: Paolo Bonzini

  1   2   3   >