[PATCH v5] xlnx_dpdma: fix descriptor endianness bug

2024-05-02 Thread Alexandra Diupina
similar actions when writing a descriptor. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina --- v5: fix subject and make xlnx_dpdma_write_descriptor() not void v4: remove rewriting desc in pla

[PATCH v4] fix endianness bug

2024-04-28 Thread Alexandra Diupina
similar actions when writing a descriptor. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina --- v4: remove rewriting desc in place v3: add xlnx_dpdma_write_descriptor() v2: min

[PATCH v2] fix bit fields extraction and prevent overflow

2024-04-28 Thread Alexandra Diupina
Add a type cast and use extract64() instead of extract32() to avoid integer overflow on addition. Fix bit fields extraction according to documentation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexand

[PATCH v3] fix endianness bug

2024-04-25 Thread Alexandra Diupina
similar actions when writing a descriptor. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina --- v3: add xlnx_dpdma_write_descriptor() v2: minor changes in xlnx_dpdma_read_descriptor() hw/dma/xl

[PATCH v2] fix host-endianness bug

2024-04-25 Thread Alexandra Diupina
xlnx-dpdma") Signed-off-by: Alexandra Diupina --- v2:minor changes in xlnx_dpdma_read_descriptor() hw/dma/xlnx_dpdma.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/hw/dma/xlnx_dpdma.c b/hw/dma/xlnx_dpdma.c index dd66be5265..62a0952

[PATCH] fix bit fields extraction and prevent overflow

2024-04-24 Thread Alexandra Diupina
Add a type cast and use extract64() instead of extract32() to avoid integer overflow on addition. Fix bit fields extraction according to documentation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexand

[PATCH] fix host-endianness bug

2024-04-24 Thread Alexandra Diupina
xlnx-dpdma") Signed-off-by: Alexandra Diupina --- hw/dma/xlnx_dpdma.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/hw/dma/xlnx_dpdma.c b/hw/dma/xlnx_dpdma.c index 1f5cd64ed1..5fd4e31699 100644 --- a/hw/dma/xlnx_dpdma.c ++

[PATCH v2 RFC] fix host-endianness bug and prevent overflow

2024-04-24 Thread Alexandra Diupina
Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alexandra Diupina --- hw/dma/xlnx_dpdma.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/hw/dma/xlnx_dpdma.c b/hw/dma/xl

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-23 Thread Alexandra Diupina
17/04/24 13:05, Konrad, Frederic пишет: Hi, -Original Message- From: qemu-devel-bounces+fkonrad=amd@nongnu.org On Behalf Of Peter Maydell Sent: Friday, April 12, 2024 12:07 PM To: Alexandra Diupina Cc: Alistair Francis ; Edgar E. Iglesias ; qemu-...@nongnu.org; qemu- de

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-16 Thread Alexandra Diupina
ract64() extracts a bit field with a length of 16 bits instead of 12, the shift is changed to 32 so that the extracted field fits into bits [47:32] of the final address. if this calculation is correct, I'm ready to create a second version of the patch. 12/04/24 13:06, Peter Maydell пишет:

[PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-12 Thread Alexandra Diupina
Overflow can occur in a situation where desc->source_address has a maximum value (pow(2, 32) - 1), so add a cast to a larger type before the assignment. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d3c6369a96 ("introduce xlnx-dpdma") Signed-off-by: Alex

[PATCH v2] esp: process the result of scsi_device_find()

2023-12-29 Thread Alexandra Diupina
Add a 'current_lun' check for a null value to avoid null pointer dereferencing and recover host if NULL return Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4eb8606560 (esp: store lun coming from the MESSAGE OUT phase) Signed-off-by: Alexandra Diupina --- v2

[PATCH] esp: process the result of scsi_device_find()

2023-12-18 Thread Alexandra Diupina
Add a 'current_lun' check for a null value to avoid null pointer dereferencing Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4eb8606560 (esp: store lun coming from the MESSAGE OUT phase) Signed-off-by: Alexandra Diupina --- hw/scsi/esp.c | 5 + 1 file changed, 5

[PATCH] hw/display/vmware_vga: fix probably typo

2023-11-10 Thread Alexandra Diupina
When calling trace_vmware_verify_rect_greater_than_bound() replace "y" with "h" and y with h Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 02218aedb1 ("hw/display/vmware_vga: replace fprintf calls with trace events") Signed-off-by: Alex