Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-04-13 Thread Andreas Färber
Hi Paolo, On 13.04.21 09:42, Paolo Bonzini wrote: > On 07/04/21 17:42, Kevin Wolf wrote: >>> +* Publishing other's private information, such as physical or >>> electronic >>> +addresses, without explicit permission >> >> Yes, it's pretty clear that I'm not publishing new information about >>

Re: [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-19 Thread Andreas Färber
Markus Armbruster > Eduardo Habkost > Paolo Bonzini > Marc-André Lureau > Eric Blake > > I volunteer myself, and also volunteer Eduardo and Daniel as reviewers > since they understand the code well. > > Cc: Andreas Färber > Cc: Daniel P. Berr

Re: [Qemu-devel] qgraph

2019-06-11 Thread Andreas Färber
Am 11.06.19 um 12:31 schrieb Paolo Bonzini: > On 11/06/19 10:56, Markus Armbruster wrote: >> Yes, this is how introspection (both QMP and QOM) is commonly used. >> Just keep in mind one difference: QMP is static, QOM is dynamic. >> >> QMP being static means it's defined at compile time. So is the

Re: [Qemu-devel] qgraph

2019-06-10 Thread Andreas Färber
Am 10.06.19 um 15:52 schrieb Paolo Bonzini: > On 10/06/19 15:28, Andreas Färber wrote: >> So if we want a new QMP operation, the most sense would probably make >> where-can-I-attach-type(foo) returning a list of QOM paths, showing only >> the first free slot per bus. Th

Re: [Qemu-devel] qgraph

2019-06-10 Thread Andreas Färber
Am 10.06.19 um 14:03 schrieb Paolo Bonzini: > On 10/06/19 13:57, Andreas Färber wrote: >> Your question doesn't make sense grammatically or conceptually. As Paolo >> explained below, QOM is a pure object model, with object types/classes >> and properties. Buses are just obje

Re: [Qemu-devel] qgraph

2019-06-10 Thread Andreas Färber
Hi Natalia, Am 10.06.19 um 11:53 schrieb Natalia Fursova: > Hi there! > Read please our correspondence and answer on last question (Will it ok for > QOM conception?) > Also forwarding to QOM and QMP maintainers. Can you make comments on this > discussion? Your question doesn't make sense

Re: [Qemu-devel] [PATCH] MAINTAINERS: new maintainers for QOM

2019-06-07 Thread Andreas Färber
Eduardo Habkost > Paolo Bonzini > Marc-André Lureau > Eric Blake > > I volunteer myself, and also volunteer Eduardo and Daniel as reviewers > since they understand the code well. > > Cc: Andreas Färber > Cc: Daniel P. Berrange > Cc: Eduardo Habkost

Re: [Qemu-devel] What's our ABI promise for externally visible QOM?

2018-11-30 Thread Andreas Färber
Am 30.11.18 um 07:59 schrieb Markus Armbruster: > QOM types and the QOM graph are externally visible: > > * qom-list-types returns QOM type names and parents. > > Fine print: the result is limited to concrete types by default. > Aside: that's the only way to figure out whether a type is

Re: [Qemu-devel] [PATCH 2/3] qtest: new functions for pulsed IRQs

2018-10-31 Thread Andreas Färber
st and which can be cleared by the test case. >> >> Signed-off-by: Michael Walle >> Cc: Paolo Bonzini >> Cc: Andreas Färber > > Hi, > > unfortunately, there was never any feedback. Are you ok with this patch > in general? There is still

Re: [Qemu-devel] [PATCH] hw/qdev-core: Fix description of instance_init

2018-09-10 Thread Andreas Färber
gt; > Signed-off-by: Thomas Huth Reviewed-by: Andreas Färber Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child()

2018-07-13 Thread Andreas Färber
Am 13.07.2018 um 23:16 schrieb Eduardo Habkost: > I wonder if we should deprecate object_initialize() and support > only object_initialize_child() later. Initializing an object > contained inside another one without making it a child of the > parent object is a recipe for trouble. The root

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-08 Thread Andreas Färber
Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: > * Andreas Färber (afaer...@suse.de) wrote: >> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: >>> For debugging purposes it is very useful to: >>> - See the description of the field. This in

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-02 Thread Andreas Färber
Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: > For debugging purposes it is very useful to: > - See the description of the field. This information is already filled >in but not shown in "qom-list" command. No objection on this part. > - Display value of the field. That is by

Re: [Qemu-devel] [PATCH 35/38] qom: Add MMU_DEBUG_LOAD

2017-12-29 Thread Andreas Färber
r clarity: tell bottom levels of virtual memory translation routines ... to bypass? or that the access ... bypasses? or that this lets us ... bypass? > > Cc: Andreas Färber <afaer...@suse.de> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > include

Re: [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize

2017-10-18 Thread Andreas Färber
Am 18.10.2017 um 01:53 schrieb Emilio G. Cota: > On Mon, Oct 16, 2017 at 10:25:39 -0700, Richard Henderson wrote: >> Move target cpu tcg initialization to common code, >> called from cpu_exec_realizefn. >> >> Cc: Andreas Färber <afaer...@suse.de> >> Signed-of

Re: [Qemu-devel] [PATCH v2 1/4] qom: provide root container for internal objs

2017-09-25 Thread Andreas Färber
Hi, Am 25.09.2017 um 10:14 schrieb Peter Xu: > On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote: >> Am 25.09.2017 um 08:37 schrieb Peter Xu: >>> We have object_get_objects_root() to keep user created objects, however >>> no place for objects that will

Re: [Qemu-devel] [PATCH v2 1/4] qom: provide root container for internal objs

2017-09-25 Thread Andreas Färber
Am 25.09.2017 um 08:37 schrieb Peter Xu: > We have object_get_objects_root() to keep user created objects, however > no place for objects that will be used internally. Create such a > container for internal objects. > > CC: Andreas Färber <afaer...@suse.de> > CC

Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init()

2017-07-17 Thread Andreas Färber
Am 17.07.2017 um 12:41 schrieb Igor Mammedov: > On Sat, 15 Jul 2017 08:08:58 -1000 > Richard Henderson wrote: > >> On 07/14/2017 03:52 AM, Igor Mammedov wrote: >>> @@ -230,6 +230,8 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error >>> **errp) >>> M68kCPUClass

Re: [Qemu-devel] [PATCH 1/7] qom: Make link property API public

2017-06-28 Thread Andreas Färber
Am 28.06.2017 um 15:32 schrieb Paolo Bonzini: > On 28/06/2017 14:48, Fam Zheng wrote: >> The get/set pair and the struct will be reused by qdev link prop, make >> them public. >> >> Signed-off-by: Fam Zheng > > Maybe it's better to make it a separate header file. No other

Re: [Qemu-devel] [PATCH v5 00/10] Add support for VM Generation ID

2017-02-10 Thread Andreas Färber
Am 10.02.2017 um 19:18 schrieb Andrew Jones: > On Fri, Feb 10, 2017 at 05:16:59PM +0100, Igor Mammedov wrote: >> On Fri, 10 Feb 2017 17:31:33 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Fri, Feb 10, 2017 at 11:12:13AM +0100, Laszlo Ersek wrote: On 02/05/17 10:11,

Re: [Qemu-devel] [PATCH 1/3] cleanup: remove not used header

2017-01-03 Thread Andreas Färber
Am 03.01.2017 um 16:25 schrieb Eric Blake: > On 01/02/2017 09:44 AM, Igor Mammedov wrote: > > perhaps s/not used/unused/ in the subject ... and qom: instead of cleanup: if this gets re-spun. Andreas > > Reviewed-by: Eric Blake > >> Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH for-2.9] qom: Make all interface types abstract

2016-12-12 Thread Andreas Färber
Am 09.12.2016 um 19:06 schrieb Eduardo Habkost: > "qom-list-types abstract=false" currently returns all interface > types, as if they were not abstract. Fix this by making sure all > interface types are abstract. > > All interface types have instance_size == 0, so we can use > it to set

Re: [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove duplicate "bv" property

2016-11-04 Thread Andreas Färber
Am 04.11.2016 um 17:07 schrieb Eduardo Habkost: > On Fri, Nov 04, 2016 at 04:56:29PM +0100, Andreas Färber wrote: >> Am 29.10.2016 um 03:48 schrieb Eduardo Habkost: >>> The object_property_add_bool() call in dummy_init() is always >>> failing because there is an exist

Re: [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove duplicate "bv" property

2016-11-04 Thread Andreas Färber
Am 29.10.2016 um 03:48 schrieb Eduardo Habkost: > The object_property_add_bool() call in dummy_init() is always > failing because there is an existing "bv" class property. We need > to remove either the "bv" class property or the "bv" instance > property. > > Remove the class property so both

Re: [Qemu-devel] [PATCH 0/6] qdev class properties + abstract class support on device-list-properties

2016-10-17 Thread Andreas Färber
Am 17.10.2016 um 23:04 schrieb Eduardo Habkost: > On Tue, Oct 11, 2016 at 05:41:13PM -0300, Eduardo Habkost wrote: >> Eduardo Habkost (6): >> qdev: qdev_class_set_props() function s/qdev_/device_/? Regards, Andreas >> qdev: Extract property-default code to qdev_property_set_to_default() >>

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-17 Thread Andreas Färber
tests: check-qom-proplist: Use _abort to catch errors For this one: Reviewed-by: Andreas Färber <afaer...@suse.de> Regards, Andreas >> tests/check-qom-proplist.c | 10 +++--- >> 1 file changed, 3 insertions(+), 7 deletions(-) -- SUSE Linux GmbH, Maxfeldstr. 5, 9040

Re: [Qemu-devel] [RFC 0/4] QOM class properties - do we need them?

2016-09-29 Thread Andreas Färber
Am 29.09.2016 um 12:21 schrieb Daniel P. Berrange: > On Thu, Sep 29, 2016 at 12:12:32PM +0200, Andreas Färber wrote: >> Am 29.09.2016 um 10:14 schrieb Daniel P. Berrange: >>> Practically all instances properties should become class properties >>> as its going to sa

Re: [Qemu-devel] [RFC 0/4] QOM class properties - do we need them?

2016-09-29 Thread Andreas Färber
Am 29.09.2016 um 02:16 schrieb David Gibson: > is there really any value to supporting the "class" > properties in addition to the "instance" properties? Yes, it makes enumerating available properties easier by not requiring to instantiate a new instance for printing, e.g., ",help" information.

Re: [Qemu-devel] [RFC 0/4] QOM class properties - do we need them?

2016-09-29 Thread Andreas Färber
Am 29.09.2016 um 10:14 schrieb Daniel P. Berrange: > On Thu, Sep 29, 2016 at 10:16:41AM +1000, David Gibson wrote: >> QOM has the concept of both "object class" properties and "object >> instance" properties. >> >> The accessor functions installed for the rarely-used class properties >> still take

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

2016-09-26 Thread Andreas Färber
Am 26.09.2016 um 18:24 schrieb Paolo Bonzini: > On 26/09/2016 18:20, Andreas Färber wrote: >> Am 26.09.2016 um 18:17 schrieb Richard Henderson: >>> On 09/26/2016 05:20 AM, Paolo Bonzini wrote: >>>> On 26/09/2016 12:56, Sagar Karandikar wrote: >>>>>

Re: [Qemu-devel] [PATCH 00/18] target-riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G, RV32G)

2016-09-26 Thread Andreas Färber
Am 26.09.2016 um 18:17 schrieb Richard Henderson: > On 09/26/2016 05:20 AM, Paolo Bonzini wrote: >> On 26/09/2016 12:56, Sagar Karandikar wrote: >>> -cpu-qom.h merged into cpu.h >> >> Please follow the model of other targets. RISCVCPUClass and the >> RISCVCPU typedef should be in cpu-qom.h. > >

Re: [Qemu-devel] steps towards deprecation of old boards and devices

2016-09-20 Thread Andreas Färber
Am 20.09.2016 um 10:08 schrieb Markus Armbruster: > Peter Maydell writes: > >> If we're going to aim for deprecating and eventually removing >> some of our unmaintained device and board models, it seems to >> me that a good first step would be to come up with a

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-19 Thread Andreas Färber
Hi Lin and Markus, Am 19.09.2016 um 13:58 schrieb Markus Armbruster: > This is about QOM use. Cc: Andreas in case he has smart ideas. > Andreas, you may want to skip ahead to "EnumProperty". > > "Lin Ma" writes: > > Markus Armbruster 2016/9/12 星期一 下午

Re: [Qemu-devel] [PULL v3 6/6] MAINTAINERS: add virtio-* tests

2016-09-15 Thread Andreas Färber
Am 15.09.2016 um 22:38 schrieb Michael S. Tsirkin: > From: Greg Kurz > > Except virtio-9p, all virtio-* tests are orphan. This patch tries to fix > it, according to the following logic: > > - when the related subsystem has its own section in MAINTAINERS, the test > is added

Re: [Qemu-devel] [PATCH v2] qom: Implement qom-get HMP command

2016-09-06 Thread Andreas Färber
116, > "tm_sec": 0, > "tm_hour": 9, > "tm_min": 46, > "tm_mon": 8, > "tm_mday": 6 > } > (qemu) qom-get /machine frob > Property '.frob' not found > > Signed-off-by: Dr. David Alan Gilbert <dgi

Re: [Qemu-devel] 答复: Re: [PATCH] object: Add 'help' option to print all available object backend types

2016-08-18 Thread Andreas Färber
Am 18.08.2016 um 11:57 schrieb Lin Ma: Markus Armbruster 2016/8/17 星期三 下午 2:48 >>> >>Lin Ma writes: >> >>> Signed-off-by: Lin Ma >>> --- >>> qemu-options.hx | 5 - >>> qom/object_interfaces.c | 16 >>> 2 files

Re: [Qemu-devel] QOM: best way for parents to pass information to children? (was Re: [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties)

2016-07-15 Thread Andreas Färber
Am 15.07.2016 um 18:10 schrieb Eduardo Habkost: > On Fri, Jul 15, 2016 at 11:11:38AM +0200, Igor Mammedov wrote: >> On Fri, 15 Jul 2016 08:35:30 +0200 >> Andrew Jones wrote: >>> On Thu, Jul 14, 2016 at 05:07:43PM -0300, Eduardo Habkost wrote: First of all, sorry for

Re: [Qemu-devel] [PATCH] qom: add option -dt-printf wich writes DeviceClass hierarchy in file

2016-07-13 Thread Andreas Färber
Am 13.07.2016 um 17:30 schrieb goremykin: > Andreas Färber писал 2016-07-12 18:41: >> Am 12.07.2016 um 17:33 schrieb goremy...@ispras.ru: >>> From: goremykin <oleg.goremi...@yandex.ru> >>> >>> Option -dt-printf 'file' writes Device Tree (DiveceClass

Re: [Qemu-devel] [PATCH] qom: add option -dt-printf wich writes DeviceClass hierarchy in file

2016-07-12 Thread Andreas Färber
Am 12.07.2016 um 18:15 schrieb Peter Maydell: > On 12 July 2016 at 16:33, wrote: >> From: goremykin >> >> Option -dt-printf 'file' writes Device Tree (DiveceClass hierarchy) to >> 'file' using Json format. This helps developers visualize the

Re: [Qemu-devel] [PATCH] qom: add option -dt-printf wich writes DeviceClass hierarchy in file

2016-07-12 Thread Andreas Färber
Am 12.07.2016 um 17:33 schrieb goremy...@ispras.ru: > From: goremykin > > Option -dt-printf 'file' writes Device Tree (DiveceClass hierarchy) to > 'file' using Json format. This helps developers visualize the hierarchy > of DeviceClass and its properties. > >

Re: [Qemu-devel] [PATCH 1/1] OpenBIOS: Switch over to official OpenBIOS git repo

2016-07-08 Thread Andreas Färber
Am 07.07.2016 um 23:22 schrieb Jeff Cody: > This update should preserve git history, and switches over to the official > openbios git repo, rather than pulling from the svn mirror. All prior history > from the svn repository should still be preserved (i.e., commit hashes are the > same for

[Qemu-devel] [PULL 0/1] QOM devices patch queue 2016-07-06

2016-07-06 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Thanks, Andreas Cc: Peter Maydell The following changes since commit 791b7d2340cfafcac9af7864343cf23504d57804: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-07-05

[Qemu-devel] [PULL 1/1] qom: Fix comment typo

2016-07-06 Thread Andreas Färber
From: Changlong Xie <xiecl.f...@cn.fujitsu.com> It's qom_unref, not qdef_unref. Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> Reviewed-by: Laurent Vivier <lviv...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h | 2 +- 1 f

Re: [Qemu-devel] [PATCH] qom/object: fix comment typo

2016-07-06 Thread Andreas Färber
Am 06.07.2016 um 07:52 schrieb Changlong Xie: > Would any maintainer pick this one? Please in the future use just "qom:" in the subject. How to find out? git log --oneline -- include/qom/object.h Also please mention the typo in the commit message. Fixing. Thanks, Andreas > > On 06/14/2016

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Marcel to PCI

2016-06-14 Thread Andreas Färber
Am 13.06.2016 um 22:07 schrieb Michael S. Tsirkin: > Marcel is reviewing PCI patches anyway, things will > be easier if people remember to Cc him. > > Cc: Marcel Apfelbaum > Signed-off-by: Michael S. Tsirkin > --- > MAINTAINERS | 1 + > 1 file changed, 1

[Qemu-devel] [PULL 0/1] QOM devices patch queue 2016-05-25

2016-05-25 Thread Andreas Färber
-25 23:24:35 +0200) QOM infrastructure fixes and device conversions * Start splitting up qdev.c ------------ Andreas Färber (1): qdev: Start disentangling bus from device hw/core/Makefile.objs | 1 + hw/core/b

[Qemu-devel] [PULL 1/1] qdev: Start disentangling bus from device

2016-05-25 Thread Andreas Färber
Move bus type and related APIs to a separate file bus.c. This is a first step in breaking up qdev.c into more manageable chunks. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> [AF: Rebased onto osdep.h] Signed-off-by: Andreas Färber <afaer...@suse.de> --- hw/core/Makefile.objs

[Qemu-devel] [PULL 1/4] MAINTAINERS: Drop Andreas as Cocoa maintainer

2016-05-25 Thread Andreas Färber
From: Andreas Färber <andreas.faer...@web.de> Peter has taken over Cocoa maintainership. Signed-off-by: Andreas Färber <andreas.faer...@web.de> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 81e7fac..87ad14f 100644 --- a/MAINT

[Qemu-devel] [PULL 4/4] MAINTAINERS: Drop Andreas as CPU maintainer

2016-05-25 Thread Andreas Färber
Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77bef88..3700d51 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1046,7 +1046,7 @@ S: Supported F: scripts/coverity-model.c

[Qemu-devel] [PULL 2/4] MAINTAINERS: Drop Andreas as PReP maintainer

2016-05-25 Thread Andreas Färber
From: Andreas Färber <andreas.faer...@web.de> Signed-off-by: Andreas Färber <andreas.faer...@web.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 87ad14f..988ce3a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[Qemu-devel] [PULL 0/4] Cut down on Andreas' maintainer responsibilities

2016-05-25 Thread Andreas Färber
Drop Andreas as CPU maintainer (2016-05-25 17:44:15 +0200) Andreas stepping down from most maintainer positions ------------ Andreas Färber (4): MAINTAINERS: Drop Andreas a

[Qemu-devel] [PULL 3/4] MAINTAINERS: Drop Andreas as 0.15 maintainer

2016-05-25 Thread Andreas Färber
Downgrade to orphan status, like all other remaining stable entries. Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 988ce3a..77bef88 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR

2016-05-25 Thread Andreas Färber
Am 25.05.2016 um 08:54 schrieb Thomas Huth: > On 12.05.2016 05:48, Bharata B Rao wrote: >> Hi, >> >> This is v3 of "Core based CPU hotplug for PowerPC sPAPR". The hotplug >> semantics looks like this: >> >> (qemu) device_add POWER8E-spapr-cpu-core,id=core2,core=16[,threads=4] >> (qemu) device_add

Re: [Qemu-devel] [PULL 06/15] target-i386: Set constant model_id for qemu63/qemu32/athlon

2016-05-23 Thread Andreas Färber
qemu64 Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

[Qemu-devel] [PULL 1/1] MAINTAINERS: Drop target-i386 from CPU subsystem

2016-04-18 Thread Andreas Färber
. Acked-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1c30dfa..28e2b17 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1050,7 +1050,6 @@ M: An

[Qemu-devel] [PULL 0/1] QOM CPUState patch queue 2016-04-18

2016-04-18 Thread Andreas Färber
+0200) QOM CPUState and X86CPU * MAINTAINERS cleanup ---- Andreas Färber (1): MAINTAINERS: Drop target-i386 from CPU subsystem MAINTAINERS | 1 - 1 file changed, 1 deletion(-)

Re: [Qemu-devel] [PATCH] qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices

2016-03-19 Thread Andreas Färber
t;peter.mayd...@linaro.org> > --- > This needs to go in after http://patchwork.ozlabs.org/patch/597716/ > as otherwise the bug fixed by that patch will become a 'make check' > failure. Looks strange, but okay, Reviewed-by: Andreas Färber <afaer...@suse.de> Through whose queue

Re: [Qemu-devel] [RFC PATCH v0 0/6] Core based CPU hotplug for PowerPC sPAPR

2016-03-01 Thread Andreas Färber
Am 01.03.2016 um 11:00 schrieb Bharata B Rao: > On Thu, Feb 25, 2016 at 09:52:36PM +0530, Bharata B Rao wrote: >> Hi, >> >> This is an attempt to implement CPU hotplug for PowerPC sPAPR based on >> the approach suggested by Andreas. While I say that, I should also explicitly >> add that I have

Re: [Qemu-devel] [PATCH v6 1/7] s390x/cpu: Cleanup init in preparation for hotplug

2016-02-22 Thread Andreas Färber
Am 22.02.2016 um 18:06 schrieb Matthew Rosato: > Ensure a valid cpu_model is set upfront by setting the > default value directly into the MachineState when none is > specified. This is needed to ensure hotplugged CPUs share > the same cpu_model. > > Signed-off-by: Matthew Rosato

Re: [Qemu-devel] [PATCH v6 3/7] s390x/cpu: Move some CPU initialization into realize

2016-02-22 Thread Andreas Färber
changed, 6 insertions(+), 3 deletions(-) Looks reasonable on a brief sight, Reviewed-by: Andreas Färber <afaer...@suse.de> What is env->cpu_num used for? In particular, have you thought about linux-user creating multiple CPUs and possibly destroying them again? Regards, Andreas -- S

Re: [Qemu-devel] [PATCH v6 6/7] cpu: Add a last_cpu macro

2016-02-22 Thread Andreas Färber
Am 22.02.2016 um 18:06 schrieb Matthew Rosato: > Add last_cpu to grab last CPU in the queue. Rename one existing > use of last_cpu as a variable name. > > Signed-off-by: Matthew Rosato > --- > hw/intc/openpic.c | 12 ++-- > include/qom/cpu.h | 1 + > 2

Re: [Qemu-devel] [PATCH v6 7/7] s390x/cpu: Allow hotplug of CPUs

2016-02-22 Thread Andreas Färber
Am 22.02.2016 um 18:06 schrieb Matthew Rosato: > Implement cpu hotplug routine and add the machine hook. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 33 + > target-s390x/cpu.c | 7 +++ > 2 files

Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device

2016-02-22 Thread Andreas Färber
Am 22.02.2016 um 08:47 schrieb David Gibson: > On Mon, Feb 22, 2016 at 07:44:40AM +0100, Andreas Färber wrote: >> Am 22.02.2016 um 06:01 schrieb Bharata B Rao: >>> sPAPR CPU core device is a container of CPU thread devices. CPU hotplug is >>> performed in the gra

Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device

2016-02-22 Thread Andreas Färber
Am 22.02.2016 um 09:05 schrieb Bharata B Rao: > On Mon, Feb 22, 2016 at 07:44:40AM +0100, Andreas Färber wrote: >> Am 22.02.2016 um 06:01 schrieb Bharata B Rao: >>> sPAPR CPU core device is a container of CPU thread devices. CPU hotplug is >>> performed in the gra

Re: [Qemu-devel] [RFC PATCH v0 0/8] cpu-package hotplug

2016-02-22 Thread Andreas Färber
Hi Bharata, Am 22.02.2016 um 06:01 schrieb Bharata B Rao: > This is an attempt to implement David Gibson's RFC that was posted at > https://lists.gnu.org/archive/html/qemu-ppc/2016-02/msg0.html > I am not sure if I have followed all the aspects of the RFC fully, but we > can make changes

Re: [Qemu-devel] [RFC PATCH v0 4/8] spapr: Introduce CPU core device

2016-02-21 Thread Andreas Färber
Am 22.02.2016 um 06:01 schrieb Bharata B Rao: > sPAPR CPU core device is a container of CPU thread devices. CPU hotplug is > performed in the granularity of CPU core device by setting the "realized" > property of this device to "true". When hotplugged, CPU core creates CPU > thread devices. > >

Re: [Qemu-devel] [PATCH v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-02-19 Thread Andreas Färber
Am 18.02.2016 um 10:56 schrieb Markus Armbruster: > Alistair Francis writes: > >> If the device being added when running qdev_device_add() has >> a reset function, register it so that it can be called. >> >> Signed-off-by: Alistair Francis

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-16 Thread Andreas Färber
Am 16.02.2016 um 13:35 schrieb Markus Armbruster: > Igor Mammedov writes: > >> On Mon, 15 Feb 2016 20:43:41 +0100 >> Markus Armbruster wrote: >> >>> Igor Mammedov writes: >>> it will allow mgmt to query present and possible to

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Andreas Färber
yushko <alek...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Paolo Bonzini <pbonz...@redhat.com> > CC: Richard Henderson <r...@twiddle.net> > CC: Eduardo Habkost <ehabk...@redhat.com> > CC: "Andreas Färber" <afaer...@suse

[Qemu-devel] [PATCH] qdev: Start disentangling bus from device

2016-02-12 Thread Andreas Färber
Move bus type and related APIs to a separate file bus.c. This is a first step in breaking up qdev.c into more manageable chunks. Signed-off-by: Andreas Färber <afaer...@suse.de> --- Here's a first step in breaking up qdev.c, originally prepared as part of my QOM device reset refac

Re: [Qemu-devel] [PATCH 1/1] hyperv: cpu hotplug fix with HyperV enabled

2016-02-12 Thread Andreas Färber
Am 12.02.2016 um 12:08 schrieb Denis V. Lunev: > On 02/12/2016 02:00 PM, Andreas Färber wrote: >> Am 11.02.2016 um 21:19 schrieb Denis V. Lunev: >>> From: "Alexey V. Kostyushko" <alek...@virtuozzo.com> >>> >>> With Hyper-V enabled CPU

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-12 Thread Andreas Färber
dhat.com> writes: >>>> >>>>> On Thu, Feb 04, 2016 at 12:55:22PM +0100, Paolo Bonzini wrote: >>>>>> >>>>>> >>>>>> On 04/02/2016 12:41, Andreas Färber wrote: >>>>>>> You're talking about m

Re: [Qemu-devel] [PATCH RFC] qmp, target-i386: device_list_properties for TYPE_CPU

2016-02-12 Thread Andreas Färber
ed with QMP interface and > with -device core2duo-x86_64-cpu,help command line. > > Signed-off-by: Valentin Rakush <valentin.rak...@gmail.com> > Cc: Luiz Capitulino <lcapitul...@redhat.com> > Cc: Eric Blake <ebl...@redhat.com> > Cc: Markus Armbruster <arm...@redh

[Qemu-devel] [PATCH] MAINTAINERS: Drop target-i386 from CPU subsystem

2016-02-12 Thread Andreas Färber
. Cc: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 02710f8..c9b5893 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1032,7 +1032,6 @@ M: Andreas F

Re: [Qemu-devel] [PATCH 01/14] cpu: Clean up includes

2016-02-12 Thread Andreas Färber
Am 09.02.2016 um 16:24 schrieb Peter Maydell: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > qom/cpu.c

Re: [Qemu-devel] KVH call for agenda for 2016-02-16

2016-02-12 Thread Andreas Färber
Am 10.02.2016 um 16:48 schrieb Christian Borntraeger: > On 02/10/2016 04:42 PM, Juan Quintela wrote: >> Please, send any topic that you are interested in covering. >> >> At the end of Monday I will send an email with the agenda or the >> cancellation of the call, so hurry up. >> >> After

Re: [Qemu-devel] [PATCH] target-arm: Fix MDCCSR_EL0 instruction encoding

2016-02-10 Thread Andreas Färber
Am 09.02.2016 um 21:57 schrieb Dirk Müller: > See C5.1.5 of the ARMv8 Reference Manual > > Signed-off-by: Dirk Mueller <dmuel...@suse.com> Reviewed-by: Andreas Färber <afaer...@suse.de> Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Fe

Re: [Qemu-devel] [PATCH] target-arm: Implement DBGDTRRX_EL0/DBGDTRTX_EL0 MSR

2016-02-10 Thread Andreas Färber
Hi Andreas, Am 09.02.2016 um 21:59 schrieb Dirk Müller: > This is used by the ARM JTAG DCC console in the Linux kernel, > but can be ignored in order to continue booting. > > Co-Authored-By: Andreas Schwab If this was co-authored by you, we need a proper Signed-off-by please.

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

2016-02-10 Thread Andreas Färber
Am 10.02.2016 um 16:28 schrieb David Hildenbrand: > For x86, cpu models are realized by making x86_64-cpu an abstract class and > creating loads of new classes, e.g. host-x86_64-cpu or haswell-x86_64-cpu. > > How does 'device_add ' play together with the x86 cpu model > approach? And with cpu

Re: [Qemu-devel] qdev & hw/core owner? (was Re: [PATCH v19 7/9] machine: add properties to compat_props incrementaly)

2016-02-04 Thread Andreas Färber
Am 04.02.2016 um 12:31 schrieb Paolo Bonzini: > On 03/02/2016 20:06, Michael S. Tsirkin wrote: >> On Wed, Feb 03, 2016 at 03:55:04PM -0200, Eduardo Habkost wrote: >>> On Thu, Jan 28, 2016 at 06:00:31PM +0100, Igor Mammedov wrote: >>> [...] It looks like this series might go nowhere but this

Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support

2016-02-02 Thread Andreas Färber
Am 02.02.2016 um 14:36 schrieb Markus Armbruster: > Gerd Hoffmann writes: > >> This patch marks usb-bot as hot-pluggable device, makes attached >> property settable and turns off auto-attach in case the device >> was hotplugged. >> >> Hot-plugging a usb-bot device with one or

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Andreas Färber
Am 03.02.2016 um 00:38 schrieb Eric Blake: > On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >> The QMP monitor code has two helper methods object_add >> and qmp_object_del that are called from several places >> in the code (QMP, HMP and main emulator startup). >> >> The HMP and main emulator

Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types

2016-02-02 Thread Andreas Färber
Am 02.02.2016 um 13:57 schrieb Daniel P. Berrange: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). > > The HMP and main emulator startup code also share > further logic that

[Qemu-devel] [PULL 1/3] qom: Allow properties to be registered against classes

2016-01-18 Thread Andreas Färber
t as an exercise for the future. There is no equivalent to object_property_del() provided, since classes must be immutable once they are defined. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h |

[Qemu-devel] [PULL 0/3] QOM devices patch queue 2016-01-18

2016-01-18 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Daniel P. Berrange Cc: Markus Armbruster Cc: Paolo Bonzini The following changes since commit

[Qemu-devel] [PULL v2 1/4] qom: Allow properties to be registered against classes

2016-01-18 Thread Andreas Färber
t as an exercise for the future. There is no equivalent to object_property_del() provided, since classes must be immutable once they are defined. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- include/qom/object.h |

[Qemu-devel] [PULL v2 2/4] qom: Change object property iterator API contract

2016-01-18 Thread Andreas Färber
used ObjectPropertyIterator struct with typedef] Signed-off-by: Andreas Färber <afaer...@suse.de> --- hw/ppc/spapr_drc.c | 7 +++ include/qom/object.h | 30 ++ net/filter.c | 7 +++ qmp.c | 14 ++-

[Qemu-devel] [PULL v2 3/4] qdev: Free QemuOpts when the QOM path goes away

2016-01-18 Thread Andreas Färber
o plug this other bug. Character devices also have yet to be fixed. Reported-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Andreas Färber <afaer...@suse.de> --- h

[Qemu-devel] [PULL v2 4/4] MAINTAINERS: Fix sPAPR entry heading

2016-01-18 Thread Andreas Färber
sPAPR in MAINTAINERS file"). Cc: David Gibson <da...@gibson.dropbear.id.au> Signed-off-by: Andreas Färber <afaer...@suse.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8f44dca..4030e27 100644 --- a/MAINTAINERS +++ b/MAINTA

[Qemu-devel] [PULL v2 0/4] QOM devices patch queue 2016-01-18

2016-01-18 Thread Andreas Färber
Device hot-unplug ID race fix ------------ Andreas Färber (1): MAINTAINERS: Fix sPAPR entry heading Daniel P. Berrange (2): qom: Allow properties to be registered against classes qom: Change object property iterator API contract Paolo Bonzini (1): qdev: Free QemuOpts when the QO

Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysbusDeviceFunc

2016-01-18 Thread Andreas Färber
Am 18.01.2016 um 05:39 schrieb David Gibson: > Functions of type FindSysbusDeviceFunc currently return an integer. I > recently made an error in a patch because I assumed that this return value > would control whether iteration of the function across devices continues > or not. In fact, the

Re: [Qemu-devel] [PATCH] cpu: Clean up includes

2016-01-18 Thread Andreas Färber
Am 18.01.2016 um 18:35 schrieb Peter Maydell: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > qom/cpu.c

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2016-01-15 Thread Andreas Färber
Am 05.11.2015 um 13:47 schrieb Markus Armbruster: > Paolo Bonzini <pbonz...@redhat.com> writes: >> On 05/11/2015 13:06, Andreas Färber wrote: >>>> 1. Wouldn't it be cleaner to delete dev-opts *before* sending >>>>DEVICE_DELETED? Like t

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2016-01-15 Thread Andreas Färber
Am 15.01.2016 um 18:16 schrieb Paolo Bonzini: > On 15/01/2016 18:03, Andreas Färber wrote: >> Am 05.11.2015 um 13:47 schrieb Markus Armbruster: >>> Paolo Bonzini <pbonz...@redhat.com> writes: >>>> On 05/11/2015 13:06, Andreas Färber wrote: >>>>

Re: [Qemu-devel] [PATCH 1/2] qom: add object_class_get_instance_size()

2016-01-11 Thread Andreas Färber
Am 18.12.2015 um 16:30 schrieb Igor Mammedov: > it will be used for allocating memory for a to be > created new object in safe manner. > > Signed-off-by: Igor Mammedov > --- > include/qom/object.h | 8 > qom/object.c | 5 + > 2 files changed, 13

Re: [Qemu-devel] [PATCH 2/2] qdev: safely fail device_add if unable to allocate device

2016-01-11 Thread Andreas Färber
Am 18.12.2015 um 22:15 schrieb Markus Armbruster: > Eric Blake writes: >> On 12/18/2015 09:48 AM, Daniel P. Berrange wrote: >>> On Fri, Dec 18, 2015 at 04:30:47PM +0100, Igor Mammedov wrote: qdev_device_add() currently uses object_new() which will abort if there

Re: [Qemu-devel] [PATCH v2] qom: change object property iterator API contract

2016-01-11 Thread Andreas Färber
Am 17.12.2015 um 09:54 schrieb Markus Armbruster: > "Daniel P. Berrange" writes: > >> Currently the object property iterator API works as follows >> >> ObjectPropertyIterator *iter; >> >> iter = object_property_iter_init(obj); >> while ((prop =

Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify

2016-01-11 Thread Andreas Färber
Am 11.01.2016 um 18:37 schrieb Markus Armbruster: > Paolo Bonzini writes: >> On 07/01/2016 10:53, Cao jin wrote: >>> On 01/07/2016 05:38 PM, Paolo Bonzini wrote: On 06/01/2016 14:43, Cao jin wrote: These functions are called in the data path; changes to use

Re: [Qemu-devel] [PATCH] doc: Display i386 CPUID properties

2016-01-04 Thread Andreas Färber
Hi, First of all this should be "target-i386:" and CC'ing Eduardo, too. Also I think you meant "X86CPU properties". This is not documentation. Am 04.01.2016 um 08:18 schrieb Valentin Rakush: > When user invokes 'qemu -cpu help' all _features_ for CPUIDs are > printed in stdout. In case of

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-16 Thread Andreas Färber
Am 15.12.2015 um 06:27 schrieb Zhu Guihua: > >>> and allow individual targets to use its own way to build CPUs? >>> >>> For initial conversion of x86-cpus to device-add we could do pretty >>> much the same like we do now, where cpu devices will appear under: >>> /machine (pc-i440fx-2.5-machine)

  1   2   3   4   5   6   7   8   9   10   >