[PATCH v3 3/3] tests/qtest/x86: check for availability of older cpu models before running tests

2024-06-05 Thread Ani Sinha
void as FeatureTestArgs* was not used by the caller. One minor correction. Replaced 'phenom' with '486' in the test 'x86/cpuid/auto-level/phenom/arat' matching the cpu used. CC: th...@redhat.com CC: imamm...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/test-x86-cpuid-compat.c | 170

[PATCH v3 0/3] x86 cpu test refactoring

2024-06-05 Thread Ani Sinha
...@redhat.com Ani Sinha (3): qtest/x86/numa-test: do not use the obsolete 'pentium' cpu tests/qtest/libqtest: add qtest_has_cpu() api tests/qtest/x86: check for availability of older cpu models before running tests tests/qtest/libqtest.c | 84 +++ tests/qtest/libqtest.h

[PATCH v3 1/3] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-05 Thread Ani Sinha
'pentium' cpu is old and obsolete and should be avoided for running tests if its not strictly needed. Use 'max' cpu instead for generic non-cpu specific numa test. CC: th...@redhat.com Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Signed-off-by: Ani Sinha --- tests/qtest/numa-test.c | 3

[PATCH 2/3] tests/qtest/libqtest: add qtest_has_cpu() api

2024-06-05 Thread Ani Sinha
checking if QEMU actually supported these models. CC: th...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/libqtest.c | 84 ++ tests/qtest/libqtest.h | 8 2 files changed, 92 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest

[PATCH v2 3/3] tests/qtest/x86: check for availability of older cpu models before running tests

2024-06-05 Thread Ani Sinha
'x86/cpuid/auto-level/phenom/arat' matching the cpu used. CC: th...@redhat.com CC: imamm...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/test-x86-cpuid-compat.c | 159 +--- 1 file changed, 98 insertions(+), 61 deletions(-) changelog: v2: reworked as per suggestion

[PATCH 2/3] tests/qtest/libqtest: add qtest_has_cpu() api

2024-06-05 Thread Ani Sinha
checking if QEMU actually supported these models. CC: th...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/libqtest.c | 84 ++ tests/qtest/libqtest.h | 8 2 files changed, 92 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest

[PATCH v3 1/3] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-05 Thread Ani Sinha
'pentium' cpu is old and obsolete and should be avoided for running tests if its not strictly needed. Use 'max' cpu instead for generic non-cpu specific numa test. CC: th...@redhat.com Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Signed-off-by: Ani Sinha --- tests/qtest/numa-test.c | 3

[PATCH v2 0/3] x86 cpu test refactoring

2024-06-05 Thread Ani Sinha
...@redhat.com Ani Sinha (3): qtest/x86/numa-test: do not use the obsolete 'pentium' cpu tests/qtest/libqtest: add qtest_has_cpu() api tests/qtest/x86: check for availability of older cpu models before running tests tests/qtest/libqtest.c | 84 +++ tests/qtest/libqtest.h

[PATCH 3/3] tests/qtest/x86: check for availability of older cpu models before running tests

2024-06-05 Thread Ani Sinha
is placed together. One minor correction. Replaced 'phenom' with '486' in the test 'x86/cpuid/auto-level/phenom/arat' matching the cpu used. CC: th...@redhat.com CC: imamm...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/test-x86-cpuid-compat.c | 214 +--- 1 file changed

[PATCH 0/3] x86 cpu test refactoring

2024-06-05 Thread Ani Sinha
Add a new library api to check for the support of a specific cpu type. Used the new api to check support for some older x86 cpu models before running the tests. CC: th...@redhat.com CC: imamm...@redhat.com CC: qemu-devel@nongnu.org CC: pbonz...@redhat.com CC: lviv...@redhat.com Ani Sinha (3

[PATCH v2 1/3] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-05 Thread Ani Sinha
'pentium' cpu is old and obsolete and should be avoided for running tests if its not strictly needed. Use 'max' cpu instead for generic non-cpu specific numa test. CC: th...@redhat.com Reviewed-by: Thomas Huth Signed-off-by: Ani Sinha --- tests/qtest/numa-test.c | 3 ++- 1 file changed, 2

[PATCH 2/3] tests/qtest/libqtest: add qtest_has_cpu() api

2024-06-05 Thread Ani Sinha
checking if QEMU actually supported these models. CC: th...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/libqtest.c | 84 ++ tests/qtest/libqtest.h | 8 2 files changed, 92 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest

[PATCH] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-04 Thread Ani Sinha
'pentium' cpu is old and obsolete and should be avoided for running tests if its not strictly needed. Use 'max' cpu instead for generic non-cpu specific numa test. CC: th...@redhat.com Signed-off-by: Ani Sinha --- tests/qtest/numa-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH RFC v3 00/49] Add AMD Secure Nested Paging (SEV-SNP) support

2024-04-18 Thread Ani Sinha
> On 20 Mar 2024, at 14:08, Michael Roth wrote: > > These patches implement SEV-SNP base support along with CPUID enforcement > support for QEMU, and are also available at: > > https://github.com/amdese/qemu/commits/snp-v3-rfc > > they are based on top of the following patchset from Paolo:

Re: [PATCH v2 06/10] i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with IGVM

2024-04-04 Thread Ani Sinha
> On 3 Apr 2024, at 16:41, Roy Hopkins wrote: > > When using an IGVM file the configuration of the system firmware is > defined by IGVM directives contained in the file. In this case the user > should not configure any pflash devices. > > This commit skips initialization of the ROM mode when

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-28 Thread Ani Sinha
> On 28 Mar 2024, at 16:04, Ani Sinha wrote: > > > >> On 27 Mar 2024, at 19:43, Roy Hopkins wrote: >> >> On Wed, 2024-03-27 at 18:58 +0530, Ani Sinha wrote: >>> >>> >>>> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: >&g

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-28 Thread Ani Sinha
> On 27 Mar 2024, at 19:43, Roy Hopkins wrote: > > On Wed, 2024-03-27 at 18:58 +0530, Ani Sinha wrote: >> >> >>> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: >>> >>> When using an IGVM file the configuration of the system firmware is >

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-27 Thread Ani Sinha
> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: > > When using an IGVM file the configuration of the system firmware is > defined by IGVM directives contained in the file. Therefore the default > system firmware should not be initialized when an IGVM file has been > provided. > > This commit

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Ani Sinha
gt; Folks who have to use ancient guest that requires ISAPC can still > use older QEMU to play with it. > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > docs/about/deprecated.rst | 7 +++ > hw/i386/pc_piix.c | 1 + > 2 files changed, 8 insertions

Re: [PATCH 0/9] Introduce support for IGVM files

2024-03-20 Thread Ani Sinha
> On 27 Feb 2024, at 20:20, Roy Hopkins wrote: > > Hi everyone, > > This initial patch series submission adds the capability to configure > confidential guests using files that conform to the Independent Guest Virtual > Machine (IGVM) file format. The series is based on the master branch

Re: [PATCH] SMBIOS: fix long lines

2024-03-13 Thread Ani Sinha
> On 13-Mar-2024, at 03:59, Michael S. Tsirkin wrote: > > Break up long lines to fit under 80/90 char limit. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >

Re: [PATCH v5] pc: q35: Bump max_cpus to 4096 vcpus

2024-03-12 Thread Ani Sinha
> On 28-Feb-2024, at 20:03, Ani Sinha wrote: > > Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow > up to 4096 vCPUs") > Linux kernel can support upto a maximum number of 4096 vcpus when MAXSMP is > enabled in the kernel. At p

[PATCH] docs: update copyright date to the year 2024

2024-03-11 Thread Ani Sinha
We are already in the third month of 2024 but the copyright notices still refer to 2023. Update the date to 2024 in documentation and help texts. Cc: peter.mayd...@linaro.org Cc: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha --- docs/conf.py | 2 +- include/qemu/help-texts.h | 2

Re: [PATCH v2 07/20] smbios: avoid mangling user provided tables

2024-03-08 Thread Ani Sinha
> On 08-Mar-2024, at 22:49, Igor Mammedov wrote: > > On Thu, 7 Mar 2024 09:33:17 +0530 > Ani Sinha wrote: > >>> On 06-Mar-2024, at 12:11, Ani Sinha wrote: >>> >>> >>> >>> On Tue, 5 Mar 2024, Igor Mammedov wrote: >>>

[PATCH v2] docs/acpi/bits: add some clarity and details while also improving formating

2024-03-07 Thread Ani Sinha
Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. Also improve the formating of the document while at it. CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha --- docs/devel/acpi-bits.rst | 55

[PATCH] docs/acpi/bits: add some clarity and details and improve formating

2024-03-07 Thread Ani Sinha
Update bios-bits docs to add more details on why a pre-OS environment for testing bioses is useful. Add author's FOSDEM talk link. CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha --- docs/devel/acpi-bits.rst | 55 1 file changed, 39 insertions

Re: [PATCH v2 07/20] smbios: avoid mangling user provided tables

2024-03-06 Thread Ani Sinha
> On 06-Mar-2024, at 12:11, Ani Sinha wrote: > > > > On Tue, 5 Mar 2024, Igor Mammedov wrote: > >> currently smbios_entry_add() preserves internally '-smbios type=' >> options but tables provided with '-smbios file=' are stored directly >> into blob t

Re: [PATCH v2 20/20] tests: acpi: update expected SSDT.dimmpxm blob

2024-03-06 Thread Ani Sinha
i440fx as well? > > Expected diff: > > -Name (MEMA, 0x07FFE000) > +Name (MEMA, 0x07FFF000) > > Signed-off-by: Igor Mammedov Acked-by: Ani Sinha > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > tests/data/acpi/q35/SSDT.dimmpxm| Bin 181

Re: [PATCH v2 18/20] tests: acpi/smbios: whitelist expected blobs

2024-03-06 Thread Ani Sinha
> On 05-Mar-2024, at 21:27, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov Acked-by: Ani Sinha > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > b/t

Re: [PATCH v2 17/20] smbios: clear smbios_type4_count before building tables

2024-03-05 Thread Ani Sinha
> On 05-Mar-2024, at 21:27, Igor Mammedov wrote: > > it will help to keep type 4 tables accounting correct in case > SMBIOS tables are built multiple times. I suggest you arrange this before patch 15 where you are actually calling smbios_get_tables_ep() multiple times. That way there is no

Re: [PATCH v2 11/20] smbios: build legacy mode code only for 'pc' machine

2024-03-05 Thread Ani Sinha
dulo that, > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > v2: > moved type0/type1/have_binfile_bitmap/have_fields_bitmap rename into > a separate patch > --- > include/hw/firmware/smbios.h | 5 + > hw/i386/Kconfig| 1 + > hw/sm

Re: [PATCH v2 10/20] smbios: rename/expose structures/bitmaps used by both legacy and modern code

2024-03-05 Thread Ani Sinha
e. > > Doing it as a separate patch to avoid rename cluttering follow-up > patch which will move legacy code into a separate file. > I checked that after application of this patch in the patcset, QEMU build goes through fine. Therefore, > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha &

Re: [PATCH v2 09/20] smbios: add smbios_add_usr_blob_size() helper

2024-03-05 Thread Ani Sinha
> On 05-Mar-2024, at 21:27, Igor Mammedov wrote: > > it will be used by follow up patch when legacy handling > is moved out into a separate file. > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 18 ++ > 1

Re: [PATCH v2 07/20] smbios: avoid mangling user provided tables

2024-03-05 Thread Ani Sinha
on-legacy SMBIOS tables. > > Signed-off-by: Igor Mammedov > Tested-by: Fiona Ebner Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 179 +++-- > 1 file changed, 92 insertions(+), 87 deletions(-) > > diff --git a/hw/smbios/smbios

Re: [PATCH 18/19] pc/q35: set SMBIOS entry point type to 'auto' by default

2024-03-05 Thread Ani Sinha
> Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > hw/i386/pc.c | 2 +- > hw/i386/pc_piix.c | 4 > hw/i386/pc_q35.c | 3 +++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 56562e7d9e..2f69dfd0a8

Re: [PATCH 15/19] smbios: error out when building type 4 table is not possible

2024-03-05 Thread Ani Sinha
t; This will help caller to decide if it should fallback to > SMBIOSv3 when smbios-entry-point-type='auto' > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 13/19] smbios: extend smbios-entry-point-type with 'auto' value

2024-03-05 Thread Ani Sinha
On Tue, 27 Feb 2024, Igor Mammedov wrote: > later patches will use it to pick SMBIOS version at runtime > depending on configuration. > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > qapi/machine.json | 5 - > 1 file changed, 4 insertions(+), 1

Re: [PATCH 12/19] get rid of global smbios_ep_type

2024-03-05 Thread Ani Sinha
build is fine, Reviewed-by: Ani Sinha > --- > hw/i386/fw_cfg.h | 3 ++- > include/hw/firmware/smbios.h | 5 +++-- > hw/arm/virt.c| 4 ++-- > hw/i386/fw_cfg.c | 8 > hw/i386/pc.c | 2 +- > hw/loongarch/

Re: [PATCH 14/19] smbios: in case of entry point is 'auto' try to build v2 tables 1st

2024-03-04 Thread Ani Sinha
g but there is nothing > QEMU can do here, so go and aks Microsoft to real fix). > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 52 +++--- > 1 file changed, 49 insertions(+), 3 deletions(-) > >

Re: [PATCH 11/19] smbios: clear smbios_tables pointer after freeing

2024-03-04 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > that will avoid double free if smbios_get_tables() is called > multiple times. > > Signed-off-by: Igor Mammedov Maybe we can squash this with patch 10. Other than that, Reviewed-by: Ani Sinha > --- > hw/sm

Re: [PATCH 10/19] smbios: handle errors consistently

2024-03-04 Thread Ani Sinha
> On 04-Mar-2024, at 19:09, Igor Mammedov wrote: > > On Mon, 4 Mar 2024 16:44:34 +0530 (IST) > Ani Sinha wrote: > >> On Tue, 27 Feb 2024, Igor Mammedov wrote: >> >>> Current code uses mix of error_report()+exit(1) >>> and error_setg() to handle

Re: [PATCH 10/19] smbios: handle errors consistently

2024-03-04 Thread Ani Sinha
MBIOS3.x tables/entrypoint > in follow up patch. > > Signed-off-by: Igor Mammedov Other than the nit below, Reviewed-by: Ani Sinha > --- > include/hw/firmware/smbios.h | 4 ++-- > hw/i386/fw_cfg.c | 3 ++- > hw/smbios/smbios.c | 32 +

Re: [PATCH 09/19] smbios: build legacy mode code only for 'pc' machine

2024-03-04 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > basically moving code around without functional change. > And exposing some symbols so that they could be shared > between smbbios.c and new smbios_legacy.c > > plus some meson magic to build smbios_legacy.c only > for 'pc' machine and

Re: [PATCH 07/19] smbios: avoid mangling user provided tables

2024-03-04 Thread Ani Sinha
On Tue, 27 Feb 2024, Igor Mammedov wrote: > currently smbios_entry_add() preserves internally '-smbios type=' > options but tables provided with '-smbios file=' are stored directly > into blob that eventually will be exposed to VM. And then later > QEMU adds default/'-smbios type' entries on

Re: [PATCH 08/19] smbios: don't check type4 structures in legacy mode

2024-03-03 Thread Ani Sinha
ables broken > since SeaBIOS doesn't expect that. > > Rather than trying to add support for type4 to legacy code > (both QEMU and SeaBIOS), simplify smbios_get_table_legacy() > by dropping not relevant check in legacy code and error out > on type4 blob. > > Signed-off-by: Ig

Re: [PATCH 06/19] smbios: get rid of smbios_legacy global

2024-03-01 Thread Ani Sinha
> On 29-Feb-2024, at 19:59, Igor Mammedov wrote: > > On Thu, 29 Feb 2024 16:23:21 +0530 > Ani Sinha wrote: > >>> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: >>> >>> clean up smbios_set_defaults() which is reused by legacy >>> and non

Re: [PATCH 06/19] smbios: get rid of smbios_legacy global

2024-02-29 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > clean up smbios_set_defaults() which is reused by legacy > and non legacy machines from being aware of 'legacy' notion > and need to turn it off. And push legacy handling up to > PC machine code where it's relevant. > > Signed-off-by: Igor

Re: [PATCH 05/19] smbios: get rid of smbios_smp_sockets global

2024-02-28 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > it makes smbios_validate_table() independent from > smbios_smp_sockets global, which in turn lets > smbios_get_tables() avoid using not related legacy code. > Good cleanup! > Signed-off-by: Igor Mammedov R

[PATCH v5] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-28 Thread Ani Sinha
. Berrangé Reviewed-by: Igor Mammedov Reviewed-by: Gerd Hoffmann Signed-off-by: Ani Sinha --- hw/i386/pc_q35.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Changelog: v5: mention the PRs in the commit message. Add tags. v4: tweaked commit message as per suggestion from danpb explicit

Re: [PATCH 03/19] tests: smbios: add test for legacy mode CLI options

2024-02-28 Thread Ani Sinha
hat it > ain't broken during SMBIOS code refactoring. > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > tests/data/smbios/type11_blob.legacy | Bin 0 -> 10 bytes > tests/qtest/bios-tables-test.c | 17 + > 2 files changed, 17 inserti

Re: [PATCH v4] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-28 Thread Ani Sinha
> On 28-Feb-2024, at 17:12, Gerd Hoffmann wrote: > > On Wed, Feb 21, 2024 at 07:32:27PM +0530, Ani Sinha wrote: >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow >> up to 4096 vCPUs") >> Linux kernel can support upto a max

Re: [PATCH 04/19] smbios: cleanup smbios_get_tables() from legacy handling

2024-02-28 Thread Ani Sinha
Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > hw/i386/fw_cfg.c | 1 + > hw/smbios/smbios.c | 6 -- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c > index 98a478c276..a635234e68 100644 > --- a/hw/

Re: [PATCH 03/19] tests: smbios: add test for legacy mode CLI options

2024-02-28 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > Unfortunately having 2.0 machine type deprecated is not enough > to get rid of legacy SMBIOS handling since 'isapc' also uses > that and it's staying around. > > Hence add test for CLI options handling to be sure that it > ain't broken

Re: [PATCH 02/19] tests: smbios: add test for -smbios type=11 option

2024-02-28 Thread Ani Sinha
> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov Empty description is not nice. Other than that, Reviewed-by: Ani Sinha > --- > tests/data/smbios/type11_blob | Bin 0 -> 11 bytes > tests/qtest/bios-tables-test.c | 17 ++

Re: [PATCH 01/19] tests: smbios: make it possible to write SMBIOS only test

2024-02-28 Thread Ani Sinha
PI dependency and use that for testing SMBIOS. > > As the 1st user add "acpi/piix4/smbios-options" test case. > > Signed-off-by: Igor Mammedov Reviewed-by: Ani Sinha > --- > tests/qtest/bios-tables-test.c | 47 +++--- > 1 file changed, 38 inserti

[PATCH v4] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-21 Thread Ani Sinha
(1024) Cc: Daniel P. Berrangé Cc: Igor Mammedov Cc: Michael S. Tsirkin Cc: Julia Suvorova Cc: kra...@redhat.com Reviewed-by: Daniel P. Berrangé Signed-off-by: Ani Sinha --- hw/i386/pc_q35.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Changelog: v4: tweaked commit message as per

Re: [PATCH v3] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-20 Thread Ani Sinha
> On 20-Feb-2024, at 21:46, Gerd Hoffmann wrote: > > On Tue, Feb 20, 2024 at 03:50:57PM +, Daniel P. Berrangé wrote: >> On Tue, Feb 20, 2024 at 09:12:04PM +0530, Ani Sinha wrote: >>> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS t

[PATCH v3] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-20 Thread Ani Sinha
ted (1728) exceeds the recommended cpus supported by KVM (12) Number of SMP cpus requested (1728) exceeds the maximum cpus supported by KVM (1024) Cc: Daniel P. Berrangé Cc: Igor Mammedov Cc: Michael S. Tsirkin Cc: Julia Suvorova Cc: kra...@redhat.com Signed-off-by: Ani Sinha --- hw/i386/pc

Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-02-11 Thread Ani Sinha
> On 31-Jan-2024, at 17:24, Gerd Hoffmann wrote: > > On Wed, Jan 31, 2024 at 08:19:06AM +0530, Ani Sinha wrote: > >> This error exists only with edk2. Seabios currently can boot a linux guest >> fine with 4096 vcpus. Since the lowest common denominator for a working

Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Ani Sinha
On Wed, Jan 31, 2024 at 9:27 AM Zhao Liu wrote: > > Hi Ani, > > On Wed, Jan 31, 2024 at 08:19:06AM +0530, Ani Sinha wrote: > > Date: Wed, 31 Jan 2024 08:19:06 +0530 > > From: Ani Sinha > > Subject: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus > > X-Mailer:

[PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Ani Sinha
8) exceeds the recommended cpus supported by KVM (12) Number of SMP cpus requested (1728) exceeds the maximum cpus supported by KVM (1024) Cc: Daniel P. Berrangé Cc: Igor Mammedov Cc: Michael S. Tsirkin Cc: Julia Suvorova Cc: kra...@redhat.com Signed-off-by: Ani Sinha --- hw/i386/pc_q35.c | 3 ++- 1 file

Re: [PATCH v2 3/3] hw/arm: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:07, Greg Kurz wrote: > > error_printf() doesn't add newlines. > > Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-a

Re: [PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:17, Daniel P. Berrangé wrote: > > On Tue, Jan 30, 2024 at 10:14:28PM +0530, Ani Sinha wrote: >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow >> up to 4096 vCPUs") >> Linux kernel can support upt

Re: [PATCH v2 1/3] hw/i386: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:07, Greg Kurz wrote: > > error_printf() doesn't add newlines. > > Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-

Re: [PATCH v2 2/3] hw/loongarch: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:07, Greg Kurz wrote: > > error_printf() doesn't add newlines. > > Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha > --- > hw/loongarch/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/loongar

[PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Ani Sinha
8) exceeds the recommended cpus supported by KVM (12) Number of SMP cpus requested (1728) exceeds the maximum cpus supported by KVM (1024) Cc: Daniel P. Berrangé Cc: Igor Mammedov Cc: Michael S. Tsirkin Cc: Julia Suvorova Signed-off-by: Ani Sinha --- hw/i386/pc_q35.c | 3 ++- 1 file changed, 2 insert

Re: [PATCH 1/3] hw/i386: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 21:26, Greg Kurz wrote: > > error_fprintf() doesn't add newlines. ^ Should be error_printf(). Ditto for other patches. > > Signed-off-by: Greg Kurz > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2 1/2] hw/smbios: Fix OEM strings table option validation

2024-01-29 Thread Ani Sinha
f93fb0 ("smbios: support setting OEM strings table") > Signed-off-by: Akihiko Odaki > Reviewed-by: Michael Tokarev Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios

Re: [PATCH v2 2/2] hw/smbios: Fix port connector option validation

2024-01-29 Thread Ani Sinha
c56 ("hw/smbios: support for type 8 (port connector)") > Signed-off-by: Akihiko Odaki > Reviewed-by: Michael Tokarev Reviewed-by: Ani Sinha > --- > hw/smbios/smbios.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios

Re: [PULL 03/15] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2024-01-24 Thread Ani Sinha
> On 24-Jan-2024, at 14:28, Igor Mammedov wrote: > > On Fri, 1 Dec 2023 12:15:16 -0500 > "Michael S. Tsirkin" wrote: > >> From: Ani Sinha >> >> When dumping table blobs using rebuild-expected-aml.sh, table blobs from all >> test varian

[PATCH v2] acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOWN event from bits VM

2024-01-16 Thread Ani Sinha
-by: Ani Sinha --- tests/avocado/acpi-bits.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) changelog: v2: cosmetic comment updates in code and patch description. diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py index 68b9e98d4e..efe4f52ee0 100644 --- a/tests

[PATCH] acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOWN event from bits VM

2024-01-16 Thread Ani Sinha
-by: Ani Sinha --- tests/avocado/acpi-bits.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py index 68b9e98d4e..870cd2e36c 100644 --- a/tests/avocado/acpi-bits.py +++ b/tests/avocado/acpi-bits.py @@ -53,7 +53,7

Re: [PATCH 1/2] acpi/tests/avocado/bits: import smilatency test from bits in order to disable it

2024-01-08 Thread Ani Sinha
> On 08-Jan-2024, at 4:28 PM, Peter Maydell wrote: > > On Mon, 8 Jan 2024 at 10:35, Ani Sinha wrote: >> >> Add smilatency test script in the bits avocado tests from bios-bits. No >> changes >> have been made to the original test script. The test will be di

Re: acpiBitsTest.test_acpi_smbios_bits test intermittently times out

2024-01-08 Thread Ani Sinha
> On 07-Jan-2024, at 9:56 PM, Ani Sinha wrote: > > On Sat, Jan 6, 2024 at 5:39 PM Peter Maydell wrote: >> >> On Sat, 6 Jan 2024 at 05:41, Ani Sinha wrote: >>> >>> On Sat, Jan 6, 2024 at 10:05 AM Ani Sinha wrote: >>>> >>>

[PATCH 0/2] acpi/tests/avocado/bits: disable smilatency tests

2024-01-08 Thread Ani Sinha
CC: m...@redhat.com CC: waine...@redhat.com CC: qemu-devel@nongnu.org Ani Sinha (2): acpi/tests/avocado/bits: import smilatency test from bits in order to disable it acpi/tests/avocado/bits: disable smilatency tests .../acpi-bits/bits-tests/smilatency.py2 | 107

[PATCH 1/2] acpi/tests/avocado/bits: import smilatency test from bits in order to disable it

2024-01-08 Thread Ani Sinha
...@redhat.com Signed-off-by: Ani Sinha --- .../acpi-bits/bits-tests/smilatency.py2 | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 tests/avocado/acpi-bits/bits-tests/smilatency.py2 diff --git a/tests/avocado/acpi-bits/bits-tests/smilatency.py2 b/tests

[PATCH 2/2] acpi/tests/avocado/bits: disable smilatency tests

2024-01-08 Thread Ani Sinha
: waine...@redhat.com Signed-off-by: Ani Sinha --- tests/avocado/acpi-bits/bits-tests/smilatency.py2 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/avocado/acpi-bits/bits-tests/smilatency.py2 b/tests/avocado/acpi-bits/bits-tests/smilatency.py2 index 48083bfb0d

[PATCH 1/2] acpi/tests/avocado/bits: import smilatency test from bits in order to disable it

2024-01-08 Thread Ani Sinha
...@redhat.com Signed-off-by: Ani Sinha --- .../acpi-bits/bits-tests/smilatency.py2 | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 tests/avocado/acpi-bits/bits-tests/smilatency.py2 diff --git a/tests/avocado/acpi-bits/bits-tests/smilatency.py2 b/tests

[PATCH 2/2] acpi/tests/avocado/bits: disable smilatency tests

2024-01-08 Thread Ani Sinha
: waine...@redhat.com Signed-off-by: Ani Sinha --- tests/avocado/acpi-bits/bits-tests/smilatency.py2 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/avocado/acpi-bits/bits-tests/smilatency.py2 b/tests/avocado/acpi-bits/bits-tests/smilatency.py2 index 48083bfb0d

Re: acpiBitsTest.test_acpi_smbios_bits test intermittently times out

2024-01-07 Thread Ani Sinha
On Sat, Jan 6, 2024 at 5:39 PM Peter Maydell wrote: > > On Sat, 6 Jan 2024 at 05:41, Ani Sinha wrote: > > > > On Sat, Jan 6, 2024 at 10:05 AM Ani Sinha wrote: > > > > > > On Sat, Jan 6, 2024 at 12:11 AM Peter Maydell > >

Re: acpiBitsTest.test_acpi_smbios_bits test intermittently times out

2024-01-05 Thread Ani Sinha
On Sat, Jan 6, 2024 at 10:05 AM Ani Sinha wrote: > > On Sat, Jan 6, 2024 at 12:11 AM Peter Maydell > wrote: > > > > The avocado test acpiBitsTest.test_acpi_smbios_bits seems to be > > flaky in CI -- sometimes it appears to time out. > > > > https://git

Re: acpiBitsTest.test_acpi_smbios_bits test intermittently times out

2024-01-05 Thread Ani Sinha
On Sat, Jan 6, 2024 at 12:11 AM Peter Maydell wrote: > > The avocado test acpiBitsTest.test_acpi_smbios_bits seems to be > flaky in CI -- sometimes it appears to time out. > > https://gitlab.com/qemu-project/qemu/-/issues/2077 > has the details (including links to jobs etc). Do you have more

Re: [PATCH] pc: q35: Bump max_cpus to 4096

2023-12-13 Thread Ani Sinha
> On 11-Dec-2023, at 11:27 AM, Thomas Huth wrote: > > On 08/12/2023 13.26, Ani Sinha wrote: >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow >> up to 4096 vCPUs") >> Linux kernel can support upto a maximum number of

Re: [PULL 6/6] tests/acpi: disallow tests/data/acpi/virt/SSDT.memhp changes

2023-12-13 Thread Ani Sinha
> On 13-Dec-2023, at 8:47 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 13, 2023 at 04:14:00PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> I agree, Gerd, going forward please include the diff of the >>> disassemled AML. >> >> That is in patch 5/6 which updates the test data. >> >> take

Re: [PULL 6/6] tests/acpi: disallow tests/data/acpi/virt/SSDT.memhp changes

2023-12-13 Thread Ani Sinha
> On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote: >> >> >>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann wrote: >>> >>> Signed-off-by: Gerd Hoffmann >> &g

Re: [PULL 6/6] tests/acpi: disallow tests/data/acpi/virt/SSDT.memhp changes

2023-12-13 Thread Ani Sinha
> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann Please combine this patch with patch 5. No need to do this separately. > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] pc: q35: Bump max_cpus to 4096

2023-12-08 Thread Ani Sinha
> On 08-Dec-2023, at 6:27 PM, Daniel P. Berrangé wrote: > > On Fri, Dec 08, 2023 at 05:56:11PM +0530, Ani Sinha wrote: >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow >> up to 4096 vCPUs") >> Linux kernel can support upt

[PATCH] pc: q35: Bump max_cpus to 4096

2023-12-08 Thread Ani Sinha
ber of SMP cpus requested (4096) exceeds the recommended cpus supported by KVM (12) Number of SMP cpus requested (4096) exceeds the maximum cpus supported by KVM (1024) Cc: Daniel P. Berrangé Cc: Igor Mammedov Cc: Michael S. Tsirkin Cc: Julia Suvorova Signed-off-by: Ani Sinha --- hw/i38

Re: [PULL 03/15] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-12-01 Thread Ani Sinha
> On 01-Dec-2023, at 10:45 PM, Michael S. Tsirkin wrote: > > From: Ani Sinha > > When dumping table blobs using rebuild-expected-aml.sh, table blobs from all > test variants are dumped regardless of whether there are any actual changes to > the tables or not. This cre

Re: [PATCH-for-9.0 v2 5/8] hw: Prefer qdev_prop_set_bit over object_property_set_bool for QDev

2023-11-24 Thread Ani Sinha
audé > --- > hw/acpi/cpu_hotplug.c | 7 +++ > hw/acpi/ich9.c | 4 ++-- > hw/acpi/piix4.c | 4 ++-- For the acpi bits, Reviewed-by: Ani Sinha > hw/arm/armsse.c | 3 +-- > hw/arm/armv7m.c |

Re: [PATCH v2] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-23 Thread Ani Sinha
> On 21-Nov-2023, at 12:39 PM, Ani Sinha wrote: > > > >> On 16-Nov-2023, at 11:30 AM, Ani Sinha wrote: >> >> >> >>> On 07-Nov-2023, at 10:19 AM, Ani Sinha wrote: >>> >>> When dumping table blobs using rebuild-exp

Re: [PATCH v2] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-20 Thread Ani Sinha
> On 16-Nov-2023, at 11:30 AM, Ani Sinha wrote: > > > >> On 07-Nov-2023, at 10:19 AM, Ani Sinha wrote: >> >> When dumping table blobs using rebuild-expected-aml.sh, table blobs from all >> test variants are dumped regardless of whether there are any

Re: [PATCH-for-8.2?] hw/acpi/erst: Do not ignore Error* in realize handler

2023-11-20 Thread Ani Sinha
UARD()"). > > Cc: qemu-sta...@nongnu.org > Fixes: f7e26ffa59 ("ACPI ERST: support for ACPI ERST feature") > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Ani Sinha > --- > hw/acpi/erst.c | 10 ++ > 1 file changed, 10 insertions(+) > >

Re: [PATCH 1/3] tests/avocado: reverse_debugging drain console to prevent hang

2023-11-16 Thread Ani Sinha
> On 16-Nov-2023, at 7:01 PM, Ani Sinha wrote: > > > >> On 16-Nov-2023, at 6:56 PM, Ani Sinha wrote: >> >> >> >>> On 16-Nov-2023, at 5:23 PM, Nicholas Piggin wrote: >>> >>> Like replay_linux.py, reverse_debugging.py starts

Re: [PATCH 1/3] tests/avocado: reverse_debugging drain console to prevent hang

2023-11-16 Thread Ani Sinha
> On 16-Nov-2023, at 6:56 PM, Ani Sinha wrote: > > > >> On 16-Nov-2023, at 5:23 PM, Nicholas Piggin wrote: >> >> Like replay_linux.py, reverse_debugging.py starts the vm with console >> set but does not interact with it (e.g., with wait_for_co

Re: [PATCH 1/3] tests/avocado: reverse_debugging drain console to prevent hang

2023-11-16 Thread Ani Sinha
s and powernv") > Fixes: be52eca30978 ("tests/acceptance: add reverse debugging test") > Tested-by: Thomas Huth > Signed-off-by: Nicholas Piggin Reviewed-by: Ani Sinha mailto:anisi...@redhat.com> <mailto:anisi...@redhat.com>> > --- > tests/avocado/re

Re: [PATCH] tests/avocado/reverse_debugging: Disable the ppc64 tests by default

2023-11-16 Thread Ani Sinha
> On 16-Nov-2023, at 2:25 PM, Daniel P. Berrangé wrote: > > On Thu, Nov 16, 2023 at 05:14:43PM +1000, Nicholas Piggin wrote: >> On Thu Nov 16, 2023 at 1:55 PM AEST, Ani Sinha wrote: >>> >>> >>>> On 16-Nov-2023, at 6:45 AM, Nicholas Piggin wro

Re: [PATCH] tests/avocado/mem-addr-space-check: Replace assertEquals() for Python 3.12

2023-11-16 Thread Ani Sinha
> On 16-Nov-2023, at 12:56 PM, Ani Sinha wrote: > > > >> On 16-Nov-2023, at 11:49 AM, Thomas Huth wrote: >> >> assertEquals() has been removed in Python 3.12 and should be replaced by >> assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.h

Re: [PATCH] tests/avocado/mem-addr-space-check: Replace assertEquals() for Python 3.12

2023-11-15 Thread Ani Sinha
> On 16-Nov-2023, at 11:49 AM, Thomas Huth wrote: > > assertEquals() has been removed in Python 3.12 and should be replaced by > assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3 > > Signed-off-by: Thomas Huth Acked-by: Ani Sinha mailto:a

Re: [PATCH v2] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-15 Thread Ani Sinha
> On 07-Nov-2023, at 10:19 AM, Ani Sinha wrote: > > When dumping table blobs using rebuild-expected-aml.sh, table blobs from all > test variants are dumped regardless of whether there are any actual changes to > the tables or not. This creates lot of new files for variou

  1   2   3   4   5   6   7   8   9   10   >